GitHub/WoltLab/com.woltlab.wcf.conversation.git
2 years agoFix conversation order when being removed from conversation
Tim Düsterhus [Thu, 10 Feb 2022 11:28:20 +0000 (12:28 +0100)]
Fix conversation order when being removed from conversation

When one is removed from a conversation, UserConversationList will use the time
of removal as the conversation's `lastPostTime` when ordering, instead of the
actual time of the newest message to not leak information about new messages
after removal.

However this was not properly accounted for within `readObjectIDs()`. Now if a
conversation one was removed from receives new messages after a long-ish time -
with several conversations in between - the conversation will appear on the
*pageNo* where it would be if one would still be a participant. But within the
page it would be ordered based on the timestamp of removal (i.e. appear at the
very bottom of the page).

Fix this by also overriding `lastPostTime` in `readObjectIDs()`. This will move
the conversation to the proper `pageNo` based on the removal time.

This might still be slightly misleading, because the “last message” column in
the template shows the time of the actual last visible message, but this
confusion can be resolved by opening the conversation and seeing the removal
timestamp matching up, whereas without this fix the conversation can be all
over the place.

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 10 Feb 2022 10:48:57 +0000 (11:48 +0100)]
Merge branch '5.3' into 5.4

2 years agoMerge pull request #170 from WoltLab/remove-participant-last-message-id
Tim Düsterhus [Thu, 10 Feb 2022 10:47:29 +0000 (11:47 +0100)]
Merge pull request #170 from WoltLab/remove-participant-last-message-id

Fix calculation of `lastMessageID` when removing other conversation participants

2 years agoFix calculation of `lastMessageID` when removing other conversation participants
Tim Düsterhus [Thu, 10 Feb 2022 10:33:50 +0000 (11:33 +0100)]
Fix calculation of `lastMessageID` when removing other conversation participants

Without this `ORDER BY` usually the first visible message would've been set as
the `lastMessageID`, as that's the first row within the `conversation_message`
table.

2 years agoMerge branch 'can-reply-can-read' into 5.4
Tim Düsterhus [Wed, 19 Jan 2022 14:35:26 +0000 (15:35 +0100)]
Merge branch 'can-reply-can-read' into 5.4

2 years agoRemove obsolete check for `->canRead()` in ConversationMessageAction::validateContainer()
Tim Düsterhus [Tue, 18 Jan 2022 14:48:22 +0000 (15:48 +0100)]
Remove obsolete check for `->canRead()` in ConversationMessageAction::validateContainer()

2 years agoVerify that the conversation is readable in Conversation::canReply()
Tim Düsterhus [Tue, 18 Jan 2022 14:47:53 +0000 (15:47 +0100)]
Verify that the conversation is readable in Conversation::canReply()

2 years agoUpdate npm dependencies
Tim Düsterhus [Mon, 10 Jan 2022 10:27:45 +0000 (11:27 +0100)]
Update npm dependencies

2 years agoRelease 5.4.10 5.4.10
Alexander Ebert [Wed, 22 Dec 2021 16:28:25 +0000 (17:28 +0100)]
Release 5.4.10

2 years agoRelease 5.4.10 dev 1 5.4.10-dev-1 5.4.10_dev_1
Alexander Ebert [Fri, 17 Dec 2021 16:41:02 +0000 (17:41 +0100)]
Release 5.4.10 dev 1

2 years agoUpdate prettier and typescript
Tim Düsterhus [Mon, 13 Dec 2021 12:47:56 +0000 (13:47 +0100)]
Update prettier and typescript

2 years agoCount drafts for flood control during actual submission
Tim Düsterhus [Fri, 3 Dec 2021 12:59:06 +0000 (13:59 +0100)]
Count drafts for flood control during actual submission

Otherwise a spammer might be able to silently prepare a large number of drafts,
submitting them in bulk when they prepared enough.

3 years agoRemoved the upgrade instructions
Alexander Ebert [Fri, 24 Sep 2021 12:12:34 +0000 (14:12 +0200)]
Removed the upgrade instructions

3 years agoRelease 5.4.8 5.4.8
Alexander Ebert [Fri, 24 Sep 2021 09:15:53 +0000 (11:15 +0200)]
Release 5.4.8

3 years agoMerge branch '5.4' of https://github.com/WoltLab/com.woltlab.wcf.conversation into 5.4
Alexander Ebert [Fri, 24 Sep 2021 07:41:24 +0000 (09:41 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/com.woltlab.wcf.conversation into 5.4

3 years agoRelease 5.4.8 dev 2 5.4.8_dev_2
Alexander Ebert [Fri, 24 Sep 2021 07:41:04 +0000 (09:41 +0200)]
Release 5.4.8 dev 2

3 years agoRun php-cs-fixer using PHP 8.0
Tim Düsterhus [Fri, 24 Sep 2021 07:37:32 +0000 (09:37 +0200)]
Run php-cs-fixer using PHP 8.0

3 years agoMerge pull request #157 from WoltLab/attachment-orphan
Tim Düsterhus [Thu, 23 Sep 2021 11:41:19 +0000 (13:41 +0200)]
Merge pull request #157 from WoltLab/attachment-orphan

Prevent method calls on `null` in ConversationMessageAttachmentObjectType::canDownload()

3 years agoPrevent method calls on `null` in ConversationMessageAttachmentObjectType::canDownload()
Tim Düsterhus [Thu, 23 Sep 2021 10:08:02 +0000 (12:08 +0200)]
Prevent method calls on `null` in ConversationMessageAttachmentObjectType::canDownload()

This may happen for attachments where the corresponding conversation /
conversation message no longer exists.

3 years agoRelease 5.4.8 dev 1 5.4.8_dev_1
Alexander Ebert [Wed, 22 Sep 2021 16:37:02 +0000 (18:37 +0200)]
Release 5.4.8 dev 1

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 22 Sep 2021 16:10:55 +0000 (16:10 +0000)]
Updating minified JavaScript files

3 years agoDisable npm cache in javascript workflow
Tim Düsterhus [Tue, 21 Sep 2021 08:34:23 +0000 (10:34 +0200)]
Disable npm cache in javascript workflow

3 years agoUpdate npm dependencies
Tim Düsterhus [Tue, 21 Sep 2021 08:30:48 +0000 (10:30 +0200)]
Update npm dependencies

3 years agoSkip the JS for invisible participant if the user lacks the permissions
Alexander Ebert [Mon, 20 Sep 2021 16:17:25 +0000 (18:17 +0200)]
Skip the JS for invisible participant if the user lacks the permissions

3 years agoIncorrect check to display the signatur
Alexander Ebert [Mon, 20 Sep 2021 14:50:53 +0000 (16:50 +0200)]
Incorrect check to display the signatur

This check was effectively redundant since 3.0, but worked until a legacy trait was removed in 5.4. This was overlooked and caused signatures to be hidden in 5.4.

Fixes 381191f4f1e26cdfff406e4ac6240c063d816068

3 years agoMerge branch '5.3' into 5.4
Alexander Ebert [Tue, 31 Aug 2021 13:57:56 +0000 (15:57 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Tue, 31 Aug 2021 12:32:58 +0000 (14:32 +0200)]
Merge branch '5.2' into 5.3

3 years agoRelease 5.2.15 5.2.15
Alexander Ebert [Tue, 31 Aug 2021 11:41:53 +0000 (13:41 +0200)]
Release 5.2.15

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 31 Aug 2021 11:30:54 +0000 (13:30 +0200)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.23 3.1.23 3.1.final
Alexander Ebert [Tue, 31 Aug 2021 10:34:34 +0000 (12:34 +0200)]
Release 3.1.23

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 26 Aug 2021 10:34:38 +0000 (12:34 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Aug 2021 10:29:09 +0000 (12:29 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Thu, 26 Aug 2021 10:28:52 +0000 (12:28 +0200)]
Merge branch '3.1' into 5.2

3 years agoUpdating minified JavaScript files
WoltLab [Tue, 24 Aug 2021 09:49:52 +0000 (09:49 +0000)]
Updating minified JavaScript files

3 years agoRelease 5.4.3 5.4.3
Alexander Ebert [Tue, 10 Aug 2021 09:07:55 +0000 (11:07 +0200)]
Release 5.4.3

3 years agoMisleading remark about the comma to separate recipients
Alexander Ebert [Fri, 6 Aug 2021 15:29:59 +0000 (17:29 +0200)]
Misleading remark about the comma to separate recipients

3 years agoRelease 5.4.0 5.4.0
Alexander Ebert [Wed, 14 Jul 2021 15:45:19 +0000 (17:45 +0200)]
Release 5.4.0

3 years agoBad XML 5.4.0_RC_1
Alexander Ebert [Mon, 28 Jun 2021 14:01:22 +0000 (16:01 +0200)]
Bad XML

3 years agoRelease 5.4.0 RC 1
Alexander Ebert [Mon, 28 Jun 2021 13:37:17 +0000 (15:37 +0200)]
Release 5.4.0 RC 1

3 years agoAdd modified PIPs to 5.3 -> 5.4 instructions
Tim Düsterhus [Mon, 28 Jun 2021 08:01:17 +0000 (10:01 +0200)]
Add modified PIPs to 5.3 -> 5.4 instructions

3 years agoRevert "Removed the upgrade support from 5.3.*"
Tim Düsterhus [Mon, 28 Jun 2021 07:58:47 +0000 (09:58 +0200)]
Revert "Removed the upgrade support from 5.3.*"

This reverts commit 0fe90b164697dbb4fc74a86b510a6c3de42406c2.

3 years agoUpdate XSD paths in XML files
Matthias Schmidt [Wed, 23 Jun 2021 07:14:48 +0000 (09:14 +0200)]
Update XSD paths in XML files

See WoltLab/WCF#4268

3 years agoRelease 5.4.0 Beta 2 5.4.0_Beta_2
Alexander Ebert [Wed, 16 Jun 2021 15:26:53 +0000 (17:26 +0200)]
Release 5.4.0 Beta 2

3 years agoMerge branch '5.3' into 5.4
Matthias Schmidt [Tue, 15 Jun 2021 05:54:04 +0000 (07:54 +0200)]
Merge branch '5.3' into 5.4

3 years agoRelease 5.3.8 5.3.8
Alexander Ebert [Mon, 14 Jun 2021 14:47:02 +0000 (16:47 +0200)]
Release 5.3.8

3 years agoUpdating minified JavaScript files
WoltLab [Mon, 14 Jun 2021 13:53:22 +0000 (13:53 +0000)]
Updating minified JavaScript files

3 years agoForce `LF` line endings for generated JavaScript (WoltLab/WCF#4285)
MysteryCode [Mon, 14 Jun 2021 08:30:55 +0000 (10:30 +0200)]
Force `LF` line endings for generated JavaScript (WoltLab/WCF#4285)

The `newLine` configuration option in tsconfig is platform specific. Explicitly set it to ensure consistent behavior.

[Tim: Rephrased the commit message]
[Tim: Adapted to the differing context in non-WoltLab/WCF repositories]

3 years agoAdd workflow for SCSS prettier (#154)
Matthias Schmidt [Thu, 3 Jun 2021 07:42:34 +0000 (09:42 +0200)]
Add workflow for SCSS prettier (#154)

3 years agoAdd 5.4 branch to GitHub workflows
Tim Düsterhus [Mon, 31 May 2021 14:31:06 +0000 (16:31 +0200)]
Add 5.4 branch to GitHub workflows

3 years agoRelease 5.4.0 Beta 1 5.4.0_Beta_1
Alexander Ebert [Wed, 2 Jun 2021 12:58:03 +0000 (14:58 +0200)]
Release 5.4.0 Beta 1

3 years agoIncorrect use of the `<void/>` instruction
Alexander Ebert [Mon, 31 May 2021 14:21:41 +0000 (16:21 +0200)]
Incorrect use of the `<void/>` instruction

3 years agoRelease 5.4.0 Beta 1
Alexander Ebert [Mon, 31 May 2021 13:42:12 +0000 (15:42 +0200)]
Release 5.4.0 Beta 1

3 years agoRemoved the upgrade support from 5.3.*
Alexander Ebert [Mon, 31 May 2021 13:04:10 +0000 (15:04 +0200)]
Removed the upgrade support from 5.3.*

3 years agoUpdate npm dependencies
Tim Düsterhus [Wed, 26 May 2021 09:19:00 +0000 (11:19 +0200)]
Update npm dependencies

3 years agoRelease 5.4.0 Alpha 3 5.4.0_Alpha_3
Alexander Ebert [Thu, 20 May 2021 14:47:29 +0000 (16:47 +0200)]
Release 5.4.0 Alpha 3

3 years agoUpdate npm dependencies
Tim Düsterhus [Tue, 18 May 2021 10:37:40 +0000 (12:37 +0200)]
Update npm dependencies

3 years agoFix code style
Matthias Schmidt [Fri, 14 May 2021 12:31:14 +0000 (14:31 +0200)]
Fix code style

3 years agoMerge branch '5.3'
Matthias Schmidt [Fri, 14 May 2021 12:26:32 +0000 (14:26 +0200)]
Merge branch '5.3'

3 years agoDelete conversations without messages in `ConversationRebuildDataWorker` (#153)
Matthias Schmidt [Fri, 14 May 2021 12:22:55 +0000 (14:22 +0200)]
Delete conversations without messages in `ConversationRebuildDataWorker` (#153)

Close #152

3 years agoPreserve names of method arguments during inheritance
Matthias Schmidt [Fri, 14 May 2021 06:34:06 +0000 (08:34 +0200)]
Preserve names of method arguments during inheritance

See WoltLab/WCF#4211

3 years agoUse/Add explicit `return null;` statement
Matthias Schmidt [Wed, 12 May 2021 10:25:37 +0000 (12:25 +0200)]
Use/Add explicit `return null;` statement

3 years agoRelease 5.4.0 Alpha 2 5.4.0_Alpha_2
Alexander Ebert [Tue, 11 May 2021 14:23:49 +0000 (16:23 +0200)]
Release 5.4.0 Alpha 2

3 years agoUpdate npm dependencies
Tim Düsterhus [Tue, 11 May 2021 13:23:11 +0000 (15:23 +0200)]
Update npm dependencies

3 years agoFix typo in method documentation
Matthias Schmidt [Tue, 11 May 2021 08:07:23 +0000 (10:07 +0200)]
Fix typo in method documentation

3 years agoAdd `@method` comment for `DatabaseObjectList::getSingleObject()` in subclasses
Matthias Schmidt [Tue, 11 May 2021 06:38:20 +0000 (08:38 +0200)]
Add `@method` comment for `DatabaseObjectList::getSingleObject()` in subclasses

3 years agoRemove duplicate user ids before using local variable in `ConversationPage`
Matthias Schmidt [Thu, 6 May 2021 12:20:44 +0000 (14:20 +0200)]
Remove duplicate user ids before using local variable in `ConversationPage`

3 years agoRelease 5.4.0 Alpha 1 5.4.0_Alpha_1
Alexander Ebert [Wed, 5 May 2021 09:46:06 +0000 (11:46 +0200)]
Release 5.4.0 Alpha 1

3 years agoPin `php-cs-fixer` version in codestyle workflow
Matthias Schmidt [Tue, 4 May 2021 08:52:05 +0000 (10:52 +0200)]
Pin `php-cs-fixer` version in codestyle workflow

3 years agoUse null coalescing operator wherever possible
Matthias Schmidt [Fri, 30 Apr 2021 05:54:33 +0000 (07:54 +0200)]
Use null coalescing operator wherever possible

3 years agoUpdate update instructions
Matthias Schmidt [Fri, 30 Apr 2021 05:50:25 +0000 (07:50 +0200)]
Update update instructions

3 years agoRemove obsolete delete instruction for template listeners
Matthias Schmidt [Thu, 29 Apr 2021 12:18:24 +0000 (14:18 +0200)]
Remove obsolete delete instruction for template listeners

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 28 Apr 2021 15:13:47 +0000 (15:13 +0000)]
Updating minified JavaScript files

3 years agoAdd explicit `return null;` statements
Matthias Schmidt [Tue, 27 Apr 2021 12:59:18 +0000 (14:59 +0200)]
Add explicit `return null;` statements

3 years agoMerge branch '5.3'
Matthias Schmidt [Mon, 26 Apr 2021 14:37:58 +0000 (16:37 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 26 Apr 2021 14:37:50 +0000 (16:37 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Mon, 26 Apr 2021 14:37:39 +0000 (16:37 +0200)]
Merge branch '3.1' into 5.2

3 years agoFix title of data section when editing conversation label
Matthias Schmidt [Mon, 26 Apr 2021 14:37:24 +0000 (16:37 +0200)]
Fix title of data section when editing conversation label

Close #151

3 years agoRemove unused import
Matthias Schmidt [Mon, 26 Apr 2021 09:51:37 +0000 (11:51 +0200)]
Remove unused import

3 years agoImprove IDE recognition of variable types
Matthias Schmidt [Mon, 26 Apr 2021 09:48:52 +0000 (11:48 +0200)]
Improve IDE recognition of variable types

3 years agoCorrectly take user ignore types into account
Tim Düsterhus [Fri, 23 Apr 2021 08:59:57 +0000 (10:59 +0200)]
Correctly take user ignore types into account

see WoltLab/WCF#3981
see WoltLab/WCF#4064

3 years agoAdd language PIP to update instructions
Tim Düsterhus [Thu, 22 Apr 2021 15:26:44 +0000 (17:26 +0200)]
Add language PIP to update instructions

3 years agoUse `UserUtil::getIpAddress()` instead of deprecated `SessionHandler::$ipAddress`
Matthias Schmidt [Thu, 22 Apr 2021 13:29:31 +0000 (15:29 +0200)]
Use `UserUtil::getIpAddress()` instead of deprecated `SessionHandler::$ipAddress`

See WoltLab/WCF#3593

3 years agoSet-up php-cs-fixer using setup-php in codestyle workflow
Tim Düsterhus [Mon, 19 Apr 2021 12:13:48 +0000 (14:13 +0200)]
Set-up php-cs-fixer using setup-php in codestyle workflow

This allows us to easily install extensions.

3 years agoEnable new RSS feed dialog
Matthias Schmidt [Mon, 19 Apr 2021 12:43:23 +0000 (14:43 +0200)]
Enable new RSS feed dialog

See WoltLab/WCF#4123

3 years agoUse new `lineBreakSeparatedText` option type
Matthias Schmidt [Sat, 17 Apr 2021 15:23:09 +0000 (17:23 +0200)]
Use new `lineBreakSeparatedText` option type

See WoltLab/WCF#4126
See WoltLab/WCF#4128

3 years agoUpdating minified JavaScript files
WoltLab [Thu, 15 Apr 2021 07:11:41 +0000 (07:11 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 14 Apr 2021 09:55:42 +0000 (11:55 +0200)]
Merge branch '5.3'

3 years agoRelease 5.3.6 5.3.6
Alexander Ebert [Mon, 12 Apr 2021 13:00:18 +0000 (15:00 +0200)]
Release 5.3.6

3 years agoUse consistent title for flood control delay time
Matthias Schmidt [Sun, 11 Apr 2021 15:43:46 +0000 (17:43 +0200)]
Use consistent title for flood control delay time

See WoltLab/WCF#3801

3 years agoConsistently use "entered" in English phrases instead of "given"
Matthias Schmidt [Sun, 11 Apr 2021 11:05:19 +0000 (13:05 +0200)]
Consistently use "entered" in English phrases instead of "given"

See WoltLab/WCF#3801

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 31 Mar 2021 13:34:11 +0000 (15:34 +0200)]
Merge branch '5.3'

3 years agoRedirect to GET request after using the participant filter
Marcel Werk [Tue, 30 Mar 2021 17:11:03 +0000 (19:11 +0200)]
Redirect to GET request after using the participant filter

3 years agoUpdate `Ui/Object/Action` implementation
Matthias Schmidt [Tue, 30 Mar 2021 13:42:13 +0000 (15:42 +0200)]
Update `Ui/Object/Action` implementation

See WoltLab/WCF@afc2ab81100a477e2fa1d92783837f6e064a8af6

3 years agoRecompile TypeScript code
Matthias Schmidt [Thu, 25 Mar 2021 13:43:02 +0000 (14:43 +0100)]
Recompile TypeScript code

3 years agoUse `Ui/Object/Action` instead of `WCF.Action.*`
Matthias Schmidt [Wed, 24 Mar 2021 13:37:43 +0000 (14:37 +0100)]
Use `Ui/Object/Action` instead of `WCF.Action.*`

See WoltLab/WCF#4080

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 23 Mar 2021 14:30:15 +0000 (15:30 +0100)]
Merge branch '5.3'

3 years agoDo not check for `fixup!` commit in draft PRs
Tim Düsterhus [Thu, 11 Mar 2021 11:42:08 +0000 (12:42 +0100)]
Do not check for `fixup!` commit in draft PRs

3 years agoMerge pull request #150 from WoltLab/conversation-flood
Tim Düsterhus [Mon, 8 Mar 2021 16:25:59 +0000 (17:25 +0100)]
Merge pull request #150 from WoltLab/conversation-flood

Add flood control for conversation messages

3 years agoFix copy and paste mistake in message.error.floodControl phrase
Tim Düsterhus [Mon, 8 Mar 2021 15:24:04 +0000 (16:24 +0100)]
Fix copy and paste mistake in message.error.floodControl phrase

Co-authored-by: Matthias Schmidt <gravatronics@live.com>
3 years agoEnforce `user.conversation.floodControlTime`
Tim Düsterhus [Mon, 8 Mar 2021 14:06:54 +0000 (15:06 +0100)]
Enforce `user.conversation.floodControlTime`

Resolves #135