Tim Düsterhus [Thu, 10 Feb 2022 11:28:20 +0000 (12:28 +0100)]
Fix conversation order when being removed from conversation
When one is removed from a conversation, UserConversationList will use the time
of removal as the conversation's `lastPostTime` when ordering, instead of the
actual time of the newest message to not leak information about new messages
after removal.
However this was not properly accounted for within `readObjectIDs()`. Now if a
conversation one was removed from receives new messages after a long-ish time -
with several conversations in between - the conversation will appear on the
*pageNo* where it would be if one would still be a participant. But within the
page it would be ordered based on the timestamp of removal (i.e. appear at the
very bottom of the page).
Fix this by also overriding `lastPostTime` in `readObjectIDs()`. This will move
the conversation to the proper `pageNo` based on the removal time.
This might still be slightly misleading, because the “last message” column in
the template shows the time of the actual last visible message, but this
confusion can be resolved by opening the conversation and seeing the removal
timestamp matching up, whereas without this fix the conversation can be all
over the place.
Tim Düsterhus [Thu, 10 Feb 2022 10:48:57 +0000 (11:48 +0100)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 10 Feb 2022 10:47:29 +0000 (11:47 +0100)]
Merge pull request #170 from WoltLab/remove-participant-last-message-id
Fix calculation of `lastMessageID` when removing other conversation participants
Tim Düsterhus [Thu, 10 Feb 2022 10:33:50 +0000 (11:33 +0100)]
Fix calculation of `lastMessageID` when removing other conversation participants
Without this `ORDER BY` usually the first visible message would've been set as
the `lastMessageID`, as that's the first row within the `conversation_message`
table.
Tim Düsterhus [Wed, 19 Jan 2022 14:35:26 +0000 (15:35 +0100)]
Merge branch 'can-reply-can-read' into 5.4
Tim Düsterhus [Tue, 18 Jan 2022 14:48:22 +0000 (15:48 +0100)]
Remove obsolete check for `->canRead()` in ConversationMessageAction::validateContainer()
Tim Düsterhus [Tue, 18 Jan 2022 14:47:53 +0000 (15:47 +0100)]
Verify that the conversation is readable in Conversation::canReply()
Tim Düsterhus [Mon, 10 Jan 2022 10:27:45 +0000 (11:27 +0100)]
Update npm dependencies
Alexander Ebert [Wed, 22 Dec 2021 16:28:25 +0000 (17:28 +0100)]
Release 5.4.10
Alexander Ebert [Fri, 17 Dec 2021 16:41:02 +0000 (17:41 +0100)]
Release 5.4.10 dev 1
Tim Düsterhus [Mon, 13 Dec 2021 12:47:56 +0000 (13:47 +0100)]
Update prettier and typescript
Tim Düsterhus [Fri, 3 Dec 2021 12:59:06 +0000 (13:59 +0100)]
Count drafts for flood control during actual submission
Otherwise a spammer might be able to silently prepare a large number of drafts,
submitting them in bulk when they prepared enough.
Alexander Ebert [Fri, 24 Sep 2021 12:12:34 +0000 (14:12 +0200)]
Removed the upgrade instructions
Alexander Ebert [Fri, 24 Sep 2021 09:15:53 +0000 (11:15 +0200)]
Release 5.4.8
Alexander Ebert [Fri, 24 Sep 2021 07:41:24 +0000 (09:41 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/com.woltlab.wcf.conversation into 5.4
Alexander Ebert [Fri, 24 Sep 2021 07:41:04 +0000 (09:41 +0200)]
Release 5.4.8 dev 2
Tim Düsterhus [Fri, 24 Sep 2021 07:37:32 +0000 (09:37 +0200)]
Run php-cs-fixer using PHP 8.0
Tim Düsterhus [Thu, 23 Sep 2021 11:41:19 +0000 (13:41 +0200)]
Merge pull request #157 from WoltLab/attachment-orphan
Prevent method calls on `null` in ConversationMessageAttachmentObjectType::canDownload()
Tim Düsterhus [Thu, 23 Sep 2021 10:08:02 +0000 (12:08 +0200)]
Prevent method calls on `null` in ConversationMessageAttachmentObjectType::canDownload()
This may happen for attachments where the corresponding conversation /
conversation message no longer exists.
Alexander Ebert [Wed, 22 Sep 2021 16:37:02 +0000 (18:37 +0200)]
Release 5.4.8 dev 1
WoltLab [Wed, 22 Sep 2021 16:10:55 +0000 (16:10 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Tue, 21 Sep 2021 08:34:23 +0000 (10:34 +0200)]
Disable npm cache in javascript workflow
Tim Düsterhus [Tue, 21 Sep 2021 08:30:48 +0000 (10:30 +0200)]
Update npm dependencies
Alexander Ebert [Mon, 20 Sep 2021 16:17:25 +0000 (18:17 +0200)]
Skip the JS for invisible participant if the user lacks the permissions
Alexander Ebert [Mon, 20 Sep 2021 14:50:53 +0000 (16:50 +0200)]
Incorrect check to display the signatur
This check was effectively redundant since 3.0, but worked until a legacy trait was removed in 5.4. This was overlooked and caused signatures to be hidden in 5.4.
Fixes
381191f4f1e26cdfff406e4ac6240c063d816068
Alexander Ebert [Tue, 31 Aug 2021 13:57:56 +0000 (15:57 +0200)]
Merge branch '5.3' into 5.4
Alexander Ebert [Tue, 31 Aug 2021 12:32:58 +0000 (14:32 +0200)]
Merge branch '5.2' into 5.3
Alexander Ebert [Tue, 31 Aug 2021 11:41:53 +0000 (13:41 +0200)]
Release 5.2.15
Alexander Ebert [Tue, 31 Aug 2021 11:30:54 +0000 (13:30 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Tue, 31 Aug 2021 10:34:34 +0000 (12:34 +0200)]
Release 3.1.23
Tim Düsterhus [Thu, 26 Aug 2021 10:34:38 +0000 (12:34 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 26 Aug 2021 10:29:09 +0000 (12:29 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Aug 2021 10:28:52 +0000 (12:28 +0200)]
Merge branch '3.1' into 5.2
WoltLab [Tue, 24 Aug 2021 09:49:52 +0000 (09:49 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 10 Aug 2021 09:07:55 +0000 (11:07 +0200)]
Release 5.4.3
Alexander Ebert [Fri, 6 Aug 2021 15:29:59 +0000 (17:29 +0200)]
Misleading remark about the comma to separate recipients
Alexander Ebert [Wed, 14 Jul 2021 15:45:19 +0000 (17:45 +0200)]
Release 5.4.0
Alexander Ebert [Mon, 28 Jun 2021 14:01:22 +0000 (16:01 +0200)]
Bad XML
Alexander Ebert [Mon, 28 Jun 2021 13:37:17 +0000 (15:37 +0200)]
Release 5.4.0 RC 1
Tim Düsterhus [Mon, 28 Jun 2021 08:01:17 +0000 (10:01 +0200)]
Add modified PIPs to 5.3 -> 5.4 instructions
Tim Düsterhus [Mon, 28 Jun 2021 07:58:47 +0000 (09:58 +0200)]
Revert "Removed the upgrade support from 5.3.*"
This reverts commit
0fe90b164697dbb4fc74a86b510a6c3de42406c2.
Matthias Schmidt [Wed, 23 Jun 2021 07:14:48 +0000 (09:14 +0200)]
Update XSD paths in XML files
See WoltLab/WCF#4268
Alexander Ebert [Wed, 16 Jun 2021 15:26:53 +0000 (17:26 +0200)]
Release 5.4.0 Beta 2
Matthias Schmidt [Tue, 15 Jun 2021 05:54:04 +0000 (07:54 +0200)]
Merge branch '5.3' into 5.4
Alexander Ebert [Mon, 14 Jun 2021 14:47:02 +0000 (16:47 +0200)]
Release 5.3.8
WoltLab [Mon, 14 Jun 2021 13:53:22 +0000 (13:53 +0000)]
Updating minified JavaScript files
MysteryCode [Mon, 14 Jun 2021 08:30:55 +0000 (10:30 +0200)]
Force `LF` line endings for generated JavaScript (WoltLab/WCF#4285)
The `newLine` configuration option in tsconfig is platform specific. Explicitly set it to ensure consistent behavior.
[Tim: Rephrased the commit message]
[Tim: Adapted to the differing context in non-WoltLab/WCF repositories]
Matthias Schmidt [Thu, 3 Jun 2021 07:42:34 +0000 (09:42 +0200)]
Add workflow for SCSS prettier (#154)
Tim Düsterhus [Mon, 31 May 2021 14:31:06 +0000 (16:31 +0200)]
Add 5.4 branch to GitHub workflows
Alexander Ebert [Wed, 2 Jun 2021 12:58:03 +0000 (14:58 +0200)]
Release 5.4.0 Beta 1
Alexander Ebert [Mon, 31 May 2021 14:21:41 +0000 (16:21 +0200)]
Incorrect use of the `<void/>` instruction
Alexander Ebert [Mon, 31 May 2021 13:42:12 +0000 (15:42 +0200)]
Release 5.4.0 Beta 1
Alexander Ebert [Mon, 31 May 2021 13:04:10 +0000 (15:04 +0200)]
Removed the upgrade support from 5.3.*
Tim Düsterhus [Wed, 26 May 2021 09:19:00 +0000 (11:19 +0200)]
Update npm dependencies
Alexander Ebert [Thu, 20 May 2021 14:47:29 +0000 (16:47 +0200)]
Release 5.4.0 Alpha 3
Tim Düsterhus [Tue, 18 May 2021 10:37:40 +0000 (12:37 +0200)]
Update npm dependencies
Matthias Schmidt [Fri, 14 May 2021 12:31:14 +0000 (14:31 +0200)]
Fix code style
Matthias Schmidt [Fri, 14 May 2021 12:26:32 +0000 (14:26 +0200)]
Merge branch '5.3'
Matthias Schmidt [Fri, 14 May 2021 12:22:55 +0000 (14:22 +0200)]
Delete conversations without messages in `ConversationRebuildDataWorker` (#153)
Close #152
Matthias Schmidt [Fri, 14 May 2021 06:34:06 +0000 (08:34 +0200)]
Preserve names of method arguments during inheritance
See WoltLab/WCF#4211
Matthias Schmidt [Wed, 12 May 2021 10:25:37 +0000 (12:25 +0200)]
Use/Add explicit `return null;` statement
Alexander Ebert [Tue, 11 May 2021 14:23:49 +0000 (16:23 +0200)]
Release 5.4.0 Alpha 2
Tim Düsterhus [Tue, 11 May 2021 13:23:11 +0000 (15:23 +0200)]
Update npm dependencies
Matthias Schmidt [Tue, 11 May 2021 08:07:23 +0000 (10:07 +0200)]
Fix typo in method documentation
Matthias Schmidt [Tue, 11 May 2021 06:38:20 +0000 (08:38 +0200)]
Add `@method` comment for `DatabaseObjectList::getSingleObject()` in subclasses
Matthias Schmidt [Thu, 6 May 2021 12:20:44 +0000 (14:20 +0200)]
Remove duplicate user ids before using local variable in `ConversationPage`
Alexander Ebert [Wed, 5 May 2021 09:46:06 +0000 (11:46 +0200)]
Release 5.4.0 Alpha 1
Matthias Schmidt [Tue, 4 May 2021 08:52:05 +0000 (10:52 +0200)]
Pin `php-cs-fixer` version in codestyle workflow
Matthias Schmidt [Fri, 30 Apr 2021 05:54:33 +0000 (07:54 +0200)]
Use null coalescing operator wherever possible
Matthias Schmidt [Fri, 30 Apr 2021 05:50:25 +0000 (07:50 +0200)]
Update update instructions
Matthias Schmidt [Thu, 29 Apr 2021 12:18:24 +0000 (14:18 +0200)]
Remove obsolete delete instruction for template listeners
WoltLab [Wed, 28 Apr 2021 15:13:47 +0000 (15:13 +0000)]
Updating minified JavaScript files
Matthias Schmidt [Tue, 27 Apr 2021 12:59:18 +0000 (14:59 +0200)]
Add explicit `return null;` statements
Matthias Schmidt [Mon, 26 Apr 2021 14:37:58 +0000 (16:37 +0200)]
Merge branch '5.3'
Matthias Schmidt [Mon, 26 Apr 2021 14:37:50 +0000 (16:37 +0200)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Mon, 26 Apr 2021 14:37:39 +0000 (16:37 +0200)]
Merge branch '3.1' into 5.2
Matthias Schmidt [Mon, 26 Apr 2021 14:37:24 +0000 (16:37 +0200)]
Fix title of data section when editing conversation label
Close #151
Matthias Schmidt [Mon, 26 Apr 2021 09:51:37 +0000 (11:51 +0200)]
Remove unused import
Matthias Schmidt [Mon, 26 Apr 2021 09:48:52 +0000 (11:48 +0200)]
Improve IDE recognition of variable types
Tim Düsterhus [Fri, 23 Apr 2021 08:59:57 +0000 (10:59 +0200)]
Correctly take user ignore types into account
see WoltLab/WCF#3981
see WoltLab/WCF#4064
Tim Düsterhus [Thu, 22 Apr 2021 15:26:44 +0000 (17:26 +0200)]
Add language PIP to update instructions
Matthias Schmidt [Thu, 22 Apr 2021 13:29:31 +0000 (15:29 +0200)]
Use `UserUtil::getIpAddress()` instead of deprecated `SessionHandler::$ipAddress`
See WoltLab/WCF#3593
Tim Düsterhus [Mon, 19 Apr 2021 12:13:48 +0000 (14:13 +0200)]
Set-up php-cs-fixer using setup-php in codestyle workflow
This allows us to easily install extensions.
Matthias Schmidt [Mon, 19 Apr 2021 12:43:23 +0000 (14:43 +0200)]
Enable new RSS feed dialog
See WoltLab/WCF#4123
Matthias Schmidt [Sat, 17 Apr 2021 15:23:09 +0000 (17:23 +0200)]
Use new `lineBreakSeparatedText` option type
See WoltLab/WCF#4126
See WoltLab/WCF#4128
WoltLab [Thu, 15 Apr 2021 07:11:41 +0000 (07:11 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Wed, 14 Apr 2021 09:55:42 +0000 (11:55 +0200)]
Merge branch '5.3'
Alexander Ebert [Mon, 12 Apr 2021 13:00:18 +0000 (15:00 +0200)]
Release 5.3.6
Matthias Schmidt [Sun, 11 Apr 2021 15:43:46 +0000 (17:43 +0200)]
Use consistent title for flood control delay time
See WoltLab/WCF#3801
Matthias Schmidt [Sun, 11 Apr 2021 11:05:19 +0000 (13:05 +0200)]
Consistently use "entered" in English phrases instead of "given"
See WoltLab/WCF#3801
Matthias Schmidt [Wed, 31 Mar 2021 13:34:11 +0000 (15:34 +0200)]
Merge branch '5.3'
Marcel Werk [Tue, 30 Mar 2021 17:11:03 +0000 (19:11 +0200)]
Redirect to GET request after using the participant filter
Matthias Schmidt [Tue, 30 Mar 2021 13:42:13 +0000 (15:42 +0200)]
Update `Ui/Object/Action` implementation
See WoltLab/WCF@
afc2ab81100a477e2fa1d92783837f6e064a8af6
Matthias Schmidt [Thu, 25 Mar 2021 13:43:02 +0000 (14:43 +0100)]
Recompile TypeScript code
Matthias Schmidt [Wed, 24 Mar 2021 13:37:43 +0000 (14:37 +0100)]
Use `Ui/Object/Action` instead of `WCF.Action.*`
See WoltLab/WCF#4080
Matthias Schmidt [Tue, 23 Mar 2021 14:30:15 +0000 (15:30 +0100)]
Merge branch '5.3'
Tim Düsterhus [Thu, 11 Mar 2021 11:42:08 +0000 (12:42 +0100)]
Do not check for `fixup!` commit in draft PRs
Tim Düsterhus [Mon, 8 Mar 2021 16:25:59 +0000 (17:25 +0100)]
Merge pull request #150 from WoltLab/conversation-flood
Add flood control for conversation messages
Tim Düsterhus [Mon, 8 Mar 2021 15:24:04 +0000 (16:24 +0100)]
Fix copy and paste mistake in message.error.floodControl phrase
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
Tim Düsterhus [Mon, 8 Mar 2021 14:06:54 +0000 (15:06 +0100)]
Enforce `user.conversation.floodControlTime`
Resolves #135