GitHub/WoltLab/WCF.git
4 years agoMerge branch 'master' into next
Tim Düsterhus [Wed, 22 Jan 2020 18:00:31 +0000 (19:00 +0100)]
Merge branch 'master' into next

4 years agoFix retryAfter for EmailDeliveryBackgroundJob
Olaf Braun [Sun, 19 Jan 2020 13:48:06 +0000 (14:48 +0100)]
Fix retryAfter for EmailDeliveryBackgroundJob

The array contained a duplicate entry `11`.

Closes #3140

4 years agoOptional select fields were not optional because of a property mismatch
Alexander Ebert [Tue, 21 Jan 2020 16:49:42 +0000 (17:49 +0100)]
Optional select fields were not optional because of a property mismatch

4 years agoExperimental adjustment of selections in the editor on triple click
Alexander Ebert [Tue, 21 Jan 2020 16:05:46 +0000 (17:05 +0100)]
Experimental adjustment of selections in the editor on triple click

4 years agoMisaligned caret in Safari 13+ using the invisible space
Alexander Ebert [Mon, 20 Jan 2020 18:36:19 +0000 (19:36 +0100)]
Misaligned caret in Safari 13+ using the invisible space

4 years agoFix revoking of user trophies
Joshua Rüsweg [Mon, 20 Jan 2020 16:37:41 +0000 (17:37 +0100)]
Fix revoking of user trophies

4 years agoSelected text hidden in an element's overflow should not trigger the quote tooltip
Alexander Ebert [Mon, 20 Jan 2020 12:36:42 +0000 (13:36 +0100)]
Selected text hidden in an element's overflow should not trigger the quote tooltip

4 years agoThe space key should not collapse drop-downs attached to `<input>`
Alexander Ebert [Sun, 19 Jan 2020 18:12:56 +0000 (19:12 +0100)]
The space key should not collapse drop-downs attached to `<input>`

4 years agoSuppress pointer events for hidden dialogs
Alexander Ebert [Sun, 19 Jan 2020 17:58:45 +0000 (18:58 +0100)]
Suppress pointer events for hidden dialogs

4 years agoIncorrect link to the version history of articles
Alexander Ebert [Thu, 16 Jan 2020 18:22:54 +0000 (19:22 +0100)]
Incorrect link to the version history of articles

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 16 Jan 2020 17:53:19 +0000 (18:53 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Alexander Ebert [Thu, 16 Jan 2020 17:52:58 +0000 (18:52 +0100)]
Merge branch '3.0'

4 years agoAttempting to access an element that is not always present
Alexander Ebert [Thu, 16 Jan 2020 17:52:17 +0000 (18:52 +0100)]
Attempting to access an element that is not always present

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 16 Jan 2020 17:32:14 +0000 (18:32 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Alexander Ebert [Thu, 16 Jan 2020 17:31:44 +0000 (18:31 +0100)]
Merge branch '3.0'

4 years ago`WCF::getAnchor()` already encodes HTML entities
Alexander Ebert [Thu, 16 Jan 2020 17:30:51 +0000 (18:30 +0100)]
`WCF::getAnchor()` already encodes HTML entities

4 years agoTrim the usernames reported by `Ui/ItemList`.
Alexander Ebert [Thu, 16 Jan 2020 17:23:58 +0000 (18:23 +0100)]
Trim the usernames reported by `Ui/ItemList`.

4 years agoValidate the access token using a strict regex pattern
Alexander Ebert [Thu, 16 Jan 2020 16:08:06 +0000 (17:08 +0100)]
Validate the access token using a strict regex pattern

4 years agoProperly suppress links in the AttachmentBBCode when requested by the parser
Alexander Ebert [Thu, 16 Jan 2020 15:10:34 +0000 (16:10 +0100)]
Properly suppress links in the AttachmentBBCode when requested by the parser

4 years agoImproved detection of WebP files in PHP 7.0
Alexander Ebert [Wed, 15 Jan 2020 18:14:36 +0000 (19:14 +0100)]
Improved detection of WebP files in PHP 7.0

Closes #3136

4 years ago`IMAGETYPE_WEBP` is available since PHP 7.1 only
Alexander Ebert [Tue, 14 Jan 2020 16:12:07 +0000 (17:12 +0100)]
`IMAGETYPE_WEBP` is available since PHP 7.1 only

4 years agoDo not use html variables in AbstractFormField::getHtml()
Matthias Schmidt [Sun, 12 Jan 2020 16:11:14 +0000 (17:11 +0100)]
Do not use html variables in AbstractFormField::getHtml()

The additional template variables are only relevant for the actual form field which is generated by `AbstractFormField::getFieldHtml()`.

4 years agoSuppress the option for i18n articles when there is only a single language
Alexander Ebert [Sat, 11 Jan 2020 22:27:39 +0000 (23:27 +0100)]
Suppress the option for i18n articles when there is only a single language

4 years agoAdd missing bracket in German phrase
Matthias Schmidt [Sat, 11 Jan 2020 17:22:54 +0000 (18:22 +0100)]
Add missing bracket in German phrase

4 years agoAdd missing foreign keys for 3.1 updates
Matthias Schmidt [Sat, 11 Jan 2020 14:20:13 +0000 (15:20 +0100)]
Add missing foreign keys for 3.1 updates

4 years agoFix adding reactions with multilingual title fields
Joshua Rüsweg [Fri, 10 Jan 2020 19:24:30 +0000 (20:24 +0100)]
Fix adding reactions with multilingual title fields

4 years agofixed missing consideration of the box name in menu pip
Marcel Werk [Fri, 10 Jan 2020 17:00:35 +0000 (18:00 +0100)]
fixed missing consideration of the box name in menu pip

4 years agobuttons in article view were too large
Marcel Werk [Fri, 10 Jan 2020 16:28:24 +0000 (17:28 +0100)]
buttons in article view were too large

4 years agoIncorrect version comparison
Alexander Ebert [Thu, 9 Jan 2020 22:35:54 +0000 (23:35 +0100)]
Incorrect version comparison

4 years agoFix codestyle
Joshua Rüsweg [Thu, 9 Jan 2020 22:17:51 +0000 (23:17 +0100)]
Fix codestyle

4 years agoPrevent duplicates in special trophy assignment
Joshua Rüsweg [Thu, 9 Jan 2020 22:12:36 +0000 (23:12 +0100)]
Prevent duplicates in special trophy assignment
If a trophy is taken away and added again shortly afterwards, the error may occur that the trophy can be marked twice as "Special". In this case, this leads to an error. We prevent this by making the whole thing clear.

4 years agoAdd helper method to add missing foreign keys for 3.1 updates 5.2.1
Matthias Schmidt [Wed, 8 Jan 2020 19:00:26 +0000 (20:00 +0100)]
Add helper method to add missing foreign keys for 3.1 updates

4 years agoAdd missing foreign keys logs during table creation via PHP API
Matthias Schmidt [Wed, 8 Jan 2020 17:53:59 +0000 (18:53 +0100)]
Add missing foreign keys logs during table creation via PHP API

4 years agoMissing file omitted by .gitignore
Alexander Ebert [Wed, 8 Jan 2020 17:50:59 +0000 (18:50 +0100)]
Missing file omitted by .gitignore

4 years agoPreparing the release 5.2.1
Alexander Ebert [Wed, 8 Jan 2020 15:27:05 +0000 (16:27 +0100)]
Preparing the release 5.2.1

4 years agoUpdating minified JavaScript files
woltlab.com [Wed, 8 Jan 2020 14:47:45 +0000 (14:47 +0000)]
Updating minified JavaScript files

4 years agoThe owner group has always access to all groups
Alexander Ebert [Wed, 8 Jan 2020 14:04:11 +0000 (15:04 +0100)]
The owner group has always access to all groups

4 years agoReject MySQL 8 < 8.0.14 due to a serious bug
Alexander Ebert [Mon, 6 Jan 2020 17:48:40 +0000 (18:48 +0100)]
Reject MySQL 8 < 8.0.14 due to a serious bug

See #3133

4 years agoMerge branch 'next' of github.com:WoltLab/WCF into next
Alexander Ebert [Mon, 6 Jan 2020 17:24:28 +0000 (18:24 +0100)]
Merge branch 'next' of github.com:WoltLab/WCF into next

4 years agoDeploy the RoutingCacheBuilder at a later point during the upgrade
Alexander Ebert [Mon, 6 Jan 2020 17:24:09 +0000 (18:24 +0100)]
Deploy the RoutingCacheBuilder at a later point during the upgrade

Fixes #3124

4 years agoFix incorrect usage of classList
Joshua Rüsweg [Mon, 6 Jan 2020 17:07:46 +0000 (18:07 +0100)]
Fix incorrect usage of classList

4 years agoIdempotent modification of the database
Alexander Ebert [Mon, 6 Jan 2020 15:29:32 +0000 (16:29 +0100)]
Idempotent modification of the database

Fixes #3125

4 years agoMerge branch 'master' into next
Alexander Ebert [Mon, 6 Jan 2020 14:13:39 +0000 (15:13 +0100)]
Merge branch 'master' into next

4 years agoDeclare implicitly used property
Alexander Ebert [Mon, 6 Jan 2020 14:12:44 +0000 (15:12 +0100)]
Declare implicitly used property

Fixes #3121

4 years agoMerge branch 'master' into next
Alexander Ebert [Mon, 6 Jan 2020 14:11:42 +0000 (15:11 +0100)]
Merge branch 'master' into next

4 years agoMerge branch 'next' of github.com:WoltLab/WCF into next
Alexander Ebert [Mon, 6 Jan 2020 14:11:07 +0000 (15:11 +0100)]
Merge branch 'next' of github.com:WoltLab/WCF into next

4 years agoIgnore empty XMLHttpRequests aborted by the browser in production environments
Alexander Ebert [Mon, 6 Jan 2020 14:11:04 +0000 (15:11 +0100)]
Ignore empty XMLHttpRequests aborted by the browser in production environments

Fixes #3127

4 years agoMerge pull request #3130 from mutec/htaccessf1
Alexander Ebert [Mon, 6 Jan 2020 14:09:42 +0000 (15:09 +0100)]
Merge pull request #3130 from mutec/htaccessf1

fix htaccess generation

4 years agoMerge pull request #3131 from mutec/rewritetestf1
Alexander Ebert [Mon, 6 Jan 2020 14:09:03 +0000 (15:09 +0100)]
Merge pull request #3131 from mutec/rewritetestf1

make CoreRewriteTestAction available during offline mode

4 years agoMerge branch 'master' into next
Marcel Werk [Sun, 5 Jan 2020 22:04:34 +0000 (23:04 +0100)]
Merge branch 'master' into next

4 years agoRemoved broken media provider
Marcel Werk [Sun, 5 Jan 2020 22:03:18 +0000 (23:03 +0100)]
Removed broken media provider

4 years agoIncorrect deduction of activity points for revoked reactions
Alexander Ebert [Sun, 5 Jan 2020 21:38:19 +0000 (22:38 +0100)]
Incorrect deduction of activity points for revoked reactions

4 years agoMoved the dialog to prevent interference with the dialog's maintainFocus()
Alexander Ebert [Sun, 5 Jan 2020 19:43:29 +0000 (20:43 +0100)]
Moved the dialog to prevent interference with the dialog's maintainFocus()

4 years agoWorkaround for the search for objects matching multiple tags
Alexander Ebert [Sun, 5 Jan 2020 19:08:00 +0000 (20:08 +0100)]
Workaround for the search for objects matching multiple tags

4 years agomake CoreRewriteTestAction available during offline mode
mutec [Sun, 5 Jan 2020 14:29:51 +0000 (15:29 +0100)]
make CoreRewriteTestAction available during offline mode

4 years agoMerge pull request #3129 from Krymonota/remove-paypal-try
Marcel Werk [Sun, 5 Jan 2020 14:04:52 +0000 (15:04 +0100)]
Merge pull request #3129 from Krymonota/remove-paypal-try

Remove Turkish Lira from PayPal payment method

4 years agofix htaccess generation
mutec [Sun, 5 Jan 2020 13:29:21 +0000 (14:29 +0100)]
fix htaccess generation

4 years agoRemove Turkish Lira from PayPal payment method
Niklas [Sun, 5 Jan 2020 02:59:26 +0000 (03:59 +0100)]
Remove Turkish Lira from PayPal payment method

Turkish Lira is no longer supported by PayPal.

4 years agoMerge branch 'master' into next
Alexander Ebert [Sat, 4 Jan 2020 19:23:28 +0000 (20:23 +0100)]
Merge branch 'master' into next

4 years agoMerge pull request #3128 from WoltLab/mention-bogus-space
Alexander Ebert [Sat, 4 Jan 2020 19:21:18 +0000 (20:21 +0100)]
Merge pull request #3128 from WoltLab/mention-bogus-space

Prevent newline after the userBBCodeTag

4 years agoFix legacy i18n value handling in i18n form fields
Matthias Schmidt [Sat, 4 Jan 2020 16:08:06 +0000 (17:08 +0100)]
Fix legacy i18n value handling in i18n form fields

Close #3122

4 years agoFix application of user limit in birthday box
Matthias Schmidt [Sat, 4 Jan 2020 12:47:08 +0000 (13:47 +0100)]
Fix application of user limit in birthday box

4 years agoMerge branch 'master' into next
Matthias Schmidt [Sat, 4 Jan 2020 12:44:46 +0000 (13:44 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Matthias Schmidt [Sat, 4 Jan 2020 12:44:32 +0000 (13:44 +0100)]
Merge branch '3.0'

4 years agoFix handling of default box limit/sorting if not explicitly set
Matthias Schmidt [Sat, 4 Jan 2020 12:44:22 +0000 (13:44 +0100)]
Fix handling of default box limit/sorting if not explicitly set

If a box is created via the box package installation plugin and if no limit, sort field, or sort order is given, the default value should be used instead of leaving the values `null`.

Is also fixed the problem that simply submitting the box edit form without change for a box supporting a limit but not actually having a limit causes an error message because the limit field is empty.

4 years agoPrevent newline after the userBBCodeTag
Tim Düsterhus [Fri, 3 Jan 2020 23:51:02 +0000 (00:51 +0100)]
Prevent newline after the userBBCodeTag

The newline renders as a single space, which looks bad when punctuation
is being used directly after a mention.

Previously a sentence such as:

> Good to see you @Foo!

would have resulted in:

> Good to see you <a>@Foo</a>
> !

which is being rendered as:

> Good to see you @Foo !

4 years agoarticle list now uses the teaser image
Marcel Werk [Fri, 3 Jan 2020 17:17:07 +0000 (18:17 +0100)]
article list now uses the teaser image

4 years agoFixed wrong menu item title
Marcel Werk [Fri, 3 Jan 2020 15:59:56 +0000 (16:59 +0100)]
Fixed wrong menu item title

4 years agoMerge branch 'master' into next
Marcel Werk [Fri, 3 Jan 2020 15:59:25 +0000 (16:59 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Marcel Werk [Fri, 3 Jan 2020 15:59:02 +0000 (16:59 +0100)]
Merge branch '3.0'

4 years agoFixed wrong menu item title
Marcel Werk [Fri, 3 Jan 2020 15:58:42 +0000 (16:58 +0100)]
Fixed wrong menu item title

4 years agoFix article image caption if HTML is used in image caption
Matthias Schmidt [Fri, 3 Jan 2020 15:30:45 +0000 (16:30 +0100)]
Fix article image caption if HTML is used in image caption

4 years agoMerge branch 'master' into next
Matthias Schmidt [Fri, 3 Jan 2020 15:19:17 +0000 (16:19 +0100)]
Merge branch 'master' into next

4 years agoFix missing template parsing in German language item
Matthias Schmidt [Fri, 3 Jan 2020 15:18:57 +0000 (16:18 +0100)]
Fix missing template parsing in German language item

4 years agoRevert "Disabled `ENABLE_PRODUCTION_DEBUG_MODE` by default"
Alexander Ebert [Thu, 2 Jan 2020 16:23:42 +0000 (17:23 +0100)]
Revert "Disabled `ENABLE_PRODUCTION_DEBUG_MODE` by default"

This reverts commit ef1a15aa67556baf84c2a14ebecceecb09c27b18.

4 years agoDisabled `ENABLE_PRODUCTION_DEBUG_MODE` by default
Alexander Ebert [Thu, 2 Jan 2020 16:18:28 +0000 (17:18 +0100)]
Disabled `ENABLE_PRODUCTION_DEBUG_MODE` by default

See #3126

4 years agoIncorrect DOM element access
Alexander Ebert [Thu, 2 Jan 2020 15:48:49 +0000 (16:48 +0100)]
Incorrect DOM element access

4 years agoRemove limit for detailed reaction list
Joshua Rüsweg [Thu, 2 Jan 2020 14:31:12 +0000 (15:31 +0100)]
Remove limit for detailed reaction list

4 years agoAdjust missing phrases in en.xml for reaction system
Tim Düsterhus [Thu, 2 Jan 2020 12:27:57 +0000 (13:27 +0100)]
Adjust missing phrases in en.xml for reaction system

4 years agoHandle all attachments in AttachmentRebuildDataWorker
Tim Düsterhus [Mon, 30 Dec 2019 20:46:33 +0000 (21:46 +0100)]
Handle all attachments in AttachmentRebuildDataWorker

This ensures that the storage is migrated for non-image attachments.

4 years agoIncreased margin between teaser and toc
Marcel Werk [Mon, 30 Dec 2019 15:50:07 +0000 (16:50 +0100)]
Increased margin between teaser and toc

4 years ago`PasswordUtil::secureCompare()` was unintentionally removed
Alexander Ebert [Sun, 29 Dec 2019 21:56:33 +0000 (22:56 +0100)]
`PasswordUtil::secureCompare()` was unintentionally removed

See c914372abbe9f62b765f4b0e0b934f6d45150201

4 years agoPreparing the release 5.2.0 5.2.0
Alexander Ebert [Sat, 28 Dec 2019 19:29:30 +0000 (20:29 +0100)]
Preparing the release 5.2.0

4 years agoUpdating minified JavaScript files
woltlab.com [Sat, 28 Dec 2019 19:25:28 +0000 (19:25 +0000)]
Updating minified JavaScript files

4 years agoFix filter field position when rebuilding filterable item list
Matthias Schmidt [Sat, 28 Dec 2019 17:31:31 +0000 (18:31 +0100)]
Fix filter field position when rebuilding filterable item list

See 7308a8fa1a28ea6515f3656a5356d895b1a5c042

4 years agoAdd missing throw tag in method documentations
Matthias Schmidt [Sat, 28 Dec 2019 16:24:29 +0000 (17:24 +0100)]
Add missing throw tag in method documentations

4 years agoExplicitly declare variable type in comment
Matthias Schmidt [Sat, 28 Dec 2019 16:18:35 +0000 (17:18 +0100)]
Explicitly declare variable type in comment

4 years agoFix documentation issues
Matthias Schmidt [Sat, 28 Dec 2019 16:18:07 +0000 (17:18 +0100)]
Fix documentation issues

4 years agoMerge branch 'master' into next
Joshua Rüsweg [Fri, 27 Dec 2019 14:45:57 +0000 (15:45 +0100)]
Merge branch 'master' into next

4 years agoFix caching of teaserImages in ViewableArticleContentList
Joshua Rüsweg [Fri, 27 Dec 2019 14:45:31 +0000 (15:45 +0100)]
Fix caching of teaserImages in ViewableArticleContentList

4 years agoFix reference for article comment notifications
Joshua Rüsweg [Fri, 27 Dec 2019 14:43:09 +0000 (15:43 +0100)]
Fix reference for article comment notifications
Until now, the notifications were bound to the article object. However, the actual comments are bound to the article content object. This has now been corrected and the notification itself is now also bound to the article content object.

4 years agoFetch articles in ViewableArticleContentList
Joshua Rüsweg [Fri, 27 Dec 2019 14:29:49 +0000 (15:29 +0100)]
Fetch articles in ViewableArticleContentList
Prevents multiple queries in notifications.

4 years agoAdd ViewableArticleContentRuntimeCache
Joshua Rüsweg [Fri, 27 Dec 2019 14:27:28 +0000 (15:27 +0100)]
Add ViewableArticleContentRuntimeCache

4 years agoRemarks on SMTP servers on port 465
Alexander Ebert [Wed, 25 Dec 2019 17:09:16 +0000 (18:09 +0100)]
Remarks on SMTP servers on port 465

4 years agoUpdated worker title and description
Alexander Ebert [Wed, 25 Dec 2019 17:05:00 +0000 (18:05 +0100)]
Updated worker title and description

4 years agoMerge branch 'master' into next
Alexander Ebert [Wed, 25 Dec 2019 16:36:34 +0000 (17:36 +0100)]
Merge branch 'master' into next

4 years agoMerge pull request #3119 from Krymonota/fix-de-trophy-condition-typo
Alexander Ebert [Wed, 25 Dec 2019 16:30:25 +0000 (17:30 +0100)]
Merge pull request #3119 from Krymonota/fix-de-trophy-condition-typo

Fix typo in trophy condition description (de.xml)

4 years agoPopulate the authors array for new notifications
Alexander Ebert [Wed, 25 Dec 2019 16:27:19 +0000 (17:27 +0100)]
Populate the authors array for new notifications

4 years agoImproved event access for user notifications
Alexander Ebert [Wed, 25 Dec 2019 16:26:04 +0000 (17:26 +0100)]
Improved event access for user notifications

Closes #3017

4 years agoRemove dislikes from statDailyHandler
Joshua Rüsweg [Wed, 25 Dec 2019 10:52:00 +0000 (11:52 +0100)]
Remove dislikes from statDailyHandler