Marcel Werk [Mon, 14 Sep 2020 12:31:34 +0000 (14:31 +0200)]
Expired session during 3rd party auth led to a SystemException
(cherry picked from commit
da8b0e89fa9da82fc7965955e7c0639a65d6ac00)
Marcel Werk [Mon, 14 Sep 2020 11:51:37 +0000 (13:51 +0200)]
Expired session during google auth led to a SystemException
(cherry picked from commit
740ece8da10177354ab904f9aeb6ea914741c025)
Matthias Schmidt [Wed, 28 Oct 2020 16:21:28 +0000 (17:21 +0100)]
Remove obsolete TODO
Matthias Schmidt [Wed, 28 Oct 2020 13:01:48 +0000 (14:01 +0100)]
Fix reading medias' `captionEnableHtml`
See
a1b75f8b9b9d6137434945bb8bea9518eddb48d3
Tim Düsterhus [Wed, 28 Oct 2020 08:48:09 +0000 (09:48 +0100)]
Merge branch '3.1' into 5.2
Niklas [Wed, 28 Oct 2020 08:46:10 +0000 (09:46 +0100)]
Fix class name in UserRegistrationUtil::__construct() PHPDoc (#3652)
Tim Düsterhus [Mon, 26 Oct 2020 16:31:08 +0000 (17:31 +0100)]
Merge pull request #3648 from WoltLab/actions
Refactor Workflows
Tim Düsterhus [Mon, 26 Oct 2020 15:53:33 +0000 (16:53 +0100)]
Add javascript workflow
Tim Düsterhus [Mon, 26 Oct 2020 15:53:17 +0000 (16:53 +0100)]
Rename php-syntax workflow to php
Tim Düsterhus [Mon, 26 Oct 2020 16:02:03 +0000 (17:02 +0100)]
Adjust human readable name for CodeSniffer check
Joshua Rüsweg [Sat, 24 Oct 2020 13:28:59 +0000 (15:28 +0200)]
Merge pull request #3644 from Krymonota/patch-14
Add like support check to comment responses
Niklas [Sat, 24 Oct 2020 12:12:15 +0000 (14:12 +0200)]
Add like support check to comment responses
If the provided comment manager doesn't support likes, it's not possible to like comments, as can be seen here:
- https://github.com/WoltLab/WCF/blob/
6747fe291c584d7c8295912f8d94297588d142b2/com.woltlab.wcf/templates/commentList.tpl#L59
- https://github.com/WoltLab/WCF/blob/
6747fe291c584d7c8295912f8d94297588d142b2/com.woltlab.wcf/templates/commentList.tpl#L59
However, it's never checked for comment responses whether the comment manager supports likes. This results in the like button being displayed for comment responses, even though likes aren't supported.
Tim Düsterhus [Fri, 23 Oct 2020 12:47:06 +0000 (14:47 +0200)]
Merge pull request #3612 from WoltLab/csrf-token-template-backport
Backport CsrfTokenFunctionTemplatePlugin
Tim Düsterhus [Fri, 23 Oct 2020 10:49:54 +0000 (12:49 +0200)]
Whitelist `get_class` in enterprise mode
Alexander Ebert [Wed, 21 Oct 2020 16:20:06 +0000 (18:20 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Fri, 16 Oct 2020 11:57:29 +0000 (13:57 +0200)]
Ignore top-level node_modules/
Tim Düsterhus [Wed, 21 Oct 2020 13:39:04 +0000 (15:39 +0200)]
Limit workflows to release branches
Features branches will be tested using a PR.
Tim Düsterhus [Wed, 21 Oct 2020 13:37:16 +0000 (15:37 +0200)]
Merge pull request #3622 from WoltLab/workflow-style
Add codestyle workflow
Tim Düsterhus [Wed, 21 Oct 2020 13:03:35 +0000 (15:03 +0200)]
Add codestyle workflow
Tim Düsterhus [Wed, 21 Oct 2020 13:18:26 +0000 (15:18 +0200)]
Add .phpcs.xml
Tim Düsterhus [Wed, 21 Oct 2020 13:13:28 +0000 (15:13 +0200)]
Merge pull request #3617 from WoltLab/formbuilder-php8
Fix PHP 8 support in form builder
Tim Düsterhus [Wed, 21 Oct 2020 12:46:13 +0000 (14:46 +0200)]
Tighten up the code style a bit
Tim Düsterhus [Wed, 21 Oct 2020 10:07:35 +0000 (12:07 +0200)]
Merge pull request #3620 from WoltLab/php-syntax-action
Add php-syntax workflow
Tim Düsterhus [Wed, 21 Oct 2020 08:40:18 +0000 (10:40 +0200)]
Pin the setup-php action to v2 instead of 2.7.0
Tim Düsterhus [Wed, 21 Oct 2020 08:35:20 +0000 (10:35 +0200)]
Ignore errors in HTMLPurifier*.autoload-legacy.php
Tim Düsterhus [Wed, 21 Oct 2020 08:33:38 +0000 (10:33 +0200)]
Fix PHP 8 syntax in DirectoryUtil
Tim Düsterhus [Wed, 21 Oct 2020 08:31:58 +0000 (10:31 +0200)]
Remove PHP syntax check from Travis CI
Tim Düsterhus [Wed, 21 Oct 2020 08:09:44 +0000 (10:09 +0200)]
Suppress "No Syntax errors detected" output
Tim Düsterhus [Wed, 21 Oct 2020 07:46:50 +0000 (09:46 +0200)]
Add php-syntax problem matcher
Tim Düsterhus [Wed, 21 Oct 2020 07:38:08 +0000 (09:38 +0200)]
Add php-syntax Workflow
Tim Düsterhus [Tue, 20 Oct 2020 10:02:22 +0000 (12:02 +0200)]
Fix PHP 8 support in form builder
> Message: Method ReflectionParameter::getClass() is deprecated
Fixes #3489
Tim Düsterhus [Mon, 19 Oct 2020 12:58:39 +0000 (14:58 +0200)]
Backport CsrfTokenFunctionTemplatePlugin
see
3f6a261b1e6a3804370eb1e2a046ea6c666dbedd
see #3606
Alexander Ebert [Mon, 19 Oct 2020 13:58:54 +0000 (15:58 +0200)]
Revert "Fix deprecation warnings in form builder in PHP 8"
This reverts commit
624e3dd0b234c4bab3e537173421045c7c82590c.
Tim Düsterhus [Mon, 19 Oct 2020 13:32:05 +0000 (15:32 +0200)]
Fix endless loop in removeExifData when the APP1 signature does not match
Tim Düsterhus [Mon, 19 Oct 2020 11:36:07 +0000 (13:36 +0200)]
Ignore symlink creation failures in DebugFolderEmailTransport
Matthias Schmidt [Sat, 17 Oct 2020 14:36:53 +0000 (16:36 +0200)]
Fix updating action of foreign key
Close #3610
Marcel Werk [Thu, 15 Oct 2020 09:10:50 +0000 (11:10 +0200)]
Fixed parameter validation of 'captionEnableHtml'
Marcel Werk [Wed, 14 Oct 2020 09:06:14 +0000 (11:06 +0200)]
Added link to new manual
Alexander Ebert [Tue, 13 Oct 2020 16:03:33 +0000 (18:03 +0200)]
Suppress the edit button for boxes on touch devices
The first tap on the box will trigger the hover, preventing any other elements, such as links, from responding.
Matthias Schmidt [Mon, 12 Oct 2020 16:51:54 +0000 (18:51 +0200)]
Fix add PIP entry via GUI if only delete element exists in XML file
Close #3599
Matthias Schmidt [Mon, 12 Oct 2020 16:37:11 +0000 (18:37 +0200)]
Fix missing language item
Close #3597
Alexander Ebert [Mon, 12 Oct 2020 16:10:32 +0000 (18:10 +0200)]
Merge pull request #3600 from WoltLab/exception-parse-alphanumeric-code
Support alphanumeric error code in ExceptionLogUtil::parseException()
Tim Düsterhus [Mon, 12 Oct 2020 16:09:06 +0000 (18:09 +0200)]
Support alphanumeric error code in ExceptionLogUtil::parseException()
PDO error codes might contain letters.
Alexander Ebert [Sun, 11 Oct 2020 11:42:03 +0000 (13:42 +0200)]
Use a literal string to avoid escaping
See #3595
Alexander Ebert [Sun, 11 Oct 2020 11:41:39 +0000 (13:41 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Sun, 11 Oct 2020 11:41:20 +0000 (13:41 +0200)]
Use a literal string to avoid escaping
See #3595
Alexander Ebert [Sun, 11 Oct 2020 11:38:16 +0000 (13:38 +0200)]
Merge pull request #3598 from WoltLab/php8_form_builder
Fix deprecation warnings in form builder in PHP 8
Matthias Schmidt [Sat, 10 Oct 2020 15:54:50 +0000 (17:54 +0200)]
Fix deprecation warnings in form builder in PHP 8
Close #3489
Olaf Braun [Mon, 5 Oct 2020 12:05:24 +0000 (14:05 +0200)]
Fix 'Undefined index: additionalData' in Box
This error can be encountered when calling `new Box(123)` with
`123` not being the ID of a valid box.
Closes #3594
Matthias Schmidt [Sun, 4 Oct 2020 15:58:31 +0000 (17:58 +0200)]
Fix page title for system check page
Close #3591
Marcel Werk [Sun, 4 Oct 2020 09:09:03 +0000 (11:09 +0200)]
Merge branch '3.1' into 5.2
Marcel Werk [Sun, 4 Oct 2020 09:07:18 +0000 (11:07 +0200)]
Removed obsolete code
There is no article counter for users (wcf1_user.articles) in version 3.1.
joshuaruesweg [Sun, 4 Oct 2020 08:41:58 +0000 (10:41 +0200)]
Add missing language variable `wcf.upload.error.uploadFailed`
Marcel Werk [Thu, 1 Oct 2020 16:27:19 +0000 (18:27 +0200)]
Automatic removal of commas from tag names
Alexander Ebert [Thu, 1 Oct 2020 15:45:52 +0000 (17:45 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Thu, 1 Oct 2020 15:45:29 +0000 (17:45 +0200)]
Merge pull request #3585 from WoltLab/overdue-cronjob
Improved the wording of the cronjob error message
Alexander Ebert [Thu, 1 Oct 2020 15:45:10 +0000 (17:45 +0200)]
Improved readability
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
Marcel Werk [Thu, 1 Oct 2020 15:16:01 +0000 (17:16 +0200)]
Removed obsolete code
Marcel Werk [Thu, 1 Oct 2020 14:52:57 +0000 (16:52 +0200)]
Merge branch '3.1' into 5.2
Marcel Werk [Thu, 1 Oct 2020 14:52:40 +0000 (16:52 +0200)]
Default value blocked saving of empty date fields
Alexander Ebert [Thu, 1 Oct 2020 14:41:22 +0000 (16:41 +0200)]
Incorrect parameter order
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Alexander Ebert [Wed, 30 Sep 2020 18:39:39 +0000 (20:39 +0200)]
Improved the wording of the cronjob error message
Marcel Werk [Wed, 30 Sep 2020 14:09:23 +0000 (16:09 +0200)]
Page title could not be renamed via page management
Marcel Werk [Wed, 30 Sep 2020 12:51:54 +0000 (14:51 +0200)]
Fixed broken autofocus in login form
Matthias Schmidt [Tue, 29 Sep 2020 14:07:57 +0000 (16:07 +0200)]
Fix (non)empty dependency for radiobuttons
joshuaruesweg [Mon, 28 Sep 2020 14:56:10 +0000 (16:56 +0200)]
Show always an no selection option in custom select options build with the OptionHandler
Fixes #3579
Alexander Ebert [Mon, 28 Sep 2020 14:48:26 +0000 (16:48 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 28 Sep 2020 14:48:13 +0000 (16:48 +0200)]
Incorrect link to the user edit form
Tim Düsterhus [Mon, 28 Sep 2020 09:32:57 +0000 (11:32 +0200)]
Merge pull request #3577 from WoltLab/filereader-range
Disable 'Range' handling for 0-byte files in FileReader
Tim Düsterhus [Mon, 28 Sep 2020 08:50:36 +0000 (10:50 +0200)]
Disable 'Range' handling for 0-byte files in FileReader
see https://community.woltlab.com/thread/285960-download-eines-leeren-textdokuments-gibt-http-error-416-aus/
joshuaruesweg [Sun, 27 Sep 2020 11:35:02 +0000 (13:35 +0200)]
Add missing language variables
woltlab.com [Wed, 23 Sep 2020 16:31:37 +0000 (16:31 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 22 Sep 2020 11:34:16 +0000 (13:34 +0200)]
Increased the z-index of the reaction popover
This prevents the reactions from being overlapped by an adjacent tab menu on mobile devices.
Alexander Ebert [Tue, 22 Sep 2020 11:28:12 +0000 (13:28 +0200)]
Do not block the installation of not yet installed projects
Fixes #3572
This commit rectifies the change in
d70a577df3662d168612e40035a4237c19bed5b0
Alexander Ebert [Mon, 21 Sep 2020 10:06:00 +0000 (12:06 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 21 Sep 2020 10:05:45 +0000 (12:05 +0200)]
Prevent data being pasted twice in Chromium on Android
Alexander Ebert [Sun, 20 Sep 2020 14:08:39 +0000 (16:08 +0200)]
Use the `selectionchange` event to suppress the selection of the quote tooltip
Alexander Ebert [Sun, 20 Sep 2020 10:25:30 +0000 (12:25 +0200)]
Prevent the read access to devtools projects without a valid path
Alexander Ebert [Fri, 18 Sep 2020 15:03:31 +0000 (17:03 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Fri, 18 Sep 2020 15:02:47 +0000 (17:02 +0200)]
Missing link target causes buttons to be unresponsive in some touch browers
Tim Düsterhus [Wed, 16 Sep 2020 13:48:16 +0000 (15:48 +0200)]
Use consistent hostname in description of mail_smtp_host
Tim Düsterhus [Mon, 14 Sep 2020 18:36:48 +0000 (20:36 +0200)]
Fix typo in error message in MultipleSelectionFormField
Sascha Greuel [Wed, 9 Sep 2020 08:03:04 +0000 (10:03 +0200)]
Fix PHP 8 compatibility in GDImageAdapter (#3558)
Fixed image resource validation
Resolves #3492
Sascha Greuel [Wed, 9 Sep 2020 08:01:20 +0000 (10:01 +0200)]
Fix PHP 8 compatibility in HTTPRequest (#3557)
Fixed PHP8 related error message (Argument #1 ($arg) must be passed by reference, value given)
Closes #3554
Marcel Werk [Tue, 8 Sep 2020 09:53:37 +0000 (11:53 +0200)]
Fixed icon alignment in the "login with google" button
Tim Düsterhus [Tue, 8 Sep 2020 08:54:51 +0000 (10:54 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 8 Sep 2020 07:43:31 +0000 (09:43 +0200)]
Prevent Android from collapsing the keyboard on [Enter]
Somehow the linkify redactor plugin causes Android to collapse the on-screen
keyboard if a new line is entered.
This plugin was already removed for 5.2 in commit
19af26fc22bc31d699db6021dee2eda1d23b8a14,
so let's effectively disable it for 3.1 as well.
see https://community.woltlab.com/thread/285573-wsc-3-1-17-smartphone-tastatur-schlie%C3%9Ft-sich-unbeabsichtigt/?postID=
1816848#post1816848
Matthias Schmidt [Thu, 3 Sep 2020 14:46:14 +0000 (16:46 +0200)]
Fix changing monolingual to multilingual package data via devtools
Close #3550
Matthias Schmidt [Thu, 3 Sep 2020 14:41:30 +0000 (16:41 +0200)]
Fix typo in German language item
Alexander Ebert [Wed, 2 Sep 2020 13:49:40 +0000 (15:49 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Wed, 2 Sep 2020 13:47:34 +0000 (15:47 +0200)]
Incorrect calculation of the last 2 digits of the year
Fixes #3547
Marcel Werk [Wed, 2 Sep 2020 09:51:05 +0000 (11:51 +0200)]
Merge pull request #3548 from WoltLab/acp-headContent
Add `$headContent` placeholder variable to header.tpl in ACP
Tim Düsterhus [Wed, 2 Sep 2020 09:46:56 +0000 (11:46 +0200)]
Add `$headContent` placeholder variable to header.tpl in ACP
This allows the developer to easily add page specific `<style>` tags in
the appropriate location.
Alexander Ebert [Fri, 28 Aug 2020 13:27:09 +0000 (15:27 +0200)]
Release 5.2.9
Alexander Ebert [Fri, 28 Aug 2020 13:15:59 +0000 (15:15 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Fri, 28 Aug 2020 11:09:35 +0000 (13:09 +0200)]
Release 3.1.17
Tim Düsterhus [Thu, 27 Aug 2020 10:21:00 +0000 (12:21 +0200)]
Revert "Fix deprecation warnings in form builder in PHP 8"
This reverts commit
5ae5d6c5621c8fe1f30d6a2c787024b9bcadee87.
As commented on the original commit this change is not compatible with PHP
7.0 which is the lowest PHP version we support as of right now. Revert
this commit for now to not break compatibility with existing installations
of 5.2 until a proper solution for 5.3 and later is developed.
See #3489.
Alexander Ebert [Wed, 26 Aug 2020 17:05:45 +0000 (19:05 +0200)]
`http_build_query()` is now allowed for calls from within a template
joshuaruesweg [Wed, 26 Aug 2020 16:51:12 +0000 (18:51 +0200)]
Fix notifications with are triggered by merged users
Objects of merged users are rewritten to the new user. This is currently done but not by the notification authors. There the author is simply deleted from the notification. This works for most notifications, but not for reactions, because they always expect a concrete author (a guest cannot assign reactions). If users are deleted, it works as intended, since the corresponding reaction object is then also deleted.
Alexander Ebert [Wed, 26 Aug 2020 15:57:54 +0000 (17:57 +0200)]
Release 5.2.9