GitHub/WoltLab/WCF.git
3 years agoAdd WoltLab Suite bot
joshuaruesweg [Sun, 4 Apr 2021 15:11:36 +0000 (17:11 +0200)]
Add WoltLab Suite bot

3 years agoAdd meta tags for CategoryArticleListPage
joshuaruesweg [Sun, 4 Apr 2021 15:02:20 +0000 (17:02 +0200)]
Add meta tags for CategoryArticleListPage

3 years agoFix code style
Matthias Schmidt [Wed, 31 Mar 2021 11:33:12 +0000 (13:33 +0200)]
Fix code style

3 years agoFix code style
Matthias Schmidt [Wed, 31 Mar 2021 11:16:37 +0000 (13:16 +0200)]
Fix code style

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 31 Mar 2021 11:15:21 +0000 (13:15 +0200)]
Merge branch '5.3'

3 years agoPreview images and cover photos were exported twice
Marcel Werk [Wed, 31 Mar 2021 09:16:59 +0000 (11:16 +0200)]
Preview images and cover photos were exported twice

3 years agoRemove/replace nbsp when copying code to the clipboard
Marcel Werk [Tue, 30 Mar 2021 17:54:29 +0000 (19:54 +0200)]
Remove/replace nbsp when copying code to the clipboard

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 30 Mar 2021 16:44:40 +0000 (18:44 +0200)]
Merge branch '5.3'

3 years agoCover photo deletion was not saved properly
Marcel Werk [Tue, 30 Mar 2021 16:39:32 +0000 (18:39 +0200)]
Cover photo deletion was not saved properly

3 years agoAlways fetch package information using the default language
Marcel Werk [Tue, 30 Mar 2021 13:24:21 +0000 (15:24 +0200)]
Always fetch package information using the default language

3 years agoImprove `Ui/Object/Action` implementation (#4101)
Matthias Schmidt [Tue, 30 Mar 2021 13:08:34 +0000 (15:08 +0200)]
Improve `Ui/Object/Action` implementation (#4101)

* Improve `Ui/Object/Action` implementation

1. The `objectAction` callback of `Ui/Object/Action/Handler` no gets the whole `data: ObjectActionData` data structure instead of each element separately.
2. `ObjectActionData` now also contains the container element.
3. Add support for `data-object-action-handler` for action buttons. The default actions ignore actions triggered by buttons with such attributes. Instead, custom handlers can react to specific actions by checking for the value of this attribute.

* Use `insertAdjacentElement` in `Ui/Object/Action/Delete`

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoFixed missing language variables for error messages
Marcel Werk [Tue, 30 Mar 2021 13:08:03 +0000 (15:08 +0200)]
Fixed missing language variables for error messages

3 years agoRemoved obsolete language variables
Marcel Werk [Tue, 30 Mar 2021 13:04:08 +0000 (15:04 +0200)]
Removed obsolete language variables

3 years agoMerge branch '5.2' into 5.3
Marcel Werk [Mon, 29 Mar 2021 16:24:45 +0000 (18:24 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Marcel Werk [Mon, 29 Mar 2021 16:24:08 +0000 (18:24 +0200)]
Merge branch '3.1' into 5.2

3 years agoUpdate the user rank after users change their profile
Marcel Werk [Mon, 29 Mar 2021 16:23:50 +0000 (18:23 +0200)]
Update the user rank after users change their profile

3 years agoFix identifier of DOM change listener in `Ui/Object/Action`
Matthias Schmidt [Mon, 29 Mar 2021 14:13:03 +0000 (16:13 +0200)]
Fix identifier of DOM change listener in `Ui/Object/Action`

3 years agoRemoved obsolete Chrome workaround for dialogs with scrollbars
Marcel Werk [Mon, 29 Mar 2021 13:52:14 +0000 (15:52 +0200)]
Removed obsolete Chrome workaround for dialogs with scrollbars

3 years agoRemoved obsolete whitespaces
Marcel Werk [Sun, 28 Mar 2021 12:29:18 +0000 (14:29 +0200)]
Removed obsolete whitespaces

3 years agoDelete trophy images when deleting tropies
Marcel Werk [Sun, 28 Mar 2021 12:13:50 +0000 (14:13 +0200)]
Delete trophy images when deleting tropies

3 years agoFixed wrong parameter type
Marcel Werk [Sun, 28 Mar 2021 12:13:14 +0000 (14:13 +0200)]
Fixed wrong parameter type

3 years agoMissing margin for trophies with images
Marcel Werk [Sun, 28 Mar 2021 11:17:59 +0000 (13:17 +0200)]
Missing margin for trophies with images

3 years agoHide comment counter when comments are disabled
Marcel Werk [Sun, 28 Mar 2021 11:02:52 +0000 (13:02 +0200)]
Hide comment counter when comments are disabled

3 years agoMade sure ids in toc are unique
Marcel Werk [Sun, 28 Mar 2021 10:48:19 +0000 (12:48 +0200)]
Made sure ids in toc are unique

3 years agoMerge branch '5.2' into 5.3
Marcel Werk [Sun, 28 Mar 2021 09:51:29 +0000 (11:51 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Marcel Werk [Sun, 28 Mar 2021 09:38:13 +0000 (11:38 +0200)]
Merge branch '3.1' into 5.2

3 years agoStrip rtl override char
Marcel Werk [Sun, 28 Mar 2021 09:37:09 +0000 (11:37 +0200)]
Strip rtl override char

3 years agoMerge pull request #4093 from WoltLab/redirect-guard
Joshua Rüsweg [Fri, 26 Mar 2021 13:58:27 +0000 (14:58 +0100)]
Merge pull request #4093 from WoltLab/redirect-guard

Add RedirectGuard

3 years agoPermit the use of `array_diff` in templates
Alexander Ebert [Fri, 26 Mar 2021 11:36:18 +0000 (12:36 +0100)]
Permit the use of `array_diff` in templates

If only developers would stop moving business logic into templates…

3 years agoMerge pull request #4080 from WoltLab/ts_dbo_action
Matthias Schmidt [Wed, 24 Mar 2021 12:40:48 +0000 (13:40 +0100)]
Merge pull request #4080 from WoltLab/ts_dbo_action

Add global `WCF.Action.(Delete|Toggle)` replacement modules

3 years agoMerge branch 'master' into ts_dbo_action
Matthias Schmidt [Wed, 24 Mar 2021 12:37:19 +0000 (13:37 +0100)]
Merge branch 'master' into ts_dbo_action

3 years agoAvoid using template compiler in `ObjectActionFunctionTemplatePlugin`
Matthias Schmidt [Wed, 24 Mar 2021 12:35:46 +0000 (13:35 +0100)]
Avoid using template compiler in `ObjectActionFunctionTemplatePlugin`

Language items in `wcf.global.` do not support template scripting by default. Instead of "manually" adding support for template scripting for this specific case, the relevant language item has been moved to a different language item category.

3 years agoReplace use of `WCF.Search.User` with `Ui/User/Search/Input` (#4096)
Matthias Schmidt [Wed, 24 Mar 2021 08:02:24 +0000 (09:02 +0100)]
Replace use of `WCF.Search.User` with `Ui/User/Search/Input` (#4096)

* Replace use of `WCF.Search.User` with `Ui/User/Search/Input`

See #3876

* Remove obsolete TODO

See 9d7cfda776e5c3809babfeb003d1212c29413619

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoIncorrect position of the suggestion drop-down
Alexander Ebert [Tue, 23 Mar 2021 18:16:23 +0000 (19:16 +0100)]
Incorrect position of the suggestion drop-down

Related issue: #4096

3 years agoRemove duplicate colon
Matthias Schmidt [Mon, 22 Mar 2021 12:21:17 +0000 (13:21 +0100)]
Remove duplicate colon

3 years agoRemove trailing whitespace in ObjectActionFunctionTemplatePlugin documentation
Matthias Schmidt [Mon, 22 Mar 2021 12:04:08 +0000 (13:04 +0100)]
Remove trailing whitespace in ObjectActionFunctionTemplatePlugin documentation

3 years agoExtend documentation of `ObjectActionFunctionTemplatePlugin`
Matthias Schmidt [Mon, 22 Mar 2021 11:58:39 +0000 (12:58 +0100)]
Extend documentation of `ObjectActionFunctionTemplatePlugin`

3 years agoMake `wcf.global.button.delete.confirmMessage` globally available in JS code
Matthias Schmidt [Mon, 22 Mar 2021 11:45:18 +0000 (12:45 +0100)]
Make `wcf.global.button.delete.confirmMessage` globally available in JS code

3 years agoUpdate obsolete comment in `Media/Manager/Base`
Matthias Schmidt [Sun, 21 Mar 2021 13:50:23 +0000 (14:50 +0100)]
Update obsolete comment in `Media/Manager/Base`

3 years agoDeprecate `WCF.Action.*` classes
Matthias Schmidt [Sun, 21 Mar 2021 13:49:29 +0000 (14:49 +0100)]
Deprecate `WCF.Action.*` classes

3 years agoUse `Ui/Object/Action/Delete` for attachments
Matthias Schmidt [Sun, 21 Mar 2021 13:47:16 +0000 (14:47 +0100)]
Use `Ui/Object/Action/Delete` for attachments

3 years agoAdd Applebot as spider
joshuaruesweg [Sun, 21 Mar 2021 11:30:10 +0000 (12:30 +0100)]
Add Applebot as spider

3 years agoRemove obsolete import
Matthias Schmidt [Sun, 21 Mar 2021 09:54:05 +0000 (10:54 +0100)]
Remove obsolete import

3 years agoReplace use of `WCF.Action.SimpleProxy` with `Ui/Object/Action`
Matthias Schmidt [Sun, 21 Mar 2021 09:48:28 +0000 (10:48 +0100)]
Replace use of `WCF.Action.SimpleProxy` with `Ui/Object/Action`

3 years agoRemove obsolete JavaScript function
Matthias Schmidt [Sun, 21 Mar 2021 09:47:20 +0000 (10:47 +0100)]
Remove obsolete JavaScript function

3 years agoUse `Ui/Object/Action` for media files
Matthias Schmidt [Sun, 21 Mar 2021 09:42:34 +0000 (10:42 +0100)]
Use `Ui/Object/Action` for media files

3 years agoUse `Ui/Object/Action/Delete` in more places in ACP
Matthias Schmidt [Sun, 21 Mar 2021 08:54:16 +0000 (09:54 +0100)]
Use `Ui/Object/Action/Delete` in more places in ACP

3 years agoSupport nested structures in `Ui/Object/Action/Delete`
Matthias Schmidt [Sun, 21 Mar 2021 08:43:42 +0000 (09:43 +0100)]
Support nested structures in `Ui/Object/Action/Delete`

3 years agoConvert last uses of `WCF.Action.Toggle` to `Ui/Action/Toggle`
Matthias Schmidt [Sun, 21 Mar 2021 08:33:51 +0000 (09:33 +0100)]
Convert last uses of `WCF.Action.Toggle` to `Ui/Action/Toggle`

3 years agoAdd support for `(enable|disable)Title` for toggling in `{objectAction}`
Matthias Schmidt [Sun, 21 Mar 2021 08:33:13 +0000 (09:33 +0100)]
Add support for `(enable|disable)Title` for toggling in `{objectAction}`

3 years agoFix code formatting in ObjectActionFunctionTemplatePlugin
Matthias Schmidt [Sat, 20 Mar 2021 12:22:53 +0000 (13:22 +0100)]
Fix code formatting in ObjectActionFunctionTemplatePlugin

3 years agoUse `Ui/Object/Action/Delete` in frontend
Matthias Schmidt [Sat, 20 Mar 2021 12:15:38 +0000 (13:15 +0100)]
Use `Ui/Object/Action/Delete` in frontend

3 years agoUse ObjectActionFunctionTemplatePlugin in more places in ACP
Matthias Schmidt [Sat, 20 Mar 2021 12:09:28 +0000 (13:09 +0100)]
Use ObjectActionFunctionTemplatePlugin in more places in ACP

3 years agoAdd and use ObjectActionFunctionTemplatePlugin
Matthias Schmidt [Thu, 18 Mar 2021 10:04:08 +0000 (11:04 +0100)]
Add and use ObjectActionFunctionTemplatePlugin

3 years agoUse new templates for object action delete and toggle icons
Matthias Schmidt [Wed, 17 Mar 2021 15:07:32 +0000 (16:07 +0100)]
Use new templates for object action delete and toggle icons

3 years agoAdd templates for object action delete and toggle icons
Matthias Schmidt [Wed, 17 Mar 2021 15:07:16 +0000 (16:07 +0100)]
Add templates for object action delete and toggle icons

3 years agoStart using `Ui/Object/Action/*` in ACP
Matthias Schmidt [Tue, 16 Mar 2021 13:56:07 +0000 (14:56 +0100)]
Start using `Ui/Object/Action/*` in ACP

3 years agoApply suggestions from code review
Matthias Schmidt [Mon, 15 Mar 2021 09:13:46 +0000 (10:13 +0100)]
Apply suggestions from code review

3 years agoMove `Controller/ClipboardData` to `Controller/Clipboard/Data`
Matthias Schmidt [Mon, 15 Mar 2021 09:00:04 +0000 (10:00 +0100)]
Move `Controller/ClipboardData` to `Controller/Clipboard/Data`

3 years agoAdd draft for global `WCF.Action.(Delete|Toggle)` replacement modules
Matthias Schmidt [Sun, 14 Mar 2021 12:26:02 +0000 (13:26 +0100)]
Add draft for global `WCF.Action.(Delete|Toggle)` replacement modules

3 years agoFix editing newly uploaded media files
Matthias Schmidt [Sun, 21 Mar 2021 09:20:50 +0000 (10:20 +0100)]
Fix editing newly uploaded media files

3 years agoMerge pull request #4095 from WoltLab/WCF_Action_Proxy
Matthias Schmidt [Sun, 21 Mar 2021 09:13:19 +0000 (10:13 +0100)]
Merge pull request #4095 from WoltLab/WCF_Action_Proxy

Stop using `WCF.Action.Proxy` in templates

3 years agoApply suggestions from code review
Matthias Schmidt [Sun, 21 Mar 2021 08:11:42 +0000 (09:11 +0100)]
Apply suggestions from code review

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoThrow `UserInputException` insteadof `InvalidArgumentException` for invalid captchas
joshuaruesweg [Sat, 20 Mar 2021 16:48:03 +0000 (17:48 +0100)]
Throw `UserInputException` insteadof `InvalidArgumentException` for invalid captchas

See 80d79b25e7c027b48487bc822faf4256534f22e2

3 years agoMerge branch '5.3'
joshuaruesweg [Sat, 20 Mar 2021 16:40:54 +0000 (17:40 +0100)]
Merge branch '5.3'

3 years agoThrow `UserInputException` insteadof `InvalidArgumentException` for invalid captchas
joshuaruesweg [Sat, 20 Mar 2021 15:38:02 +0000 (16:38 +0100)]
Throw `UserInputException` insteadof `InvalidArgumentException` for invalid captchas

Currently, bots are deliberately manipulating the field to provoke an exception. This is prevented with this fix.

3 years agoUse `Ui/Sortable/List` instead of `WCF.Sortable.List`
Matthias Schmidt [Sat, 20 Mar 2021 13:01:40 +0000 (14:01 +0100)]
Use `Ui/Sortable/List` instead of `WCF.Sortable.List`

See #3876

3 years agoUse modern JavaScript to reset data import mapping
Matthias Schmidt [Sat, 20 Mar 2021 12:43:01 +0000 (13:43 +0100)]
Use modern JavaScript to reset data import mapping

3 years agoMove cronjob execution to `BootstrapFrontend` and use `Ajax` module
Matthias Schmidt [Sat, 20 Mar 2021 12:37:38 +0000 (13:37 +0100)]
Move cronjob execution to `BootstrapFrontend` and use `Ajax` module

3 years agoAdd missing new line
joshuaruesweg [Sat, 20 Mar 2021 11:39:51 +0000 (12:39 +0100)]
Add missing new line

3 years agoAdd UGC tag only for user generated content
joshuaruesweg [Sat, 20 Mar 2021 11:36:16 +0000 (12:36 +0100)]
Add UGC tag only for user generated content

3 years agoUse RedirectGuard in ImageProxy
Tim Düsterhus [Thu, 18 Mar 2021 10:51:53 +0000 (11:51 +0100)]
Use RedirectGuard in ImageProxy

3 years agoUse RedirectGuard during URL unfurling
Tim Düsterhus [Thu, 18 Mar 2021 10:51:22 +0000 (11:51 +0100)]
Use RedirectGuard during URL unfurling

3 years agoAdd RedirectGuard for Guzzle
Tim Düsterhus [Thu, 18 Mar 2021 10:51:09 +0000 (11:51 +0100)]
Add RedirectGuard for Guzzle

3 years agoMerge pull request #4091 from WoltLab/password-focus
Marcel Werk [Thu, 18 Mar 2021 10:42:28 +0000 (11:42 +0100)]
Merge pull request #4091 from WoltLab/password-focus

Maintain focus of the password input when adding the password visibility button

3 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 17 Mar 2021 15:31:21 +0000 (16:31 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #4092 from WoltLab/woltlab-source-isactive
Tim Düsterhus [Wed, 17 Mar 2021 15:17:10 +0000 (16:17 +0100)]
Merge pull request #4092 from WoltLab/woltlab-source-isactive

Use WoltLabSource.isActive() to check whether the source view is enabled

3 years agoUse WoltLabSource.isActive() to check whether the source view is enabled
Tim Düsterhus [Wed, 17 Mar 2021 14:58:36 +0000 (15:58 +0100)]
Use WoltLabSource.isActive() to check whether the source view is enabled

Apparently the previous version, checking the height of the textarea, is broken
in the Kiwi Browser for Android even though it pretends to be a standard Chrome
88 without indicating anywhere within the User-Agent that it is not.

Luckily the fix is easy enough and technically the more correct solution even
for non-broken browsers.

I verified the correct functionality using Kiwi on Android and Firefox on
Linux.

3 years agoMaintain focus of the password input when adding the password visibility button
Tim Düsterhus [Wed, 17 Mar 2021 13:04:15 +0000 (14:04 +0100)]
Maintain focus of the password input when adding the password visibility button

Fixes #4050

3 years agoFix update instructions for wcf1_unfurl_url
Tim Düsterhus [Wed, 17 Mar 2021 12:02:24 +0000 (13:02 +0100)]
Fix update instructions for wcf1_unfurl_url

3 years agoMerge pull request #4036 from WoltLab/unfurl-url
Joshua Rüsweg [Tue, 16 Mar 2021 15:54:51 +0000 (16:54 +0100)]
Merge pull request #4036 from WoltLab/unfurl-url

Unfurl url

3 years agoAdd `og:image:url` detection
joshuaruesweg [Tue, 16 Mar 2021 15:07:49 +0000 (16:07 +0100)]
Add `og:image:url` detection

3 years agoReject to unfurl urls with an explicit port
joshuaruesweg [Tue, 16 Mar 2021 13:16:45 +0000 (14:16 +0100)]
Reject to unfurl urls with an explicit port

3 years agoRemove styling elements for unfurled urls
joshuaruesweg [Fri, 12 Mar 2021 16:39:29 +0000 (17:39 +0100)]
Remove styling elements for unfurled urls

3 years agoClean up code and unify code style
joshuaruesweg [Fri, 12 Mar 2021 15:04:50 +0000 (16:04 +0100)]
Clean up code and unify code style

3 years agoUse DOMElement::getAttribute
joshuaruesweg [Fri, 12 Mar 2021 14:55:18 +0000 (15:55 +0100)]
Use DOMElement::getAttribute

3 years agoUse imageUrl as imageHash
joshuaruesweg [Fri, 12 Mar 2021 13:55:57 +0000 (14:55 +0100)]
Use imageUrl as imageHash

3 years agoUse random imageHash to avoid collisions
joshuaruesweg [Fri, 12 Mar 2021 10:38:03 +0000 (11:38 +0100)]
Use random imageHash to avoid collisions

3 years agoUse XPath to determine values
joshuaruesweg [Fri, 12 Mar 2021 10:06:03 +0000 (11:06 +0100)]
Use XPath to determine values

3 years agoReject image urls which contains special chars
joshuaruesweg [Wed, 10 Mar 2021 16:09:29 +0000 (17:09 +0100)]
Reject image urls which contains special chars

3 years agoAdd plain url feature
joshuaruesweg [Wed, 10 Mar 2021 15:17:10 +0000 (16:17 +0100)]
Add plain url feature

Display urls, which have neither an image nor a description as a simple titled link.

3 years agoCode cleanup
joshuaruesweg [Wed, 10 Mar 2021 15:09:14 +0000 (16:09 +0100)]
Code cleanup

3 years agoRemove `touch` call
joshuaruesweg [Wed, 10 Mar 2021 14:32:22 +0000 (15:32 +0100)]
Remove `touch` call

3 years agoTrim title, description and imageUrl
joshuaruesweg [Wed, 10 Mar 2021 14:28:39 +0000 (15:28 +0100)]
Trim title, description and imageUrl

3 years agoRemove superflouos breaks
joshuaruesweg [Wed, 10 Mar 2021 14:11:32 +0000 (15:11 +0100)]
Remove superflouos breaks

3 years agoUse const for unfurl url image dir
joshuaruesweg [Wed, 10 Mar 2021 14:02:02 +0000 (15:02 +0100)]
Use const for unfurl url image dir

3 years agoUse 160 chars for url description
joshuaruesweg [Wed, 10 Mar 2021 13:50:45 +0000 (14:50 +0100)]
Use 160 chars for url description

3 years agoUse own table for unfurl url images
joshuaruesweg [Wed, 10 Mar 2021 13:07:59 +0000 (14:07 +0100)]
Use own table for unfurl url images

3 years agoImproved the visuals for mobile devices
Alexander Ebert [Fri, 5 Mar 2021 18:49:36 +0000 (19:49 +0100)]
Improved the visuals for mobile devices

3 years agoRefactored the CSS and template
Alexander Ebert [Fri, 5 Mar 2021 18:36:12 +0000 (19:36 +0100)]
Refactored the CSS and template

Improved visuals to match similar components. The CSS classes now use a common prefix and are no longer nested unless required.