GitHub/WoltLab/WCF.git
3 years agoAdd `ICssClassFormField`
Matthias Schmidt [Sun, 20 Dec 2020 09:43:34 +0000 (10:43 +0100)]
Add `ICssClassFormField`

3 years agoRevert "Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4"
Matthias Schmidt [Fri, 18 Dec 2020 18:36:07 +0000 (19:36 +0100)]
Revert "Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4"

This reverts commit 7c8a1b332fd09ddb046dccfba9e92c463a18a414.

3 years agoMerge branch '5.3'
Matthias Schmidt [Fri, 18 Dec 2020 18:35:46 +0000 (19:35 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 18 Dec 2020 18:33:51 +0000 (19:33 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4
Matthias Schmidt [Fri, 18 Dec 2020 18:33:23 +0000 (19:33 +0100)]
Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4

See #3792

3 years agoFix missing variable error in DatabaseTableChangeProcessor
Matthias Schmidt [Fri, 18 Dec 2020 18:32:51 +0000 (19:32 +0100)]
Fix missing variable error in DatabaseTableChangeProcessor

See #3792

3 years agoFix updating action of foreign key
Matthias Schmidt [Fri, 18 Dec 2020 18:26:29 +0000 (19:26 +0100)]
Fix updating action of foreign key

See c64a33b40a7e601a6005f7ca247f7d2ecb52a393

3 years agoAdd CheckboxFormField (#3812)
Peter Lohse [Fri, 18 Dec 2020 18:17:12 +0000 (19:17 +0100)]
Add CheckboxFormField (#3812)

* added implementation of a checkbox form field for boolen values

* fixed indentation

* added __checkboxFormField to syncTemplates.json

* added missing comma

3 years agoRTL fix for code boxes
Marcel Werk [Fri, 18 Dec 2020 14:47:22 +0000 (15:47 +0100)]
RTL fix for code boxes

3 years agoMerge pull request #3818 from WoltLab/empty-style-preview
Tim Düsterhus [Fri, 18 Dec 2020 12:53:16 +0000 (13:53 +0100)]
Merge pull request #3818 from WoltLab/empty-style-preview

Fix style previews pointing to the style's asset folder

3 years agoFix style previews pointing to the style's asset folder
Tim Düsterhus [Fri, 18 Dec 2020 12:44:57 +0000 (13:44 +0100)]
Fix style previews pointing to the style's asset folder

update_com.woltlab.wcf_5.3.1_style.php created this situation when the style
did not have a preview image, due to a missing check for a non-empty `image` /
`image2x` property.

3 years agoMerge pull request #3817 from WoltLab/count-category-options
Marcel Werk [Fri, 18 Dec 2020 11:16:38 +0000 (12:16 +0100)]
Merge pull request #3817 from WoltLab/count-category-options

Improved detection of empty option categories

3 years agoFix typo in de.xml
Tim Düsterhus [Fri, 18 Dec 2020 08:44:07 +0000 (09:44 +0100)]
Fix typo in de.xml

3 years agoMerge pull request #3816 from WoltLab/parseSearchQuery
Tim Düsterhus [Fri, 18 Dec 2020 08:17:29 +0000 (09:17 +0100)]
Merge pull request #3816 from WoltLab/parseSearchQuery

Remove AbstractSearchEngine::parseSearchQuery()

3 years agoRemoved obsolete parameter
Marcel Werk [Thu, 17 Dec 2020 18:20:09 +0000 (19:20 +0100)]
Removed obsolete parameter

3 years agoMerge branch '5.3'
Alexander Ebert [Thu, 17 Dec 2020 16:57:56 +0000 (17:57 +0100)]
Merge branch '5.3'

3 years agoPermit the use of `is_null` in templates when running in the enterprise mode
Alexander Ebert [Thu, 17 Dec 2020 16:57:43 +0000 (17:57 +0100)]
Permit the use of `is_null` in templates when running in the enterprise mode

3 years agoImproved detection of empty option categories
Marcel Werk [Thu, 17 Dec 2020 15:20:13 +0000 (16:20 +0100)]
Improved detection of empty option categories

3 years agoRemove AbstractSearchEngine::parseSearchQuery()
Tim Düsterhus [Thu, 17 Dec 2020 08:27:26 +0000 (09:27 +0100)]
Remove AbstractSearchEngine::parseSearchQuery()

Resolves #3815

3 years agoFix typo in de.xml
Tim Düsterhus [Thu, 17 Dec 2020 08:14:29 +0000 (09:14 +0100)]
Fix typo in de.xml

3 years agoMerge pull request #3790 from WoltLab/54-typescript-acp-trophy
Alexander Ebert [Tue, 15 Dec 2020 17:41:56 +0000 (18:41 +0100)]
Merge pull request #3790 from WoltLab/54-typescript-acp-trophy

Convert ACP UI trophy modules to TypeScript

3 years agoMerge pull request #3789 from WoltLab/54-typescript-acp-template
Alexander Ebert [Tue, 15 Dec 2020 17:41:26 +0000 (18:41 +0100)]
Merge pull request #3789 from WoltLab/54-typescript-acp-template

Convert `Acp/Ui/Template/Group/Copy` to TypeScript

3 years agoMerge pull request #3788 from WoltLab/54-typescript-acp-style
Alexander Ebert [Tue, 15 Dec 2020 17:41:02 +0000 (18:41 +0100)]
Merge pull request #3788 from WoltLab/54-typescript-acp-style

Convert `Acp/Ui/Style/Editor` to TypeScript

3 years agoMerge pull request #3787 from WoltLab/54-typescript-acp-user
Alexander Ebert [Tue, 15 Dec 2020 17:40:28 +0000 (18:40 +0100)]
Merge pull request #3787 from WoltLab/54-typescript-acp-user

Convert ACP UI user modules to TypeScript

3 years agoMerge pull request #3806 from WoltLab/LanguageItemFormNode
Matthias Schmidt [Tue, 15 Dec 2020 17:26:39 +0000 (18:26 +0100)]
Merge pull request #3806 from WoltLab/LanguageItemFormNode

Add `LanguageItemFormNode`

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 15 Dec 2020 17:22:32 +0000 (18:22 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 15 Dec 2020 17:19:37 +0000 (18:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix hiding/showing tab menu entries due to form builder dependencies
Matthias Schmidt [Tue, 15 Dec 2020 17:19:21 +0000 (18:19 +0100)]
Fix hiding/showing tab menu entries due to form builder dependencies

3 years agoMerge pull request #3809 from WoltLab/access-log
Tim Düsterhus [Tue, 15 Dec 2020 10:47:41 +0000 (11:47 +0100)]
Merge pull request #3809 from WoltLab/access-log

Make the ACP session access log more useful

3 years agoEnsure that the request ID is fully logged in SessionAccessLogListener
Tim Düsterhus [Mon, 14 Dec 2020 16:19:00 +0000 (17:19 +0100)]
Ensure that the request ID is fully logged in SessionAccessLogListener

3 years agoMerge branch '5.3'
Alexander Ebert [Tue, 15 Dec 2020 10:43:02 +0000 (11:43 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #3810 from WoltLab/user-group-option-limited-removal
Alexander Ebert [Tue, 15 Dec 2020 10:42:36 +0000 (11:42 +0100)]
Merge pull request #3810 from WoltLab/user-group-option-limited-removal

Prevent the unintentional removal of values for groups that are not being edited

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 14 Dec 2020 19:13:50 +0000 (20:13 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 14 Dec 2020 19:13:35 +0000 (20:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoExcempt the admin panel from application overrides
Alexander Ebert [Mon, 14 Dec 2020 19:13:04 +0000 (20:13 +0100)]
Excempt the admin panel from application overrides

Fixes #3762

3 years agoPrevent the unintentional removal of values for groups that are not being edited
Alexander Ebert [Mon, 14 Dec 2020 17:44:41 +0000 (18:44 +0100)]
Prevent the unintentional removal of values for groups that are not being edited

3 years agoIncrease `Bcrypt` cost to 12
Tim Düsterhus [Mon, 14 Dec 2020 15:16:09 +0000 (16:16 +0100)]
Increase `Bcrypt` cost to 12

This results in ~333ms per hash on an oldish Intel(R) Core(TM) i5-2430M CPU @ 2.40GHz
 any other CPU I tested was faster than that.

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 14 Dec 2020 13:13:57 +0000 (14:13 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #3807 from WoltLab/imagick-quantize-images
Alexander Ebert [Mon, 14 Dec 2020 13:13:27 +0000 (14:13 +0100)]
Merge pull request #3807 from WoltLab/imagick-quantize-images

Greatly improve the performance of GIF processing with ImageMagick

3 years agoRemoved the legacy workaround for ancient ImageMagick versions
Alexander Ebert [Mon, 14 Dec 2020 12:43:18 +0000 (13:43 +0100)]
Removed the legacy workaround for ancient ImageMagick versions

3 years agoMake the ACP session access log more useful
Tim Düsterhus [Mon, 14 Dec 2020 10:51:24 +0000 (11:51 +0100)]
Make the ACP session access log more useful

This commit intentionally overloads the existing fields to keep the change
simple. The log is not really usuable for programmatic processing, due to the
existing constraints. The cleanest solution probably would be storing all the
loggable information as a JSON blob and then parsing that one when accessing
the log and querying it with MySQL's JSON function. But the latter are not
supported yet.

All in all this change improves the ACP session access log a lot and that is
what counts.

Resolves #3537

3 years agoUse LanguageItemFormNode in MultifactorManageForm
Tim Düsterhus [Mon, 14 Dec 2020 09:48:06 +0000 (10:48 +0100)]
Use LanguageItemFormNode in MultifactorManageForm

3 years agoUse LanguageItemFormNode in MultifactorDisableForm
Tim Düsterhus [Mon, 14 Dec 2020 09:46:31 +0000 (10:46 +0100)]
Use LanguageItemFormNode in MultifactorDisableForm

3 years agoUse LanguageItemFormNode in BackupMultifactorMethod
Tim Düsterhus [Mon, 14 Dec 2020 09:44:16 +0000 (10:44 +0100)]
Use LanguageItemFormNode in BackupMultifactorMethod

3 years agoUse LanguageItemFormNode in EmailMultifactorMethod
Tim Düsterhus [Mon, 14 Dec 2020 09:42:49 +0000 (10:42 +0100)]
Use LanguageItemFormNode in EmailMultifactorMethod

3 years agoFix typo in LanguageItemFormNode
Tim Düsterhus [Mon, 14 Dec 2020 09:39:11 +0000 (10:39 +0100)]
Fix typo in LanguageItemFormNode

3 years agoTypo
Alexander Ebert [Sun, 13 Dec 2020 19:05:13 +0000 (20:05 +0100)]
Typo

3 years agoPrevent the trophy content being squished together
Alexander Ebert [Sat, 12 Dec 2020 18:11:39 +0000 (19:11 +0100)]
Prevent the trophy content being squished together

3 years agoGreatly improve the performance of GIF processing with ImageMagick
Alexander Ebert [Sat, 12 Dec 2020 17:41:36 +0000 (18:41 +0100)]
Greatly improve the performance of GIF processing with ImageMagick

3 years agoAdd `LanguageItemFormNode`
Matthias Schmidt [Sat, 12 Dec 2020 15:25:09 +0000 (16:25 +0100)]
Add `LanguageItemFormNode`

Close #3753

3 years agoMerge branch '5.3'
Matthias Schmidt [Sat, 12 Dec 2020 14:08:25 +0000 (15:08 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sat, 12 Dec 2020 14:01:52 +0000 (15:01 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3799 from WoltLab/nonnull_in_primary_key
Matthias Schmidt [Sat, 12 Dec 2020 14:00:52 +0000 (15:00 +0100)]
Merge pull request #3799 from WoltLab/nonnull_in_primary_key

Validate primary indices with null columns in PHP DB API

3 years agoReload styleEditor after updating image path
joshuaruesweg [Fri, 11 Dec 2020 10:48:22 +0000 (11:48 +0100)]
Reload styleEditor after updating image path
Because the style is compiled after the variables have been set, we have to reload the style object once with the correct `imagePath` so that it can be used correctly in the initial compilation.

3 years agoMerge pull request #3778 from WoltLab/consistent-phrasing
Tim Düsterhus [Fri, 11 Dec 2020 08:17:23 +0000 (09:17 +0100)]
Merge pull request #3778 from WoltLab/consistent-phrasing

Use consistent phrasing

3 years agoRemove obsolete PACKAGE_ID check in ImportCLICommand
Tim Düsterhus [Thu, 10 Dec 2020 13:21:03 +0000 (14:21 +0100)]
Remove obsolete PACKAGE_ID check in ImportCLICommand

3 years agoMerge pull request #3781 from WoltLab/remove-recaptcha-v1
Tim Düsterhus [Thu, 10 Dec 2020 10:30:29 +0000 (11:30 +0100)]
Merge pull request #3781 from WoltLab/remove-recaptcha-v1

Remove reCAPTCHA v1 implementation

3 years agoSimplify recaptcha key checks in template
Tim Düsterhus [Thu, 10 Dec 2020 08:45:27 +0000 (09:45 +0100)]
Simplify recaptcha key checks in template

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoMerge pull request #3798 from WoltLab/toc-suppress-enumeration
Tim Düsterhus [Thu, 10 Dec 2020 08:44:07 +0000 (09:44 +0100)]
Merge pull request #3798 from WoltLab/toc-suppress-enumeration

Suppress enumeration that is part of the headline in ToC

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 9 Dec 2020 17:43:15 +0000 (18:43 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 9 Dec 2020 17:43:05 +0000 (18:43 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix doubled validation errors for CaptchaFormField
Matthias Schmidt [Wed, 9 Dec 2020 17:42:41 +0000 (18:42 +0100)]
Fix doubled validation errors for CaptchaFormField

3 years agoValidate primary indices with null columns in PHP DB API
Matthias Schmidt [Wed, 9 Dec 2020 16:13:59 +0000 (17:13 +0100)]
Validate primary indices with null columns in PHP DB API

Close #3792

3 years agoSuppress enumeration that is part of the headline in ToC
Tim Düsterhus [Wed, 9 Dec 2020 13:49:11 +0000 (14:49 +0100)]
Suppress enumeration that is part of the headline in ToC

Resolves #3757

3 years agoMerge pull request #3711 from WoltLab/mfa-meta
Tim Düsterhus [Wed, 9 Dec 2020 12:26:58 +0000 (13:26 +0100)]
Merge pull request #3711 from WoltLab/mfa-meta

Multifactor Authentication: Integration branch

3 years agoSort language items in wcf.user.security category
Tim Düsterhus [Wed, 9 Dec 2020 11:52:57 +0000 (12:52 +0100)]
Sort language items in wcf.user.security category

3 years agoAppend 'Authentication' to name of SessionHandler::changeUserAfterMultifactor()
Tim Düsterhus [Wed, 9 Dec 2020 10:54:23 +0000 (11:54 +0100)]
Append 'Authentication' to name of SessionHandler::changeUserAfterMultifactor()

3 years agoUse constant time hexadecimal encoding in migrate_multifactor
Tim Düsterhus [Wed, 9 Dec 2020 10:44:56 +0000 (11:44 +0100)]
Use constant time hexadecimal encoding in migrate_multifactor

3 years agoAdd missing language item
Tim Düsterhus [Wed, 9 Dec 2020 10:43:16 +0000 (11:43 +0100)]
Add missing language item

3 years agoMake use of ->markRequiredFields(false) for single-field authentication forms
Tim Düsterhus [Wed, 9 Dec 2020 09:45:16 +0000 (10:45 +0100)]
Make use of ->markRequiredFields(false) for single-field authentication forms

3 years agoMerge branch 'master' into mfa-meta
Tim Düsterhus [Wed, 9 Dec 2020 09:22:16 +0000 (10:22 +0100)]
Merge branch 'master' into mfa-meta

For #3764.

3 years agoRestored the user online location for profiles
Alexander Ebert [Wed, 9 Dec 2020 00:23:31 +0000 (01:23 +0100)]
Restored the user online location for profiles

There has been a change in 5.3 that introduced the `$userOnline` value, however this is the target user itself and not the user's content they are viewing. The `$user` variable is useless, because it is a plain `User` object that is not compatible with `{$user}`.

3 years agoMerge pull request #3765 from WoltLab/db_api_rename_column
Matthias Schmidt [Tue, 8 Dec 2020 17:05:21 +0000 (18:05 +0100)]
Merge pull request #3765 from WoltLab/db_api_rename_column

Support renaming database table columns via PHP API

3 years agoMake marking required fields optional with form builder (#3764)
Matthias Schmidt [Tue, 8 Dec 2020 17:03:41 +0000 (18:03 +0100)]
Make marking required fields optional with form builder (#3764)

Close #3758

3 years agoMerge branch '5.3'
joshuaruesweg [Tue, 8 Dec 2020 12:57:21 +0000 (13:57 +0100)]
Merge branch '5.3'

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:56:41 +0000 (13:56 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:54:49 +0000 (13:54 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 7 Dec 2020 20:00:31 +0000 (21:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2

3 years agoForce the use of the attachment thumbnail if the original is inaccessible
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible

3 years agoWorkaround for the misaligned caret in Safari caused by 0x200B
Alexander Ebert [Mon, 7 Dec 2020 19:02:58 +0000 (20:02 +0100)]
Workaround for the misaligned caret in Safari caused by 0x200B

3 years agoImproved the iOS WebKit click detection inside the editor margin
Alexander Ebert [Mon, 7 Dec 2020 17:16:08 +0000 (18:16 +0100)]
Improved the iOS WebKit click detection inside the editor margin

3 years agoForce a whitespace before and after inserted smileys
Alexander Ebert [Mon, 7 Dec 2020 16:27:54 +0000 (17:27 +0100)]
Force a whitespace before and after inserted smileys

3 years agoMerge pull request #3793 from WoltLab/style-import-permissions
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions

Validate package installation permissions in StyleImportForm

3 years agoValidate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm

3 years agoMerge pull request #3786 from WoltLab/like-rebuild
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild

Optimize LikeRebuildDataWorker performance

3 years agoMerge pull request #3775 from WoltLab/mfa-reauth
Tim Düsterhus [Mon, 7 Dec 2020 10:36:22 +0000 (11:36 +0100)]
Merge pull request #3775 from WoltLab/mfa-reauth

Add generic reauthentication implementation

3 years agoAdd explanatory texts to reauthentication
Tim Düsterhus [Mon, 7 Dec 2020 10:24:56 +0000 (11:24 +0100)]
Add explanatory texts to reauthentication

3 years agoDo not request reauthentication from users connected to a third party provider
Tim Düsterhus [Tue, 1 Dec 2020 14:59:00 +0000 (15:59 +0100)]
Do not request reauthentication from users connected to a third party provider

3 years agoRequest reauthentication in MultifactorDisableForm
Tim Düsterhus [Tue, 1 Dec 2020 14:53:05 +0000 (15:53 +0100)]
Request reauthentication in MultifactorDisableForm

3 years agoRequest reauthentication in MultifactorManageForm
Tim Düsterhus [Tue, 1 Dec 2020 14:52:08 +0000 (15:52 +0100)]
Request reauthentication in MultifactorManageForm

3 years agoAdd TReauthenticationCheck
Tim Düsterhus [Tue, 1 Dec 2020 14:48:12 +0000 (15:48 +0100)]
Add TReauthenticationCheck

3 years agoAdd ReauthenticationForm
Tim Düsterhus [Tue, 1 Dec 2020 14:41:12 +0000 (15:41 +0100)]
Add ReauthenticationForm

3 years agoAdd reauthentication logic to SessionHandler
Tim Düsterhus [Tue, 1 Dec 2020 14:08:29 +0000 (15:08 +0100)]
Add reauthentication logic to SessionHandler

3 years agoRemove obsolete import from MultifactorAuthenticationForm
Tim Düsterhus [Tue, 1 Dec 2020 14:19:07 +0000 (15:19 +0100)]
Remove obsolete import from MultifactorAuthenticationForm

3 years agoMerge branch 'master' into mfa-meta
Tim Düsterhus [Mon, 7 Dec 2020 10:05:24 +0000 (11:05 +0100)]
Merge branch 'master' into mfa-meta

For the UserPasswordFormField.

3 years agoMerge branch '5.3'
Tim Düsterhus [Mon, 7 Dec 2020 10:05:02 +0000 (11:05 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #3779 from WoltLab/mfa-acp
Tim Düsterhus [Mon, 7 Dec 2020 08:09:50 +0000 (09:09 +0100)]
Merge pull request #3779 from WoltLab/mfa-acp

Add multi-factor management to UserEditForm

3 years agoMerge pull request #3782 from WoltLab/deprecate-memcached
Tim Düsterhus [Mon, 7 Dec 2020 08:07:57 +0000 (09:07 +0100)]
Merge pull request #3782 from WoltLab/deprecate-memcached

Deprecate memcached

3 years agoOnly close the user panel drop-downs if no key modifier was pressed
Alexander Ebert [Sun, 6 Dec 2020 21:48:54 +0000 (22:48 +0100)]
Only close the user panel drop-downs if no key modifier was pressed