Tim Düsterhus [Tue, 31 May 2022 13:41:47 +0000 (15:41 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Tue, 31 May 2022 13:41:28 +0000 (15:41 +0200)]
Adjust PHP versions in environment check for 5.4
see
598b72301a2cdcd0f3a0c1196f6fc1107e01650e
Tim Düsterhus [Tue, 31 May 2022 13:39:48 +0000 (15:39 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 31 May 2022 13:36:26 +0000 (15:36 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 31 May 2022 13:35:00 +0000 (15:35 +0200)]
Adjust PHP versions in environment check for 5.2
see
598b72301a2cdcd0f3a0c1196f6fc1107e01650e
Tim Düsterhus [Tue, 31 May 2022 13:33:43 +0000 (15:33 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 31 May 2022 13:31:44 +0000 (15:31 +0200)]
Merge pull request #4840 from WoltLab/system-environment-check
Add basic check for the runtime environment
Tim Düsterhus [Tue, 31 May 2022 13:11:02 +0000 (15:11 +0200)]
Add basic check for the runtime environment
Running WoltLab Suite in an unsupported environment might work for the
majority of requests, some requests might fail very visibly. But there
also is a third type: A request that *appear* to execute properly, but
that subtly behaves incorrectly, due to a change in PHP's behavior.
The latter type is dangerous, as those requests might introduce errors
into the dataset that are very hard to impossible to correct after the
fact because the necessary information to fix up the data is no longer
available.
Prevent this situation from occuring by performing a basic test of the
runtime environment and halting processing early if this test fails to
ensure that it processed as little as possible.
Tim Düsterhus [Tue, 31 May 2022 12:57:44 +0000 (14:57 +0200)]
Enable HTML escaping of `->errorMessage` in packageUpdateServerList.tpl
This is not exploitable for a full-blown XSS attack, as any HTML tags are
stripped. Nonetheless the `"` character can cause issues, as the value is also
displayed in an HTML attribute and the error message contains uncontrolled
content.
Tim Düsterhus [Tue, 31 May 2022 09:37:34 +0000 (11:37 +0200)]
Release 5.5.0 Beta 4
WoltLab [Tue, 31 May 2022 09:32:57 +0000 (09:32 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Tue, 31 May 2022 09:31:02 +0000 (11:31 +0200)]
WoltLab [Tue, 31 May 2022 09:27:55 +0000 (09:27 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 31 May 2022 09:13:32 +0000 (11:13 +0200)]
Merge pull request #4838 from WoltLab/custom-color-picker
Custom color picker implementation
Alexander Ebert [Tue, 31 May 2022 09:13:26 +0000 (11:13 +0200)]
Simplified the code a bit
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Alexander Ebert [Mon, 30 May 2022 17:14:40 +0000 (19:14 +0200)]
Incorrect calculation of the saturation
Alexander Ebert [Mon, 30 May 2022 16:43:14 +0000 (18:43 +0200)]
Clean-up of legacy files, FF workaround
Alexander Ebert [Mon, 30 May 2022 15:58:14 +0000 (17:58 +0200)]
Unified the phrases for the color picker
Alexander Ebert [Mon, 30 May 2022 14:54:12 +0000 (16:54 +0200)]
Overhauled color picker with RGBA and HSL
Alexander Ebert [Mon, 30 May 2022 14:39:11 +0000 (16:39 +0200)]
Support for RGB <-> HSL
Tim Düsterhus [Mon, 30 May 2022 08:54:48 +0000 (10:54 +0200)]
Re-deprecate SessionHandler's styleID functionality
see
094ee7c31ce505b293fc228d6831ecb4a42130cc
Tim Düsterhus [Mon, 30 May 2022 08:47:36 +0000 (10:47 +0200)]
Revert "Prevent saving `styleID` in sessions for user"
The intention behind that change still is valid. However using the
`StyleAction::changeStyle()` method which internally uses
`UserAction::update()` internally is problematic, due to events firing. At the
point where `initStyle()` runs, the applications are not yet initialized and
thus the event listener classes of applications will not be found by the
autoloader.
With
bb2430b495a4bfe7e8f205b97749f49ce4f59229 the handling of the `styleID`
parameter is already removed, thus ultimately solving the same problem, but
without the issues.
This reverts commit
cc5207457ef1157b44ecad54db32ab7438a1158e.
Alexander Ebert [Sun, 29 May 2022 18:06:26 +0000 (20:06 +0200)]
Use separate inputs for the RGB color channels
Marcel Werk [Sun, 29 May 2022 15:41:09 +0000 (17:41 +0200)]
Search for author without search term was not possible
Alexander Ebert [Sat, 28 May 2022 13:05:48 +0000 (15:05 +0200)]
Removed an outdated webkit work-around
This was required in <= 5.4 to fix an issue caused by the `transform: translateX(-50%)` offset used in these versions. 5.5 uses a pixel-perfect positioning that no longer relies on this hack.
Alexander Ebert [Sat, 28 May 2022 12:48:22 +0000 (14:48 +0200)]
Missing removal of existing error messages
See https://www.woltlab.com/community/thread/295622-bitte-f%C3%BCllen-sie-dieses-eingabefeld-aus-doppelt-angezeigt/
Alexander Ebert [Sat, 28 May 2022 12:40:49 +0000 (14:40 +0200)]
Bad access the editor from within a dialog
See https://www.woltlab.com/community/thread/295640-%C3%BCber-medien-hinzugef%C3%BCgtes-bild-l%C3%A4sst-sich-nach-der-entfernung-nicht-direkt-erneu/
Alexander Ebert [Sat, 28 May 2022 12:25:55 +0000 (14:25 +0200)]
Merge pull request #4833 from WoltLab/mobile-right-sidebar
Show content of the right sidebar below the main content (mobile view)
Marcel Werk [Sat, 28 May 2022 11:03:23 +0000 (13:03 +0200)]
Show content of the right sidebar below the main content (mobile view)
Alexander Ebert [Thu, 26 May 2022 11:45:20 +0000 (13:45 +0200)]
Show a text cursor while the item list accepts items
Alexander Ebert [Thu, 26 May 2022 11:34:29 +0000 (13:34 +0200)]
Reordered the generic search filters
Tim Düsterhus [Wed, 25 May 2022 13:45:38 +0000 (15:45 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Wed, 25 May 2022 13:44:51 +0000 (15:44 +0200)]
Regenerate composer autoloader
Tim Düsterhus [Wed, 25 May 2022 13:43:01 +0000 (15:43 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 25 May 2022 13:33:31 +0000 (15:33 +0200)]
Regenerate composer autoloader
Tim Düsterhus [Wed, 25 May 2022 13:31:40 +0000 (15:31 +0200)]
Tim Düsterhus [Wed, 25 May 2022 13:30:33 +0000 (15:30 +0200)]
Regenerate composer autoloader
Alexander Ebert [Tue, 24 May 2022 16:38:52 +0000 (18:38 +0200)]
Improved behavior of the mobile search
An already active overlay such as the mobile menu could cause the page to become scrollable.
See https://www.woltlab.com/community/thread/295731-mobil-%C3%B6ffnen-der-suche-nach-%C3%B6ffnen-eines-men%C3%BCs-fehlerhaft/
Marcel Werk [Tue, 24 May 2022 16:20:38 +0000 (18:20 +0200)]
Improved phrases in search form
Marcel Werk [Tue, 24 May 2022 16:06:21 +0000 (18:06 +0200)]
Fixed wrong language variable
Marcel Werk [Tue, 24 May 2022 12:56:13 +0000 (14:56 +0200)]
Removed time information in account ban duration message
Alexander Ebert [Tue, 24 May 2022 09:48:58 +0000 (11:48 +0200)]
Merge branch '5.4' into 5.5
Alexander Ebert [Mon, 23 May 2022 17:08:46 +0000 (19:08 +0200)]
Force case-insensitive check for smiley codes
The smiley table uses a case-insensitive unique key for the smiley code.
See https://www.woltlab.com/community/thread/295708-bug-beim-erstellen-eines-smileys-mit-bereits-vorhandenem-smileycode-duplikat/
Marcel Werk [Mon, 23 May 2022 17:00:48 +0000 (19:00 +0200)]
Content navigation buttons were unintentionally truncated in mobile version
Alexander Ebert [Mon, 23 May 2022 15:59:45 +0000 (17:59 +0200)]
Merge pull request #4825 from WoltLab/standalone-notification-list
Moved the notification list into the global space
Alexander Ebert [Mon, 23 May 2022 15:23:28 +0000 (17:23 +0200)]
Moved the notification list into the global space
The notification list was placed in the user menu a long time ago, but never really fitted in there. The link was already (and continues to be) reachable through the drop-down menu, removing the need of an additional location.
Moving the notification list into the global page space makes more sense and aligns with similar lists such as the conversations.
Alexander Ebert [Mon, 23 May 2022 15:09:52 +0000 (17:09 +0200)]
The extra profile link now starts the edit mode
See https://www.woltlab.com/community/thread/295243-pro-und-kontra-neues-kontrollzentrum/
Alexander Ebert [Mon, 23 May 2022 15:04:16 +0000 (17:04 +0200)]
Mark quotes that have been stripped empty
See https://www.woltlab.com/community/thread/295675-zitieren-von-zitaten-f%C3%BChrt-zu-leerem-zitat/
Alexander Ebert [Mon, 23 May 2022 14:22:51 +0000 (16:22 +0200)]
Incorrect alignment of the user profile header
See https://www.woltlab.com/community/thread/295692-contenttitle-im-benutzerprofil-leicht-versetzt/
Alexander Ebert [Mon, 23 May 2022 14:01:28 +0000 (16:01 +0200)]
Incorrect handling of HTML elements in `<pre>`
Fixes #4824
Tim Düsterhus [Mon, 23 May 2022 08:01:44 +0000 (10:01 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Mon, 23 May 2022 07:58:20 +0000 (09:58 +0200)]
Fix typo in de.xml
Alexander Ebert [Fri, 20 May 2022 14:20:42 +0000 (16:20 +0200)]
Release 5.5.0 Beta 3
Alexander Ebert [Fri, 20 May 2022 14:12:34 +0000 (16:12 +0200)]
Incorrect visuals when the title is alone
See
405de3b60f453dfca0c11555f653128694b7ecb6
WoltLab [Fri, 20 May 2022 14:01:45 +0000 (14:01 +0000)]
Updating minified JavaScript files
Alexander Ebert [Fri, 20 May 2022 13:50:22 +0000 (15:50 +0200)]
Merge pull request #4823 from WoltLab/page-search
Exclude page versions of disabled languages from search results
Alexander Ebert [Fri, 20 May 2022 13:49:32 +0000 (15:49 +0200)]
Merge pull request #4817 from WoltLab/search-by-author
Support search for multiple authors
Alexander Ebert [Fri, 20 May 2022 13:49:10 +0000 (15:49 +0200)]
Merge branch '5.5' into search-by-author
Marcel Werk [Fri, 20 May 2022 13:43:49 +0000 (15:43 +0200)]
Exclude page versions of disabled languages from search results
ref https://www.woltlab.com/community/thread/295670-inexistente-cms-seiten-im-suchindex-nach-entfernen-der-mehrsprachigkeit/
Alexander Ebert [Fri, 20 May 2022 13:20:11 +0000 (15:20 +0200)]
Merge pull request #4819 from WoltLab/search-form-subject-only
Improved structure of the search form filter options
Alexander Ebert [Wed, 18 May 2022 16:38:36 +0000 (18:38 +0200)]
Work-around when closing a closing dialog
See https://www.woltlab.com/community/thread/295669-uidialog-cannot-read-properties-of-undefined-reading-closable/
Marcel Werk [Wed, 18 May 2022 16:24:37 +0000 (18:24 +0200)]
Improved structure of the search form filter options
Alexander Ebert [Wed, 18 May 2022 16:21:59 +0000 (18:21 +0200)]
Image viewer broke during orientation change
See https://www.woltlab.com/community/thread/295628-mobil-bildanzeige-skaliert-beim-drehen/
Marcel Werk [Wed, 18 May 2022 16:15:21 +0000 (18:15 +0200)]
Missing language variable
Marcel Werk [Wed, 18 May 2022 15:46:22 +0000 (17:46 +0200)]
Fixed code style
Marcel Werk [Wed, 18 May 2022 15:39:48 +0000 (17:39 +0200)]
Check if at least one author exists when searching for author
Alexander Ebert [Wed, 18 May 2022 15:39:43 +0000 (17:39 +0200)]
Inconsistent sort order of the mobile ACP header
See https://www.woltlab.com/community/thread/295662-mobiles-men%C3%BC-im-acp/
Marcel Werk [Wed, 18 May 2022 15:33:45 +0000 (17:33 +0200)]
Support search for multiple authors
Marcel Werk [Wed, 18 May 2022 14:17:39 +0000 (16:17 +0200)]
Removed nameExactly option
Tim Düsterhus [Wed, 18 May 2022 13:22:50 +0000 (15:22 +0200)]
Restrict access to `?action=WCFSetup` after successful installation
This action only exists to complete WCFSetup. It should be guarded by a check
an unfinished installation (`!PACKAGE_ID`) to prevent accesses in live
installation.
Marcel Werk [Wed, 18 May 2022 11:30:24 +0000 (13:30 +0200)]
Improved overflow behaviour of the contentInteractionButtons buttons on mobile
Tim Düsterhus [Wed, 18 May 2022 11:00:28 +0000 (13:00 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5
Tim Düsterhus [Wed, 18 May 2022 11:00:17 +0000 (13:00 +0200)]
Merge branch '5.4' into 5.5
Marcel Werk [Wed, 18 May 2022 10:45:06 +0000 (12:45 +0200)]
Improved behaviour for contentHeaderNavigation buttons
ref https://www.woltlab.com/community/thread/295238-%C3%A4nderung-der-reihenfolge-von-antworten-pagination-abonnieren-in-der-mobilen-ansi/?postID=
1894039#post1894039
Tim Düsterhus [Tue, 17 May 2022 14:59:10 +0000 (16:59 +0200)]
Fix typo in WCFSetup
Marcel Werk [Tue, 17 May 2022 08:59:25 +0000 (10:59 +0200)]
Unified phrases for deprecated options
Marcel Werk [Fri, 13 May 2022 11:19:15 +0000 (13:19 +0200)]
Deprecated AMP support
PR #4803 accidentally had the wrong target branch.
(cherry picked from commit
8c97dca561b32b3c02f3cb30b32574a8f83b8bd5)
Marcel Werk [Mon, 16 May 2022 19:47:11 +0000 (21:47 +0200)]
Added documentation of minvalue / maxvalue
Marcel Werk [Mon, 16 May 2022 14:54:01 +0000 (16:54 +0200)]
Email address was not visible in listing of group members
Tim Düsterhus [Mon, 16 May 2022 09:38:35 +0000 (11:38 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5
Alexander Ebert [Sat, 14 May 2022 12:30:38 +0000 (14:30 +0200)]
Incorrect handling of the return focus
Related https://www.woltlab.com/community/thread/295562-inhalte-k%C3%B6nnen-doppelt-gemeldet-werden/
(cherry picked from commit
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812)
Tim Düsterhus [Mon, 16 May 2022 09:37:27 +0000 (11:37 +0200)]
Revert "Suppress errors when disabling the focus trap"
This commit duplicates commit
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812 which is
the cleaner fix, but was accidentally commited to `master` only. We revert this
one to allow for a clean cherry-picking of
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812.
This reverts commit
e7439c4f5fc7daf8d45d2de478c488798ddf463a.
Alexander Ebert [Mon, 16 May 2022 09:36:38 +0000 (11:36 +0200)]
Merge pull request #4808 from WoltLab/55-incorrect-http-204-handling
HTTP 204 does not carry a response type
Tim Düsterhus [Mon, 16 May 2022 09:36:19 +0000 (11:36 +0200)]
Fix `wcf.user.register.error.blacklistMatches` language variable in RegisterForm
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`
Apparently the previously used actions uses an out of date phpcs.
(cherry picked from commit
c5cd836751c3fb357b8ddce52a95a83f3ac46347)
Alexander Ebert [Mon, 16 May 2022 09:31:40 +0000 (11:31 +0200)]
Consistent evaluation of the response content type
Alexander Ebert [Mon, 16 May 2022 09:25:55 +0000 (11:25 +0200)]
Proper handling of a 204 response
Alexander Ebert [Mon, 16 May 2022 09:17:50 +0000 (11:17 +0200)]
HTTP 204 does not carry a `content-type`
See https://www.woltlab.com/community/thread/295631-importer-h%C3%A4ngt-bei-reaktionen-100/
Marcel Werk [Mon, 16 May 2022 07:51:10 +0000 (09:51 +0200)]
Merge pull request #4805 from WoltLab/package-xsd
Added documentation of the void element
Tim Düsterhus [Mon, 16 May 2022 07:42:33 +0000 (09:42 +0200)]
Use correct CodeMirror mode for SCSS inputs
`sass` is the indentation based SASS syntax.
Alexander Ebert [Sun, 15 May 2022 11:20:40 +0000 (13:20 +0200)]
Incorrect markup in the authentication dialog
Alexander Ebert [Sun, 15 May 2022 11:04:54 +0000 (13:04 +0200)]
Suppress errors when disabling the focus trap
Alexander Ebert [Sun, 15 May 2022 11:00:09 +0000 (13:00 +0200)]
Use CSS variable to apply the dialog offset
Alexander Ebert [Sun, 15 May 2022 10:38:59 +0000 (12:38 +0200)]
Revert "Dynamic width of code box line numbers"
This reverts commit
d3853740d8304f9703876006db990c2e01642656.
Alexander Ebert [Sun, 15 May 2022 10:37:51 +0000 (12:37 +0200)]
Dynamic width of code box line numbers
This avoids indenting short code listings too much, especially on screens with limited space.
Alexander Ebert [Sun, 15 May 2022 09:17:08 +0000 (11:17 +0200)]
Do not wrap code boxes on mobile
Having long lines wrap multiple times is horrible, overflow scrolling is much better and also quite natural on touch devices.
Alexander Ebert [Sun, 15 May 2022 09:16:26 +0000 (11:16 +0200)]
Better accessibility of code box buttons
Alexander Ebert [Sun, 15 May 2022 09:04:40 +0000 (11:04 +0200)]
Newer iOS versions permit a click near the bottom
Alexander Ebert [Sat, 14 May 2022 17:13:45 +0000 (19:13 +0200)]
Prevent the "external url" indicator to wrap
See https://www.woltlab.com/community/thread/295487-einzelnes-umbrechen-des-externalurl-icons-verhindern/
Alexander Ebert [Sat, 14 May 2022 17:01:48 +0000 (19:01 +0200)]
Expand the active menu item by default