GitHub/WoltLab/WCF.git
2 years agoStrip MariaDB replication version hack in MySQLDatabase::getVersion()
Tim Düsterhus [Mon, 10 Jan 2022 09:47:49 +0000 (10:47 +0100)]
Strip MariaDB replication version hack in MySQLDatabase::getVersion()

Resolves #4626

2 years agoMerge pull request #4623 from WoltLab/php8.1-i18n-option
Tim Düsterhus [Fri, 7 Jan 2022 13:52:02 +0000 (14:52 +0100)]
Merge pull request #4623 from WoltLab/php8.1-i18n-option

Fix PHP 8.1 compatibility when saving I18n options

2 years agoDefault missing values to `''` in OptionHandler::validateOption()
Tim Düsterhus [Fri, 7 Jan 2022 08:54:19 +0000 (09:54 +0100)]
Default missing values to `''` in OptionHandler::validateOption()

This is required for PHP 8.1 compatibility of i18n options, as these are
handled separately using I18nHandler.

see b46c272b28ba84892534b31c641a6dd412bb0a1e
see 860e98cff580e299cbbd8cdb7eb50d0113b938cc

2 years agoRevert "Fix PHP 8.1 compatibility when saving I18n options"
Tim Düsterhus [Fri, 7 Jan 2022 08:50:28 +0000 (09:50 +0100)]
Revert "Fix PHP 8.1 compatibility when saving I18n options"

During the discussion within the PR is was decided to opt for a different, less
invasive, fix, because the impact of this change is not really clear.

This reverts commit b46c272b28ba84892534b31c641a6dd412bb0a1e.

2 years agoNested tab menus were not preselected on load
Alexander Ebert [Thu, 6 Jan 2022 19:20:12 +0000 (20:20 +0100)]
Nested tab menus were not preselected on load

See https://www.woltlab.com/community/thread/293819-subtab-direkt-aufrufen-geht-nicht/

2 years agoMerge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Marcel Werk [Thu, 6 Jan 2022 17:11:09 +0000 (18:11 +0100)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4

2 years agosignature_max_image_height caused incorrect size of avatars in quotes within signatures
Marcel Werk [Thu, 6 Jan 2022 17:11:01 +0000 (18:11 +0100)]
signature_max_image_height caused incorrect size of avatars in quotes within signatures

Closes #4625

2 years agoFiltering the user list by a user group discarded the optional columns
Alexander Ebert [Thu, 6 Jan 2022 17:08:45 +0000 (18:08 +0100)]
Filtering the user list by a user group discarded the optional columns

Fix for 9bc86ecf0bd32ed2615023bcf9ae398aafbb23fa

See https://www.woltlab.com/community/thread/293719-detailinfos-innerhalb-benutzergruppen-fehlen-im-acp-seit-update-woltlab-suite-5/

2 years agoFix PHP 8.1 compatibility when saving I18n options
Tim Düsterhus [Thu, 6 Jan 2022 09:50:13 +0000 (10:50 +0100)]
Fix PHP 8.1 compatibility when saving I18n options

As I18n options are special-cased, they will not be provided in `rawValues`,
thus passing `null` to `->getData()`, which the option types are not prepared
to handle. Before PHP 8.1 this was implicitly treated as an empty string, with
the types introduced to native functions, e.g. `explode()` or `preg_replace()`
this will result in an error.

2 years agoRun prettier on `acp/style/**/*.scss`
Tim Düsterhus [Tue, 4 Jan 2022 15:10:03 +0000 (16:10 +0100)]
Run prettier on `acp/style/**/*.scss`

2 years agoMerge pull request #4619 from WoltLab/recommend-smtp
Tim Düsterhus [Mon, 3 Jan 2022 14:40:24 +0000 (15:40 +0100)]
Merge pull request #4619 from WoltLab/recommend-smtp

Mark the SMTP email transport as recommended

2 years agoMark the SMTP email transport as recommended
Tim Düsterhus [Mon, 3 Jan 2022 09:21:52 +0000 (10:21 +0100)]
Mark the SMTP email transport as recommended

2 years agoPasting in ItemList did not work
Marcel Werk [Tue, 28 Dec 2021 16:18:10 +0000 (17:18 +0100)]
Pasting in ItemList did not work

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 23 Dec 2021 10:24:45 +0000 (11:24 +0100)]
Merge branch '5.3' into 5.4

2 years agoPass the file's basename to the validation regex in StyleEditor::export()
Tim Düsterhus [Thu, 23 Dec 2021 10:19:25 +0000 (11:19 +0100)]
Pass the file's basename to the validation regex in StyleEditor::export()

This fixes 84f62ddac1ba9894a9cbb8791085f7799f3760c8.

2 years agoRelease 5.4.10 5.4.10
Alexander Ebert [Wed, 22 Dec 2021 16:26:57 +0000 (17:26 +0100)]
Release 5.4.10

2 years agoRelease 5.4.10 dev 2 5.4.10_dev_2
Alexander Ebert [Wed, 22 Dec 2021 14:49:35 +0000 (15:49 +0100)]
Release 5.4.10 dev 2

2 years agoRelease 5.3.16 5.3.16
Alexander Ebert [Wed, 22 Dec 2021 14:46:57 +0000 (15:46 +0100)]
Release 5.3.16

2 years agoUpdating minified JavaScript files
WoltLab [Wed, 22 Dec 2021 14:23:59 +0000 (14:23 +0000)]
Updating minified JavaScript files

2 years agoImproper restore of navigation menu icons
Alexander Ebert [Wed, 22 Dec 2021 14:07:29 +0000 (15:07 +0100)]
Improper restore of navigation menu icons

2 years agoMerge pull request #4610 from WoltLab/54-metacode-parse-attributes
Alexander Ebert [Mon, 20 Dec 2021 15:43:35 +0000 (16:43 +0100)]
Merge pull request #4610 from WoltLab/54-metacode-parse-attributes

Enforce a consistent return type

2 years agoEnforce a consistent return type
Alexander Ebert [Mon, 20 Dec 2021 15:10:27 +0000 (16:10 +0100)]
Enforce a consistent return type

The method was designed to always return an array. If the `\base64_code()` fails, it returned `false` instead, which was both unexpected and could fail in PHP 8.1 (autovivification on false, https://wiki.php.net/rfc/autovivification_false)

2 years agoRelease 5.4.10 dev 1 5.4.10_dev_1
Alexander Ebert [Fri, 17 Dec 2021 16:38:41 +0000 (17:38 +0100)]
Release 5.4.10 dev 1

2 years agoAdd `wcf.user.3rdparty.login.error.user_aborted` phrase
Tim Düsterhus [Fri, 17 Dec 2021 12:34:12 +0000 (13:34 +0100)]
Add `wcf.user.3rdparty.login.error.user_aborted` phrase

2 years agoFix the include family of "functions" in stack trace sanitization
Tim Düsterhus [Fri, 17 Dec 2021 09:31:27 +0000 (10:31 +0100)]
Fix the include family of "functions" in stack trace sanitization

`include` et al are not actual functions, but language constructs. For this
reason they cannot be reflected, causing their arguments to show as
`[error_during_sanitization]`. Fix this by special casing them to not run the
sanitization, they do not contain sensitive arguments (apart from the path
which is redacted independently later).

2 years agoUpdating minified JavaScript files
WoltLab [Thu, 16 Dec 2021 18:09:39 +0000 (18:09 +0000)]
Updating minified JavaScript files

2 years agoSelection changes on mobile were recognized as clicks
Alexander Ebert [Thu, 16 Dec 2021 18:08:23 +0000 (19:08 +0100)]
Selection changes on mobile were recognized as clicks

2 years agoUpdating minified JavaScript files
WoltLab [Thu, 16 Dec 2021 14:47:59 +0000 (14:47 +0000)]
Updating minified JavaScript files

2 years agoRemove dot files from image export
joshuaruesweg [Wed, 15 Dec 2021 08:48:19 +0000 (09:48 +0100)]
Remove dot files from image export

2 years agoRemove obsolete imports
Tim Düsterhus [Tue, 14 Dec 2021 10:24:35 +0000 (11:24 +0100)]
Remove obsolete imports

2 years agoProperly wrap Guzzle's ConnectException into FontDownloadFailed in FontManager
Tim Düsterhus [Tue, 14 Dec 2021 10:02:18 +0000 (11:02 +0100)]
Properly wrap Guzzle's ConnectException into FontDownloadFailed in FontManager

2 years agoMaintain `hasFavicon` attribute during style import
joshuaruesweg [Tue, 14 Dec 2021 09:50:40 +0000 (10:50 +0100)]
Maintain `hasFavicon` attribute during style import

2 years agoAllow file `favicon.ico` for style imports
joshuaruesweg [Tue, 14 Dec 2021 09:49:45 +0000 (10:49 +0100)]
Allow file `favicon.ico` for style imports

2 years agoUpdate scssphp/scssphp once more
Tim Düsterhus [Tue, 14 Dec 2021 09:41:32 +0000 (10:41 +0100)]
Update scssphp/scssphp once more

see aae76af2d247e67d4b812008805ca0f32014366f

2 years agoUpdate scssphp/scssphp to the updated fork
Tim Düsterhus [Tue, 14 Dec 2021 09:32:50 +0000 (10:32 +0100)]
Update scssphp/scssphp to the updated fork

2 years agoFix database and file system getting out of sync for pageLogo in style
Tim Düsterhus [Tue, 14 Dec 2021 09:10:20 +0000 (10:10 +0100)]
Fix database and file system getting out of sync for pageLogo in style

This can happen if the style editor is opened in two tabs and no logo is
configured yet. In Tab (A) an logo is uploaded and then Tab (B) is submitted.
Tab (B) will not provided the `pageLogo` key in the `uploads` parameter,
because nothing in this field was changed. Thus the processing for the logo
does not run. However all style variables are cleared upon an edit, thus
clearing the database reference.

Closes #4606

2 years agoFix wrong return type of LikeObject::getReactions()
joshuaruesweg [Mon, 13 Dec 2021 14:32:16 +0000 (15:32 +0100)]
Fix wrong return type of LikeObject::getReactions()

2 years agoFix UiToggleInput
Tim Düsterhus [Mon, 13 Dec 2021 13:53:18 +0000 (14:53 +0100)]
Fix UiToggleInput

Found with `strictPropertyInitialization`.

2 years agoMake Notification/Handler.ts compatible with useUnknownInCatchVariables
Tim Düsterhus [Mon, 13 Dec 2021 13:46:59 +0000 (14:46 +0100)]
Make Notification/Handler.ts compatible with useUnknownInCatchVariables

2 years agoFix return of any value in RewriteTest.ts
Tim Düsterhus [Mon, 13 Dec 2021 13:08:10 +0000 (14:08 +0100)]
Fix return of any value in RewriteTest.ts

2 years agoSilence `@typescript-eslint/no-unsafe-argument`
Tim Düsterhus [Mon, 13 Dec 2021 13:05:04 +0000 (14:05 +0100)]
Silence `@typescript-eslint/no-unsafe-argument`

2 years agoUpdate eslint
Tim Düsterhus [Mon, 13 Dec 2021 13:04:53 +0000 (14:04 +0100)]
Update eslint

2 years agoUpdate `@types` packages
Tim Düsterhus [Mon, 13 Dec 2021 12:30:15 +0000 (13:30 +0100)]
Update `@types` packages

2 years agoUpdate to prettier 2.5.1
Tim Düsterhus [Mon, 13 Dec 2021 12:29:10 +0000 (13:29 +0100)]
Update to prettier 2.5.1

2 years agoUpdate to TypeScript 4.5.3
Tim Düsterhus [Mon, 13 Dec 2021 12:28:07 +0000 (13:28 +0100)]
Update to TypeScript 4.5.3

2 years agoIncorrect check for the active suggestion
Alexander Ebert [Sat, 11 Dec 2021 12:40:45 +0000 (13:40 +0100)]
Incorrect check for the active suggestion

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 7 Dec 2021 14:08:18 +0000 (15:08 +0100)]
Merge branch '5.3' into 5.4

2 years agoCast `$length` to an actual `int` in TLengthDatabaseTableColumn::length()
mutec [Sun, 28 Nov 2021 10:49:39 +0000 (11:49 +0100)]
Cast `$length` to an actual `int` in TLengthDatabaseTableColumn::length()

When the object is being initialized from the existing structure in the
database, the length will be passed as a string and was previously stored as-is
within the object.

This violates the existing PHPDoc type declaration and breaks consumers that
use a strict comparison (`===`) to check the length, notably
`YearDatabaseTableColumn`.

Fix this by casting the passed parameter to an actual `int`. This should be
adjusted to a proper parameter type in a future version.

Resolves #4594

[Tim: Adjusted commit message]

2 years agoStrip ZERO WIDTH SPACE in StringUtil::trim()
Tim Düsterhus [Mon, 6 Dec 2021 11:31:56 +0000 (12:31 +0100)]
Strip ZERO WIDTH SPACE in StringUtil::trim()

2 years agoRemoving an ACL entry did not persist the current changes to the permissions
Alexander Ebert [Sat, 4 Dec 2021 18:24:58 +0000 (19:24 +0100)]
Removing an ACL entry did not persist the current changes to the permissions

2 years agoDeselecting columns for the user result list was overridden by defaults
Alexander Ebert [Sat, 4 Dec 2021 16:29:59 +0000 (17:29 +0100)]
Deselecting columns for the user result list was overridden by defaults

See https://community.woltlab.com/thread/292760-acp-benutzersuche/

2 years agoRestrict the width of the login form
Alexander Ebert [Sat, 4 Dec 2021 16:10:31 +0000 (17:10 +0100)]
Restrict the width of the login form

See https://community.woltlab.com/thread/293054-xsrf-fehlermeldung-beim-acp-login-sieht-b%C3%A4h-b%C3%A4h-aus/

2 years agoGracefully handle missing permissions to delete cover photos
Alexander Ebert [Sat, 4 Dec 2021 15:48:57 +0000 (16:48 +0100)]
Gracefully handle missing permissions to delete cover photos

2 years agoDo not block the DevTools language switch if viewing a non-CMS page
Alexander Ebert [Sat, 4 Dec 2021 15:14:49 +0000 (16:14 +0100)]
Do not block the DevTools language switch if viewing a non-CMS page

2 years agoIncorrect cleanup of pasted tables
Alexander Ebert [Sat, 4 Dec 2021 14:24:17 +0000 (15:24 +0100)]
Incorrect cleanup of pasted tables

2 years agoIncorrect detection of the last child of a list element when backspacing empty lines
Alexander Ebert [Wed, 1 Dec 2021 18:53:31 +0000 (19:53 +0100)]
Incorrect detection of the last child of a list element when backspacing empty lines

2 years agoIncorrect backspacing of empty paragraphs in list with adjacent lists
Alexander Ebert [Wed, 1 Dec 2021 18:09:28 +0000 (19:09 +0100)]
Incorrect backspacing of empty paragraphs in list with adjacent lists

2 years agoCheck the name of the PRIMARY KEY in PHP DDL
Tim Düsterhus [Wed, 1 Dec 2021 09:51:15 +0000 (10:51 +0100)]
Check the name of the PRIMARY KEY in PHP DDL

Resolves #4592

2 years agoRelease 5.4.9 5.4.9
Alexander Ebert [Tue, 30 Nov 2021 15:10:34 +0000 (16:10 +0100)]
Release 5.4.9

2 years agoMerge branch '5.3' into 5.4
Alexander Ebert [Tue, 30 Nov 2021 15:00:49 +0000 (16:00 +0100)]
Merge branch '5.3' into 5.4

2 years agoRelease 5.3.15 5.3.15
Alexander Ebert [Tue, 30 Nov 2021 14:41:50 +0000 (15:41 +0100)]
Release 5.3.15

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 30 Nov 2021 14:34:02 +0000 (14:34 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Tue, 30 Nov 2021 14:31:49 +0000 (15:31 +0100)]
Merge branch '5.2' into 5.3

2 years agoRelease 5.2.16 5.2.16
Alexander Ebert [Tue, 30 Nov 2021 13:33:28 +0000 (14:33 +0100)]
Release 5.2.16

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 30 Nov 2021 13:26:57 +0000 (13:26 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 30 Nov 2021 13:25:15 +0000 (14:25 +0100)]
Merge branch '3.1' into 5.2

2 years agoUpdating minified JavaScript files 3.1.24
WoltLab [Tue, 30 Nov 2021 12:57:10 +0000 (12:57 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 30 Nov 2021 10:30:44 +0000 (11:30 +0100)]
Merge branch '5.3' into 5.4

2 years agoFixed suffix declaration in XSD
Sascha Greuel [Tue, 30 Nov 2021 10:23:56 +0000 (11:23 +0100)]
Fixed suffix declaration in XSD

As of now, a suffix is only allowed for option categories, which is wrong,
because a suffix can only be applied to an option itself.

Resolves #4596

2 years agoRelease 3.1.24
Alexander Ebert [Tue, 30 Nov 2021 10:01:51 +0000 (11:01 +0100)]
Release 3.1.24

2 years agoRelease 5.4.9 dev 2 5.4.9_dev_2
Alexander Ebert [Mon, 22 Nov 2021 16:28:56 +0000 (17:28 +0100)]
Release 5.4.9 dev 2

2 years agoUpdating minified JavaScript files
WoltLab [Mon, 22 Nov 2021 16:21:26 +0000 (16:21 +0000)]
Updating minified JavaScript files

2 years agoUnable to insert new links into the editor
Alexander Ebert [Mon, 22 Nov 2021 16:19:55 +0000 (17:19 +0100)]
Unable to insert new links into the editor

Fixes 3222504e625d0760d82edc4856cda903be8d7497

2 years agoMerge pull request #4589 from WoltLab/5.4-vb5crypt
Tim Düsterhus [Mon, 22 Nov 2021 11:39:41 +0000 (12:39 +0100)]
Merge pull request #4589 from WoltLab/5.4-vb5crypt

Add `Vb5Bcrypt` password algorithm

2 years agoAdd `Vb5Bcrypt` password algorithm
joshuaruesweg [Mon, 22 Nov 2021 11:24:54 +0000 (12:24 +0100)]
Add `Vb5Bcrypt` password algorithm

2 years agoRelease 5.4.9 dev 1 5.4.9_dev_1
Alexander Ebert [Sun, 21 Nov 2021 22:48:12 +0000 (23:48 +0100)]
Release 5.4.9 dev 1

2 years agoUpdating minified JavaScript files
WoltLab [Sat, 20 Nov 2021 13:46:26 +0000 (13:46 +0000)]
Updating minified JavaScript files

2 years agoIncorrect `width` of images for embedded links
Alexander Ebert [Sat, 20 Nov 2021 12:40:17 +0000 (13:40 +0100)]
Incorrect `width` of images for embedded links

Replaces #4587

2 years agoWorkaround to recover tmpHashes for attachments for the `wcf\form\MessageForm`
Alexander Ebert [Fri, 19 Nov 2021 16:59:04 +0000 (17:59 +0100)]
Workaround to recover tmpHashes for attachments for the `wcf\form\MessageForm`

Fixes WoltLab/com.woltlab.wbb#504

2 years agoIncorrect version number in the installer
Alexander Ebert [Thu, 11 Nov 2021 10:22:08 +0000 (11:22 +0100)]
Incorrect version number in the installer

2 years agoMerge branch '5.3' into 5.4
Alexander Ebert [Wed, 10 Nov 2021 18:23:39 +0000 (19:23 +0100)]
Merge branch '5.3' into 5.4

2 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 10 Nov 2021 18:22:29 +0000 (19:22 +0100)]
Merge branch '5.2' into 5.3

2 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 10 Nov 2021 18:22:18 +0000 (19:22 +0100)]
Merge branch '3.1' into 5.2

2 years agoIncorrect reset of the timer to show the loading indicator
Alexander Ebert [Wed, 10 Nov 2021 18:21:40 +0000 (19:21 +0100)]
Incorrect reset of the timer to show the loading indicator

The missing reset caused repeated calls to `show()` being effectively ignored, because the check `_timeoutShow === null` would be always true if the callback was cancelled before.

See https://community.woltlab.com/thread/293232-ajaxstatus-wird-nach-einem-fehlerhaften-request-nicht-wieder-angezeigt/

2 years agoEnforce the aspect ratio when capping the image height
Alexander Ebert [Wed, 10 Nov 2021 17:35:43 +0000 (18:35 +0100)]
Enforce the aspect ratio when capping the image height

2 years agoFix for code boxes inside quotes
Alexander Ebert [Sun, 7 Nov 2021 15:11:48 +0000 (16:11 +0100)]
Fix for code boxes inside quotes

2 years agoRemoved the (hidden) links in the article lists
Alexander Ebert [Sat, 6 Nov 2021 14:03:09 +0000 (15:03 +0100)]
Removed the (hidden) links in the article lists

The links in the footer are inaccessible due to the title link which spans the entire element. They serve no real purpose anyway and can simply be left out, also improving keyboard navigation by skipping pointless links.

See https://community.woltlab.com/thread/292905-artikelauflistung-link-zu-benutzer-geht-nicht/

2 years agoIncorrect position of the edit options for messages on mobile
Alexander Ebert [Sat, 6 Nov 2021 13:51:41 +0000 (14:51 +0100)]
Incorrect position of the edit options for messages on mobile

See https://community.woltlab.com/thread/293126-beitrag-bearbeiten-mobil-nur-schwer-oder-nicht-immer-m%C3%B6glich/

2 years agoPreserve the link that is being edited when the focus is lost
Alexander Ebert [Sat, 6 Nov 2021 13:05:58 +0000 (14:05 +0100)]
Preserve the link that is being edited when the focus is lost

See https://community.woltlab.com/thread/292962-link-bearbeiten-funktioniert-auf-einigen-mobilen-ger%C3%A4ten-nicht/

2 years agoImproved the position of the link tooltip on small screens
Alexander Ebert [Sat, 6 Nov 2021 12:22:44 +0000 (13:22 +0100)]
Improved the position of the link tooltip on small screens

2 years agoWorkaround for a gap with fullscreen dialogs on iOS
Alexander Ebert [Sat, 6 Nov 2021 11:31:31 +0000 (12:31 +0100)]
Workaround for a gap with fullscreen dialogs on iOS

See https://community.woltlab.com/thread/292818-fehler-bei-der-anzeige-von-reaktionen-in-der-mobilen-ansicht/

2 years agoExpose the article bbcode template to the admin panel
Alexander Ebert [Fri, 5 Nov 2021 17:05:49 +0000 (18:05 +0100)]
Expose the article bbcode template to the admin panel

See https://community.woltlab.com/thread/292627-artikelvorschau-funktioniert-nicht-bei-nutzung-von-wsa-bb-code/

2 years agoUpdate to WoltLab/zxcvbn@5b582b24e437f1883ccad3c37dae7c3c5f1e7da3
Tim Düsterhus [Fri, 5 Nov 2021 11:33:05 +0000 (12:33 +0100)]
Update to WoltLab/zxcvbn@5b582b24e437f1883ccad3c37dae7c3c5f1e7da3

see #4578

2 years agoUpdate to WoltLab/zxcvbn@06171c20f9bc1f4fbfbf12ba5c88bc1db0624970
Tim Düsterhus [Fri, 5 Nov 2021 11:16:27 +0000 (12:16 +0100)]
Update to WoltLab/zxcvbn@06171c20f9bc1f4fbfbf12ba5c88bc1db0624970

see #4578

2 years agoUpdate to WoltLab/zxcvbn@ade1e45a9a744600124f760243535b366ce76483
Tim Düsterhus [Fri, 5 Nov 2021 10:56:08 +0000 (11:56 +0100)]
Update to WoltLab/zxcvbn@ade1e45a9a744600124f760243535b366ce76483

Resolves #4578

2 years agoFix typo in TS comment
mutec [Thu, 4 Nov 2021 18:03:19 +0000 (19:03 +0100)]
Fix typo in TS comment

see #4577

2 years agoClean up attachment tmpHash handling in WYSIWYG autosave (#4576)
Tim Düsterhus [Thu, 4 Nov 2021 14:54:19 +0000 (15:54 +0100)]
Clean up attachment tmpHash handling in WYSIWYG autosave (#4576)

The previous `.splice()` call was erroneous because it might remove more
entries in case the to-be-removed entry is not the last within the array for
whatever reason.

Replace the whole logic with a modern `.filter()`, cleanly filtering out all
existing entries for the current `tmpHash` and then readding it, if it still is
required.

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 4 Nov 2021 14:38:16 +0000 (15:38 +0100)]
Merge branch '5.3' into 5.4

2 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 4 Nov 2021 14:35:33 +0000 (15:35 +0100)]
Merge branch '5.2' into 5.3

2 years agoFix error message for `foreignColumnChange` in PHP DDL API
Tim Düsterhus [Thu, 4 Nov 2021 14:34:47 +0000 (15:34 +0100)]
Fix error message for `foreignColumnChange` in PHP DDL API