GitHub/moto-9609/android_kernel_motorola_exynos9610.git
7 years agoALSA: control: code refactoring for ELEM_READ/ELEM_WRITE operations
Takashi Sakamoto [Sun, 20 Aug 2017 04:49:07 +0000 (13:49 +0900)]
ALSA: control: code refactoring for ELEM_READ/ELEM_WRITE operations

ALSA control core handles ELEM_READ/ELEM_WRITE requests within lock
acquisition of a counting semaphore. The lock is acquired in helper
functions in the end of call path before calling implementations of each
driver.

ioctl(2) with SNDRV_CTL_ELEM_READ
...
->snd_ctl_ioctl()
  ->snd_ctl_elem_read_user()
    ->snd_ctl_elem_read()
      ->down_read(controls_rwsem)
      ->snd_ctl_find_id()
      ->struct snd_kcontrol.get()
      ->up_read(controls_rwsem)

ioctl(2) with SNDRV_CTL_ELEM_WRITE
...
->snd_ctl_ioctl()
  ->snd_ctl_elem_write_user()
    ->snd_ctl_elem_write()
      ->down_read(controls_rwsem)
      ->snd_ctl_find_id()
      ->struct snd_kcontrol.put()
      ->up_read(controls_rwsem)

This commit moves the lock acquisition to middle of the call graph to
simplify the helper functions. As a result:

ioctl(2) with SNDRV_CTL_ELEM_READ
...
->snd_ctl_ioctl()
  ->snd_ctl_elem_read_user()
    ->down_read(controls_rwsem)
    ->snd_ctl_elem_read()
      ->snd_ctl_find_id()
      ->struct snd_kcontrol.get()
    ->up_read(controls_rwsem)

ioctl(2) with SNDRV_CTL_ELEM_WRITE
...
->snd_ctl_ioctl()
  ->snd_ctl_elem_write_user()
    ->down_read(controls_rwsem)
    ->snd_ctl_elem_write()
      ->snd_ctl_find_id()
      ->struct snd_kcontrol.put()
    ->up_read(controls_rwsem)

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: control: queue events within locking of controls_rwsem for ELEM_WRITE operation
Takashi Sakamoto [Sun, 20 Aug 2017 04:49:06 +0000 (13:49 +0900)]
ALSA: control: queue events within locking of controls_rwsem for ELEM_WRITE operation

Any control event is queued by a call of snd_ctl_notify(). This function
adds the event to each queue of opened file data corresponding to ALSA
control character devices. This function acquired two types of lock; a
counting semaphore for a list of the opened file data and a spinlock for
card data opened by the file. Typically, this function is called after
acquiring a counting semaphore for a list of elements in the card data.

In current implementation of a handler for ELEM_WRITE request, the
function is called after releasing the semaphore for a list of elements
in the card data. This release is not necessarily needed.

This commit removes the release to call the function within the critical
section so that later commits are simple.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usb: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:21 +0000 (13:15 +0530)]
ALSA: usb: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: spi: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:20 +0000 (13:15 +0530)]
ALSA: spi: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sparc: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:19 +0000 (13:15 +0530)]
ALSA: sparc: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sh: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:18 +0000 (13:15 +0530)]
ALSA: sh: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ppc: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:17 +0000 (13:15 +0530)]
ALSA: ppc: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pcmcia: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:16 +0000 (13:15 +0530)]
ALSA: pcmcia: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: parisc: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:15 +0000 (13:15 +0530)]
ALSA: parisc: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mips: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:14 +0000 (13:15 +0530)]
ALSA: mips: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: firewire: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:13 +0000 (13:15 +0530)]
ALSA: firewire: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: drivers: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:12 +0000 (13:15 +0530)]
ALSA: drivers: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: atmel: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:11 +0000 (13:15 +0530)]
ALSA: atmel: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: arm: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:10 +0000 (13:15 +0530)]
ALSA: arm: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: aoa: constify snd_pcm_ops structures
Arvind Yadav [Fri, 18 Aug 2017 07:45:09 +0000 (13:15 +0530)]
ALSA: aoa: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usb-audio: don't retry snd_usb_ctl_msg after timeout
Stephen Barber [Thu, 17 Aug 2017 22:17:46 +0000 (15:17 -0700)]
ALSA: usb-audio: don't retry snd_usb_ctl_msg after timeout

A few calls to snd_usb_ctl_msg wrap the function in a retry loop. In
the worst case, the timeout for snd_usb_ctl_msg is 5 seconds, which when
retried 10 times (for example, if a device is removed) could cause a
probe to hang for ~50 seconds.

Example stack trace from 3.14 which triggered a hung task timeout:
Call Trace:
 [<ffffffffa2c1f720>] ? inet6_set_link_af.part.35+0x12/0x12
 [<ffffffffa2c20309>] schedule+0x6e/0x70
 [<ffffffffa2c1f81c>] schedule_timeout+0xfc/0x13c
 [<ffffffffa2667bbc>] ? rcu_read_unlock_sched_notrace+0x17/0x17
 [<ffffffffa2c20d68>] __wait_for_common+0x153/0x190
 [<ffffffffa2c20d68>] ? __wait_for_common+0x153/0x190
 [<ffffffffa26890e5>] ? wake_up_state+0x12/0x12
 [<ffffffffa2c20e0e>] wait_for_completion_timeout+0x1d/0x1f
 [<ffffffffa2a07c70>] usb_start_wait_urb+0x93/0xf1
 [<ffffffffa2a07daf>] usb_control_msg+0xe1/0x11d
 [<ffffffffc02cd254>] snd_usb_ctl_msg+0x9c/0xf1 [snd_usb_audio]
 [<ffffffffc02ce191>] snd_usb_mixer_set_ctl_value+0x124/0xab1 [snd_usb_audio]
 [<ffffffffc02ce230>] snd_usb_mixer_set_ctl_value+0x1c3/0xab1 [snd_usb_audio]
 [<ffffffffc02ce58e>] snd_usb_mixer_set_ctl_value+0x521/0xab1 [snd_usb_audio]
 [<ffffffffc02cee88>] snd_usb_mixer_add_control+0x36a/0x1264 [snd_usb_audio]
 [<ffffffffc02cf323>] snd_usb_mixer_add_control+0x805/0x1264 [snd_usb_audio]
 [<ffffffffa2a06e11>] ? usb_free_urb+0x1a/0x1c
 [<ffffffffc02cfcf7>] snd_usb_mixer_add_control+0x11d9/0x1264 [snd_usb_audio]
 [<ffffffffc02d000f>] snd_usb_create_mixer+0xbc/0x286 [snd_usb_audio]
 [<ffffffffc02cac18>] 0xffffffffc02cac17
 [<ffffffffa2a0aaf1>] usb_probe_interface+0x17c/0x21c
 [<ffffffffa29a65bc>] driver_probe_device+0xae/0x1fa
 [<ffffffffa29a6767>] __device_attach_driver+0x5f/0x66
 [<ffffffffa29a6708>] ? driver_probe_device+0x1fa/0x1fa
 [<ffffffffa29a4a60>] bus_for_each_drv+0x87/0xaa
 [<ffffffffa29a688a>] __device_attach+0x9d/0x101
 [<ffffffffa29a6913>] device_initial_probe+0x13/0x15
 [<ffffffffa29a5ae6>] bus_probe_device+0x33/0x96
 [<ffffffffa29a3d19>] device_add+0x328/0x547
 [<ffffffffa2a09355>] usb_set_configuration+0x624/0x674
 [<ffffffffa2a11949>] generic_probe+0x45/0x77
 [<ffffffffa2a0a962>] usb_probe_device+0x2d/0x40
 [<ffffffffa29a65bc>] driver_probe_device+0xae/0x1fa
 [<ffffffffa29a6767>] __device_attach_driver+0x5f/0x66
 [<ffffffffa29a6708>] ? driver_probe_device+0x1fa/0x1fa
 [<ffffffffa29a4a60>] bus_for_each_drv+0x87/0xaa
 [<ffffffffa29a688a>] __device_attach+0x9d/0x101
 [<ffffffffa29a6913>] device_initial_probe+0x13/0x15
 [<ffffffffa29a5ae6>] bus_probe_device+0x33/0x96
 [<ffffffffa29a3d19>] device_add+0x328/0x547
 [<ffffffffa29030bc>] ? add_device_randomness+0x111/0x130
 [<ffffffffa2a00967>] usb_new_device+0x2a2/0x3c0
 [<ffffffffa2a02ddc>] hub_thread+0xa3d/0xeed
 [<ffffffffa2c2010d>] ? __schedule+0x41e/0x5ac
 [<ffffffffa26957ce>] ? finish_wait+0x62/0x62
 [<ffffffffa2a0239f>] ? usb_reset_device+0x16a/0x16a
 [<ffffffffa267b255>] kthread+0x108/0x110
 [<ffffffffa267b14d>] ? __kthread_parkme+0x67/0x67
 [<ffffffffa2c23b2c>] ret_from_fork+0x7c/0xb0
 [<ffffffffa267b14d>] ? __kthread_parkme+0x67/0x67

Signed-off-by: Stephen Barber <smbarber@chromium.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: parisc: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:16:00 +0000 (14:46 +0530)]
ALSA: parisc: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usb: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:59 +0000 (14:45 +0530)]
ALSA: usb: make snd_pcm_hardware const

Make this const as it is only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sparc: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:58 +0000 (14:45 +0530)]
ALSA: sparc: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sh: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:57 +0000 (14:45 +0530)]
ALSA: sh: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ppc: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:56 +0000 (14:45 +0530)]
ALSA: ppc: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pcmcia: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:55 +0000 (14:45 +0530)]
ALSA: pcmcia: make snd_pcm_hardware const

Make this const as it is only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pci: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:54 +0000 (14:45 +0530)]
ALSA: pci: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mips: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:53 +0000 (14:45 +0530)]
ALSA: mips: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: isa: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:52 +0000 (14:45 +0530)]
ALSA: isa: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: drivers: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:51 +0000 (14:45 +0530)]
ALSA: drivers: make snd_pcm_hardware const

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: atmel: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:50 +0000 (14:45 +0530)]
ALSA: atmel: make snd_pcm_hardware const

Make this const as it is only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: arm: make snd_pcm_hardware const
Bhumika Goyal [Thu, 17 Aug 2017 09:15:49 +0000 (14:45 +0530)]
ALSA: arm: make snd_pcm_hardware const

Make this const as it is only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: wavefront: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:30 +0000 (15:36 +0530)]
ALSA: wavefront: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sscape: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:29 +0000 (15:36 +0530)]
ALSA: sscape: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sb16: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:28 +0000 (15:36 +0530)]
ALSA: sb16: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: opti9xx: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:27 +0000 (15:36 +0530)]
ALSA: opti9xx: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: msnd: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:26 +0000 (15:36 +0530)]
ALSA: msnd: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: gus: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:25 +0000 (15:36 +0530)]
ALSA: gus: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: es1688: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:24 +0000 (15:36 +0530)]
ALSA: es1688: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: cs4236: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:23 +0000 (15:36 +0530)]
ALSA: cs4236: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: cmi8330: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:22 +0000 (15:36 +0530)]
ALSA: cmi8330: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: azt2320: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:21 +0000 (15:36 +0530)]
ALSA: azt2320: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: als100: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:20 +0000 (15:36 +0530)]
ALSA: als100: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ad1816a: constify pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:19 +0000 (15:36 +0530)]
ALSA: ad1816a: constify pnp_card_device_id

pnp_card_device_id are not supposed to change at runtime. All functions
working with pnp_card_device_id provided by <linux/pnp.h> work with
const pnp_card_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:18 +0000 (15:36 +0530)]
ALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id

*_device_id are not supposed to change at runtime. All functions
working with *_device_id provided by <linux/pnp.h> work with
const *_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: es18xx: constify pnp_device_id and pnp_card_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:17 +0000 (15:36 +0530)]
ALSA: es18xx: constify pnp_device_id and pnp_card_device_id

*_device_id are not supposed to change at runtime. All functions
working with *_device_id provided by <linux/pnp.h> work with
const *_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: drivers: mpu401: constify pnp_device_id
Arvind Yadav [Thu, 17 Aug 2017 10:06:16 +0000 (15:36 +0530)]
ALSA: drivers: mpu401: constify pnp_device_id

pnp_device_id are not supposed to change at runtime. All functions
working with pnp_device_id provided by <linux/pnp.h> work with
const pnp_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: hda: make snd_kcontrol_new const
Bhumika Goyal [Wed, 16 Aug 2017 08:44:11 +0000 (14:14 +0530)]
ALSA: hda: make snd_kcontrol_new const

Make these const as they are only passed as the 3rd argument to the
function snd_hda_gen_add_kctl, which is of type const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pcxhr: make snd_kcontrol_new const
Bhumika Goyal [Wed, 16 Aug 2017 08:44:10 +0000 (14:14 +0530)]
ALSA: pcxhr: make snd_kcontrol_new const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: aoa: make snd_kcontrol_new const
Bhumika Goyal [Wed, 16 Aug 2017 08:44:09 +0000 (14:14 +0530)]
ALSA: aoa: make snd_kcontrol_new const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: firewire-motu: constify snd_rawmidi_ops structures
Julia Lawall [Tue, 15 Aug 2017 08:09:54 +0000 (10:09 +0200)]
ALSA: firewire-motu: constify snd_rawmidi_ops structures

These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops.  This argument is const, so the
snd_rawmidi_ops structures can be const too.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agosound: emu8000: constify emu8000_ops
Julia Lawall [Mon, 14 Aug 2017 17:13:26 +0000 (19:13 +0200)]
sound: emu8000: constify emu8000_ops

The structure emu8000_ops is only copied into another structure, so
it can be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme9652: Use common error handling code in two functions
Markus Elfring [Mon, 14 Aug 2017 20:00:40 +0000 (22:00 +0200)]
ALSA: rme9652: Use common error handling code in two functions

Add a jump target so that a bit of exception handling can be better reused
in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: wss: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:07 +0000 (17:28 +0530)]
ALSA: wss: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sb8: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:06 +0000 (17:28 +0530)]
ALSA: sb8: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sb16: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:05 +0000 (17:28 +0530)]
ALSA: sb16: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: emu8000: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:04 +0000 (17:28 +0530)]
ALSA: emu8000: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: msnd: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:03 +0000 (17:28 +0530)]
ALSA: msnd: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: gus: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:02 +0000 (17:28 +0530)]
ALSA: gus: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: es18xx: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:01 +0000 (17:28 +0530)]
ALSA: es18xx: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: es1688: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:58:00 +0000 (17:28 +0530)]
ALSA: es1688: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ad1816a: constify snd_pcm_ops structures
Arvind Yadav [Fri, 11 Aug 2017 11:57:59 +0000 (17:27 +0530)]
ALSA: ad1816a: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mpu401: Adjust four checks for null pointers
Markus Elfring [Sat, 12 Aug 2017 18:50:16 +0000 (20:50 +0200)]
ALSA: mpu401: Adjust four checks for null pointers

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mpu401: Use common error handling code in snd_mpu401_uart_new()
Markus Elfring [Sat, 12 Aug 2017 18:40:17 +0000 (20:40 +0200)]
ALSA: mpu401: Use common error handling code in snd_mpu401_uart_new()

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mpu401: Delete an error message for a failed memory allocation in snd_mpu401_ua...
Markus Elfring [Sat, 12 Aug 2017 18:20:11 +0000 (20:20 +0200)]
ALSA: mpu401: Delete an error message for a failed memory allocation in snd_mpu401_uart_new()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new()
Markus Elfring [Sat, 12 Aug 2017 17:54:20 +0000 (19:54 +0200)]
ALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pc...
Markus Elfring [Sat, 12 Aug 2017 17:09:23 +0000 (19:09 +0200)]
ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_cr...
Markus Elfring [Sat, 12 Aug 2017 16:45:42 +0000 (18:45 +0200)]
ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create()
Markus Elfring [Sat, 12 Aug 2017 16:14:54 +0000 (18:14 +0200)]
ALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pci: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:28 +0000 (21:01 +0530)]
ALSA: pci: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ymfpci: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:27 +0000 (21:01 +0530)]
ALSA: ymfpci: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: trident: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:26 +0000 (21:01 +0530)]
ALSA: trident: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme9652: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:25 +0000 (21:01 +0530)]
ALSA: rme9652: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: riptide: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:24 +0000 (21:01 +0530)]
ALSA: riptide: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: pcxhr: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:23 +0000 (21:01 +0530)]
ALSA: pcxhr: make snd_pcm_hardware const

Make this const as it is only used during a copy operation.
Done using Coccinelle

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ctxfi: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:22 +0000 (21:01 +0530)]
ALSA: ctxfi: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: mixart: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:21 +0000 (21:01 +0530)]
ALSA: mixart: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: lx6464es: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:20 +0000 (21:01 +0530)]
ALSA: lx6464es: make snd_pcm_hardware const

Make this const as it is only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: lola: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:19 +0000 (21:01 +0530)]
ALSA: lola: make snd_pcm_hardware const

Make this const as it is only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: emu10k1: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:18 +0000 (21:01 +0530)]
ALSA: emu10k1: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: cs5535audio: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:17 +0000 (21:01 +0530)]
ALSA: cs5535audio: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: korg1212: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:16 +0000 (21:01 +0530)]
ALSA: korg1212: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: cs46xx: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:15 +0000 (21:01 +0530)]
ALSA: cs46xx: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ca0106: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:14 +0000 (21:01 +0530)]
ALSA: ca0106: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: aw2: make snd_pcm_hardware const
Bhumika Goyal [Sat, 12 Aug 2017 15:31:13 +0000 (21:01 +0530)]
ALSA: aw2: make snd_pcm_hardware const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme9652: Adjust seven checks for null pointers
Markus Elfring [Sat, 12 Aug 2017 15:07:09 +0000 (17:07 +0200)]
ALSA: rme9652: Adjust seven checks for null pointers

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written …

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme9652: Improve eight size determinations
Markus Elfring [Sat, 12 Aug 2017 14:50:06 +0000 (16:50 +0200)]
ALSA: rme9652: Improve eight size determinations

Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme9652: Delete an error message for a failed memory allocation in snd_hdspm_cr...
Markus Elfring [Sat, 12 Aug 2017 14:10:32 +0000 (16:10 +0200)]
ALSA: rme9652: Delete an error message for a failed memory allocation in snd_hdspm_create()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme96: Adjust five checks for null pointers
Markus Elfring [Sat, 12 Aug 2017 13:18:56 +0000 (15:18 +0200)]
ALSA: rme96: Adjust five checks for null pointers

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written …

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme96: Use common error handling code in snd_rme96_probe()
Markus Elfring [Sat, 12 Aug 2017 12:50:33 +0000 (14:50 +0200)]
ALSA: rme96: Use common error handling code in snd_rme96_probe()

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: rme96: Delete two error messages for a failed memory allocation in snd_rme96_pr...
Markus Elfring [Sat, 12 Aug 2017 12:24:41 +0000 (14:24 +0200)]
ALSA: rme96: Delete two error messages for a failed memory allocation in snd_rme96_probe()

Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: trident: Delete an error message for a failed memory allocation in snd_trident_...
Markus Elfring [Sat, 12 Aug 2017 11:20:16 +0000 (13:20 +0200)]
ALSA: trident: Delete an error message for a failed memory allocation in snd_trident_tlb_alloc()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation...
Markus Elfring [Fri, 11 Aug 2017 17:39:06 +0000 (19:39 +0200)]
ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs()

Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

[Fixed the unused variable warning by this change as well -- tiwai]

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usb: Delete an error message for a failed memory allocation in two functions
Markus Elfring [Fri, 11 Aug 2017 16:38:25 +0000 (18:38 +0200)]
ALSA: usb: Delete an error message for a failed memory allocation in two functions

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: usx2y: Delete an error message for a failed memory allocation in two functions
Markus Elfring [Fri, 11 Aug 2017 15:40:57 +0000 (17:40 +0200)]
ALSA: usx2y: Delete an error message for a failed memory allocation in two functions

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: trident: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:38 +0000 (17:17 +0530)]
ALSA: trident: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: sis7019: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:37 +0000 (17:17 +0530)]
ALSA: sis7019: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: intel8x0m: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:36 +0000 (17:17 +0530)]
ALSA: intel8x0m: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: intel8x0: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:35 +0000 (17:17 +0530)]
ALSA: intel8x0: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: echoaudio: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:34 +0000 (17:17 +0530)]
ALSA: echoaudio: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: au88x0: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:33 +0000 (17:17 +0530)]
ALSA: au88x0: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: ali5451: constify snd_pcm_ops structures
Arvind Yadav [Thu, 10 Aug 2017 11:47:32 +0000 (17:17 +0530)]
ALSA: ali5451: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: emux: Delete two error messages for a failed memory allocation in snd_emux_crea...
Markus Elfring [Wed, 9 Aug 2017 07:30:34 +0000 (09:30 +0200)]
ALSA: emux: Delete two error messages for a failed memory allocation in snd_emux_create_port()

Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
7 years agoALSA: emux: Adjust four checks for null pointers
Markus Elfring [Wed, 9 Aug 2017 07:22:42 +0000 (09:22 +0200)]
ALSA: emux: Adjust four checks for null pointers

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>