GitHub/WoltLab/WCF.git
4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Tue, 28 Apr 2020 11:33:28 +0000 (13:33 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrecise check for ImageMagick
Alexander Ebert [Tue, 28 Apr 2020 11:33:13 +0000 (13:33 +0200)]
Precise check for ImageMagick

The previous check was inaccurate, because it did not consider improperly configured environments that have selected ImageMagick, but did not provide it.

4 years agoMerge pull request #3220 from WoltLab/enterprise-mode-user-group-option-form
Alexander Ebert [Mon, 27 Apr 2020 17:30:52 +0000 (19:30 +0200)]
Merge pull request #3220 from WoltLab/enterprise-mode-user-group-option-form

Overly restrictive access to permissions

4 years agoMerge pull request #3221 from WoltLab/resize-chrome-bug
Tim Düsterhus [Sun, 26 Apr 2020 13:23:21 +0000 (15:23 +0200)]
Merge pull request #3221 from WoltLab/resize-chrome-bug

Work around bug in createImageBitmap in Chrome

4 years agoWork around bug in createImageBitmap in Chrome
Tim Düsterhus [Sun, 26 Apr 2020 12:55:52 +0000 (14:55 +0200)]
Work around bug in createImageBitmap in Chrome

Google Chrome returns inconsistent sizing between `img.(width|height)` and
the (width|height) of the bitmap returned by `createImageBitmap()`.

See: https://bugs.chromium.org/p/chromium/issues/detail?id=1069965

This mismatch causes Pica to corrupt the resulting image.

This commit disables resizing when the bug is detected. The behavior might
need to be re-adjusted depending on what behavior Chrome's fix will result
in.

4 years agoOverly restrictive access to permissions
Alexander Ebert [Sun, 26 Apr 2020 11:24:51 +0000 (13:24 +0200)]
Overly restrictive access to permissions

The changes in #3206 were not applied to the UserGroupOptionForm, incorrectly enforcing limits on administrator when running in enterprise mode.

4 years agoDisallow changes to the `mail_from_address` when running in enterprise mode
Alexander Ebert [Sat, 25 Apr 2020 22:09:36 +0000 (00:09 +0200)]
Disallow changes to the `mail_from_address` when running in enterprise mode

4 years agoSkip the master password for the owner group when running in enterprise mode
Alexander Ebert [Sat, 25 Apr 2020 18:39:29 +0000 (20:39 +0200)]
Skip the master password for the owner group when running in enterprise mode

4 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Sat, 25 Apr 2020 17:04:14 +0000 (19:04 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3215 from WoltLab/storageHandler
Joshua Rüsweg [Sat, 25 Apr 2020 17:01:17 +0000 (19:01 +0200)]
Merge pull request #3215 from WoltLab/storageHandler

Fix return values in the UserStorageHandler for modified fields unloa…

4 years agoAvoid potential race condition when saving profile visitors
Marcel Werk [Fri, 24 Apr 2020 15:02:40 +0000 (17:02 +0200)]
Avoid potential race condition when saving profile visitors

4 years agoAdded missing since tag
Marcel Werk [Fri, 24 Apr 2020 13:40:18 +0000 (15:40 +0200)]
Added missing since tag

4 years agoIncorrect API url resolution
Alexander Ebert [Mon, 20 Apr 2020 00:06:32 +0000 (02:06 +0200)]
Incorrect API url resolution

This issue only exists for apps that are running on different subdomains.

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Sun, 19 Apr 2020 22:08:34 +0000 (00:08 +0200)]
Merge branch '3.1' into 5.2

4 years ago"search for updates" button is missing if user cannot install packages
Marcel Werk [Sun, 19 Apr 2020 22:08:14 +0000 (00:08 +0200)]
"search for updates" button is missing if user cannot install packages

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Fri, 17 Apr 2020 17:15:34 +0000 (19:15 +0200)]
Merge branch '3.1' into 5.2

4 years agoFixed typo
Marcel Werk [Fri, 17 Apr 2020 17:15:04 +0000 (19:15 +0200)]
Fixed typo

4 years agoIncorrect orientation of images rotated with ImageMagick
Alexander Ebert [Fri, 17 Apr 2020 16:09:27 +0000 (18:09 +0200)]
Incorrect orientation of images rotated with ImageMagick

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 17 Apr 2020 16:09:08 +0000 (18:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoIncorrect orientation of images rotated with ImageMagick
Alexander Ebert [Fri, 17 Apr 2020 16:08:53 +0000 (18:08 +0200)]
Incorrect orientation of images rotated with ImageMagick

4 years agoPrevent multiple unregistering UploadFormFields
joshuaruesweg [Fri, 17 Apr 2020 14:38:48 +0000 (16:38 +0200)]
Prevent multiple unregistering UploadFormFields

4 years agoFix grammar
Joshua Rüsweg [Fri, 17 Apr 2020 14:12:40 +0000 (16:12 +0200)]
Fix grammar

Co-Authored-By: Alexander Ebert <ebert@woltlab.com>
4 years agoFix return values in the UserStorageHandler for modified fields unloaded users
joshuaruesweg [Fri, 17 Apr 2020 13:49:34 +0000 (15:49 +0200)]
Fix return values in the UserStorageHandler for modified fields unloaded users
Currently the UserStorageHandler returns obsolete values if the value is deleted/updated before the user object is cached.

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Thu, 16 Apr 2020 14:20:27 +0000 (16:20 +0200)]
Merge branch '3.1' into 5.2

4 years agoLabel selection missing in pagination of the article list
Marcel Werk [Thu, 16 Apr 2020 14:20:14 +0000 (16:20 +0200)]
Label selection missing in pagination of the article list

Closes #3213

4 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Thu, 16 Apr 2020 12:06:15 +0000 (14:06 +0200)]
Merge branch '3.1' into 5.2

4 years agoFix incorrect assignment of user trophies, with duplicates of one user trophy
joshuaruesweg [Thu, 16 Apr 2020 12:05:42 +0000 (14:05 +0200)]
Fix incorrect assignment of user trophies, with duplicates of one user trophy
See https://community.woltlab.com/thread/282933-automatische-vergabe-bei-bedingung-hat-troph%C3%A4e-x-und-y-fehlerhaft/

4 years agoRemove reaction buttons from commentLists which do not support reactions
joshuaruesweg [Thu, 16 Apr 2020 11:39:48 +0000 (13:39 +0200)]
Remove reaction buttons from commentLists which do not support reactions

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Tue, 14 Apr 2020 22:46:17 +0000 (00:46 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Marcel Werk [Tue, 14 Apr 2020 22:45:50 +0000 (00:45 +0200)]
Merge branch '3.0' into 3.1

4 years agoFixed incorrect title when editing menu entries
Marcel Werk [Tue, 14 Apr 2020 22:45:31 +0000 (00:45 +0200)]
Fixed incorrect title when editing menu entries

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Tue, 14 Apr 2020 22:16:19 +0000 (00:16 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Marcel Werk [Tue, 14 Apr 2020 22:16:03 +0000 (00:16 +0200)]
Merge branch '3.0' into 3.1

4 years agoThumbnails created with imagick had wrong image size
Marcel Werk [Tue, 14 Apr 2020 22:15:13 +0000 (00:15 +0200)]
Thumbnails created with imagick had wrong image size

4 years agoHTML in category descriptions was not considered correctly
Marcel Werk [Tue, 14 Apr 2020 21:11:08 +0000 (23:11 +0200)]
HTML in category descriptions was not considered correctly

4 years agoFixed margin of paragraph tag on amp pages
Marcel Werk [Tue, 14 Apr 2020 18:15:28 +0000 (20:15 +0200)]
Fixed margin of paragraph tag on amp pages

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Tue, 14 Apr 2020 17:07:40 +0000 (19:07 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Marcel Werk [Tue, 14 Apr 2020 16:59:31 +0000 (18:59 +0200)]
Merge branch '3.0' into 3.1

4 years agoFixed PHP 7.4 issue
Marcel Werk [Tue, 14 Apr 2020 16:58:43 +0000 (18:58 +0200)]
Fixed PHP 7.4 issue

4 years agoMerge pull request #3207 from WoltLab/search-keyword-upsert
Marcel Werk [Tue, 14 Apr 2020 13:23:17 +0000 (15:23 +0200)]
Merge pull request #3207 from WoltLab/search-keyword-upsert

Avoid potential race condition when saving search keywords

4 years agoUpdated method name
Marcel Werk [Tue, 14 Apr 2020 12:38:06 +0000 (14:38 +0200)]
Updated method name

4 years agoDisabled media bbcodes in amp version
Marcel Werk [Mon, 13 Apr 2020 17:22:14 +0000 (19:22 +0200)]
Disabled media bbcodes in amp version

4 years agoAdded missing value reset
Marcel Werk [Mon, 13 Apr 2020 13:38:19 +0000 (15:38 +0200)]
Added missing value reset

4 years agoAdded maxlength attribute in user group add form
Marcel Werk [Mon, 13 Apr 2020 13:38:10 +0000 (15:38 +0200)]
Added maxlength attribute in user group add form

4 years agoFixed different spelling of "pixels"
Marcel Werk [Mon, 13 Apr 2020 12:22:31 +0000 (14:22 +0200)]
Fixed different spelling of "pixels"

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Mon, 13 Apr 2020 12:16:33 +0000 (14:16 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Marcel Werk [Mon, 13 Apr 2020 12:15:58 +0000 (14:15 +0200)]
Merge branch '3.0' into 3.1

4 years agoToo long text entries when saving media lead to an error message
Marcel Werk [Mon, 13 Apr 2020 12:15:04 +0000 (14:15 +0200)]
Too long text entries when saving media lead to an error message

4 years agoAvoid potential race condition when saving search keywords
Marcel Werk [Mon, 13 Apr 2020 11:34:34 +0000 (13:34 +0200)]
Avoid potential race condition when saving search keywords

4 years agoMerge pull request #3206 from WoltLab/enterprise-mode-restricted-permissions
Alexander Ebert [Sun, 12 Apr 2020 22:38:06 +0000 (00:38 +0200)]
Merge pull request #3206 from WoltLab/enterprise-mode-restricted-permissions

Restrict the ability to modify some permissions when running in enterprise mode

4 years agoIncorrect comparison did include the admin group in a non restricted environment
Alexander Ebert [Sun, 12 Apr 2020 18:01:41 +0000 (20:01 +0200)]
Incorrect comparison did include the admin group in a non restricted environment

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sat, 11 Apr 2020 22:39:10 +0000 (00:39 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent the upload of a new cover photo when the cover photo is disabled
Alexander Ebert [Sat, 11 Apr 2020 22:36:30 +0000 (00:36 +0200)]
Prevent the upload of a new cover photo when the cover photo is disabled

4 years agoRestrict the ability to modify some permissions when running in enterprise mode
Alexander Ebert [Sat, 11 Apr 2020 16:11:33 +0000 (18:11 +0200)]
Restrict the ability to modify some permissions when running in enterprise mode

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Thu, 9 Apr 2020 22:11:15 +0000 (00:11 +0200)]
Merge branch '3.1' into 5.2

4 years agoWorkaround when editing a user with a cover photo without permissions to view it
Alexander Ebert [Thu, 9 Apr 2020 22:10:47 +0000 (00:10 +0200)]
Workaround when editing a user with a cover photo without permissions to view it

4 years agoFixed incorrect detection of numerics
Marcel Werk [Thu, 9 Apr 2020 20:02:34 +0000 (22:02 +0200)]
Fixed incorrect detection of numerics

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Thu, 9 Apr 2020 20:02:16 +0000 (22:02 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Marcel Werk [Thu, 9 Apr 2020 20:01:52 +0000 (22:01 +0200)]
Merge branch '3.0' into 3.1

4 years agoFixed incorrect detection of numerics
Marcel Werk [Thu, 9 Apr 2020 20:01:28 +0000 (22:01 +0200)]
Fixed incorrect detection of numerics

4 years agoMerge branch '3.1' into 5.2 5.2.5
Tim Düsterhus [Wed, 8 Apr 2020 18:21:08 +0000 (20:21 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1 3.1.13
Tim Düsterhus [Wed, 8 Apr 2020 18:20:26 +0000 (20:20 +0200)]
Merge branch '3.0' into 3.1

4 years agoMerge pull request #3205 from WoltLab/revert-3203-purifier-doctype 3.0.24
Tim Düsterhus [Wed, 8 Apr 2020 18:19:22 +0000 (20:19 +0200)]
Merge pull request #3205 from WoltLab/revert-3203-purifier-doctype

Revert "Specify HTML.Doctype as HTML 4 Strict for HTML Purifier"

4 years agoRevert "Specify HTML.Doctype as HTML 4 Strict for HTML Purifier"
Tim Düsterhus [Wed, 8 Apr 2020 18:17:40 +0000 (20:17 +0200)]
Revert "Specify HTML.Doctype as HTML 4 Strict for HTML Purifier"

4 years agoPreparing the release 5.2.5
Alexander Ebert [Wed, 8 Apr 2020 16:51:36 +0000 (18:51 +0200)]
Preparing the release 5.2.5

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 8 Apr 2020 16:38:10 +0000 (18:38 +0200)]
Merge branch '3.1' into 5.2

4 years agoPreparing the release 3.1.13
Alexander Ebert [Wed, 8 Apr 2020 16:14:22 +0000 (18:14 +0200)]
Preparing the release 3.1.13

4 years agoRemoved the compatibility check for API versions
Alexander Ebert [Tue, 17 Dec 2019 10:40:24 +0000 (11:40 +0100)]
Removed the compatibility check for API versions

4 years agoUpgrade notice for WoltLab Suite 5.2
Alexander Ebert [Wed, 8 Apr 2020 15:34:00 +0000 (17:34 +0200)]
Upgrade notice for WoltLab Suite 5.2

4 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Wed, 8 Apr 2020 15:07:29 +0000 (17:07 +0200)]
Merge branch '3.0' into 3.1

4 years agoPreparing the release 3.0.24
Alexander Ebert [Wed, 8 Apr 2020 14:56:44 +0000 (16:56 +0200)]
Preparing the release 3.0.24

4 years agoMerge pull request #3204 from WoltLab/form_builder_destruction
Matthias Schmidt [Wed, 8 Apr 2020 14:05:51 +0000 (16:05 +0200)]
Merge pull request #3204 from WoltLab/form_builder_destruction

Fix reference issue when destroying form

4 years agoFix comment in `cleanup()` method documentation
Matthias Schmidt [Wed, 8 Apr 2020 14:01:37 +0000 (16:01 +0200)]
Fix comment in `cleanup()` method documentation

4 years agoUse `cleanup()` instead of `destory()` to fix reference issue
Matthias Schmidt [Wed, 8 Apr 2020 13:53:20 +0000 (15:53 +0200)]
Use `cleanup()` instead of `destory()` to fix reference issue

4 years agoFix reference issue when destroying form
Matthias Schmidt [Wed, 8 Apr 2020 13:30:20 +0000 (15:30 +0200)]
Fix reference issue when destroying form

Close #3197

4 years agoUpdating minified JavaScript files
woltlab.com [Wed, 8 Apr 2020 13:28:55 +0000 (13:28 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 8 Apr 2020 13:27:08 +0000 (15:27 +0200)]
Merge branch '3.1' into 5.2

4 years agoUpdating minified JavaScript files
woltlab.com [Wed, 8 Apr 2020 13:25:56 +0000 (13:25 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Wed, 8 Apr 2020 13:24:29 +0000 (15:24 +0200)]
Merge branch '3.0' into 3.1

4 years agoUpdating minified JavaScript files
woltlab.com [Wed, 8 Apr 2020 13:23:22 +0000 (13:23 +0000)]
Updating minified JavaScript files

4 years agoUnique id for the share content dialog
Alexander Ebert [Wed, 8 Apr 2020 13:21:01 +0000 (15:21 +0200)]
Unique id for the share content dialog

Closes #3181

4 years agoExplicitly check for the `ctype` extension
Alexander Ebert [Wed, 8 Apr 2020 13:19:10 +0000 (15:19 +0200)]
Explicitly check for the `ctype` extension

Closes #3199

4 years agoMerge pull request #3202 from SoftCreatR/patch-12
Alexander Ebert [Wed, 8 Apr 2020 13:15:47 +0000 (15:15 +0200)]
Merge pull request #3202 from SoftCreatR/patch-12

Set font cache control to public

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 8 Apr 2020 13:15:28 +0000 (15:15 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Wed, 8 Apr 2020 13:14:49 +0000 (15:14 +0200)]
Merge branch '3.0' into 3.1

4 years agoMerge pull request #3203 from WoltLab/purifier-doctype
Alexander Ebert [Wed, 8 Apr 2020 13:14:21 +0000 (15:14 +0200)]
Merge pull request #3203 from WoltLab/purifier-doctype

Specify HTML.Doctype as HTML 4 Strict for HTML Purifier

4 years agoValidate file extensions for images in UploadFormField
joshuaruesweg [Tue, 7 Apr 2020 11:06:07 +0000 (13:06 +0200)]
Validate file extensions for images in UploadFormField

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 8 Apr 2020 13:09:28 +0000 (15:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Tim Düsterhus [Wed, 8 Apr 2020 13:09:04 +0000 (15:09 +0200)]
Merge branch '3.0' into 3.1

4 years agoValidate file extensions for remote avatars in UserAvatarAction
joshuaruesweg [Tue, 7 Apr 2020 11:31:10 +0000 (13:31 +0200)]
Validate file extensions for remote avatars in UserAvatarAction

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 8 Apr 2020 13:02:34 +0000 (15:02 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge branch '3.0' into 3.1
Alexander Ebert [Wed, 8 Apr 2020 13:02:02 +0000 (15:02 +0200)]
Merge branch '3.0' into 3.1

4 years agoExplicitly set the stream timeout
Alexander Ebert [Wed, 8 Apr 2020 13:01:18 +0000 (15:01 +0200)]
Explicitly set the stream timeout

4 years agoSpecify HTML.Doctype as HTML 4 Strict for HTML Purifier
Tim Düsterhus [Wed, 8 Apr 2020 12:47:30 +0000 (14:47 +0200)]
Specify HTML.Doctype as HTML 4 Strict for HTML Purifier

Not setting a Doctype defaults to HTML 4 Transitional, allowing legacy
tags. HTML 4 Strict will attempt to convert them into a standards compliant
format.

HTML Purifier does not support the HTML 5 Doctype as a readily available
configuration.

Before:

    string '<p><font size="6">This is some text!</font></p>' (length=47)

After:

    string '<p><span style="font-size:xx-large;">This is some text!</span></p>' (length=66)

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 8 Apr 2020 12:52:52 +0000 (14:52 +0200)]
Merge branch '3.1' into 5.2

4 years agoIncorrect HTML markup
Alexander Ebert [Wed, 8 Apr 2020 12:52:00 +0000 (14:52 +0200)]
Incorrect HTML markup

4 years agoNon owner groups could not edit groups previously created by them
Alexander Ebert [Mon, 6 Apr 2020 21:08:27 +0000 (23:08 +0200)]
Non owner groups could not edit groups previously created by them

4 years agoSet font cache control to public
Sascha Greuel [Fri, 3 Apr 2020 23:08:45 +0000 (01:08 +0200)]
Set font cache control to public

resolves #3186

4 years agoWhitelisted `html_entity_decode` in enterprise mode
Alexander Ebert [Thu, 2 Apr 2020 21:44:03 +0000 (23:44 +0200)]
Whitelisted `html_entity_decode` in enterprise mode

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 1 Apr 2020 12:30:41 +0000 (14:30 +0200)]
Merge branch '3.1' into 5.2