GitHub/WoltLab/WCF.git
3 years agoMerge pull request #3920 from WoltLab/http-request-proxy
Tim Düsterhus [Mon, 1 Feb 2021 10:50:35 +0000 (11:50 +0100)]
Merge pull request #3920 from WoltLab/http-request-proxy

Fix HTTPRequest with proxies

3 years agoStream HTTPRequest responses only of a maximum length is desired
Tim Düsterhus [Mon, 1 Feb 2021 10:37:09 +0000 (11:37 +0100)]
Stream HTTPRequest responses only of a maximum length is desired

cURL is not supported for streaming responses. As we process the full response
body for requests without a maximum length there is no benefit to streaming the
response, because we lose cURL support.

3 years agoUpdate Guzzle
Tim Düsterhus [Mon, 1 Feb 2021 10:34:50 +0000 (11:34 +0100)]
Update Guzzle

see guzzle/guzzle#2848
see guzzle/guzzle#2850

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 29 Jan 2021 15:23:00 +0000 (16:23 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix which index object is used when dropping indices with PHP API
Matthias Schmidt [Fri, 29 Jan 2021 15:22:50 +0000 (16:22 +0100)]
Fix which index object is used when dropping indices with PHP API

Only `$matchingExistingIndex` is guaranteed to have the correct index name.

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 29 Jan 2021 14:55:51 +0000 (15:55 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix checked property when adding indices to `DatabaseTable`
Matthias Schmidt [Fri, 29 Jan 2021 14:55:26 +0000 (15:55 +0100)]
Fix checked property when adding indices to `DatabaseTable`

3 years agoMerge branch '5.2' into 5.3 5.3.3
Alexander Ebert [Fri, 29 Jan 2021 14:25:33 +0000 (15:25 +0100)]
Merge branch '5.2' into 5.3

3 years agoRelease 5.2.11 5.2.11
Alexander Ebert [Fri, 29 Jan 2021 14:01:03 +0000 (15:01 +0100)]
Release 5.2.11

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 29 Jan 2021 13:56:16 +0000 (14:56 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.19 3.1.19
Alexander Ebert [Fri, 29 Jan 2021 13:44:59 +0000 (14:44 +0100)]
Release 3.1.19

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 29 Jan 2021 13:38:27 +0000 (13:38 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Fri, 29 Jan 2021 12:35:25 +0000 (13:35 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Fri, 29 Jan 2021 12:32:24 +0000 (13:32 +0100)]
Merge branch '3.1' into 5.2

3 years agoFix converting float value to integer
joshuaruesweg [Fri, 29 Jan 2021 12:30:56 +0000 (13:30 +0100)]
Fix converting float value to integer

3 years agoRelease 5.3.3
Alexander Ebert [Wed, 27 Jan 2021 17:36:18 +0000 (18:36 +0100)]
Release 5.3.3

3 years agoObject edit link led to the admin panel
Marcel Werk [Wed, 27 Jan 2021 16:14:41 +0000 (17:14 +0100)]
Object edit link led to the admin panel

3 years agoMake update_com.woltlab.wcf_5.3_packageServer.php compatible with WCF_N != 1
Tim Düsterhus [Wed, 27 Jan 2021 15:31:11 +0000 (16:31 +0100)]
Make update_com.woltlab.wcf_5.3_packageServer.php compatible with WCF_N != 1

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Wed, 27 Jan 2021 14:58:09 +0000 (15:58 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3908 from WoltLab/pr_build_package
Joshua Rüsweg [Wed, 27 Jan 2021 14:57:30 +0000 (15:57 +0100)]
Merge pull request #3908 from WoltLab/pr_build_package

Add wcfsetup workflow

3 years agoAdd wcfsetup workflow
joshuaruesweg [Wed, 27 Jan 2021 14:30:47 +0000 (15:30 +0100)]
Add wcfsetup workflow
This workflow generates the WCFSetup and stores it as an artifact.

3 years agoImproved message for rejected credentials on paid packages (#3903)
Alexander Ebert [Wed, 27 Jan 2021 11:20:57 +0000 (12:20 +0100)]
Improved message for rejected credentials on paid packages (#3903)

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 26 Jan 2021 14:12:20 +0000 (15:12 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3900 from WoltLab/hasOwnerAccess
Tim Düsterhus [Tue, 26 Jan 2021 14:11:49 +0000 (15:11 +0100)]
Merge pull request #3900 from WoltLab/hasOwnerAccess

Fix User::hasOwnerAccess()

3 years agoCheck owner access after checking controller blacklist in RequestHandler
Tim Düsterhus [Tue, 26 Jan 2021 14:03:22 +0000 (15:03 +0100)]
Check owner access after checking controller blacklist in RequestHandler

This ensures that the check only happens when absolute required.

3 years agoRemove caching from User::hasOwnerAccess()
Tim Düsterhus [Tue, 26 Jan 2021 14:00:28 +0000 (15:00 +0100)]
Remove caching from User::hasOwnerAccess()

The current caching logic is buggy as reported in issue #3899. This patch
removes this caching, as this method already is quite fast and it also is
seldomly called. Within the frontend it is only called when the user is banned.

Fixes #3899

3 years agoFix bad revert
Tim Düsterhus [Mon, 25 Jan 2021 12:58:27 +0000 (13:58 +0100)]
Fix bad revert

see 6e01c38f9218c5763130f19814f3d5b94cca26be

3 years agoReformat update_com.woltlab.wcf_5.3.3_db.php to use Tabs
Tim Düsterhus [Mon, 25 Jan 2021 12:02:31 +0000 (13:02 +0100)]
Reformat update_com.woltlab.wcf_5.3.3_db.php to use Tabs

Code style for 5.3 expects tabs, not spaces. PHP CodeSniffer complains.

3 years agoAdd PSR-12 reformatting commits for 5.3 to .git-blame-ignore-revs
Tim Düsterhus [Mon, 25 Jan 2021 11:58:17 +0000 (12:58 +0100)]
Add PSR-12 reformatting commits for 5.3 to .git-blame-ignore-revs

see 6e01c38f9218c5763130f19814f3d5b94cca26be
see 9faac4ad4b5d27f9159e531b645ed3f4088adb3a

3 years agoRevert "Reformat EventListenerPackageInstallationPlugin to PSR-12"
Tim Düsterhus [Mon, 25 Jan 2021 11:53:30 +0000 (12:53 +0100)]
Revert "Reformat EventListenerPackageInstallationPlugin to PSR-12"

This reverts commit 9faac4ad4b5d27f9159e531b645ed3f4088adb3a.

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 25 Jan 2021 08:18:19 +0000 (09:18 +0100)]
Merge branch '5.2' into 5.3

3 years agoWhitelist `array_fill` in enterprise mode
Tim Düsterhus [Mon, 25 Jan 2021 08:17:56 +0000 (09:17 +0100)]
Whitelist `array_fill` in enterprise mode

3 years agoSupport `environment=all` in event listener PIP GUI
Matthias Schmidt [Sun, 24 Jan 2021 12:15:24 +0000 (13:15 +0100)]
Support `environment=all` in event listener PIP GUI

3 years agoReformat EventListenerPackageInstallationPlugin to PSR-12
Matthias Schmidt [Sun, 24 Jan 2021 12:13:38 +0000 (13:13 +0100)]
Reformat EventListenerPackageInstallationPlugin to PSR-12

3 years agoSupport `environment=all` for event listeners in database
Matthias Schmidt [Sun, 24 Jan 2021 12:02:22 +0000 (13:02 +0100)]
Support `environment=all` for event listeners in database

See #3145

3 years agoMerge pull request #3884 from WoltLab/password-phpbb-combined
Tim Düsterhus [Thu, 21 Jan 2021 15:02:28 +0000 (16:02 +0100)]
Merge pull request #3884 from WoltLab/password-phpbb-combined

Add support for phpBB's combined hash

3 years agoAdd support for phpBB's combined hash
Tim Düsterhus [Wed, 30 Sep 2020 09:39:25 +0000 (11:39 +0200)]
Add support for phpBB's combined hash

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoSet 'stream' to `true` for Guzzle in `HTTPRequest`
Tim Düsterhus [Thu, 21 Jan 2021 08:33:22 +0000 (09:33 +0100)]
Set 'stream' to `true` for Guzzle in `HTTPRequest`

This is required to properly support the 'maxLength' option on endless streams
(such as a web radio). Without setting 'stream' to `true`, Guzzle attempts to
download the entire response body before returning from `->send()`.

3 years agoMerge pull request #3873 from WoltLab/user-online-performance
Joshua Rüsweg [Wed, 20 Jan 2021 14:46:44 +0000 (15:46 +0100)]
Merge pull request #3873 from WoltLab/user-online-performance

Fix performance of user online list

3 years agoFix performance of user online list
joshuaruesweg [Tue, 12 Jan 2021 13:45:33 +0000 (14:45 +0100)]
Fix performance of user online list
If the UserStorageHandler has to load all users that are online, this is quite resource intensive in larger communities and the query is very slow. The UserStorageHandler must actually be loaded so that the permissions of the users can be checked to see if they can make themselves invisible. We switch off this check with this commit and assume that users who cannot change this setting are always online.

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 20 Jan 2021 12:15:24 +0000 (12:15 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 20 Jan 2021 12:13:58 +0000 (13:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 20 Jan 2021 12:12:17 +0000 (12:12 +0000)]
Updating minified JavaScript files

3 years agoUnify reaction count button style with notification style
joshuaruesweg [Mon, 18 Jan 2021 15:25:23 +0000 (16:25 +0100)]
Unify reaction count button style with notification style

3 years agoMerge branch '5.2' into 5.3
Marcel Werk [Mon, 18 Jan 2021 15:20:15 +0000 (16:20 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Marcel Werk [Mon, 18 Jan 2021 15:19:54 +0000 (16:19 +0100)]
Merge branch '3.1' into 5.2

3 years agoPermissions for media were not saved correctly
Marcel Werk [Mon, 18 Jan 2021 15:19:25 +0000 (16:19 +0100)]
Permissions for media were not saved correctly

3 years agoAdd spacing beetween reaction icon in notifications
joshuaruesweg [Mon, 18 Jan 2021 14:58:43 +0000 (15:58 +0100)]
Add spacing beetween reaction icon in notifications

3 years agoFix double html encoding in trophy activity events
joshuaruesweg [Mon, 18 Jan 2021 12:54:21 +0000 (13:54 +0100)]
Fix double html encoding in trophy activity events

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Fri, 15 Jan 2021 12:47:06 +0000 (13:47 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Fri, 15 Jan 2021 12:46:45 +0000 (13:46 +0100)]
Merge branch '3.1' into 5.2

3 years agoSet explicit value for invalid select options
joshuaruesweg [Fri, 15 Jan 2021 12:45:59 +0000 (13:45 +0100)]
Set explicit value for invalid select options

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 15 Jan 2021 10:29:29 +0000 (11:29 +0100)]
Merge branch '5.2' into 5.3

3 years agoSupport WysiwygFormContainer as children of ITabMenuFormContainer
Titus Kirch [Wed, 30 Dec 2020 01:11:55 +0000 (02:11 +0100)]
Support WysiwygFormContainer as children of ITabMenuFormContainer

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 15 Jan 2021 08:53:55 +0000 (09:53 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix displaying error messages for devtool projects' instructions
Matthias Schmidt [Fri, 15 Jan 2021 08:53:37 +0000 (09:53 +0100)]
Fix displaying error messages for devtool projects' instructions

3 years agoRemove incorrect devtools form field description
Matthias Schmidt [Fri, 15 Jan 2021 08:50:00 +0000 (09:50 +0100)]
Remove incorrect devtools form field description

3 years agoImprove variable name
Matthias Schmidt [Fri, 15 Jan 2021 08:37:54 +0000 (09:37 +0100)]
Improve variable name

3 years agoMerge pull request #3865 from WoltLab/fix-style-preview
Tim Düsterhus [Wed, 13 Jan 2021 08:13:00 +0000 (09:13 +0100)]
Merge pull request #3865 from WoltLab/fix-style-preview

Fix the style preview images

3 years agoFix check for deleted notifications in NotificationEmailDeliveryBackgroundJob
Tim Düsterhus [Mon, 11 Jan 2021 15:59:19 +0000 (16:59 +0100)]
Fix check for deleted notifications in NotificationEmailDeliveryBackgroundJob

3 years agoFix multiple queries for user online list stats
joshuaruesweg [Mon, 11 Jan 2021 12:54:23 +0000 (13:54 +0100)]
Fix multiple queries for user online list stats

3 years agoMerge pull request #3867 from WoltLab/smtp-auth-fail
Tim Düsterhus [Mon, 11 Jan 2021 11:33:09 +0000 (12:33 +0100)]
Merge pull request #3867 from WoltLab/smtp-auth-fail

Fail SMTP auth if credentials are configured but all mechanisms fail

3 years agoProperly detect EOF in SmtpEmailTransport::read()
Tim Düsterhus [Mon, 11 Jan 2021 11:18:00 +0000 (12:18 +0100)]
Properly detect EOF in SmtpEmailTransport::read()

3 years agoDisconnect SMTP session for all types of Exception during connect / auth
Tim Düsterhus [Mon, 11 Jan 2021 10:51:23 +0000 (11:51 +0100)]
Disconnect SMTP session for all types of Exception during connect / auth

3 years agoFail SMTP auth if credentials are configured but all mechanisms fail
Tim Düsterhus [Mon, 11 Jan 2021 10:49:20 +0000 (11:49 +0100)]
Fail SMTP auth if credentials are configured but all mechanisms fail

3 years agoFix the style preview images
Tim Düsterhus [Mon, 11 Jan 2021 08:44:05 +0000 (09:44 +0100)]
Fix the style preview images

The update 5.3.1 -> 5.3.2 detached all the style preview images in the
database, while leaving the actual image files in the file system. This new
update script *should* fix this situation again, by scanning the asset folder
and reattaching the newest image.

3 years agoMerge branch '5.2' into 5.3 5.3.2
joshuaruesweg [Wed, 6 Jan 2021 15:40:00 +0000 (16:40 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Wed, 6 Jan 2021 15:39:26 +0000 (16:39 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3844 from WoltLab/fix-failing-cronjobs
Joshua Rüsweg [Wed, 6 Jan 2021 15:38:31 +0000 (16:38 +0100)]
Merge pull request #3844 from WoltLab/fix-failing-cronjobs

Fix failing cronjobs

3 years agoIncorrect year
Alexander Ebert [Wed, 6 Jan 2021 14:59:23 +0000 (15:59 +0100)]
Incorrect year

Old habits die hard…

3 years agoRelease 5.3.2
Alexander Ebert [Wed, 6 Jan 2021 14:57:01 +0000 (15:57 +0100)]
Release 5.3.2

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 6 Jan 2021 14:44:19 +0000 (14:44 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 6 Jan 2021 11:19:16 +0000 (12:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix VarbinaryDatabaseTableColumn
Tim Düsterhus [Wed, 6 Jan 2021 11:18:29 +0000 (12:18 +0100)]
Fix VarbinaryDatabaseTableColumn

> Call to undefined method wcf\system\database\table\column\VarbinaryDatabaseTableColumn::traitGetLength()

see 4a65b1e27cc85fc9fb9bbcdf6a6d7a5f9cc76187

3 years agoHide article-related notification events if articles are disabled
Matthias Schmidt [Sun, 3 Jan 2021 16:23:09 +0000 (17:23 +0100)]
Hide article-related notification events if articles are disabled

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 3 Jan 2021 16:20:22 +0000 (17:20 +0100)]
Merge branch '5.2' into 5.3

3 years agoHide article-related notification events if articles are disabled
Matthias Schmidt [Sun, 3 Jan 2021 16:20:06 +0000 (17:20 +0100)]
Hide article-related notification events if articles are disabled

Close #3845

3 years agofixup! Disable disabling of failed system cronjobs Fixes #3841
joshuaruesweg [Sun, 3 Jan 2021 16:10:32 +0000 (17:10 +0100)]
fixup! Disable disabling of failed system cronjobs Fixes #3841

3 years agoDisable disabling of failed system cronjobs
joshuaruesweg [Sat, 2 Jan 2021 15:10:37 +0000 (16:10 +0100)]
Disable disabling of failed system cronjobs
Fixes #3841

3 years agoPrevent failing cronjobs from blocking other cronjobs by executing them last
joshuaruesweg [Sat, 2 Jan 2021 15:06:56 +0000 (16:06 +0100)]
Prevent failing cronjobs from blocking other cronjobs by executing them last

3 years agoFix missing informal language variable
Peter Lohse [Sat, 2 Jan 2021 13:37:43 +0000 (14:37 +0100)]
Fix missing informal language variable

Closes #3843

3 years agoPrevent sentences in the search result list from being "glued" together
Alexander Ebert [Thu, 31 Dec 2020 12:43:19 +0000 (13:43 +0100)]
Prevent sentences in the search result list from being "glued" together

3 years agoProperly remove formatting in nested elements
Alexander Ebert [Mon, 28 Dec 2020 19:08:32 +0000 (20:08 +0100)]
Properly remove formatting in nested elements

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 28 Dec 2020 15:30:06 +0000 (16:30 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix validation of required single media form fields
Matthias Schmidt [Mon, 28 Dec 2020 15:29:17 +0000 (16:29 +0100)]
Fix validation of required single media form fields

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 27 Dec 2020 13:12:50 +0000 (14:12 +0100)]
Merge branch '5.2' into 5.3

3 years agoImprove readability of form field template code
Matthias Schmidt [Sun, 27 Dec 2020 13:11:32 +0000 (14:11 +0100)]
Improve readability of form field template code

3 years agoFix validation of form builder node attributes
Matthias Schmidt [Sun, 27 Dec 2020 13:10:31 +0000 (14:10 +0100)]
Fix validation of form builder node attributes

Close #3827

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 27 Dec 2020 12:55:45 +0000 (13:55 +0100)]
Merge branch '5.2' into 5.3

3 years agoThrow exception for VARBINARY columns without length
Matthias Schmidt [Sun, 27 Dec 2020 12:54:55 +0000 (13:54 +0100)]
Throw exception for VARBINARY columns without length

Close #3827

3 years agoMerge pull request #3824 from WoltLab/53-upgrade-preserve-credentials
Alexander Ebert [Wed, 23 Dec 2020 18:16:53 +0000 (19:16 +0100)]
Merge pull request #3824 from WoltLab/53-upgrade-preserve-credentials

Preserve package server credentials during the upgrade from 5.2 to 5.3.

3 years agoEnable the media page in offline mode
Alexander Ebert [Wed, 23 Dec 2020 17:30:50 +0000 (18:30 +0100)]
Enable the media page in offline mode

This is consistent with the existing exception from the forced login (`AbstractPage::forceLogin()`).

Fixes #3836

3 years agoPrevent the removal of the package servers for `5.3` to preserve the credentials
Alexander Ebert [Wed, 23 Dec 2020 17:12:16 +0000 (18:12 +0100)]
Prevent the removal of the package servers for `5.3` to preserve the credentials

3 years agoPermit `wsm` to be placed inside `<li>`
Alexander Ebert [Wed, 23 Dec 2020 16:15:43 +0000 (17:15 +0100)]
Permit `wsm` to be placed inside `<li>`

3 years agoRemoved the extra margin for `<em>`
Alexander Ebert [Wed, 23 Dec 2020 12:00:44 +0000 (13:00 +0100)]
Removed the extra margin for `<em>`

This margin was required in previous versions that used incomplete fonts with lack for true italic versions. All system fonts have support for italic variants and the new WebFont support utilizes fonts with the same capabilities, creating a weird gap after italic words.

3 years agoDisplay a somewhat meaningful message when the package list inaccessible
Alexander Ebert [Tue, 22 Dec 2020 17:48:21 +0000 (18:48 +0100)]
Display a somewhat meaningful message when the package list inaccessible

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 22 Dec 2020 13:08:09 +0000 (14:08 +0100)]
Merge branch '5.2' into 5.3

3 years agoValidate column names in indices when using PHP DB API (#3832)
Matthias Schmidt [Tue, 22 Dec 2020 13:07:39 +0000 (14:07 +0100)]
Validate column names in indices when using PHP DB API (#3832)

Close  #3828

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 22 Dec 2020 12:20:34 +0000 (13:20 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()
Matthias Schmidt [Tue, 22 Dec 2020 12:04:22 +0000 (13:04 +0100)]
Fix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()

Close #3829