GitHub/LineageOS/android_kernel_motorola_exynos9610.git
11 years ago[media] rtl28xxu: Add USB IDs for Compro VideoMate U620F
Alistair Buxton [Wed, 13 Feb 2013 00:58:47 +0000 (21:58 -0300)]
[media] rtl28xxu: Add USB IDs for Compro VideoMate U620F

Signed-off-by: Alistair Buxton <a.j.buxton@gmail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: add usb id for terratec h5 rev. 3
Roland Scheidegger [Sat, 9 Feb 2013 00:08:55 +0000 (21:08 -0300)]
[media] em28xx: add usb id for terratec h5 rev. 3

Seems to work just the same as older revisions.

Signed-off-by: Roland Scheidegger <rscheidegger_lists@hispeed.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: rc: gpio-ir-recv: add support for device tree parsing
Sebastian Hesselbarth [Fri, 8 Feb 2013 21:47:30 +0000 (18:47 -0300)]
[media] media: rc: gpio-ir-recv: add support for device tree parsing

This patch adds device tree parsing for gpio_ir_recv platform_data and
the mandatory binding documentation. It basically follows what we already
have for e.g. gpio_keys. All required device tree properties are OS
independent but an optional property allows linux specific support for rc
maps.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] mceusb: move check earlier to make smatch happy
Dan Carpenter [Tue, 12 Feb 2013 11:22:08 +0000 (08:22 -0300)]
[media] mceusb: move check earlier to make smatch happy

Smatch complains that "cmdbuf[cmdcount - length]" might go past the end
of the array.  It's an easy warning to silence by moving the limit
check earlier.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] radio-si470x doc: add info about v4l2-ctl and sox+alsa
Alexey Klimov [Mon, 11 Feb 2013 22:04:51 +0000 (19:04 -0300)]
[media] radio-si470x doc: add info about v4l2-ctl and sox+alsa

Patch adds information about using v4l2-ctl utility to tune the si470x
radio and example how to use sox+alsa to redirect sound from radio sound
device to another sound device.

Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: media: Remove unnecessary OOM messages
Joe Perches [Mon, 11 Feb 2013 17:38:05 +0000 (14:38 -0300)]
[media] staging: media: Remove unnecessary OOM messages

alloc failures already get standardized OOM
messages and a dump_stack.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh_vou: Use vou_dev instead of vou_file wherever possible
Laurent Pinchart [Thu, 3 Jan 2013 18:35:57 +0000 (15:35 -0300)]
[media] sh_vou: Use vou_dev instead of vou_file wherever possible

This prepares for the removal of vou_file.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh_vou: Use video_drvdata()
Laurent Pinchart [Thu, 3 Jan 2013 18:35:56 +0000 (15:35 -0300)]
[media] sh_vou: Use video_drvdata()

Replace video_devdata() followed by video_get_drvdata() calls with
video_drvdata().

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drivers/media/platform/soc_camera/pxa_camera.c: use devm_ functions
Julia Lawall [Mon, 7 Jan 2013 12:51:21 +0000 (09:51 -0300)]
[media] drivers/media/platform/soc_camera/pxa_camera.c: use devm_ functions

This patch uses various devm_ functions for data that is allocated in the
probe function of a platform driver and is only freed in the remove
function.
This also fixes a checkpatch warning, removing a space before a \n in a
string.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] mt9t112: mt9t111 format set up differs from mt9t112
Guennadi Liakhovetski [Wed, 30 Jan 2013 11:04:47 +0000 (08:04 -0300)]
[media] mt9t112: mt9t111 format set up differs from mt9t112

The original commit, adding the mt9t112 driver said, that mt9t111 and
mt9t112 had identical register layouts. This however doesn't seem to be
the case. At least pixel format selection in the mt9t111 datasheet is
different from the driver implementation. So far only the default YUYV
format has been verified to work with mt9t111. Limit the driver to only
report one supported format with mt9t111 until more formats are
implemented.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sh-mobile-ceu-camera: fix SHARPNESS control default
Guennadi Liakhovetski [Wed, 30 Jan 2013 08:19:56 +0000 (05:19 -0300)]
[media] sh-mobile-ceu-camera: fix SHARPNESS control default

The V4L2_CID_SHARPNESS control in the sh-mobile-ceu-camera driver, if off,
turns the CEU low-pass filter on. This is the opposite to the hardware
default and can degrade image quality. Switch default to on to restore the
default unfiltered mode.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years agoRevert "[media] fc0011: Return early, if the frequency is already tuned"
Mauro Carvalho Chehab [Mon, 11 Feb 2013 21:38:59 +0000 (19:38 -0200)]
Revert "[media] fc0011: Return early, if the frequency is already tuned"

This reverts commit a92591a7112042f92b609be42bc332d989776e9b.

From: Michael Büsch <m@bues.ch>
To: linux-media@vger.kernel.org
Cc: mchehab@redhat.com
Subject: Re: [git:v4l-dvb/for_v3.9] [media] fc0011: Return early, if the frequency is already tuned
Date: Mon, 11 Feb 2013 21:59:19 +0100

Can you please revert this one again? It might cause issues if the dvb device
is reset/reinitialized.

Requested-by: Michael Büsch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] cx18/ivtv: fix regression: remove __init from a non-init function
Hans Verkuil [Sat, 9 Feb 2013 08:40:10 +0000 (05:40 -0300)]
[media] cx18/ivtv: fix regression: remove __init from a non-init function

Commits 5e6e81b2890db3969527772a8350825a85c22d5c (cx18) and
2aebbf6737212265b917ed27c875c59d3037110a (ivtv) added an __init
annotation to the cx18-alsa-load and ivtv-alsa-load functions. However,
these functions are called *after* initialization by the main cx18/ivtv
driver. By that time the memory containing those functions is already
freed and your machine goes BOOM.

Cc: stable@vger.kernel.org # for 3.8
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: fix analog streaming with USB bulk transfers
Frank Schaefer [Thu, 7 Feb 2013 16:32:46 +0000 (13:32 -0300)]
[media] em28xx: fix analog streaming with USB bulk transfers

With the conversion to videobuf2, some unnecessary calls of
em28xx_set_alternate() have been removed. It is now called at analog streaming
start only.
This has unveiled a bug that causes USB bulk transfers to fail with all urbs
having status -EVOERFLOW.
The reason is, that for bulk transfers usb_set_interface() needs to be called
even if the previous alt setting was the same (side note: bulk transfers seem
to work only with alt=0).
While it seems to be NOT necessary for isoc transfers, it's reasonable to just
call usb_set_interface() unconditionally in em28xx_set_alternate().
Also add a comment that explains the issue to prevent regressions in the future.

Cc: stable@vger.kernel.org # for 3.8
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] stv0900: remove unnecessary null pointer check
Cong Ding [Mon, 4 Feb 2013 01:34:48 +0000 (22:34 -0300)]
[media] stv0900: remove unnecessary null pointer check

The address of a variable is impossible to be null, so we remove the check.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] fc0011: Return early, if the frequency is already tuned
Michael Büsch [Thu, 7 Feb 2013 15:21:06 +0000 (12:21 -0300)]
[media] fc0011: Return early, if the frequency is already tuned

Return early, if we already tuned to a frequency.

Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] fc0011: Add some sanity checks and cleanups
Michael Büsch [Thu, 7 Feb 2013 15:19:30 +0000 (12:19 -0300)]
[media] fc0011: Add some sanity checks and cleanups

Add some sanity checks to the calculations and make the REG_16 register write consistent
with the other ones.

Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] fc0011: Fix xin value clamping
Michael Büsch [Thu, 7 Feb 2013 15:16:55 +0000 (12:16 -0300)]
[media] fc0011: Fix xin value clamping

Fix the xin value clamping and use clamp_t().

Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years agoRevert "[media] [PATH,1/2] mxl5007 move reset to attach"
Mauro Carvalho Chehab [Fri, 8 Feb 2013 19:47:01 +0000 (17:47 -0200)]
Revert "[media] [PATH,1/2] mxl5007 move reset to attach"

This patch was applied by mistake. Michael thinks that it
it needs more work than simply moving the soft reset.

So, it should be held back for further review.

This reverts commit 0a3237704dec476be3cdfbe8fc9df9cc65b14442.

Requested by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] fc0011: fp/fa value overflow fix
Michael Büsch [Thu, 7 Feb 2013 15:13:13 +0000 (12:13 -0300)]
[media] fc0011: fp/fa value overflow fix

Assign the maximum instead of masking with the maximum on value overflow.

Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tm6000: fix an uninitialized variable
Hans Verkuil [Thu, 7 Feb 2013 10:05:43 +0000 (07:05 -0300)]
[media] tm6000: fix an uninitialized variable

tm6000_poll could use an uninitialized buf pointer. Move the buf-handling
code inside the 'if' that initializes the buf pointer.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] dvb-usb: check for invalid length in ttusb_process_muxpack()
Dan Carpenter [Thu, 7 Feb 2013 07:24:49 +0000 (04:24 -0300)]
[media] dvb-usb: check for invalid length in ttusb_process_muxpack()

This patch is driven by a static checker warning.
The ttusb_process_muxpack() function is only called from
ttusb_process_frame().  Before calling, it verifies that len >= 2.  The
problem is that len == 2 is not valid and would lead to an array
underflow.
Odd number values for len are also invalid and would lead to reading
past the end of the array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: Include missing platform_device.h header
Sachin Kamat [Thu, 7 Feb 2013 05:55:55 +0000 (02:55 -0300)]
[media] s5p-tv: Include missing platform_device.h header

Without this patch we get the following build error:
drivers/media/platform/s5p-tv/mixer_video.c:
In function ‘find_and_register_subdev’:
drivers/media/platform/s5p-tv/mixer_video.c:42:34: error:
‘platform_bus_type’ undeclared (first use in this function)

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-tv: Include missing irqreturn.h header
Sachin Kamat [Thu, 7 Feb 2013 05:55:54 +0000 (02:55 -0300)]
[media] s5p-tv: Include missing irqreturn.h header

Without this patch we get the following compilation errors:
drivers/media/platform/s5p-tv/mixer.h:345:13: error: Expected ; at end of declaration
drivers/media/platform/s5p-tv/mixer.h:345:13: error: got mxr_irq_handler

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [REVIEW] em28xx: fix bytesperline calculation in TRY_FMT
Hans Verkuil [Wed, 6 Feb 2013 11:14:47 +0000 (08:14 -0300)]
[media] [REVIEW] em28xx: fix bytesperline calculation in TRY_FMT

The bytesperline calculation was incorrect: it used the old width instead of
the provided width. Fixed.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tveeprom: Fix lots of bad whitespace
Mauro Carvalho Chehab [Fri, 8 Feb 2013 18:17:10 +0000 (16:17 -0200)]
[media] tveeprom: Fix lots of bad whitespace

While running checkpatch.pl after the last patch, I noticed
lots of those:
WARNING: please, no space before tabs
#151: FILE: drivers/media/common/tveeprom.c:99:
+^I{ TUNER_ABSENT,        ^I^I"None" },$

(together with other checkpatch.pl errors/warnings)

While I won't be fixing everything, as I have already an
script to fix the above, let's do it, in order to clean it
a little bit.

While here, also drop cmacs-specific format text at the end.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tveeprom: move from media/i2c to media/common
Hans Verkuil [Wed, 6 Feb 2013 11:03:41 +0000 (08:03 -0300)]
[media] tveeprom: move from media/i2c to media/common

The tveeprom module is a helper module for Hauppauge-based eeproms.
It's used by many drivers and the i2c part is actually optional, so this
driver is better placed in the media/common directory.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] btcx-risc: move from media/i2c to media/common
Hans Verkuil [Wed, 6 Feb 2013 10:57:57 +0000 (07:57 -0300)]
[media] btcx-risc: move from media/i2c to media/common

The btcx-risc module is a helper module for bttv/conexant based TV cards.
It isn't an i2c module at all, instead it should be in common since it is
used by 4 pci drivers.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] cx2341x: move from media/i2c to media/common
Hans Verkuil [Wed, 6 Feb 2013 10:53:31 +0000 (07:53 -0300)]
[media] cx2341x: move from media/i2c to media/common

The cx2341x module is a helper module for conexant-based MPEG encoders.
It isn't an i2c module at all, instead it should be in common since it is
used by 7 pci and usb drivers to handle the MPEG setup.
It also shouldn't be visible in the config menu as it is always
selected automatically by those drivers that need it.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ttusb2: Kconfig patch to auto-select frontends for TechnoTrend CT-3650
Matti Kurkela [Tue, 5 Feb 2013 10:08:42 +0000 (07:08 -0300)]
[media] ttusb2: Kconfig patch to auto-select frontends for TechnoTrend CT-3650

The ttusb2 module is already updated to recognize the TechnoTrend CT-3650
CI DVB C/T USB2.0 receiver in addition to the Pinnacle 400e. But if
MEDIA_SUBDRV_AUTOSELECT is used, the required tuner and demodulator
modules are not automatically selected. Here's a patch to fix that and add a
note of the CT-3650 to the online help of the ttusb2 module.
This patch applies cleanly to 3.7.6 and other 3.7.x kernels.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [PATH,1/2] mxl5007 move reset to attach
Jose Alberto Reguero [Sun, 3 Feb 2013 21:30:38 +0000 (18:30 -0300)]
[media] [PATH,1/2] mxl5007 move reset to attach

This patch move the soft reset to the attach function because with dual
tuners, when one tuner do reset, the other one is perturbed, and the
stream has errors.

Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] soc-camera: fix compilation breakage in 3 drivers
Guennadi Liakhovetski [Wed, 30 Jan 2013 12:25:25 +0000 (09:25 -0300)]
[media] soc-camera: fix compilation breakage in 3 drivers

A recent commit broke compilation of 3 camera drivers: for PXA2x0, OMAP1
and MX1 by using a wrong pointer. Fix them.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] Documentation: update V4L cardlists
Mauro Carvalho Chehab [Fri, 8 Feb 2013 16:51:36 +0000 (14:51 -0200)]
[media] Documentation: update V4L cardlists

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] saa7134: Add capture card Hawell HW-9004V1
Vadim Frolov [Wed, 30 Jan 2013 08:14:59 +0000 (05:14 -0300)]
[media] saa7134: Add capture card Hawell HW-9004V1

This patch adds new capture board Hawell HW-9004V1. This card has 4 SAA71300 chips. In order to work it is needed to initialize its registers (gpio mask and value). The value of these registers were dumped under Windows using flytest.

Signed-off-by: Vadim Frolov <fralik@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tm6000: check an allocation for failure
Dan Carpenter [Wed, 30 Jan 2013 06:03:43 +0000 (03:03 -0300)]
[media] tm6000: check an allocation for failure

This allocation had no error checking.  It didn't need to be under
the mutex so I moved it out form there. That makes the error handling
easier and is a potential speed up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ov7670: remove legacy ctrl callbacks
Javier Martin [Tue, 29 Jan 2013 11:21:40 +0000 (08:21 -0300)]
[media] ov7670: remove legacy ctrl callbacks

via-camera and mcam-core were the only bridge drivers that used ov7670.
Since now they have been moved to use the ctrl framework, the old
legacy callbacks in the ov7670 can be removed.

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] via-camera: implement the control framework
Javier Martin [Tue, 29 Jan 2013 11:06:35 +0000 (08:06 -0300)]
[media] via-camera: implement the control framework

And added a missing kfree to clean up the via_camera struct.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] mcam-core: implement the control framework
Javier Martin [Tue, 29 Jan 2013 10:58:48 +0000 (07:58 -0300)]
[media] mcam-core: implement the control framework

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ov7670: use the control framework
Javier Martin [Tue, 29 Jan 2013 10:31:17 +0000 (07:31 -0300)]
[media] ov7670: use the control framework

Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: ov7670: Add possibility to disable pixclk during hblank
Javier Martin [Tue, 29 Jan 2013 10:26:38 +0000 (07:26 -0300)]
[media] media: ov7670: Add possibility to disable pixclk during hblank

Some bridge drivers capture pixels during blanking periods if
pixclk is enabled. In order to avoid capturing bogus data we need to
disable pixclk in the sensor during those blanking periods.

Acked-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: ov7670: add possibility to bypass pll for ov7675
Javier Martin [Tue, 29 Jan 2013 10:23:42 +0000 (07:23 -0300)]
[media] media: ov7670: add possibility to bypass pll for ov7675

For a frame rate of 30 fps a pixclk of 24MHz is needed. For those
cases where the ov7670 has a clean 24MHz input (xvclk) the PLL
can be bypassed.
This will result in a value of clkrc of 1, which means that in practice
pixclk = xvclk (input clock)

Acked-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: ov7670: calculate framerate properly for ov7675
Javier Martin [Tue, 29 Jan 2013 10:16:59 +0000 (07:16 -0300)]
[media] media: ov7670: calculate framerate properly for ov7675

According to the datasheet ov7675 uses a formula to achieve
the desired framerate that is different from the operations
done in the current code.
In fact, this formula should apply to ov7670 too. This would
mean that current code is wrong but, in order to preserve
compatibility, the new formula will be used for ov7675 only.

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'
Javier Martin [Tue, 29 Jan 2013 10:14:27 +0000 (07:14 -0300)]
[media] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'

'min_height' and 'min_width' are variables that allow to specify the minimum
resolution that the sensor will achieve. This patch make v4l2 fmt callbacks
consider this parameters in order to return valid data to user space.

Acked-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: ov7670: add support for ov7675
Javier Martin [Tue, 29 Jan 2013 10:12:13 +0000 (07:12 -0300)]
[media] media: ov7670: add support for ov7675

ov7675 and ov7670 share the same registers but there is no way
to distinguish them at runtime. However, they require different
tweaks to achieve the desired resolution. For this reason this
patch adds a new ov7675 entry to the ov7670_id table.

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] redrat3: fix transmit return value and overrun
Sean Young [Tue, 29 Jan 2013 11:19:31 +0000 (08:19 -0300)]
[media] redrat3: fix transmit return value and overrun

If more than 127 different lengths are transmitted then the driver causes
an overrun on sample_lens. Try to send as much as possible and return the
amount sent.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] mceusb: make transmit work on HP transceiver
Sean Young [Tue, 29 Jan 2013 11:19:30 +0000 (08:19 -0300)]
[media] mceusb: make transmit work on HP transceiver

This transceiver expects the set IR TX ports and IR data as seperate
packets, like the Windows driver does. Remove unnecessary kzalloc.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] mceusb: make transmit work on the Philips IR transceiver
Sean Young [Tue, 29 Jan 2013 11:19:29 +0000 (08:19 -0300)]
[media] mceusb: make transmit work on the Philips IR transceiver

The GET_REVISION command puts the device in an unresponsive state,
although it continues to report any IR activity. Note that GET_REVISION
command is not documented, nor is any possible response to it parsed.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ttusbir: add missing endian conversion
Sean Young [Tue, 29 Jan 2013 11:19:28 +0000 (08:19 -0300)]
[media] ttusbir: add missing endian conversion

spotted by sparse.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] ttusbir: do not set led twice on resume
Sean Young [Tue, 29 Jan 2013 11:19:27 +0000 (08:19 -0300)]
[media] ttusbir: do not set led twice on resume

led_classdev_resume already sets the led.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] Documentation/media-framework.txt: fix a sentence
Antonio Ospite [Mon, 28 Jan 2013 20:45:31 +0000 (17:45 -0300)]
[media] Documentation/media-framework.txt: fix a sentence

Signed-off-by: Antonio Ospite <ao2@amarulasolutions.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging/media/solo6x10: Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR
Peter Huewe [Fri, 25 Jan 2013 22:10:12 +0000 (19:10 -0300)]
[media] staging/media/solo6x10: Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR

Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/ptr_ret.cocci.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5c73m3: Remove __dev* attributes
Sylwester Nawrocki [Wed, 6 Feb 2013 20:35:41 +0000 (17:35 -0300)]
[media] s5c73m3: Remove __dev* attributes

Remove no longer supported __devinit, __devexit attributes.

Signed-off-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: overhaul em28xx_capture_area_set()
Frank Schaefer [Sun, 20 Jan 2013 12:26:47 +0000 (09:26 -0300)]
[media] em28xx: overhaul em28xx_capture_area_set()

- move the bit shifting of width+height values inside the function
- fix the debug message format and output values
- add comment about the size limit (e.g. EM277x supports >2MPix)
- make void, because error checking is incomplete and we never check the
  returned value (we would continue anyway)

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] adv7180: remove {query/g_/s_}ctrl
Federico Vaga [Wed, 23 Jan 2013 13:07:07 +0000 (10:07 -0300)]
[media] adv7180: remove {query/g_/s_}ctrl

All drivers which use this subdevice use also the control framework.
The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because
device drivers will inherit controls from this subdevice.

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] sta2x11_vip: convert to videobuf2, control framework, file handler
Federico Vaga [Tue, 5 Feb 2013 17:34:37 +0000 (14:34 -0300)]
[media] sta2x11_vip: convert to videobuf2, control framework, file handler

This patch re-write the driver and use the videobuf2
interface instead of the old videobuf. Moreover, it uses also
the control framework which allows the driver to inherit
controls from its subdevice (ADV7180). Finally the driver does not
implement custom file operation but it uses the generic ones from
videobuf2 and v4l2_fh

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] v4l2-core: do not enable the buffer ioctls for radio devices
Frank Schaefer [Tue, 22 Jan 2013 18:51:55 +0000 (15:51 -0300)]
[media] v4l2-core: do not enable the buffer ioctls for radio devices

The buffer ioctls (VIDIOC_REQBUFS, VIDIOC_QUERYBUF, VIDIOC_QBUF, VIDIOC_DQBUF,
VIDIOC_EXPBUF, VIDIOC_CREATE_BUFS, VIDIOC_PREPARE_BUF) are not applicable for
radio devices. Hence, they should be set valid only for non-radio devices in
determine_valid_ioctls().

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-fimc: Fix fimc-lite entities deregistration
Sylwester Nawrocki [Fri, 11 Jan 2013 10:06:28 +0000 (07:06 -0300)]
[media] s5p-fimc: Fix fimc-lite entities deregistration

Clear the proper array when deregistering FIMC-LITE devices. Now
fimc[] array is erroneously accessed instead of fimc_lite[] and
fimc_md_unregister_entities() function call can result in an oops
from NULL pointer dereference, since fmd->fimc[] is cleared earlier.
This might happen in normal conditions when the driver's probing
is deferred and then retried.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-mfc: end-of-stream handling in encoder bug fix
Kamil Debski [Fri, 11 Jan 2013 14:29:34 +0000 (11:29 -0300)]
[media] s5p-mfc: end-of-stream handling in encoder bug fix

In some circumstances after issuing the V4L2_ENC_CMD_STOP the application
could freeze. This patch prevents this behavior.

Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] s5p-csis: Fix clock handling on error path in probe()
Sylwester Nawrocki [Fri, 18 Jan 2013 16:52:38 +0000 (13:52 -0300)]
[media] s5p-csis: Fix clock handling on error path in probe()

Move e_clkput label after the clk_disable() call so a not acquired clock
is not attempted to be disabled. This fixes runtime warnings like:
 s5p-mipi-csis 11880000.csis: failed to get clock: sclk_csis
 ------------[ cut here ]------------
 WARNING: at drivers/clk/clk.c:478 clk_disable+0x24/0x34()
 Modules linked in:
 [<c001603c>] (unwind_backtrace+0x0/0x13c) from [<c0022060>] (warn_slowpath_common+0x54/0x64)
 [<c0022060>] (warn_slowpath_common+0x54/0x64) from [<c002208c>] (warn_slowpath_null+0x1c/0x24)
 [<c002208c>] (warn_slowpath_null+0x1c/0x24) from [<c033f868>] (clk_disable+0x24/0x34)
 [<c033f868>] (clk_disable+0x24/0x34) from [<c02feff8>] (s5pcsis_probe+0x25c/0x4c8)
 [<c02feff8>] (s5pcsis_probe+0x25c/0x4c8) from [<c0268e34>] (platform_drv_probe+0x18/0x1c)
 [<c0268e34>] (platform_drv_probe+0x18/0x1c) from [<c0267700>] (driver_probe_device+0xa4/0x368)
 [<c0267700>] (driver_probe_device+0xa4/0x368) from [<c0267a50>] (__driver_attach+0x8c/0x90)
 [<c0267a50>] (__driver_attach+0x8c/0x90) from [<c0265c94>] (bus_for_each_dev+0x60/0x8c)
 [<c0265c94>] (bus_for_each_dev+0x60/0x8c) from [<c02665e8>] (bus_add_driver+0x20c/0x2d4)
 [<c02665e8>] (bus_add_driver+0x20c/0x2d4) from [<c0268064>] (driver_register+0x78/0x194)
 [<c0268064>] (driver_register+0x78/0x194) from [<c0008668>] (do_one_initcall+0x34/0x188)
 [<c0008668>] (do_one_initcall+0x34/0x188) from [<c03de57c>] (kernel_init+0x180/0x2f0)
 [<c03de57c>] (kernel_init+0x180/0x2f0) from [<c000f0d8>] (ret_from_fork+0x14/0x3c)
 ---[ end trace 0c5a55345c42530b ]---

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] uvcvideo: Implement videobuf2 .wait_prepare and .wait_finish operations
Laurent Pinchart [Mon, 21 Jan 2013 09:51:41 +0000 (06:51 -0300)]
[media] uvcvideo: Implement videobuf2 .wait_prepare and .wait_finish operations

Those optional operations are used to release and reacquire the queue
lock when videobuf2 needs to perform operations that sleep for a long
time, such as waiting for a buffer to be complete. Implement them to
avoid blocking qbuf or streamoff calls when a dqbuf is in progress.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: Convert to devm_ioremap_resource()
Thierry Reding [Mon, 21 Jan 2013 09:09:07 +0000 (06:09 -0300)]
[media] media: Convert to devm_ioremap_resource()

Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] use IS_ENABLED() macro
Peter Senna Tschudin [Sun, 20 Jan 2013 04:32:56 +0000 (01:32 -0300)]
[media] use IS_ENABLED() macro

This patch introduces the use of IS_ENABLED() macro. For example,
replacing:
 #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
with:
 #if IS_ENABLED(CONFIG_I2C)
All changes made by this patch respect the same replacement pattern.

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,24/24] v4l2-core/v4l2-common.c: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:31 +0000 (19:41 -0300)]
[media] [V2,24/24] v4l2-core/v4l2-common.c: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_MEDIA_TUNER_TEA5761) || \
     defined(CONFIG_MEDIA_TUNER_TEA5761_MODULE)
with:
 #if IS_ENABLED(CONFIG_MEDIA_TUNER_TEA5761)
This change was made for: CONFIG_MEDIA_TUNER_TEA5761
Also replaced:
 #if defined(CONFIG_I2C) || (defined(CONFIG_I2C_MODULE) && defined(MODULE))
with:
 #if IS_ENABLED(CONFIG_I2C)

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,23/24] usb/hdpvr/hdpvr-i2c.c: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:30 +0000 (19:41 -0300)]
[media] [V2,23/24] usb/hdpvr/hdpvr-i2c.c: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_I2C) || \
     defined(CONFIG_I2C_MODULE)
with:
 #if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,22/24] usb/hdpvr/hdpvr-core.c: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:29 +0000 (19:41 -0300)]
[media] [V2,22/24] usb/hdpvr/hdpvr-core.c: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_I2C) || \
     defined(CONFIG_I2C_MODULE)
with:
 #if IS_ENABLED(CONFIG_I2C)
This change was made for: CONFIG_I2C

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,04/24] platform/marvell-ccic/mcam-core.h: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:11 +0000 (19:41 -0300)]
[media] [V2,04/24] platform/marvell-ccic/mcam-core.h: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_VIDEOBUF2_VMALLOC) || \
     defined(CONFIG_VIDEOBUF2_VMALLOC_MODULE)
with:
 #if IS_ENABLED(CONFIG_VIDEOBUF2_VMALLOC)
This change was made for: CONFIG_VIDEOBUF2_VMALLOC,
CONFIG_VIDEOBUF2_DMA_CONTIG, CONFIG_VIDEOBUF2_DMA_SG

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,03/24] pci/ttpci/av7110.c: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:10 +0000 (19:41 -0300)]
[media] [V2,03/24] pci/ttpci/av7110.c: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_INPUT_EVDEV) || \
     defined(CONFIG_INPUT_EVDEV_MODULE)
with:
 #if IS_ENABLED(CONFIG_INPUT_EVDEV)
This change was made for: CONFIG_INPUT_EVDEV,
CONFIG_DVB_SP8870

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,02/24] pci/saa7134/saa7134.h: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:09 +0000 (19:41 -0300)]
[media] [V2,02/24] pci/saa7134/saa7134.h: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_VIDEO_SAA7134_DVB) || \
     defined(CONFIG_VIDEO_SAA7134_DVB_MODULE)
with:
 #if IS_ENABLED(CONFIG_VIDEO_SAA7134_DVB)
This change was made for: CONFIG_VIDEO_SAA7134_DVB

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] [V2,01/24] pci/cx88/cx88.h: use IS_ENABLED() macro
Peter Senna Tschudin [Sat, 19 Jan 2013 22:41:08 +0000 (19:41 -0300)]
[media] [V2,01/24] pci/cx88/cx88.h: use IS_ENABLED() macro

replace:
 #if defined(CONFIG_VIDEO_CX88_DVB) || \
     defined(CONFIG_VIDEO_CX88_DVB_MODULE)
with:
 #if IS_ENABLED(CONFIG_VIDEO_CX88_DVB)
This change was made for: CONFIG_VIDEO_CX88_DVB,
CONFIG_VIDEO_CX88_BLACKBIRD, CONFIG_VIDEO_CX88_VP3054

Reported-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] blackfin: add error frame support
Scott Jiang [Fri, 18 Jan 2013 20:09:48 +0000 (17:09 -0300)]
[media] blackfin: add error frame support

Mark current frame as error frame when ppi error interrupt
report fifo error. Member next_frm in struct bcap_device can
be optimized out.

Signed-off-by: Scott Jiang <scott.jiang.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] add maintainer for blackfin media drivers
Scott Jiang [Fri, 18 Jan 2013 20:09:47 +0000 (17:09 -0300)]
[media] add maintainer for blackfin media drivers

Signed-off-by: Scott Jiang <scott.jiang.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: go7007: fix test for V4L2_STD_SECAM
Dan Carpenter [Mon, 28 Jan 2013 13:19:42 +0000 (10:19 -0300)]
[media] staging: go7007: fix test for V4L2_STD_SECAM

The current test doesn't make a lot of sense.  It's likely to be true,
which is what we would want in most cases.  From looking at how this is
handled in other drivers,  I think "&" was intended instead of "*".
It's an easy mistake to make because they are next to each other on the
keyboard.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging/media/go7007: Use kmemdup rather than duplicating its implementation
Peter Huewe [Fri, 25 Jan 2013 22:23:30 +0000 (19:23 -0300)]
[media] staging/media/go7007: Use kmemdup rather than duplicating its implementation

Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: media: go7007: call_all stream stuff Some Additional stuff for v4l2_...
Volokh Konstantin [Wed, 16 Jan 2013 12:00:51 +0000 (09:00 -0300)]
[media] staging: media: go7007: call_all stream stuff Some Additional stuff for v4l2_subdev stream events partial need for new style framework. Also need for wis_tw2804 notification stuff

Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: media: go7007: i2c GPIO initialization Reset i2c stuff for GO7007_BO...
Volokh Konstantin [Wed, 16 Jan 2013 12:00:50 +0000 (09:00 -0300)]
[media] staging: media: go7007: i2c GPIO initialization Reset i2c stuff for GO7007_BOARDID_ADLINK_MPG24 need reset GPIO always when encoder initialize

Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: media: go7007: firmware protection Protection for unfirmware load
Volokh Konstantin [Wed, 16 Jan 2013 12:00:49 +0000 (09:00 -0300)]
[media] staging: media: go7007: firmware protection Protection for unfirmware load

If no firmware was loaded (no exists,wrong or some error) then rmmod
fails with OOPS, so need some protection stuff.

Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: media: go7007: memory clear fix memory clearing for v4l2_subdev...
Volokh Konstantin [Wed, 16 Jan 2013 12:00:48 +0000 (09:00 -0300)]
[media] staging: media: go7007: memory clear fix memory clearing for v4l2_subdev allocation

Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years agoRevert "[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift"
Mauro Carvalho Chehab [Wed, 6 Feb 2013 10:29:39 +0000 (08:29 -0200)]
Revert "[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift"

On Wed, 6 Feb 2013 09:04:39 +0000
Olivier GRENIE <olivier.grenie@parrot.com> wrote:

> I do not agree with the patch. Let's take an example: adap->id = 0. Then:
>  * 1 << ~(adap->id) = 1 << ~(0) = 0
>  * ~(1 << adap->id) = ~(1 << 0) = 0xFE
>
> The correct change should be: st->channel_state |= 1 << (1 - adap->id); Indeed, the original source code was not correct.

Requested-by: Olivier GRENIE <olivier.grenie@parrot.com>
Cc: Patrick Boettcher <patrick.boettcher@dibcom.fr>
Cc: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: tvp514x: remove field description
Prabhakar Lad [Tue, 15 Jan 2013 06:55:40 +0000 (03:55 -0300)]
[media] media: tvp514x: remove field description

This patch removes the field description of fields that no
longer exists, along side aligns the field description of
fields.

Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] Support Digivox Mini HD (rtl2832)
Eddi De Pieri [Mon, 14 Jan 2013 21:21:32 +0000 (18:21 -0300)]
[media] Support Digivox Mini HD (rtl2832)

Add support for Digivox Mini HD (rtl2832)
The tuner works, but with worst performance then realtek linux driver,
due to incomplete implementation of fc2580.c

Signed-off-by: Eddi De Pieri <eddi@depieri.net>
Tested-by: Lorenzo Dongarrà <lorenzo_64@katamail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] DocBook: mention that EINVAL can be returned for invalid menu indices
Hans Verkuil [Fri, 11 Jan 2013 13:49:12 +0000 (10:49 -0300)]
[media] DocBook: mention that EINVAL can be returned for invalid menu indices

The documentation suggested that if the control value is wrong only
ERANGE can be returned. But in some cases (an invalid menu index)
EINVAL can also be returned. Clarify this.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] DocBook: improve the error_idx field documentation
Hans Verkuil [Fri, 11 Jan 2013 13:33:30 +0000 (10:33 -0300)]
[media] DocBook: improve the error_idx field documentation

The documentation of the error_idx field was incomplete and confusing.
This patch improves it.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] DocBook: fix various validation errors
Hans Verkuil [Fri, 11 Jan 2013 11:18:55 +0000 (08:18 -0300)]
[media] DocBook: fix various validation errors

Fixed the following errors (with exception of the SVG errors):
  GEN     /home/hans/work/src/v4l/media-git/Documentation/DocBook//v4l2.xml
  rm -rf Documentation/DocBook/index.html; echo '<h1>Linux Kernel HTML Documentation</h1>' >> Documentation/DocBook/index.html && echo '<h2>Kernel Version: 3.8.0-rc1</h2>' >> Documentation/DocBook/index.html && cat Documentation/DocBook/media_api.html >> Documentation/DocBook/index.html
  /tmp/x.xml:883: element revremark: validity error : Element structname is not declared in revremark list of possible children
  /tmp/x.xml:883: element revremark: validity error : Element xref is not declared in revremark list of possible children
  /tmp/x.xml:9580: element xref: validity error : Element xref was declared EMPTY this one has content
  /tmp/x.xml:13508: element link: validity error : Element link does not carry attribute linkend
  /tmp/x.xml:13508: element link: validity error : No declaration for attribute linked of element link
  /tmp/x.xml:16986: element imagedata: validity error : Value "SVG" for attribute format of imagedata is not among the enumerated set
  /tmp/x.xml:17003: element imagedata: validity error : Value "SVG" for attribute format of imagedata is not among the enumerated set
  /tmp/x.xml:17022: element imagedata: validity error : Value "SVG" for attribute format of imagedata is not among the enumerated set

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] tuners/xc5000: fix MODE_AIR in xc5000_set_params()
Dan Carpenter [Sun, 13 Jan 2013 18:31:33 +0000 (15:31 -0300)]
[media] tuners/xc5000: fix MODE_AIR in xc5000_set_params()

There is a missing break so we use XC_RF_MODE_CABLE instead of
XC_RF_MODE_AIR.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: input: use common work_struct callback function for IR RC key polling
Frank Schaefer [Sun, 13 Jan 2013 13:20:45 +0000 (10:20 -0300)]
[media] em28xx: input: use common work_struct callback function for IR RC key polling

Remove em28xx_i2c_ir_work() and check the device type in the common callback
function em28xx_ir_work() instead. Simplifies em28xx_ir_start().
Reduces the code size with a minor performance drawback.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: i2c RC devices: minor code size and memory usage optimization
Frank Schaefer [Sun, 13 Jan 2013 13:20:44 +0000 (10:20 -0300)]
[media] em28xx: i2c RC devices: minor code size and memory usage optimization

Set up the i2c_client locally in em28xx_i2c_ir_handle_key().

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: fix a comment and a small coding style issue
Frank Schaefer [Sun, 13 Jan 2013 13:20:43 +0000 (10:20 -0300)]
[media] em28xx: fix a comment and a small coding style issue

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: remove unused parameter ir_raw from i2c RC key polling functions
Frank Schaefer [Sun, 13 Jan 2013 13:20:42 +0000 (10:20 -0300)]
[media] em28xx: remove unused parameter ir_raw from i2c RC key polling functions

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: get rid of the dependency on module ir-kbd-i2c
Frank Schaefer [Sun, 13 Jan 2013 13:20:41 +0000 (10:20 -0300)]
[media] em28xx: get rid of the dependency on module ir-kbd-i2c

We already have the key polling functions and the polling infrastructure in
em28xx-input, so we can easily get rid of the dependency on module ir-kbd-i2c.
For maximum safety, do not touch the key reporting mechanism for those devices.
Code size could be improved further but would have minor peformance impacts.
Tested with device "Terratec Cinergy 200 USB" (EM2800_BOARD_TERRATEC_CINERGY_200)

[mchehab@redhat.com: Fix two checkpatch.pl warnings:
 ERROR: "foo * bar" should be "foo *bar" (line 465)
 WARNING: kfree(NULL) is safe this check is probably not required (line 725)]

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: remove i2cdprintk() messages
Frank Schaefer [Sun, 13 Jan 2013 13:20:40 +0000 (10:20 -0300)]
[media] em28xx: remove i2cdprintk() messages

We don't report any key/scan codes or errors inside the key polling functions
for internal IR RC devices, just in the key handling fucntions.
Do the same for external devices.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx-input: remove dead code line from em28xx_get_key_em_haup()
Frank Schaefer [Sun, 13 Jan 2013 13:20:39 +0000 (10:20 -0300)]
[media] em28xx-input: remove dead code line from em28xx_get_key_em_haup()

Field 'old' of struct IR_i2c is used nowhere in module ir-kbd-i2c.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] em28xx: add missing IR RC slave address to the list of known i2c devices
Frank Schaefer [Sun, 13 Jan 2013 13:15:08 +0000 (10:15 -0300)]
[media] em28xx: add missing IR RC slave address to the list of known i2c devices

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] cx231xx: add a missing break statement
Dan Carpenter [Fri, 11 Jan 2013 05:48:41 +0000 (02:48 -0300)]
[media] cx231xx: add a missing break statement

My static checker complains about the fall through here.  From the
context it looks like we should add a break statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] staging: go7007: print the audio input type
Dan Carpenter [Thu, 10 Jan 2013 08:00:57 +0000 (05:00 -0300)]
[media] staging: go7007: print the audio input type

Smatch complains that the "Audio input:" printk isn't reachable.  Hiding
the "return 0;" behind another statement is a style violation.
It looks like audio_input is normally configured so I've enabled the
print statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drivers/media/pci: use memmove for overlapping regions
Nickolai Zeldovich [Tue, 8 Jan 2013 01:28:05 +0000 (22:28 -0300)]
[media] drivers/media/pci: use memmove for overlapping regions

Change several memcpy() to memmove() in cases when the regions are
definitely overlapping; memcpy() of overlapping regions is undefined
behavior in C and can produce different results depending on the compiler,
the memcpy implementation, etc.

Cc: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] DocBook: media: struct v4l2_capability card field is a UTF-8 string
Laurent Pinchart [Mon, 7 Jan 2013 19:30:24 +0000 (16:30 -0300)]
[media] DocBook: media: struct v4l2_capability card field is a UTF-8 string

The struct v4l2_capability card field stores the device name. That name
can be hardcoded in drivers, or be retrieved directly from the device.
The later is very common with USB devices. As several devices already
report names that include non-ASCII characters, update the field
description to use UTF-8.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] media: cx18, ivtv: eliminate unnecessary array index checks
Nickolai Zeldovich [Mon, 7 Jan 2013 00:52:03 +0000 (21:52 -0300)]
[media] media: cx18, ivtv: eliminate unnecessary array index checks

The idx values passed to cx18_i2c_register() and ivtv_i2c_register()
by cx18_init_subdevs() and ivtv_load_and_init_modules() respectively
are always in-range, based on how the hw_all bitmask is populated.
Previously, the checks were already ineffective because arrays were
being dereferenced using the index before the check.

Acked-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift
Nickolai Zeldovich [Sat, 5 Jan 2013 18:13:05 +0000 (15:13 -0300)]
[media] drivers/media/usb/dvb-usb/dib0700_core.c: fix left shift

Fix bug introduced in 7757ddda6f4febbc52342d82440dd4f7a7d4f14f, where
instead of bit-negating the bitmask, the bit position was bit-negated
instead.

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: Olivier Grenie <olivier.grenie@dibcom.fr>
Cc: Patrick Boettcher <patrick.boettcher@dibcom.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] iguanair: intermittent initialization failure
Sean Young [Mon, 14 Jan 2013 08:51:44 +0000 (05:51 -0300)]
[media] iguanair: intermittent initialization failure

On cold boot the device does not initialize until the first packet is
received, and that packet is not processed.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
11 years ago[media] iguanair: ensure transmission mask is initialized
Sean Young [Sun, 6 Jan 2013 16:19:44 +0000 (13:19 -0300)]
[media] iguanair: ensure transmission mask is initialized

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>