GitHub/LineageOS/android_kernel_samsung_universal7580.git
14 years agoStaging: hv: test return value of VmbusChannelEstablishGpadl()
Bill Pemberton [Wed, 5 May 2010 19:27:37 +0000 (15:27 -0400)]
Staging: hv: test return value of VmbusChannelEstablishGpadl()

The return value of VmbusChannelEstablishGpadl() was not examined in
Channel.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT() in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:36 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT() in Channel.c

return an error instead of calling ASSERT() if VmbusPostMessage()
fails.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT() in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:35 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT() in Channel.c

check memory allocation in VmbusChannelCreateGpadlHeader() and
return -ENOMEM if it fails

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT()s in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:34 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT()s in Channel.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: test return value of osd_WaitEventCreate()
Bill Pemberton [Wed, 5 May 2010 19:27:33 +0000 (15:27 -0400)]
Staging: hv: test return value of osd_WaitEventCreate()

The return value of osd_WaitEventCreate() was not examined in some
places.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: return correct error values in Connection.c
Bill Pemberton [Wed, 5 May 2010 19:27:32 +0000 (15:27 -0400)]
Staging: hv: return correct error values in Connection.c

Also check the kzalloc call return value.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: check return value of osd_PageAlloc()
Bill Pemberton [Wed, 5 May 2010 19:27:30 +0000 (15:27 -0400)]
Staging: hv: check return value of osd_PageAlloc()

The return value of osd_PageAlloc() was checked using an ASSERT().
Change that to more useful behaviour.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT()s in ChannelMgt.c
Bill Pemberton [Wed, 5 May 2010 19:27:31 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT()s in ChannelMgt.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Remove check for NULL before calling kfree()
Bill Pemberton [Wed, 5 May 2010 19:27:29 +0000 (15:27 -0400)]
Staging: hv: Remove check for NULL before calling kfree()

kfree() knows how to deal with NULL, so there's no reason to check for
NULL before passing something to it.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155v4l: fix some sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 17:45:16 +0000 (10:45 -0700)]
Staging: dt3155v4l: fix some sparse warnings

Mostly some __iomem markings and some static functions as well.

Cc: Marin Mitov <mitov@issp.bas.bg
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155v4l: Adding the missing linux/delay.h
Marin Mitov [Wed, 5 May 2010 17:31:38 +0000 (20:31 +0300)]
Staging: dt3155v4l: Adding the missing linux/delay.h

The prototypes of udelay() and msleep() are in linux/delay.h,
so include it.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: code cleanup, resolved sparse finding
Andres More [Tue, 4 May 2010 23:40:11 +0000 (20:40 -0300)]
Staging: vt6656: code cleanup, resolved sparse finding

Cleared sparse warning 'Using plain integer as NULL pointer'

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: code cleanup, removed OUT definition
Andres More [Tue, 4 May 2010 23:40:10 +0000 (20:40 -0300)]
Staging: vt6656: code cleanup, removed OUT definition

Remoted empty OUT define in ttype.h and its usage across the code.

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: removed SUCCESS define as it is not used
Andres More [Tue, 4 May 2010 23:40:09 +0000 (20:40 -0300)]
Staging: vt6656: removed SUCCESS define as it is not used

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: arlan: fixed unnecessary whitespace style issue in arlan-main.c
Prashant P. Shah [Wed, 5 May 2010 14:16:28 +0000 (19:46 +0530)]
Staging: arlan: fixed unnecessary whitespace style issue in arlan-main.c

This is a patch to the arlan-main.c file that fixes the unnecessary whitespace
issues found by the checkpatch.pl tool.

Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: cxt1e1: fix up one remaining THIS_MODULE usage
Peter Hüwe [Wed, 5 May 2010 12:21:14 +0000 (14:21 +0200)]
Staging: cxt1e1: fix up one remaining THIS_MODULE usage

Copied from original Patch by Randy Dunlap

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192u: Check kmalloc return value before use the buffer in ieee80211_soft...
wzt.wzt@gmail.com [Wed, 5 May 2010 06:56:52 +0000 (14:56 +0800)]
Staging: rtl8192u: Check kmalloc return value before use the buffer in ieee80211_softmac.c

Check kmalloc return value before use the buffer.

Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: cb_pcidas64: fix up build warnings
Greg Kroah-Hartman [Wed, 5 May 2010 16:12:13 +0000 (09:12 -0700)]
Staging: comedi: cb_pcidas64: fix up build warnings

Now that the 8255.h file is being included properly, we were
using the incorrect function prototypes, which causes a build
warning now.  This fixes it up and preserves the __iomem markings that
sparse wants to see.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: 8255: fix up previous static markings.
Greg Kroah-Hartman [Wed, 5 May 2010 16:10:31 +0000 (09:10 -0700)]
Staging: comedi: 8255: fix up previous static markings.

Ian pointed out that exported symbols should not be marked as static :)

Fixed this up by properly including the 8255.h file, and fixing
the function prototypes there, as the CONFIG variables were not getting
set so users of the header file were seeing the incorrect function
prototypes.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: line6: driver: fix up sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 05:45:08 +0000 (22:45 -0700)]
Staging: line6: driver: fix up sparse warnings

minor stuff.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: industrialio-trigger.c: minor fixups
Greg Kroah-Hartman [Wed, 5 May 2010 05:34:00 +0000 (22:34 -0700)]
Staging: iio: industrialio-trigger.c: minor fixups

We needed to include a header file that declared the functions that are
being exported in this file.

Also fix up an indentation problem, and some sparse warnings.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: ring_sw.c: fix up sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 05:33:27 +0000 (22:33 -0700)]
Staging: iio: ring_sw.c: fix up sparse warnings

NULL usage, static stuff, etc.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: industrialio-ring.c: fix up sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 05:32:43 +0000 (22:32 -0700)]
Staging: iio: industrialio-ring.c: fix up sparse warnings

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: accel: fix up some sparse warnings.
Greg Kroah-Hartman [Wed, 5 May 2010 05:32:01 +0000 (22:32 -0700)]
Staging: iio: accel: fix up some sparse warnings.

Minor stuff (static, NULL, etc.)

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: trigger: fix up some global variables
Greg Kroah-Hartman [Wed, 5 May 2010 05:31:22 +0000 (22:31 -0700)]
Staging: iio: trigger: fix up some global variables

These should be static.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: light: tsl2563: fix static sparse warning
Greg Kroah-Hartman [Wed, 5 May 2010 05:29:41 +0000 (22:29 -0700)]
Staging: iio: light: tsl2563: fix static sparse warning

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: adc: max1363_ring.c: fix up sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 05:28:37 +0000 (22:28 -0700)]
Staging: iio: adc: max1363_ring.c: fix up sparse warnings

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: max1363_core: fix bug in kzalloc call
Greg Kroah-Hartman [Wed, 5 May 2010 05:26:19 +0000 (22:26 -0700)]
Staging: iio: max1363_core: fix bug in kzalloc call

The operands were switched around :(

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: adc: max1363_core: fix up some sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 05:24:05 +0000 (22:24 -0700)]
Staging: iio: adc: max1363_core: fix up some sparse warnings

Also fix a minor coding style issue.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: light trivial whitespace fix
Jonathan Cameron [Tue, 4 May 2010 21:34:37 +0000 (22:34 +0100)]
Staging: iio: light trivial whitespace fix

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: accelerometers trivial checkpatch related fixes
Jonathan Cameron [Tue, 4 May 2010 21:34:36 +0000 (22:34 +0100)]
Staging: iio: accelerometers trivial checkpatch related fixes

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: Trivial - remove pointless semi colon (checkpatch found)
Jonathan Cameron [Tue, 4 May 2010 21:20:54 +0000 (22:20 +0100)]
Staging: iio: Trivial - remove pointless semi colon (checkpatch found)

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: add basic ethtool support
Stephen Hemminger [Tue, 4 May 2010 16:58:57 +0000 (09:58 -0700)]
Staging: hv: add basic ethtool support

Ethtool allows querying device information and controlling parameters.
For now just add ability to turn on/off scatter/gather.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: add transmit flow control
Stephen Hemminger [Tue, 4 May 2010 16:58:56 +0000 (09:58 -0700)]
Staging: hv: add transmit flow control

Keep track of the number of pages sent over transmit and stop
before going over.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: transmit scatter gather support
Stephen Hemminger [Tue, 4 May 2010 16:58:55 +0000 (09:58 -0700)]
Staging: hv: transmit scatter gather support

The transmit management of pages was confusing for handling
fragmented SKB's. (But since NETIF_F_SG was never set, the code was never hit).

The parameter AdditionalRequestPageBufferCount is always one,
(and leads to ugly code), so just inline and add comments.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: use existing Ethernet header size
Stephen Hemminger [Tue, 4 May 2010 16:58:54 +0000 (09:58 -0700)]
Staging: hv: use existing Ethernet header size

Use ETH_ALEN to indicate that MAC address is Ethernet.
Also use Linux printk format for mac addresses.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: ring parameter
Stephen Hemminger [Tue, 4 May 2010 16:58:53 +0000 (09:58 -0700)]
Staging: hv: ring parameter

The ring size parameter should be number of pages (not bytes).
Add module parameter information as well.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: cleanup network driver
Stephen Hemminger [Tue, 4 May 2010 16:58:52 +0000 (09:58 -0700)]
Staging: hv: cleanup network driver

Minor stuff:
   * Add module description
   * Remove variable set but never used.
   * Move variable inside conditional

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci3xxx.c: loads of sparse cleanups
Greg Kroah-Hartman [Tue, 4 May 2010 23:14:02 +0000 (16:14 -0700)]
Staging: comedi: hwdrv_apci3xxx.c: loads of sparse cleanups

__iomem pointer fixes, and static cleanups.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci3501.h: make a variable static.
Greg Kroah-Hartman [Tue, 4 May 2010 23:13:28 +0000 (16:13 -0700)]
Staging: comedi: hwdrv_apci3501.h: make a variable static.

Cleans up the sparse warning.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci2032.c: static sparse fix
Greg Kroah-Hartman [Tue, 4 May 2010 23:12:53 +0000 (16:12 -0700)]
Staging: comedi: hwdrv_apci2032.c: static sparse fix

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci1564.c: static sparse cleanups.
Greg Kroah-Hartman [Tue, 4 May 2010 23:12:29 +0000 (16:12 -0700)]
Staging: comedi: hwdrv_apci1564.c: static sparse cleanups.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci1500.c: sparse static cleanups
Greg Kroah-Hartman [Tue, 4 May 2010 23:12:00 +0000 (16:12 -0700)]
Staging: comedi: hwdrv_apci1500.c: sparse static cleanups

Mark a bunch of variables and functions as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci1032.c: sparse warning fixups
Greg Kroah-Hartman [Tue, 4 May 2010 23:11:26 +0000 (16:11 -0700)]
Staging: comedi: hwdrv_apci1032.c: sparse warning fixups

Mark a variable as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci035.h: fix sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:10:36 +0000 (16:10 -0700)]
Staging: comedi: hwdrv_apci035.h: fix sparse warnings

This let us delete two variables and mark one as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: hwdrv_apci035.c: fix sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:09:53 +0000 (16:09 -0700)]
Staging: comedi: hwdrv_apci035.c: fix sparse warnings

Some variables should be static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: adl_pci9111.c: fix sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:09:26 +0000 (16:09 -0700)]
Staging: comedi: adl_pci9111.c: fix sparse warnings

divisor and other problems fixed.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: adl_pci9118.c: fix unsigned problem with divisors
Greg Kroah-Hartman [Tue, 4 May 2010 23:08:51 +0000 (16:08 -0700)]
Staging: comedi: adl_pci9118.c: fix unsigned problem with divisors

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: adv_pci1710.c: fix unsigned problem with divisors
Greg Kroah-Hartman [Tue, 4 May 2010 23:08:24 +0000 (16:08 -0700)]
Staging: comedi: adv_pci1710.c: fix unsigned problem with divisors

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: amplc_dio200.c: fix NULL sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:07:43 +0000 (16:07 -0700)]
Staging: comedi: amplc_dio200.c: fix NULL sparse warnings

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: cb_pcidas64.c: fix sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:07:03 +0000 (16:07 -0700)]
Staging: comedi: cb_pcidas64.c: fix sparse warnings

This fixes a bunch of iomem and other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: das1800.c: fix a locking error on the error path.
Greg Kroah-Hartman [Tue, 4 May 2010 23:06:33 +0000 (16:06 -0700)]
Staging: comedi: das1800.c: fix a locking error on the error path.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: plx9080.h: properly mark iomem variables
Greg Kroah-Hartman [Tue, 4 May 2010 23:05:52 +0000 (16:05 -0700)]
Staging: comedi: plx9080.h: properly mark iomem variables

It's a __iomem *, so mark it as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: quatech_daqp_cs.c: fix up the irq
Greg Kroah-Hartman [Tue, 4 May 2010 23:05:09 +0000 (16:05 -0700)]
Staging: comedi: quatech_daqp_cs.c: fix up the irq

The irq needs to return the correct type.  Also fix up some other
sparse warnings that were found.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_amcc_s5933.h: sparse cleanup
Greg Kroah-Hartman [Tue, 4 May 2010 23:04:19 +0000 (16:04 -0700)]
Staging: comedi: addi_amcc_s5933.h: sparse cleanup

Mark a variable static that does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_common.c: sparse cleanups
Greg Kroah-Hartman [Tue, 4 May 2010 23:03:35 +0000 (16:03 -0700)]
Staging: comedi: addi_common.c: sparse cleanups

Now that we are properly marking the variable as __iomem, don't
cast it.

Also fix up some other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_common.h: properly mark this variable as __iomem
Greg Kroah-Hartman [Tue, 4 May 2010 23:02:39 +0000 (16:02 -0700)]
Staging: comedi: addi_common.h: properly mark this variable as __iomem

It's not an unsigned long, it's a __iomem pointer, so mark it as
such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: usbduxfast.c: mark a function static
Greg Kroah-Hartman [Tue, 4 May 2010 23:02:00 +0000 (16:02 -0700)]
Staging: comedi: usbduxfast.c: mark a function static

It does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: 8255.c: mark some functions static
Greg Kroah-Hartman [Tue, 4 May 2010 23:01:19 +0000 (16:01 -0700)]
Staging: comedi: 8255.c: mark some functions static

sparse pointed out that these functions should be static, so mark them
as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: mark a variable as __user
Greg Kroah-Hartman [Tue, 4 May 2010 23:00:02 +0000 (16:00 -0700)]
Staging: comedi: mark a variable as __user

This is really a userspace pointer, so mark it as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: fix up sparse warning in hyperv_utils.c
Greg Kroah-Hartman [Tue, 4 May 2010 21:31:18 +0000 (14:31 -0700)]
Staging: hv: fix up sparse warning in hyperv_utils.c

The function isn't called by anyone else, so mark it static.

Also remove version.h, as it is not needed.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar and memrar updates
Alan Cox [Tue, 4 May 2010 19:40:12 +0000 (20:40 +0100)]
Staging: rar and memrar updates

rar: perform a clean up pass

- Move to a registration model where each RAR is claimed/unclaimed
- Use that to fix the client stuff (one client per RAR so no need to queue stuff)
- Support unregister so drivers can rmmod themselves safely
- Fix locking hang on calling rar lock from rar callback
- Clean up
- Kerneldoc

Folded in the memrar update as Greg asked

- Fix various unload related bugs
- Use the per RAR allocator/deallocator
- Add kerneldoc

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:imu ADIS16400 and ADIS16405 driver
Barry Song [Tue, 4 May 2010 13:43:15 +0000 (14:43 +0100)]
staging:iio:imu ADIS16400 and ADIS16405 driver

Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Barry Song <Barry.Song@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:imu ADIS16300 driver
Barry Song [Tue, 4 May 2010 13:43:14 +0000 (14:43 +0100)]
staging:iio:imu ADIS16300 driver

Signed-off-by: Barry Song <Barry.Song@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:Documentation: Rewrite example for new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:13 +0000 (14:43 +0100)]
staging:iio:Documentation: Rewrite example for new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:tsl2563 add a name attribute under the iio
Jonathan Cameron [Tue, 4 May 2010 13:43:12 +0000 (14:43 +0100)]
staging:iio:tsl2563 add a name attribute under the iio

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:ring_sw: Fix incorrect test on successful read of last value, causes...
Jonathan Cameron [Tue, 4 May 2010 13:43:11 +0000 (14:43 +0100)]
staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 add support for 8 bit equivalent devices, max1036-9, max11600-5
Jonathan Cameron [Tue, 4 May 2010 13:43:10 +0000 (14:43 +0100)]
staging:iio:max1363 add support for 8 bit equivalent devices, max1036-9, max11600-5

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 add support for max11606-max11617
Jonathan Cameron [Tue, 4 May 2010 13:43:09 +0000 (14:43 +0100)]
staging:iio:max1363 add support for max11606-max11617

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Remove naming via IDR's where no longer necessary under new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:08 +0000 (14:43 +0100)]
staging:iio: Remove naming via IDR's where no longer necessary under new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:tsl2563: change lux to illuminance0_input to match new abi
Jonathan Cameron [Tue, 4 May 2010 13:43:07 +0000 (14:43 +0100)]
staging:iio:tsl2563: change lux to illuminance0_input to match new abi

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Directory name changes to match new ABI.
Jonathan Cameron [Tue, 4 May 2010 13:43:06 +0000 (14:43 +0100)]
staging:iio: Directory name changes to match new ABI.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: ABI documentation (partial)
Jonathan Cameron [Tue, 4 May 2010 13:43:05 +0000 (14:43 +0100)]
staging:iio: ABI documentation (partial)

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Documentation, update iio_utils.h for the move to a bus
Jonathan Cameron [Tue, 4 May 2010 13:43:04 +0000 (14:43 +0100)]
staging:iio: Documentation, update iio_utils.h for the move to a bus

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 move to new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:03 +0000 (14:43 +0100)]
staging:iio:max1363 move to new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Clean out unused IIO_SCAN_EL and add IIO_SCAN_NAMED_EL_C
Jonathan Cameron [Tue, 4 May 2010 13:43:02 +0000 (14:43 +0100)]
staging:iio: Clean out unused IIO_SCAN_EL and add IIO_SCAN_NAMED_EL_C

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Move event attributes into the event[n] device in sysfs
Jonathan Cameron [Tue, 4 May 2010 13:43:01 +0000 (14:43 +0100)]
staging:iio: Move event attributes into the event[n] device in sysfs

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: Move from class to bus
Jonathan Cameron [Tue, 4 May 2010 13:43:00 +0000 (14:43 +0100)]
staging: iio: Move from class to bus

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Support functions for scan mask matching
Jonathan Cameron [Tue, 4 May 2010 13:42:59 +0000 (14:42 +0100)]
staging:iio: Support functions for scan mask matching

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoiio:staging:accelerometers move towards the new abi
Jonathan Cameron [Tue, 4 May 2010 13:42:58 +0000 (14:42 +0100)]
iio:staging:accelerometers move towards the new abi

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Add new attrs for sampling frequency available and temp_raw
Jonathan Cameron [Tue, 4 May 2010 13:42:57 +0000 (14:42 +0100)]
staging:iio: Add new attrs for sampling frequency available and temp_raw

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Add new in_raw definitions for adc channels.
Jonathan Cameron [Tue, 4 May 2010 13:42:56 +0000 (14:42 +0100)]
staging:iio: Add new in_raw definitions for adc channels.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: all rtl8192su chips have the 93c46 eprom
Florian Schilhabel [Tue, 4 May 2010 12:24:35 +0000 (14:24 +0200)]
Staging: rtl8192su: all rtl8192su chips have the 93c46 eprom

all rtl8192su chips have the 93c46 eprom. (no 93c56)
it it theoretically safe to remove the 93c56 definitions and some unneeded code.
if your device stops working after this patch, please send me a mail
and include some information about your device:
* dmesg
* lsusb -v
* _exact_ chipset (version)
* vendor
* everything else, that may help

plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: refactored FirmwareCheckReady
Florian Schilhabel [Tue, 4 May 2010 12:24:12 +0000 (14:24 +0200)]
Staging: rtl8192su: refactored FirmwareCheckReady

replaced if..else if..else by a switch.
this is hopefully easier to read.

plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: check for skb == NULL
Florian Schilhabel [Tue, 4 May 2010 12:23:43 +0000 (14:23 +0200)]
Staging: rtl8192su: check for skb == NULL

added 2 checks for skb == NULL.
plus cosmetics

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: staging/cxt1e1: Convert bare printks to pr_<level>
Joe Perches [Mon, 3 May 2010 19:33:16 +0000 (12:33 -0700)]
Staging: staging/cxt1e1: Convert bare printks to pr_<level>

Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
A few line splits for long arguments
A couple of embedded function names converted to "%s", __func__
Removed some uses of THIS_MODULE->name

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: move ASSERT(scmnd) to a more useful location
Bill Pemberton [Mon, 3 May 2010 21:50:45 +0000 (17:50 -0400)]
Staging: hv: move ASSERT(scmnd) to a more useful location

There's not much point to make sure scmnd is not NULL after an assert
that would dereference scmnd.  The ASSERT()'s should be removed, but
until they are at least they at least can be in the right order.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: delete ext_utils.c
Greg Kroah-Hartman [Tue, 4 May 2010 15:26:23 +0000 (08:26 -0700)]
Staging: hv: delete ext_utils.c

A whole file just for a single line function call is beyond silly.
Delete it and move the call into where it is being called.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: fix up formatting issues in utils.h
Greg Kroah-Hartman [Tue, 4 May 2010 15:21:01 +0000 (08:21 -0700)]
Staging: hv: fix up formatting issues in utils.h

--------  cut here and print out and paste on wall --------

Tabs, not spaces

--------  cut here and print out and paste on wall --------

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Added new hv_utils driver with shutdown as first functionality
Hank Janssen [Tue, 4 May 2010 22:55:05 +0000 (15:55 -0700)]
Staging: hv: Added new hv_utils driver with shutdown as first functionality

Addition of new driver for Hyper-V called hv_utils.
This driver is intended to support things like KVP, Timesync, Heartbeat etc.

This first release has support for Gracefull shutdown.
e.g. Select shutdown from the Hyper-V main admin screen and the Linux VM
will do a gracefull shutdown.

Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: __user markup on comedi_fops.c
Greg Kroah-Hartman [Mon, 3 May 2010 23:32:28 +0000 (16:32 -0700)]
Staging: comedi: __user markup on comedi_fops.c

Hm, what a mess.  I tried to properly mark up the __user pointers,
but for some of these structures, we use them both in the kernel,
and across the user/kernel boundry, which isn't ok.  So we end
up generating a few new sparse warnings in places we were not before,
but the large majority of things are now properly tagged in the fops
file.

The whole ioctl interface needs to be carefully looked at in the future.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: drivers.c sparse cleanup
Greg Kroah-Hartman [Mon, 3 May 2010 22:55:45 +0000 (15:55 -0700)]
Staging: comedi: drivers.c sparse cleanup

Fix up some sparse issues in drivers.c

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: range.c: properly mark up __user pointers
Greg Kroah-Hartman [Mon, 3 May 2010 22:50:09 +0000 (15:50 -0700)]
Staging: comedi: range.c: properly mark up __user pointers

This is the start of cleaning up the user pointer markings
in the comedi core.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move some more functions to internal.h
Greg Kroah-Hartman [Mon, 3 May 2010 22:38:37 +0000 (15:38 -0700)]
Staging: comedi: move some more functions to internal.h

Only the internal comedi core calls these, so put them here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: clean up sparse issues in proc.c
Greg Kroah-Hartman [Mon, 3 May 2010 22:32:04 +0000 (15:32 -0700)]
Staging: comedi: clean up sparse issues in proc.c

The whole file should be converted to use seqfile, if it's even
still needed.  Or move to debugfs.

Anyway, I fixed up the minor issues here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_reset_async_buf local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:27:52 +0000 (15:27 -0700)]
Staging: comedi: make comedi_reset_async_buf local to comedi core

No one outside of the comedi core calls this function, so don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_free_board_minor local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:24:14 +0000 (15:24 -0700)]
Staging: comedi: make comedi_free_board_minor local to comedi core

No one outside of the comedi core calls this function, so don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_alloc_board_minor local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:20:29 +0000 (15:20 -0700)]
Staging: comedi: make comedi_alloc_board_minor local to comedi core

No one outside of the comedi core calls this function, so create
an internal.h file to put the prototype in, and don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_set_subdevice_runflags() static
Greg Kroah-Hartman [Mon, 3 May 2010 22:15:06 +0000 (15:15 -0700)]
Staging: comedi: make comedi_set_subdevice_runflags() static

No one calls this anymore, except the core comedi code, so
mark it static and don't export it.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: make it typesafe
Greg Kroah-Hartman [Mon, 3 May 2010 22:01:50 +0000 (15:01 -0700)]
Staging: comedi: kcomedilib: make it typesafe

If we really are passing in a struct comedi_device, then say we are,
don't mess around with void pointers for no reason.

This also fixes up the comedi_bond.c driver, which is the only
user of the kcomedilib code.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>