Alexander Ebert [Fri, 21 Aug 2020 09:25:00 +0000 (11:25 +0200)]
The implementation for JS bundles for other repositories was outdated
See #3520
Alexander Ebert [Thu, 20 Aug 2020 22:50:53 +0000 (00:50 +0200)]
Update the number of votes in a poll after voting
Alexander Ebert [Thu, 20 Aug 2020 22:28:41 +0000 (00:28 +0200)]
Merge branch '5.2'
Alexander Ebert [Thu, 20 Aug 2020 22:28:22 +0000 (00:28 +0200)]
Prevent the focus being trapped if the user intentionally clicks outside
Clicking on a link or button outside of the overlay caused the browser to close the drop-down and shift the focus on the menu element.
woltlab.com [Thu, 20 Aug 2020 16:18:22 +0000 (16:18 +0000)]
Updating minified JavaScript files
Alexander Ebert [Thu, 20 Aug 2020 16:13:45 +0000 (18:13 +0200)]
uglifyjs.minify expects the code and not a path
For whatever reason that this has worked in the past, in node 14+ the behavior appears to have been changed.
The `cascade` option is not mentioned in the list of valid options and since error message were implicitly suppressed, this went by unnoticed.
Fixes #3520
Alexander Ebert [Thu, 20 Aug 2020 09:52:57 +0000 (11:52 +0200)]
Merge branch '5.2'
Alexander Ebert [Thu, 20 Aug 2020 09:52:30 +0000 (11:52 +0200)]
Merge pull request #3525 from WoltLab/rich-metacode-in-quick-reply
Prevent rich metacode being dysfunctional in new messages
Alexander Ebert [Wed, 19 Aug 2020 22:50:46 +0000 (00:50 +0200)]
Merge branch '5.2'
Alexander Ebert [Wed, 19 Aug 2020 22:50:13 +0000 (00:50 +0200)]
Merge pull request #3523 from WoltLab/dropdown-scrollbar-large-tablets-fix
Fix the scrollbar for dropdowns on large tablets
Alexander Ebert [Wed, 19 Aug 2020 17:26:11 +0000 (19:26 +0200)]
Prevent rich metacode being dysfunctional in messages just created by replying
The `isset` strategy does not work properly, because in some cases the HTML is evaluated before being placed in the final template, causing the variable to be set already.
This changes modifies the behavior to always attempt to initialize the JavaScript, but made changes to ensure that each subsequent call is idempotent.
Matthias Schmidt [Wed, 19 Aug 2020 16:38:35 +0000 (18:38 +0200)]
Add missing word in exception message
See
709b412bf72084e48d408787d8455f9876fcdaed
joshuaruesweg [Wed, 19 Aug 2020 13:32:27 +0000 (15:32 +0200)]
Fix the scrollbar for dropdowns on large tablets
Because tablets are not the platform "desktop", the scrollbar is not shown for tablets, even though they are rendered with desktop view.
Fixes #3522
Alexander Ebert [Wed, 19 Aug 2020 08:41:18 +0000 (10:41 +0200)]
Merge branch '5.2'
Alexander Ebert [Wed, 19 Aug 2020 08:40:47 +0000 (10:40 +0200)]
Disable the search for updates buttons while active
Alexander Ebert [Wed, 19 Aug 2020 08:00:20 +0000 (10:00 +0200)]
Merge pull request #3519 from WoltLab/reactions-smartphone-optimization
Overflow handling for reaction popovers on smartphones
Alexander Ebert [Wed, 19 Aug 2020 08:00:02 +0000 (10:00 +0200)]
Reset the scroll position for popovers aligned to the bottom
Tim Düsterhus [Wed, 19 Aug 2020 07:51:42 +0000 (09:51 +0200)]
Merge branch '5.2' into master
Marcel Werk [Tue, 18 Aug 2020 18:22:33 +0000 (20:22 +0200)]
Merge pull request #3514 from WoltLab/form-link-to-created-item
Forms: Provide a link to edit an item that was just created
Marcel Werk [Tue, 18 Aug 2020 18:21:51 +0000 (20:21 +0200)]
Changed appearance of the edit link
Alexander Ebert [Tue, 18 Aug 2020 18:12:35 +0000 (20:12 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Tue, 18 Aug 2020 17:54:44 +0000 (19:54 +0200)]
Use of explicit font weight `600` instead of `bold`
Matthias Schmidt [Tue, 18 Aug 2020 17:35:29 +0000 (19:35 +0200)]
Toggling preview button is only possible before building form
See #3513
Joshua Rüsweg [Tue, 18 Aug 2020 17:22:02 +0000 (19:22 +0200)]
Merge pull request #3521 from Krymonota/patch-13
Remove redundant `implements IWorker`
Niklas [Tue, 18 Aug 2020 17:14:12 +0000 (19:14 +0200)]
Remove redundant `implements IWorker`
Alexander Ebert [Tue, 18 Aug 2020 15:57:10 +0000 (17:57 +0200)]
Incorrect scroll position and reaction order
Alexander Ebert [Tue, 18 Aug 2020 15:02:24 +0000 (17:02 +0200)]
Compute the overflow indicators when displaying the popover
Alexander Ebert [Tue, 18 Aug 2020 14:58:06 +0000 (16:58 +0200)]
CSS incorrectly applied for non smartphones sizes
Alexander Ebert [Tue, 18 Aug 2020 14:56:29 +0000 (16:56 +0200)]
Cleaned up the dependencies
Marcel Werk [Tue, 18 Aug 2020 13:43:37 +0000 (15:43 +0200)]
Added new template 'formNotice'
Marcel Werk [Tue, 18 Aug 2020 13:39:11 +0000 (15:39 +0200)]
Fixed double call of executeAction()
Matthias Schmidt [Sat, 15 Aug 2020 12:46:51 +0000 (14:46 +0200)]
Fix deprecation warnings in form builder in PHP 8
Close #3489
Alexander Ebert [Mon, 17 Aug 2020 16:54:40 +0000 (18:54 +0200)]
Overflow handling for reaction popovers on smartphones
Closes #3518
ilou [Mon, 17 Aug 2020 16:44:31 +0000 (18:44 +0200)]
Allow disabling preview button in WYSIWYG form container
Marcel Werk [Mon, 17 Aug 2020 16:05:15 +0000 (18:05 +0200)]
Merge branch 'master' into form-link-to-created-item
Marcel Werk [Mon, 17 Aug 2020 16:03:54 +0000 (18:03 +0200)]
Use of LinkHandler::getControllerLink() instead of LinkHandler::getLink()
Tim Düsterhus [Mon, 17 Aug 2020 15:21:17 +0000 (17:21 +0200)]
Merge pull request #3517 from WoltLab/zxcvbn-bundle
Load zxcvbn on demand
Tim Düsterhus [Mon, 17 Aug 2020 15:20:45 +0000 (17:20 +0200)]
Merge pull request #3516 from WoltLab/retain-dimensions-aspect-ratio
Improve phrasing for *_retain_dimensions phrases
Joshua Rüsweg [Mon, 17 Aug 2020 14:24:29 +0000 (16:24 +0200)]
Merge pull request #3476 from WoltLab/failsafe-scss
Failsafe Style SCSS
joshuaruesweg [Mon, 17 Aug 2020 14:13:25 +0000 (16:13 +0200)]
Fix comment
joshuaruesweg [Mon, 17 Aug 2020 13:50:25 +0000 (15:50 +0200)]
Fix image path on editing styles
Tim Düsterhus [Mon, 17 Aug 2020 13:34:27 +0000 (15:34 +0200)]
Remove 3.1.* update instructions
This cleans up package.xml. The 3.1.* instructions are not required for master / 5.3.
Tim Düsterhus [Mon, 17 Aug 2020 13:13:59 +0000 (15:13 +0200)]
Remove unused div from PasswordStrength.js
Tim Düsterhus [Mon, 17 Aug 2020 13:12:14 +0000 (15:12 +0200)]
Load zxcvbn on demand
Resolves #3515
Tim Düsterhus [Mon, 17 Aug 2020 13:00:07 +0000 (15:00 +0200)]
Improve phrasing for *_retain_dimensions phrases
- de: s/Bildformat/Seitenverhältnis/
- en: s/Dimensions/Aspect Ratio/
- en: Use Title Case
Resolves #3510
woltlab.com [Mon, 17 Aug 2020 10:29:28 +0000 (10:29 +0000)]
Updating minified JavaScript files
Marcel Werk [Sun, 16 Aug 2020 13:36:46 +0000 (15:36 +0200)]
Forms: Provide a link to edit an item that was just created
Closes #3289
Alexander Ebert [Sat, 15 Aug 2020 18:04:03 +0000 (20:04 +0200)]
Close the notification drop-down after clicking a link
This prevents the drop-down from staying open if the link is _effectively_ a no-op that does not cause a navigation, such as when the link target is the current page.
Alexander Ebert [Sat, 15 Aug 2020 17:37:20 +0000 (19:37 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 15 Aug 2020 17:35:58 +0000 (19:35 +0200)]
Prefer longer group names for mentions
Marcel Werk [Sat, 15 Aug 2020 14:16:03 +0000 (16:16 +0200)]
Added a unique key to `wcf1_user.username`
Closes #3494
Marcel Werk [Sat, 15 Aug 2020 14:12:03 +0000 (16:12 +0200)]
Increase upload limits to more reasonable values
Closes #3457
joshuaruesweg [Fri, 14 Aug 2020 14:35:26 +0000 (16:35 +0200)]
Fix indentation
joshuaruesweg [Fri, 14 Aug 2020 14:29:11 +0000 (16:29 +0200)]
Fix cleanup
joshuaruesweg [Fri, 14 Aug 2020 13:13:00 +0000 (15:13 +0200)]
Generate CSS on saving custom CSS
Joshua Rüsweg [Fri, 14 Aug 2020 13:42:59 +0000 (15:42 +0200)]
Merge pull request #3511 from WoltLab/worker-thread-error-handling
Add proper error handling to WorkerCLICommand with --threads > 1
Tim Düsterhus [Fri, 14 Aug 2020 10:28:02 +0000 (12:28 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Fri, 14 Aug 2020 10:22:16 +0000 (12:22 +0200)]
Skip display-name of Mailbox if display-name == addr-spec
If the human readable $name of a Mailbox matches the $address then leave
out the $name within the header representation and specify a bare email
address. The name is redundant in cases like this and this might lead to
negative spam scoring.
Tim Düsterhus [Fri, 14 Aug 2020 09:39:29 +0000 (11:39 +0200)]
Add proper error handling to WorkerCLICommand with --threads > 1
Fixes #3507
Alexander Ebert [Thu, 13 Aug 2020 21:39:37 +0000 (23:39 +0200)]
Convert `<small>` into `font-size`
Alexander Ebert [Thu, 13 Aug 2020 18:26:47 +0000 (20:26 +0200)]
Allow the `dropover` to bubble from the editor
Enables proper drag & drop when running in fullscreen mode.
Fixes #3509
Tim Düsterhus [Thu, 13 Aug 2020 13:54:09 +0000 (15:54 +0200)]
Merge pull request #3508 from WoltLab/update-default-style
Update defaultStyle/ and defaultStyle.tar
Tim Düsterhus [Thu, 13 Aug 2020 11:48:16 +0000 (13:48 +0200)]
Update defaultStyle/ and defaultStyle.tar
The files have been created by exporting the style from the ACP for the
current git master.
Resolves #3459
Alexander Ebert [Thu, 13 Aug 2020 11:31:56 +0000 (13:31 +0200)]
Merge branch '5.2'
Alexander Ebert [Thu, 13 Aug 2020 11:31:37 +0000 (13:31 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Thu, 13 Aug 2020 11:31:16 +0000 (13:31 +0200)]
Merge pull request #3500 from Krymonota/patch-12
Add missing phrases to English 3rd party register language items
Alexander Ebert [Thu, 13 Aug 2020 11:29:36 +0000 (13:29 +0200)]
Merge pull request #3483 from WoltLab/page-action-buttons-overhaul
Overhauled the page action buttons' behavior
joshuaruesweg [Thu, 13 Aug 2020 07:46:00 +0000 (09:46 +0200)]
Merge branch '5.2'
joshuaruesweg [Thu, 13 Aug 2020 07:44:48 +0000 (09:44 +0200)]
Fix resizing images in Safari
Fixes #3506
Tim Düsterhus [Thu, 13 Aug 2020 07:07:10 +0000 (09:07 +0200)]
Merge pull request #3505 from WoltLab/create-thumbnail-leak
Clear thumbnail handles as soon as possible
Marcel Werk [Wed, 12 Aug 2020 16:23:53 +0000 (18:23 +0200)]
Merge branch '5.2'
Marcel Werk [Wed, 12 Aug 2020 16:22:56 +0000 (18:22 +0200)]
Merge branch '3.1' into 5.2
Marcel Werk [Wed, 12 Aug 2020 16:22:37 +0000 (18:22 +0200)]
Prevent username overflow in the message sidebar
Marcel Werk [Wed, 12 Aug 2020 15:52:11 +0000 (17:52 +0200)]
Merge branch '5.2'
Marcel Werk [Wed, 12 Aug 2020 15:51:54 +0000 (17:51 +0200)]
Merge branch '3.1' into 5.2
Marcel Werk [Wed, 12 Aug 2020 15:51:25 +0000 (17:51 +0200)]
Prevent changes to the showOrder setting of system boxes during an update
Marcel Werk [Wed, 12 Aug 2020 15:47:36 +0000 (17:47 +0200)]
Merge branch '5.2'
Marcel Werk [Wed, 12 Aug 2020 15:47:22 +0000 (17:47 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Wed, 29 Jan 2020 13:38:56 +0000 (14:38 +0100)]
Prevent changes to the visibility settings of system boxes during an update/upgrade
Tim Düsterhus [Wed, 12 Aug 2020 15:14:54 +0000 (17:14 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Wed, 12 Aug 2020 14:13:05 +0000 (16:13 +0200)]
Merge pull request #3502 from Krymonota/timing-safe-comparison-social-login
Use timing safe comparison to validate `state` parameter for social login
Niklas [Wed, 12 Aug 2020 14:08:29 +0000 (16:08 +0200)]
Fix type of `options` parameter in HTTPRequest PHPDoc (#3504)
Niklas (Krymonota) [Wed, 12 Aug 2020 13:59:26 +0000 (15:59 +0200)]
Use timing safe comparison to validate `state` parameter for social login
The Twitter social login is left out because the implementation still uses OAuth 1.0, which does not support the `state` parameter.
Closes #3501
Tim Düsterhus [Wed, 12 Aug 2020 13:55:02 +0000 (15:55 +0200)]
Clear thumbnail handles as soon as possible
This reproduces when rebuilding attachment thumbnails for largish animated
GIF files using ImageMagick. The ImageMagick on-disk cache quota is not
sufficient to hold:
1) The original
2) The tiny thumbnail
3) The in-progress regular thumbnail
The old value of the `$thumbnail` variable will only be destructed once (3)
returns. But the memory is already needed during execution of (3).
So this commit adjusts the code to `null` out the `$thumbnail` variable as
soon as possible, instead of waiting until it goes out of scope naturally.
Example stack trace from the worker:
ImagickException: cache resources exhausted `/var/www/html/attachments/00/1-*snip*.bin' @ error/cache.c/OpenPixelCache/4083 in /var/www/html/lib/system/image/adapter/ImagickImageAdapter.class.php:132
Stack trace:
#0 /var/www/html/lib/system/image/adapter/ImagickImageAdapter.class.php(132): Imagick->cropthumbnailimage(352, 198)
#1 /var/www/html/lib/system/image/adapter/ImageAdapter.class.php(82): wcf\system\image\adapter\ImagickImageAdapter->createThumbnail(352, 198, 0)
#2 /var/www/html/lib/system/upload/DefaultUploadFileSaveStrategy.class.php(323): wcf\system\image\adapter\ImageAdapter->createThumbnail(352, 198, 0)
#3 /var/www/html/lib/data/attachment/AttachmentAction.class.php(226): wcf\system\upload\DefaultUploadFileSaveStrategy->generateThumbnails(Object(wcf\data\attachment\Attachment))
#4 /var/www/html/lib/data/AbstractDatabaseObjectAction.class.php(204): wcf\data\attachment\AttachmentAction->generateThumbnails()
#5 /var/www/html/lib/system/worker/AttachmentRebuildDataWorker.class.php(48): wcf\data\AbstractDatabaseObjectAction->executeAction()
#6 /var/www/html/lib/system/cli/command/WorkerCLICommand.class.php(152): wcf\system\worker\AttachmentRebuildDataWorker->execute()
#7 /var/www/html/lib/system/CLIWCF.class.php(291): wcf\system\cli\command\WorkerCLICommand->execute(Array)
#8 /var/www/html/lib/system/CLIWCF.class.php(85): wcf\system\CLIWCF->initCommands()
#9 /var/www/html/cli.php(18): wcf\system\CLIWCF->__construct()
#10 {main}
Niklas [Tue, 11 Aug 2020 16:16:41 +0000 (18:16 +0200)]
Add missing phrases to English 3rd party register language items
Joshua Rüsweg [Tue, 11 Aug 2020 09:32:34 +0000 (11:32 +0200)]
Merge pull request #3499 from WoltLab/5.2-like-rebuild-data-fix
Fix calculation the cached reactions
joshuaruesweg [Mon, 10 Aug 2020 16:36:49 +0000 (18:36 +0200)]
Use proper placeholders for fetching the reactions
joshuaruesweg [Mon, 10 Aug 2020 15:57:26 +0000 (17:57 +0200)]
Fix calculation the cached reactions
Tim Düsterhus [Mon, 10 Aug 2020 15:20:05 +0000 (17:20 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Mon, 10 Aug 2020 15:19:21 +0000 (17:19 +0200)]
Merge pull request #3498 from WoltLab/dbo-action-php-8
Fix bogus call to `call_user_func_array` in AbstractDBOAction::validateAction()
Tim Düsterhus [Mon, 10 Aug 2020 14:16:37 +0000 (16:16 +0200)]
Fix bogus call to `call_user_func_array` in AbstractDBOAction::validateAction()
Fixes #3490
Alexander Ebert [Mon, 10 Aug 2020 12:42:17 +0000 (14:42 +0200)]
Merge pull request #3449 from WoltLab/password-security
Better password security estimation
Alexander Ebert [Mon, 10 Aug 2020 12:35:10 +0000 (14:35 +0200)]
Adjusted the bar sizes for the visual password strength
Old: 20/40/60/80/100
New: 5/20/50/85/100
Alexander Ebert [Mon, 10 Aug 2020 11:41:25 +0000 (13:41 +0200)]
Merge pull request #3496 from WoltLab/comment-object-author-cleanup
Add AbstractCommentManager::getObjectID() to DRY up isContentAuthor
Tim Düsterhus [Mon, 10 Aug 2020 10:01:43 +0000 (12:01 +0200)]
Prevent guests from being a comment’s content author
Tim Düsterhus [Mon, 10 Aug 2020 09:32:01 +0000 (11:32 +0200)]
Add AbstractCommentManager::getObjectID() to DRY up isContentAuthor
Tim Düsterhus [Mon, 10 Aug 2020 07:48:49 +0000 (09:48 +0200)]
Merge branch 'master' into password-security
Marcel Werk [Sun, 9 Aug 2020 12:02:34 +0000 (14:02 +0200)]
Skip the menu indicator on mobile if only sub level items have counters
Closes #3164
Alexander Ebert [Fri, 7 Aug 2020 23:21:12 +0000 (01:21 +0200)]
Typo
Marcel Werk [Fri, 7 Aug 2020 20:53:30 +0000 (22:53 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF