Rickard Strandqvist [Sun, 7 Dec 2014 22:28:37 +0000 (23:28 +0100)]
staging: rtl8192e: rtl8192e: rtl_cam.c: Remove unused function
Remove the function CAM_read_entry() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 7 Dec 2014 21:59:07 +0000 (22:59 +0100)]
staging: rtl8188eu: os_dep: usb_ops_linux.c: Remove unused function
Remove the function usb_writeN() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 7 Dec 2014 18:16:15 +0000 (19:16 +0100)]
staging: rtl8188eu: hal: rtl8188e_hal_init.c: Remove unused function
Remove the function GetEEPROMSize8188E() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 7 Dec 2014 17:33:06 +0000 (18:33 +0100)]
staging: rtl8188eu: hal: rtl8188e_cmd.c: Remove unused function
Remove the function rtl8188e_set_rssi_cmd() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mohammad Jamal [Tue, 16 Dec 2014 16:27:44 +0000 (21:57 +0530)]
Staging: rtl8192u : fix space before , coding style issue in r8190_rtl8256.c
This is a patch to r8190_rtl8256.c file that fixes space before , warning found by checkpatch.pl tool
Signed-off-by: Mohammad Jamal<md.jamalmohiuddin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jonathan Jin [Tue, 16 Dec 2014 03:28:23 +0000 (21:28 -0600)]
staging: rtl8192e: rejoin split quoted strings
Fix a checkpatch.pl warning regarding quoted string splits across lines.
While each join of these quoted strings results in a new checkpatch.pl
"lines over 80 characters" warning, the regained ability to grep for
these log strings in the codebase is, I would argue, well worth the
trade-off.
Signed-off-by: Jonathan Jin <jjin082693@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gangadhar Vukkesala [Sat, 20 Dec 2014 15:59:47 +0000 (21:29 +0530)]
staging: rtl8188eu: Fixed a space coding style issue.
Fixed a space coding style issue which was found when running checkpatch.pl
script on rtw_ap.c.
Signed-off-by: Gangadhar Vukkesala <gangs.freelancer@gmail.com>
Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abel Moyo [Thu, 4 Dec 2014 13:13:21 +0000 (14:13 +0100)]
Staging: rtl8188eu: {core, hal, include}: Removed inline function
Removed inline function get_my_bssid and open coded all its references
Signed-off-by: Abel Moyo <abelmoyo.ab@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Tulia [Wed, 24 Dec 2014 06:15:09 +0000 (09:15 +0300)]
staging: rtl8723au: fix sparse warning
drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol
'rtw_ack_tx_done23a' was not declared. Should it be static?
Function 'rtw_ack_tx_done23a' seems to be unused in current staging
code.
Signed-off-by: Alexey Tulia <alexey.tulia@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sat, 20 Dec 2014 16:44:10 +0000 (17:44 +0100)]
staging: rtl8723au: hal: odm.c: Remove some unused functions
Removes some functions that are not used anywhere:
odm_1R_CCA23a() odm_TXPowerTrackingCheckAP() odm_TXPowerTrackingCheckMP()
odm_RSSIMonitorCheck23aAP() odm_RSSIMonitorCheck23aMP() odm_RSSIMonitorInit()
odm_RefreshRateAdaptiveMask23aAPADSL23a() odm_RefreshRateAdaptiveMask23aMP23a()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joe Borg [Tue, 16 Dec 2014 07:54:32 +0000 (02:54 -0500)]
Staging: rtl8723au: core: rtw_ap: checkpatch.pl fixes
Fixing styling errors found with checkpatch.pl. These include:
"(foo*)" should be "(foo *)"
space required after that ';'
...totalling 5 styling errors.
Signed-off-by: Joe Borg <joe@josephb.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yannis Damigos [Sat, 20 Dec 2014 16:47:27 +0000 (18:47 +0200)]
staging: rtl8723au: Fix sparse invalid assignment warnings
This is a patch to the hal/rtl8723au_xmit.c file that fixes the
following warnings found by sparse tool:
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: warning: invalid assignment: |=
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: left side has type unsigned int
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: right side has type restricted __le32
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: expected unsigned int [usertype] *pdw
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: got restricted __le32 *<noident>
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: expected unsigned int [usertype] *pdw
drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: got restricted __le32 *<noident>
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Asaf Vertz [Tue, 16 Dec 2014 13:57:58 +0000 (15:57 +0200)]
staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"
Fixed a coding style error, "foo * bar" should be "foo *bar"
Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Krzysztof Konopko [Mon, 15 Dec 2014 15:02:14 +0000 (16:02 +0100)]
staging: rtl8723au: Fix sparse warnings
Some struct fields in wifi.h are meant to be __le16 but were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c:538:24: warning: cast to restricted __le16
rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
rtw_wlan_util.c:1546:25: warning: cast to restricted __le16
This patch updates the types of the fields in `AC_param` and
`ADDBA_request` structs to be consistent with relevant structs in
include/linux/ieee80211.h.
Signed-off-by: Krzysztof Konopko <kris@konagma.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dean Michael Ancajas [Mon, 8 Dec 2014 20:55:21 +0000 (13:55 -0700)]
Staging: rtl8723au: os_dep: Fixed a coding style issue.
Fixed a coding style issue for braces.
Signed-off-by: Dean Michael Ancajas <dbancajas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjana Sasindran [Fri, 5 Dec 2014 15:47:02 +0000 (21:17 +0530)]
staging: rtl8723au: hal: Removed a space before semicolon
This patch fix the checkpatch.pl warning:
WARNING: space before semicolon prohibited
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjana Sasindran [Thu, 4 Dec 2014 13:50:30 +0000 (19:20 +0530)]
staging: rtl8723au: hal: Removed space before semicolon
This patch fix the checkpatch.pl warning:
WARNING: spaces prohibited before semicolon
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjana Sasindran [Thu, 4 Dec 2014 12:41:13 +0000 (18:11 +0530)]
staging: rtl8723au: hal: Added blank line after declaration
This patch fix the checkpatch.pl warning:
WARNING: Missing blank line after declaration
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Donald [Thu, 4 Dec 2014 02:19:59 +0000 (20:19 -0600)]
drivers: staging: rtl8723au: Fix "'foo * bar' should be 'foo *bar'" errors
Fix checkpatch.pl "'foo * bar' should be 'foo *bar'" errors
Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:54 +0000 (16:15 -0500)]
staging: rtl8723au: Hal8723PwrSeq.h: Use BIT() define to match mask value
This is a no-op change, but it improves consistency.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:53 +0000 (16:15 -0500)]
staging: rtl8723au: Hal8723PwrSeq.h: Remove SDIO specific entries
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:52 +0000 (16:15 -0500)]
staging: rtl8723au: Hal8723PwrSeq.h: Remove PCI specific entries from the power sequence tables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:51 +0000 (16:15 -0500)]
staging: rtl8723au: HalPwrSeqCmdParsing23a(): Avoid unnecessary variable inits
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:50 +0000 (16:15 -0500)]
staging: rtl8723au: Hal8723APhyCfg.h: Remove more unused #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:49 +0000 (16:15 -0500)]
staging: rtl8723au: There is no 11N pseudo PHY here
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:48 +0000 (16:15 -0500)]
staging: rtl8723au: Baseband is always configured through PHY regs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:47 +0000 (16:15 -0500)]
staging: rtl8723au: Hal8723APhyCfg.h: Remove some undefined structs and enums
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:46 +0000 (16:15 -0500)]
staging: rtl8723au: Use enum for counter and avoid ugly typecast
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:45 +0000 (16:15 -0500)]
staging: rtl8723au: Use proper enum defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:44 +0000 (16:15 -0500)]
staging: rtl8723au: Use correct register names to set parameters to reduce 80M spur
Use the correct register names when setting parameters to reduce 80M
spur. In addition apply updated 80M spur reduction parameters.
Original patch supplied by Andrew Chang <andrew.chang@realtek.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Thu, 4 Dec 2014 21:15:43 +0000 (16:15 -0500)]
staging: rtl8723au: usb_dvobj_init(): A NULL pointer check for usb_host_endpoints makes no sense
struct usb_host_interface points to an array of
struct usb_host_endpoints - it makes no sense to do a NULL pointer
check for each pointer.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjana Sasindran [Wed, 3 Dec 2014 16:12:09 +0000 (21:42 +0530)]
staging: rtl8723au: hal: Removed spaces before semicolon
This patch fix the checkpatch.pl warning:
WARNING: space prohibited before semicolon
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul Hedman [Wed, 3 Dec 2014 02:34:13 +0000 (20:34 -0600)]
Staging: rtl8712: Fixes brace coding style in rtl871x_sta_mgt.c
This patch fixes a brace warning in rtl871x_sta_mgt.c found
by the checkpatch.pl tool.
Signed-off-by: Paul Hedman <paul@mybb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Emrys Bayliss [Mon, 12 Jan 2015 16:51:36 +0000 (03:51 +1100)]
Staging: vt6656: Checkpatch fix: else after break or return
This patch fixes the following checkpatch.pl error:
rxtx.c:588: WARNING: else is not generally useful after a break or return
Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gustavo A. R. Silva [Sun, 11 Jan 2015 22:46:45 +0000 (16:46 -0600)]
Staging: vt6656: Fixed typo in a variable name
Fixed typo in a variable name in dpc.h file.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gustavo A. R. Silva [Sun, 11 Jan 2015 22:35:54 +0000 (16:35 -0600)]
Staging: vt6656: Fixed typo in a macro name
Fixed typo in a macro name in card.c and device.h files.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gustavo A. R. Silva [Sun, 11 Jan 2015 22:18:00 +0000 (16:18 -0600)]
Staging: vt6655: Fixed a typo
Fixed a typo in mac.c file.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 11 Jan 2015 10:26:12 +0000 (10:26 +0000)]
staging: vt6655: [BUG] Protect MACvSelectPage1 with lock.
The device must not flip to page 1 while in interrupt lock causing
loss of connection or dead lock.
Protect from changes to page by adding lock where user can
change the page in CARDvSetRSPINF, vnt_configure and set_channel
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Piotr Kubus [Sat, 10 Jan 2015 14:35:45 +0000 (15:35 +0100)]
Staging: vt6655: fix a space coding style issue
Fixed a space coding style issue found by checkpatch.pl in rxtx.c.
Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sakshi Bansal [Thu, 8 Jan 2015 16:37:41 +0000 (22:07 +0530)]
Staging: vt6655: baseband.c: fixed line over 80 characters
Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicholas Parkanyi [Tue, 30 Dec 2014 09:57:44 +0000 (04:57 -0500)]
staging: vt6655: Replace C99 comments in power.c and upc.h.
This patch fixes the following checkpatch.pl warnings:
ERROR: do not use C99 // comments
+//
ERROR: do not use C99 // comments
+// For memory mapped IO
ERROR: do not use C99 // comments
+//
ERROR: do not use C99 // comments
+#endif // __UPC_H__
ERROR: do not use C99 // comments
+ // set period of power up before TBTT
ERROR: do not use C99 // comments
+ // set AID
ERROR: do not use C99 // comments
+ // set ATIM Window
ERROR: do not use C99 // comments
+ // Set AutoSleep
ERROR: do not use C99 // comments
+ // Set HWUTSF
ERROR: do not use C99 // comments
+ // clear always listen beacon
ERROR: do not use C99 // comments
+ // first time set listen next beacon
ERROR: do not use C99 // comments
+ // always listen beacon
ERROR: do not use C99 // comments
+ // enable power saving hw function
ERROR: do not use C99 // comments
+ // disable power saving hw function
ERROR: do not use C99 // comments
+ //clear AutoSleep
ERROR: do not use C99 // comments
+ //clear HWUTSF
ERROR: do not use C99 // comments
+ // set always listen beacon
Signed-off-by: Nicholas Parkanyi <n.parkanyi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Krzysztof Adamski [Wed, 10 Dec 2014 17:05:31 +0000 (18:05 +0100)]
staging: vt6656: whitespace checkpatch warning fix.
This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Krzysztof Adamski <k@japko.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fred Chou [Wed, 10 Dec 2014 05:50:16 +0000 (13:50 +0800)]
staging: vt6655: remove unused function in mac.c
Removed the unused function MACvGetShortRetryLimit, which also
fixed the following sparse warning:
drivers/staging/vt6655/mac.c:162:6: warning:
symbol 'MACvGetShortRetryLimit' was not declared. Should it be static?
Signed-off-by: Fred Chou <fred.chou.nd@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Krzysztof Adamski [Tue, 9 Dec 2014 11:01:38 +0000 (12:01 +0100)]
staging: vt6656: Use ether_addr_copy() on vnt_private members.
This patch fixes checkpatch.pl warning:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)
current_net_addr and permanent_net_addr members of vnt_private alignment
is changed to at last 16 bits so that ether_addr_copy can be safely used
on them.
buf->data is of type ieee80211_cts which is already properly aligned.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Krzysztof Adamski [Mon, 8 Dec 2014 11:13:41 +0000 (12:13 +0100)]
staging: vt6656: Use ether_addr_copy() in vnt_fill_ieee80211_rts.
Both struct ieee80211_rts and struct ieee80211_hdr defined in
linux/ieee80211.h are declared as __aligned(2) so it is safe to use
ether_addr_copy() instead of memcpy().
Signed-off-by: Krzysztof Adamski <k@japko.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sören Brinkmann [Fri, 5 Dec 2014 04:33:41 +0000 (20:33 -0800)]
staging: vt6655: Declare vnt_init() static
Fix sparse warning:
drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static?
Signed-off-by: Sören Brinkmann <soeren.brinkmann@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mariusz Gorski [Fri, 5 Dec 2014 21:28:19 +0000 (22:28 +0100)]
staging: panel: Remove magic numbers in LCD commands
Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.
Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mariusz Gorski [Wed, 3 Dec 2014 18:53:47 +0000 (19:53 +0100)]
staging: panel: Remove unused variable
Remove lcd.left_shift because it is only written to at some places but
never read from.
Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Syed Amer Gilani [Sat, 27 Dec 2014 20:57:43 +0000 (21:57 +0100)]
staging: unisys: fix checkpatch space prohibited before comma errors
Fixes checkpatch Error:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Syed Amer Gilani <syed.amer@gilani.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sat, 27 Dec 2014 22:04:14 +0000 (23:04 +0100)]
staging: unisys: uislib: uisutils.c: Fix a missing va_end
A missing va_end in connection with vsnprintf
Was found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 14 Dec 2014 23:08:37 +0000 (00:08 +0100)]
staging: unisys: virtpci: virtpci.c: Removes unnecessary NULL check
It is impossible for dprivate to ever be NULL, no check required.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rasmus Villemoes [Fri, 12 Dec 2014 10:51:27 +0000 (11:51 +0100)]
staging: unisys: remove leftover __DATE__
Commit
836bee9eee6d ("Staging: unisys: remove references to __DATE__
and __TIME__") removed most; this seems to be an accidental
leftover. VERSIONDATE is not used anywhere.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan Thompson [Fri, 5 Dec 2014 22:09:25 +0000 (17:09 -0500)]
staging: unisys: Remove VISORCHANNEL typedef
Remove the VISORCHANNEL typedef and rename the base VISORCHANNEL_Tag
structure to visorchannel to follow consistent naming. The longer
struct visorchannel type required additional line wrapping to remain
less than 81 characters.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan Thompson [Fri, 5 Dec 2014 22:09:24 +0000 (17:09 -0500)]
staging: unisys: visorchannel: Describe spinlocks in VISORCHANNEL_Tag struct
Add comments indicating the requirements and use of the insert_lock and
remove_lock in the VISORCHANNEL_Tag structure.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan Thompson [Fri, 5 Dec 2014 22:09:23 +0000 (17:09 -0500)]
staging: unisys: visorchannel: Rename CamelCase variable nQueues
Rename the visorchannel_debug parameter nQueues to num_queues.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan Thompson [Fri, 5 Dec 2014 22:09:22 +0000 (17:09 -0500)]
staging: unisys: visorchannel: Rename CamelCase variable channelBytes
Rename channelBytes to channel_bytes in the series of visorchannel_create
functions provided by visorchannel.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:21 +0000 (17:09 -0500)]
staging: unisys: get rid of goto in visorchipset_ioctl()
Remove another completely unnecessary goto and just return the values
directly.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:20 +0000 (17:09 -0500)]
staging: unisys: fix CamelCase in visorchipset_mmap()
Fix CamelCase name:
physAddr => physaddr
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:19 +0000 (17:09 -0500)]
staging: unisys: get rid of goto in visorchipset_open()
This goto uses CamelCase and was completely unnecessary.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:18 +0000 (17:09 -0500)]
staging: unisys: get rid of HAVE_UNLOCKED_IOCTL code
We definitely have it, so there's no point in keeping the older stuff
around. Get rid of the #ifdefs and old code.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:17 +0000 (17:09 -0500)]
staging: unisys: fix CamelCase global variables in file.c
Fix CamelCase names:
Cdev => file_cdev
PControlVm_channel => file_controlvm_channel
MajorDev => majordev
Registered => registered
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:16 +0000 (17:09 -0500)]
staging: unisys: refactor visorchipset_file_init()
Fix the declaration so it is a single line. Fix CamelCase parameter
names:
MajorDev => major_dev
pControlVm_channel => controlvm_channel
Remove the unnecessary gotos and just return directly in error cases.
Fix the last error condition so it returns the result of cdev_add()
instead of always zero.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:15 +0000 (17:09 -0500)]
staging: unisys: refactor req_handler_add()
Fix the CamelCase parameter names:
Server_Channel_Ok => server_channel_ok
Server_Channel_Init => server_channel_init
clientStr => clientstr
clientStrLen => clientstr_len
And remove the extra parenthesis in the list_add_tail() call at the end.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:14 +0000 (17:09 -0500)]
staging: unisys: fix CamelCase globals in uisutils.c
Rename CamelCase global variable names:
ReqHandlerInfo_list => req_handler_info_list
ReqHandlerInfo_list_lock => req_handler_info_list_lock
Update all references to use the new name.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:13 +0000 (17:09 -0500)]
staging: unisys: refactor uisctrl_unregister_req_handler_ex()
Get rid of the unnecessary goto statement and just return directly.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:12 +0000 (17:09 -0500)]
staging: unisys: refactor uisctrl_register_req_handler_ex()
Fix CamelCase local variable name:
pReqHandlerInfo => req_handler
Get rid of the useless goto and just return straight away on an error.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:11 +0000 (17:09 -0500)]
staging: unisys: fix brackets in uisctrl_register_req_handler_ex()
Add the missing brackets to the last if statement in this function.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:10 +0000 (17:09 -0500)]
staging: unisys: fix spacing in uisutils.c
Fix as many spacing problems as possible by indenting lines properly and
getting rid of spaces between typecasts and their targets.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:09 +0000 (17:09 -0500)]
staging: unisys: fix line spacing in uisutils.c
Just remove the couple of extra blank lines.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:08 +0000 (17:09 -0500)]
staging: unisys: fix line spacing in uisthread.c
Just remove the one extra blank line.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:07 +0000 (17:09 -0500)]
staging: unisys: fix CamelCase names in do_locked_client_insert()
Fix CamelCase names:
pSignal => signal
Remove unused parameters issueInterruptIfEmpty and interruptHandle, and update
callers of this function.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:06 +0000 (17:09 -0500)]
staging: unisys: fix spacing in uisqueue.c
Correct alignment for a couple of functions and remove the space between
a typecast and its target.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:05 +0000 (17:09 -0500)]
staging: unisys: fix CamelCase Work queue name in uislib.c
Fix CamelCase name:
Work_wakeup_polling_device_channels => work_wakeup_polling_device_channels
Update references to use the new name.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:04 +0000 (17:09 -0500)]
staging: unisys: rename Initialize_incoming_thread()
Fix the CamelCase name of this function:
Initialize_incoming_thread => initialize_incoming_thread
Update all references to use the new name.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:03 +0000 (17:09 -0500)]
staging: unisys: rename Process_Incoming()
Fix the CamelCase function name:
Process_Incoming => process_incoming
Update all references to use the new name.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:02 +0000 (17:09 -0500)]
staging: unisys: refactor find_dev()
Fix the function definition so that it is a single line. Fix CamelCase
parameter names:
busNo => bus_no
devNo => dev_no
Get rid of the goto and just break out of the for loop, since that does
the exact same thing.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:01 +0000 (17:09 -0500)]
staging: unisys: refactor info_debugfs_read()
Fix the function declaration so the type is on the same line as the name,
and fix the CamelCase local variable name:
TotalBytes => total_bytes
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:09:00 +0000 (17:09 -0500)]
staging: unisys: refactor delete_device_glue()
Fix the function declaration so it is a single line, and fix CamelCase
function parameter names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:59 +0000 (17:08 -0500)]
staging: unisys: refactor delete_bus_glue()
Fix the function declaration to be a single line, and rename the CamelCase
parameter:
busNo => bus_no
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:58 +0000 (17:08 -0500)]
staging: unisys: refactor destroy_device()
Fix the function declaration so it is a single line. Rename CamelCase local
variable names:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp(). Fix
spelling error DESTORY to correctly read DESTROY.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:57 +0000 (17:08 -0500)]
staging: unisys: refactor resume_device()
Fix the function declaration so it is a single line. Fix CamelCase local
variable names:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp().
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:56 +0000 (17:08 -0500)]
staging: unisys: refactor pause_device()
Fix the function declaration so it is on a single line. Fix CamelCase local
variables:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp().
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:55 +0000 (17:08 -0500)]
staging: unisys: refactor create_device()
OK, lets clean up this messy function. The entire thing is reflowed so spacing
and indentation is correct. Tests that created extra indentation were swapped
for equivalent negative tests that did not create extra indentation. Use of
cmp_uuid_le() were fixed to test specifically for the zero case, and not to
lazily use !cmp_uuid_le(). CamelCase local variable names were fixed:
busNo => bus_no
devNo => dev_no
minSize => min_size
pReqHandler => req_handler
Away => cleanup
Finally, the struct guest_msgs cmd declaration was moved to the beginning of
the function, and cringing and wincing at the function was significantly
reduced.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:54 +0000 (17:08 -0500)]
staging: unisys: fix CamelCase in destroy_bus()
Fix the CamelCase local variable:
busNo => bus_no
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:53 +0000 (17:08 -0500)]
staging: unisys: fix CamelCase in create_bus()
Fix CamelCase local variable names:
busNo => bus_no
deviceCount => dev_count
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:52 +0000 (17:08 -0500)]
staging: unisys: refactor init_vbus_channel()
Clean up the function definition so it's a single line. Remove the unnecessary
goto statements and just return directly. Remove the unneeded local variable
for the return result. Fix CamelCase parameters and local variable names:
channelAddr => ch_addr
channelBytes => ch_bytes
pChan => ch
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:51 +0000 (17:08 -0500)]
staging: unisys: fix CamelCase global variable names in uislib.c
Fix CamelCase names:
ProcReadBufferValid => debug_buf_valid
ProcReadBuffer => debug_buf
BusListHead => bus_list
BusListLock => bus_list_lock
BusListCount => bus_list_count
MaxBusCount => max_bus_count
PhysicalDataChan => phys_data_chan
PlatformNumber => platform_no
Incoming_ThreadInfo => incoming_ti
Incoming_Thread_Started => incoming_started
List_Polling_Device_Channels => poll_dev_chan
Lock_Polling_Device_Channels => poll_dev_lock
Wakeup_Polling_Device_Channels => poll_dev_wake_q
Go_Polling_Device_Channels => poll_dev_start
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:50 +0000 (17:08 -0500)]
staging: unisys: get rid of doubled assignment in uislib_mod_init()
Split the doubled assignment in uislib_mod_init() into two separate assignments.
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:49 +0000 (17:08 -0500)]
staging: unisys: remove extra parens from uislib_enable_channel_interrupts()
Get rid of the extra parenthesis in uislib_enable_channel_interrupts().
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:48 +0000 (17:08 -0500)]
staging: unisys: add missing brackets in Process_Incoming()
Fix the brackets in the else clause in Process_Incoming().
Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:47 +0000 (17:08 -0500)]
staging: unisys: add missing brackets in info_debugfs_read()
The if statement in info_debugfs_read() needs another set of brackets for the
else clause.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:46 +0000 (17:08 -0500)]
staging: unisys: remove extraneous blank lines in uislib.c
Fix the line spacing errors in uislib.c.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:45 +0000 (17:08 -0500)]
staging: unisys: fix strict checks in create_device()
Use the variable name rather than the type, and add a set of missing brackets
to the if statement in create_device().
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:44 +0000 (17:08 -0500)]
staging: unisys: refactor create_bus()
Fix the missing braces and logical continuation problems in create_bus().
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:43 +0000 (17:08 -0500)]
staging: unisys: fix alignment in uislib.c
Fix almost all of the parenthesis alignment problems in uislib.c. The 2
remaining issues are in create_device(), which is heavily indented and needs
to be refactored entirely anyway.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:42 +0000 (17:08 -0500)]
staging: unisys: clean up typecasts in uislib.c
Remove all extraneous spaces from typecasts in uislib.c.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:41 +0000 (17:08 -0500)]
staging: unisys: add comment to spinlock in struct charqueue
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:40 +0000 (17:08 -0500)]
staging: unisys: remove unused types from visorchipset.h
Delete the following unused types, and unused function prototypes:
VISORCHIPSET_SWITCH_INFO
VISORCHIPSET_EXTERNALPORT_INFO
VISORCHIPSET_INTERNALPORT_INFO
visorchipset_get_switch_info()
visorchipset_get_externalport_info()
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:39 +0000 (17:08 -0500)]
staging: unisys: get rid of channel stub
The functions in channels/* aren't used in a lot of places. In fact, the
functions in channel.c can be moved to uislib/uisqueue.c, and the rest
of the files in channels can be eliminated.
This patch deletes the channels directory and files, removes it from all
Kconfigs that referenced them, removes the reference in the Makefile,
and moves the functions inside of channels.c to uislib/uisqueue.c.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Fri, 5 Dec 2014 22:08:38 +0000 (17:08 -0500)]
staging: unisys: remove testing.h
Nobody is using this file so remove it and the reference to it in
visorchipset_main.c.
Signed-off-by: Ken Depro <kenneth.depro@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / log