Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:07 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_tx_timeout
Use naming schema found in other rtlwifi devices.
Rename rtl8192_tx_timeout to _rtl92e_tx_timeout.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:06 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_tx_isr
Use naming schema found in other rtlwifi devices.
Rename rtl8192_tx_isr to _rtl92e_tx_isr.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:05 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_tx_cmd
Use naming schema found in other rtlwifi devices.
Rename rtl8192_tx_cmd to _rtl92e_tx_cmd.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:04 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_tx
Use naming schema found in other rtlwifi devices.
Rename rtl8192_tx to _rtl92e_tx.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:03 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_free_tx_ring
Use naming schema found in other rtlwifi devices.
Rename rtl8192_free_tx_ring to _rtl92e_free_tx_ring.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:02 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_free_rx_ring
Use naming schema found in other rtlwifi devices.
Rename rtl8192_free_rx_ring to _rtl92e_free_rx_ring.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:01 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_alloc_tx_desc_ring
Use naming schema found in other rtlwifi devices.
Rename rtl8192_alloc_tx_desc_ring to _rtl92e_alloc_tx_ring.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:13:00 +0000 (10:13 +0200)]
staging: rtl8192e: Rename rtl8192_alloc_rx_desc_ring
Use naming schema found in other rtlwifi devices.
Rename rtl8192_alloc_rx_desc_ring to _rtl92e_alloc_rx_ring.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:59 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_pci_probe
Use naming schema found in other rtlwifi devices.
Rename rtl8192_pci_probe to _rtl92e_pci_probe.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:58 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_pci_module_init
Use naming schema found in other rtlwifi devices.
Rename rtl8192_pci_module_init to _rtl92e_pci_module_init.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:57 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_pci_module_exit
Use naming schema found in other rtlwifi devices.
Rename rtl8192_pci_module_exit to _rtl92e_pci_module_exit.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:56 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_pci_initdescring
Use naming schema found in other rtlwifi devices.
Rename rtl8192_pci_initdescring to _rtl92e_pci_initdescring.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:55 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_pci_disconnect
Use naming schema found in other rtlwifi devices.
Rename rtl8192_pci_disconnect to _rtl92e_pci_disconnect.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:54 +0000 (10:12 +0200)]
staging: rtl8192e: Rename _rtl8192_up
Use naming schema found in other rtlwifi devices.
Rename _rtl8192_up to _rtl92e_up.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:53 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_up
Use naming schema found in other rtlwifi devices.
Rename rtl8192_up to _rtl92e_try_up.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:52 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_restart
Use naming schema found in other rtlwifi devices.
Rename rtl8192_restart to _rtl92e_restart.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:51 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_down
Use naming schema found in other rtlwifi devices.
Rename rtl8192_down to _rtl92e_down.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:50 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_close
Use naming schema found in other rtlwifi devices.
Rename rtl8192_close to _rtl92e_close.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:49 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_open
Use naming schema found in other rtlwifi devices.
Rename rtl8192_open to _rtl92e_open.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:12:48 +0000 (10:12 +0200)]
staging: rtl8192e: Rename rtl8192_ioctl
Use naming schema found in other rtlwifi devices.
Rename rtl8192_ioctl to _rtl92e_ioctl.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:30 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_irq_tx_tasklet
Use naming schema found in other rtlwifi devices.
Rename rtl8192_irq_tx_tasklet to _rtl92e_irq_tx_tasklet.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:29 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_irq_rx_tasklet
Use naming schema found in other rtlwifi devices.
Rename rtl8192_irq_rx_tasklet to _rtl92e_irq_rx_tasklet.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:28 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_interrupt
Use naming schema found in other rtlwifi devices.
Rename rtl8192_interrupt to _rtl92e_irq.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:27 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init_priv_variable
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init_priv_variable to _rtl92e_init_priv_variable.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:26 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init_priv_task
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init_priv_task to _rtl92e_init_priv_task.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:25 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init_priv_lock
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init_priv_lock to _rtl92e_init_priv_lock.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:24 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init_priv_handler
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init_priv_handler to _rtl92e_init_priv_handler.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:23 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init_priv_constant
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init_priv_constant to _rtl92e_init_priv_constant.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mateusz Kulikowski [Sun, 20 Sep 2015 08:09:22 +0000 (10:09 +0200)]
staging: rtl8192e: Rename rtl8192_init
Use naming schema found in other rtlwifi devices.
Rename rtl8192_init to _rtl92e_init.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:12 +0000 (17:52 -0700)]
staging: comedi: rtd520: hook up 8254 timer/counter subdevice
There is a standard 8254 Timer/Counter device on the board. Hook up
the subdevice for the user.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:11 +0000 (17:52 -0700)]
staging: comedi: rtd520: use DIV_ROUND_CLOSEST and DIV_ROUND_UP macros
Use the macros to clarify the divisor calculations.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:10 +0000 (17:52 -0700)]
staging: comedi: rtd520: tidy up block comments
Use the preferred block command style.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:09 +0000 (17:52 -0700)]
staging: comedi: rtd520: remove unnecessary function desc. block comments
These function description comments are cut-and-paste cruft from the
old skeleton driver. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:08 +0000 (17:52 -0700)]
staging: comedi: rtd520: fix rtd_ao_winsn()
The "comedi range and offset conversions" in this function is
incorrect. According to the hardware manual, the DAC registers
are defined as:
| D15 | D14-D03 | D02 | | D01 | D00 |
| Sign | 12-bit data | (see manual) |
The extended 'Sign' bit is only used for bipolar ranges to indicate
negative 12-bit data values.
The current code actually flips the sign for all bipolar data
values instead of just munging the value to 2's complement and
extending the sign bit.
Fix the function to correctly munge the comedi offset binary
values into 2's complement and extended the sign when bipolar
ranges are specified.
For aesthetics, rename this function and tidy it up a bit.
Save the readback value after the conversion is complete.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:07 +0000 (17:52 -0700)]
staging: comedi: rtd520: convert DAC register defines to macros
For aesthetics, convert the defines for the various DAC registers into
macros that take the comedi channel and return the correct offset.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:06 +0000 (17:52 -0700)]
staging: comedi: rtd520: remove unnecessary comments from rtd_ao_winsn()
These comments are cut-and-paste from the old skeleton driver. Remove
them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:05 +0000 (17:52 -0700)]
staging: comedi: rtd520: move constants to right side of comparisons
Fix the checkpatch.pl issues about:
WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:04 +0000 (17:52 -0700)]
staging: comedi: rtd520: rename rtd520Boards
For aesthetics, rename this CamelCase array.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:03 +0000 (17:52 -0700)]
staging: comedi: rtd529: usleep_range is preferred over udelay
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt". `udelay()` is only used in the
firmware upload process. Replace them with `usleep_range()` with a
reasonable upper limit.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:02 +0000 (17:52 -0700)]
staging: comedi: rtd520: fix logical continuations
Fix the checkpatch.pl issues about:
CHECK: Logical continuations should be on the previous line
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 25 Sep 2015 00:52:01 +0000 (17:52 -0700)]
staging: comedi: rtd520: prefer using the BIT macro
Use the BIT macro to define the register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 23 Sep 2015 18:35:56 +0000 (19:35 +0100)]
staging: comedi: comedi_pci.c: improve function documentation
Expand the descriptions of the functions and document the return values.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Wed, 23 Sep 2015 17:43:37 +0000 (10:43 -0700)]
staging: comedi: rti800: use comedi_offset_munge()
Use the comedi_offset_munge() helper to do the two's complement
to comedi offset binary and comedi offset binary to two's complement
conversions.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Wed, 23 Sep 2015 17:43:36 +0000 (10:43 -0700)]
staging: comedi: rti800: prefer using the BIT macro
Use the BIT macro to define the register bits.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Wed, 23 Sep 2015 15:33:27 +0000 (16:33 +0100)]
staging: comedi: comedi_fops.c: Tweak kernel-doc for consistency
Adjust the kernel-doc in this file for consistency of capitalization and
punctuation. Make more use of the special kernel-doc markers for
parameter names, constant names, etc. Use the correct kernel-doc tag
for the return values sections.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 22 Sep 2015 17:02:39 +0000 (18:02 +0100)]
staging: comedi: comedi_buf.c: document remaining exported functions
Add kernel-doc headers to the remaining functions marked for export.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 22 Sep 2015 17:02:38 +0000 (18:02 +0100)]
staging: comedi: comedi_buf.c: tweak existing kernel-doc
Expand the kernel-doc descriptions of those exported functions that
already have kernel-doc comments.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:56 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document remaining inline functions
Add kernel-doc headers to the inline functions that do not have them
yet.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:55 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: tweak docs for inline functions
Tweak the kernel-doc for already documented inline functions for
consistency, and document their return values.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:54 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: tweak struct comedi_async documentation
Make the kernel-doc layout for `struct comedi_async` more consistent
with the documentation for the other COMEDI data types.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:53 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document struct comedi_lrange
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:52 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document struct comedi_buf_map
Add kernel-doc for `struct comedi_buf_map` and the associated `struct
comedi_buf_page`.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:51 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document struct comedi_subdevice
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:50 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document struct comedi_device
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:49 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: document struct comedi_driver
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:48 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: tweak kernel-doc for struct comedi_async
Tweak the formatting of the kernel-doc formatted comment for `struct
comedi_async` in order to stop it generating bogus headings for text
before a colon.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:47 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: use enum for COMEDI_CB_... constants
The existing constants `COMEDI_CB_EOS` etc. are in the form of macros
and have a bogus kernel-doc comment. Change them to `enum` constants so
they can be documented properly with kernel-doc.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Mon, 21 Sep 2015 17:52:46 +0000 (18:52 +0100)]
staging: comedi: comedidev.h: reformat copyright comment
Use the preferred block comment style.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Thu, 17 Sep 2015 16:19:17 +0000 (17:19 +0100)]
staging: comedi: drivers.c: document exported functions
Add missing kernel-doc to the low-level COMEDI driver API functions
exported from "drivers.c" and tart up some of the existing kernel-doc
comments for consistency.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Thu, 17 Sep 2015 16:19:16 +0000 (17:19 +0100)]
staging: comedi: drivers.c: replace #include <linux/dma-mapping.h>
Comedi's "drivers.c" doesn't use anything from `<linux/dma-mapping.h>`,
but it does use `DMA_NONE` from `<linux/dma-direction.h>`, so replace
the appropriate `#include` directive.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Thu, 17 Sep 2015 16:19:15 +0000 (17:19 +0100)]
staging: comedi: drivers.c: remove irrelevant #includes
Comedi's "drivers.c" doesn't use anything from these included headers,
so remove them.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:58 +0000 (17:18 +0200)]
staging: most: fix pcm_write input/output error
This patch keeps the process from sleeping after the PCM middle layer has
stopped playback by calling the pcm trigger callback. The patch is needed
to prevent aplay from causing a pcm_write Input/Output error.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:57 +0000 (17:18 +0200)]
staging: most: add poll syscall to AIM cdev
This patch adds the implementation of the poll syscall to the AIM cdev.
To have the full functionality, a helper function is needed in the
core module to retrieve the instantaneous availability of tx buffers.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:56 +0000 (17:18 +0200)]
staging: most: remove audio resolution format check
This patch removes the audio format cross-check, because the definitions
are not compatible.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:55 +0000 (17:18 +0200)]
staging: most: fix style problems
This patch simply corrects style violations.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:54 +0000 (17:18 +0200)]
staging: most: move initialization code
This pathch moves the initialization of the PCM middle layer hardware
parameters to function audio_set_hw_params().
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:53 +0000 (17:18 +0200)]
staging: most: rename function
This patch renames the function audio_set_pcm_format(). Since the
function doesn't only set the PCM format anymore and to guard against
misunderstandings, its name needs to be changed.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:52 +0000 (17:18 +0200)]
staging: most: add missing channel initialization
This patch adds missing initialization of channel count for 8-bit mono
audio resolution.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:51 +0000 (17:18 +0200)]
staging: most: purge unecessary variable
This patch purges a temp. variable to store the functions return value.
Since the content is never being evaluated, it can safely be removed.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:50 +0000 (17:18 +0200)]
staging: most: squash AIM sound
This patch removes debug messages and prevents the sound AIM from being
noisy in kernel log.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:49 +0000 (17:18 +0200)]
staging: most: make hardware parameters channel exclusive
Since the PCM interface's hardware parameters are channel/substream
exclusive, the struct snd_pcm_hardware needs to be embedded in the
channel structure.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:48 +0000 (17:18 +0200)]
staging: most: include vendor in audio card's shortname
This patch adds Microchip as vendor to the audio card's shortname to
be displayed, when playback and capture devices are queried.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:47 +0000 (17:18 +0200)]
staging: most: add multi channel support to sound AIM
This patch adds 5.1 surround configuration with subbuffer cross-check,
when establishing a link to the core. For the sake of simplicity, only
one specific channel configuration is allowed.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:46 +0000 (17:18 +0200)]
staging: most: refactor channel structure
The struct most_c_obj has the same set of attributes for each of two AIMs.
This patch cleans up the code by introducing the new struct most_c_aim_obj
hat contains those fields.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:45 +0000 (17:18 +0200)]
staging: most: add fair buffer distribution
This patch ensures a fair distribution of buffers, when two AIMs share a
single channel. The AIMs then won't be able to use more than half of all
pre-allocated buffers of the linked channel. However, in case the channel
is not shared, the AIM can exclusively use all available buffers.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:44 +0000 (17:18 +0200)]
staging: most: consolidate code
The function drci_rd_reg() always delivers little endian representation of
the 16-bit DCI register. The value returned by this function must always be
carefully converted from __le16 to u16 type. This patch moves all those
conversions to the function itself.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:43 +0000 (17:18 +0200)]
staging: most: prevent DMA on stack
This patch is needed to avoid having DMA on the stack.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:42 +0000 (17:18 +0200)]
staging: most: simplify code
This patch simply rearranges code for better readability.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:41 +0000 (17:18 +0200)]
staging: most: fix MAC address representation
This patch fixes the representation of the MAC address within the HDM USB
module.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:40 +0000 (17:18 +0200)]
staging: most: fix buffer size for DIM2
This patch reduces the DBR buffer size to prevent an overflow in the DIM2
module. It is needed, because the MediaLB hardware has problems with DBR
buffers that exceed the size of 255 messages.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:39 +0000 (17:18 +0200)]
staging: most: remove macro cpu_to_le16
This patch removes the wrongly used macros cpu_to_le16
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:38 +0000 (17:18 +0200)]
staging: most: fix buffer synchronization request
Revision D of OS81118 network interface controller have the internal
buffer synchronization mechanism changed. This patch adapts the driver
to this.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:37 +0000 (17:18 +0200)]
staging: most: remove dead code
The case where the channel type is neither synchronous nor isochronous is
already covered by a previous condition.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:36 +0000 (17:18 +0200)]
staging: most: remove unnecessary field initialization
Since conf->extra_len has already been reset in most_start_channel() when
function hdm_configure_channel() gets called, it can safely be removed
here.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:35 +0000 (17:18 +0200)]
staging: most: fix channel operation in multi-aim context
This patch fixes the opening and closing process of a physical channel
when used by different AIMs.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:34 +0000 (17:18 +0200)]
staging: most: fix USB babble on IN pipe
This patch prevents the HDM USB from submitting an URB with a buffer size
unaligned to 512 bytes to the USB subsystem.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:33 +0000 (17:18 +0200)]
staging: most: remove shared IRQ request
Since there is no way find out whether the INIC has generated an
interrupt, the I2C interrupt must not be registered as a shared
interrupt.
Reported-by: PrasannaKumar Muralidharan <PrasannaKumar.Muraidharan@microchip.com>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:32 +0000 (17:18 +0200)]
staging: most: fix race condition in AIM networking
If the network device is being opened right after it has been registered
via function register_netdev(), the device state is not yet consistent in
the context of function ndo_open(). This patch cares about having the
initialization done right, before the networking device is registered.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:31 +0000 (17:18 +0200)]
staging: most: remove aim reset
This patch partly reverts a modification of function most_stop_channel()
that is trying to reset an established link between an AIM and an HDM in
all suitable places. But since the function most_stop_channel() is
stopping the data transfer it is the wrong place to do so.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 28 Sep 2015 15:18:30 +0000 (17:18 +0200)]
staging: most: change structure initialization
By applying this patch the initialization of the most_aim structure is
performed at compile time.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Fri, 25 Sep 2015 07:45:15 +0000 (00:45 -0700)]
wilc1000 : Remove unused macro definitions
Remove all unused TCP_*_MASK macro definitions
Signed-off-by: Anish Bhatt <anish@gatech.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:06 +0000 (18:15 +0900)]
staging: wilc1000: remove variable cif_func
This patch removes variable cif_func and use mac_cfg directly. No need to have
another pointer variable.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:05 +0000 (18:15 +0900)]
staging: wilc1000: remove function pointer os_wait
This patch removes function pointer os_wait which is pointer of
linux_wlan_lock_timeout and just call the real name function directly.
Remove also static from linux_wlan_lock_timeout declaration.
As os_wait is deleted, structure wilc_wlan_os_func_t is useless. Delete
wilc_wlan_os_func_t, os_func and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:04 +0000 (18:15 +0900)]
staging: wilc1000: remove mutex txq_cs and it's related codes
mutex txq_cs is never used in the driver. txq_cs, txq_critical_section and
txq_lock have same pointer so just delete them and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:03 +0000 (18:15 +0900)]
staging: wilc1000: remove variable rx_buffer_size
This patch removes two variables rx_buffer_size and use LINUX_RX_SIZE as
argument.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:02 +0000 (18:15 +0900)]
staging: wilc1000: remove variable tx_buffer_size
This patch removes unnecessary two variables tx_buffer_size and just use
LINUX_TX_SIZE as argument.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:01 +0000 (18:15 +0900)]
staging: wilc1000: remove pointer varialbes of hif_cs
Remove hif_lock and hif_critical_section which are pointer of
g_linux_wlan->hif_cs. Remove also it's related codes.
Just use mutex varialbe g_linux_wlan->hif_cs.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:15:00 +0000 (18:15 +0900)]
staging: wilc1000: remove pointer variables of txq_add_to_head_cs
This patch removes txq_add_to_head_critical_section and txq_add_to_head_lock
which are pointer of g_linux_wlan->txq_add_to_head_cs.
Just use g_linux_wlan->txq_add_to_head_cs as argument of function.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:14:59 +0000 (18:14 +0900)]
staging: wilc1000: remove pointer varialbe cfg_wait and cfg_wait_event
This patch removes cfg_wait and cfg_wait_event which are pointer of
g_linux_wlan->cfg_event. No need to have pointer varialbe of it. Just use
g_linux_wlan->cfg_event.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 24 Sep 2015 09:14:58 +0000 (18:14 +0900)]
staging: wilc1000: remove pointer variable of g_linux_wlan->txq_event
Remove variable txq_wait and txq_wait_event which are pointer varialbe
of g_linux_wlan->txq_event. No need to have extra pointer varialbe. Just use
g_linux_wlan->txq_event. Remove os_context.txq_wait_event, txq_wait and it's
related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>