Ana Rey [Fri, 7 Mar 2014 08:23:55 +0000 (09:23 +0100)]
staging: rtl8187se: Convert r8180_priv typedef into a struct
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to structure.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Fri, 7 Mar 2014 08:23:54 +0000 (09:23 +0100)]
staging: rtl8187se: Convert buffer typedef into a struct
The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to structure.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 6 Mar 2014 21:09:44 +0000 (02:39 +0530)]
Staging: rtl8192e: Fix Sparse Warning of invalid assignment in rtllib_tx.c
This patch fixes following sparse warnings:
drivers/staging/rtl8192e/rtllib_tx.c:942:45: warning: invalid assignment: +=
drivers/staging/rtl8192e/rtllib_tx.c:942:45: left side has type unsigned long
drivers/staging/rtl8192e/rtllib_tx.c:942:45: right side has type restricted __le16
drivers/staging/rtl8192e/rtllib_tx.c:947:49: warning: invalid assignment: +=
drivers/staging/rtl8192e/rtllib_tx.c:947:49: left side has type unsigned long
drivers/staging/rtl8192e/rtllib_tx.c:947:49: right side has type restricted __le16
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 5 Mar 2014 16:12:04 +0000 (17:12 +0100)]
staging: rtl8187se: Fix whitespaces in ieee80211/dot11d.h
This patch fixes whitespaces as the codingStyle of the kernel recommends.
Thus, this patch fixes these errors found by checkpatch.pl in r8180.h
ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raluca Oncioiu [Fri, 7 Mar 2014 22:44:12 +0000 (00:44 +0200)]
Staging: octeon-usb: Remove unnecessary brackets
Remove brackets from single line branches of if statements.
Break long lines.
Signed-off-by: Raluca Oncioiu <raluca.oncioiu91@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raluca Oncioiu [Fri, 7 Mar 2014 22:32:05 +0000 (00:32 +0200)]
Staging: octeon-usb: Break up long lines
Break up long lines.
Signed-off-by: Raluca Oncioiu <raluca.oncioiu91@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 14:49:07 +0000 (20:19 +0530)]
Staging:rtl8192:ieee80211: Fix sparse warning cast to restricted __le32
This patch fixes the following sparse warnings in ieee80211_rx.c:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2201:34: warning: cast
to restricted __le32
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2202:34: warning: cast
to restricted __le32
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2203:36: warning: cast
to restricted __le32
by changing the annotation in the structure header file for struct
ieee80211_probe_response for time_stamp and altering the cast
for beacon_interval to le16.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Tue, 4 Mar 2014 23:23:58 +0000 (04:53 +0530)]
staging:rtl8712: Fix sparse warning incorrect type in assignment
This patch fixes the following sparse warnings:
drivers/staging/rtl8712/rtl871x_cmd.c:471:30: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:471:30: expected unsigned int
[unsigned] [usertype] Length
drivers/staging/rtl8712/rtl871x_cmd.c:471:30: got restricted __le32
[usertype] <noident>
drivers/staging/rtl8712/rtl871x_cmd.c:472:32: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:472:32: expected unsigned int
[unsigned] [usertype] IELength
drivers/staging/rtl8712/rtl871x_cmd.c:472:32: got restricted __le32
[usertype] <noident>
drivers/staging/rtl8712/rtl871x_cmd.c:473:39: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:473:39: expected unsigned int
[unsigned] [usertype] SsidLength
drivers/staging/rtl8712/rtl871x_cmd.c:473:39: got restricted __le32
[usertype] <noident>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Fri, 7 Mar 2014 17:29:10 +0000 (22:59 +0530)]
staging:netlogic: Shorten line to 80 characters
This patch fixes the checkpatch.pl warning: line over 80 charcters.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Thu, 6 Mar 2014 15:14:37 +0000 (17:14 +0200)]
Staging:ft1000: Fix __packed is preferred over __attribute__((packed)) in ft1000_ioctl.h
Fix checkpatch.pl issues with __packed is preferred
over __attribute__((packed)) in ft1000_ioctl.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 21:42:30 +0000 (03:12 +0530)]
Staging: gdm72xx: Fix incorrect type in assignment in gdm_wimax.c
This patch fixes following sparse warnings:
drivers/staging/gdm72xx/gdm_wimax.c:543:37: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:543:37: expected void [noderef] <asn:1>*to
drivers/staging/gdm72xx/gdm_wimax.c:543:37: got void *buf
drivers/staging/gdm72xx/gdm_wimax.c:566:41: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:566:41: expected void const [noderef] <asn:1>*from
drivers/staging/gdm72xx/gdm_wimax.c:566:41: got void *buf
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 16:41:29 +0000 (22:11 +0530)]
staging:gdm72xx: Fix unnecessary brace errors
This patch fixes the following warning for gdm_wimax.c
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 7 Mar 2014 12:23:06 +0000 (14:23 +0200)]
Staging:winbond: Fix line over 80 characters in wb35rx.c
Fix checkpatch.pl issues with line over 80
characters in wb35rx.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 6 Mar 2014 23:50:20 +0000 (05:20 +0530)]
staging:android: Introduce the use of the managed version of kzalloc
This patch moves shared private data kzalloc to managed devm_kzalloc and
cleans now unneccessary kfree in probe and remove functions.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 00:50:09 +0000 (06:20 +0530)]
staging:rtl8187se:ieee80211: Fix Sparse Warning for Static Declarations
This patch fixes the following Sparse warnings :
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:27:4: warning:
symbol 'rsn_authen_cipher_suite' was not declared. Should it be static?
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:352:6: warning:
symbol 'ext_ieee80211_send_beacon_wq' was not declared. Should it be
static?
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Tue, 4 Mar 2014 23:47:40 +0000 (05:17 +0530)]
staging:rtl8187se:ieee80211: Fix incorrect type in assignment
This patch fixes sparse warnings like :
(1) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31:
warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31:
expected unsigned short [unsigned] [usertype] frame_ctl
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: got
restricted __le16 [usertype] <noident>
(2) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32:
warning: incorrect type in assignment (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32:
expected restricted __le16 [usertype] duration_id
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: got
int
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keerthimai Janarthanan [Thu, 6 Mar 2014 14:21:46 +0000 (19:51 +0530)]
staging: rts5139: Unnecessary space between function pointer name.
Unnecessary space between function pointer name.
Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 20:24:44 +0000 (01:54 +0530)]
Staging: rts5139: Fix Sparse Warning for Static Declarations in rts51x.c
This patch fixes the following sparse warning in rts51x.c
drivers/staging/rts5139/rts51x.c:218:5: warning: symbol 'rts51x_pre_reset' was not declared. Should it be static?
drivers/staging/rts5139/rts51x.c:229:5: warning: symbol 'rts51x_post_reset' was not declared. Should it be static?
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 20:19:16 +0000 (01:49 +0530)]
Staging: rts5139: Fix Sparse Warning for Static Declarations
This patch fixes the following Sparse warnings :
formatter_inquiry_str should be static
queuecommand_lck should be static
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Wed, 5 Mar 2014 19:39:09 +0000 (21:39 +0200)]
staging: rts5139: Fix quoted string split across lines
This patch fixes the quoted string split across
lines in staging/rts5139/ms.c
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Wed, 5 Mar 2014 15:23:10 +0000 (17:23 +0200)]
staging/rts5208/rtsx_scsi.c: Remove unnecessary parentheses
Remove unnecessary parentheses from staging/rts5208/rtsx_scsi.c
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 01:57:44 +0000 (07:27 +0530)]
Staging: rts5139: Fix incorrect type in assignment in rts51x_fop.c
This patch fixes following sparse warning in rts51x_fop.c
Warning: incorrect type in assignment
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Tue, 4 Mar 2014 23:29:57 +0000 (04:59 +0530)]
staging:serqt_usb2: Fix sparse warning restricted __le16 degrades to integer
This patch fixes the following sparse warning :
drivers/staging/serqt_usb2/serqt_usb2.c:727:40: warning: restricted __le16 degrades to integer
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Fri, 7 Mar 2014 16:09:27 +0000 (21:39 +0530)]
staging:nvec: Introduce the use of the managed version of kzalloc
This patch moves shared private data kzalloc to managed devm_kzalloc.
There are no kfree statements associated with this data, so using devm
adds the possibility of the data being freed, if the proble function
fails (if that is possible) or if the remove function succeeds.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 5 Mar 2014 20:48:39 +0000 (22:48 +0200)]
Staging:nvec: fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split
across lines in nvec.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 00:43:54 +0000 (06:13 +0530)]
Staging: crystalhd: Fix different address spaces warning
This patch fixes following sparse warning in crystalhd_lnx.c
WARNING: incorrect type in argument
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 00:35:51 +0000 (06:05 +0530)]
Staging: crystalhd: Fix different address spaces warning from sparse in crystalhd_misc.c
This patch fixes following sparse warning in crystalhd_misc.c
WARNING: incorrect type in argument
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 7 Mar 2014 14:23:43 +0000 (16:23 +0200)]
Staging:dgap: Fix "foo * bar" should be "foo *bar" in dgap.h
Fix checkpatch.pl issues with "foo * bar" should
be "foo *bar" in dgap.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 7 Mar 2014 14:23:42 +0000 (16:23 +0200)]
Staging:dgap: Fix open brace '{' following struct go on the same line in dgap.h
Fix checkpatch.pl issues with open brace '{'
following struct go on the same line in dgap.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Thu, 6 Mar 2014 23:48:49 +0000 (01:48 +0200)]
Staging:wlags49_h25: Fix sparse warning for static declarations
This patch fixes the Sparse Warnings "symbol
was not declared. Should it be static?"
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 21:05:16 +0000 (02:35 +0530)]
Staging: wlags49_h2: Fix incorrect type in assignment in wl_wext.c
This patch fixes following sparse warnings:
drivers/staging/wlags49_h2/wl_wext.c:3357:28: warning: incorrect type in assignment (different address spaces)
drivers/staging/wlags49_h2/wl_wext.c:3357:28: expected void [noderef] <asn:1>*[addressable] [assigned] pointer
drivers/staging/wlags49_h2/wl_wext.c:3357:28: got void *<noident>
drivers/staging/wlags49_h2/wl_wext.c:3422:47: warning: incorrect type in assignment (different address spaces)
drivers/staging/wlags49_h2/wl_wext.c:3422:47: expected void [noderef] <asn:1>*[addressable] [assigned] pointer
drivers/staging/wlags49_h2/wl_wext.c:3422:47: got char *[usertype] <noident>
drivers/staging/wlags49_h2/wl_wext.c:3781:21: warning: symbol 'wl_priv_args' was not declared. Should it be static?
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 20:55:30 +0000 (02:25 +0530)]
Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in dhf.c
This patch fixes the following sparse warnings:
drivers/staging/wlags49_h2/dhf.c:109:6: warning: symbol 'signature' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:126:25: warning: symbol 'mfi_sup' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:127:25: warning: symbol 'cfi_sup' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:142:17: warning: symbol 'ltv_info' was not declared. Should it be static?
drivers/staging/wlags49_h2/dhf.c:173:1: warning: symbol 'check_comp_fw' was not declared. Should it be static?
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 20:49:41 +0000 (02:19 +0530)]
Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in hcf.c
This patch fixes following sparse warnings:
drivers/staging/wlags49_h2/hcf.c:253:26: warning: symbol 'cfg_drv_identity' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:262:24: warning: symbol 'cfg_drv_sup_range' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:274:31: warning: symbol 'cfg_drv_act_ranges_pri' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:291:31: warning: symbol 'cfg_drv_act_ranges_sta' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:336:31: warning: symbol 'cfg_drv_act_ranges_hsi' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:373:24: warning: symbol 'cfg_drv_act_ranges_apf' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:3103:1: warning: symbol 'calc_mic' was not declared. Should it be static?
drivers/staging/wlags49_h2/hcf.c:3419:1: warning: symbol 'check_mic' was not declared. Should it be static?
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 20:39:06 +0000 (02:09 +0530)]
Staging: wlags49_h2: Fix Remove unused functions in wl_util.c
This patch removes the unused function "percent" from wl_util.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 01:00:41 +0000 (06:30 +0530)]
staging:wlags49_h2: Remove unnecessary braces in if statements
This patch fixes the checkpatch warnings:
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 01:00:19 +0000 (06:30 +0530)]
staging:wlags49_h2: Remove unnecessary spaces around parentheses
This patch fixes the following checkpatch errors:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 00:59:58 +0000 (06:29 +0530)]
staging:wlags49_h2:fix conditional statement warnings
This patch fixes the following warnings:
WARNING: that open brace { should be on the previous line
WARNING: suspect code indent for conditional statements (16, 16)
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 00:59:03 +0000 (06:29 +0530)]
staging:wlags49_h2:change include path for uaccess.h
This patch fixes the following issue detected by checkpatch.pl.
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 00:58:24 +0000 (06:28 +0530)]
staging:wlags49_h2: change comment style
Coding style requires that comments use the standard /* */ style
instead of C99 style. The commented #include statements were also
removed as they are not required.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 4 Mar 2014 12:27:31 +0000 (17:57 +0530)]
Staging: wlags49_h2: Fix sparse warnings in sta_h2.c
This patch fixes sparse warnings "Using plain integer as NULL pointer" in
sta_h2.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Mon, 3 Mar 2014 20:06:10 +0000 (01:36 +0530)]
Staging: iio/accel: Fix Prefer netdev_warn(netdev, ...then dev_warn(dev, ... then pr_warn(... to printk(KERN_INFO ... in sca3000_ring.c
This patch fixes the following checkpatch.pl warning in sca3000_ring.c
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Mon, 3 Mar 2014 16:39:58 +0000 (22:09 +0530)]
Staging: iio/resolver: Fix prefer pr_warn over pr_warning in ad2s1210.c
This patch fixes following checkpatch.pl warning
WARNING: Prefer pr_warn(... to pr_warning(...
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 20:10:32 +0000 (22:10 +0200)]
Staging: rtl8188eu: Fix warning of prefer ether_addr_copy.
This patch fixes the warning of "Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)" in file rtw_cmd.c. Pahole
shows that the addresses are 2-byte aligned.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:38:05 +0000 (09:38 +0200)]
Staging: rtl8188eu: Fix warning of suspect code indent.
This patch fixes the warning of "suspect code indent for conditional
statements" in file rtw_cmd.c. I have removed the conditional statements
in two places altogether, as it didn't bring any value.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:37:25 +0000 (09:37 +0200)]
Staging: rtl8188eu: Fix warning of space prohibited before semicolon.
This patch fixes the warning of "space prohibited before semicolon" in file rtw_cmd.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:37:04 +0000 (09:37 +0200)]
Staging: rtl8188eu: Fix warning of unnecessary parentheses.
This patch fixes the warning of "unnecessary parentheses" in file rtw_cmd.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:36:37 +0000 (09:36 +0200)]
Staging: rtl8188eu: Fix warning of space before tabs.
This patch fixes the warning of "please, no space before tabs" in file
rtw_cmd.c. I have also removed couple of lines of code that was
commented and probably left from the previous version.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:35:34 +0000 (09:35 +0200)]
Staging: rtl8188eu: Fix warning of spaces at the start of a line.
This patch fixes the warning of "please, no spaces at the start of a
line" in file rtw_cmd.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 07:34:39 +0000 (09:34 +0200)]
Staging: rtl8188eu: Fix warning braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_cmd.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 5 Mar 2014 22:03:59 +0000 (03:33 +0530)]
Staging: rtl8188eu: Fix sparse warning cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1627:25: warning: cast to restricted __le16
by changing the annotations in the struct declaration.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 4 Mar 2014 21:43:41 +0000 (23:43 +0200)]
Staging: rtl8188eu: Fix warning of printk should include KERN_.
This patch fixes the warning produced by checkpatch of "printk should
include KERN_ facility level". printk was replaced by netdev_info. While
at it, I have also fixed the line over 80 characters warning.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 6 Mar 2014 22:10:34 +0000 (00:10 +0200)]
Staging: rtl8188eu: Fix warning of prefer ether_addr_copy().
This patch fixes the warning produced by checkpatch "Prefer
ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)". The address that is copied is a field of
nat25_network_db_entry structure. Definition for this struct is found in
rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 4 Mar 2014 19:28:29 +0000 (21:28 +0200)]
Staging: rtl8188eu: Fix warning of braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for any arm
of this statement" in file rtw_ioctl_set.c. The braces are removed in
three places.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Mon, 3 Mar 2014 23:54:15 +0000 (01:54 +0200)]
Staging:rtl8188eu: fix kfree(NULL) is safe this check is probably not required in rtw_ap.c
Fix checkpatch.pl issues with kfree(NULL) is safe this
check is probably not required in rtw_ap.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Mon, 3 Mar 2014 21:34:46 +0000 (23:34 +0200)]
Staging: rtl8188eu: Fix warning of kfree check is not required.
This patch fixes the warning produced by checkpatch in the file
rtw_cmd.c "kfree(NULL) is safe this check is probably not required". The
patch fixes it in two places for this file.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Mon, 3 Mar 2014 19:47:18 +0000 (21:47 +0200)]
Staging: rtl8188eu: Fix warning of no space before tabs.
This patch fixes the warning of "Please, no space before tab" produced
by checkpatch.pl. The modified file: rtw_cmd.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Mon, 3 Mar 2014 07:44:19 +0000 (09:44 +0200)]
Staging: rtl8188eu: Fix the warning of space before parenthesis.
This patch fixes the warning of "space prohibited between function name
and open parenthesis '('". The modified file: rtw_cmd.c. The patch also
removes some strange spaces that were generated probably by some editor.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Fri, 7 Mar 2014 22:23:34 +0000 (14:23 -0800)]
Merge branch 'imx-drm-staging' of git://ftp.arm.linux.org.uk/~rmk/linux-arm into staging-next
Russell writes:
This set of changes reorganises imx-drm's DT bindings by re-using the OF
graph parsing code which was located in drivers/media, removing the
temporary bindings.
The result is that more TODO entries are now removed. While we're not
quite done with this yet as there's a few straggling updates to imx-ldb
to come, but leaving these out is not detrimental at this point in time
- they are more an enhancement.
However, this pull has the additional complication that we're sharing
seven commits with Mauro's V4L git tree, which move the OF graph parsing
code out of drivers/media into drivers/of. Philipp's imx-drm changes
depend on these and my previously committed round of imx-drm commits.
Hence, the diffstat below is from a test merge with your tree head
(
17b02809cfa7).
Mauro merged those seven commits earlier today as a git pull, so both
trees will be sharing exactly the same commit IDs.
I've given these changes a spin here on both my Hummingboard and Cubox-i4
(one is iMX6Solo, the other is iMX6Quad based), which includes Xorg using
the DRM device directly, and I find nothing wrong.
The diffstat does look a little scarey - this is because we're having to
update the ARM DT files along with this change, and obviously the
dependency on the OF graph parsing code.
bahar sahin [Mon, 3 Mar 2014 01:56:03 +0000 (03:56 +0200)]
Staging: octeon: Fix coding style
This patch removes unnecessary braces to fix a checkpatch.pl warning.
Signed-off-by: bahar sahin <baharxf@gmail.com>
Reviewed-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Mon, 3 Mar 2014 01:03:54 +0000 (06:33 +0530)]
staging:octeon: Replace pr_warning by preferred pr_warn
This patch fixes the checkpatch.pl warning :
Prefer pr_warn(... to pr_warning(...
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Mon, 3 Mar 2014 01:00:46 +0000 (06:30 +0530)]
staging:octeon: remove space after opening parentheses
This patch fixes the checkpatch warning : space prohibited after
that open parenthesis '('.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Thu, 6 Mar 2014 17:42:16 +0000 (19:42 +0200)]
Staging:wlan-ng: no space before tabs in p80211mgmt.h
Fix checkpatch.pl issues with no space before tabs
in p80211mgmt.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 5 Mar 2014 15:40:52 +0000 (21:10 +0530)]
staging:wlan-ng:Fix sparse warning cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/wlan-ng/hfa384x_usb.c:3582:14: warning: cast to
restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:3584:19: warning: cast to
restricted __le16
by changing the annotations in the struct declaration.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Mon, 3 Mar 2014 00:39:45 +0000 (02:39 +0200)]
Staging: wlan-ng: Fix Sparse warning should it be static?
This patch fixes following Sparse warning should it be static? in
staging/wlan-ng.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sun, 2 Mar 2014 17:16:15 +0000 (22:46 +0530)]
Staging:
ced1401: Fix removed unused structs
This patch removes an unused struct while at the same time removing checkpatch.pl warning
WARNING: Avoid use of typedef
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sun, 2 Mar 2014 15:30:46 +0000 (21:00 +0530)]
Staging:
ced1401: Fix do not add new typedefs
This patch fixes the following checkpatch.pl issues in ced_ioctl.h
WARNING: do not add new typedefs
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sat, 1 Mar 2014 22:47:01 +0000 (04:17 +0530)]
Staging: gs_gpgaboot: Fix Bad function definition in io.c
This patch fixes the following checkpatch.pl issues in io.c
WARNING: Bad function definition
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Fri, 7 Mar 2014 11:33:08 +0000 (17:03 +0530)]
Staging: dgnc: Fix struct file_operations should normally be const
This patch fixes following checkpatch.pl warning:
WARNING:struct file_operations should normally be const
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 3 Mar 2014 21:05:46 +0000 (23:05 +0200)]
staging: sbe-2t3e3: remove t3e3_resp_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_resp_t typedef.
Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 3 Mar 2014 21:05:45 +0000 (23:05 +0200)]
staging: sbe-2t3e3: remove t3e3_stats_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_stats_t typedef.
Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:107: WARNING: do not add new typedefs
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 3 Mar 2014 21:05:44 +0000 (23:05 +0200)]
staging: sbe-2t3e3: remove t3e3_param_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_param_t typedef.
Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:87: WARNING: do not add new typedefs
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 3 Mar 2014 21:05:43 +0000 (23:05 +0200)]
staging: sbe-2t3e3: remove t3e3_tx_desc_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_tx_desc_t typedef.
Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 3 Mar 2014 21:05:42 +0000 (23:05 +0200)]
staging: sbe-2t3e3: remove t3e3_rx_desc_t typedef
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_rx_desc_t typedef.
Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Sun, 2 Mar 2014 10:46:31 +0000 (12:46 +0200)]
Staging: sbe-2t3e3: Fix the error of (foo*) should be (foo *).
This patch fixes an error in 2t3e3.h that (foo*) should be (foo *).
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 1 Mar 2014 21:38:46 +0000 (03:08 +0530)]
staging:sbe-2t3e3: remove assignment in if condition
This patch removes the assignment in an if condition to do away with
the checkpatch warning :'do not use assignment in if condition'.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 1 Mar 2014 21:22:20 +0000 (02:52 +0530)]
Staging:cxt1e1:musycc:remove assignment in if condition
This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Tue, 4 Mar 2014 21:21:09 +0000 (02:51 +0530)]
staging: silicom : remove assignment in if condition
This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 5 Mar 2014 17:15:30 +0000 (19:15 +0200)]
Staging:media: Fix Sparse warnings incorrect type in lirc_sasem.c
This patch fixes following sparse warning in dgap.c
drivers/staging/media/lirc/lirc_sasem.c:392:32: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/media/lirc/lirc_sasem.c:392:32: expected void const [noderef] <asn:1>*<noident>
drivers/staging/media/lirc/lirc_sasem.c:392:32: got char const *buf
drivers/staging/media/lirc/lirc_sasem.c:123:28: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
drivers/staging/media/lirc/lirc_sasem.c:123:28: expected int ( *write )( ... )
drivers/staging/media/lirc/lirc_sasem.c:123:28: got int ( static [toplevel] *<noident> )( ... )
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 5 Mar 2014 17:15:29 +0000 (19:15 +0200)]
Staging:media: Fix Sparse Warnings "symbol was not declared. Should it be static?"
This patch fixes the Sparse Warnings "symbol was
not declared. Should it be static?"
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sat, 1 Mar 2014 22:40:04 +0000 (04:10 +0530)]
Staging: media/cxd2099: Fix line length over 80 characters
This patch fixes the following checkpatch.pl issues in cxd2099.c
WARNING: line length over 80 characters
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 1 Mar 2014 20:48:38 +0000 (02:18 +0530)]
staging:media: remove assignment in if condition
This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Zabel [Wed, 5 Mar 2014 09:21:02 +0000 (10:21 +0100)]
staging: imx-drm: Update TODO
The device tree bindings are updated regardless of the common display
framework and in the meantime the HDMI driver was included.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:21:01 +0000 (10:21 +0100)]
ARM: dts: imx6qdl: Add IPU DI ports and endpoints, move imx-drm node to dtsi
This patch connects IPU and display encoder (HDMI, LVDS, MIPI)
device tree nodes, as well as parallel displays on the DISP0
and DISP1 outputs, using the OF graph bindings described in
Documentation/devicetree/bindings/media/video-interfaces.txt
The IPU ports correspond to the two display interfaces. The
order of endpoints in the ports is arbitrary.
Each encoder with an associated input multiplexer has multiple
input ports in the device tree. The order and reg property of
the ports must correspond to the multiplexer input order.
Since the imx-drm node now only needs to contain links to the
display interfaces, it can be moved to the SoC dtsi level. At
the board level, only connections between the display interface
ports and encoders or panels have to be added.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:21:00 +0000 (10:21 +0100)]
ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi
This patch connects IPU and display encoder (VGA, LVDS)
device tree nodes, as well as parallel displays on the DISP0
and DISP1 outputs, using the OF graph bindings described in
Documentation/devicetree/bindings/media/video-interfaces.txt
The IPU ports correspond to the two display interfaces. The
order of endpoints in the ports is arbitrary.
Since the imx-drm node now only needs to contain links to the
display interfaces, it can be moved to the SoC dtsi level. At
the board level, only connections between the display interface
ports and encoders or panels have to be added.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:59 +0000 (10:20 +0100)]
ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi
This patch connects IPU and and parallel display device tree
nodes using the OF graph bindings described in
Documentation/devicetree/bindings/media/video-interfaces.txt
The IPU ports correspond to the two display interfaces. The
order of endpoints in the ports is arbitrary.
Since the imx-drm node now only needs to contain links to the
display interfaces, it can be moved to the SoC dtsi level. At
the board level, only connections between the display interface
ports and panels have to be added.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:58 +0000 (10:20 +0100)]
ARM: dts: imx53-mba53: Fix TVE DDC I2C bus property
This patch fixes the Television Encoder node's DDC I2C bus property to
use the common property name of 'ddc-i2c-bus' instead of just 'ddc'.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:57 +0000 (10:20 +0100)]
imx-drm: imx-tve: Fix DDC I2C bus property
This patch fixes the TV Encoder DDC I2C bus property to use the common
'ddc-i2c-bus' property name instead of 'ddc'.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:56 +0000 (10:20 +0100)]
imx-drm: imx-hdmi: Fix DDC I2C bus property
This patch fixes the DDC I2C bus property to use the common 'ddc-i2c-bus'
property name instead of 'ddc'. This is already documented in
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:55 +0000 (10:20 +0100)]
staging: imx-drm: Document imx-hdmi device tree bindings
This patch adds device tree binding documentation for the HDMI transmitter
on i.MX6.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:54 +0000 (10:20 +0100)]
staging: imx-drm: Document updated imx-drm device tree bindings
This patch updates the device tree binding documentation for i.MX IPU/display
nodes using the OF graph bindings documented in
Documentation/devicetree/bindings/media/video-interfaces.txt.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:53 +0000 (10:20 +0100)]
staging: imx-drm-core: use of_graph_parse_endpoint
Using of_graph_parse_endpoint recovers the port id from an endpoint device
tree node. This just replaces an open coded read of the "reg" property.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Philipp Zabel [Wed, 5 Mar 2014 09:20:52 +0000 (10:20 +0100)]
staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs
This patch adds support to find the involved components connected to
the IPU display interface ports using the OF graph bindings documented
in Documentation/devicetree/bindings/media/video-interfaces.txt.
It makes use of the of_graph (formerly v4l2_of) parsing helpers and
thus depends on the patch that moves those out to drivers/of.
Each display interface needs to have an associated port node in the
device tree. We can associate this node with the crtc platform device
and use it to find the crtc corresponding to a given port node instead
of using a combination of parent device node and id number, as before.
Explicitly converting the void* cookie to the port device tree node
allows to get rid of the ipu_id and di_id fields. The multiplexer
setting on i.MX6 now can be obtained from the port id (reg property)
in the device tree.
The imx-drm node now needs a ports property that contains phandles
to each of the IPU display interface port nodes. From there, all
attached encoders are scanned and enabled encoders are added to a
waiting list.
The bind order makes sure that once all components are probed, crtcs
are bound before encoders, so that imx_drm_encoder_parse_of can be
called from the encoder bind callbacks.
For parsing the OF graph, temporary copies of the V4L2 OF graph
helpers are used, that can be removed again once those are available
at a generic place.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Russell King [Fri, 7 Mar 2014 16:17:06 +0000 (16:17 +0000)]
Merge branch 'topic/of-graph' of git://git.pengutronix.de/git/pza/linux into imx-drm-staging
Merge the of-graph dependency for imx-drm. These will be the basis of
the new DT bindings for imx-drm.
Philipp Zabel [Fri, 7 Mar 2014 14:49:54 +0000 (15:49 +0100)]
of: Fix of_graph_parse_endpoint stub for !CONFIG_OF builds
This patch fixes the following build error:
In file included from drivers/media/i2c/adv7343.c:29:0:
>> include/linux/of_graph.h:41:1: error: expected identifier or '(' before '{' token
{
^
include/linux/of_graph.h:39:19: warning: 'of_graph_parse_endpoint' declared 'static' but never defined [-Wunused-function]
static inline int of_graph_parse_endpoint(const struct device_node *node,
^
vim +41 include/linux/of_graph.h
35 const struct device_node *node);
36 struct device_node *of_graph_get_remote_port(const struct device_node *node);
37 #else
38
39 static inline int of_graph_parse_endpoint(const struct device_node *node,
40 struct of_endpoint *endpoint);
> 41 {
42 return -ENOSYS;
43 }
44
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Himangi Saraogi [Thu, 6 Mar 2014 22:37:18 +0000 (04:07 +0530)]
staging:lustre: Fix sparse warning of incorrect argument type
This patch fixes the following sparse warning :
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: expected void const [noderef] <asn:1>*from
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:99:35: got char const *buffer
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 6 Mar 2014 22:39:23 +0000 (04:09 +0530)]
staging:lustre: Fix sparse warnings of Using plain integer as NULL pointer
This patch fixes the following sparse warnings:
drivers/staging/lustre/lustre/lov/lov_obd.c:342:48: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:647:44: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:771:46: warning: Using plain integer as NULL pointer
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sat, 1 Mar 2014 21:31:17 +0000 (03:01 +0530)]
staging: lustre: remove assignment in if condition
This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sat, 1 Mar 2014 11:33:33 +0000 (17:03 +0530)]
Staging : lustre/lustre/lov: Fix Statements terminations use 1 semicolon in lov_ea.c
This patch fixes the following checkpatch.pl issues in lov_ea.c
Warning: Statements terminations use 1 semicolon in lov_ea.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John de la Garza [Thu, 6 Mar 2014 23:51:59 +0000 (15:51 -0800)]
usbip:usbip_common.c: check return value of sscanf
Added code to check return value of sscanf.
Signed-off-by: John de la Garza <john@jjdev.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John de la Garza [Fri, 7 Mar 2014 00:30:36 +0000 (16:30 -0800)]
comedi:drivers:poc.c: unnecessary space before function pointer arguments
Removed unnecessary space before function pointer arguments.
Signed-off-by: John de la Garza <john@jjdev.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / MotorolaMobilityLLC / kernel-slsi.git / log