Alexander Ebert [Sat, 23 Apr 2022 16:08:39 +0000 (18:08 +0200)]
Unused import
Marcel Werk [Sat, 23 Apr 2022 13:19:37 +0000 (15:19 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Sat, 23 Apr 2022 13:19:35 +0000 (15:19 +0200)]
Wrapping of the pagination prevented
Marcel Werk [Sat, 23 Apr 2022 13:08:29 +0000 (15:08 +0200)]
Fixed margins when pagination top was hidden
Marcel Werk [Sat, 23 Apr 2022 12:15:14 +0000 (14:15 +0200)]
Unified code of content header / footer navigation
Alexander Ebert [Sat, 23 Apr 2022 12:12:09 +0000 (14:12 +0200)]
Do not focus the search suggestions automatically
This interferes with the ability to enter a search term that is similar to a suggestion. Pressing enter would cause the suggestion to be filed in instead of submitting the value as-is.
Alexander Ebert [Sat, 23 Apr 2022 12:08:54 +0000 (14:08 +0200)]
Selecting a search suggestion discarded the search
See https://www.woltlab.com/community/thread/295268-suchfunktion-teilweise-umst%C3%A4ndlich/
Alexander Ebert [Fri, 22 Apr 2022 16:11:11 +0000 (18:11 +0200)]
Superfluous whitespace
Alexander Ebert [Fri, 22 Apr 2022 16:01:37 +0000 (18:01 +0200)]
Restore the user menu DOM on close
See https://www.woltlab.com/community/thread/295304-kontrollzentrum-nicht-mehr-anklickbar-nach-wechsel-der-aufl%C3%B6sung/
Alexander Ebert [Fri, 22 Apr 2022 15:16:55 +0000 (17:16 +0200)]
Exclude the macOS emoji keyboard from keypresses
See https://www.woltlab.com/community/thread/295207-hotkey-f%C3%BCr-emoji-men%C3%BC-funktioniert-im-editor-nicht/
Alexander Ebert [Fri, 22 Apr 2022 15:10:25 +0000 (17:10 +0200)]
Incorrect selection when submitting editor dialogs
Fixes #4747
Tim Düsterhus [Fri, 22 Apr 2022 14:13:42 +0000 (16:13 +0200)]
Update fileDelete.xml to remove files where only the case changed
It is not guaranteed that new file case was successfully applied on case
insensitive file system, so these files might be deleted even with the
fileDelete PIP verifying the actual casing since
49c488354f3fd5b02a851a48d912d6aad3601161.
Remove those files from fileDelete.xml to be on the safe side. This is no
longer easily doable with bash only. The following PHP script was used to
generate fileDelete.xml:
<?php
\exec(<<<'EOT'
git log --root --diff-filter=D --no-renames --summary |awk '/delete mode/{print $NF}' |grep wcfsetup/install/files/ |sort -u
EOT, $delete);
\exec(<<<'EOT'
find wcfsetup/install/files/ |sort -u
EOT, $preserve);
$preserve = \array_map('strtolower', $preserve);
$delete = \array_filter($delete, static function ($file) use ($preserve) {
return !\in_array(\strtolower($file), $preserve);
});
echo <<<'EOT'
<?xml version="1.0" encoding="UTF-8"?>
<data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com http://www.woltlab.com/XSD/2019/fileDelete.xsd">
<delete>
<!-- Special files -->
<file>acp/masterPassword.inc.php</file>
<!-- /Special files -->
EOT, "\n";
echo \implode("\n", \array_map(static function ($file) {
$file = \preg_replace('/^wcfsetup\\/install\\/files\\//', '', $file);
return "\t\t<file>{$file}</file>";
}, $delete))."\n";
echo <<<'EOT'
</delete>
</data>
EOT, "\n";
Tim Düsterhus [Fri, 22 Apr 2022 13:26:54 +0000 (15:26 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 22 Apr 2022 13:26:13 +0000 (15:26 +0200)]
Remove reference to CONTRIBUTING.md from README.md
see
5d7b7d602e0f6efb077bffda4b3ecceed8534810
Marcel Werk [Thu, 21 Apr 2022 15:28:08 +0000 (17:28 +0200)]
Added global language variable for "mark as read" buttons
Marcel Werk [Thu, 21 Apr 2022 13:26:24 +0000 (15:26 +0200)]
Button label optimized
Alexander Ebert [Thu, 21 Apr 2022 13:14:06 +0000 (15:14 +0200)]
Merge branch '5.4'
Alexander Ebert [Thu, 21 Apr 2022 13:12:48 +0000 (15:12 +0200)]
Detect italic/underline text pasted from Google Docs
Marcel Werk [Thu, 21 Apr 2022 09:33:12 +0000 (11:33 +0200)]
Pagination of search results was not accessible for guests
Closes #4749
Marcel Werk [Wed, 20 Apr 2022 20:19:21 +0000 (22:19 +0200)]
Individual sorting of search results had no effect
Alexander Ebert [Wed, 20 Apr 2022 16:06:39 +0000 (18:06 +0200)]
Release 5.5.0 Alpha 2
WoltLab [Wed, 20 Apr 2022 16:05:32 +0000 (16:05 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 20 Apr 2022 15:28:12 +0000 (17:28 +0200)]
Incorrect focus/scroll management on iOS
See https://www.woltlab.com/community/thread/295245-antworten-button-springt-zum-footer/
Alexander Ebert [Wed, 20 Apr 2022 14:05:36 +0000 (16:05 +0200)]
Incorrect DOM behavior of `dboAction`
The invocation of the `DomChangeListener` does not make any sense any more, because the API is designed to be asynchronous. The caller must take care of this themselves.
Alexander Ebert [Wed, 20 Apr 2022 13:29:23 +0000 (15:29 +0200)]
Merge pull request #4746 from WoltLab/55-user-menu-settings
Cleaned up the user menu, extra profile link
Alexander Ebert [Wed, 20 Apr 2022 13:21:35 +0000 (15:21 +0200)]
Inconsistent layout of multiline text
Alexander Ebert [Wed, 20 Apr 2022 13:05:51 +0000 (15:05 +0200)]
Cleaned up the user menu, extra profile link
Alexander Ebert [Wed, 20 Apr 2022 12:21:34 +0000 (14:21 +0200)]
Merge pull request #4744 from WoltLab/deprecate-fetchRemoteAvatar
Deprecate UserAvatarAction::fetchRemoteAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:56:56 +0000 (12:56 +0200)]
Deprecate UserAvatarAction::fetchRemoteAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:53:58 +0000 (12:53 +0200)]
Add `@since` to UserProfileAction::setAvatar()
see
7448a453886e504eaa1d70e8a39bbb1fad14dd42
see #4583
Marcel Werk [Wed, 20 Apr 2022 09:17:27 +0000 (11:17 +0200)]
Fetching a remote avatar didn't work if user doesn't have to permission to upload avatars
Tim Düsterhus [Tue, 19 Apr 2022 13:49:35 +0000 (15:49 +0200)]
Properly check permissions for the `systemIdMismatch` message in acp/index.tpl
Alexander Ebert [Tue, 19 Apr 2022 12:37:48 +0000 (14:37 +0200)]
Merge pull request #4739 from SoftCreatR/patch-4
Remove cursive font in quotes
WoltLab [Tue, 19 Apr 2022 08:46:09 +0000 (08:46 +0000)]
Updating minified JavaScript files
joshuaruesweg [Tue, 19 Apr 2022 08:18:50 +0000 (10:18 +0200)]
Merge branch '5.4'
joshuaruesweg [Tue, 19 Apr 2022 08:18:31 +0000 (10:18 +0200)]
Fix fetching userID for multilanguage articles
Tim Düsterhus [Tue, 19 Apr 2022 07:05:30 +0000 (09:05 +0200)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Tue, 19 Apr 2022 07:05:06 +0000 (09:05 +0200)]
Merge branch '5.4'
joshuaruesweg [Mon, 18 Apr 2022 08:36:19 +0000 (10:36 +0200)]
Use spaces instead of tabs
joshuaruesweg [Mon, 18 Apr 2022 08:31:40 +0000 (10:31 +0200)]
Prevent firing notifications for awarding own trophies
Sascha Greuel [Sun, 17 Apr 2022 13:27:45 +0000 (15:27 +0200)]
Removed cursive font in quotes
See https://www.woltlab.com/community/thread/295216-kursivschrift-in-zitaten-entfernen
Alexander Ebert [Thu, 14 Apr 2022 14:57:41 +0000 (16:57 +0200)]
Release 5.4.16
Alexander Ebert [Thu, 14 Apr 2022 14:47:23 +0000 (16:47 +0200)]
Merge branch '5.3' into 5.4
Alexander Ebert [Thu, 14 Apr 2022 14:45:23 +0000 (16:45 +0200)]
Release 5.3.22
Alexander Ebert [Thu, 14 Apr 2022 14:25:09 +0000 (16:25 +0200)]
Merge branch '5.4'
Alexander Ebert [Thu, 14 Apr 2022 14:25:02 +0000 (16:25 +0200)]
Removed the outdated `CONTRIBUTING.md`
The file is heavily outdated and badly presented on GitHub. With WoltLab Suite 5.4 we switched to PSR-12 and Prettier anyway, so there is no need to explain any special rules.
Closes #4600
Marcel Werk [Thu, 14 Apr 2022 12:26:35 +0000 (14:26 +0200)]
Merge branch '5.4'
Marcel Werk [Thu, 14 Apr 2022 12:26:23 +0000 (14:26 +0200)]
Attached images with mismatched proportions got mangled
Tim Düsterhus [Thu, 14 Apr 2022 12:17:41 +0000 (14:17 +0200)]
Merge pull request #4737 from WoltLab/exclusion-check-install
Always check exclusions in PackageUpdateAction::createQueue()
Tim Düsterhus [Thu, 14 Apr 2022 10:23:15 +0000 (12:23 +0200)]
Always check exclusions in PackageUpdateAction::createQueue()
Ever since the method checked for package exclusions in
1d7f1d205ee64fd2723877c1f296c592518e516d it only applied the check to updates,
not to fresh installs. It's not clear why it did so, I assume this to be an
oversight.
Change this to always run the exclusion check, otherwise exclusions might be
circumvented using PackageUpdateAction::prepareInstallation() with a
package+version combination that would regularly be excluded.
Tim Düsterhus [Thu, 14 Apr 2022 10:20:33 +0000 (12:20 +0200)]
Improve types in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 10:18:22 +0000 (12:18 +0200)]
Fix error handling in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 09:55:42 +0000 (11:55 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 14 Apr 2022 09:54:49 +0000 (11:54 +0200)]
Add missing trailing comma in PackageUpdateDispatcher
see
cdffd4c7fc6b55e7b131274b8050ddd6f8cb200b
Tim Düsterhus [Thu, 14 Apr 2022 09:50:18 +0000 (11:50 +0200)]
Ensure that the `version` array key is always set for excludes in package update XML processing
see
1996ec7a0df649b27bffbf150d8ddbc0131ce6db
Alexander Ebert [Thu, 14 Apr 2022 09:47:35 +0000 (11:47 +0200)]
Empty code boxes partially collapsed the layout
See https://www.woltlab.com/community/thread/295182-leere-code-box-ist-kaputt/
Tim Düsterhus [Wed, 13 Apr 2022 08:55:41 +0000 (10:55 +0200)]
Merge pull request #4735 from WoltLab/rescue-mode-assets
Embed the assets as data URIs in rescueMode.tpl
Tim Düsterhus [Wed, 13 Apr 2022 08:06:35 +0000 (10:06 +0200)]
Embed the assets as data URIs in rescueMode.tpl
The same reasoning as for the change to WCFSetup in
600940bc4fe0cbc219ba6fd9a89444aefa07dda5 applies:
With this change the rescue mode is fully self-contained and does not rely on
external requests that need to be served using PHP, making it more resilient.
It also avoids the expensive rebuild of the compiled ACP CSS, because it now
uses the prebuilt WCFSetup.css which can be used as-is for this purpose.
Tim Düsterhus [Wed, 13 Apr 2022 07:17:30 +0000 (09:17 +0200)]
Fix typo in en.xml
Alexander Ebert [Tue, 12 Apr 2022 17:00:12 +0000 (19:00 +0200)]
Missing update of the compiled JavaScript files
Alexander Ebert [Tue, 12 Apr 2022 16:59:52 +0000 (18:59 +0200)]
Allow out-of-band polling of notifications
Alexander Ebert [Tue, 12 Apr 2022 13:20:42 +0000 (15:20 +0200)]
Release 5.4.16 dev 1
WoltLab [Tue, 12 Apr 2022 12:39:44 +0000 (12:39 +0000)]
Updating minified JavaScript files
Alexander Ebert [Tue, 12 Apr 2022 12:32:56 +0000 (14:32 +0200)]
Removing an attachment did not purge copies
See https://www.woltlab.com/community/thread/295032-dateianh%C3%A4nge-aktualsieren-sich-nicht-beim-l%C3%B6schen/
WoltLab [Tue, 12 Apr 2022 09:53:44 +0000 (09:53 +0000)]
Updating minified JavaScript files
Marcel Werk [Tue, 12 Apr 2022 09:38:45 +0000 (11:38 +0200)]
Merge pull request #4734 from WoltLab/charset-title
Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl
Tim Düsterhus [Tue, 16 Feb 2021 13:22:28 +0000 (14:22 +0100)]
Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl
see #3802
see #3998
see #4543
Co-authored-by: Sascha Moser <saschamoser1994@hotmail.de>
Tim Düsterhus [Mon, 11 Apr 2022 15:23:52 +0000 (17:23 +0200)]
Merge branch '5.4'
Alexander Ebert [Mon, 11 Apr 2022 15:05:49 +0000 (17:05 +0200)]
Overlaying images discarded the transparency
See https://www.woltlab.com/community/thread/295124-imagickimageadapter-overlayen-zweier-bilder-mit-alpha-channel-entfernt-transpare/
Tim Düsterhus [Mon, 11 Apr 2022 14:04:13 +0000 (16:04 +0200)]
Mark TUnsupportedDefaultValue as deprecated
see #4733
Tim Düsterhus [Mon, 11 Apr 2022 14:01:58 +0000 (16:01 +0200)]
Merge pull request #4733 from WoltLab/php-ddl-default
Add IDefaultValueDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 14:01:29 +0000 (16:01 +0200)]
Merge branch '5.4'
Alexander Ebert [Mon, 11 Apr 2022 14:00:58 +0000 (16:00 +0200)]
Merge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text
Disallow default values for BLOB and TEXT columns
Tim Düsterhus [Mon, 11 Apr 2022 12:14:48 +0000 (14:14 +0200)]
Check for `IDefaultValueDatabaseTableColumn` in AbstractDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:14:19 +0000 (14:14 +0200)]
Explicitly implement `IDefaultValueDatabaseTableColumn` in supported column types
Tim Düsterhus [Mon, 11 Apr 2022 12:13:28 +0000 (14:13 +0200)]
Implement IDefaultValueDatabaseTableColumn by default in AbstractDatabaseTableColumn
This is temporary to not break backwards compatibility.
Tim Düsterhus [Mon, 11 Apr 2022 12:11:50 +0000 (14:11 +0200)]
Add IDefaultValueDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 11:51:00 +0000 (13:51 +0200)]
Allow `null` in `TUnsupportedDefaultValue`
When fetching the column definition from the database MySQL will return `null`
as the default value for BLOB and TEXT column even if the column itself is
`NOT NULL`.
Alexander Ebert [Mon, 11 Apr 2022 10:45:24 +0000 (12:45 +0200)]
Incorrect code formatting
Alexander Ebert [Mon, 11 Apr 2022 10:41:36 +0000 (12:41 +0200)]
Missing cache reset after manually adding phrases
See https://www.woltlab.com/community/thread/295020-text-hinzuf%C3%BCgen-cache-wird-nicht-geleert/
Marcel Werk [Mon, 11 Apr 2022 09:01:36 +0000 (11:01 +0200)]
Create/update page without box information resulted in error
Tim Düsterhus [Fri, 8 Apr 2022 10:24:28 +0000 (12:24 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 8 Apr 2022 10:03:23 +0000 (12:03 +0200)]
Remove accidentally added space in MysqlSearchEngine
Tim Düsterhus [Fri, 8 Apr 2022 10:00:53 +0000 (12:00 +0200)]
Do not add the `+` prefix to search terms matching an InnoDB stop word
This is issue is effectively identical to the one fixed in commit
247d9cc51af9cd78395e2e7600bacbc2ffdf918b.
Tim Düsterhus [Thu, 7 Apr 2022 08:57:11 +0000 (10:57 +0200)]
Update composer dependencies
Tim Düsterhus [Thu, 7 Apr 2022 07:29:06 +0000 (09:29 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 7 Apr 2022 07:28:30 +0000 (09:28 +0200)]
Fix code style in AbstractXMLPackageInstallationPlugin
Marcel Werk [Wed, 6 Apr 2022 15:50:17 +0000 (17:50 +0200)]
Installation of nested elements (e.g. menu items) failed
Tim Düsterhus [Wed, 6 Apr 2022 13:29:26 +0000 (15:29 +0200)]
Update update instructions for 5.5
Tim Düsterhus [Wed, 6 Apr 2022 11:34:34 +0000 (13:34 +0200)]
Decouple HtmlInputProcessor::convertToHtml() from general-purpose HTML encoding (#4728)
Fixes #4717
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Wed, 6 Apr 2022 11:02:02 +0000 (13:02 +0200)]
Ignore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTerms()
joshuaruesweg [Wed, 6 Apr 2022 08:44:01 +0000 (10:44 +0200)]
Remove unused import
joshuaruesweg [Wed, 6 Apr 2022 08:41:04 +0000 (10:41 +0200)]
Use internal class to mask IP addresses
Marcel Werk [Tue, 5 Apr 2022 14:06:13 +0000 (16:06 +0200)]
Article teaser was incorrectly formatted when automatically generated from the article content
Marcel Werk [Tue, 5 Apr 2022 13:59:00 +0000 (15:59 +0200)]
Fixed wrong margin for content item images
Marcel Werk [Tue, 5 Apr 2022 09:20:31 +0000 (11:20 +0200)]
Banning a user without entering an unbanning date leads to error message
Alexander Ebert [Mon, 4 Apr 2022 17:08:41 +0000 (19:08 +0200)]
Detect Firefox in Favico.js based on CSS
See https://www.woltlab.com/community/thread/294994-verwendung-von-installtrigger-in-favico-js-vermeiden/
Alexander Ebert [Mon, 4 Apr 2022 17:01:12 +0000 (19:01 +0200)]
Verify that the active dialog is closable
See https://www.woltlab.com/community/thread/294867-verschachtelte-dialoge-verwerfen-optionen-des-1-dialogs/
Alexander Ebert [Mon, 4 Apr 2022 13:47:47 +0000 (15:47 +0200)]
Removed obsolete method calls of deprecated method
See #4718
Alexander Ebert [Mon, 4 Apr 2022 13:46:30 +0000 (15:46 +0200)]
Removed unused code from WSC <3.0
See #4718