Alexander Ebert [Tue, 25 Jul 2023 09:39:29 +0000 (11:39 +0200)]
Merge branch '5.5'
Alexander Ebert [Tue, 25 Jul 2023 09:38:23 +0000 (11:38 +0200)]
Merge branch '5.4' into 5.5
Alexander Ebert [Tue, 25 Jul 2023 09:38:17 +0000 (11:38 +0200)]
Decrease the height of the news widget
Tim Düsterhus [Tue, 25 Jul 2023 09:23:48 +0000 (11:23 +0200)]
Merge branch '5.5'
Tim Düsterhus [Tue, 25 Jul 2023 09:22:46 +0000 (11:22 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Tue, 25 Jul 2023 09:20:28 +0000 (11:20 +0200)]
Fix comma detection in Ui/ItemList/Static
This got broken during the TypeScript migration in
c04fd6ce08b40262c660d38dbd491c37aed49a89.
see https://www.woltlab.com/community/thread/300812-itemlist-static-separierung-per-komma-funktioniert-nicht/
Tim Düsterhus [Mon, 24 Jul 2023 14:52:54 +0000 (16:52 +0200)]
Merge pull request #5592 from WoltLab/numberformat-php
Fix number formatting in StringUtil
Tim Düsterhus [Mon, 24 Jul 2023 13:34:46 +0000 (15:34 +0200)]
Fix PHP codestyle
Tim Düsterhus [Mon, 24 Jul 2023 07:26:21 +0000 (09:26 +0200)]
Fix StringUtil::formatDouble() for $maxDecimals != 2
NumberFormatter performs rounding itself, thus there is no need to round
manually. This also changes the recommended alternative for this use case that
is mentioned in the doc comment.
Tim Düsterhus [Mon, 24 Jul 2023 07:23:51 +0000 (09:23 +0200)]
Limit the NumberFormatter to 2 fraction digits in StringUtil::getNumberFormatter()
see https://www.woltlab.com/community/thread/300795-startseite-beitr%C3%A4ge-pro-tag-ist-%C3%BCbertrieben-genau/
Tim Düsterhus [Mon, 24 Jul 2023 07:20:04 +0000 (09:20 +0200)]
Fix handling of negative numbers in StringUtil::formatInteger()
The formatted value was compared against `0`, not the original integer. Just
delegate to `formatNumeric()`.
Tim Düsterhus [Fri, 21 Jul 2023 07:10:31 +0000 (09:10 +0200)]
Add missing `.button` class in PaypalPaymentMethod
Alexander Ebert [Thu, 20 Jul 2023 10:23:07 +0000 (12:23 +0200)]
Fix the position of the quote selection
It shares the `balloonTooltip` class but is not part of the page overlay container.
See https://www.woltlab.com/community/thread/300757-quote-by-marking-text-tooltip-is-misplaced-when-page-is-scrolled/
Alexander Ebert [Wed, 19 Jul 2023 15:49:51 +0000 (17:49 +0200)]
Release 6.0.0 Alpha 7
WoltLab [Wed, 19 Jul 2023 15:42:59 +0000 (15:42 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 19 Jul 2023 15:41:26 +0000 (17:41 +0200)]
Update the CKEditor 5 bundle
Alexander Ebert [Wed, 19 Jul 2023 14:48:52 +0000 (16:48 +0200)]
Improve the readability of mentions in the editor
See https://www.woltlab.com/community/thread/300743-vorschl%C3%A4ge-f%C3%BCr-erw%C3%A4hnungen-etwas-vergr%C3%B6%C3%9Fern/
Alexander Ebert [Wed, 19 Jul 2023 14:44:43 +0000 (16:44 +0200)]
Disable image resizing
See #5591
Alexander Ebert [Wed, 19 Jul 2023 14:39:16 +0000 (16:39 +0200)]
Merge pull request #5590 from WoltLab/better-scroll-disable
Improve the behavior of visible scrollbars
Alexander Ebert [Wed, 19 Jul 2023 14:18:01 +0000 (16:18 +0200)]
Closing dialogs with Esc should close and detach the dialog
See https://www.woltlab.com/community/thread/300742-seite-nicht-mehr-scrollbar-wenn-dialog-mittels-esc-geschlossen-wird/
Marcel Werk [Wed, 19 Jul 2023 13:29:46 +0000 (15:29 +0200)]
Fix margins in embedded content widget
Alexander Ebert [Wed, 19 Jul 2023 12:20:59 +0000 (14:20 +0200)]
Add a default value for the x offset of legacy dialogs
The lack of a valid value sometimes caused the dialog to be squished against the side of the document, causing an incorrect width calculation.
Alexander Ebert [Wed, 19 Jul 2023 12:18:29 +0000 (14:18 +0200)]
Simulate the visible sidebar when a dialog is open
Alexander Ebert [Wed, 19 Jul 2023 12:04:03 +0000 (14:04 +0200)]
Always force the vertical scrollbar to be visible
Alexander Ebert [Tue, 18 Jul 2023 16:38:45 +0000 (18:38 +0200)]
Remove the outdated module import
Alexander Ebert [Tue, 18 Jul 2023 16:34:19 +0000 (18:34 +0200)]
Fix the scroll freeze handling on mobile
See https://www.woltlab.com/community/thread/300714-page-jumps-on-mobile-when-opening-reaction-dialog/
Alexander Ebert [Tue, 18 Jul 2023 14:53:12 +0000 (16:53 +0200)]
Add a workaround for the collapsing borders in Firefox
See https://www.woltlab.com/community/thread/300725-broken-hover-effect-for-tables-in-ckeditor/
Tim Düsterhus [Tue, 18 Jul 2023 14:26:52 +0000 (16:26 +0200)]
Merge pull request #5589 from WoltLab/editor-align-order
Use “standard” order for alignment options in CKEditor toolbar
Alexander Ebert [Tue, 18 Jul 2023 14:26:12 +0000 (16:26 +0200)]
Limit the ToC to a maximum of 50% width on large devices
See https://www.woltlab.com/community/thread/300544-maximalbreite-f%C3%BCr-inhaltsverzeichnis-setzen/
Alexander Ebert [Tue, 18 Jul 2023 14:23:23 +0000 (16:23 +0200)]
Fix the position of tooltips
See #5575
Alexander Ebert [Tue, 18 Jul 2023 13:54:32 +0000 (15:54 +0200)]
Fix the color of the balloon tooltip pointer
See https://www.woltlab.com/community/thread/300637-incorrectly-colored-triangle-pointer-for-image-controls-in-ckeditor-in-dark-mode/
Alexander Ebert [Tue, 18 Jul 2023 13:38:18 +0000 (15:38 +0200)]
Restore the mobile search icon when closing the search
See https://www.woltlab.com/community/thread/300653-mobiles-such-icon-%C3%A4ndert-seinen-status-nicht/
Alexander Ebert [Tue, 18 Jul 2023 13:01:52 +0000 (15:01 +0200)]
Suppress button hover states on touch devices
See https://www.woltlab.com/community/thread/300684-mobil-ist-es-nicht-erkennbar-wenn-man-eine-formatierung-deaktiviert/
Tim Düsterhus [Tue, 18 Jul 2023 12:29:40 +0000 (14:29 +0200)]
Use “standard” order for alignment options in CKEditor toolbar
It might be arguable whether it should be "left, center, right, justify" or
"left, right, center, justify", but in no case "center" should come first.
"left, center, right, justify" is used by Google Docs and LibreOffice Writer.
Alexander Ebert [Tue, 18 Jul 2023 10:04:30 +0000 (12:04 +0200)]
Provide a sane width attribute for attachments
Alexander Ebert [Tue, 18 Jul 2023 10:00:01 +0000 (12:00 +0200)]
Report image attachments to the editor
See https://www.woltlab.com/community/thread/300722-broken-image-icon-when-editing-a-post-with-a-video-file-attached/
Alexander Ebert [Mon, 17 Jul 2023 19:04:48 +0000 (21:04 +0200)]
Move popover into the body element
These elements do not exist within dialogs and their behavior does not play well with fixed positioning.
Alexander Ebert [Mon, 17 Jul 2023 16:59:51 +0000 (18:59 +0200)]
Fix the position of balloon tooltips
Alexander Ebert [Mon, 17 Jul 2023 16:37:54 +0000 (18:37 +0200)]
Fix the handling of the width attributes of `[attach]`
Marcel Werk [Mon, 17 Jul 2023 16:26:41 +0000 (18:26 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Mon, 17 Jul 2023 16:26:35 +0000 (18:26 +0200)]
Make explanation of notification setting more precise
Alexander Ebert [Mon, 17 Jul 2023 16:25:19 +0000 (18:25 +0200)]
Use fixed positioning for drop-down menus
Marcel Werk [Mon, 17 Jul 2023 16:20:06 +0000 (18:20 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Mon, 17 Jul 2023 16:20:00 +0000 (18:20 +0200)]
Fix some logic errors when sending comment notifications
The old code assumed that the active user was also the author of the respective comment, but this is not guaranteed.
Marcel Werk [Mon, 17 Jul 2023 16:17:39 +0000 (18:17 +0200)]
Fix typo
Alexander Ebert [Mon, 17 Jul 2023 16:06:53 +0000 (18:06 +0200)]
Fix a typo in the style variable value
Alexander Ebert [Mon, 17 Jul 2023 15:53:44 +0000 (17:53 +0200)]
Release 6.0.0 Alpha 6
WoltLab [Mon, 17 Jul 2023 15:43:26 +0000 (15:43 +0000)]
Updating minified JavaScript files
Alexander Ebert [Mon, 17 Jul 2023 15:40:58 +0000 (17:40 +0200)]
Merge pull request #5588 from WoltLab/ckeditor-image-resize
Add image resize support in CKEditor
Alexander Ebert [Mon, 17 Jul 2023 15:34:31 +0000 (17:34 +0200)]
Update the CKEditor 5 bundle
Alexander Ebert [Mon, 17 Jul 2023 11:46:24 +0000 (13:46 +0200)]
Fix the positioning of tooltips
Fixes #5575
Alexander Ebert [Mon, 17 Jul 2023 11:31:02 +0000 (13:31 +0200)]
Fix the installation through the projects
Alexander Ebert [Mon, 17 Jul 2023 11:25:41 +0000 (13:25 +0200)]
Fix the image resizing of aligned images
Alexander Ebert [Mon, 17 Jul 2023 11:19:19 +0000 (13:19 +0200)]
Fix a typo
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Alexander Ebert [Mon, 17 Jul 2023 11:17:27 +0000 (13:17 +0200)]
Clean up the code
Alexander Ebert [Fri, 14 Jul 2023 16:08:57 +0000 (18:08 +0200)]
Add resize support for attachments
Alexander Ebert [Fri, 14 Jul 2023 14:34:15 +0000 (16:34 +0200)]
Add support for resizable attachments
Alexander Ebert [Mon, 17 Jul 2023 10:26:20 +0000 (12:26 +0200)]
Merge pull request #5587 from WoltLab/attachment-bbcode-refactor
Refactor `AttachmentBBCode`
Alexander Ebert [Fri, 14 Jul 2023 16:34:01 +0000 (18:34 +0200)]
Invert the logic by short-circuiting for thumbnails
Alexander Ebert [Fri, 14 Jul 2023 16:29:19 +0000 (18:29 +0200)]
Simplify the handling of the alignment CSS classes
Alexander Ebert [Fri, 14 Jul 2023 15:35:55 +0000 (17:35 +0200)]
Slightly improve the consistency of HTML generation
Alexander Ebert [Fri, 14 Jul 2023 15:21:05 +0000 (17:21 +0200)]
Use short circuits and replace large string concats with `\sprintf()`
Alexander Ebert [Fri, 14 Jul 2023 14:55:34 +0000 (16:55 +0200)]
Split the `getParsedTag()` method into specific functions
Alexander Ebert [Fri, 14 Jul 2023 14:39:24 +0000 (16:39 +0200)]
Remove long deprecated support for external object lists
This features was deprecated 9 years ago in https://github.com/WoltLab/WCF/commit/
0a2b09a2d0d914887eedf43d02328add19ec4216
Tim Düsterhus [Fri, 14 Jul 2023 12:58:23 +0000 (14:58 +0200)]
Merge pull request #5586 from WoltLab/package-installation-submit-ux
Improve the UX around submitting package installation requests
Tim Düsterhus [Fri, 14 Jul 2023 12:20:46 +0000 (14:20 +0200)]
Show the regular AJAX status in package installation until the first request goes through
Until the first request goes through, nothing is visible, as the dialog is not
yet spawned. Show the regular AJAX status to improve the UX.
Tim Düsterhus [Fri, 14 Jul 2023 12:20:08 +0000 (14:20 +0200)]
Disable submit button in package installation confirmation after clicking
It might take a while for the request to go through and the admin should not
click twice.
Marcel Werk [Fri, 14 Jul 2023 11:20:06 +0000 (13:20 +0200)]
Merge pull request #5584 from WoltLab/reset-date-selection-ui
Improve UI of the reset button in the date picker
Tim Düsterhus [Fri, 14 Jul 2023 08:33:11 +0000 (10:33 +0200)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Fri, 14 Jul 2023 08:32:14 +0000 (10:32 +0200)]
Merge branch '5.5'
Tim Düsterhus [Fri, 14 Jul 2023 08:28:50 +0000 (10:28 +0200)]
Fix truncation of Unicode string query parameters in Benchmark
This needs to use `mb_substr()`, as we checked UTF-8 validity before to use
`UNHEX()` with binary strings. Previously UTF-8 sequences might've been cut
short and the resulting invalid sequence cannot be JSON encoded, as JSON
requires strings to be valid UTF-8.
see https://www.woltlab.com/community/thread/298853-schwer-reproduzierbar-fehlermeldungen-beim-importieren-von-sprachdateien/
Marcel Werk [Thu, 13 Jul 2023 16:43:38 +0000 (18:43 +0200)]
Remove obsolete code
Marcel Werk [Thu, 13 Jul 2023 16:27:50 +0000 (18:27 +0200)]
Improve UI of the reset button in the date picker
Alexander Ebert [Thu, 13 Jul 2023 14:27:43 +0000 (16:27 +0200)]
Merge pull request #5577 from WoltLab/unbundle-ckeditor
Defer loading of CKEditor and unbundle its components for the accelerated guest view
Alexander Ebert [Thu, 13 Jul 2023 14:23:15 +0000 (16:23 +0200)]
Merge pull request #5581 from WoltLab/newsfeed-loading
Improve the loading experience of the newsfeed in dark mode
Alexander Ebert [Thu, 13 Jul 2023 14:18:52 +0000 (16:18 +0200)]
Improve the behavior on mobile, use the loading indicator component
Alexander Ebert [Thu, 13 Jul 2023 13:59:16 +0000 (15:59 +0200)]
Merge pull request #5578 from WoltLab/light-mode-contrast
Improve the contrast of colors in the light mode
Alexander Ebert [Thu, 13 Jul 2023 13:58:52 +0000 (15:58 +0200)]
Slightly increase the size of buttons and inputs on touch devices
See https://www.woltlab.com/community/thread/300621-input-height-mobile-device/
Marcel Werk [Thu, 13 Jul 2023 13:50:19 +0000 (15:50 +0200)]
Merge pull request #5583 from WoltLab/url-detection
Improve detection of URL in texts
Marcel Werk [Thu, 13 Jul 2023 13:48:13 +0000 (15:48 +0200)]
Limit URL detection to http(s) protokoll
Marcel Werk [Thu, 13 Jul 2023 13:40:53 +0000 (15:40 +0200)]
Apply suggestions from code review
Marcel Werk [Thu, 13 Jul 2023 13:25:14 +0000 (15:25 +0200)]
Improve detection of URL in texts
Tim Düsterhus [Thu, 13 Jul 2023 12:59:39 +0000 (14:59 +0200)]
Improve the loading experience of the newsfeed in dark mode
The default page of an `<iframe>` is `about:blank` which has a light background
color. In case the newsfeed loads slowly or fails to load entirely, there will
be a big white block in a dark mode ACP which looks odd.
Fix this issue by setting the `<iframe>` to be `visibility: hidden` until the
contents are available. Additionally a spinner is shown while the iframe is
hidden.
Tim Düsterhus [Thu, 13 Jul 2023 10:02:37 +0000 (12:02 +0200)]
Merge pull request #5579 from WoltLab/return-symbol
Use correct character for return key in phrases
Tim Düsterhus [Thu, 13 Jul 2023 09:51:32 +0000 (11:51 +0200)]
Use correct character for return key in phrases
Per https://en.wikipedia.org/wiki/Enter_key#Keyboard_symbols:
> The return key symbol is U+23CE ⏎ RETURN SYMBOL, an arrow pointing down and
> leftward;
Tim Düsterhus [Thu, 13 Jul 2023 07:58:35 +0000 (09:58 +0200)]
Add dummy definition file for `ckeditor5-bundle` module
This prevents TypeScript from complaining about a non-existent module when
dynamically loading it for the definitions of the globals.
Marcel Werk [Wed, 12 Jul 2023 15:59:23 +0000 (17:59 +0200)]
Change icon for the notification to solid version
This will bring the icon more in line with the other icons in the user panel.
Alexander Ebert [Wed, 12 Jul 2023 15:46:40 +0000 (17:46 +0200)]
Update the default colors
Alexander Ebert [Mon, 10 Jul 2023 09:55:14 +0000 (11:55 +0200)]
Improve the color contrast of badges
Alexander Ebert [Fri, 7 Jul 2023 15:29:49 +0000 (17:29 +0200)]
Improve the color contrast in the light mode
Alexander Ebert [Wed, 12 Jul 2023 15:29:20 +0000 (17:29 +0200)]
Remove CKEditor components from the tiny bundle
Alexander Ebert [Wed, 12 Jul 2023 15:23:48 +0000 (17:23 +0200)]
Defer loading of the CKEditor bundle until it is first requested
Alexander Ebert [Wed, 12 Jul 2023 14:21:02 +0000 (16:21 +0200)]
Restructure the toolbar a bit
Alexander Ebert [Wed, 12 Jul 2023 14:09:56 +0000 (16:09 +0200)]
Force the button separators to cover the entire height
Alexander Ebert [Wed, 12 Jul 2023 14:06:52 +0000 (16:06 +0200)]
Improve the appearance of split buttons
Tim Düsterhus [Wed, 12 Jul 2023 13:48:21 +0000 (15:48 +0200)]
Add PHP 8.3 to the php.yml workflow
Alexander Ebert [Wed, 12 Jul 2023 11:49:15 +0000 (13:49 +0200)]
Add some margin around spoilers
Alexander Ebert [Tue, 11 Jul 2023 15:50:00 +0000 (17:50 +0200)]
Increase the top gap of quotes to separate them from preceding content
Marcel Werk [Tue, 11 Jul 2023 14:06:08 +0000 (16:06 +0200)]
Merge pull request #5574 from WoltLab/language-selector-icons
Add icons to the mobile version of the language selector
Marcel Werk [Tue, 11 Jul 2023 13:59:48 +0000 (15:59 +0200)]
Fix javascript error when you click on the language selector in the mobile menu