GitHub/WoltLab/WCF.git
14 months agoMake LicensePage::$licenseNumber a string
Tim Düsterhus [Thu, 21 Sep 2023 10:23:06 +0000 (12:23 +0200)]
Make LicensePage::$licenseNumber a string

While the licenseNumber is numeric, it is not used as an integer: No
mathematical operations are to be performed on it. Change the type to a string
to make the purpose clear.

14 months agoUpdate composer dependencies
Tim Düsterhus [Thu, 21 Sep 2023 07:44:10 +0000 (09:44 +0200)]
Update composer dependencies

14 months agoRequire an icon to be returned for the user menu item
Alexander Ebert [Wed, 20 Sep 2023 13:26:23 +0000 (15:26 +0200)]
Require an icon to be returned for the user menu item

All code paths already guarantee an icon and the template unconditionally accesses the icon anyway.

14 months agoMove the icon property initialization into the constructor
Alexander Ebert [Wed, 20 Sep 2023 13:17:51 +0000 (15:17 +0200)]
Move the icon property initialization into the constructor

14 months agoSimplify the logic to determine the icon of a user menu item
Alexander Ebert [Wed, 20 Sep 2023 13:13:27 +0000 (15:13 +0200)]
Simplify the logic to determine the icon of a user menu item

14 months agoAdd a dynamic override for user menu item icons
Alexander Ebert [Wed, 20 Sep 2023 13:10:50 +0000 (15:10 +0200)]
Add a dynamic override for user menu item icons

See https://www.woltlab.com/community/thread/301652-brand-icons-in-usermenu-xml-verwenden/

14 months agoFix the support for Font Awesome icons in `userMenu.xml`
Alexander Ebert [Wed, 20 Sep 2023 11:50:19 +0000 (13:50 +0200)]
Fix the support for Font Awesome icons in `userMenu.xml`

14 months agoRevert "Add support for brand icons for `userMenu.xml`"
Alexander Ebert [Wed, 20 Sep 2023 11:45:04 +0000 (13:45 +0200)]
Revert "Add support for brand icons for `userMenu.xml`"

This reverts commit c5391e07cf9f5cc24245b79d7f0c660b13e7a2f2.

14 months agoFix the visuals of the color picker
Alexander Ebert [Wed, 20 Sep 2023 10:32:59 +0000 (12:32 +0200)]
Fix the visuals of the color picker

See https://www.woltlab.com/community/thread/301686-stileditor-farben-mit-seltsamen-hovereffekt/

14 months agoRemove the accidental assignment of `$trophies`
Alexander Ebert [Tue, 19 Sep 2023 15:26:45 +0000 (17:26 +0200)]
Remove the accidental assignment of `$trophies`

14 months agoRedirect back to the license page after installing a package
Alexander Ebert [Tue, 19 Sep 2023 15:23:04 +0000 (17:23 +0200)]
Redirect back to the license page after installing a package

See https://www.woltlab.com/community/thread/301678-acp-lizenzierte-produkte-plugins-installieren/

14 months agoFix the background color of marked media items
Alexander Ebert [Tue, 19 Sep 2023 14:56:48 +0000 (16:56 +0200)]
Fix the background color of marked media items

See https://www.woltlab.com/community/thread/301680-overlayfarbe-medienauswahl/

14 months agoFix the “Insert Media” button for HTML and template content
Alexander Ebert [Tue, 19 Sep 2023 14:53:05 +0000 (16:53 +0200)]
Fix the “Insert Media” button for HTML and template content

See https://www.woltlab.com/community/thread/301681-medien-einf%C3%BCgen-im-acp-funktioniert-nicht/

14 months agoFilter out special trophies that no longer exist
Alexander Ebert [Tue, 19 Sep 2023 13:35:43 +0000 (15:35 +0200)]
Filter out special trophies that no longer exist

See https://www.woltlab.com/community/thread/301663-attempt-to-read-property-showorder-on-null/

14 months agoAdd support for `<button>` inside `.dropdownMenu`
Alexander Ebert [Sat, 16 Sep 2023 13:34:02 +0000 (15:34 +0200)]
Add support for `<button>` inside `.dropdownMenu`

14 months agoFix the appearance of the search reset button
Alexander Ebert [Tue, 19 Sep 2023 12:22:39 +0000 (14:22 +0200)]
Fix the appearance of the search reset button

See https://www.woltlab.com/community/thread/301671-bildauswahl-boxen/

14 months agoImprove the visuals and accessibility of the media image widget
Alexander Ebert [Tue, 19 Sep 2023 12:21:32 +0000 (14:21 +0200)]
Improve the visuals and accessibility of the media image widget

See https://www.woltlab.com/community/thread/301671-bildauswahl-boxen/

14 months agoRename `WebComponents.js` to `.min.js`
Alexander Ebert [Tue, 19 Sep 2023 11:59:59 +0000 (13:59 +0200)]
Rename `WebComponents.js` to `.min.js`

This change prevents CDNs from attempting to minify a file that is already minified.

See https://www.woltlab.com/community/thread/301662-icons-are-not-displayed/

14 months agoMerge branch '5.5' into 6.0
Tim Düsterhus [Tue, 19 Sep 2023 10:04:39 +0000 (12:04 +0200)]
Merge branch '5.5' into 6.0

14 months agoMerge pull request #5660 from WoltLab/mailbox-for-mailto
Tim Düsterhus [Tue, 19 Sep 2023 09:57:01 +0000 (11:57 +0200)]
Merge pull request #5660 from WoltLab/mailbox-for-mailto

Add Mailbox::getAddressForMailto()

14 months agoMerge pull request #5659 from WoltLab/preload-json-graceful
Tim Düsterhus [Tue, 19 Sep 2023 09:50:06 +0000 (11:50 +0200)]
Merge pull request #5659 from WoltLab/preload-json-graceful

Gracefully handle broken preload JSON

14 months agoUse `UserProfile::getEncodedEmail()` in `UserListPage` in ACP
Tim Düsterhus [Tue, 19 Sep 2023 09:06:23 +0000 (11:06 +0200)]
Use `UserProfile::getEncodedEmail()` in `UserListPage` in ACP

14 months agoLeverage `Mailbox::getAddressForMailto()` in `UserProfile::getEncodedEmail()`
Tim Düsterhus [Tue, 19 Sep 2023 09:05:34 +0000 (11:05 +0200)]
Leverage `Mailbox::getAddressForMailto()` in `UserProfile::getEncodedEmail()`

14 months agoAdd Mailbox::getAddressForMailto()
Tim Düsterhus [Tue, 19 Sep 2023 08:57:33 +0000 (10:57 +0200)]
Add Mailbox::getAddressForMailto()

14 months agoAdd Mailbox::splitLocalpartAndDomain()
Tim Düsterhus [Tue, 19 Sep 2023 08:57:18 +0000 (10:57 +0200)]
Add Mailbox::splitLocalpartAndDomain()

14 months agoGracefully handle broken preload JSON
Tim Düsterhus [Tue, 19 Sep 2023 07:58:44 +0000 (09:58 +0200)]
Gracefully handle broken preload JSON

see https://www.woltlab.com/community/thread/301669-was-will-mir-diese-fehlermeldung-sagen/

14 months agoFix the support for Font Awesome icons in `acpMenu.xml`
Alexander Ebert [Mon, 18 Sep 2023 18:09:57 +0000 (20:09 +0200)]
Fix the support for Font Awesome icons in `acpMenu.xml`

See https://www.woltlab.com/community/thread/301641-entwickler-werkzeuge-acpmenu-icons-machen-acp-kaputt/

14 months agoAdd support for brand icons for `userMenu.xml`
Alexander Ebert [Mon, 18 Sep 2023 17:24:06 +0000 (19:24 +0200)]
Add support for brand icons for `userMenu.xml`

See https://www.woltlab.com/community/thread/301652-brand-icons-in-usemenu-xml-verwenden/

14 months agoRelease 5.5.16 5.5.16
Alexander Ebert [Mon, 18 Sep 2023 13:11:08 +0000 (15:11 +0200)]
Release 5.5.16

14 months agoUpdating minified JavaScript files
WoltLab [Mon, 18 Sep 2023 13:08:56 +0000 (13:08 +0000)]
Updating minified JavaScript files

14 months agoMerge branch '5.4' into 5.5
Alexander Ebert [Mon, 18 Sep 2023 13:07:28 +0000 (15:07 +0200)]
Merge branch '5.4' into 5.5

14 months agoRelease 5.4.32 5.4.32
Alexander Ebert [Mon, 18 Sep 2023 12:22:14 +0000 (14:22 +0200)]
Release 5.4.32

14 months agoImprove the visuals of outstanding updates
Alexander Ebert [Mon, 18 Sep 2023 12:15:08 +0000 (14:15 +0200)]
Improve the visuals of outstanding updates

14 months agoMerge pull request #5658 from WoltLab/html-output-href-validation
Tim Düsterhus [Mon, 18 Sep 2023 10:48:54 +0000 (12:48 +0200)]
Merge pull request #5658 from WoltLab/html-output-href-validation

Properly handle malformed URIs in HtmlOutputNodeA

14 months agoRemove useless emptyness checks in HtmlOutputNodeA
Tim Düsterhus [Mon, 18 Sep 2023 09:54:18 +0000 (11:54 +0200)]
Remove useless emptyness checks in HtmlOutputNodeA

`$value` is guaranteed to be non-empty at this point.

14 months agoDisallow empty link values in HtmlOutputNodeA
Tim Düsterhus [Mon, 18 Sep 2023 09:53:40 +0000 (11:53 +0200)]
Disallow empty link values in HtmlOutputNodeA

14 months agoProperly handle malformed URIs in HtmlOutputNodeA
Tim Düsterhus [Mon, 18 Sep 2023 09:50:55 +0000 (11:50 +0200)]
Properly handle malformed URIs in HtmlOutputNodeA

14 months agoFix the return type of `getParentNode()`
Alexander Ebert [Sat, 16 Sep 2023 16:46:20 +0000 (18:46 +0200)]
Fix the return type of `getParentNode()`

See https://www.woltlab.com/community/thread/301636-pagenode-getparentnode-wirft-fehler-wenn-parentnode-null/

14 months agoSkip the filter initialization if there are no projects
Alexander Ebert [Sat, 16 Sep 2023 16:45:07 +0000 (18:45 +0200)]
Skip the filter initialization if there are no projects

See https://www.woltlab.com/community/thread/301637-js-fehler-in-entwickler-werkzeuge-wenn-kein-projekt-vorhanden-ist/

14 months agoTrim the description of a style package to 255 characters
Alexander Ebert [Sat, 16 Sep 2023 12:29:07 +0000 (14:29 +0200)]
Trim the description of a style package to 255 characters

See https://www.woltlab.com/community/thread/301562-fehler-bei-zu-langem-text-in-der-stilbeschreibung/

14 months agoUse `wheneverSeen()` to allow elements being reinitialized
Alexander Ebert [Sat, 16 Sep 2023 12:24:46 +0000 (14:24 +0200)]
Use `wheneverSeen()` to allow elements being reinitialized

14 months agoUse distinct variables for the time only mode
Alexander Ebert [Sat, 16 Sep 2023 10:32:40 +0000 (12:32 +0200)]
Use distinct variables for the time only mode

See https://www.woltlab.com/community/thread/301628-the-time-selector-tooltip-message-needs-to-be-fixed/

14 months agoRefresh the internal data of cached reactions
Alexander Ebert [Sat, 16 Sep 2023 10:22:42 +0000 (12:22 +0200)]
Refresh the internal data of cached reactions

See https://www.woltlab.com/community/thread/301627-when-changing-the-reaction-image-the-file-is-not-updated-in-the-dashboard/

14 months agoFix the padding of the style changer on large screens
Alexander Ebert [Sat, 16 Sep 2023 10:18:20 +0000 (12:18 +0200)]
Fix the padding of the style changer on large screens

See https://www.woltlab.com/community/thread/301626-stilauswahl-im-footer-hat-falsches-padding/

14 months agoFix the visuals of the style list
Alexander Ebert [Sat, 16 Sep 2023 10:15:32 +0000 (12:15 +0200)]
Fix the visuals of the style list

See https://www.woltlab.com/community/thread/301624-stil-liste-im-acp-layoutfehler-rc1/

14 months agoMake a dummy change to TypeScript to test the d.ts exporter
Tim Düsterhus [Fri, 15 Sep 2023 14:04:24 +0000 (16:04 +0200)]
Make a dummy change to TypeScript to test the d.ts exporter

14 months agoActivate 6.0 in d.ts exporter
Tim Düsterhus [Fri, 15 Sep 2023 13:59:02 +0000 (15:59 +0200)]
Activate 6.0 in d.ts exporter

14 months agoAdd 6.0 branch to GHA workflows
Tim Düsterhus [Fri, 15 Sep 2023 13:48:40 +0000 (15:48 +0200)]
Add 6.0 branch to GHA workflows

14 months agoRelease 6.0.0 RC 1 6.0.0_RC_1
Alexander Ebert [Fri, 15 Sep 2023 11:49:54 +0000 (13:49 +0200)]
Release 6.0.0 RC 1

14 months agoUpdating minified JavaScript files
WoltLab [Fri, 15 Sep 2023 11:45:08 +0000 (11:45 +0000)]
Updating minified JavaScript files

14 months agoUpdate the CKEditor 5 bundle
Alexander Ebert [Fri, 15 Sep 2023 09:52:18 +0000 (11:52 +0200)]
Update the CKEditor 5 bundle

14 months agoMerge pull request #5655 from Cyperghost/bugifx/ckeditor-confi
Alexander Ebert [Fri, 15 Sep 2023 09:51:55 +0000 (11:51 +0200)]
Merge pull request #5655 from Cyperghost/bugifx/ckeditor-confi

Insert extraPlugins as empty array

14 months agoReset `WCF::AVAILABLE_UPGRADE_VERSION` for 6.0
Tim Düsterhus [Fri, 15 Sep 2023 09:00:06 +0000 (11:00 +0200)]
Reset `WCF::AVAILABLE_UPGRADE_VERSION` for 6.0

14 months agoMerge branch '5.5'
Tim Düsterhus [Fri, 15 Sep 2023 08:58:57 +0000 (10:58 +0200)]
Merge branch '5.5'

14 months agoUpdate `@types` dependencies
Tim Düsterhus [Fri, 15 Sep 2023 08:52:36 +0000 (10:52 +0200)]
Update `@types` dependencies

14 months agoInsert extraPlugins as empty array
Olaf Braun [Fri, 15 Sep 2023 06:40:32 +0000 (08:40 +0200)]
Insert extraPlugins as empty array

14 months agoUpdate the woltlab/editor npm dependency
Tim Düsterhus [Thu, 14 Sep 2023 14:24:55 +0000 (16:24 +0200)]
Update the woltlab/editor npm dependency

14 months agoFix the apt invocation in d-ts.yml
Tim Düsterhus [Thu, 14 Sep 2023 14:12:00 +0000 (16:12 +0200)]
Fix the apt invocation in d-ts.yml

14 months agoSync the package.json dependencies in d-ts.yml
Tim Düsterhus [Thu, 14 Sep 2023 14:10:37 +0000 (16:10 +0200)]
Sync the package.json dependencies in d-ts.yml

14 months agoMove the woltlab/* dependencies from devDependencies to dependencies
Tim Düsterhus [Thu, 14 Sep 2023 13:58:09 +0000 (15:58 +0200)]
Move the woltlab/* dependencies from devDependencies to dependencies

14 months agoUpdate the woltlab/editor npm dependency
Tim Düsterhus [Thu, 14 Sep 2023 13:46:30 +0000 (15:46 +0200)]
Update the woltlab/editor npm dependency

This drops quite a few second-level dependencies.

14 months agoMerge pull request #5654 from WoltLab/date-picker-whenverfirstseen
Tim Düsterhus [Thu, 14 Sep 2023 13:16:54 +0000 (15:16 +0200)]
Merge pull request #5654 from WoltLab/date-picker-whenverfirstseen

Migrate from DomChangeListener to `wheneverFirstSeen()` for Date/Picker

14 months agoMigrate from DomChangeListener to `wheneverFirstSeen()` for Date/Picker
Tim Düsterhus [Thu, 14 Sep 2023 13:02:43 +0000 (15:02 +0200)]
Migrate from DomChangeListener to `wheneverFirstSeen()` for Date/Picker

see https://www.woltlab.com/community/thread/301605-formbuilder-via-dialogfactory-l%C3%A4dt-dateformfield-falsch/

14 months agoMerge pull request #5653 from WoltLab/ckeditor5-typings
Alexander Ebert [Thu, 14 Sep 2023 12:57:46 +0000 (14:57 +0200)]
Merge pull request #5653 from WoltLab/ckeditor5-typings

Use the exported typings of the editor

14 months agoUpdate the CKEditor5 bundle
Alexander Ebert [Thu, 14 Sep 2023 12:54:46 +0000 (14:54 +0200)]
Update the CKEditor5 bundle

14 months agoFix the name of the editor library
Alexander Ebert [Thu, 14 Sep 2023 12:54:11 +0000 (14:54 +0200)]
Fix the name of the editor library

14 months agoUse an explicit `type` import
Alexander Ebert [Thu, 14 Sep 2023 11:55:53 +0000 (13:55 +0200)]
Use an explicit `type` import

14 months agoUse the exported typings of the editor
Alexander Ebert [Thu, 14 Sep 2023 11:52:33 +0000 (13:52 +0200)]
Use the exported typings of the editor

14 months agoFix the reference to `setTimeout()`
Alexander Ebert [Thu, 14 Sep 2023 09:59:01 +0000 (11:59 +0200)]
Fix the reference to `setTimeout()`

14 months agoMerge pull request #5652 from WoltLab/ckeditor5-export-modules
Alexander Ebert [Thu, 14 Sep 2023 09:55:15 +0000 (11:55 +0200)]
Merge pull request #5652 from WoltLab/ckeditor5-export-modules

Expose all bundled CKEditor5 modules

14 months agoFix search issue when some types are not accessible
Marcel Werk [Wed, 13 Sep 2023 14:54:09 +0000 (16:54 +0200)]
Fix search issue when some types are not accessible

ref https://www.woltlab.com/community/thread/301563-suchbereich-alles-funktioniert-in-bestimmten-konstellationen-nicht/

14 months agoExpose all bundled CKEditor5 modules
Alexander Ebert [Wed, 13 Sep 2023 14:24:01 +0000 (16:24 +0200)]
Expose all bundled CKEditor5 modules

See WoltLab/editor#92

14 months agoCheck for version and date when loading PackageArchive
Tim Düsterhus [Wed, 13 Sep 2023 12:32:11 +0000 (14:32 +0200)]
Check for version and date when loading PackageArchive

Resolves #5650

14 months agoReject duplicated elements in `<packageinformation>`
Tim Düsterhus [Wed, 13 Sep 2023 12:21:42 +0000 (14:21 +0200)]
Reject duplicated elements in `<packageinformation>`

14 months agoDrop `<compatibility>` from package.xsd
Tim Düsterhus [Wed, 13 Sep 2023 11:53:46 +0000 (13:53 +0200)]
Drop `<compatibility>` from package.xsd

14 months agoExport CKEditor5 as an AMD module
Alexander Ebert [Wed, 13 Sep 2023 11:40:22 +0000 (13:40 +0200)]
Export CKEditor5 as an AMD module

See WoltLab/editor#91

14 months agoFix the `WCF.Label.ACPList` namespace
Alexander Ebert [Wed, 13 Sep 2023 11:34:00 +0000 (13:34 +0200)]
Fix the `WCF.Label.ACPList` namespace

14 months agoFix the color of the CKEditor logo
Alexander Ebert [Tue, 12 Sep 2023 15:53:36 +0000 (17:53 +0200)]
Fix the color of the CKEditor logo

14 months agoAdd missing `menuItem` PIP to update instructions from 5.5
Tim Düsterhus [Tue, 12 Sep 2023 11:23:22 +0000 (13:23 +0200)]
Add missing `menuItem` PIP to update instructions from 5.5

14 months agoUpdate files_pre_check.tar
Tim Düsterhus [Tue, 12 Sep 2023 11:19:57 +0000 (13:19 +0200)]
Update files_pre_check.tar

14 months agoEnable the update server check when upgrading from 5.5
Tim Düsterhus [Tue, 12 Sep 2023 11:15:42 +0000 (13:15 +0200)]
Enable the update server check when upgrading from 5.5

14 months agoRevert "Remove the preliminary upgrade instructions from 5.5"
Tim Düsterhus [Tue, 12 Sep 2023 11:15:27 +0000 (13:15 +0200)]
Revert "Remove the preliminary upgrade instructions from 5.5"

This reverts commit b600a2611491aa9c16891d2c5ffbdc1a005591c9.

14 months agoUpdate fileDelete.xml
Tim Düsterhus [Tue, 12 Sep 2023 11:14:54 +0000 (13:14 +0200)]
Update fileDelete.xml

14 months agoFix error message in PackageArchive::extractTar()
Tim Düsterhus [Fri, 8 Sep 2023 13:17:36 +0000 (15:17 +0200)]
Fix error message in PackageArchive::extractTar()

The two archive names were swapped.

14 months agoEnforce the width of the first column of `.boxN`
Alexander Ebert [Tue, 12 Sep 2023 10:20:07 +0000 (12:20 +0200)]
Enforce the width of the first column of `.boxN`

See https://www.woltlab.com/community/thread/301575-plugin-store-icons-in-boxen-zu-breit/

14 months agoFix the style variable value for `individualScssDarkMode`
Alexander Ebert [Mon, 11 Sep 2023 17:47:04 +0000 (19:47 +0200)]
Fix the style variable value for `individualScssDarkMode`

14 months agoMerge pull request #5649 from WoltLab/experimental-upgrade
Alexander Ebert [Mon, 11 Sep 2023 17:11:30 +0000 (19:11 +0200)]
Merge pull request #5649 from WoltLab/experimental-upgrade

Enable the experimental upgrade to 6.0

14 months agoPermit insecure access to the package servers for 5.5
Alexander Ebert [Mon, 11 Sep 2023 15:13:04 +0000 (17:13 +0200)]
Permit insecure access to the package servers for 5.5

14 months agoRemove obsolete / deprecated code
Marcel Werk [Mon, 11 Sep 2023 15:00:16 +0000 (17:00 +0200)]
Remove obsolete / deprecated code

14 months agoStop caring about PHP 7.2/7.3
Alexander Ebert [Mon, 11 Sep 2023 13:29:39 +0000 (15:29 +0200)]
Stop caring about PHP 7.2/7.3

14 months agoAdd checks for `Memcached` and the attachment storage
Alexander Ebert [Mon, 11 Sep 2023 13:27:08 +0000 (15:27 +0200)]
Add checks for `Memcached` and the attachment storage

14 months agoAdd the license agreement for CKEditor 5
Alexander Ebert [Mon, 11 Sep 2023 12:16:50 +0000 (14:16 +0200)]
Add the license agreement for CKEditor 5

14 months agoAdd a check for legacy multi domain setups
Alexander Ebert [Mon, 11 Sep 2023 12:12:40 +0000 (14:12 +0200)]
Add a check for legacy multi domain setups

14 months agoAdd support for the test upgrade from 5.5 to 6.0
Alexander Ebert [Mon, 11 Sep 2023 12:08:35 +0000 (14:08 +0200)]
Add support for the test upgrade from 5.5 to 6.0

14 months agoUpdate the pre-upgrade checks for 6.0
Alexander Ebert [Mon, 11 Sep 2023 12:05:17 +0000 (14:05 +0200)]
Update the pre-upgrade checks for 6.0

14 months agoRemove obsolete `__sidebarLeftHasMenu` parameter
Marcel Werk [Mon, 11 Sep 2023 10:15:17 +0000 (12:15 +0200)]
Remove obsolete `__sidebarLeftHasMenu` parameter

The notification list doesn't have a left sidebar anymore.

14 months agoAdjust event name to match the naming scheme
Marcel Werk [Mon, 11 Sep 2023 09:00:08 +0000 (11:00 +0200)]
Adjust event name to match the naming scheme

14 months agoMerge pull request #5648 from WoltLab/resolve-current-page-event
Marcel Werk [Mon, 11 Sep 2023 08:34:21 +0000 (10:34 +0200)]
Merge pull request #5648 from WoltLab/resolve-current-page-event

Add event for resolving the active page

14 months agoAdd the missing border to the rich embeds
Alexander Ebert [Sun, 10 Sep 2023 14:05:09 +0000 (16:05 +0200)]
Add the missing border to the rich embeds

Fixes #5646

14 months agoAdd event for resolving the active page
Marcel Werk [Sun, 10 Sep 2023 13:55:07 +0000 (15:55 +0200)]
Add event for resolving the active page

This event allows to add custom logic for resolving the active page.