GitHub/WoltLab/WCF.git
2 years agoMerge branch '5.5'
Tim Düsterhus [Fri, 13 May 2022 07:20:20 +0000 (09:20 +0200)]
Merge branch '5.5'

2 years agoMerge pull request #4799 from WoltLab/wcf-force-logout
Tim Düsterhus [Fri, 13 May 2022 07:18:52 +0000 (09:18 +0200)]
Merge pull request #4799 from WoltLab/wcf-force-logout

Immediately destroy the session for banned users

2 years agoMerge pull request #4795 from WoltLab/mb-strpos
Tim Düsterhus [Fri, 13 May 2022 07:17:25 +0000 (09:17 +0200)]
Merge pull request #4795 from WoltLab/mb-strpos

Remove unneeded usage of `mb_strpos`

2 years agoMerge pull request #4786 from WoltLab/remove-x-frame-options
Tim Düsterhus [Fri, 13 May 2022 07:17:06 +0000 (09:17 +0200)]
Merge pull request #4786 from WoltLab/remove-x-frame-options

Always send `x-frame-options`

2 years agoMerge pull request #4793 from WoltLab/error-500
Tim Düsterhus [Fri, 13 May 2022 07:16:43 +0000 (09:16 +0200)]
Merge pull request #4793 from WoltLab/error-500

Use HTTP 500 in error conditions

2 years agoMerge pull request #4794 from WoltLab/wcfacp-initPackage
Tim Düsterhus [Fri, 13 May 2022 07:16:25 +0000 (09:16 +0200)]
Merge pull request #4794 from WoltLab/wcfacp-initPackage

Remove obsolete WCFACP::initPackage()

2 years agoMerge pull request #4796 from WoltLab/canonical-url-s-parameter
Tim Düsterhus [Fri, 13 May 2022 07:16:14 +0000 (09:16 +0200)]
Merge pull request #4796 from WoltLab/canonical-url-s-parameter

Remove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL

2 years agoMerge pull request #4788 from WoltLab/template-modifier-allowlist
Tim Düsterhus [Fri, 13 May 2022 07:16:00 +0000 (09:16 +0200)]
Merge pull request #4788 from WoltLab/template-modifier-allowlist

Always restrict valid template modifiers to an allow list

2 years agoImmediately destroy the session for banned users
Tim Düsterhus [Thu, 12 May 2022 15:16:54 +0000 (17:16 +0200)]
Immediately destroy the session for banned users

The forced logout for banned users was introduced in
ab84d9cab2f864c23f0b18dbeb67e7ea79b1fe9f and only destroyed the session during
shutdown.

At the point where this check runs the request effectively is fully booted up
and in any case the NamedUserException would abort any further booting, thus it
is safe to simply destroy the session immediately to keep all the necessary
logic in a single location.

2 years agoUse `->prepare()` instead of `->prepareStatement()` in SessionHandler
Tim Düsterhus [Thu, 12 May 2022 15:13:13 +0000 (17:13 +0200)]
Use `->prepare()` instead of `->prepareStatement()` in SessionHandler

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 14:08:05 +0000 (16:08 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge pull request #4798 from pehbeh/patch-1
Tim Düsterhus [Thu, 12 May 2022 13:38:20 +0000 (15:38 +0200)]
Merge pull request #4798 from pehbeh/patch-1

Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoMerge pull request #4797 from WoltLab/mysql-requirements
Tim Düsterhus [Thu, 12 May 2022 13:38:04 +0000 (15:38 +0200)]
Merge pull request #4797 from WoltLab/mysql-requirements

Increase minimum MySQL version to 8.0.29 / MariaDB 10.5.12

2 years agoIncrease minimum MySQL version to 8.0.29 / MariaDB 10.5.12
Tim Düsterhus [Thu, 12 May 2022 13:31:52 +0000 (15:31 +0200)]
Increase minimum MySQL version to 8.0.29 / MariaDB 10.5.12

2 years agoUpdate URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
pehbeh [Thu, 12 May 2022 13:31:54 +0000 (15:31 +0200)]
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoRemove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL
Tim Düsterhus [Thu, 12 May 2022 13:19:14 +0000 (15:19 +0200)]
Remove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL

2 years agoRemove unneeded usage of `mb_strpos`
Tim Düsterhus [Thu, 12 May 2022 12:39:24 +0000 (14:39 +0200)]
Remove unneeded usage of `mb_strpos`

If the return value of `mb_strpos` is only compared to `false` then there is no
need to use the multibyte engine, instead `str_contains()` does example the
same and is clearer.

The same applies if the return value is compared to `0`, in this case the size
of multibyte characters cannot have affected the offset. `str_starts_with()`
can be used instead.

2 years agoMerge branch '5.5'
Tim Düsterhus [Thu, 12 May 2022 12:50:09 +0000 (14:50 +0200)]
Merge branch '5.5'

2 years agoFix incorrect use of `mb_strpos` in MysqlSearchEngine
Tim Düsterhus [Thu, 12 May 2022 12:48:06 +0000 (14:48 +0200)]
Fix incorrect use of `mb_strpos` in MysqlSearchEngine

The return value of `mb_strpos` needs to be checked type-safely, as both `0`
and `false` are falsy. In this case this likely was safe, as the inner join may
not appear at the start of the query, it was a questionable nonetheless.

Fix this by using `str_contains()` which makes the intent even clearer.

2 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Thu, 12 May 2022 11:49:18 +0000 (13:49 +0200)]
Merge remote-tracking branch 'origin/master'

2 years agoMerge branch '5.5'
Tim Düsterhus [Thu, 12 May 2022 11:48:47 +0000 (13:48 +0200)]
Merge branch '5.5'

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 11:48:37 +0000 (13:48 +0200)]
Merge branch '5.4' into 5.5

2 years agoUpdate URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl
Tim Düsterhus [Thu, 12 May 2022 11:48:13 +0000 (13:48 +0200)]
Update URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl

2 years agoMerge pull request #4792 from WoltLab/styleID-parameter
Tim Düsterhus [Thu, 12 May 2022 10:47:07 +0000 (12:47 +0200)]
Merge pull request #4792 from WoltLab/styleID-parameter

Remove the `$_REQUEST['styleID']` handling

2 years agoRemove obsolete WCFACP::initPackage()
Tim Düsterhus [Thu, 12 May 2022 10:39:18 +0000 (12:39 +0200)]
Remove obsolete WCFACP::initPackage()

Ever since WoltLab Suite Core got its own frontend the PACKAGE_ID constant
should be defined at all times, making this method obsolete.

2 years agoRemove the `$_REQUEST['styleID']` handling
Tim Düsterhus [Thu, 12 May 2022 10:29:34 +0000 (12:29 +0200)]
Remove the `$_REQUEST['styleID']` handling

Resolves #4533

2 years agoUse HTTP 500 in error conditions
Tim Düsterhus [Thu, 12 May 2022 10:32:41 +0000 (12:32 +0200)]
Use HTTP 500 in error conditions

Sending a 500 Internal Server Error for unplanned errors is more appropriate
than a 503 Service Unavailable, as the latter is defined:

RFC 7231#6.6.4:

> The 503 (Service Unavailable) status code indicates that the server
> is currently unable to handle the request due to a temporary overload
> or scheduled maintenance, which will likely be alleviated after some
> delay.

It's not likely that the exception will resolve itself after some delay.

2 years agoSimplify generation of random cookie prefix in WCFSetup
Tim Düsterhus [Thu, 12 May 2022 10:02:31 +0000 (12:02 +0200)]
Simplify generation of random cookie prefix in WCFSetup

2 years agoDrop unused constant `URL_TO_LOWERCASE` from default options.inc.php
Tim Düsterhus [Thu, 12 May 2022 09:26:11 +0000 (11:26 +0200)]
Drop unused constant `URL_TO_LOWERCASE` from default options.inc.php

The option was removed in f3aa502157efa11ac3c76e8471d69d0ac9f69f1f.

2 years agoMerge pull request #4791 from WoltLab/wcfsetup-n
Tim Düsterhus [Thu, 12 May 2022 09:15:27 +0000 (11:15 +0200)]
Merge pull request #4791 from WoltLab/wcfsetup-n

Remove the WCF_N input in WCFSetup

2 years agoRemove the WCF_N input in WCFSetup
Tim Düsterhus [Thu, 12 May 2022 09:04:02 +0000 (11:04 +0200)]
Remove the WCF_N input in WCFSetup

Users should install separate instances into separate databases for security
reasons. This also avoids issues with users running a non-standard number and
any existing guides / queries not working, because the database tables have a
different name.

2 years agoMerge branch 'header-normalize'
Tim Düsterhus [Thu, 12 May 2022 08:44:59 +0000 (10:44 +0200)]
Merge branch 'header-normalize'

2 years agoUse `Header::normalize()` in `ImageUtil::browserSupportsWebp()`
Tim Düsterhus [Wed, 11 May 2022 10:50:10 +0000 (12:50 +0200)]
Use `Header::normalize()` in `ImageUtil::browserSupportsWebp()`

see #4534

2 years agoUse `Header::normalize()` in `RequestHandler::sendPsr7Response()`
Tim Düsterhus [Wed, 11 May 2022 10:46:01 +0000 (12:46 +0200)]
Use `Header::normalize()` in `RequestHandler::sendPsr7Response()`

see #4534

2 years agoMerge branch '5.5'
Tim Düsterhus [Wed, 11 May 2022 15:06:17 +0000 (17:06 +0200)]
Merge branch '5.5'

2 years agoMerge pull request #4784 from WoltLab/require-x64
Tim Düsterhus [Wed, 11 May 2022 14:57:25 +0000 (16:57 +0200)]
Merge pull request #4784 from WoltLab/require-x64

Require 64-bit support

2 years agoMerge pull request #4783 from WoltLab/ts-target
Tim Düsterhus [Wed, 11 May 2022 14:54:27 +0000 (16:54 +0200)]
Merge pull request #4783 from WoltLab/ts-target

Target es2019 in tsconfig.json

2 years agoMerge pull request #4787 from WoltLab/user-online-list
Marcel Werk [Wed, 11 May 2022 13:06:27 +0000 (15:06 +0200)]
Merge pull request #4787 from WoltLab/user-online-list

User online statistics were invisible when all active users were invisible

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:57:23 +0000 (14:57 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:56:48 +0000 (14:56 +0200)]
Merge branch '5.3' into 5.4

2 years agoAdd the `required` attribute to the recipientID select in contact.tpl
Tim Düsterhus [Wed, 11 May 2022 12:56:09 +0000 (14:56 +0200)]
Add the `required` attribute to the recipientID select in contact.tpl

see a8490749c3ba7014380d55462fc45dd635c1d71c

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:50:53 +0000 (14:50 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:49:48 +0000 (14:49 +0200)]
Merge branch '5.3' into 5.4

2 years agoIndicate that selecting a recipient is required in contact.tpl
Tim Düsterhus [Wed, 11 May 2022 12:49:24 +0000 (14:49 +0200)]
Indicate that selecting a recipient is required in contact.tpl

2 years agoAlways restrict valid template modifiers to an allow list
Tim Düsterhus [Wed, 11 May 2022 12:32:19 +0000 (14:32 +0200)]
Always restrict valid template modifiers to an allow list

Previously this allow list was only used in enterprise mode, but it is
generally a useful security feature. Thus the allow list previously known as
`$enterpriseFunctions` is applied in call cases.

This also makes it easier for developers, as there will be less differences
between the enterprise mode and the non-enterprise mode.

As before this allow list can easily be extended if a useful function is
missing from it.

2 years agoAdd 64-bit check to update_com.woltlab.wcf_5.5_checkSystemRequirements.php
Tim Düsterhus [Wed, 11 May 2022 12:04:42 +0000 (14:04 +0200)]
Add 64-bit check to update_com.woltlab.wcf_5.5_checkSystemRequirements.php

2 years agoMerge branch 'master' into require-x64
Tim Düsterhus [Wed, 11 May 2022 12:02:52 +0000 (14:02 +0200)]
Merge branch 'master' into require-x64

2 years agoAdd update_com.woltlab.wcf_5.5_checkSystemRequirements.php
Tim Düsterhus [Wed, 11 May 2022 12:02:15 +0000 (14:02 +0200)]
Add update_com.woltlab.wcf_5.5_checkSystemRequirements.php

see 48b47a4a8ba0260d52226c80063ebac081fa719b

2 years agoApplied code suggestions
Marcel Werk [Wed, 11 May 2022 11:09:44 +0000 (13:09 +0200)]
Applied code suggestions

2 years agoShow legend only when users are listed
Marcel Werk [Wed, 11 May 2022 10:25:15 +0000 (12:25 +0200)]
Show legend only when users are listed

2 years agoAlways send `x-frame-options`
Tim Düsterhus [Wed, 11 May 2022 10:24:13 +0000 (12:24 +0200)]
Always send `x-frame-options`

Resolves #4484

2 years agoUser online statistics were invisible when all active users were invisible
Marcel Werk [Wed, 11 May 2022 10:24:06 +0000 (12:24 +0200)]
User online statistics were invisible when all active users were invisible

2 years agoDrop obsolete upgrade instructions from 5.4 to 5.5
Tim Düsterhus [Wed, 11 May 2022 09:40:37 +0000 (11:40 +0200)]
Drop obsolete upgrade instructions from 5.4 to 5.5

2 years agoMerge branch '5.5'
Tim Düsterhus [Wed, 11 May 2022 09:39:22 +0000 (11:39 +0200)]
Merge branch '5.5'

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 09:39:12 +0000 (11:39 +0200)]
Merge branch '5.4' into 5.5

2 years agoDrop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php
Tim Düsterhus [Wed, 11 May 2022 09:38:47 +0000 (11:38 +0200)]
Drop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php

2 years agoDrop obsolete fileDelete_5.5.xml
Tim Düsterhus [Wed, 11 May 2022 09:37:38 +0000 (11:37 +0200)]
Drop obsolete fileDelete_5.5.xml

2 years agoCheck for 64-bit support in SystemCheckPage
Tim Düsterhus [Wed, 11 May 2022 09:26:08 +0000 (11:26 +0200)]
Check for 64-bit support in SystemCheckPage

2 years agoRequire 64-bit PHP in WCFSetup
Tim Düsterhus [Wed, 11 May 2022 09:16:18 +0000 (11:16 +0200)]
Require 64-bit PHP in WCFSetup

see #4512

2 years agoMerge branch '5.5'
Tim Düsterhus [Wed, 11 May 2022 08:41:46 +0000 (10:41 +0200)]
Merge branch '5.5'

2 years agoFix language items in recommended section of system requirements in WCFSetup
Tim Düsterhus [Wed, 11 May 2022 08:40:35 +0000 (10:40 +0200)]
Fix language items in recommended section of system requirements in WCFSetup

see 3445cbe2a005ead9843d9e17709a915631dd11b5
see e88d06dc88bc263b7424fbccfa47c13907413b8c

2 years agoTarget es2019 in tsconfig.json
Tim Düsterhus [Wed, 11 May 2022 08:18:04 +0000 (10:18 +0200)]
Target es2019 in tsconfig.json

Resolves #4595

2 years agoRun php-cs-fixer using PHP 8.1
Tim Düsterhus [Wed, 11 May 2022 08:01:03 +0000 (10:01 +0200)]
Run php-cs-fixer using PHP 8.1

2 years agoMerge pull request #4782 from WoltLab/system-requirements
Tim Düsterhus [Wed, 11 May 2022 07:58:47 +0000 (09:58 +0200)]
Merge pull request #4782 from WoltLab/system-requirements

Increase minimum PHP requirement

2 years agoRelease 5.5.0 Beta 2 5.5.0_Beta_2
Alexander Ebert [Tue, 10 May 2022 20:58:18 +0000 (22:58 +0200)]
Release 5.5.0 Beta 2

2 years agoIncorrect dialog position on smartphones
Alexander Ebert [Tue, 10 May 2022 16:06:08 +0000 (18:06 +0200)]
Incorrect dialog position on smartphones

See https://www.woltlab.com/community/thread/295560-neues-thema-erstellen-au%C3%9Ferhalb-des-bildschirms/

2 years agoFix php.yml workflow
Tim Düsterhus [Tue, 10 May 2022 15:36:21 +0000 (17:36 +0200)]
Fix php.yml workflow

see 7cb8935ef0ef6707e0ed1cb8fe26ac17dd155400

2 years agoUpgrade laminas/laminas-httphandlerrunner to 2.1.0
Tim Düsterhus [Mon, 9 May 2022 09:04:51 +0000 (11:04 +0200)]
Upgrade laminas/laminas-httphandlerrunner to 2.1.0

2 years agoTighten up version constraints in composer.json
Tim Düsterhus [Mon, 9 May 2022 09:02:43 +0000 (11:02 +0200)]
Tighten up version constraints in composer.json

2 years agoRemove obsolete Symfony polyfills
Tim Düsterhus [Mon, 9 May 2022 09:00:44 +0000 (11:00 +0200)]
Remove obsolete Symfony polyfills

2 years agoUpdate PHP platform version in composer.json
Tim Düsterhus [Mon, 9 May 2022 09:00:13 +0000 (11:00 +0200)]
Update PHP platform version in composer.json

2 years agoRemove PHP < 8.1 from php.yml workflow
Tim Düsterhus [Mon, 9 May 2022 08:59:06 +0000 (10:59 +0200)]
Remove PHP < 8.1 from php.yml workflow

2 years agoIncrease minimum PHP version to 8.1.2
Tim Düsterhus [Mon, 9 May 2022 08:58:47 +0000 (10:58 +0200)]
Increase minimum PHP version to 8.1.2

2 years agoAdd the 5.5 branch to GitHub workflows
Tim Düsterhus [Tue, 10 May 2022 15:33:34 +0000 (17:33 +0200)]
Add the 5.5 branch to GitHub workflows

2 years agoRelease 5.5.0 Beta 1 5.5.0_Beta_1
Alexander Ebert [Tue, 10 May 2022 14:30:34 +0000 (16:30 +0200)]
Release 5.5.0 Beta 1

2 years agoRemoved the upgrade instructions from 5.4.*
Alexander Ebert [Tue, 10 May 2022 14:12:26 +0000 (16:12 +0200)]
Removed the upgrade instructions from 5.4.*

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 10 May 2022 13:53:32 +0000 (13:53 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 10 May 2022 07:26:40 +0000 (09:26 +0200)]
Merge branch '5.4'

2 years agoFix English versions of `wcf.user.security.multifactor.backup.authenticationEmail...
Tim Düsterhus [Tue, 10 May 2022 07:25:42 +0000 (09:25 +0200)]
Fix English versions of `wcf.user.security.multifactor.backup.authenticationEmail.body.*`

The phrases contained broken template scripting, due to the use of the `'`
apostroph within a single quoted string.

2 years agoDialogs could become too wide with lots of text
Alexander Ebert [Mon, 9 May 2022 13:51:17 +0000 (15:51 +0200)]
Dialogs could become too wide with lots of text

2 years agoSuppress the redundant loading indicator
Alexander Ebert [Mon, 9 May 2022 12:17:55 +0000 (14:17 +0200)]
Suppress the redundant loading indicator

See https://www.woltlab.com/community/thread/295539-doppelte-ladebalken/

2 years agoMerge pull request #4781 from WoltLab/ci-check
Tim Düsterhus [Mon, 9 May 2022 11:31:31 +0000 (13:31 +0200)]
Merge pull request #4781 from WoltLab/ci-check

Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()

2 years agoAdd fileDelete_5.5.xml
Tim Düsterhus [Mon, 9 May 2022 10:42:53 +0000 (12:42 +0200)]
Add fileDelete_5.5.xml

These files never were part of the git repository, but were accidentally
included in an upgrade package, because an unclean source directory was used
when building the upgrade.

2 years agoFlip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFile...
Tim Düsterhus [Mon, 9 May 2022 09:06:38 +0000 (11:06 +0200)]
Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()

Flipping the whole path does not provide any real benefit, because we only care
about whether the file system where WoltLab Suite resides is case sensitive or
not. It does however break when `open_basedir` is configured.

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 9 May 2022 08:49:45 +0000 (10:49 +0200)]
Merge branch '5.4'

2 years agoRemove the codestyle workflow from branches that are not master
Tim Düsterhus [Fri, 6 May 2022 13:11:45 +0000 (15:11 +0200)]
Remove the codestyle workflow from branches that are not master

2 years agoLazy loading the user’s avatar causes flashes
Alexander Ebert [Sun, 8 May 2022 11:54:02 +0000 (13:54 +0200)]
Lazy loading the user’s avatar causes flashes

Safari (macOS and iOS) does not handle lazy loaded images above the fold gracefully. This causes the user’s avatar to flicker noticeably on ever page navigation.

2 years agoMerge pull request #4779 from WoltLab/search-result-pagination
Alexander Ebert [Sun, 8 May 2022 11:42:21 +0000 (13:42 +0200)]
Merge pull request #4779 from WoltLab/search-result-pagination

Tracked the result page number in the url

2 years agoMerge pull request #4777 from WoltLab/article-comment-like-notifications
Alexander Ebert [Sun, 8 May 2022 11:38:09 +0000 (13:38 +0200)]
Merge pull request #4777 from WoltLab/article-comment-like-notifications

Notifications about reactions to article comments

2 years agoMerge pull request #4776 from WoltLab/scroll-to-comments
Alexander Ebert [Sun, 8 May 2022 11:29:21 +0000 (13:29 +0200)]
Merge pull request #4776 from WoltLab/scroll-to-comments

Scrolling to a comment not visible by default did not work

2 years agoProper prototype creation
Marcel Werk [Sat, 7 May 2022 17:11:55 +0000 (19:11 +0200)]
Proper prototype creation

2 years agoTracked the result page number in the url
Marcel Werk [Sat, 7 May 2022 17:09:50 +0000 (19:09 +0200)]
Tracked the result page number in the url

2 years agoProper history navigation for searches
Marcel Werk [Sat, 7 May 2022 16:51:22 +0000 (18:51 +0200)]
Proper history navigation for searches

2 years agoTrack the page number of search result in the url
Marcel Werk [Sat, 7 May 2022 16:38:01 +0000 (18:38 +0200)]
Track the page number of search result in the url

2 years agoVisual separator for specialized search filters
Alexander Ebert [Sat, 7 May 2022 16:13:12 +0000 (18:13 +0200)]
Visual separator for specialized search filters

See https://www.woltlab.com/community/thread/295502-kategorie-auswahl-ist-verrutscht/

2 years agoMerge branch '5.4'
Marcel Werk [Sat, 7 May 2022 15:42:08 +0000 (17:42 +0200)]
Merge branch '5.4'

2 years agoMerge branch '5.3' into 5.4
Marcel Werk [Sat, 7 May 2022 15:41:59 +0000 (17:41 +0200)]
Merge branch '5.3' into 5.4

2 years agoMerge branch '5.2' into 5.3
Marcel Werk [Sat, 7 May 2022 15:41:46 +0000 (17:41 +0200)]
Merge branch '5.2' into 5.3

2 years agoRevert "Show always an no selection option in custom select options build with the...
Marcel Werk [Sat, 7 May 2022 15:40:48 +0000 (17:40 +0200)]
Revert "Show always an no selection option in custom select options build with the OptionHandler"

This reverts commit 6fef8b82e15794eee5317e6b15bb0670f137315c.

2 years agoIncorrect margin of `.formSubmit` in dialogs
Alexander Ebert [Sat, 7 May 2022 14:59:03 +0000 (16:59 +0200)]
Incorrect margin of `.formSubmit` in dialogs

This was caused by the negative margin introduced in 1d224f10cdd05e7f5d09f869ee1fbbbdff025749 which caused the calculation to be off by 10px, causing a visible gap.

See https://www.woltlab.com/community/thread/295497-fehlerhafte-mobile-darstellung-von-dialogen/