GitHub/LineageOS/android_kernel_motorola_exynos9610.git
10 years agostaging: rtl8188eu: Remove unused function rtw_os_read_port()
navin patidar [Mon, 28 Jul 2014 17:41:29 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove unused function rtw_os_read_port()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function _addba_timer_hdl()
navin patidar [Mon, 28 Jul 2014 17:41:28 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function _addba_timer_hdl()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function _link_timer_hdl()
navin patidar [Mon, 28 Jul 2014 17:41:27 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function _link_timer_hdl()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function _survey_timer_hdl()
navin patidar [Mon, 28 Jul 2014 17:41:26 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function _survey_timer_hdl()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function _dynamic_check_timer_handlder()
navin patidar [Mon, 28 Jul 2014 17:41:25 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function _dynamic_check_timer_handlder()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function _rtw_scan_timeout_handler()
navin patidar [Mon, 28 Jul 2014 17:41:24 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function _rtw_scan_timeout_handler()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove wrapper function rtw_join_timeout_handler()
navin patidar [Mon, 28 Jul 2014 17:41:23 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove wrapper function rtw_join_timeout_handler()

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8188eu: Remove unused member MultiFunc from struct hal_data_8188e
navin patidar [Mon, 28 Jul 2014 17:41:22 +0000 (23:11 +0530)]
staging: rtl8188eu: Remove unused member MultiFunc from struct hal_data_8188e

Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: dgnc: removes unused if defined code
Seunghun Lee [Mon, 28 Jul 2014 13:51:03 +0000 (22:51 +0900)]
staging: dgnc: removes unused if defined code

DGNC_TRACER and TRC_TO_KMEM are never defined.

This patch removes if defined DGNC_TRACER and TRC_TO_KMEM code.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: checkpatch.pl fix: Indentation of case-statements fixed
Matthias Beyer [Tue, 29 Jul 2014 14:52:39 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: checkpatch.pl fix: Indentation of case-statements fixed

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: checkpatch.pl fix: Removed parentheses from return statement
Matthias Beyer [Tue, 29 Jul 2014 14:52:38 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: checkpatch.pl fix: Removed parentheses from return statement

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: checkpatch.pl fix: Transformed C99-style comments
Matthias Beyer [Tue, 29 Jul 2014 14:52:37 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: checkpatch.pl fix: Transformed C99-style comments

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: checkpatch.pl fix: Added blank lines after declarations
Matthias Beyer [Tue, 29 Jul 2014 14:52:36 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: checkpatch.pl fix: Added blank lines after declarations

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSGetPktInfo()
Matthias Beyer [Tue, 29 Jul 2014 14:52:35 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSGetPktInfo()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSClassifyPkt()
Matthias Beyer [Tue, 29 Jul 2014 14:52:34 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EThCSClassifyPkt()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchVLANRules()
Matthias Beyer [Tue, 29 Jul 2014 14:52:33 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchVLANRules()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchEThTypeSAP()
Matthias Beyer [Tue, 29 Jul 2014 14:52:32 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchEThTypeSAP()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchDestMACAdress()
Matthias Beyer [Tue, 29 Jul 2014 14:52:31 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchDestMACAdress()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchSrcMACAdress()
Matthias Beyer [Tue, 29 Jul 2014 14:52:30 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in EthCSMatchSrcMACAdress()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in ClassifyPacket()
Matthias Beyer [Tue, 29 Jul 2014 14:52:29 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in ClassifyPacket()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in flush_all_queues()
Matthias Beyer [Tue, 29 Jul 2014 14:52:28 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in flush_all_queues()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in PruneQueue()
Matthias Beyer [Tue, 29 Jul 2014 14:52:27 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in PruneQueue()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in IpVersion4()
Matthias Beyer [Tue, 29 Jul 2014 14:52:26 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in IpVersion4()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestPort()
Matthias Beyer [Tue, 29 Jul 2014 14:52:25 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestPort()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcPort()
Matthias Beyer [Tue, 29 Jul 2014 14:52:24 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcPort()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchProtocol()
Matthias Beyer [Tue, 29 Jul 2014 14:52:23 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchProtocol()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchTos()
Matthias Beyer [Tue, 29 Jul 2014 14:52:22 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchTos()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestIpAddress()
Matthias Beyer [Tue, 29 Jul 2014 14:52:21 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchDestIpAddress()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcIpAddress()
Matthias Beyer [Tue, 29 Jul 2014 14:52:20 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Line length / Whitespace cleanup in MatchSrcIpAddress()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced if-else return with ternary operator
Matthias Beyer [Tue, 29 Jul 2014 14:52:19 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced if-else return with ternary operator

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced do-while(0) breaks with continue
Matthias Beyer [Tue, 29 Jul 2014 14:52:18 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced do-while(0) breaks with continue

This patch replaces the do-while(0); loop which is used for breaking if
a check fails by using the `continue` statement. This saves one
indentation level.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced member accessing by variable in flush_all_queues()
Matthias Beyer [Tue, 29 Jul 2014 14:52:17 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced member accessing by variable in flush_all_queues()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()
Matthias Beyer [Tue, 29 Jul 2014 14:52:16 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced do-while(0) jumps with goto and label, removes one...
Matthias Beyer [Tue, 29 Jul 2014 14:52:15 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced do-while(0) jumps with goto and label, removes one level of indentation

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced member accessing with variable in MatchDestIpAddress()
Matthias Beyer [Tue, 29 Jul 2014 14:52:14 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced member accessing with variable in MatchDestIpAddress()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()
Matthias Beyer [Tue, 29 Jul 2014 14:52:13 +0000 (16:52 +0200)]
Staging: bcm: Qos.c: Replaced member accessing with variable in PruneQueue()

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Protocol.c: Line length fixes
Matthias Beyer [Tue, 29 Jul 2014 12:48:34 +0000 (14:48 +0200)]
Staging: bcm: IPv6Protocol.c: Line length fixes

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Protocol.c: Whitespace cleanup
Matthias Beyer [Tue, 29 Jul 2014 12:48:33 +0000 (14:48 +0200)]
Staging: bcm: IPv6Protocol.c: Whitespace cleanup

Removes whitespace before semicolons and add blank line after
declaration.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Protocol.c: Replaced member accessing with variable
Matthias Beyer [Tue, 29 Jul 2014 12:48:32 +0000 (14:48 +0200)]
Staging: bcm: IPv6Protocol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Procotol.c: Replaced member accessing with variable
Matthias Beyer [Tue, 29 Jul 2014 12:48:31 +0000 (14:48 +0200)]
Staging: bcm: IPv6Procotol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Protocol.c: Removed unnecessary if-else blocks
Matthias Beyer [Tue, 29 Jul 2014 12:48:30 +0000 (14:48 +0200)]
Staging: bcm: IPv6Protocol.c: Removed unnecessary if-else blocks

This patch simplifies

    if (a) {
        x = false;
    } else {
        if (b) {
            x = false;
        }
    }

to
    if (a || b) {
        x = false;
    }

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: bcm: IPv6Protocol.c: Reindented switch-case
Matthias Beyer [Tue, 29 Jul 2014 12:48:29 +0000 (14:48 +0200)]
Staging: bcm: IPv6Protocol.c: Reindented switch-case

This patch removes the unneccessary blocks inside the case statements
and fixes the indentation of their content.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: unisys: remove U8 type
Benjamin Romer [Tue, 29 Jul 2014 19:09:40 +0000 (15:09 -0400)]
staging: unisys: remove U8 type

This patch switches all use of the U8 typedef to use the kernel's u8 type
instead.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: unisys: add sysfs entries for parahotplug support
Benjamin Romer [Tue, 29 Jul 2014 15:11:21 +0000 (11:11 -0400)]
staging: unisys: add sysfs entries for parahotplug support

This patch adds new a new directory parahotplug to the visorchipset sysfs
directory, and two new attributes, deviceenabled, and devicedisabled, into the
new directory, to add s-Par parahotplug support.

The parahotplug interface is used to deal with SR-IOV recovery situations on
s-Par guest partitions. The command service partition will send a message to a
guest when an SR-IOV device that guest is using needs to be temporarily removed.
The message triggers a udev event that will cause a recovery script to run.
When that script has completed its work, it will write to one of the
parahotplug interfaces to send a message back to Command, indicating that the
recovery action has completed.

When a guest that is sharing an SR-IOV device is restarted, that guest will
take down the PF driver on the device, but any guests with VFs will not know
that their device needs to be reset as well. The recovery script makes it so
the device will be shut down fully and then restarted after the sharing guest
comes back up, and ensures that the timing is correct.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: unisys: remove parahotplug proc entry
Benjamin Romer [Tue, 29 Jul 2014 15:11:20 +0000 (11:11 -0400)]
staging: unisys: remove parahotplug proc entry

Remove the parahotplug proc code entirely in preparation for replacement with
sysfs entries. Since visorchipset_proc_read_writeonly() is orphaned by the
removal, it is removed as well.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: clean up the tail of function device_init_registers
Malcolm Priestley [Mon, 28 Jul 2014 22:26:26 +0000 (23:26 +0100)]
staging: vt6655: clean up the tail of function device_init_registers

Aligning the code.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: remove typedef enum __device_init_type
Malcolm Priestley [Mon, 28 Jul 2014 22:26:25 +0000 (23:26 +0100)]
staging: vt6655: remove typedef enum __device_init_type

The value is either DEVICE_INIT_COLD or DEVICE_INIT_DXPL making no
difference to code.

Remove typedef and remove if statement in device_init_registers
pulling the code in.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: dead code remove undefined macro IO_MAP
Malcolm Priestley [Mon, 28 Jul 2014 20:43:30 +0000 (21:43 +0100)]
staging: vt6655: dead code remove undefined macro IO_MAP

This device is always memory mapped

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: dead code remove undefined macro FOR_LED_ON_NOTEBOOK code.
Malcolm Priestley [Mon, 28 Jul 2014 20:43:29 +0000 (21:43 +0100)]
staging: vt6655: dead code remove undefined macro FOR_LED_ON_NOTEBOOK code.

Removing all variables associated with the code.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: deadcode remove undefined macro THREAD code.
Malcolm Priestley [Mon, 28 Jul 2014 20:43:28 +0000 (21:43 +0100)]
staging: vt6655: deadcode remove undefined macro THREAD code.

Removing _RxManagementQueue, InitRxManagementQueue, MlmeThread, mlme_kill,
EnQueue and DeQueue.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6655: remove undefined TASK_LET code
Malcolm Priestley [Mon, 28 Jul 2014 20:43:27 +0000 (21:43 +0100)]
staging: vt6655: remove undefined TASK_LET code

Removing all code within and function MngWorkItem.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging:rtl8712:mlme_linux.c: Adds blank lines to pass checkpatch.pl
Santiago Torres [Sun, 27 Jul 2014 21:02:47 +0000 (17:02 -0400)]
staging:rtl8712:mlme_linux.c: Adds blank lines to pass checkpatch.pl

Added three newlines after variable declarations to pass checkpatch.pl.

Signed-off by: Santiago Torres-Arias <torresariass@gmail.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: lustre: fix sparse warnings "Using plain integer as NULL pointer"
Radek Dostal [Sun, 27 Jul 2014 21:22:57 +0000 (23:22 +0200)]
staging: lustre: fix sparse warnings "Using plain integer as NULL pointer"

fixes all sparse warnings "Using plain integer as NULL pointer"
in drivers/staging/lustre

drivers/staging/lustre/lnet/lnet/api-ni.c:1665:32: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lnet/lnet/api-ni.c:1773:35: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/fld/fld_request.c:171:17: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/llite/llite_lib.c:155:30: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/llite/lproc_llite.c:846:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:902:48: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:946:54: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_obd.c:2819:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lov/lov_dev.c:456:66: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/mdc_request.c:2426:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/mdc_request.c:2569:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/mdc_request.c:2740:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:175:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:176:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:177:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:178:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:179:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:180:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:181:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:182:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:183:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:185:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:186:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:193:66: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:194:63: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:195:56: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:196:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:197:50: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:198:48: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:199:57: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:200:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:206:48: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mdc/lproc_mdc.c:207:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/mgc/mgc_request.c:199:9: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:331:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdclass/obd_config.c:1164:53: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdclass/obd_config.c:1306:71: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdclass/llog_test.c:943:62: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdclass/llog_test.c:944:65: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/obdecho/echo_client.c:3116:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/osc/osc_request.c:3424:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/osc/osc_request.c:3548:46: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/osc/osc_request.c:3615:46: warning: Using plain integer as NULL pointer

Signed-off-by: Radek Dostal <rd@radekdostal.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: linux-module: add const modifier to file_operations
Jessica Yu [Mon, 28 Jul 2014 13:33:15 +0000 (06:33 -0700)]
Staging: lustre: linux-module: add const modifier to file_operations

Add the const modifier to the file_operations struct, since it is
normally const.

Signed-off-by: Jessica Yu <jyu@cowsay.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: linux-module: remove extraneous parens
Jessica Yu [Mon, 28 Jul 2014 13:33:14 +0000 (06:33 -0700)]
Staging: lustre: linux-module: remove extraneous parens

Remove unnecessary parens from return statements, return is not a function

Signed-off-by: Jessica Yu <jyu@cowsay.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: linux-module: remove unnecessary spaces
Jessica Yu [Mon, 28 Jul 2014 13:33:13 +0000 (06:33 -0700)]
Staging: lustre: linux-module: remove unnecessary spaces

Remove extraneous space after open paren and before close paren.

Signed-off-by: Jessica Yu <jyu@cowsay.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: lustre: linux-module: fix pointer style issue
Jessica Yu [Mon, 28 Jul 2014 13:33:12 +0000 (06:33 -0700)]
Staging: lustre: linux-module: fix pointer style issue

Fix pointer code style (foo * bar -> foo *bar)

Signed-off-by: Jessica Yu <jyu@cowsay.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_dio200: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:45 +0000 (15:01 -0700)]
staging: comedi: amplc_dio200: use the comedi_device 'mmio' member

The amplc_dio200_common module currently uses a union in the private
data to determine if the hardware uses port or memory mapped I/O.

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address and remove all the union code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ii_pci20kc: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:44 +0000 (15:01 -0700)]
staging: comedi: ii_pci20kc: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the __iomem * base
address.

Since this was the only member in the private data, remove the struct
and its allocation.

This legacy driver is a bit strange. The base address of the board is
passed to the (*attach) using by the user using the comedi_config
utiltiy. This base address is currently not ioremap'ed and is simply
cast to a void __iomem *. I'm not sure if this is correct. Add a
comment so it will be addressed later.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_labpc: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:43 +0000 (15:01 -0700)]
staging: comedi: ni_labpc: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Only the ni_labpc_pci module does the ioremap, its also the only
module that sets the 'has_mmio' member in the boardinfo. Remove
this member from the boardinfo and use dev->mmio to determine if
the I/O is memory mapped.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_labpc: refactor labpc_8255_mmio()
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:42 +0000 (15:01 -0700)]
staging: comedi: ni_labpc: refactor labpc_8255_mmio()

Refactor the 8255 support code in preperation for using the comedi_device
'mmio' member.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_set_mode()
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:41 +0000 (15:01 -0700)]
staging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_set_mode()

Use the comedi_device parameter that is passed to this function to find
the dev->iobase so it does not have to be included in each call.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_load()
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:40 +0000 (15:01 -0700)]
staging: comedi: ni_labpc: don't pass dev->iobase to labpc_counter_load()

Use the comedi_device parameter that is passed to this function to find
the dev->iobase so it does not have to be included in each call.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_labpc: pass comedi_device to the I/O callbacks
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:39 +0000 (15:01 -0700)]
staging: comedi: ni_labpc: pass comedi_device to the I/O callbacks

This driver uses some callbacks in the private data to handle the
port mapped or memory mapped I/O used to access the hardware.

Pass the comedi_device pointer to the helper functions so that the
base address can be found and does not need to be included in each
call.

Also, remove the inline from the helper functions.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: mite: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:38 +0000 (15:01 -0700)]
staging: comedi: mite: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
'daq_io_addr'.

Move the iounmap of this address from mite_detach() to the drivers
that use the mite module.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: mite: pass comedi_device to mite_setup()
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:37 +0000 (15:01 -0700)]
staging: comedi: mite: pass comedi_device to mite_setup()

For aesthetics, pass the comedi_device to mite_setup() and mite_setup2()
so that the dev->class_dev can be used in the dev_{level} message to make
the messages have consistancy with the other comedi drivers.

Remove the extra dev_warn() noise in the drivers when mite_setup() fails.

Rename the 'use_iodwbsr_1' parameter and change it to a bool.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: mite: inline mite_setup()
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:36 +0000 (15:01 -0700)]
staging: comedi: mite: inline mite_setup()

This exported function simply calls mite_setup2() with the 'use_iodsbsr_1'
parameter set to 0.

Inline the simple function and remove the EXPORT_SYMBOL_GPL.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: s626: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:35 +0000 (15:01 -0700)]
staging: comedi: s626: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: rtd520: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:34 +0000 (15:01 -0700)]
staging: comedi: rtd520: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address of PCI bar 2.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: cb_pcidas64: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:33 +0000 (15:01 -0700)]
staging: comedi: cb_pcidas64: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address of PCI bar 3.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_670x: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:32 +0000 (15:01 -0700)]
staging: comedi: ni_670x: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_6527: iounmap resource when detached
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:31 +0000 (15:01 -0700)]
staging: comedi: ni_6527: iounmap resource when detached

PCI bar 1 is ioremap'ed during the (*auto_attach). This resource
needs to be iounmap'ed when the driver is (*detach)ed.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_6527: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:30 +0000 (15:01 -0700)]
staging: comedi: ni_6527: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: dt3000: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:29 +0000 (15:01 -0700)]
staging: comedi: dt3000: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: daqboard2000: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:28 +0000 (15:01 -0700)]
staging: comedi: daqboard2000: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: addi_apci_3xxx: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:27 +0000 (15:01 -0700)]
staging: comedi: addi_apci_3xxx: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: icp_multi: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:26 +0000 (15:01 -0700)]
staging: comedi: icp_multi: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: mf6x4: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:25 +0000 (15:01 -0700)]
staging: comedi: mf6x4: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: me_daq: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:24 +0000 (15:01 -0700)]
staging: comedi: me_daq: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: gsc_hpdi: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:23 +0000 (15:01 -0700)]
staging: comedi: gsc_hpdi: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_65xx: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:22 +0000 (15:01 -0700)]
staging: comedi: ni_65xx: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Since this was the only member in the private data, remove the struct
and its allocation.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: 8255_pci: use the comedi_device 'mmio' member
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:21 +0000 (15:01 -0700)]
staging: comedi: 8255_pci: use the comedi_device 'mmio' member

Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.

Since this was the only member in the private data, remove the struct
and its allocation.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: add an 'mmio' member to comedi_device
H Hartley Sweeten [Tue, 29 Jul 2014 22:01:20 +0000 (15:01 -0700)]
staging: comedi: add an 'mmio' member to comedi_device

All the comedi drivers that use memory mapped io currently have a
void __iomem * member in their private data for the driver. For
some of the drivers this is actually the only member in that data.

For convienence, add a new member to the comedi_device for this
void __iomem *.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: tidy up stuct pci230_private
Ian Abbott [Tue, 29 Jul 2014 11:58:26 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: tidy up stuct pci230_private

Align the member comments a bit better in the declaration of `struct
pci230_private`.  Also remove the heading comment as it is just a
boilerplate comedi comment.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: no need to initialize named members to zero
Ian Abbott [Tue, 29 Jul 2014 11:58:25 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: no need to initialize named members to zero

The members of the elements of `pci230_boards[]` that are not explicitly
named in their initializers will be initialized to 0 automatically, so
there is no need to initialize them to 0 explicitly.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: add whitespace to pci230_boards[]
Ian Abbott [Tue, 29 Jul 2014 11:58:24 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: add whitespace to pci230_boards[]

Add a bit of whitespace to the initializer of `pci230_boards[]` for
aesthetic reasons.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: no need for '&function'
Ian Abbott [Tue, 29 Jul 2014 11:58:23 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: no need for '&function'

Remove the "address-of" operator when the operand is a function.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: remove some indentation in pci230_ai_check_chanlist()
Ian Abbott [Tue, 29 Jul 2014 11:58:22 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: remove some indentation in pci230_ai_check_chanlist()

A few lines in `pci230_ai_check_chanlist()` are indented one level too
much, so remove the excess indentation.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: omit '!= 0' from logical expressions
Ian Abbott [Tue, 29 Jul 2014 11:58:20 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: omit '!= 0' from logical expressions

Since anything non-zero is logically "true", don't bother doing
"not-equal" comparisons with zero.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: don't begin line with binary operator
Ian Abbott [Tue, 29 Jul 2014 11:58:19 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: don't begin line with binary operator

If an expression involving a binary operator needs to be split across
two lines, put the split after the operator.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: add whitespace to register values
Ian Abbott [Tue, 29 Jul 2014 11:58:18 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: add whitespace to register values

Several macros are defined for bit-field values within hardware
registers.  They are defined as left-shifted values.  Add some
whitespace around the left-shift operator.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: remove PCI230_TEST_BIT()
Ian Abbott [Tue, 29 Jul 2014 11:58:17 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: remove PCI230_TEST_BIT()

The `PCI230_TEST_BIT()` macro is never used.  Remove it.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: remove PCI230_ADC_CONV
Ian Abbott [Tue, 29 Jul 2014 11:58:16 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: remove PCI230_ADC_CONV

The macro `PCI230_ADC_CONV` is never used.  Just remove it.  (At one
time, the value was written to the `PCI230_ADCSWTRIG` register to
trigger a conversion, but any value would do, and the driver no longer
uses that register to trigger conversions anyway.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: remove unused settling time constants
Ian Abbott [Tue, 29 Jul 2014 11:58:15 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: remove unused settling time constants

The macro constants `PCI230_DAC_SETTLE`, `PCI230_ADC_SETTLE` and
`PCI230_MUX_SETTLE` are never used.  Just remove them.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: usleep_range is preferred over udelay
Ian Abbott [Tue, 29 Jul 2014 11:58:14 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: usleep_range is preferred over udelay

Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt".  I picked 100 us as a reasonable
upper bound, but it's not that critical.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: alignment should match open parenthesis
Ian Abbott [Tue, 29 Jul 2014 11:58:13 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: alignment should match open parenthesis

Fix checkpatch issue: "CHECK: Alignment should match open parenthesis".

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: blank lines aren't necessary before a close brace '}'
Ian Abbott [Tue, 29 Jul 2014 11:58:12 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: blank lines aren't necessary before a close brace '}'

Fix checkpatch issues: "CHECK: Blank lines aren't necessary before a
close brace '}'".

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: logical continuations should be on the previous line
Ian Abbott [Tue, 29 Jul 2014 11:58:11 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: logical continuations should be on the previous line

Fix checkpatch issues "CHECK: Logical continuations should be on the
previous line".

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: fix checkpatch line over 80 characters
Ian Abbott [Tue, 29 Jul 2014 11:58:10 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: fix checkpatch line over 80 characters

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: amplc_pci230: reformat a load of comments
Ian Abbott [Tue, 29 Jul 2014 11:58:09 +0000 (12:58 +0100)]
staging: comedi: amplc_pci230: reformat a load of comments

Reformat a load of comments to fit in with the preferred coding style,
including the copyright and driver description comments at the top of
the file.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>