GitHub/WoltLab/WCF.git
3 years agoMerge pull request #3767 from WoltLab/resetSessions
Tim Düsterhus [Mon, 30 Nov 2020 08:14:03 +0000 (09:14 +0100)]
Merge pull request #3767 from WoltLab/resetSessions

Remove calls to SessionHandler::resetSessions()

3 years agoIntroduce a helper interface for the FileUpload class
Alexander Ebert [Sat, 28 Nov 2020 15:15:26 +0000 (16:15 +0100)]
Introduce a helper interface for the FileUpload class

This interface prevents a circular dependency of the modules `./Delete` and `./Upload`.

3 years agoResolved a few compatibility issues
Alexander Ebert [Fri, 27 Nov 2020 18:51:14 +0000 (19:51 +0100)]
Resolved a few compatibility issues

The internal ids must remain strings, because the legacy `Dictionary` implementation relied on a plain object. In JavaScript objects, all keys are implicitly converted to strings, but Map treats `1` and `"1"` to be different.

3 years agoWorkaround for the legacy inheritance support
Alexander Ebert [Fri, 27 Nov 2020 16:59:51 +0000 (17:59 +0100)]
Workaround for the legacy inheritance support

3 years agoMerge pull request #3761 from WoltLab/54-typescript-misc
Alexander Ebert [Fri, 27 Nov 2020 12:32:32 +0000 (13:32 +0100)]
Merge pull request #3761 from WoltLab/54-typescript-misc

Converted remaining UI modules to TypeScript

3 years agoRemove call to SessionHandler::resetSessions() from UserMergeForm
Tim Düsterhus [Fri, 27 Nov 2020 11:03:15 +0000 (12:03 +0100)]
Remove call to SessionHandler::resetSessions() from UserMergeForm

3 years agoRemove call to SessionHandler::resetSessions() from UserEditor
Tim Düsterhus [Fri, 27 Nov 2020 11:01:26 +0000 (12:01 +0100)]
Remove call to SessionHandler::resetSessions() from UserEditor

3 years agoRemove call to SessionHandler::resetSessions() from acp/install.php
Tim Düsterhus [Fri, 27 Nov 2020 10:59:44 +0000 (11:59 +0100)]
Remove call to SessionHandler::resetSessions() from acp/install.php

3 years agoRemove call to SessionHandler::resetSessions() from UserGroupEditor
Tim Düsterhus [Fri, 27 Nov 2020 10:58:34 +0000 (11:58 +0100)]
Remove call to SessionHandler::resetSessions() from UserGroupEditor

3 years agoRemove call to SessionHandler::resetSessions() from UserAssignToGroupForm
Tim Düsterhus [Fri, 27 Nov 2020 10:51:58 +0000 (11:51 +0100)]
Remove call to SessionHandler::resetSessions() from UserAssignToGroupForm

UserEditor::resetCache() already is responsible to clear the cached data.

3 years agoFix package check in update_com.woltlab.wcf_5.4_removeFiles.php
Tim Düsterhus [Thu, 26 Nov 2020 13:36:36 +0000 (14:36 +0100)]
Fix package check in update_com.woltlab.wcf_5.4_removeFiles.php

`fetchSingleColumn()` returns false for non-existing rows.

3 years agoUpdate the upgrade instructions from WoltLab Suite 5.3
Tim Düsterhus [Thu, 26 Nov 2020 13:18:56 +0000 (14:18 +0100)]
Update the upgrade instructions from WoltLab Suite 5.3

- A few PIPs were missing, most notably the language items.
- Additional commentary.
- Reordering for better resiliency.

3 years agoMerge branch '5.3'
Tim Düsterhus [Thu, 26 Nov 2020 12:51:39 +0000 (13:51 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Nov 2020 12:51:25 +0000 (13:51 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3629 from WoltLab/session-update
Tim Düsterhus [Thu, 26 Nov 2020 12:31:10 +0000 (13:31 +0100)]
Merge pull request #3629 from WoltLab/session-update

Update instructions for new sessions

3 years agoImprove variable naming in update_com.woltlab.wcf_5.4_session_1_cookies.php
Tim Düsterhus [Thu, 26 Nov 2020 11:35:21 +0000 (12:35 +0100)]
Improve variable naming in update_com.woltlab.wcf_5.4_session_1_cookies.php

3 years agoMerge pull request #3763 from WoltLab/http-request-timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:33:41 +0000 (12:33 +0100)]
Merge pull request #3763 from WoltLab/http-request-timeout

HTTP request timeouts

3 years agoSet an explicit timeout for ImageProxyAction's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:29:23 +0000 (12:29 +0100)]
Set an explicit timeout for ImageProxyAction's HttpClient

3 years agoSet an explicit timeout for FontManager's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:28:03 +0000 (12:28 +0100)]
Set an explicit timeout for FontManager's HttpClient

3 years agoReplace HTTPRequest's timeout by connect_timeout + read_timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:26:00 +0000 (12:26 +0100)]
Replace HTTPRequest's timeout by connect_timeout + read_timeout

The timeout in 5.2 only applied to the connect() syscall. Guzzle's timeout
option applies to the total transfer. Replace it by connect_timeout +
read_timeout for backwards compatibility for code that expected the actual
transfer to take an arbitrary amount of time.

3 years agoDrop wcf1_session.sessionVariables
Tim Düsterhus [Thu, 26 Nov 2020 11:20:39 +0000 (12:20 +0100)]
Drop wcf1_session.sessionVariables

3 years agoAdd update instructions for session refactoring
Tim Düsterhus [Thu, 22 Oct 2020 12:47:56 +0000 (14:47 +0200)]
Add update instructions for session refactoring

3 years agoAdd skipStyleUpdate paramter to file PIP
Tim Düsterhus [Thu, 22 Oct 2020 12:37:53 +0000 (14:37 +0200)]
Add skipStyleUpdate paramter to file PIP

3 years agoAllow returning a Document in ScriptPackageInstallationPlugin
Tim Düsterhus [Thu, 22 Oct 2020 10:14:48 +0000 (12:14 +0200)]
Allow returning a Document in ScriptPackageInstallationPlugin

3 years agoDelete obsolete session_* options in option.xml
Tim Düsterhus [Thu, 22 Oct 2020 12:18:26 +0000 (14:18 +0200)]
Delete obsolete session_* options in option.xml

3 years agoUse a local variable to prevent parallel requests being mixed up
Alexander Ebert [Wed, 25 Nov 2020 23:57:03 +0000 (00:57 +0100)]
Use a local variable to prevent parallel requests being mixed up

Fixes #3760

3 years agoImproper serialization of `null` values
Alexander Ebert [Wed, 25 Nov 2020 23:25:31 +0000 (00:25 +0100)]
Improper serialization of `null` values

Fixes #3751

3 years agoFix typo in de.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:34:03 +0000 (09:34 +0100)]
Fix typo in de.xml

3 years agoUpdate the orphanedComments remark in package.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml

3 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 25 Nov 2020 08:08:07 +0000 (09:08 +0100)]
Merge branch '5.3'

3 years agoFix typo in informal German phrases
Jannis Grimm [Wed, 25 Nov 2020 03:04:31 +0000 (04:04 +0100)]
Fix typo in informal German phrases

Verweide -> Vermeide

Closes #3752

[Tim: rephrased the commit message]

3 years agoUpdated the `package-lock.json`
Alexander Ebert [Tue, 24 Nov 2020 18:35:44 +0000 (19:35 +0100)]
Updated the `package-lock.json`

The old version was outdated and prevented the `node_modules/.bin` from being created after running `npm i`

3 years agoImproved randomized sort order of related articles
Marcel Werk [Tue, 24 Nov 2020 17:44:34 +0000 (18:44 +0100)]
Improved randomized sort order of related articles

3 years agoMerge branch '5.3'
Alexander Ebert [Tue, 24 Nov 2020 17:33:25 +0000 (18:33 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #3750 from WoltLab/emogrifier-5.0
Tim Düsterhus [Tue, 24 Nov 2020 14:58:34 +0000 (15:58 +0100)]
Merge pull request #3750 from WoltLab/emogrifier-5.0

Update pelago/emogrifier to 5.0

3 years agoUpdate pelago/emogrifier to 5.0
Tim Düsterhus [Tue, 24 Nov 2020 14:45:28 +0000 (15:45 +0100)]
Update pelago/emogrifier to 5.0

3 years agoRelease 5.3.1 5.3.1
Alexander Ebert [Mon, 23 Nov 2020 15:38:18 +0000 (16:38 +0100)]
Release 5.3.1

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 15:34:03 +0000 (16:34 +0100)]
Merge branch '5.2' into 5.3

3 years agoMissing check for empty object ids 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 14:55:09 +0000 (15:55 +0100)]
Merge branch '5.2' into 5.3

3 years agorandomized sort order of related articles
Marcel Werk [Mon, 23 Nov 2020 14:19:48 +0000 (15:19 +0100)]
randomized sort order of related articles

3 years agoChanged related articles to new layout
Marcel Werk [Mon, 23 Nov 2020 14:19:02 +0000 (15:19 +0100)]
Changed related articles to new layout

3 years agoRelease 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.18 3.1.18
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18

3 years agoDeprecated PreparedStatement::fetchList()
Tim Düsterhus [Mon, 23 Nov 2020 11:45:43 +0000 (12:45 +0100)]
Deprecated PreparedStatement::fetchList()

Resolves #3742

3 years agoUse modified package servers when running in enterprise mode
Alexander Ebert [Mon, 23 Nov 2020 11:30:45 +0000 (12:30 +0100)]
Use modified package servers when running in enterprise mode

3 years agoMerge branch '5.3'
Tim Düsterhus [Mon, 23 Nov 2020 10:36:46 +0000 (11:36 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.3_orphanedComments.php
- Replaced ts/WoltLabSuite/Core/Acp/Ui/Option/EmailSmtpTest.js with the file
  from 5.3, replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.
- Manually applied 4ac5f76b4ee5804919a832729a7ab384ea9d9a4d to the already
  converted WoltLabSuite/Core/Ui/Screen.ts

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 23 Nov 2020 08:31:54 +0000 (09:31 +0100)]
Merge branch '5.2' into 5.3

3 years agoWhitelist `iterator_count` in enterprise mode
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode

3 years agoMerge pull request #3738 from WoltLab/emogrifier-4.0
Tim Düsterhus [Mon, 23 Nov 2020 08:10:25 +0000 (09:10 +0100)]
Merge pull request #3738 from WoltLab/emogrifier-4.0

Update to Emogrifier 4.0

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sun, 22 Nov 2020 17:36:43 +0000 (18:36 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3744 from Krymonota/patch-18
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18

Add missing JSDoc to `EmailSmtpTest`

3 years agoMerge pull request #3745 from Krymonota/patch-19
Alexander Ebert [Sun, 22 Nov 2020 16:58:12 +0000 (17:58 +0100)]
Merge pull request #3745 from Krymonota/patch-19

Fix JSDoc module typo in `RewriteGenerator`

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Sat, 21 Nov 2020 21:00:14 +0000 (22:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix point calculation for removing reactions from an object
joshuaruesweg [Sat, 21 Nov 2020 20:56:27 +0000 (21:56 +0100)]
Fix point calculation for removing reactions from an object

3 years agoRelease 5.3.1
Alexander Ebert [Sat, 21 Nov 2020 18:59:08 +0000 (19:59 +0100)]
Release 5.3.1

3 years agoFix JSDoc module typo in `RewriteGenerator`
Niklas [Sat, 21 Nov 2020 18:41:47 +0000 (19:41 +0100)]
Fix JSDoc module typo in `RewriteGenerator`

3 years agoAdd missing JSDoc to `EmailSmtpTest`
Niklas [Sat, 21 Nov 2020 18:39:56 +0000 (19:39 +0100)]
Add missing JSDoc to `EmailSmtpTest`

3 years agoForce the removal of orphaned comments during the upgrade
Alexander Ebert [Sat, 21 Nov 2020 18:36:16 +0000 (19:36 +0100)]
Force the removal of orphaned comments during the upgrade

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:11:59 +0000 (19:11 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Fri, 20 Nov 2020 19:08:26 +0000 (20:08 +0100)]
Merge branch '5.2' into 5.3

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:03:30 +0000 (19:03 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 20 Nov 2020 18:59:24 +0000 (19:59 +0100)]
Merge branch '3.1' into 5.2

3 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 18:06:23 +0000 (18:06 +0000)]
Updating minified JavaScript files

3 years agoWorkaround for a Chromium bug on Windows
Alexander Ebert [Fri, 20 Nov 2020 17:39:33 +0000 (18:39 +0100)]
Workaround for a Chromium bug on Windows

3 years agoVerbose style compatibility for 5.2/5.3
Alexander Ebert [Fri, 20 Nov 2020 16:16:19 +0000 (17:16 +0100)]
Verbose style compatibility for 5.2/5.3

Fixes #3737

3 years agoPermit images uploaded as media to be wrapped in a link
Alexander Ebert [Fri, 20 Nov 2020 12:38:01 +0000 (13:38 +0100)]
Permit images uploaded as media to be wrapped in a link

3 years agoMerge branch '5.3'
Tim Düsterhus [Fri, 20 Nov 2020 10:23:22 +0000 (11:23 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.2.10_orphanedComments.php
- Replaced ts/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js with the file
  from 5.3, replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 20 Nov 2020 10:19:32 +0000 (11:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoClean up comments when removing moderation queues (#3740)
Alexander Ebert [Thu, 19 Nov 2020 18:24:52 +0000 (19:24 +0100)]
Clean up comments when removing moderation queues (#3740)

* Delete comments when moderation queues are being removed

See #3707

* Clean-up script for orphaned comments

* Use the `CommentHandler` to remove comments

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoEnabled three column layout for boxes top / bottom
Marcel Werk [Thu, 19 Nov 2020 18:02:23 +0000 (19:02 +0100)]
Enabled three column layout for boxes top / bottom

3 years agoSkip DOM updates when the article is not present
Alexander Ebert [Thu, 19 Nov 2020 15:56:12 +0000 (16:56 +0100)]
Skip DOM updates when the article is not present

3 years agoMerge branch '5.3'
Tim Düsterhus [Thu, 19 Nov 2020 15:24:51 +0000 (16:24 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.3_style.php which is not required.
- Replaced ts/WoltLabSuite/Core/Media/Editor.js with the file from 5.3,
  replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.

3 years agoMerge pull request #3739 from WoltLab/fix-style-preview
Tim Düsterhus [Thu, 19 Nov 2020 15:17:08 +0000 (16:17 +0100)]
Merge pull request #3739 from WoltLab/fix-style-preview

Fix style preview images when upgrading from 5.2

3 years agoFix style preview images when upgrading from 5.2
Tim Düsterhus [Thu, 19 Nov 2020 15:09:29 +0000 (16:09 +0100)]
Fix style preview images when upgrading from 5.2

3 years agoFixed html in acp search results
Marcel Werk [Thu, 19 Nov 2020 14:27:41 +0000 (15:27 +0100)]
Fixed html in acp search results

3 years agoAdjust RecipientAwareTextMimePart for Emogrifier 4.0
Tim Düsterhus [Thu, 19 Nov 2020 13:30:56 +0000 (14:30 +0100)]
Adjust RecipientAwareTextMimePart for Emogrifier 4.0

3 years agoUpdate pelago/emogrifier to 4.0
Tim Düsterhus [Thu, 19 Nov 2020 13:30:40 +0000 (14:30 +0100)]
Update pelago/emogrifier to 4.0

3 years agoAdd note about the email_html.tpl update to package.xml
Tim Düsterhus [Thu, 19 Nov 2020 13:18:04 +0000 (14:18 +0100)]
Add note about the email_html.tpl update to package.xml

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 19 Nov 2020 13:13:46 +0000 (14:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoReplace the selector for the font-family in email_html.tpl
Tim Düsterhus [Thu, 19 Nov 2020 13:06:01 +0000 (14:06 +0100)]
Replace the selector for the font-family in email_html.tpl

The Emogrifier version used in 5.2 does not fully support all features
of the `:not()` selector. Depending on the environment the use of
`:not()` results in slightly different output. Specifically the number
of `:not()`s chained there caused the result to have a very large
specificity, possibly overriding the font-size of the headline tags.

Use `body, body *` instead, it will not put any useless CSS onto heading
tags and still catch all relevant elements. The biggest difference is
that the `<br>` tag will carry a `font-family` and `font-size`.

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 18 Nov 2020 19:02:11 +0000 (20:02 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 18 Nov 2020 19:01:46 +0000 (20:01 +0100)]
Merge branch '3.1' into 5.2

3 years agoMutable variable access inside a callback
Alexander Ebert [Wed, 18 Nov 2020 19:00:04 +0000 (20:00 +0100)]
Mutable variable access inside a callback

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 16:32:58 +0000 (17:32 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 18 Nov 2020 16:32:41 +0000 (17:32 +0100)]
Merge branch '3.1' into 5.2

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:32:21 +0000 (17:32 +0100)]
Fix ACL buttons when editing media files successively

Replaces 3a7740a3704339c79d08fd2f5094fa1a1973318b by backporting and using parts of 6ee58cd2865980cd7fa16a1f3ebc660131fc7fd6.

3 years agoRevert "Fix ACL buttons when editing media files successively"
Matthias Schmidt [Wed, 18 Nov 2020 16:26:26 +0000 (17:26 +0100)]
Revert "Fix ACL buttons when editing media files successively"

This reverts commit 3a7740a3704339c79d08fd2f5094fa1a1973318b.

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:24:30 +0000 (17:24 +0100)]
Fix ACL buttons when editing media files successively

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 18 Nov 2020 15:31:03 +0000 (16:31 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 15:28:34 +0000 (16:28 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix file icon update after upload on media list page
Matthias Schmidt [Wed, 18 Nov 2020 15:28:18 +0000 (16:28 +0100)]
Fix file icon update after upload on media list page

3 years agoRemove assignment of $__wscMissingOwnerGroup
Tim Düsterhus [Wed, 18 Nov 2020 15:16:44 +0000 (16:16 +0100)]
Remove assignment of $__wscMissingOwnerGroup

Apparently this was forgotten in #3697.

3 years agoMake WoltLabSuite/Core/List a proper generic class
Tim Düsterhus [Wed, 18 Nov 2020 14:14:59 +0000 (15:14 +0100)]
Make WoltLabSuite/Core/List a proper generic class

3 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 18 Nov 2020 11:43:32 +0000 (12:43 +0100)]
Merge branch '5.3'

Dropped update_com.woltlab.wcf_5.3_fixActivationMethod.php which is not
required.

3 years agoRemove obsolete update_com.woltlab.wcf_5.3_fixActivationMethod.php
Tim Düsterhus [Wed, 18 Nov 2020 11:42:59 +0000 (12:42 +0100)]
Remove obsolete update_com.woltlab.wcf_5.3_fixActivationMethod.php

3 years agoMerge pull request #3727 from WoltLab/favicon-template-typo
Tim Düsterhus [Wed, 18 Nov 2020 08:22:32 +0000 (09:22 +0100)]
Merge pull request #3727 from WoltLab/favicon-template-typo

Fix typo in favicon template filename

3 years agoUpdating minified JavaScript files
WoltLab [Tue, 17 Nov 2020 14:56:24 +0000 (14:56 +0000)]
Updating minified JavaScript files