GitHub/moto-9609/android_kernel_motorola_exynos9610.git
7 years agoiio: make stm32 trigger driver use INDIO_HARDWARE_TRIGGERED mode
Benjamin Gaignard [Thu, 27 Apr 2017 13:29:16 +0000 (15:29 +0200)]
iio: make stm32 trigger driver use INDIO_HARDWARE_TRIGGERED mode

Add validate function to be use to use the correct trigger.
Add an attribute to configure device mode like for quadrature and
enable modes

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: add hardware triggered operating mode
Benjamin Gaignard [Thu, 27 Apr 2017 13:29:15 +0000 (15:29 +0200)]
iio: add hardware triggered operating mode

Devices, like stm32 timer, could be triggered by hardware events which
are not buffer or software events. However it could be necessary to
validate the triggers like it is done for buffer or event triggered modes.
This patch add a new INDIO_HARDWARE_TRIGGERED operating mode for this
kind of devices and allow this mode to register trigger consumer.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: Aspeed ADC - Handle return value of clk_prepare_enable
Arvind Yadav [Mon, 29 May 2017 07:42:12 +0000 (13:12 +0530)]
iio: Aspeed ADC - Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Rick Altherr <raltherr@google.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoRevert "iio: accel: bma180: Add support for BMA250E"
Hans de Goede [Tue, 6 Jun 2017 20:35:38 +0000 (22:35 +0200)]
Revert "iio: accel: bma180: Add support for BMA250E"

This reverts commit f1320b09517bceb261fed887fe261d6cbab2094e.

The BMA250E is already handled by the bmc150-accel-i2c driver, which
supports the "E" variants of the BMA??? accelerometers better then the
bma180 driver.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoRevert "iio: accel: bma180: Add ACPI enumeration support for BMA250E"
Hans de Goede [Tue, 6 Jun 2017 20:35:37 +0000 (22:35 +0200)]
Revert "iio: accel: bma180: Add ACPI enumeration support for BMA250E"

This reverts commit 5333e88661f2079d5ca8b94690ac920976300de3.

The BMA250E is already handled by the bmc150-accel-i2c driver, which
supports the "E" variants of the BMA??? accelerometers better then the
bma180 driver.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: magnetometer: st_magn_spi: fix spi_device_id table
Lorenzo Bianconi [Tue, 6 Jun 2017 20:51:24 +0000 (22:51 +0200)]
iio: magnetometer: st_magn_spi: fix spi_device_id table

Remove LSM303DLHC, LSM303DLM from st_magn_id_table since LSM303DL series
does not support spi interface

Fixes: 872e79add756 (iio: magn: Add STMicroelectronics magn driver)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: accel: st_accel_spi: fix spi_device_id table
Lorenzo Bianconi [Tue, 6 Jun 2017 20:51:23 +0000 (22:51 +0200)]
iio: accel: st_accel_spi: fix spi_device_id table

Remove LSM303DL, LSM303DLM, LSM303DLH, LSM303DLHC from st_accel_id_table
since LSM303DL series does not support spi interface

Fixes: d62511689de5 (iio: accel: Add STMicroelectronics accel driver)
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: imu: inv_mpu6050: replace sprintf with scnprintf
Jean-Baptiste Maneyrol [Wed, 7 Jun 2017 13:42:26 +0000 (13:42 +0000)]
iio: imu: inv_mpu6050: replace sprintf with scnprintf

Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: imu: inv_mpu6050: fix lock issues by using our own mutex
Jean-Baptiste Maneyrol [Wed, 7 Jun 2017 13:41:42 +0000 (13:41 +0000)]
iio: imu: inv_mpu6050: fix lock issues by using our own mutex

There are several locks issues when using buffer and direct polling
data at the same time. Use our own mutex for managing locking and
block simultaneous use of buffer and direct polling by using
iio_device_{claim/release}_direct_mode. This makes chip_config
enable bit obsolete, so delete it.

Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agodt-bindings: iio: imu: st_lsm6dsx: support active-low interrupts
Lorenzo Bianconi [Wed, 7 Jun 2017 18:17:11 +0000 (20:17 +0200)]
dt-bindings: iio: imu: st_lsm6dsx: support active-low interrupts

Update st_lsm6dsx device binding with active-low interrupts support
(IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_EDGE_FALLING).

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: imu: st_lsm6dsx: support active-low interrupts
Lorenzo Bianconi [Wed, 7 Jun 2017 18:17:10 +0000 (20:17 +0200)]
iio: imu: st_lsm6dsx: support active-low interrupts

Add support for active low interrupts (IRQF_TRIGGER_LOW and
IRQF_TRIGGER_FALLING). Configure the device as active high or low
according to the requested irq line.

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: ad7791: Use sysfs_match_string() helper
Andy Shevchenko [Fri, 9 Jun 2017 12:08:10 +0000 (15:08 +0300)]
iio: adc: ad7791: Use sysfs_match_string() helper

Use sysfs_match_string() helper instead of open coded variant.

Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: core: Use __sysfs_match_string() helper
Andy Shevchenko [Fri, 9 Jun 2017 12:08:16 +0000 (15:08 +0300)]
iio: core: Use __sysfs_match_string() helper

Use __sysfs_match_string() helper instead of open coded variant.

Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: proximity: sx9500: Use devm_gpiod_get()
Andy Shevchenko [Sat, 10 Jun 2017 19:08:21 +0000 (22:08 +0300)]
iio: proximity: sx9500: Use devm_gpiod_get()

Since index is always 0 replace devm_gpiod_get_index() by devm_gpiod_get().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: twl4030: Fold twl4030-madc.h into driver
Sebastian Reichel [Thu, 27 Apr 2017 15:30:12 +0000 (17:30 +0200)]
iio: adc: twl4030: Fold twl4030-madc.h into driver

twl4030-madc.h is no longer used by anything outside of
the iio driver, so it can be merged into the driver.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: twl4030: Remove twl4030_madc_request.func_cb
Sebastian Reichel [Thu, 27 Apr 2017 15:30:11 +0000 (17:30 +0200)]
iio: adc: twl4030: Remove twl4030_madc_request.func_cb

This functionality is not used by the IIO subsystem. Due
to removal of legacy API it can also be removed.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: twl4030: Drop struct twl4030_madc_user_parms
Sebastian Reichel [Thu, 27 Apr 2017 15:30:10 +0000 (17:30 +0200)]
iio: adc: twl4030: Drop struct twl4030_madc_user_parms

This struct is no longer used by anything in the kernel.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: twl4030: Unexport twl4030_madc_conversion()
Sebastian Reichel [Thu, 27 Apr 2017 15:30:09 +0000 (17:30 +0200)]
iio: adc: twl4030: Unexport twl4030_madc_conversion()

All madc users have been converted to IIO API, so drop the
legacy API. The function is still used inside of the driver.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: twl4030: Drop twl4030_get_madc_conversion()
Sebastian Reichel [Thu, 27 Apr 2017 15:30:08 +0000 (17:30 +0200)]
iio: adc: twl4030: Drop twl4030_get_madc_conversion()

Drop legacy twl4030_get_madc_conversion() method. It has been
used by drivers to get madc data before it conversion to IIO
API. There are no users in the mainline kernel anymore.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: stm32: add support for STM32H7
Fabrice Gasnier [Mon, 29 May 2017 09:28:20 +0000 (11:28 +0200)]
iio: adc: stm32: add support for STM32H7

Add support for STM32H7 Analog to Digital Converter. It has up
to 20 external channels, resolution ranges from 8 to 16bits.
Either bus or asynchronous adc clock may be used.

Add registers & bitfields definition. Also add new configuration
options to enter/exit powerdown and perform self-calibration.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: stm32: make per instance bus clock optional
Fabrice Gasnier [Mon, 29 May 2017 09:28:19 +0000 (11:28 +0200)]
iio: adc: stm32: make per instance bus clock optional

STM32F4 requires one clock per ADC instance for register access. But,
newer version of ADC hardware block have common bus clock for all
instances (per instance driver isn't responsible for getting it).
So, make it optional by default. Still, enforce it's required on STM32F4.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: stm32: introduce compatible data cfg
Fabrice Gasnier [Mon, 29 May 2017 09:28:18 +0000 (11:28 +0200)]
iio: adc: stm32: introduce compatible data cfg

Prepare support for stm32h7 adc variant by introducing compatible
configuration data.
Move STM32F4 specific stuff to compatible data structure:
- registers & bit fields
- input channels data
- start/stop procedures
- trigger definitions

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: stm32: make core adc clock optional by default
Fabrice Gasnier [Mon, 29 May 2017 09:28:17 +0000 (11:28 +0200)]
iio: adc: stm32: make core adc clock optional by default

Analog clock input is mandatory on stm32f4. But newer version of
ADC hardware block allow to select either bus clock or asynchronous
clock, for analog circuitry.

So, make it optional by default, but enforce clk presence on stm32f4.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agodt-bindings: iio: stm32-adc: add support for STM32H7
Fabrice Gasnier [Mon, 29 May 2017 09:28:16 +0000 (11:28 +0200)]
dt-bindings: iio: stm32-adc: add support for STM32H7

Document support for STM32H7 Analog to Digital Converter.
Main difference is regarding compatible, clock definitions and new
features like differential channels support:
STM32H7 ADC block has two clock inputs, common clock for all ADCs.
One 'bus' clock for registers access, and one optional 'adc' clock
for analog circuitry (bus clock may be used for conversions).

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: Fix integration time/averaging for INA219/220
Stefan Brüns [Wed, 24 May 2017 00:09:06 +0000 (02:09 +0200)]
iio: adc: Fix integration time/averaging for INA219/220

INA226/230/231 has integration times per voltage channel and common
averaging setting for both channels, while the INA219/220 only has a
combined integration time/averaging setting per channel.
Only expose the averaging attribute for the INA226, and expose the correct
integration times for the INA219.

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: meson-saradc: use NULL instead of 0 for pointer
Paolo Cretaro [Sun, 28 May 2017 11:24:38 +0000 (13:24 +0200)]
iio: adc: meson-saradc: use NULL instead of 0 for pointer

Fix sparse warning: Using plain integer as NULL pointer

Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio:adc:lpc32xx Handle return value of clk_prepare_enable
Arvind Yadav [Tue, 30 May 2017 11:05:27 +0000 (16:35 +0530)]
iio:adc:lpc32xx Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: mxs-lradc: fix non-static symbol warnings
Paolo Cretaro [Wed, 31 May 2017 23:50:55 +0000 (01:50 +0200)]
iio: adc: mxs-lradc: fix non-static symbol warnings

Fix sparse warning "symbol foo was not declared. Should it be static?"
for the following symbols:
mx23_lradc_adc_irq_names
mx28_lradc_adc_irq_names
iio_dev_attr_in_voltage0_scale_available
iio_dev_attr_in_voltage1_scale_available
iio_dev_attr_in_voltage2_scale_available
iio_dev_attr_in_voltage3_scale_available
iio_dev_attr_in_voltage4_scale_available
iio_dev_attr_in_voltage5_scale_available
iio_dev_attr_in_voltage6_scale_available
iio_dev_attr_in_voltage7_scale_available
iio_dev_attr_in_voltage10_scale_available
iio_dev_attr_in_voltage11_scale_available
iio_dev_attr_in_voltage12_scale_available
iio_dev_attr_in_voltage13_scale_available
iio_dev_attr_in_voltage14_scale_available
iio_dev_attr_in_voltage15_scale_available

Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoRevert "iio: hi8435: cleanup reset gpio"
Jonathan Cameron [Sun, 28 May 2017 15:10:21 +0000 (16:10 +0100)]
Revert "iio: hi8435: cleanup reset gpio"

This reverts commit 61305664a542f874283f74bf0b27ddb31f5045d7.

This commit was applied prematurely and will break some existing
situations where the signal is inverted as part of voltage level
conversions.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: xilinx: Handle return value of clk_prepare_enable
Arvind Yadav [Fri, 26 May 2017 06:37:41 +0000 (12:07 +0530)]
iio: adc: xilinx: Handle return value of clk_prepare_enable

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: use proper name for the R-Car SoC
Wolfram Sang [Sun, 28 May 2017 09:30:46 +0000 (11:30 +0200)]
iio: use proper name for the R-Car SoC

It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: ina2xx: Make use of attribute flags consistent on all channels
Stefan Brüns [Wed, 24 May 2017 00:09:05 +0000 (02:09 +0200)]
iio: adc: ina2xx: Make use of attribute flags consistent on all channels

Flags for shared channel attributes should be set on all channels of a
channel set. I.e. SAMP_FREQUENCY and OVERSAMPLING_RATIO are set on the
in_voltage{0,1} channels, thus should be set on in_power, in_current.

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: hi8435: remote ampersands from hi8435_info definition
Nikita Yushchenko [Tue, 23 May 2017 08:07:46 +0000 (11:07 +0300)]
iio: hi8435: remote ampersands from hi8435_info definition

C syntax allows apersands when initializing structures fields with
function pointers, but in Linux sources ampersands are normally not used
in thix context.

Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: cpcap: Remove hung interrupt quirk
Tony Lindgren [Tue, 23 May 2017 00:51:46 +0000 (17:51 -0700)]
iio: adc: cpcap: Remove hung interrupt quirk

This is no longer needed as the real problem was interrupt flags
not getting passed properly from device tree to the cpcap-core.c
mfd driver. This got fixed with commit ac89473213c6 ("mfd: cpcap:
Fix interrupt to use level interrupt") So let's remove ADC
interrupt specific the quirk.

Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: cpcap: Fix die temperature
Tony Lindgren [Tue, 23 May 2017 00:51:45 +0000 (17:51 -0700)]
iio: adc: cpcap: Fix die temperature

It seems that "MC13783 Power Management and Audio Ciruit User's Guide"
MC1378UG.pdf documents several similar components as in the CPCAP PMIC.

Chapter "9.5.5 Die Temperature and UID" says that the die temperature
value is 282 at 25C with LSB of -1.14C. Converting CPCAP PMIC channel3
values with following seems to produce values that make sense for a
PMIC die:

temperature = 25000 + ((regval - 282) * 114)

As we don't have any other documentation, let's assume the die
temperature is unconfigured in the Motorola mapphone Linux kernel
and the current temperature conversion table should be only used
for the battery thermistor and not for the die temperature.

Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: cpcap: Fix default register values and battery temperature
Tony Lindgren [Tue, 23 May 2017 00:51:44 +0000 (17:51 -0700)]
iio: adc: cpcap: Fix default register values and battery temperature

Looking at the register dumps from Android kernel on droid 4, I noticed
the values with the mainline kernel don't match. Let's fix this by
initializing the ADC registers to what Android does.

For getting correct values from the battery thermistor, we need to
toggle the CPCAP_BIT_THERMBIAS_EN when measuring battery temperature
to get correct battery temperatures. And looks like we also need to
wait a little bit before reading the battery temperature as otherwise
the results are inaccurate.

Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agostaging: vchiq_core: Replace remaining BUG_ON with WARN_ON
Stefan Wahren [Thu, 25 May 2017 22:26:26 +0000 (00:26 +0200)]
staging: vchiq_core: Replace remaining BUG_ON with WARN_ON

This replaces all remaining BUG_ON with WARN_ON. So in case of
a VCHIQ bug the system is still usable.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Bail out in case of invalid tx_pos
Stefan Wahren [Thu, 25 May 2017 22:26:25 +0000 (00:26 +0200)]
staging: vchiq_core: Bail out in case of invalid tx_pos

Properly handle the error case in case of an invalid tx_pos.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Don't BUG if process is unexpected
Stefan Wahren [Thu, 25 May 2017 22:26:24 +0000 (00:26 +0200)]
staging: vchiq_core: Don't BUG if process is unexpected

Bail out properly if the process index doesn't match the remote insert.
We also drop the BUG in case the process index is at local insert,
so we can trigger the WARN_ON again some steps later.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Bail out if ref_count is unexpected
Stefan Wahren [Thu, 25 May 2017 22:26:23 +0000 (00:26 +0200)]
staging: vchiq_core: Bail out if ref_count is unexpected

If the ref counter of service has an unexpected value then we better
bail out.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Bail out if service is NULL
Stefan Wahren [Thu, 25 May 2017 22:26:22 +0000 (00:26 +0200)]
staging: vchiq_core: Bail out if service is NULL

In the unlikely case that service is NULL we should bail out instead
of calling BUG_ON(). The other BUG_ON calls will be fixed in separate
patches.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Don't BUG if sending RESUME fails
Stefan Wahren [Thu, 25 May 2017 22:26:21 +0000 (00:26 +0200)]
staging: vchiq_core: Don't BUG if sending RESUME fails

VCHIQ suspend and resume isn't implemented, but even it was
there is no need to call BUG().

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Bailout if VCHIQ state is already initialized
Stefan Wahren [Thu, 25 May 2017 22:26:20 +0000 (00:26 +0200)]
staging: vchiq_core: Bailout if VCHIQ state is already initialized

In case VCHIQ state is already initialized we need to bailout
in order to aovid a memory leak.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Simplify VCHIQ init
Stefan Wahren [Thu, 25 May 2017 22:26:19 +0000 (00:26 +0200)]
staging: vchiq_core: Simplify VCHIQ init

Since the ARM side of VCHIQ support only 1 state, we could simplify
the init code. This makes it possible to avoid BUG_ON and a theoretical
overflow of id.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_2835_arm: Use PAGE_MASK macro
Stefan Wahren [Thu, 25 May 2017 22:26:18 +0000 (00:26 +0200)]
staging: vchiq_2835_arm: Use PAGE_MASK macro

Use the PAGE_MASK instead of open code it.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_2835_arm: Handle vmalloc_to_page error case
Stefan Wahren [Thu, 25 May 2017 22:26:17 +0000 (00:26 +0200)]
staging: vchiq_2835_arm: Handle vmalloc_to_page error case

In case vmalloc_to_page returns NULL create_pagelist must abort
imediatly.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo
Stefan Wahren [Thu, 25 May 2017 22:26:16 +0000 (00:26 +0200)]
staging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo

Assuming the intension of the function is to clean up, so fix the function
name accordingly.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_arm: Avoid multiline dereference
Stefan Wahren [Thu, 25 May 2017 22:26:15 +0000 (00:26 +0200)]
staging: vchiq_arm: Avoid multiline dereference

Reduce the indentation within vchiq_dump_service_use_state in order
to avoid a multiline derefernce.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_arm: Fix variable names in comment
Stefan Wahren [Thu, 25 May 2017 22:26:14 +0000 (00:26 +0200)]
staging: vchiq_arm: Fix variable names in comment

This comment was apparently forgotten in the correction of CamelCase.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size
Stefan Wahren [Thu, 25 May 2017 22:26:13 +0000 (00:26 +0200)]
staging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size

The variable slot_mem_size is assigned a value which is never used.
This issue has been found by CppCheck.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_2835_arm: Reduce scope of i in free_pagelist
Stefan Wahren [Thu, 25 May 2017 22:26:12 +0000 (00:26 +0200)]
staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

We can reduce the scope of the counting variable i. This has
been found by CppCheck.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vchiq_core: Use return value of mutex_lock_killable directly
Stefan Wahren [Thu, 25 May 2017 22:26:11 +0000 (00:26 +0200)]
staging: vchiq_core: Use return value of mutex_lock_killable directly

Instead of saving the return value of mutex_lock_killable in a
local variable we could use the value directly.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: removes comparison to null
Juliana Rodrigues [Sat, 27 May 2017 01:02:03 +0000 (22:02 -0300)]
staging: rtl8188eu: removes comparison to null

This patch fixes multiple comparison to NULL checkpatch errors by
rewriting the conditional as a negation.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: removed unnecessary blank lines
Juliana Rodrigues [Sat, 27 May 2017 01:01:26 +0000 (22:01 -0300)]
staging: rtl8188eu: removed unnecessary blank lines

Removes numerous unnecessary blank lines in order to fix
checkpatch styling issues.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: removed unnecessary parentheses
Juliana Rodrigues [Sat, 27 May 2017 01:00:54 +0000 (22:00 -0300)]
staging: rtl8188eu: removed unnecessary parentheses

This patch removes numerous unnecessary parentheses in order
to fix checkpatch styling issues.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: removed function names from strings
Juliana Rodrigues [Sat, 27 May 2017 01:00:22 +0000 (22:00 -0300)]
staging: rtl8188eu: removed function names from strings

This patch fixes a checkpatch issue caused by using function
names inside strings. Those function names were replaced by
__func__.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: add spaces around character
Juliana Rodrigues [Sat, 27 May 2017 00:59:48 +0000 (21:59 -0300)]
staging: rtl8188eu: add spaces around character

This patch solves a checkpatch issue caused by not using spaces
around an OR sign.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: fixes block comments subsequent lines
Juliana Rodrigues [Sat, 27 May 2017 00:58:35 +0000 (21:58 -0300)]
staging: rtl8188eu: fixes block comments subsequent lines

This patch adds * on block comments subsequent lines, which were
causing a checkpatch styling warning.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8188eu: fix comments with lines over 80 characters
Juliana Rodrigues [Thu, 25 May 2017 18:30:27 +0000 (15:30 -0300)]
staging: rtl8188eu: fix comments with lines over 80 characters

This patch fixes some checkpatch errors in which comments go over
80 characters per line.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: rtl8192u: swap comparison to constant
Szilveszter Székely [Thu, 25 May 2017 18:26:06 +0000 (19:26 +0100)]
staging: rtl8192u: swap comparison to constant

Comparisons should place the constant on the right side of the test

This patch fixes coding style issues as reported by checkpatch.

Signed-off-by: Szilveszter Székely <szekelyszilv@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: fsl-dpaa2/eth: Map Tx buffers as bidirectional
Ioana Radulescu [Wed, 24 May 2017 12:13:28 +0000 (07:13 -0500)]
staging: fsl-dpaa2/eth: Map Tx buffers as bidirectional

WRIOP hardware may need to write to the hardware annotation
area of Tx buffers (e.g. frame status bits) and also to
the data area (e.g. L4 checksum in frame header).

Map these buffers as DMA_BIDIRECTIONAL, otherwise the
write transaction through SMMU will not be allowed.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: fsl-dpaa2/eth: Fix address translations
Ioana Radulescu [Wed, 24 May 2017 12:13:27 +0000 (07:13 -0500)]
staging: fsl-dpaa2/eth: Fix address translations

Use the correct mechanisms for translating a DMA-mapped IOVA
address into a virtual one. Without this fix, once SMMU is
enabled on Layerscape platforms, the Ethernet driver throws
IOMMU translation faults.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_fips_local.c - align block comments
Derek Robson [Wed, 24 May 2017 04:43:39 +0000 (16:43 +1200)]
Drivers: ccree: ssi_fips_local.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_hash.c - align block comments
Derek Robson [Wed, 24 May 2017 04:43:26 +0000 (16:43 +1200)]
Drivers: ccree: ssi_hash.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_hash.h - align block comments
Derek Robson [Wed, 24 May 2017 04:43:11 +0000 (16:43 +1200)]
Drivers: ccree: ssi_hash.h - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_ivgen.c - align block comments
Derek Robson [Wed, 24 May 2017 04:42:57 +0000 (16:42 +1200)]
Drivers: ccree: ssi_ivgen.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_pm.h - align block comments
Derek Robson [Wed, 24 May 2017 04:42:41 +0000 (16:42 +1200)]
Drivers: ccree: ssi_pm.h - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_pm_ext.c - align block comments
Derek Robson [Wed, 24 May 2017 04:42:24 +0000 (16:42 +1200)]
Drivers: ccree: ssi_pm_ext.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_pm_ext.h - align block comments
Derek Robson [Wed, 24 May 2017 04:42:08 +0000 (16:42 +1200)]
Drivers: ccree: ssi_pm_ext.h - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_request_mgr.c - align block comments
Derek Robson [Wed, 24 May 2017 04:41:49 +0000 (16:41 +1200)]
Drivers: ccree: ssi_request_mgr.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_request_mgr.h - align block comments
Derek Robson [Wed, 24 May 2017 04:41:27 +0000 (16:41 +1200)]
Drivers: ccree: ssi_request_mgr.h - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_sysfs.c - align block comments
Derek Robson [Wed, 24 May 2017 04:41:11 +0000 (16:41 +1200)]
Drivers: ccree: ssi_sysfs.c - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoDrivers: ccree: ssi_sysfs.h - align block comments
Derek Robson [Wed, 24 May 2017 04:40:32 +0000 (16:40 +1200)]
Drivers: ccree: ssi_sysfs.h - align block comments

Fixed block comment alignment, Style fix only
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: ccree: fix cc_crypto_ctx.h white spaces
Gennadii Altukhov [Fri, 26 May 2017 09:28:47 +0000 (11:28 +0200)]
staging: ccree: fix cc_crypto_ctx.h white spaces

Fix checkpatch.pl reported checks: spaces preferred around '/' and '<<' in cc_crypto_ctx.h

Signed-off-by: Gennadii Altukhov <grinrag@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: wilc1000: add missing blank line after struct declaration
Marko Stankovic [Thu, 25 May 2017 17:28:31 +0000 (19:28 +0200)]
staging: wilc1000: add missing blank line after struct declaration

Fix a missing blank line issue reported by checkpatch.pl

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: wilc1000: remove excessive blank lines
Marko Stankovic [Thu, 25 May 2017 17:28:30 +0000 (19:28 +0200)]
staging: wilc1000: remove excessive blank lines

Fix the multiple blank lines issue reported by checkpatch.pl

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: wlan-ng: hfa384x: fix several type issues.
Nikola Jelic [Tue, 23 May 2017 21:02:45 +0000 (23:02 +0200)]
staging: wlan-ng: hfa384x: fix several type issues.

There were several in-place conversions of 16 and 32-bit data, which caused
sparse to detect them. Changed them to the in situ versions, such as:
le16_to_cpu -> le16_to_cpus

Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: fbtft: Fix to avoid precedence issues
Rishiraj Manwatkar [Sat, 20 May 2017 06:33:17 +0000 (06:33 +0000)]
staging: fbtft: Fix to avoid precedence issues

Parentheses added to avoid operator precedence issues.

Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agoMerge tag 'iio-for-4.13a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Mon, 29 May 2017 13:53:42 +0000 (15:53 +0200)]
Merge tag 'iio-for-4.13a' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

First set of new device support, features and cleanups for IIO in the 4.13 cycle

Two entirely new drivers in here plus the usual range of cleanups and features.

New device support
* ad5064
  - add ltc2631, ltc2633 and ltc2635 support.
* bma180
  - trivial support for bma250e (new id)
* hid-sensor-rotation
  - add relative orientation and geometric orientation support.
* isl29028
  - add isl29030 support (its effectively the same part from a driver point of
  view)
* maxim_thermocouple
  - add max31856 id.
* meson-saradc
  - add meson8b SoC adc support.
* ti-adc084s021
  - new driver and bindings.
* ti-adc108s102
  - new driver and bindings.

Staging graduations
* isl29028

Features
* bma180
  - ACPI enumeration for BMA250E which is used in various x86 tablets.
* hi8453
  - add raw access rather than only events.
* hid-sensor-hub
  - Implement batch mode in which we can set a threshold on the amount of time
  between data coming from the fifos.  This is the first device to do this
  rather than use a watershed on the number of samples.
* hts221
  - power management support
* lsm6dsx
  - add system power management support.
* rpr0521
  - sampling frequency read / write
* stm32-trigger
  - add support for TRG02 triggers.
* tsl2583
  - runtime power management support.

Cleanups
* core
  - inkern: fix a double unlock in iio_read_available_channel_raw when raw
  value doesn't appear to be raw (error path).
  - fixup accidental sizeof pointer in iio_device_add_mask_type.
* docs
  - fix an accidental duplicated line in sysfs-bus-iio-meas-spec.
* tools
  - use local include/uapi headers to ensure always up to date.
  - increase length of allowed trigger names.
* ad9834
  - symbolic to octal permissions.
ade7753
  - symbolic to octal permissions.
  - fix indentation
ade7754
  - symbolic to octal permissions.
ade7758
  - symbolic to octal permissions.
ade7854
  - symbolic to octal permissions.
* as3935
  - move out of storm check to given consistent results for raw and processed
  values.
* bmp280
  - fix bme280 naming in Kconfig help.
* hi8435
  - avoid garbage on event after enable.
  - add missing in_voltage_sensing_mode_available to list possible enum options.
  - handle the reset gpio with the obvious polarity rather than relying on
  DT to provide it correctly.
* hid-sensors
  - fix a wrong error path scrubbing of return values.
* hid-sensors-accel
  - drop static on a local variable
* hid-sensors-rotation
  - Add missing scale and offset property parsing support.
* ina2xx
  - Fix a bad use of GENMASK and some typos and whitespace issues.
* isl29018
  - only declare the ACPI table when ACPI is enabled.
* isl29028
  - fix proximity sleep times.
* lsm6dsx
  - replace ifdef CONFIG_PM with __maybe_unused to avoid the complexity of
  dealing with the various PM config variables.
* meson-saradc
  - mark meson_sar_adc_data static and const.
* rcar-gyroadc
  - derive the interface clock speed from the fck clock on the basis they are
  the same actual clock.
  - drop the now unused if clock from the bindings.
* rpr0521
  - disable sensor when marked as such rather than always enabling it.
  - poweroff if probe fails and we can talk to device.
  - make sure device powered off when it doesn't need to be on.
  - use sizeof rather than hardcoded size on value read.
  - whitespace fixup.
  - reorder channel numbers ready for buffered support which didn't quite
  make this pull request.
* st-accel
  - fix platform data initialization to allow remove and reprobe.
* st-pressure
  - fix platform data initialization to allow remove and reprobe.
* tsl2x7x
  - S_IRUGO, S_IWUSR to octal values
  - rename driver for consistency with more recent drivers
  - drop FSF mailing address
  - replace DEVICE_ATTR macros with the shorter DEVICE_ATTR_RW form and
  relevant function renames.
* zpa2326
  - report an error for consistency with other error paths.

7 years agodgnc: fix multiple blank lines coding style problem
Aliza Minkov [Thu, 25 May 2017 13:46:45 +0000 (16:46 +0300)]
dgnc: fix multiple blank lines coding style problem

According to the coding-style documentation, functions in source files
should be separated with one blank line. Redundant blank lines were
removed from this source file, in accordance with coding-style
documentation.

Signed-off-by: Aliza Minkov <minkov.al@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vt6655: align function parameters to open parenthesis
Marko Stankovic [Tue, 23 May 2017 22:25:24 +0000 (00:25 +0200)]
staging: vt6655: align function parameters to open parenthesis

Alignment styles are used interchangeably, align parameters to open
parenthesis and fix issues reported by checkpatch.pl

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agodrivers/staging/speakup: fix indent coding style problem in spk_ttyio.c
Rui Teng [Tue, 23 May 2017 02:04:15 +0000 (10:04 +0800)]
drivers/staging/speakup: fix indent coding style problem in spk_ttyio.c

This is a patch to the spk_ttyio.c file which fixes up the indent error
reported by the checkpatch.pl tool.

Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vt6655: remove unnecessary blank lines
Marko Stankovic [Mon, 22 May 2017 23:19:44 +0000 (01:19 +0200)]
staging: vt6655: remove unnecessary blank lines

Fix unnecessary blank lines issues reported by checkpatch.pl

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vt6655: replace NULL comparison with '!' operator
Marko Stankovic [Mon, 22 May 2017 23:19:43 +0000 (01:19 +0200)]
staging: vt6655: replace NULL comparison with '!' operator

Fix comparison to NULL issues reported by checkpatch.pl

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: vt6655: add spaces around '%' operator
Marko Stankovic [Sat, 20 May 2017 16:50:37 +0000 (18:50 +0200)]
staging: vt6655: add spaces around '%' operator

Fix checkpatch issue by adding spaces around the '%' operator

Signed-off-by: Marko Stankovic <dartnorris@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: android: ion: set init function as static
Paolo Cretaro [Thu, 18 May 2017 21:59:41 +0000 (23:59 +0200)]
staging: android: ion: set init function as static

Fix warning issued by sparse:
symbol 'ion_device_create' was not declared. Should it be static?

Signed-off-by: Paolo Cretaro <melko@frugalware.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: speakup: signedness bug in spk_ttyio_in_nowait()
Dan Carpenter [Fri, 19 May 2017 21:27:18 +0000 (00:27 +0300)]
staging: speakup: signedness bug in spk_ttyio_in_nowait()

On most of the common arches char is signed so it can't ever == 0xff.
Let's fix this by making it a u8.

Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: remove channel_addr check in handle_command
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:59 +0000 (16:17 -0400)]
staging: unisys: visorbus: remove channel_addr check in handle_command

Removed a check for physaddr=0 in handle_command() function in
visorchipset.c.

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: add comment to explain polling logic in controlvm_periodic...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:58 +0000 (16:17 -0400)]
staging: unisys: visorbus: add comment to explain polling logic in controlvm_periodic_work

Added a comment to explain polling frequency variation logic in
controlvm_periodic_logic() in visorchipset.c.

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: include: renamed structure spar_io_channel_protocol in iochannel...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:57 +0000 (16:17 -0400)]
staging: unisys: include: renamed structure spar_io_channel_protocol in iochannel.h to match driver namespace

Renamed structure spar_io_channel_protocol to visor_io_channel and
changed "visor bus" to "visorbus" in a comment in visornic_main.c
and visorhba_main.c.

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: include: renamed #defines in iochannel.h to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:56 +0000 (16:17 -0400)]
staging: unisys: include: renamed #defines in iochannel.h to match driver namespace

Renamed #defines
* ULTRA_VHBA_CHANNEL_PROTOCOL_SIGNATURE to
VISOR_VHBA_CHANNEL_SIGNATURE
* ULTRA_VNIC_CHANNEL_PROTOCOL_SIGNATURE to
VISOR_VNIC_CHANNEL_SIGNATURE
* ULTRA_VSWITCH_CHANNEL_PROTOCOL_SIGNATURE to
VISOR_VSWITCH_CHANNEL_SIGNATURE
* ULTRA_VHBA_CHANNEL_PROTOCOL_VERSIONID to
VISOR_VHBA_CHANNEL_VERSIONID
* ULTRA_VNIC_CHANNEL_PROTOCOL_VERSIONID to
VISOR_VNIC_CHANNEL_VERSIONID
* ULTRA_VSWITCH_CHANNEL_PROTOCOL_VERSIONID to
VISOR_VSWITCH_CHANNEL_VERSIONID
* SPAR_VHBA_CHANNEL_OK_CLIENT to VISOR_VHBA_CHANNEL_OK_CLIENT
* SPAR_VNIC_CHANNEL_OK_CLIENT to VISOR_VNIC_CHANNEL_OK_CLIENT

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: include: renamed #defines in channel.h to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:55 +0000 (16:17 -0400)]
staging: unisys: include: renamed #defines in channel.h to match driver namespace

Renamed #defines
* ULTRA_CHANNEL_PROTOCOL_SIGNATURE to
VISOR_CHANNEL_SIGNATURE
* SPAR_CHANNEL_SERVER_READY to
VISOR_CHANNEL_SERVER_READY
* ULTRA_VALID_CHANNELCLI_TRANSITION
VISOR_VALID_CHANNELCLI_TRANSITION
* ULTRA_CLIERRORBOOT_THROTTLEMSG_DISABLED to
VISOR_CLIERRORBOOT_THROTTLEMSG_DISABLED
* ULTRA_CLIERRORBOOT_THROTTLEMSG_NOTATTACHED to
VISOR_CLIERRORBOOT_THROTTLEMSG_NOTATTACHED
* ULTRA_CLIERRORBOOT_THROTTLEMSG_BUSY to
VISOR_CLIERRORBOOT_THROTTLEMSG_BUSY
* ULTRA_IO_DRIVER_ENABLES_INTS to
VISOR_DRIVER_ENABLES_INTS
* ULTRA_IO_CHANNEL_IS_POLLING to
VISOR_CHANNEL_IS_POLLING
* ULTRA_IO_IOVM_IS_OK_WITH_DRIVER_DISABLING_INTS to
VISOR_IOVM_OK_DRIVER_DISABLING_INTS
* ULTRA_IO_DRIVER_DISABLES_INTS to
VISOR_DRIVER_DISABLES_INTS
* ULTRA_IO_DRIVER_SUPPORTS_ENHANCED_RCVBUF_CHECKING to
VISOR_DRIVER_ENHANCED_RCVBUF_CHECKING
* ULTRA_CHANNEL_ENABLE_INTS to
VISOR_CHANNEL_ENABLE_INTS
* SPAR_VHBA_CHANNEL_PROTOCOL_UUID to VISOR_VHBA_CHANNEL_UUID
* SPAR_VHBA_CHANNEL_PROTOCOL_UUID_STR to
VISOR_VHBA_CHANNEL_UUID_STR
* SPAR_VNIC_CHANNEL_PROTOCOL_UUID to VISOR_VNIC_CHANNEL_UUID
* SPAR_VNIC_CHANNEL_PROTOCOL_UUID_STR to
VISOR_VNIC_CHANNEL_UUID_STR
* SPAR_SIOVM_UUID to VISOR_SIOVM_UUID

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: include: renamed function spar_check_channel in channel.h to match...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:54 +0000 (16:17 -0400)]
staging: unisys: include: renamed function spar_check_channel in channel.h to match driver namespace

Renamed function spar_check_channel() to visor_check_channel().

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorinput: removed enum in ultrainputreport.h to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:53 +0000 (16:17 -0400)]
staging: unisys: visorinput: removed enum in ultrainputreport.h to match driver namespace

Removed enum ultra_inputaction in ultrainputreport.h and changed
elements to #defnes.

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorinput: renamed structures in ultrainputreport.h to match driver...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:52 +0000 (16:17 -0400)]
staging: unisys: visorinput: renamed structures in ultrainputreport.h to match driver namespace

Renamed structures
* ultra_inputactivity to visor_inputactivity
* ultra_inputreport to visor_inputreport

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorinput: renamed #defines in visorinput.c to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:51 +0000 (16:17 -0400)]
staging: unisys: visorinput: renamed #defines in visorinput.c to match driver namespace

Renamed #defines
* SPAR_KEYBOARD_CHANNEL_PROTOCOL_UUID to
VISOR_KEYBOARD_CHANNEL_UUID
* SPAR_KEYBOARD_CHANNEL_PROTOCOL_UUID_STR to
VISOR_KEYBOARD_CHANNEL_UUID_STR
* SPAR_MOUSE_CHANNEL_PROTOCOL_UUID to
VISOR_MOUSE_CHANNEL_UUID
* SPAR_MOUSE_CHANNEL_PROTOCOL_UUID_STR to
VISOR_MOUSE_CHANNEL_UUID_STR

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: renamed enum in controlvmchannel.h to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:50 +0000 (16:17 -0400)]
staging: unisys: visorbus: renamed enum in controlvmchannel.h to match driver namespace

Renamed enum and its members
* ultra_chipset_feature to visor_chipset_feature
* ULTRA_CHIPSET_FEATURE_REPLY to VISOR_CHIPSET_FEATURE_REPLY
* ULTRA_CHIPSET_FEATURE_PARA_HOTPLUG to
VISOR_CHIPSET_FEATURE_PARA_HOTPLUG

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: renamed structures in controlvmchannel.h to match driver...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:49 +0000 (16:17 -0400)]
staging: unisys: visorbus: renamed structures in controlvmchannel.h to match driver namespace

Renamed structures
* spar_segment_state to visor_segment_state
* efi_spar_indication to efi_visor_indication
* spar_controlvm_channel_protocol to visor_controlvm_channel
* spar_controlvm_parameters_header to
visor_controlvm_parameters_header

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: renamed #defines in controlvmchannel.h to match driver...
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:48 +0000 (16:17 -0400)]
staging: unisys: visorbus: renamed #defines in controlvmchannel.h to match driver namespace

Renamed #defines
* SPAR_CONTROLVM_CHANNEL_PROTOCOL_UUID to
VISOR_CONTROLVM_CHANNEL_UUID
* ULTRA_CONTROLVM_CHANNEL_PROTOCOL_SIGNATURE to
VISOR_CONTROLVM_CHANNEL_SIGNATURE
* ULTRA_CONTROLVM_CHANNEL_PROTOCOL_VERSIONID to
VISOR_CONTROLVM_CHANNEL_VERSIONID
* SPAR_CONTROLVM_CHANNEL_OK_CLIENT to
VISOR_CONTROLVM_CHANNEL_OK_CLIENT

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
7 years agostaging: unisys: visorbus: renamed #defines in visorchipset.c to match driver namespace
Sameer Wadgaonkar [Fri, 19 May 2017 20:17:47 +0000 (16:17 -0400)]
staging: unisys: visorbus: renamed #defines in visorchipset.c to match driver namespace

Renamed #defines
* UNISYS_SPAR_LEAF_ID to UNISYS_VISOR_LEAF_ID
* UNISYS_SPAR_ID_EBX to UNISYS_VISOR_ID_EBX
* UNISYS_SPAR_ID_ECX to UNISYS_VISOR_ID_ECX
* UNISYS_SPAR_ID_EDX to UNISYS_VISOR_ID_EDX

Signed-off-by: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>