Richard Kennedy [Wed, 17 Mar 2010 14:40:55 +0000 (14:40 +0000)]
Staging: wlan-ng: tidy up iw_handler
Use array initialisation technique copied from ipw2200.c.
This should always get the function pointers in the correct place,
without the needed for endless counting, skipping blanks etc.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Edgardo Hames [Tue, 16 Mar 2010 02:00:40 +0000 (23:00 -0300)]
Staging: wlan-ng: rework code style after feedback
This patch includes the feedback received from Richard Kennedy.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 19:27:42 +0000 (21:27 +0200)]
Staging: wlan-ng: fix spaces coding style issue in p80211conv.c
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Fri, 2 Apr 2010 08:57:35 +0000 (10:57 +0200)]
Staging: winbond: wbusb.c Coding style fixes.
I fixed the reported checkpatch.pl problems except for a bunch of
long lines and some printk:s.
I also removed versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 20:05:32 +0000 (22:05 +0200)]
Staging: winbond: wbusb_s.h Coding style fixes.
I fixed comments and some spacing.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 20:00:13 +0000 (22:00 +0200)]
Staging: winbond: wblinux_f.h Coding style fixes v2.
I fixed whitespace and comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 19:52:37 +0000 (21:52 +0200)]
Staging: winbond: wbhal_s.h Coding style fixes.
I fixed checkpatch warnings except some long lines and typedefs.
I also removed versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 17:10:59 +0000 (19:10 +0200)]
Staging: winbond: wbhal_f.h Coding style fixes.
I fixed all checkpatch problems and also converted the
function arguments from hungarian notation and CamelCase.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 06:38:57 +0000 (08:38 +0200)]
Staging: winbond: wb35rx.c Coding style fixes v2.
New patch that fixes an unclear comment too.
I fixed checkpatch issues except for long lines and printk:s.
I also removed version comments and the () in a return statement.
Generated .o is identical to master and i checked the code with
Dan Carpenters strip_whitespace.pl and diff.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 06:57:55 +0000 (08:57 +0200)]
Staging: winbond: wb35tx_f.h Coding style fixes.
I fixed the checkpatch.pl problems and converted the function
arguments away from CamelCase and hungarian notation.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 25 Mar 2010 13:44:53 +0000 (14:44 +0100)]
Staging: winbond: wb35reg.c Coding style fixes
I fixed the problems reported by checkpatch.pl excetp for
long lines, a couple of printks and some warnings about usb_free_urb(NULL).
I checked for regressions with Dan Carpenters strip_whitespace.pl
and diff and everything looks good.
Generated .o is identical to master.
This is a new patch against master where I fixed up a switch-statement
after comments from Pavel Machek.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 22 Mar 2010 18:47:48 +0000 (20:47 +0200)]
Staging: winbond: fix comments and space coding style issue in mlmetxrx_f.h
This is a patch to the mlmetxrx_f.h file that fixed up a comments and
space Errors found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 22 Mar 2010 18:41:44 +0000 (20:41 +0200)]
Staging: winbond: fix brace, comments and space coding style issue in mlmetxrx.c
This is a patch to the mlmetxrx.c file that fixed up a brace, comments
and space Errors found by the checkpatch.pl tool.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Mon, 22 Mar 2010 17:59:58 +0000 (18:59 +0100)]
Staging: winbond: wb35reg_s.h Coding styls fixes.
I fixed all problems reported by checkpatch.pl except
some long lines. I also removed commented away code and
revision comments.
Checked for regressions with Dan Carpenters
strip_whitespace.pl and diff.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Mon, 22 Mar 2010 10:55:30 +0000 (11:55 +0100)]
Staging: winbond: wb35reg_f.h Coding style fixes.
I fixed the checkpatch things except a couple of long lines.
I also removed hungarian notation and CamelCase from the argument names
and some "commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 21 Mar 2010 21:31:30 +0000 (22:31 +0100)]
Staging: winbond: sysdef.h Coding style fixes.
I fixed the C99 comments and removed commented away code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 21 Mar 2010 16:55:03 +0000 (17:55 +0100)]
Staging: winbond: sme_api.h Coding style fixes.
I fixed the things reported by checkpatch.pl except
one long line and a __inline.
I also removed commented away code and versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 21 Mar 2010 16:50:42 +0000 (17:50 +0100)]
Staging: winbond: reg.c Coding style fixes
I fixed all problems reported by checkpatch.pl except some
(a lot of) long lines and some printk:s.
I removed "commented away" code and version comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sat, 20 Mar 2010 19:43:59 +0000 (20:43 +0100)]
Staging: winbond: scan_s.h Coding style fixes.
I fixed all things reported by checkpatch.pl except a couple
of long lines and typedefs.
I also removed "commented away" code and a history comment.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 14:46:35 +0000 (16:46 +0200)]
Staging: winbond: fix brace and space coding style issue in mac_structures.h
This is a patch to the mac_structures.h file that fixed up a brace and
space Errors found by the checkpatch.pl tool.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 14:29:01 +0000 (16:29 +0200)]
Staging: winbond: fix comments coding style issue in mac_structures.h
This is a patch to the mac_structures.h file that fixed up a comments
Errors found by the checkpatch.pl tool
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 13:37:21 +0000 (15:37 +0200)]
Staging: winbond: fix comments coding style issue in core.h
This is a patch to the core.h file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Fri, 19 Mar 2010 23:26:45 +0000 (00:26 +0100)]
Staging: winbond: mto.c Coding style fixes
I changed all things reported by checkpatch.pl except some long lines
and the use of externs in a .c file. I also removed revision comments
and "commented out" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Fri, 19 Mar 2010 20:43:25 +0000 (21:43 +0100)]
Staging: winbond: mto.h Coding style fixes
I fixed all problems reported by checkpatch.pl except for a couple of
long lines. I also removed version comments and removed "commented away"
code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sankar P [Fri, 19 Mar 2010 20:41:02 +0000 (02:11 +0530)]
Staging: winbond: Remove typedef for standard types
Remove the typedef named "fixed" used for the standard type s32
Signed-off-by: Sankar P <sankar.curiosity@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sankar P [Fri, 19 Mar 2010 20:41:01 +0000 (02:11 +0530)]
Staging: winbond: Convert typedef struct _STRUCT_SELECTOR
This patch converts the declaration typedef struct _STRUCT_SELECTOR
to struct struct_selector and also the places where it was used.
Signed-off-by: Sankar P <sankar.curiosity@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sankar P [Fri, 19 Mar 2010 20:41:00 +0000 (02:11 +0530)]
Staging: winbond: Remove unused enum enum_PowerManagementMode
Signed-off-by: Sankar P <sankar.curiosity@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Sankar P [Fri, 19 Mar 2010 20:40:59 +0000 (02:10 +0530)]
Staging: winbond: Convert typedef struct _PMKID to struct pmkid
This patch converts the definition typedef struct _PMKID to
struct pmkid and also the part where the typedef was used.
Signed-off-by: Sankar P <sankar.curiosity@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 18 Mar 2010 15:45:06 +0000 (16:45 +0100)]
Staging: winbond: mlme_s.h Coding style fixes
I fixed all problems found by checkpatch.pl except typedefs.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 18 Mar 2010 14:43:36 +0000 (15:43 +0100)]
Staging: winbond: mds_s.h coding style fixes.
I fixed all problems reported by checkpatch.pl except some
long lines.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 18 Mar 2010 08:54:53 +0000 (09:54 +0100)]
Staging: winbond: mds_f.h whitespace and CamelCase corrections.
I fixed the whitespaces, the C99 comment and the CamelCase
parameter names.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Wed, 17 Mar 2010 21:33:27 +0000 (22:33 +0100)]
Staging: winbond: phy_calibration.h coding style cleanup.
I fixed all checkpatch.pl problems, removed versioning comments and
"commented away" code.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 14:13:04 +0000 (16:13 +0200)]
Staging: wavelan: fix initialise statics to 0 in wavelan_cs.p.h
This is a patch to the wavelan_cs.p.h fix initialise statics to 0
Errors found by the checkpatch.pl tools, like
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 14:05:09 +0000 (16:05 +0200)]
Staging: wavelan: fix macros, spaces and TAB coding style issue in wavelan_cs.p.h
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
and
Macros complex expr -> (complex expr)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 13:21:30 +0000 (15:21 +0200)]
Staging: wavelan: fix spaces and TAB coding style issue in wavelan_cs.h
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 12:58:01 +0000 (14:58 +0200)]
Staging: wavelan: fix spaces and TAB coding style and macros issue in wavelan.p.h
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
and
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 12:45:27 +0000 (14:45 +0200)]
Staging: wavelan: fix spaces and TAB coding style issue in wavelan.h
This is a patch to the wavelan.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 12:24:21 +0000 (14:24 +0200)]
Staging: wavelan: fix spaces and TAB coding style issue in i82586.h
This is a patch to the i82586.h file that fixed up a TAB and
spaces Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: space required before the open brace '{'
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Mon, 26 Apr 2010 08:49:10 +0000 (10:49 +0200)]
Staging: iio: iio_trigger_find_by_name: Skip trailing newline if available
Skip trailing newline if available.
Signed-off-by: Michael Hennerich <Michael.Hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Hennerich [Mon, 26 Apr 2010 08:36:36 +0000 (10:36 +0200)]
Staging: iio: iio-trig-gpio: Remove redundant gpio_request
Remove redundant gpio_request:
The GPIO used as trigger IRQ, is also requested as gpio, but actually never read.
Use platform resource facility to get IRQs numbers and flags.
Make sure this driver can be used with any system IRQ, not necessarily limited to GPIO-IRQs.
Use dev_err(dev...) and friends instead of printk(KERN_ERR...)
Signed-off-by: Michael Hennerich <Michael.Hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Barry Song [Mon, 26 Apr 2010 04:19:01 +0000 (12:19 +0800)]
Staging: iio: fix typo in userspace example codes and document
Signed-off-by: Barry Song <21cnbao@gmail.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andrea Gelmini [Thu, 25 Mar 2010 17:22:37 +0000 (18:22 +0100)]
Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include
drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c: dirent.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Sprecher [Wed, 17 Mar 2010 20:15:44 +0000 (21:15 +0100)]
staging: usbip: fix coding style issues in the usbip driver
This is a patch to the usbip driver that fixes up some coding style
issues found by the checkpack.pl tool
Signed-off-by: Michael Sprecher <sprecher.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 15:06:44 +0000 (17:06 +0200)]
Staging: usbip: fix space before tab in vhci_hcd.c
This is a patch to the vhci_hcd.c fix space before tab
warning found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 15:00:57 +0000 (17:00 +0200)]
Staging: usbip: fix space before tab in usbip_common.h
This is a patch to the usbip_common.h fix space before tab
warning found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Chihau Chau [Thu, 15 Apr 2010 21:01:37 +0000 (17:01 -0400)]
Staging: dream: smd: smd_qmi: fix code style issues
This fixes some code style issues detected with the checkpatch.pl
script, like not necessary braces {} in some if and else statements and
include a KERN_INFO facility level in a printk() function.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Chihau Chau [Sat, 10 Apr 2010 19:14:38 +0000 (15:14 -0400)]
Staging: dream: pmem: fix some code style issues
This fixes some code style issues like prohibited spaces after that open
parenthesis '(' and before that close parenthesis ')', and lines over 80
characters.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Hemanth V [Thu, 1 Apr 2010 13:16:27 +0000 (18:46 +0530)]
Staging: dream: Synaptic: Add threaded IRQ support
Signed-off-by: Hemanth V <hemanthv@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Hemanth V [Thu, 1 Apr 2010 13:16:19 +0000 (18:46 +0530)]
Staging: dream: Synaptic: Remove non-standard multi touch support
Signed-off-by: Hemanth V <hemanthv@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wolfram Sang [Sat, 20 Mar 2010 14:13:01 +0000 (15:13 +0100)]
Staging: go7007: fix dangling i2c pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wolfram Sang [Sat, 20 Mar 2010 14:13:00 +0000 (15:13 +0100)]
Staging: dream: fix dangling i2c pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Chihau Chau [Mon, 15 Mar 2010 03:29:02 +0000 (00:29 -0300)]
Staging: dream: smd: smd_private: fix code style issues
This put open braces '{' following structs on the same line.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Chihau Chau [Mon, 15 Mar 2010 03:44:54 +0000 (00:44 -0300)]
Staging: dream: smd: smd_qmi: fix code style issues
This fixes some code style issues about to #include <linux/uaccess.h>
instead of <asm/uaccess.h> and some not necessary braces {}.
Signed-off-by: Chihau Chau <chihau@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vikram Dhillon [Mon, 15 Mar 2010 00:39:30 +0000 (20:39 -0400)]
Staging: arlan: arlan.h: Fixed some style issues
Fixed some style issues in accordance with checkpatch.pl. Before the
patch contained "total: 2 errors, 186 warnings, 535 lines checked" and
now it has: total: 0 errors, 170 warnings. Most of the warnings that
remain now are the line over 80 chars ones.
Signed-off-by: Vikram Dhillon <dhillonv10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:07 +0000 (22:17 -0700)]
Staging: wlags49_h2: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:06 +0000 (22:17 -0700)]
Staging: vt6656: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:05 +0000 (22:17 -0700)]
Staging: vt6655: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:04 +0000 (22:17 -0700)]
Staging: rtl8192u: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:03 +0000 (22:17 -0700)]
Staging: rtl8192su: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:02 +0000 (22:17 -0700)]
Staging: rtl8192e: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:01 +0000 (22:17 -0700)]
Staging: rtl8187se: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:00 +0000 (22:17 -0700)]
Staging: rt2870: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:59 +0000 (22:16 -0700)]
Staging: rt2860: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:58 +0000 (22:16 -0700)]
Staging: otus: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:57 +0000 (22:16 -0700)]
Staging: otus: 80211core: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:55 +0000 (22:16 -0700)]
Staging: cx25821: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Mon, 22 Mar 2010 21:36:20 +0000 (22:36 +0100)]
Staging: vt6655: CGI/CSI confusion in device_ioctl()
The wrong messages were printed
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Steven Harms [Thu, 18 Mar 2010 14:15:59 +0000 (10:15 -0400)]
Staging: vt6655: Convert C99 style comments, remove spaces between function definitions and parenthesis
Converted C99 style comments to kernel style guideline complianet
comments. Removed spaces between function definitions and parenthesis.
These were indicated as problems by checkpatch tool.
Fixed typo found by Gabor Stefanik
Signed-off-by: Steven Harms <sharms@ubuntu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Peter Huewe [Mon, 26 Apr 2010 22:34:49 +0000 (00:34 +0200)]
Staging: otus: Add null check and fix coding style issue
This patch removes mixing of declarations and code and adds a null-test
after a kmalloc.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vikram Dhillon [Sun, 4 Apr 2010 05:22:53 +0000 (01:22 -0400)]
Staging: Otus: Hal: hpani.c Fixed some style issues
Fixed some style issues in accordance with checkpatch.pl
Signed-by: Vikram Dhillon <opensolarisdev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sun, 28 Mar 2010 11:48:10 +0000 (14:48 +0300)]
Staging: otus: hpani: using the wrong variable
We're updating the "HpPriv->ani" array here so we should use that to
determine the end of the for loop. "HpPriv->ani" has 50 elements and
"wd->regulationTable.allowChannel" has 59 elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Steven Harms [Sun, 14 Mar 2010 15:56:00 +0000 (11:56 -0400)]
Staging: otus: Remove mix of tabs and spaces with just tabs in ioctl.c
Previously defines had a mix of both tabs and spaces, causing an error
in the checkpatch tool. These tabs and spaces have been consolidated to
only tabs.
Signed-off-by: Steven Harms <sharms@ubuntu.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Neil Munro [Tue, 20 Apr 2010 00:06:33 +0000 (01:06 +0100)]
Staging: rt2860: rtmp.h: Fixed all bar one error.
All simple errors have been removed, including +80 line character limits
and various pointer syntax isues.
Signed-off-by: Neil Munro <neilmunro@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Trey Evans [Mon, 19 Apr 2010 20:15:37 +0000 (16:15 -0400)]
Staging: rt2860: fix usb_main_dev.c style errors
Correct several style errors related to pointers in usb_main_dev.c.
Signed-off-by: Trey Evans <lewis.r.evans@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Sat, 3 Apr 2010 08:29:13 +0000 (14:29 +0600)]
Staging: rt2860: fix coding style issue in mac_pci.h, mac_usb.h, rtmp_mac.h, rtmp_phy.h
This is a patch to the mac_pci.h, mac_usb.h, rtmp_mac.h, rtmp_phy.h files
that fixes up errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 20:18:51 +0000 (01:18 +0500)]
Staging: rt2860: fix coding style issue in rt3070.c, rt3090.c, rt30xx.c
This is a patch to the rt3070.c, rt3090.c, rt30xx.c files that fixes up
errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 18:22:41 +0000 (23:22 +0500)]
Staging: rt2860: fix coding style issue in rt_usb.c
This is a patch to the rt_usb.c file that fixes up errors found by the
checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 18:10:32 +0000 (23:10 +0500)]
Staging: rt2860: fix coding style issue in rt_pci_rbus.c
This is a patch to the rt_pci_rbus.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 17:57:50 +0000 (22:57 +0500)]
Staging: rt2860: fix coding style issue in rt_main_dev.c
This is a patch to the rt_main_dev.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Thu, 18 Mar 2010 09:56:47 +0000 (14:56 +0500)]
Staging: rt2860: fix coding style issue in rt_linux.c
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ben Hutchings [Mon, 29 Mar 2010 00:24:45 +0000 (01:24 +0100)]
Staging: rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe
To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
change the type of the first parameter to linux_pci_{map,unmap}_single()
from void * to struct rt_rtmp_adapter *. Also do not define the macros
PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
not used and if they were that would be a bug.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:50:20 +0000 (17:50 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in inode.c
This is a patch to the inode.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 16:08:05 +0000 (18:08 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
WARNING found by the checkpatch.pl tools, like
WARNING: please, no space before tabs
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 16:00:08 +0000 (18:00 +0200)]
Staging: pohmelfs: fix comments, spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:39:46 +0000 (17:39 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in dir.c
This is a patch to the dir.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:11:03 +0000 (17:11 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in config.c
This is a patch to the config.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like:
ERROR: switch and case should be at the same indent
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:25:09 +0000 (17:25 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in crypto.c
This is a patch to the crypto.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:03:04 +0000 (17:03 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in net.c
This is a patch to the net.c file that fixed up a TAB and spaces Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 28 Apr 2010 00:04:16 +0000 (17:04 -0700)]
Staging: dt3155: remove "inline" usage
It was wrong, and not doing what anyone would think it would do.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:53:59 +0000 (16:53 -0700)]
Staging: dt3155: rename dt3155_fbuffer_s
drop the "_s" as it's not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:51:50 +0000 (16:51 -0700)]
Staging: dt3155: rename dt3155_config_s
Drop the "_s", as it's not needed.
Now, dt3155.h is checkpatch.pl clean.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:49:23 +0000 (16:49 -0700)]
Staging: dt3155: remove dt3155_read_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:47:55 +0000 (16:47 -0700)]
Staging: dt3155: remove dt3155_status_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:45:27 +0000 (16:45 -0700)]
Staging: dt3155: remove frame_info_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:06:14 +0000 (16:06 -0700)]
Staging: dt3155: remove TRUE/FALSE
These aren't needed in the kernel, so remove them.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:04:13 +0000 (16:04 -0700)]
Staging: dt3155.h: remove #ifdef
We are in the kernel now, don't check to see if we are not.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Mon, 29 Mar 2010 07:34:29 +0000 (00:34 -0700)]
Staging: dt3155: allocator.c: sparse cleanups
Make prototypes match implementation
Use gfp_t flags not int prio
Still a couple of sparse warnings left
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Baldus [Sun, 28 Mar 2010 13:59:37 +0000 (09:59 -0400)]
Staging: dt3155: fix parentheses and bracket spacing style issues
This is a patch to the dt3155_drv.c file that removes spaces after open
parentheses and brackets and before close parentheses and brackets.
Signed-off-by: Jason Baldus <jason.baldus@gmail.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Sat, 13 Mar 2010 19:35:17 +0000 (00:35 +0500)]
Staging: dt3155: fix coding style issue in dt3155_isr.c
This is a patch to the dt3155_isr.c file that fixes up a coding
style warning and errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Thu, 8 Apr 2010 11:49:36 +0000 (19:49 +0800)]
Staging: crystalhd: remove unused #include <linux/version.h>
Remove unused #include <linux/version.h>('s) in
drivers/staging/crystalhd/crystalhd_lnx.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>