Malcolm Priestley [Sat, 17 May 2014 08:50:39 +0000 (09:50 +0100)]
staging: vt6656: Remove always true bUpdateBBVGA
Remove true if statements.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:38 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables.
byBBCR4d
byBBCRc9
byBBCR88
byBBCR09
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:37 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables
byFOETuning
byAutoPwrTunning
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:36 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables.
dwAotoRateTxOkCnt
dwAotoRateTxFailCnt
dwErrorRateThreshold
dwTPTable
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:35 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable byACKRate.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:34 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable uScanTime.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:33 +0000 (09:50 +0100)]
staging: vt6656: Remove dead variable bCCK.
bCCK is always true remove all false conditions and
local variable.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:32 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable ulTxPower.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:31 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable byRevId.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:30 +0000 (09:50 +0100)]
staging: vt6656: rndis.h move all to device.h
Commands macros are common to all source files.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:29 +0000 (09:50 +0100)]
staging: vt6656: rndis.h remove dead code.
Remove dead structures and macros.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:28 +0000 (09:50 +0100)]
staging: vt6656: srom.h move all macros to device.h
Remove srom.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:27 +0000 (09:50 +0100)]
staging: vt6656: srom.h : Remove dead code.
Remove macros and unused strutures.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:26 +0000 (09:50 +0100)]
staging: vt6656: desc.h Remove unused macros
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:25 +0000 (09:50 +0100)]
staging: vt6656: device.h remove dead macros
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:24 +0000 (09:50 +0100)]
staging: vt6656: device_cfg.h Move macros to device.h
Remove device_cfg.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:23 +0000 (09:50 +0100)]
staging: vt6656: device_cfg.h remove dead code.
Also unneeded #ifndef
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:22 +0000 (09:50 +0100)]
staging: vt6656: PIPEnsControlIn remove camel case.
Camel case changes
pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus
->
priv, request, value, index, length, buffer, status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:21 +0000 (09:50 +0100)]
staging: vt6656: PIPEnsControlOut remove camel case.
Camel case changes
pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus
->
priv, request, value, index, length, buffer, status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:20 +0000 (09:50 +0100)]
staging: vt6656: usbpipe: replace debug messsages.
Replace all DBG_PRT wiht dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:19 +0000 (09:50 +0100)]
staging: vt6656: usbpipe: get rid of in/out debug messages.
Remove all in/out debug messages.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:18 +0000 (09:50 +0100)]
staging: vt6656: rf.c additional power.
Provides extra power on weak RSSI.
The values orginate from the vendors driver.
It is applied later in RFbRawSetPower to simplify and check that it doesn't
exceed the max power.
Vendor driver VT6656_Linux_src_v1.21.03_x86_11.04.zip
http://www.viaembedded.com/servlet/downloadSvl?id=1890&download_file_id=14704
This is GPL-licensed code.
vendors code
...
if (pDevice->byRFType == RF_VT3226D0) {
if (lRSSI == 0){
lAdditionalPower = 7;
}
else if ((lRSSI < -60) && (lRSSI >= -65)){
lAdditionalPower = 5;
//lAdditionalPower = 9;
}
else if ((lRSSI < -65) && (lRSSI >= -70)){
lAdditionalPower = 7;
//lAdditionalPower = 9;
}
else if ((lRSSI < -70) && (lRSSI >= -80)){
lAdditionalPower = 9;
}
else if (lRSSI < -80) {
lAdditionalPower = 9;
}
}
else {
if (lRSSI == 0){
lAdditionalPower = 7;
}
else if ((lRSSI < -70) && (lRSSI >= -75)){
lAdditionalPower = 5;
}
else if ((lRSSI < -75) && (lRSSI >= -80)){
lAdditionalPower = 7;
}
else if (lRSSI < -80) {
lAdditionalPower = 9;
}
}
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 20:32:53 +0000 (21:32 +0100)]
staging: unisys: visorutil: Add a blank line
Add a blank line after declarations to meet kernel coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:35 +0000 (12:38 -0400)]
staging: unisys: remove remaining proc directory entries
Finally, remove /proc/uislib and all remaining, redundant entries created
under /proc/uislib/vbus.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:34 +0000 (12:38 -0400)]
staging: unisys: move uislib/info proc entry to debugfs
Convert /proc/uislib/info to an equivalent entry under debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:33 +0000 (12:38 -0400)]
staging: unisys: remove functions made redundant in uislib.c
The patches to move proc files have made the functions
uislib_proc_read_writeonly() and stop_chipset() redundant. Remove them.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:32 +0000 (12:38 -0400)]
staging: unisys: move uislib/smart_wakeup proc entry to debugfs
Convert /proc/uislib/smart_wakeup to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:31 +0000 (12:38 -0400)]
staging: unisys: move uislib/cycles_before_wait proc entry to debugfs
Convert /proc/uislib/cycles_before_wait to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:30 +0000 (12:38 -0400)]
staging: unisys: move uislib/platform proc entry to debugfs
Convert /proc/uislib/platform to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:29 +0000 (12:38 -0400)]
staging: unisys: remove testing proc interfaces from uislib
Several proc interfaces in the uislib module were intended for debug and
testing during initial driver development. They are no longer needed, so
we should remove them from the module.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 6 May 2014 13:58:23 +0000 (09:58 -0400)]
staging: unisys: Replace GUID with uuid_le
This patch replaces the GUID type with uuid_le. It removes the header file
guidutils.h, updates all uses of the GUID type to uuid_le, and replaces all
function calls that used the GUID type with their uuid_le equivalents.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Mon, 28 Apr 2014 17:23:14 +0000 (12:23 -0500)]
Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")
The visorutil module was lacking license info.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Mon, 28 Apr 2014 17:23:13 +0000 (12:23 -0500)]
Staging: unisys: detect s-Par firmware
This patch adds support for detection of s-Par firmware by checking for
the hypervisor bit in the CPU capabilities, and then querying the hypervisor
ID cpuid leaf.
This functionality will be used by the unisys drivers to determine if
they are being loaded on an s-Par platform and refuse to load if no
s-Par firmware is present.
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Ken Cox <jkc@redhat.com>
Tested by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fredrick John Berchmans [Sun, 4 May 2014 04:42:14 +0000 (21:42 -0700)]
staging: lustre: fix unused variable warnings
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Fredrick John Berchmans <fredrickprashanth@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vitaly Osipov [Sun, 4 May 2014 04:14:26 +0000 (14:14 +1000)]
staging: lustre: return -EFAULT instead of bytes remaining
return -EFAULT instead of the value returned by copy_from_user()
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Sat, 3 May 2014 20:23:29 +0000 (23:23 +0300)]
staging: lustre: info leak in lnet_ping()
On 64 bit systems there is a 4 byte hole after the last member of the
struct. We should clear it to avoid disclosing stack information.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 20:49:29 +0000 (16:49 -0400)]
staging: dgap: Get rid of CamelCase
This patch gets rid of the obvious CamelCases
from both dgap.c and dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 18:19:42 +0000 (14:19 -0400)]
staging: dgap: refactor ugly dgap_init_one function
This patch just cleans up the ugly dgap_init_one function
Signed-off-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 20:59:18 +0000 (22:59 +0200)]
staging: rtl8723au: Do not reset wdev->iftype in netdev_close()
wdev->ifdev should be set by .change_virtual_intf(). This solves the
problem of WARN() messages on module unload.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:20 +0000 (13:10 -0400)]
staging: dgap: Add check for MAXBOARDS in .probe (dgap_init_one)
Insure we don't allow configuring more than MAXBOARDS (32).
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:19 +0000 (13:10 -0400)]
staging: dgap: remove two unnecessary conditionals
Remove 2 unnessessary conditionals. They are always
false in this code path.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:18 +0000 (13:10 -0400)]
staging: dgap: check unchecked return values
Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 14:00:42 +0000 (10:00 -0400)]
staging: dgap: fix a few more sparse warnings
This patch fixes a few more sparse warnings related to __iomem
version 2 excludes a change that actually caused a new sparse
warning.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 14:41:44 +0000 (10:41 -0400)]
staging: dgap: fix sparse warnings Using plain integer as NULL pointer
This patch fixes sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 14:33:58 +0000 (10:33 -0400)]
staging: dgap: fix sparse warning about dgap_poll_lock
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 13:22:12 +0000 (09:22 -0400)]
staging: dgap: fix a few misc sparse warnings
This patch fixes a few misc sparse warnings related to __iomem
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 20:43:21 +0000 (16:43 -0400)]
staging: dgap: fix sparse warnings for the entire cm_t structure
This patch fixes sparse warnings for the entire cm_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 20:25:27 +0000 (16:25 -0400)]
staging: dgap: fix sparse warnings for the entire bs_t structure
This patch fixes sparse warnings for the entire bs_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 19:43:07 +0000 (15:43 -0400)]
staging: dgap: fix sparse warnings for re_map_membase and re_map_port
This patch fixes sparse warnings for the
re_map_membase and re_map_port variables.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 14:33:45 +0000 (10:33 -0400)]
staging: dgap: Fix BUG in processing config file
This patch fixes an OOPS caused by a pointer being
changed between the malloc and free.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Reported-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 14:33:44 +0000 (10:33 -0400)]
staging: dgap: Fix how we insure config data is a string
This patch changes the way we insure the config data
is a string. Clearly this was just wrong. After a
certain number of loads/unloads various OOPs were
generated indicating something other than this driver
had a problem. It was this driver.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Reported-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 16 May 2014 12:08:53 +0000 (08:08 -0400)]
staging: dgap: Add Mark Hounschell to maintainers list for dgap
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:29 +0000 (18:08 +0800)]
staging: gdm72xx: Remove task from TODO list
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on
ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:28 +0000 (18:08 +0800)]
staging: gdm72xx: Indentation and other whitespace fixes
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:27 +0000 (18:08 +0800)]
staging: gdm72xx: Whitespace fixes to conform to coding standards
Fixes the following checkpatch.pl issues:
WARNING: unnecessary whitespace before a quoted newline
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
Also some additional, whitespace related, readability issues.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:26 +0000 (18:08 +0800)]
staging: gdm72xx: Removed commented-out code
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:25 +0000 (18:08 +0800)]
staging: gdm72xx: Fix braces to conform with coding style
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:24 +0000 (18:08 +0800)]
staging: gdm72xx: Fix some camel-case variables
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:23 +0000 (18:08 +0800)]
staging: gdm72xx: Move logical continuation to previous line to conform to coding style
Fixes the following checkpatch.pl issue:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:22 +0000 (18:08 +0800)]
staging: gdm72xx: Modify a struct allocation to match coding standards
Fixes the following checkpatch.pl issue:
CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct qos_entry_s)...)
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:21 +0000 (18:08 +0800)]
staging: gdm72xx: Replace comparisons on jiffies values with wrap-safe functions
Fixes the following checkpatch.pl issue:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:20 +0000 (18:08 +0800)]
staging: gdm72xx: Remove unnecessary extern declarations from header files
Fixes the following checkpatch.pl issue:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:13 +0000 (10:05 +0200)]
staging: rtl8723au: Remove some unused ODM dynamic TX power functionality
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:12 +0000 (10:05 +0200)]
staging: rtl8723au: The DBG_IO code is all gone
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:11 +0000 (10:05 +0200)]
staging: rtl8723au: Remove some leftover obsolete prototypes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:10 +0000 (10:05 +0200)]
staging: rtl8723au: Name port vs register access functions consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:09 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_write*() functions directly
This allows us to finally remove the ugly HAL interface for accessing
registers, and remove rtw_io.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:08 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_read*() functions directly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:07 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layer
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:06 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_{read,write}_port() functions directly
Get rid of more HAL layer obfuscations
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:05 +0000 (10:05 +0200)]
staging: rtl8723au: Clean up usb_{read,write}_port() usage
Get rid of silly HAL convolution for calling usb_{read,write}_port()
functions.
Benefit from fact we just have one input address for read_port, so no
point storing this and carrying it around.
Pick pipe in the local function instead of based on dst/src address.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:04 +0000 (10:05 +0200)]
staging: rtl8723au: Use correct pipe type for USB interrupts
Use a correct pipe type when filling un interrupt urbs. This should
finally take care of the WARN() messages on the console when USB urbs
are submitted.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:03 +0000 (10:05 +0200)]
staging: rtl8723au: Clean up mess of parenthesis abuse
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:02 +0000 (10:05 +0200)]
staging: rtl8723au: usb_ops_linux.h: Remove some unused #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:01 +0000 (10:05 +0200)]
staging: rtl8723au: Remove nasty wrappers used to hide wrong function types
Do not use #defines to hack around pre-history functions not matching
current APIs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:00 +0000 (10:05 +0200)]
staging: rtl8723au: Remove unused USB bulk related macros and variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:59 +0000 (10:04 +0200)]
staging: rtl8723au: Don't wrap calls to usb_control_msg()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:58 +0000 (10:04 +0200)]
staging: rtl8723au: Call usb_intf_{start,stop} directly
Rip out multiple layer of useless wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:57 +0000 (10:04 +0200)]
staging: rtl8723au: Call rtl8723au_set_hw_type() directly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:56 +0000 (10:04 +0200)]
staging: rtl8723au: Remove unused usb_suspend_sema
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:55 +0000 (10:04 +0200)]
staging: rtl8723au: Move last utility function from osdep_service.c to os_intfs.c
No point carrying a dedicated file just for this small helper, so move
it to os_intfs.c and get rid of osdep_service.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:54 +0000 (10:04 +0200)]
staging: rtl8723au: os_intfs.c: Various cosmetic cleanups
In addition skb->priorty is a u32, so make rtw_classify8021d return a
u32 to match.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:53 +0000 (10:04 +0200)]
staging: rtl8723au: os_dep/usb_ops_linux.c: More bad parenthesis cleanup
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:52 +0000 (10:04 +0200)]
staging: rtl8723au: hal/usb_ops_linux.c: Various cleanups
Reduce excessive parenthesis usage, remove unnecessary null
initialization of variables, and some bad formatting.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:51 +0000 (10:04 +0200)]
staging: rtl8723au: odm_precomp.h: Remove unused #define TEST_FALG__
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:50 +0000 (10:04 +0200)]
staging: rtl8723au: hal_com.c: Fix one case of returning status in an s32
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:49 +0000 (10:04 +0200)]
staging: rtl8723au: rtl8723a_cmd.c: Fix up bad return types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:48 +0000 (10:04 +0200)]
staging: rtl8723au: rtl8723a_hal_init.c: Fix more messy return type abuse
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:47 +0000 (10:04 +0200)]
staging: rtl8723au: rtl8723a_phycfg.c: Use int for error return codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:46 +0000 (10:04 +0200)]
staging: rtl8723au: rtl8723au_xmit.c: Fixup messy return type usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:45 +0000 (10:04 +0200)]
staging: rtl8723au: rtl8723au_xmit_tasklet(): Remove unnecessary variable init
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:44 +0000 (10:04 +0200)]
staging: rtl8723au: usb_halinit.c: Another u8 error code case
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:43 +0000 (10:04 +0200)]
staging: rtl8723au: usb_intf.c: Fixup yet another round of u8 abuse for error type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:42 +0000 (10:04 +0200)]
staging: rtl8723au: os_intfs.c: Fixup more u8/uint abuse for error return codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:41 +0000 (10:04 +0200)]
staging: rtl8732au: ioctl_cfg80211.c: Fix another case of u8 abuse for error return
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:40 +0000 (10:04 +0200)]
staging: rtl8723au: rtw_xmit.c: Be consistent in using int for error return type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:39 +0000 (10:04 +0200)]
staging: rtl8723au: rtw_wlan_util.c: Fix up random mixing of bool vs int
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:38 +0000 (10:04 +0200)]
staging: rtl8723au: rtw_sta_mgt.c: Clean up messy usage of return types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:37 +0000 (10:04 +0200)]
staging: rtl8723au: rtw_security.c: Clean up mess of error return code types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:04:36 +0000 (10:04 +0200)]
staging: rtl8723au: decryptor() use int to store error codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / log