GitHub/WoltLab/WCF.git
2 years agoMerge pull request #4734 from WoltLab/charset-title
Marcel Werk [Tue, 12 Apr 2022 09:38:45 +0000 (11:38 +0200)]
Merge pull request #4734 from WoltLab/charset-title

Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl

2 years agoMove `<meta charset="utf-8">` from headInclude.tpl to header.tpl
Tim Düsterhus [Tue, 16 Feb 2021 13:22:28 +0000 (14:22 +0100)]
Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl

see #3802
see #3998
see #4543

Co-authored-by: Sascha Moser <saschamoser1994@hotmail.de>
2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 11 Apr 2022 15:23:52 +0000 (17:23 +0200)]
Merge branch '5.4'

2 years agoOverlaying images discarded the transparency
Alexander Ebert [Mon, 11 Apr 2022 15:05:49 +0000 (17:05 +0200)]
Overlaying images discarded the transparency

See https://www.woltlab.com/community/thread/295124-imagickimageadapter-overlayen-zweier-bilder-mit-alpha-channel-entfernt-transpare/

2 years agoMark TUnsupportedDefaultValue as deprecated
Tim Düsterhus [Mon, 11 Apr 2022 14:04:13 +0000 (16:04 +0200)]
Mark TUnsupportedDefaultValue as deprecated

see #4733

2 years agoMerge pull request #4733 from WoltLab/php-ddl-default
Tim Düsterhus [Mon, 11 Apr 2022 14:01:58 +0000 (16:01 +0200)]
Merge pull request #4733 from WoltLab/php-ddl-default

Add IDefaultValueDatabaseTableColumn

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 11 Apr 2022 14:01:29 +0000 (16:01 +0200)]
Merge branch '5.4'

2 years agoMerge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text
Alexander Ebert [Mon, 11 Apr 2022 14:00:58 +0000 (16:00 +0200)]
Merge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text

Disallow default values for BLOB and TEXT columns

2 years agoCheck for `IDefaultValueDatabaseTableColumn` in AbstractDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:14:48 +0000 (14:14 +0200)]
Check for `IDefaultValueDatabaseTableColumn` in AbstractDatabaseTableColumn

2 years agoExplicitly implement `IDefaultValueDatabaseTableColumn` in supported column types
Tim Düsterhus [Mon, 11 Apr 2022 12:14:19 +0000 (14:14 +0200)]
Explicitly implement `IDefaultValueDatabaseTableColumn` in supported column types

2 years agoImplement IDefaultValueDatabaseTableColumn by default in AbstractDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:13:28 +0000 (14:13 +0200)]
Implement IDefaultValueDatabaseTableColumn by default in AbstractDatabaseTableColumn

This is temporary to not break backwards compatibility.

2 years agoAdd IDefaultValueDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:11:50 +0000 (14:11 +0200)]
Add IDefaultValueDatabaseTableColumn

2 years agoAllow `null` in `TUnsupportedDefaultValue`
Tim Düsterhus [Mon, 11 Apr 2022 11:51:00 +0000 (13:51 +0200)]
Allow `null` in `TUnsupportedDefaultValue`

When fetching the column definition from the database MySQL will return `null`
as the default value for BLOB and TEXT column even if the column itself is
`NOT NULL`.

2 years agoIncorrect code formatting
Alexander Ebert [Mon, 11 Apr 2022 10:45:24 +0000 (12:45 +0200)]
Incorrect code formatting

2 years agoMissing cache reset after manually adding phrases
Alexander Ebert [Mon, 11 Apr 2022 10:41:36 +0000 (12:41 +0200)]
Missing cache reset after manually adding phrases

See https://www.woltlab.com/community/thread/295020-text-hinzuf%C3%BCgen-cache-wird-nicht-geleert/

2 years agoCreate/update page without box information resulted in error
Marcel Werk [Mon, 11 Apr 2022 09:01:36 +0000 (11:01 +0200)]
Create/update page without box information resulted in error

2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 8 Apr 2022 10:24:28 +0000 (12:24 +0200)]
Merge branch '5.4'

2 years agoRemove accidentally added space in MysqlSearchEngine
Tim Düsterhus [Fri, 8 Apr 2022 10:03:23 +0000 (12:03 +0200)]
Remove accidentally added space in MysqlSearchEngine

2 years agoDo not add the `+` prefix to search terms matching an InnoDB stop word
Tim Düsterhus [Fri, 8 Apr 2022 10:00:53 +0000 (12:00 +0200)]
Do not add the `+` prefix to search terms matching an InnoDB stop word

This is issue is effectively identical to the one fixed in commit
247d9cc51af9cd78395e2e7600bacbc2ffdf918b.

2 years agoUpdate composer dependencies
Tim Düsterhus [Thu, 7 Apr 2022 08:57:11 +0000 (10:57 +0200)]
Update composer dependencies

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 7 Apr 2022 07:29:06 +0000 (09:29 +0200)]
Merge branch '5.4'

2 years agoFix code style in AbstractXMLPackageInstallationPlugin
Tim Düsterhus [Thu, 7 Apr 2022 07:28:30 +0000 (09:28 +0200)]
Fix code style in AbstractXMLPackageInstallationPlugin

2 years agoInstallation of nested elements (e.g. menu items) failed
Marcel Werk [Wed, 6 Apr 2022 15:50:17 +0000 (17:50 +0200)]
Installation of nested elements (e.g. menu items) failed

2 years agoUpdate update instructions for 5.5
Tim Düsterhus [Wed, 6 Apr 2022 13:29:26 +0000 (15:29 +0200)]
Update update instructions for 5.5

2 years agoDecouple HtmlInputProcessor::convertToHtml() from general-purpose HTML encoding ...
Tim Düsterhus [Wed, 6 Apr 2022 11:34:34 +0000 (13:34 +0200)]
Decouple HtmlInputProcessor::convertToHtml() from general-purpose HTML encoding (#4728)

Fixes #4717

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
2 years agoIgnore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTe...
Tim Düsterhus [Wed, 6 Apr 2022 11:02:02 +0000 (13:02 +0200)]
Ignore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTerms()

2 years agoRemove unused import
joshuaruesweg [Wed, 6 Apr 2022 08:44:01 +0000 (10:44 +0200)]
Remove unused import

2 years agoUse internal class to mask IP addresses
joshuaruesweg [Wed, 6 Apr 2022 08:41:04 +0000 (10:41 +0200)]
Use internal class to mask IP addresses

2 years agoArticle teaser was incorrectly formatted when automatically generated from the articl...
Marcel Werk [Tue, 5 Apr 2022 14:06:13 +0000 (16:06 +0200)]
Article teaser was incorrectly formatted when automatically generated from the article content

2 years agoFixed wrong margin for content item images
Marcel Werk [Tue, 5 Apr 2022 13:59:00 +0000 (15:59 +0200)]
Fixed wrong margin for content item images

2 years agoBanning a user without entering an unbanning date leads to error message
Marcel Werk [Tue, 5 Apr 2022 09:20:31 +0000 (11:20 +0200)]
Banning a user without entering an unbanning date leads to error message

2 years agoDetect Firefox in Favico.js based on CSS
Alexander Ebert [Mon, 4 Apr 2022 17:08:41 +0000 (19:08 +0200)]
Detect Firefox in Favico.js based on CSS

See https://www.woltlab.com/community/thread/294994-verwendung-von-installtrigger-in-favico-js-vermeiden/

2 years agoVerify that the active dialog is closable
Alexander Ebert [Mon, 4 Apr 2022 17:01:12 +0000 (19:01 +0200)]
Verify that the active dialog is closable

See https://www.woltlab.com/community/thread/294867-verschachtelte-dialoge-verwerfen-optionen-des-1-dialogs/

2 years agoRemoved obsolete method calls of deprecated method
Alexander Ebert [Mon, 4 Apr 2022 13:47:47 +0000 (15:47 +0200)]
Removed obsolete method calls of deprecated method

See #4718

2 years agoRemoved unused code from WSC <3.0
Alexander Ebert [Mon, 4 Apr 2022 13:46:30 +0000 (15:46 +0200)]
Removed unused code from WSC <3.0

See #4718

2 years agoMerge pull request #4714 from WoltLab/5.5-fix-ci-file-delete
Joshua Rüsweg [Mon, 4 Apr 2022 13:16:56 +0000 (15:16 +0200)]
Merge pull request #4714 from WoltLab/5.5-fix-ci-file-delete

Make FileDeletePIP safe for ci file systems

2 years agoMake FileDeletePIP safe for ci file systems
joshuaruesweg [Wed, 30 Mar 2022 12:55:03 +0000 (14:55 +0200)]
Make FileDeletePIP safe for ci file systems

2 years agoAdded file archive for the upgrade
Alexander Ebert [Mon, 4 Apr 2022 12:47:00 +0000 (14:47 +0200)]
Added file archive for the upgrade

The current package builder does not handle dynamic files nicely.

2 years agoMerge pull request #4713 from WoltLab/content-language-filtering
Marcel Werk [Mon, 4 Apr 2022 11:22:43 +0000 (13:22 +0200)]
Merge pull request #4713 from WoltLab/content-language-filtering

Option to filter notifications by content language settings

2 years agoAdded parameter documentation
Marcel Werk [Mon, 4 Apr 2022 11:17:02 +0000 (13:17 +0200)]
Added parameter documentation

2 years agoApply suggestions from code review
Marcel Werk [Mon, 4 Apr 2022 11:14:42 +0000 (13:14 +0200)]
Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
2 years agoMerge branch '5.4'
joshuaruesweg [Mon, 4 Apr 2022 07:09:43 +0000 (09:09 +0200)]
Merge branch '5.4'

2 years agoUpdate google console link
Sir-Will [Sun, 3 Apr 2022 01:19:51 +0000 (03:19 +0200)]
Update google console link

Closes #4716

2 years agoCheck permissions before redirecting to the canonical URL
Marcel Werk [Thu, 31 Mar 2022 12:11:15 +0000 (14:11 +0200)]
Check permissions before redirecting to the canonical URL

Redirecting to the Canonical URL can lead to information disclosure, for example, if the URL contains the title of the object. Therefore, it is important to check the permissions before redirecting.

2 years agoMerge branch '5.4'
Marcel Werk [Thu, 31 Mar 2022 12:06:21 +0000 (14:06 +0200)]
Merge branch '5.4'

2 years agoArticle system allowed access to titles of hidden articles
Marcel Werk [Thu, 31 Mar 2022 12:05:56 +0000 (14:05 +0200)]
Article system allowed access to titles of hidden articles

The problem was caused by a redirect to the Canonical URL before the permissions were checked.

2 years agoRemoved duplicate paragraph in privacy policy
Marcel Werk [Thu, 31 Mar 2022 09:10:36 +0000 (11:10 +0200)]
Removed duplicate paragraph in privacy policy

2 years agoUpdated privacy policy
Marcel Werk [Wed, 30 Mar 2022 14:41:02 +0000 (16:41 +0200)]
Updated privacy policy

* Renamed Facebook to Meta Platforms
* Add new sections about:
** Storage duration
** General information on the legal basis for the data processing
** Information on data transfer to the USA and other non-EU countries

2 years agoUse 'do not track' option for vimeo videos
Marcel Werk [Wed, 30 Mar 2022 13:48:56 +0000 (15:48 +0200)]
Use 'do not track' option for vimeo videos

2 years agoMerge pull request #4712 from WoltLab/5.5-eventlistener-validation
Joshua Rüsweg [Tue, 29 Mar 2022 15:21:53 +0000 (17:21 +0200)]
Merge pull request #4712 from WoltLab/5.5-eventlistener-validation

Enforce unique names for XML PIPs

2 years agoOption to filter notifications by content language settings
Marcel Werk [Tue, 29 Mar 2022 14:38:40 +0000 (16:38 +0200)]
Option to filter notifications by content language settings

2 years agoFloating of attachments in simplified HTML did not work properly
Marcel Werk [Tue, 29 Mar 2022 12:36:13 +0000 (14:36 +0200)]
Floating of attachments in simplified HTML did not work properly

2 years agoMerge branch '5.4'
Marcel Werk [Tue, 29 Mar 2022 12:11:49 +0000 (14:11 +0200)]
Merge branch '5.4'

2 years agoIncorrect handling of GIF cover photos when rebuilding users
Marcel Werk [Tue, 29 Mar 2022 12:01:36 +0000 (14:01 +0200)]
Incorrect handling of GIF cover photos when rebuilding users

2 years agoFix typo
joshuaruesweg [Mon, 28 Mar 2022 12:32:41 +0000 (14:32 +0200)]
Fix typo

2 years agoFix registration with local IPv6 address
joshuaruesweg [Mon, 28 Mar 2022 12:31:26 +0000 (14:31 +0200)]
Fix registration with local IPv6 address

Fixes #4689

2 years agoEnforce unique names for userprofilemenus
joshuaruesweg [Mon, 28 Mar 2022 09:02:24 +0000 (11:02 +0200)]
Enforce unique names for userprofilemenus

2 years agoEnforce unique names for smileys
joshuaruesweg [Mon, 28 Mar 2022 09:02:15 +0000 (11:02 +0200)]
Enforce unique names for smileys

2 years agoEnforce unique names for pages
joshuaruesweg [Mon, 28 Mar 2022 09:02:08 +0000 (11:02 +0200)]
Enforce unique names for pages

2 years agoEnforce unique names for objectTypeDefinitions
joshuaruesweg [Mon, 28 Mar 2022 09:02:00 +0000 (11:02 +0200)]
Enforce unique names for objectTypeDefinitions

2 years agoEnforce unique names for menu
joshuaruesweg [Mon, 28 Mar 2022 09:01:46 +0000 (11:01 +0200)]
Enforce unique names for menu

2 years agoEnforce unique names for menuitem
joshuaruesweg [Mon, 28 Mar 2022 09:01:40 +0000 (11:01 +0200)]
Enforce unique names for menuitem

2 years agoEnforce unique names for media providers
joshuaruesweg [Mon, 28 Mar 2022 09:01:29 +0000 (11:01 +0200)]
Enforce unique names for media providers

2 years agoEnforce unique names for cronjobs
joshuaruesweg [Mon, 28 Mar 2022 09:01:13 +0000 (11:01 +0200)]
Enforce unique names for cronjobs

2 years agoEnforce unique names for boxes
joshuaruesweg [Mon, 28 Mar 2022 09:01:05 +0000 (11:01 +0200)]
Enforce unique names for boxes

2 years agoEnforce unique names for bbcodes
joshuaruesweg [Mon, 28 Mar 2022 08:59:14 +0000 (10:59 +0200)]
Enforce unique names for bbcodes

2 years agoEnforce unique names for acp search providers
joshuaruesweg [Mon, 28 Mar 2022 08:58:58 +0000 (10:58 +0200)]
Enforce unique names for acp search providers

2 years agoEnforce unique names for eventlisteners
joshuaruesweg [Fri, 25 Mar 2022 14:37:05 +0000 (15:37 +0100)]
Enforce unique names for eventlisteners

2 years agoAdd `IUniqueNameXMLPackageInstallationPlugin` to enforce unique names
joshuaruesweg [Fri, 25 Mar 2022 14:36:38 +0000 (15:36 +0100)]
Add `IUniqueNameXMLPackageInstallationPlugin` to enforce unique names

Debugging is very tedious when elements with non-unique names are supplied in a plugin, because the first element is always overwritten with the second element. This can never be intentional and is always a fault of the developer, which is difficult to find. This interface ensures that all identifiers supplied for a PIP are unique.

2 years agoMark the anonymous function as static
Alexander Ebert [Wed, 23 Mar 2022 19:01:35 +0000 (20:01 +0100)]
Mark the anonymous function as static

2 years agoBetter UX of disabled flexible button groups
Alexander Ebert [Wed, 23 Mar 2022 18:45:54 +0000 (19:45 +0100)]
Better UX of disabled flexible button groups

The buttons are now semi transparent to reflect the active value regardless of its state.

2 years agoMoved important pips to the top, smaller layout
Alexander Ebert [Wed, 23 Mar 2022 18:30:31 +0000 (19:30 +0100)]
Moved important pips to the top, smaller layout

2 years agoStop declaring the tiny builds as experimental
Alexander Ebert [Wed, 23 Mar 2022 17:57:22 +0000 (18:57 +0100)]
Stop declaring the tiny builds as experimental

2 years agoCleaned up a warning about a type mismatch
Alexander Ebert [Wed, 23 Mar 2022 13:36:49 +0000 (14:36 +0100)]
Cleaned up a warning about a type mismatch

2 years agoBad behavior of incorrectly nested BBCodes
Alexander Ebert [Wed, 23 Mar 2022 13:35:32 +0000 (14:35 +0100)]
Bad behavior of incorrectly nested BBCodes

Test case:
```
<p>Hello [tt]test<strong>[/tt]</strong> world!</p>
```

Previously the `[/tt]` was implicitly moved to the end of the `</p>`, because parent inline elements were handled incorrectly.

2 years agoMerge pull request #4710 from WoltLab/rescue-mode-directory-change
Marcel Werk [Wed, 23 Mar 2022 12:34:33 +0000 (13:34 +0100)]
Merge pull request #4710 from WoltLab/rescue-mode-directory-change

Trigger rescue mode if directory has changed

2 years agoTrigger rescue mode if directory has changed
Marcel Werk [Wed, 23 Mar 2022 12:18:32 +0000 (13:18 +0100)]
Trigger rescue mode if directory has changed

2 years agoRemoved obsolete google font loading
Marcel Werk [Wed, 23 Mar 2022 12:04:01 +0000 (13:04 +0100)]
Removed obsolete google font loading

2 years agoUpdate fileDelete.xml
Tim Düsterhus [Wed, 23 Mar 2022 10:05:03 +0000 (11:05 +0100)]
Update fileDelete.xml

2 years agoWhitelist `basename` in enterprise mode
Tim Düsterhus [Wed, 23 Mar 2022 08:10:40 +0000 (09:10 +0100)]
Whitelist `basename` in enterprise mode

2 years agoMoved "edit page" button into contentInteractionButtons
Marcel Werk [Tue, 22 Mar 2022 15:20:39 +0000 (16:20 +0100)]
Moved "edit page" button into contentInteractionButtons

Previously, the "edit page" button was not available if the page did not have a title.

2 years agoFix typo in DE language item `wcf.acp.package.validation.errorCode.20` (#4709)
Niklas [Tue, 22 Mar 2022 11:22:16 +0000 (12:22 +0100)]
Fix typo in DE language item `wcf.acp.package.validation.errorCode.20` (#4709)

2 years agoFix typo for `INVALID_EXCLUDED_PACKAGE_VERSION_NUMBER`
joshuaruesweg [Mon, 21 Mar 2022 15:25:47 +0000 (16:25 +0100)]
Fix typo for `INVALID_EXCLUDED_PACKAGE_VERSION_NUMBER`

2 years agoMerge pull request #4708 from WoltLab/5.5-self-exclude
Joshua Rüsweg [Mon, 21 Mar 2022 14:52:44 +0000 (15:52 +0100)]
Merge pull request #4708 from WoltLab/5.5-self-exclude

Forbid plugins to exclude itself

2 years agoAdd missing `@since` tag for `INVALID_EXCLUDED_PACKAGE_VERSION_NUBMER` constant
joshuaruesweg [Mon, 21 Mar 2022 14:45:34 +0000 (15:45 +0100)]
Add missing `@since` tag for `INVALID_EXCLUDED_PACKAGE_VERSION_NUBMER` constant

2 years agoForbid plugins to exclude themselves
joshuaruesweg [Mon, 21 Mar 2022 14:36:48 +0000 (15:36 +0100)]
Forbid plugins to exclude themselves

2 years agoMerge pull request #4707 from WoltLab/5.5-exclusion
Joshua Rüsweg [Mon, 21 Mar 2022 14:20:15 +0000 (15:20 +0100)]
Merge pull request #4707 from WoltLab/5.5-exclusion

Support explicit `*` for excluded parameters

2 years agoAdd cleanup script to clean invalid excluded versions
joshuaruesweg [Mon, 21 Mar 2022 13:06:44 +0000 (14:06 +0100)]
Add cleanup script to clean invalid excluded versions

2 years agoSupport explicit `*` for excluded parameters
joshuaruesweg [Mon, 21 Mar 2022 12:16:01 +0000 (13:16 +0100)]
Support explicit `*` for excluded parameters

2 years agoUpdate composer dependencies
Tim Düsterhus [Mon, 21 Mar 2022 10:10:54 +0000 (11:10 +0100)]
Update composer dependencies

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 21 Mar 2022 10:10:30 +0000 (11:10 +0100)]
Merge branch '5.4'

2 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 21 Mar 2022 10:08:46 +0000 (11:08 +0100)]
Merge branch '5.3' into 5.4

2 years agoMerge pull request #4706 from WoltLab/guzzle-psr7-backport
Tim Düsterhus [Mon, 21 Mar 2022 10:03:59 +0000 (11:03 +0100)]
Merge pull request #4706 from WoltLab/guzzle-psr7-backport

Update guzzlehttp/psr7 to a custom fork

2 years agoUpdate guzzlehttp/psr7 to a custom fork
Tim Düsterhus [Sun, 20 Mar 2022 14:22:29 +0000 (15:22 +0100)]
Update guzzlehttp/psr7 to a custom fork

see WoltLab/guzzle-psr7@ff7be9fcf7da87f971990b1a61d8a7f2b5aeac9b
see WoltLab/guzzle-psr7@986596de01529f6e837a5cadfef9ec714ace7914

2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 18 Mar 2022 14:01:46 +0000 (15:01 +0100)]
Merge branch '5.4'

2 years agoPrevent possible brick when the upgrade to 5.5 fails between unpacking of files and...
Tim Düsterhus [Fri, 18 Mar 2022 13:59:50 +0000 (14:59 +0100)]
Prevent possible brick when the upgrade to 5.5 fails between unpacking of files and unpacking of acptemplates

2 years agoMerge pull request #4705 from WoltLab/acp-security-headers
Tim Düsterhus [Fri, 18 Mar 2022 11:45:05 +0000 (12:45 +0100)]
Merge pull request #4705 from WoltLab/acp-security-headers

Add additional security headers to ACP requests

2 years agoAdd additional security headers to ACP requests
Tim Düsterhus [Fri, 18 Mar 2022 11:36:49 +0000 (12:36 +0100)]
Add additional security headers to ACP requests

2 years agoRelease 5.4.15 5.4.15
Alexander Ebert [Thu, 17 Mar 2022 16:41:10 +0000 (17:41 +0100)]
Release 5.4.15

2 years agoRelease 5.3.21 5.3.21
Alexander Ebert [Thu, 17 Mar 2022 16:36:32 +0000 (17:36 +0100)]
Release 5.3.21