Tim Düsterhus [Thu, 23 Dec 2021 10:25:27 +0000 (11:25 +0100)]
Merge branch '5.4'
Tim Düsterhus [Thu, 23 Dec 2021 10:24:45 +0000 (11:24 +0100)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 23 Dec 2021 10:19:25 +0000 (11:19 +0100)]
Pass the file's basename to the validation regex in StyleEditor::export()
This fixes
84f62ddac1ba9894a9cbb8791085f7799f3760c8.
Alexander Ebert [Wed, 22 Dec 2021 16:26:57 +0000 (17:26 +0100)]
Release 5.4.10
Alexander Ebert [Wed, 22 Dec 2021 14:49:35 +0000 (15:49 +0100)]
Release 5.4.10 dev 2
Alexander Ebert [Wed, 22 Dec 2021 14:46:57 +0000 (15:46 +0100)]
Release 5.3.16
WoltLab [Wed, 22 Dec 2021 14:23:59 +0000 (14:23 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 22 Dec 2021 14:07:29 +0000 (15:07 +0100)]
Improper restore of navigation menu icons
Joshua Rüsweg [Tue, 21 Dec 2021 12:50:24 +0000 (13:50 +0100)]
Merge pull request #4611 from WoltLab/5.5-upload-session-cleanup
Add UploadHandler session cleanup
joshuaruesweg [Tue, 21 Dec 2021 10:30:54 +0000 (11:30 +0100)]
Add UploadHandler session cleanup
Since the sessions stick way longer than with the introduction of the system, it is necessary, to clean up old file uploads in the session storage.
With this patch, a field in the session saves the creation time of the StorageField in the session and delete the field after 24 hours automatically.
Alexander Ebert [Mon, 20 Dec 2021 15:43:35 +0000 (16:43 +0100)]
Merge pull request #4610 from WoltLab/54-metacode-parse-attributes
Enforce a consistent return type
Alexander Ebert [Mon, 20 Dec 2021 15:10:27 +0000 (16:10 +0100)]
Enforce a consistent return type
The method was designed to always return an array. If the `\base64_code()` fails, it returned `false` instead, which was both unexpected and could fail in PHP 8.1 (autovivification on false, https://wiki.php.net/rfc/autovivification_false)
Marcel Werk [Mon, 20 Dec 2021 13:16:12 +0000 (14:16 +0100)]
Added missing 'deprecated' tags
Marcel Werk [Sun, 19 Dec 2021 18:35:09 +0000 (19:35 +0100)]
Unified sidebar position
Alexander Ebert [Fri, 17 Dec 2021 16:38:41 +0000 (17:38 +0100)]
Release 5.4.10 dev 1
Tim Düsterhus [Fri, 17 Dec 2021 12:34:12 +0000 (13:34 +0100)]
Add `wcf.user.3rdparty.login.error.user_aborted` phrase
Tim Düsterhus [Fri, 17 Dec 2021 09:46:40 +0000 (10:46 +0100)]
Merge branch '5.4'
Tim Düsterhus [Fri, 17 Dec 2021 09:31:27 +0000 (10:31 +0100)]
Fix the include family of "functions" in stack trace sanitization
`include` et al are not actual functions, but language constructs. For this
reason they cannot be reflected, causing their arguments to show as
`[error_during_sanitization]`. Fix this by special casing them to not run the
sanitization, they do not contain sensitive arguments (apart from the path
which is redacted independently later).
WoltLab [Thu, 16 Dec 2021 18:09:39 +0000 (18:09 +0000)]
Updating minified JavaScript files
Alexander Ebert [Thu, 16 Dec 2021 18:08:23 +0000 (19:08 +0100)]
Selection changes on mobile were recognized as clicks
WoltLab [Thu, 16 Dec 2021 14:47:59 +0000 (14:47 +0000)]
Updating minified JavaScript files
Marcel Werk [Thu, 16 Dec 2021 12:46:18 +0000 (13:46 +0100)]
Merge pull request #4605 from WoltLab/search-form-overhaul
Search form overhaul
Tim Düsterhus [Thu, 16 Dec 2021 10:34:30 +0000 (11:34 +0100)]
Marcel Werk [Wed, 15 Dec 2021 17:13:42 +0000 (18:13 +0100)]
Applied code suggestions
Marcel Werk [Wed, 15 Dec 2021 13:17:45 +0000 (14:17 +0100)]
Flood control for search function
joshuaruesweg [Wed, 15 Dec 2021 10:50:25 +0000 (11:50 +0100)]
Use a strict whitelist for allowed filenames in image folder in style export
joshuaruesweg [Wed, 15 Dec 2021 09:43:06 +0000 (10:43 +0100)]
Merge branch '5.4'
joshuaruesweg [Wed, 15 Dec 2021 09:42:08 +0000 (10:42 +0100)]
Fix incorrect default style variable value
joshuaruesweg [Wed, 15 Dec 2021 08:48:19 +0000 (09:48 +0100)]
Remove dot files from image export
Tim Düsterhus [Wed, 15 Dec 2021 08:13:41 +0000 (09:13 +0100)]
Merge pull request #4607 from WoltLab/css-parser-8.4
Upgrade to sabberworm/php-css-parser 8.4
Tim Düsterhus [Wed, 15 Dec 2021 08:09:49 +0000 (09:09 +0100)]
Upgrade to sabberworm/php-css-parser 8.4
This comes with native PHP 8.1, avoiding the need to install from our fork.
joshuaruesweg [Tue, 14 Dec 2021 10:50:28 +0000 (11:50 +0100)]
Add missing comma after last element in an array
joshuaruesweg [Tue, 14 Dec 2021 10:45:37 +0000 (11:45 +0100)]
Add `5.5` as valid API version for styles in database schema
Tim Düsterhus [Tue, 14 Dec 2021 10:36:16 +0000 (11:36 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 14 Dec 2021 10:24:35 +0000 (11:24 +0100)]
Remove obsolete imports
Tim Düsterhus [Tue, 14 Dec 2021 10:02:18 +0000 (11:02 +0100)]
Properly wrap Guzzle's ConnectException into FontDownloadFailed in FontManager
joshuaruesweg [Tue, 14 Dec 2021 09:55:43 +0000 (10:55 +0100)]
Merge branch '5.4'
joshuaruesweg [Tue, 14 Dec 2021 09:50:40 +0000 (10:50 +0100)]
Maintain `hasFavicon` attribute during style import
joshuaruesweg [Tue, 14 Dec 2021 09:49:45 +0000 (10:49 +0100)]
Allow file `favicon.ico` for style imports
Tim Düsterhus [Tue, 14 Dec 2021 09:43:40 +0000 (10:43 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 14 Dec 2021 09:41:32 +0000 (10:41 +0100)]
Tim Düsterhus [Tue, 14 Dec 2021 09:35:11 +0000 (10:35 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 14 Dec 2021 09:32:50 +0000 (10:32 +0100)]
Update scssphp/scssphp to the updated fork
Tim Düsterhus [Tue, 14 Dec 2021 09:24:54 +0000 (10:24 +0100)]
Update composer dependencies
Tim Düsterhus [Tue, 14 Dec 2021 09:14:25 +0000 (10:14 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 14 Dec 2021 09:10:20 +0000 (10:10 +0100)]
Fix database and file system getting out of sync for pageLogo in style
This can happen if the style editor is opened in two tabs and no logo is
configured yet. In Tab (A) an logo is uploaded and then Tab (B) is submitted.
Tab (B) will not provided the `pageLogo` key in the `uploads` parameter,
because nothing in this field was changed. Thus the processing for the logo
does not run. However all style variables are cleared upon an edit, thus
clearing the database reference.
Closes #4606
Marcel Werk [Mon, 13 Dec 2021 16:39:46 +0000 (17:39 +0100)]
Applied code suggestions
joshuaruesweg [Mon, 13 Dec 2021 14:39:41 +0000 (15:39 +0100)]
Remove rating of reactions from reactions data
See
25f91a2f3a776571c3e25a028b0d8542803052fb
joshuaruesweg [Mon, 13 Dec 2021 14:33:04 +0000 (15:33 +0100)]
Merge branch '5.4'
joshuaruesweg [Mon, 13 Dec 2021 14:32:16 +0000 (15:32 +0100)]
Fix wrong return type of LikeObject::getReactions()
Tim Düsterhus [Mon, 13 Dec 2021 13:53:18 +0000 (14:53 +0100)]
Fix UiToggleInput
Found with `strictPropertyInitialization`.
Tim Düsterhus [Mon, 13 Dec 2021 13:46:59 +0000 (14:46 +0100)]
Make Notification/Handler.ts compatible with useUnknownInCatchVariables
Tim Düsterhus [Mon, 13 Dec 2021 13:18:13 +0000 (14:18 +0100)]
Merge branch '5.4'
Tim Düsterhus [Mon, 13 Dec 2021 13:16:50 +0000 (14:16 +0100)]
Tim Düsterhus [Mon, 13 Dec 2021 13:08:10 +0000 (14:08 +0100)]
Fix return of any value in RewriteTest.ts
Tim Düsterhus [Mon, 13 Dec 2021 13:05:04 +0000 (14:05 +0100)]
Silence `@typescript-eslint/no-unsafe-argument`
Tim Düsterhus [Mon, 13 Dec 2021 13:04:53 +0000 (14:04 +0100)]
Update eslint
Tim Düsterhus [Mon, 13 Dec 2021 12:38:43 +0000 (13:38 +0100)]
Merge branch '5.4'
Tim Düsterhus [Mon, 13 Dec 2021 12:30:15 +0000 (13:30 +0100)]
Update `@types` packages
Tim Düsterhus [Mon, 13 Dec 2021 12:29:10 +0000 (13:29 +0100)]
Update to prettier 2.5.1
Tim Düsterhus [Mon, 13 Dec 2021 12:28:07 +0000 (13:28 +0100)]
Update to TypeScript 4.5.3
Marcel Werk [Sat, 11 Dec 2021 13:17:15 +0000 (14:17 +0100)]
Merge branch 'master' into search-form-overhaul
Marcel Werk [Sat, 11 Dec 2021 13:10:41 +0000 (14:10 +0100)]
Converted page search to ISearchProvider implementation
Marcel Werk [Sat, 11 Dec 2021 13:10:03 +0000 (14:10 +0100)]
Fixed code style
Marcel Werk [Sat, 11 Dec 2021 13:04:21 +0000 (14:04 +0100)]
Converted article search to ISearchProvider implementation
Alexander Ebert [Sat, 11 Dec 2021 12:41:01 +0000 (13:41 +0100)]
Merge branch '5.4'
Alexander Ebert [Sat, 11 Dec 2021 12:40:45 +0000 (13:40 +0100)]
Incorrect check for the active suggestion
Marcel Werk [Sat, 11 Dec 2021 10:44:36 +0000 (11:44 +0100)]
ISearchProvider was not taken into account
Marcel Werk [Sat, 11 Dec 2021 10:43:37 +0000 (11:43 +0100)]
Adjusted code documentation
Marcel Werk [Sat, 11 Dec 2021 10:43:18 +0000 (11:43 +0100)]
Applied code suggestions
Marcel Werk [Fri, 10 Dec 2021 13:04:26 +0000 (14:04 +0100)]
Applied code suggestions
Alexander Ebert [Fri, 10 Dec 2021 12:32:29 +0000 (13:32 +0100)]
Merge pull request #4604 from WoltLab/focus-trap
Use the "focus-trap" library for existing components
Alexander Ebert [Thu, 9 Dec 2021 17:41:33 +0000 (18:41 +0100)]
Use `focus-trap` to maintain the focus in dialogs
Tim Düsterhus [Fri, 10 Dec 2021 11:07:31 +0000 (12:07 +0100)]
Remove logout confirmation in ACP
The one in the frontend has already been removed in #4603.
372f863c3b0bc5bc9e3eb1f9f9cfed1cdd5971c1 is partially related as well.
Marcel Werk [Fri, 10 Dec 2021 10:38:37 +0000 (11:38 +0100)]
Merge branch 'search-form-overhaul' of https://github.com/WoltLab/WCF into search-form-overhaul
Marcel Werk [Fri, 10 Dec 2021 10:37:36 +0000 (11:37 +0100)]
Fixed code style
Tim Düsterhus [Fri, 10 Dec 2021 10:24:56 +0000 (11:24 +0100)]
Run php-cs-fixer
Marcel Werk [Fri, 10 Dec 2021 10:20:36 +0000 (11:20 +0100)]
Fixed code style
Alexander Ebert [Thu, 9 Dec 2021 19:26:59 +0000 (20:26 +0100)]
Changed the logout action into a `POST`
Using `input[type="submit"]` or `button` was not possible due to the styling being applied to these elements.
Alexander Ebert [Thu, 9 Dec 2021 18:52:12 +0000 (19:52 +0100)]
Insert the new style variables as early as possible when upgrading
Marcel Werk [Thu, 9 Dec 2021 18:19:11 +0000 (19:19 +0100)]
Missing since tag
Marcel Werk [Thu, 9 Dec 2021 18:18:00 +0000 (19:18 +0100)]
Removed obsolete language variables
Marcel Werk [Thu, 9 Dec 2021 18:17:46 +0000 (19:17 +0100)]
Removed obsolete template
Alexander Ebert [Thu, 9 Dec 2021 18:13:55 +0000 (19:13 +0100)]
Workaround for an incorrect width calculation inside `<details>`
Alexander Ebert [Thu, 9 Dec 2021 18:07:23 +0000 (19:07 +0100)]
Allow multiple instances of the quote manager on one page
Marcel Werk [Thu, 9 Dec 2021 18:06:29 +0000 (19:06 +0100)]
Moved css into scss file / mobile UI
Marcel Werk [Thu, 9 Dec 2021 16:08:46 +0000 (17:08 +0100)]
Prevented direct call of old search page/form
Marcel Werk [Thu, 9 Dec 2021 16:08:07 +0000 (17:08 +0100)]
Datepicker was not prefilled correctly
Marcel Werk [Thu, 9 Dec 2021 16:05:02 +0000 (17:05 +0100)]
Fixed search for author
Marcel Werk [Thu, 9 Dec 2021 15:09:19 +0000 (16:09 +0100)]
Added missing class documentation
Marcel Werk [Thu, 9 Dec 2021 15:04:27 +0000 (16:04 +0100)]
New interface for search providers
Alexander Ebert [Thu, 9 Dec 2021 14:37:26 +0000 (15:37 +0100)]
Use `focus-trap` to maintain the focus in the reaction picker
Alexander Ebert [Thu, 9 Dec 2021 14:19:25 +0000 (15:19 +0100)]
Use `focus-trap` to maintain the focus in date pickers
Alexander Ebert [Thu, 9 Dec 2021 13:59:21 +0000 (14:59 +0100)]
Merge pull request #4603 from WoltLab/user-panel-v2
Overhaul of the user panel menu
Marcel Werk [Wed, 8 Dec 2021 21:46:36 +0000 (22:46 +0100)]
Merge branch 'master' into search-form-overhaul
Alexander Ebert [Wed, 8 Dec 2021 20:43:14 +0000 (21:43 +0100)]
Adjust the vertical position for fixed buttons
Marcel Werk [Wed, 8 Dec 2021 20:05:41 +0000 (21:05 +0100)]
sort field / order validation
Marcel Werk [Wed, 8 Dec 2021 19:58:49 +0000 (20:58 +0100)]
Allow guests access to the search function
Alexander Ebert [Wed, 8 Dec 2021 18:31:16 +0000 (19:31 +0100)]
Implemented the overflow behavior
Alexander Ebert [Wed, 8 Dec 2021 15:35:25 +0000 (16:35 +0100)]
Improved code clarity