navin patidar [Mon, 26 May 2014 16:05:29 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused macros in odm_interface.h
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:28 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused structure "rtl8192cd_priv"
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:27 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused macros and enum defined in odm_types.h
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:26 +0000 (21:35 +0530)]
staging: rtl8188eu: remove unused header inclusion from rtw_mp.c
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:25 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:24 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function pointer ->dm_init
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:23 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove function rtw_hal_dm_deinit()
rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer.
rtl8188e_deinit_dm_priv() has empty defination, so we can remove
rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be
removed.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:22 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:21 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:20 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:19 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:18 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function pointer ->interface_ps_func
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:17 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Mon, 26 May 2014 16:05:16 +0000 (21:35 +0530)]
staging: rtl8188eu: Remove unused function rtw_interface_ps_func()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:08 +0000 (13:59 +0100)]
staging: vt6656: Fix CARDvCalculateOFDMRParameter static warning
Fix warning: symbol 'CARDvCalculateOFDMRParameter' was not declared. Should it be static?
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:07 +0000 (13:59 +0100)]
staging: vt6656: dead code remove control.c/h
Replace control.h headers with usbpipe.h
Also add to usbpipe.c its header
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:06 +0000 (13:59 +0100)]
staging: vt6656: create vnt_control_in_u8 to replace ControlvReadByte
ControlvReadByte will be removed in next patch
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:05 +0000 (13:59 +0100)]
staging: vt6656: remove dead code ControlvMaskByte
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:04 +0000 (13:59 +0100)]
staging: vt6656: Create new function to set led state.
Create vnt_mac_set_led to set state and led.
state has two modes LEDSTS_TMLEN which sets the blink rate
on TX activity and LEDSTS_STS which sets the led.
As result of this patch ControlvMaskByte becomes dead code.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:03 +0000 (13:59 +0100)]
staging: vt6656: replace ControlvWriteByte with vnt_control_out_u8
add new function in usbpipe.c to replace ControlvWriteByte
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:02 +0000 (13:59 +0100)]
staging: vt6656: rename PIPEnsControlIn/CONTROLnsRequestIn with vnt_control_in
Replace all to CONTROLnsRequestIn with vnt_control_in and remove macro.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:01 +0000 (13:59 +0100)]
staging: vt6656: rename PIPEnsControlOut/CONTROLnsRequestOut to vnt_control_out
Rename all CONTROLnsRequestOut and remove macro from control.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:59:00 +0000 (13:59 +0100)]
staging: vt6656: mac.c remove DBG_PRT debug message.
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:58:59 +0000 (13:58 +0100)]
staging: vt6656: MACvSetKeyEntry remove camel case.
camel case changes
pDevice -> priv
wKeyCtl -> key_ctl
uEntryIdx -> entry_idx
uKeyIdx -> key_idx
pbyAddr -> addr
wOffset -> offset
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 26 May 2014 12:58:58 +0000 (13:58 +0100)]
staging: vt6656: MACvSetKeyEntry change u32 pdwKey to u8 pointer
Change pdwKey u32 pointer to key u8 pointer.
Callers are already u8 remove u32 pointer cast.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joel Porquet [Mon, 26 May 2014 16:07:38 +0000 (18:07 +0200)]
staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions
Originally, this header was defining two new typedefs, CMND_TYPE and
CMND_TYPE_SD, following this type of declaration:
typedef enum {
...
} CMND_TYPE;
A previous commit (
785086556a573f07747b3633732a9dbd7e45728f) tried to
fix warnings that were pointed out by checkpatch.pl, concerning not
adding new typedefs. But this commit only removed the 'typedef' keyword,
thus transforming both the typedefs into two the definition of global
variables. For example:
enum {
...
} CMND_TYPE;
As noticed by the Sparse tool, this patch removes those erroneous global
variable definitions, and just leaves anonymous enum type definitions:
enum {
...
};
Signed-off-by: Joel Porquet <joel@porquet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 26 May 2014 10:24:47 +0000 (19:24 +0900)]
staging: dgap: move tty_port_init() for serial_ports.
If printer_ports which is allocated after serial_ports is failed
to allocate, tty_port_init for serial_ports doesn't need anymore.
So move this after allocating memory for printer_ports.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 26 May 2014 10:24:17 +0000 (19:24 +0900)]
staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()
When it failed to allocate for printer_ports, serial_ports
can be freed in dgap_tty_uninit().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 26 May 2014 10:23:01 +0000 (19:23 +0900)]
staging: dgap: remove unneeded kfree() for ttys in tty_driver
In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tobias Klauser [Mon, 26 May 2014 09:08:18 +0000 (11:08 +0200)]
staging/lustre/llite: Remove unnecessary check for NULL before iput()
iput() already checks for the inode being NULL, thus it's unnecessary to
check before calling.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peter Senna Tschudin [Mon, 26 May 2014 14:08:50 +0000 (16:08 +0200)]
drivers/staging: Remove useless return variables
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Mon, 26 May 2014 04:58:43 +0000 (21:58 -0700)]
Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines
Added a blank line after declarations in many places to fix
the following warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:48 +0000 (22:43 +0200)]
staging: rtl8723au: _InitQueueReservedPage(): Remove pointless brackets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:47 +0000 (22:43 +0200)]
staging: rtl8723au: Remove unused struct btdata_info
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:46 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BTDM_FwC2hBtInfo8723A() to rtl8723a_fw_c2h_BT_info()
In addition get rid of some pointless code obfuscating wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:45 +0000 (22:43 +0200)]
staging: rtl8723au: rtl8723a_bt-coexist.c: Remove unnecessary #ifdef CONFIG_8723AU_BT_COEXIST
This file is only compiled if CONFIG_8723AU_BT_COEXIST=y
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:44 +0000 (22:43 +0200)]
staging: rtl8723au: Rename HALBT_InitBTVars8723A() rtl8723a_BT_init_hal_vars()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:43 +0000 (22:43 +0200)]
staging: rtl8723au: Make rtl8723a_set_BTCoex_AP_mode_FwRsvdPkt_cmd() a no-op when no co-exist enabled
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:42 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BT_WifiAssociateNotify() rtl8723a_BT_wifiassociate_notify()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:41 +0000 (22:43 +0200)]
staging: rtl8723au: rtl8732au_hal_init.c: Use rtl8723au_BT_coexist() to pick firmware image
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:40 +0000 (22:43 +0200)]
staging: rtl8723au: usb_halinit.c: Remove no-op HAL_INIT_PROFILE_TAG()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:39 +0000 (22:43 +0200)]
staging: rtl8723au: Rename HALBT_InitHwConfig() rtl8723a_BT_init_hwconfig()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:38 +0000 (22:43 +0200)]
staging: rtl8723au: Move rtl8723a_dual_antenna_detection() to rtl8723a_bt-coexist.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:37 +0000 (22:43 +0200)]
staging: rtl8723au: odm.c: Rename BTDM_DisableEDCATurbo() to rtl8723a_BT_disable_EDCA_turbo()
Make it return bool since it only returns true/false, and get rid of
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:36 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Sanitize calls to alloc_mgtxmitframe23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:35 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Remove CONFIG_8723AU_BT_COEXIST #ifdefs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:34 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_pwrctrl.c: Eliminate CONFIG_8723AU_BT_COEXIST #ifdefs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:33 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_pwrctrl.c: Remove an unnecessary COEXIST #ifdef
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:32 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_cmd.c: Remove last #ifdef CONFIG_8723AU_BT_COEXIST usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:31 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BT_LpsLeave() rtl8723a_BT_lps_leave()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:30 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BTDM_ForDhcp() to rtl8723a_BT_specialpacket_notify()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:29 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BT_WifiMediaStatusNotify() rtl8723a_BT_mediastatus_notify()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:28 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BT_WifiScanNotify() rtl8723a_BT_wifiscan_notify()
Providing a dummy wrapper also allows removing some more
CONFIG_8723AU_BT_COEXIST clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:27 +0000 (22:43 +0200)]
staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:26 +0000 (22:43 +0200)]
staging: rtl8723au: Remove some CONFIG_8723AU_BT_COEXIST clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:25 +0000 (22:43 +0200)]
staging: rtl8723au: Introduce rtl8723a_BT_coexist() - and use it!
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:24 +0000 (22:43 +0200)]
staging: rtl8723au: Convert BT_IsBtDisabled() into rtl8723a_BT_enabled()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:23 +0000 (22:43 +0200)]
staging: rtl8723au: Create rtl8723au_bt_intf.h
Use this header for declaring functions that are currently #ifdef'ed
out in the general code.
Start by moving BTDM_1Ant8723A() there and renaming it appropriately.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:22 +0000 (22:43 +0200)]
staging: rtl8723au: PS_RDY_CHECK() return bools in 'bool'
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:21 +0000 (22:43 +0200)]
staging: rtl8723au: _rtw_pwr_wakeup23a(): Do not mix _FAIL/false as return value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:20 +0000 (22:43 +0200)]
staging: rtl8723au: bInternalAutoSuspend is always false
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:19 +0000 (22:43 +0200)]
staging: rtl8723au: Remove unused prototype rtw_cfg80211_issue_p2p_provision_request23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:18 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_wdev_alloc(): Don't register wiphy before kmalloc() completed
There is no point starting to register the wiphy and then having to
unregister it again if the followon kmalloc() fails.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:17 +0000 (22:43 +0200)]
staging: rtl8723au: Remove some pointless cfg80211_* wrapper macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:16 +0000 (22:43 +0200)]
staging: rtl8723au: struct rtw_wdev_priv: Remove some never 'true' variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:15 +0000 (22:43 +0200)]
staging: rtl8723au: Get rid of unused struct rtw_wdev_invit_info
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:14 +0000 (22:43 +0200)]
staging: rtl8723au: _cfg80211_rtw_mgmt_tx() clean up checking function return values
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:13 +0000 (22:43 +0200)]
staging: rtl8723au: Delete unused rtw_cfg80211_set_mgnt_wpsp2pie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:12 +0000 (22:43 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_equal()
... and in one case use is_zero_ether_addr()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:11 +0000 (22:43 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_copy()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:10 +0000 (22:43 +0200)]
staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface()
Calling open on the device when changing the interface type is wrong.
Let the stack call open at the right time.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:09 +0000 (22:43 +0200)]
staging: rtl8723au: Remove unused struct hostapd_priv
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:08 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_mlme.h: Remove a bunch of unused structs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:07 +0000 (22:43 +0200)]
staging: rtl8723au: Remove unused enum SCAN_RESULT_TYPE
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:06 +0000 (22:43 +0200)]
staging: rtl8723au: Don't check check_fwstate() == false
In addition, remove a followon check for false just after having
checked for true.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:05 +0000 (22:43 +0200)]
staging: rtl8723au: Make check_fwstate() return bool
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:04 +0000 (22:43 +0200)]
staging: rtl8723au: Don't explicitly check check_fwstate() == true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:03 +0000 (22:43 +0200)]
staging: rtl8723au: rtw_xmit.c: Use ether_addr_copy()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:02 +0000 (22:43 +0200)]
staging: rtl8723au: Use ieee80211.h defines for IV/ICV len values
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sun, 25 May 2014 20:43:01 +0000 (22:43 +0200)]
staging: rtl8723au: ieee80211.h: Remove some unused #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:29 +0000 (21:36 +0100)]
staging: vt6656: MACvSetKeyEntry create structure to write key
Create structure for wKeyCtl , pbyAddr and pbyKey
wKeyCtl(key_ctl) and pbyAddr(addr) form an union of 64 bits with swap
of two 32 bits. pbyKey(key) has a length of WLAN_KEY_LEN_CCMP(16)
bytes.
swap is needed because high order 32 bits needs to written out first.
pbyKey is memcpy on to key.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:28 +0000 (21:36 +0100)]
staging: vt6656: s_vFillTxKey fix indentation of memcpy
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:27 +0000 (21:36 +0100)]
staging: vt6656: s_uGetRTSCTSRsvTime fix word lenght
Correct to length
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:26 +0000 (21:36 +0100)]
staging: vt6656: BBbVT3184Init fix word lenght
Correct to length
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:25 +0000 (21:36 +0100)]
staging: vt6656: baseband.c replace DBG_PRT debug messages
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:24 +0000 (21:36 +0100)]
staging: vt6656: card.c replace DBG_PRT debug messages.
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:23 +0000 (21:36 +0100)]
staging; vt6656: swGetCCKControlRate remove camel case
camel case changes
pDevice -> priv
wRateIdx -> rate_idx
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sun, 25 May 2014 20:36:22 +0000 (21:36 +0100)]
staging: vt6656: swGetOFDMControlRate remove camel case
camel case changes
pDevice -> priv
wRateIdx -> rate_idx
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Manuel Schölling [Sun, 25 May 2014 18:07:02 +0000 (20:07 +0200)]
staging: dgnc: Use time_after_eq()
To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Sun, 25 May 2014 16:15:06 +0000 (09:15 -0700)]
Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs
Fixed a lot of errors of the type "ERROR: space required after that ',' (ctx:VxV)"
Added tabs at the beginning of line.
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Manuel Schölling [Sun, 25 May 2014 13:05:24 +0000 (15:05 +0200)]
staging: rtl8188eu: use time_before/time_after and change type of ips_deny_time
To be future-proof and for better readability the time comparisons are
modified to use time_before/_after() instead of plain, error-prone math.
To suppress compiler warnings the type of ips_deny_time was changed.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:12 +0000 (17:23 +0200)]
staging: rtl8821ae: add static for local symbols in rtl_btc.c
This commit fixes the sparse warning:
"warning: symbol 'X' was not declared. Should it be static?"
Where the X is one of the following
rtl_btc_operation
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:11 +0000 (17:23 +0200)]
staging: rtl8821ae: deal with unused functions in halbtcoutsrc.c
This commit fixes the compiler -Wunused-function warning. Several
functions had to be removed.
Removed symbols
halbtc_is_hw_mailbox_exist
halbtc_set_macreg
halbtc_get_macreg
halbtc_under_ips
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:10 +0000 (17:23 +0200)]
staging: rtl8821ae: add static for local symbols in halbtcoutsrc.c
This commit fixes the sparse warning:
"warning: symbol 'X' was not declared. Should it be static?"
Where the X is one of the following:
bt_profile_string
bt_spec_string
bt_link_role_string
h2c_state_string
io_state_string
btc_dbg_buf
halbtc_is_bt_coexist_available
halbtc_is_wifi_busy
halbtc_dbg_init
halbtc_is_hw_mailbox_exist
halbtc_is_bt40
halbtc_legacy
halbtc_get_wifi_bw
halbtc_get_wifi_central_chnl
halbtc_leave_lps
halbtc_enter_lps
halbtc_normal_lps
halbtc_leave_low_power
halbtc_nomal_low_power
halbtc_disable_low_power
halbtc_aggregation_check
halbtc_get_bt_patch_version
halbtc_get_wifi_rssi
halbtc_get
halbtc_set
halbtc_display_coex_statistics
halbtc_display_bt_link_info
halbtc_display_bt_fw_info
halbtc_display_fw_pwr_mode_cmd
halbtc_read_1byte
halbtc_read_2byte
halbtc_read_4byte
halbtc_write_1byte
halbtc_bitmask_write_1byte
halbtc_write_2byte
halbtc_write_4byte
halbtc_set_macreg
halbtc_get_macreg
halbtc_set_bbreg
halbtc_get_bbreg
halbtc_set_rfreg
halbtc_get_rfreg
halbtc_fill_h2c_cmd
halbtc_display_dbg_msg
halbtc_under_ips
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:09 +0000 (17:23 +0200)]
staging: rtl8821ae: deal with unused functions in halbtc8723b2ant.c
This commit fixes the compiler -Wunused-function warning. It was enough
to put #define around them to supress this warning. One was a special
case because it's usage was commented-out therefore, as I did not want
to remove it completely, I disabled it with #if 0
Conditionally compiled symbols
halbtc8723b2ant_monitor_bt_enable_disable
halbtc8723b2ant_set_bt_auto_report
halbtc8723b2ant_bt_auto_report
Disabled symbols
halbtc8723b2ant_adc_backoff
halbtc8723b2ant_set_adc_backoff
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:08 +0000 (17:23 +0200)]
staging: rtl8821ae: add static for local symbols in halbtc8723b2ant.c
This commit fixes the sparse warning:
"warning: symbol 'X' was not declared. Should it be static?"
Where the X is one of the following:
glbt_info_src_8723b_2ant
glcoex_ver_date_8723b_2ant
glcoex_ver_8723b_2ant
halbtc8723b2ant_bt_rssi_state
halbtc8723b2ant_wifi_rssi_state
halbtc8723b2ant_monitor_bt_enable_disable
halbtc8723b2ant_monitor_bt_ctr
halbtc8723b2ant_query_bt_info
halbtc8723b2ant_is_wifi_status_changed
halbtc8723b2ant_update_bt_link_info
halbtc8723b2ant_action_algorithm
halbtc8723b2ant_need_to_dec_bt_pwr
halbtc8723b2ant_set_fw_dac_swing_level
halbtc8723b2ant_set_fw_dec_bt_pwr
halbtc8723b2ant_dec_bt_pwr
halbtc8723b2ant_set_bt_auto_report
halbtc8723b2ant_bt_auto_report
halbtc8723b2ant_fw_dac_swing_lvl
halbtc8723b2ant_set_sw_rf_rx_lpf_corner
halbtc8723b2ant_rf_shrink
halbtc8723b2ant_set_sw_penalty_txrate_adaptive
halbtc8723b2ant_low_penalty_ra
halbtc8723b2ant_set_dac_swing_reg
halbtc8723b2ant_set_sw_fulltime_dac_swing
halbtc8723b2ant_dac_swing
halbtc8723b2ant_set_adc_backoff
halbtc8723b2ant_adc_backoff
halbtc8723b2ant_set_agc_table
halbtc8723b2ant_agc_table
halbtc8723b2ant_set_coex_table
halbtc8723b2ant_coex_table
halbtc8723b2ant_coex_table_with_type
halbtc8723b2ant_set_fw_ignore_wlan_act
halbtc8723b2ant_ignore_wlan_act
halbtc8723b2ant_set_fw_ps_tdma
halbtc8723b2ant_sw_mechanism1
halbtc8723b2ant_sw_mechanism2
halbtc8723b2ant_set_ant_path
halbtc8723b2ant_ps_tdma
halbtc8723b2ant_coex_alloff
halbtc8723b2ant_init_coex_dm
halbtc8723b2ant_action_bt_inquiry
halbtc8723b2ant_is_common_action
halbtc8723b2ant_tdma_duration_adjust
halbtc8723b2ant_action_sco
halbtc8723b2ant_action_hid
halbtc8723b2ant_action_a2dp
halbtc8723b2ant_action_a2dp_pan_hs
halbtc8723b2ant_action_pan_edr
halbtc8723b2ant_action_pan_hs
halbtc8723b2ant_action_pan_edr_a2dp
halbtc8723b2ant_action_pan_edr_hid
halbtc8723b2ant_action_hid_a2dp_pan_edr
halbtc8723b2ant_action_hid_a2dp
halbtc8723b2ant_run_coexist_mechanism
halbtc8723b2ant_wifioff_hwcfg
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:07 +0000 (17:23 +0200)]
staging: rtl8821ae: deal with unused functions in halbtc8723b1ant.c
This commit fixes the compiler -Wunused-function warning. Most of the
unused functions were removed however for a few of them it was enough
to put #define around them.
Removed symbols:
halbtc8723b1ant_rf_shrink
halbtc8723b1ant_dac_swing
halbtc8723b1ant_adc_backoff
halbtc8723b1ant_agc_table
halbtc8723b1ant_coex_alloff
halbtc8723b1ant_ps_tdma_type_by_wifi_rssi
halbtc8723b1ant_set_sw_rf_rx_lpf_corner
halbtc8723b1ant_set_sw_full_time_dac_swing
halbtc8723b1ant_set_adc_backoff
halbtc8723b1ant_set_agc_table
halbtc8723b1ant_set_dac_swing_reg
Conditionally compiled symbols:
halbtc8723b1ant_bt_auto_report
halbtc8723b1ant_set_bt_auto_report
halbtc8723b1ant_action_wifi_only
halbtc8723b1ant_monitor_bt_enable_disable
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Konrad Zapalowicz [Sat, 24 May 2014 15:23:06 +0000 (17:23 +0200)]
staging: rtl8821ae: add static for local symbols in halbtc8723b1ant.c
This commit fixes the sparse warning:
"warning: symbol 'X' was not declared. Should it be static?"
Where the X is one of the following:
glbt_info_src_8723b_2ant
glcoex_ver_date_8723b_2ant
glcoex_ver_8723b_2ant
halbtc8723b2ant_bt_rssi_state
halbtc8723b2ant_wifi_rssi_state
halbtc8723b2ant_monitor_bt_enable_disable
halbtc8723b2ant_monitor_bt_ctr
halbtc8723b2ant_query_bt_info
halbtc8723b2ant_is_wifi_status_changed
halbtc8723b2ant_update_bt_link_info
halbtc8723b2ant_action_algorithm
halbtc8723b2ant_need_to_dec_bt_pwr
halbtc8723b2ant_set_fw_dac_swing_level
halbtc8723b2ant_set_fw_dec_bt_pwr
halbtc8723b2ant_dec_bt_pwr
halbtc8723b2ant_set_bt_auto_report
halbtc8723b2ant_bt_auto_report
halbtc8723b2ant_fw_dac_swing_lvl
halbtc8723b2ant_set_sw_rf_rx_lpf_corner
halbtc8723b2ant_rf_shrink
halbtc8723b2ant_set_sw_penalty_txrate_adaptive
halbtc8723b2ant_low_penalty_ra
halbtc8723b2ant_set_dac_swing_reg
halbtc8723b2ant_set_sw_fulltime_dac_swing
halbtc8723b2ant_dac_swing
halbtc8723b2ant_set_adc_backoff
halbtc8723b2ant_adc_backoff
halbtc8723b2ant_set_agc_table
halbtc8723b2ant_agc_table
halbtc8723b2ant_set_coex_table
halbtc8723b2ant_coex_table
halbtc8723b2ant_coex_table_with_type
halbtc8723b2ant_set_fw_ignore_wlan_act
halbtc8723b2ant_ignore_wlan_act
halbtc8723b2ant_set_fw_ps_tdma
halbtc8723b2ant_sw_mechanism1
halbtc8723b2ant_sw_mechanism2
halbtc8723b2ant_set_ant_path
halbtc8723b2ant_ps_tdma
halbtc8723b2ant_coex_alloff
halbtc8723b2ant_init_coex_dm
halbtc8723b2ant_action_bt_inquiry
halbtc8723b2ant_is_common_action
halbtc8723b2ant_tdma_duration_adjust
halbtc8723b2ant_action_sco
halbtc8723b2ant_action_hid
halbtc8723b2ant_action_a2dp
halbtc8723b2ant_action_a2dp_pan_hs
halbtc8723b2ant_action_pan_edr
halbtc8723b2ant_action_pan_hs
halbtc8723b2ant_action_pan_edr_a2dp
halbtc8723b2ant_action_pan_edr_hid
halbtc8723b2ant_action_hid_a2dp_pan_edr
halbtc8723b2ant_action_hid_a2dp
halbtc8723b2ant_run_coexist_mechanism
halbtc8723b2ant_wifioff_hwcfg
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Niv Yehezkel [Sat, 24 May 2014 14:28:07 +0000 (10:28 -0400)]
staging: android: describe use of memory barrier on sync.c
Added comments describing the purpose of using write memory
barrier in the context of sync_timeline_destory.
Signed-off-by: Niv Yehezkel <executerx@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pascal COMBES [Sat, 24 May 2014 13:58:09 +0000 (15:58 +0200)]
Staging: dgap: Fixed iomem accesses in dgap.c
I changed dereferences from iomem into the adequate ioread function.
Signed-off-by: Pascal COMBES <pascom@orange.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / log