Marcel Werk [Wed, 18 May 2022 16:24:37 +0000 (18:24 +0200)]
Improved structure of the search form filter options
Marcel Werk [Wed, 18 May 2022 16:15:21 +0000 (18:15 +0200)]
Missing language variable
Marcel Werk [Wed, 18 May 2022 15:46:22 +0000 (17:46 +0200)]
Fixed code style
Alexander Ebert [Wed, 18 May 2022 15:39:43 +0000 (17:39 +0200)]
Inconsistent sort order of the mobile ACP header
See https://www.woltlab.com/community/thread/295662-mobiles-men%C3%BC-im-acp/
Tim Düsterhus [Wed, 18 May 2022 13:22:50 +0000 (15:22 +0200)]
Restrict access to `?action=WCFSetup` after successful installation
This action only exists to complete WCFSetup. It should be guarded by a check
an unfinished installation (`!PACKAGE_ID`) to prevent accesses in live
installation.
Marcel Werk [Wed, 18 May 2022 11:30:24 +0000 (13:30 +0200)]
Improved overflow behaviour of the contentInteractionButtons buttons on mobile
Tim Düsterhus [Wed, 18 May 2022 11:00:28 +0000 (13:00 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5
Tim Düsterhus [Wed, 18 May 2022 11:00:17 +0000 (13:00 +0200)]
Merge branch '5.4' into 5.5
Marcel Werk [Wed, 18 May 2022 10:45:06 +0000 (12:45 +0200)]
Improved behaviour for contentHeaderNavigation buttons
ref https://www.woltlab.com/community/thread/295238-%C3%A4nderung-der-reihenfolge-von-antworten-pagination-abonnieren-in-der-mobilen-ansi/?postID=
1894039#post1894039
Tim Düsterhus [Tue, 17 May 2022 14:59:10 +0000 (16:59 +0200)]
Fix typo in WCFSetup
Marcel Werk [Tue, 17 May 2022 08:59:25 +0000 (10:59 +0200)]
Unified phrases for deprecated options
Marcel Werk [Fri, 13 May 2022 11:19:15 +0000 (13:19 +0200)]
Deprecated AMP support
PR #4803 accidentally had the wrong target branch.
(cherry picked from commit
8c97dca561b32b3c02f3cb30b32574a8f83b8bd5)
Marcel Werk [Mon, 16 May 2022 19:47:11 +0000 (21:47 +0200)]
Added documentation of minvalue / maxvalue
Marcel Werk [Mon, 16 May 2022 14:54:01 +0000 (16:54 +0200)]
Email address was not visible in listing of group members
Tim Düsterhus [Mon, 16 May 2022 09:38:35 +0000 (11:38 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5
Alexander Ebert [Sat, 14 May 2022 12:30:38 +0000 (14:30 +0200)]
Incorrect handling of the return focus
Related https://www.woltlab.com/community/thread/295562-inhalte-k%C3%B6nnen-doppelt-gemeldet-werden/
(cherry picked from commit
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812)
Tim Düsterhus [Mon, 16 May 2022 09:37:27 +0000 (11:37 +0200)]
Revert "Suppress errors when disabling the focus trap"
This commit duplicates commit
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812 which is
the cleaner fix, but was accidentally commited to `master` only. We revert this
one to allow for a clean cherry-picking of
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812.
This reverts commit
e7439c4f5fc7daf8d45d2de478c488798ddf463a.
Alexander Ebert [Mon, 16 May 2022 09:36:38 +0000 (11:36 +0200)]
Merge pull request #4808 from WoltLab/55-incorrect-http-204-handling
HTTP 204 does not carry a response type
Tim Düsterhus [Mon, 16 May 2022 09:36:19 +0000 (11:36 +0200)]
Fix `wcf.user.register.error.blacklistMatches` language variable in RegisterForm
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`
Apparently the previously used actions uses an out of date phpcs.
(cherry picked from commit
c5cd836751c3fb357b8ddce52a95a83f3ac46347)
Alexander Ebert [Mon, 16 May 2022 09:31:40 +0000 (11:31 +0200)]
Consistent evaluation of the response content type
Alexander Ebert [Mon, 16 May 2022 09:25:55 +0000 (11:25 +0200)]
Proper handling of a 204 response
Alexander Ebert [Mon, 16 May 2022 09:17:50 +0000 (11:17 +0200)]
HTTP 204 does not carry a `content-type`
See https://www.woltlab.com/community/thread/295631-importer-h%C3%A4ngt-bei-reaktionen-100/
Marcel Werk [Mon, 16 May 2022 07:51:10 +0000 (09:51 +0200)]
Merge pull request #4805 from WoltLab/package-xsd
Added documentation of the void element
Tim Düsterhus [Mon, 16 May 2022 07:42:33 +0000 (09:42 +0200)]
Use correct CodeMirror mode for SCSS inputs
`sass` is the indentation based SASS syntax.
Alexander Ebert [Sun, 15 May 2022 11:20:40 +0000 (13:20 +0200)]
Incorrect markup in the authentication dialog
Alexander Ebert [Sun, 15 May 2022 11:04:54 +0000 (13:04 +0200)]
Suppress errors when disabling the focus trap
Alexander Ebert [Sun, 15 May 2022 11:00:09 +0000 (13:00 +0200)]
Use CSS variable to apply the dialog offset
Alexander Ebert [Sun, 15 May 2022 10:38:59 +0000 (12:38 +0200)]
Revert "Dynamic width of code box line numbers"
This reverts commit
d3853740d8304f9703876006db990c2e01642656.
Alexander Ebert [Sun, 15 May 2022 10:37:51 +0000 (12:37 +0200)]
Dynamic width of code box line numbers
This avoids indenting short code listings too much, especially on screens with limited space.
Alexander Ebert [Sun, 15 May 2022 09:17:08 +0000 (11:17 +0200)]
Do not wrap code boxes on mobile
Having long lines wrap multiple times is horrible, overflow scrolling is much better and also quite natural on touch devices.
Alexander Ebert [Sun, 15 May 2022 09:16:26 +0000 (11:16 +0200)]
Better accessibility of code box buttons
Alexander Ebert [Sun, 15 May 2022 09:04:40 +0000 (11:04 +0200)]
Newer iOS versions permit a click near the bottom
Alexander Ebert [Sat, 14 May 2022 17:13:45 +0000 (19:13 +0200)]
Prevent the "external url" indicator to wrap
See https://www.woltlab.com/community/thread/295487-einzelnes-umbrechen-des-externalurl-icons-verhindern/
Alexander Ebert [Sat, 14 May 2022 17:01:48 +0000 (19:01 +0200)]
Expand the active menu item by default
Alexander Ebert [Sat, 14 May 2022 16:12:55 +0000 (18:12 +0200)]
Merge pull request #4807 from WoltLab/55-desktop-notifications
Remove the option to disable desktop notifications
Alexander Ebert [Sat, 14 May 2022 15:10:15 +0000 (17:10 +0200)]
Align the mobile main menu to the right
See https://www.woltlab.com/community/thread/295627-mobil-men%C3%BC-links/
Alexander Ebert [Sat, 14 May 2022 14:32:17 +0000 (16:32 +0200)]
Suppress error messages when aborting `fetch()`
See https://www.woltlab.com/community/thread/295566-fetch-is-aborted-bei-suchergebnissen/
Alexander Ebert [Sat, 14 May 2022 14:07:03 +0000 (16:07 +0200)]
Remove the option to disable desktop notifications
Fixes #4806
Marcel Werk [Sat, 14 May 2022 14:03:45 +0000 (16:03 +0200)]
Added documentation of the void element
Marcel Werk [Sat, 14 May 2022 11:46:27 +0000 (13:46 +0200)]
Merge branch '5.4' into 5.5
Marcel Werk [Sat, 14 May 2022 11:46:05 +0000 (13:46 +0200)]
Truncate error message in cronjob log if necessary
Marcel Werk [Sat, 14 May 2022 10:59:48 +0000 (12:59 +0200)]
Support for meta tags during article import
Marcel Werk [Sat, 14 May 2022 10:35:35 +0000 (12:35 +0200)]
Typo
Tim Düsterhus [Fri, 13 May 2022 09:38:41 +0000 (11:38 +0200)]
Remove obsolete workaround for PHP_CodeSniffer bug
Tim Düsterhus [Thu, 12 May 2022 14:08:05 +0000 (16:08 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 13:38:20 +0000 (15:38 +0200)]
Merge pull request #4798 from pehbeh/patch-1
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
pehbeh [Thu, 12 May 2022 13:31:54 +0000 (15:31 +0200)]
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
Tim Düsterhus [Thu, 12 May 2022 12:48:06 +0000 (14:48 +0200)]
Fix incorrect use of `mb_strpos` in MysqlSearchEngine
The return value of `mb_strpos` needs to be checked type-safely, as both `0`
and `false` are falsy. In this case this likely was safe, as the inner join may
not appear at the start of the query, it was a questionable nonetheless.
Fix this by using `str_contains()` which makes the intent even clearer.
Tim Düsterhus [Thu, 12 May 2022 11:48:37 +0000 (13:48 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 11:48:13 +0000 (13:48 +0200)]
Update URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl
Marcel Werk [Wed, 11 May 2022 13:06:27 +0000 (15:06 +0200)]
Merge pull request #4787 from WoltLab/user-online-list
User online statistics were invisible when all active users were invisible
Tim Düsterhus [Wed, 11 May 2022 12:57:23 +0000 (14:57 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:56:48 +0000 (14:56 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:56:09 +0000 (14:56 +0200)]
Add the `required` attribute to the recipientID select in contact.tpl
see
a8490749c3ba7014380d55462fc45dd635c1d71c
Tim Düsterhus [Wed, 11 May 2022 12:50:53 +0000 (14:50 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 12:49:48 +0000 (14:49 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 11 May 2022 12:49:24 +0000 (14:49 +0200)]
Indicate that selecting a recipient is required in contact.tpl
Marcel Werk [Wed, 11 May 2022 11:09:44 +0000 (13:09 +0200)]
Applied code suggestions
Marcel Werk [Wed, 11 May 2022 10:25:15 +0000 (12:25 +0200)]
Show legend only when users are listed
Marcel Werk [Wed, 11 May 2022 10:24:06 +0000 (12:24 +0200)]
User online statistics were invisible when all active users were invisible
Tim Düsterhus [Wed, 11 May 2022 09:39:12 +0000 (11:39 +0200)]
Merge branch '5.4' into 5.5
Tim Düsterhus [Wed, 11 May 2022 09:38:47 +0000 (11:38 +0200)]
Drop obsolete update_com.woltlab.wcf_5.4.15_deleteDsStore.php
Tim Düsterhus [Wed, 11 May 2022 09:37:38 +0000 (11:37 +0200)]
Drop obsolete fileDelete_5.5.xml
Tim Düsterhus [Wed, 11 May 2022 08:40:35 +0000 (10:40 +0200)]
Fix language items in recommended section of system requirements in WCFSetup
see
3445cbe2a005ead9843d9e17709a915631dd11b5
see
e88d06dc88bc263b7424fbccfa47c13907413b8c
Alexander Ebert [Tue, 10 May 2022 20:58:18 +0000 (22:58 +0200)]
Release 5.5.0 Beta 2
Alexander Ebert [Tue, 10 May 2022 16:06:08 +0000 (18:06 +0200)]
Incorrect dialog position on smartphones
See https://www.woltlab.com/community/thread/295560-neues-thema-erstellen-au%C3%9Ferhalb-des-bildschirms/
Tim Düsterhus [Tue, 10 May 2022 15:33:34 +0000 (17:33 +0200)]
Add the 5.5 branch to GitHub workflows
Alexander Ebert [Tue, 10 May 2022 14:30:34 +0000 (16:30 +0200)]
Release 5.5.0 Beta 1
Alexander Ebert [Tue, 10 May 2022 14:12:26 +0000 (16:12 +0200)]
Removed the upgrade instructions from 5.4.*
WoltLab [Tue, 10 May 2022 13:53:32 +0000 (13:53 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Tue, 10 May 2022 07:26:40 +0000 (09:26 +0200)]
Merge branch '5.4'
Tim Düsterhus [Tue, 10 May 2022 07:25:42 +0000 (09:25 +0200)]
Fix English versions of `wcf.user.security.multifactor.backup.authenticationEmail.body.*`
The phrases contained broken template scripting, due to the use of the `'`
apostroph within a single quoted string.
Alexander Ebert [Mon, 9 May 2022 13:51:17 +0000 (15:51 +0200)]
Dialogs could become too wide with lots of text
Alexander Ebert [Mon, 9 May 2022 12:17:55 +0000 (14:17 +0200)]
Suppress the redundant loading indicator
See https://www.woltlab.com/community/thread/295539-doppelte-ladebalken/
Tim Düsterhus [Mon, 9 May 2022 11:31:31 +0000 (13:31 +0200)]
Merge pull request #4781 from WoltLab/ci-check
Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()
Tim Düsterhus [Mon, 9 May 2022 10:42:53 +0000 (12:42 +0200)]
Add fileDelete_5.5.xml
These files never were part of the git repository, but were accidentally
included in an upgrade package, because an unclean source directory was used
when building the upgrade.
Tim Düsterhus [Mon, 9 May 2022 09:06:38 +0000 (11:06 +0200)]
Flip only the file name casing on AbstractFileDeletePackageInstallationPlugin::isFilesystemCaseSensitive()
Flipping the whole path does not provide any real benefit, because we only care
about whether the file system where WoltLab Suite resides is case sensitive or
not. It does however break when `open_basedir` is configured.
Tim Düsterhus [Mon, 9 May 2022 08:49:45 +0000 (10:49 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 6 May 2022 13:11:45 +0000 (15:11 +0200)]
Remove the codestyle workflow from branches that are not master
Alexander Ebert [Sun, 8 May 2022 11:54:02 +0000 (13:54 +0200)]
Lazy loading the user’s avatar causes flashes
Safari (macOS and iOS) does not handle lazy loaded images above the fold gracefully. This causes the user’s avatar to flicker noticeably on ever page navigation.
Alexander Ebert [Sun, 8 May 2022 11:42:21 +0000 (13:42 +0200)]
Merge pull request #4779 from WoltLab/search-result-pagination
Tracked the result page number in the url
Alexander Ebert [Sun, 8 May 2022 11:38:09 +0000 (13:38 +0200)]
Merge pull request #4777 from WoltLab/article-comment-like-notifications
Notifications about reactions to article comments
Alexander Ebert [Sun, 8 May 2022 11:29:21 +0000 (13:29 +0200)]
Merge pull request #4776 from WoltLab/scroll-to-comments
Scrolling to a comment not visible by default did not work
Marcel Werk [Sat, 7 May 2022 17:11:55 +0000 (19:11 +0200)]
Proper prototype creation
Marcel Werk [Sat, 7 May 2022 17:09:50 +0000 (19:09 +0200)]
Tracked the result page number in the url
Marcel Werk [Sat, 7 May 2022 16:51:22 +0000 (18:51 +0200)]
Proper history navigation for searches
Marcel Werk [Sat, 7 May 2022 16:38:01 +0000 (18:38 +0200)]
Track the page number of search result in the url
Alexander Ebert [Sat, 7 May 2022 16:13:12 +0000 (18:13 +0200)]
Visual separator for specialized search filters
See https://www.woltlab.com/community/thread/295502-kategorie-auswahl-ist-verrutscht/
Marcel Werk [Sat, 7 May 2022 15:42:08 +0000 (17:42 +0200)]
Merge branch '5.4'
Marcel Werk [Sat, 7 May 2022 15:41:59 +0000 (17:41 +0200)]
Merge branch '5.3' into 5.4
Marcel Werk [Sat, 7 May 2022 15:41:46 +0000 (17:41 +0200)]
Merge branch '5.2' into 5.3
Marcel Werk [Sat, 7 May 2022 15:40:48 +0000 (17:40 +0200)]
Revert "Show always an no selection option in custom select options build with the OptionHandler"
This reverts commit
6fef8b82e15794eee5317e6b15bb0670f137315c.
Alexander Ebert [Sat, 7 May 2022 14:59:03 +0000 (16:59 +0200)]
Incorrect margin of `.formSubmit` in dialogs
This was caused by the negative margin introduced in
1d224f10cdd05e7f5d09f869ee1fbbbdff025749 which caused the calculation to be off by 10px, causing a visible gap.
See https://www.woltlab.com/community/thread/295497-fehlerhafte-mobile-darstellung-von-dialogen/
Marcel Werk [Fri, 6 May 2022 21:54:31 +0000 (23:54 +0200)]
Removed obsolete imports
Marcel Werk [Fri, 6 May 2022 21:47:38 +0000 (23:47 +0200)]
Notifications about reactions to article comments
Marcel Werk [Fri, 6 May 2022 21:47:11 +0000 (23:47 +0200)]
Use generic trait in existing notifications for article comments
Marcel Werk [Fri, 6 May 2022 21:46:46 +0000 (23:46 +0200)]
Added generic trait for article comment tests
Marcel Werk [Fri, 6 May 2022 15:57:21 +0000 (17:57 +0200)]
Notification type was not hidden when modules were disabled
Marcel Werk [Fri, 6 May 2022 15:49:54 +0000 (17:49 +0200)]
Scrolling to a comment not visible by default did not work