Pascal COMBES [Tue, 15 Apr 2014 19:21:07 +0000 (21:21 +0200)]
Staging: crystalhd: Fix alignement in crystalhd_lnx.c
Signed-off-by: Pascal COMBES <pascom@orange.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bojan Prtvar [Thu, 3 Apr 2014 16:56:10 +0000 (18:56 +0200)]
staging: vme: Simplfy string usage in vme_user_probe()
We can avoid usage of sprintf() and magic-sized array with simple pointer assignment.
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
Reviewed-by: wharms <wharms@bfs.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bojan Prtvar [Wed, 2 Apr 2014 22:24:10 +0000 (00:24 +0200)]
staging: vme: Fix a small coding style issue in vme_user.c
The checkpatch.pl complains about missing blank line after declaration.
This patch silence the warning.
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bastien Armand [Fri, 4 Apr 2014 19:45:07 +0000 (21:45 +0200)]
staging: panel: add blank lines after declarations
This patch fixes "Missing a blank line after declarations" checkpatch warnings in panel.c.
Signed-off-by: Bastien Armand <armand.bastien@laposte.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bastien Armand [Fri, 18 Apr 2014 16:10:08 +0000 (18:10 +0200)]
staging: panel: fix sparse warnings in keypad_read
This patch fixes two sparse warnings related to keypad_read :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
Signed-off-by: Bastien Armand <armand.bastien@laposte.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bastien Armand [Fri, 18 Apr 2014 16:10:57 +0000 (18:10 +0200)]
staging: panel: fix sparse warnings in lcd_write
This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address spaces)
warning: incorrect type in initializer (incompatible argument 2
(different address spaces))
lcd_write can be used from kernel space (in panel_lcd_print) or from user
space. So we introduce the lcd_write_char function that will write a char to
the device. We modify lcd_write and panel_lcd_print to use it. Finally we add
__user annotation missing in lcd_write.
Signed-off-by: Bastien Armand <armand.bastien@laposte.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Wed, 26 Mar 2014 21:33:41 +0000 (22:33 +0100)]
staging: panel: replace del_timer by del_timer_sync
Use del_timer_sync to ensure that the timer is stopped on all CPUs before
the driver exists.
This change was suggested by Thomas Gleixner.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
declarer name module_exit;
identifier ex;
@@
module_exit(ex);
@@
identifier r.ex;
@@
ex(...) {
<...
- del_timer
+ del_timer_sync
(...)
...>
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sat, 22 Mar 2014 17:57:18 +0000 (19:57 +0200)]
staging: sbe-2t3e3: Fix line over 80 characters in cpld.c
Fix checkpatch.pl issues with line over 80 characters in cpld.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Silvio Fricke [Sat, 12 Apr 2014 00:30:25 +0000 (02:30 +0200)]
staging: vt6655: removed incorrect casting in ioctl.c
This patch fixes the following type of sparse warnings:
drivers/staging/vt6655/ioctl.c:308:104: warning: cast from restricted gfp_t
drivers/staging/vt6655/ioctl.c:579:109: warning: cast from restricted gfp_t
Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Silvio Fricke [Sat, 12 Apr 2014 00:30:24 +0000 (02:30 +0200)]
staging: vt6655: removed incorrect casting in wpactl.c
This patch fixes the following type of sparse warnings:
drivers/staging/vt6655/wpactl.c:596:47: warning: cast from restricted gfp_t
drivers/staging/vt6655/wpactl.c:638:68: warning: cast from restricted gfp_t
drivers/staging/vt6655/wpactl.c:860:42: warning: cast from restricted gfp_t
Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Neil Armstrong [Fri, 11 Apr 2014 12:59:55 +0000 (14:59 +0200)]
staging: vt6656: fix bad symbol declaration
With sparse, the following error appears :
CHECK drivers/staging/vt6656/aes_ccmp.c
drivers/staging/vt6656/aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static?
Add correct include header in order to have function declaration.
Signed-off-by: Neil 'Superna' Armstrong <superna9999@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jimmy Li [Tue, 8 Apr 2014 13:35:02 +0000 (21:35 +0800)]
Staging: vt6655: iwctl.c: fix a sparse warning
fix a sparse warning and do some clean up.
iwctl.c:1846:35: expected restricted gfp_t [usertype] flags
Signed-off-by: Jimmy Li <coder.liss@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guido Martínez [Wed, 2 Apr 2014 17:53:02 +0000 (14:53 -0300)]
staging: vt6655: remove mention of nonexistent function CARDbSetBasicRate
Comments mention a function CARDbSetBasicRate, but it never existed in
the source tree. Remove all mention of it.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guido Martínez [Wed, 2 Apr 2014 17:53:01 +0000 (14:53 -0300)]
staging: vt6655: fix DBG_PRT and PRINT_K macros
Wrap both macros inside a 'do { ... } while(0)' to prevent breakage if
used within another 'if'. Also fix a usage of DBG_PRT with a missing
semicolon.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cédric Cabessa [Wed, 26 Mar 2014 16:49:01 +0000 (17:49 +0100)]
staging: vt6655,vt6656: fix sparse error "unexpected unlock"
Signed-off-by: Cédric Cabessa <ced@ryick.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ileana [Mon, 24 Mar 2014 13:58:05 +0000 (14:58 +0100)]
staging: vt6655: fix sparse warning
Added missing static qualifier
Signed-off-by: Ioana Ileana <ioana.ileana@telecom-paristech.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:32 +0000 (09:01 +0000)]
staging: vt6656: rxtx s_vFillCTSHead replace TYPE_CTL_CTS macro
Replace with IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS from linux/ieee80211.h
to get value of TYPE_CTL_CTS and endian correct to frame_control.
Remove old macros in tether.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:31 +0000 (09:01 +0000)]
staging: vt6656: vnt_fill_ieee80211_rts replace TYPE_CTL_RTS macro
Replace with IEEE80211_FTYPE_CTL | IEEE80211_STYPE_RTS from linux/ieee80211.h
to get value of TYPE_CTL_RTS and endian correct to frame_control.
Remove old macros in tether.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:30 +0000 (09:01 +0000)]
staging: vt6656: rxtx Replace vnt_tx_fifo_head wReserved
At run time wReserved has the value of wCurrentRate.
Replace with current_rate with __le16 base type and endian correct
wCurrentRate.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:29 +0000 (09:01 +0000)]
staging : vt6656: rxtx struct vnt_beacon_buffer Replace wTxByteCount
Replace with tx_byte_count with base type __le16
Provide endian correction in csBeacon_xmit of cbReqCount
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:28 +0000 (09:01 +0000)]
staging: vt6656: rxtx struct vnt_tx_buffer Replace wTxByteCount
Replace with tx_byte_count with base type __le16.
In nsDMA_tx_packet and bRelayPacketSend provide endian correction.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:27 +0000 (09:01 +0000)]
staging: vt6656: rxtx Replace struct vnt_tx_fifo_head wTimeStamp
Replace with time_stamp with base type __le16
In s_bPacketToWirelessUsb endian correct DEFAULT_MSDU_LIFETIME_RES_64us
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:26 +0000 (09:01 +0000)]
staging: vt6656: rxtx: s_vFillTxKey fix pMACHeader sparse warning
Endian convert __le16 pMACHeader->frame_control and pMACHeader->seq_ctrl
back to cpu.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:25 +0000 (09:01 +0000)]
staging: vt6656: rxtx: s_vFillTxKey Fix base type pdwExtIV
Use base type to __le32.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:24 +0000 (09:01 +0000)]
staging: vt6656: rxtx s_vFillTxKey Fix pdwIV base type
Use base type __le32 and endian correct changed values.
Correct endian conversions to cpu_to_le32.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 22 Mar 2014 09:01:23 +0000 (09:01 +0000)]
staging: vt6656: rxtx.c: s_vFillTxKey Replace dwRevIVCounter
Fix base type to __le32 and remove camel case.
Camel case change
dwRevIVCounter -> rev_iv_counter
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jake Edge [Sun, 13 Apr 2014 17:10:45 +0000 (11:10 -0600)]
staging/rtl8187se fix sparse complaints
Fix the following sparse complaints:
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt.c:201:5: warning: symbol 'ieee80211_crypto_init' was not declared. Should it be static?
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt.c:222:6: warning: symbol 'ieee80211_crypto_deinit' was not declared. Should it be static?
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_ccmp.c:446:5: warning: symbol 'ieee80211_crypto_ccmp_init' was not declared. Should it be static?
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_ccmp.c:452:6: warning: symbol 'ieee80211_crypto_ccmp_exit' was not declared. Should it be static?
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_wep.c:264:5: warning: symbol 'ieee80211_crypto_wep_init' was not declared. Should it be static?
drivers/staging/rtl8187se//ieee80211/ieee80211_crypt_wep.c:269:6: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static?
by adding an include file into source files and moving some
declarations around into the proper header files.
Signed-off-by: Jake Edge <jake@edge2.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Kepplinger [Wed, 9 Apr 2014 07:25:55 +0000 (09:25 +0200)]
staging: rtl8187se: fix pointer and return statement's syntax
Use the common kernel coding style.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jonas Hahnfeld [Sun, 6 Apr 2014 15:46:04 +0000 (17:46 +0200)]
staging: rtl8187se: Fix warning symbol should be static
This patch solves some sparse warnings about "symbol [...] was not
declared. Should it be static?" by including the correct header files.
Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 18 Apr 2014 00:31:35 +0000 (09:31 +0900)]
staging: cxt1e1: replace OS_kmalloc/OS_kfree with kzalloc/kfree
Replace OS_kmalloc/OS_kfree with kzalloc/kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:18:26 +0000 (11:18 -0500)]
STAGING: cxt1e1: Remove curly braces
Removes unnecessary curly braces from for loop in eeprom_delay.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:17:59 +0000 (11:17 -0500)]
STAGING: cxt1e1: More formatting fixes
Removes parens as are not necessary for return.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:17:29 +0000 (11:17 -0500)]
STAGING: cxt1e1: Formatting fixes checkpatch issues
Removes spaces before & where needed.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:16:36 +0000 (11:16 -0500)]
STAGING: cxt1e1: Remove volatile variable
Removes volatile variable.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:16:02 +0000 (11:16 -0500)]
STAGING: cxt1e1: Fixes comment blocks
Comment block fixes.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:14:59 +0000 (11:14 -0500)]
STAGING: cxt1e1: Indentation fixes
Indentation fixes using Lindent.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Sun, 23 Mar 2014 16:14:27 +0000 (11:14 -0500)]
STAGING: cxt1e1: Remove sparse warnings
Removes sparse warnings by including a header and adding static to some functions.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Matei Oprea [Sun, 23 Mar 2014 12:13:16 +0000 (14:13 +0200)]
staging: cxt1e1: hwprobe: fix incorrect type in assignment
This patch fixes "incorrect type in argument 1" warning from sparse.
Signed-off-by: Matei Oprea <eu@opreamatei.ro>
Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hayato Suzuki [Wed, 16 Apr 2014 11:57:14 +0000 (20:57 +0900)]
staging: speakup: fix typo in kobjects.c
Correct spelling typo in kobjects.c
Signed-off-by: Hayato Suzuki <hytszk@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:18 +0000 (01:49 +0000)]
staging: crypto: skein: add TODO file
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:17 +0000 (01:49 +0000)]
staging: crypto: skein: remove unnecessary line continuation
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:16 +0000 (01:49 +0000)]
staging: crypto: skein: remove braces from single-statement block
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:15 +0000 (01:49 +0000)]
staging: crypto: skein: remove externs from .c files
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:14 +0000 (01:49 +0000)]
staging: crypto: skein: wrap multi-line macros in do-while loops
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:13 +0000 (01:49 +0000)]
staging: crypto: skein: fix brace placement errors
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:12 +0000 (01:49 +0000)]
staging: crypto: skein: fix do/while brace formatting
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:11 +0000 (01:49 +0000)]
staging: crypto: skein: cleanup >80 character lines
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:10 +0000 (01:49 +0000)]
staging: crypto: skein: remove trailing whitespace
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:09 +0000 (01:49 +0000)]
staging: crypto: skein: fix leading whitespace
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:08 +0000 (01:49 +0000)]
staging: crypto: skein: dos2unix, remove executable perms
$ find drivers/staging/skein -type f | xargs todos -d
$ chmod -x drivers/staging/skein/skeinApi.c
$ chmod -x drivers/staging/skein/include/skeinApi.h
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:07 +0000 (01:49 +0000)]
staging: crypto: skein: cleanup whitespace around operators/punc.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:06 +0000 (01:49 +0000)]
staging: crypto: skein: fixup pointer whitespace
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:05 +0000 (01:49 +0000)]
staging: crypto: skein: use u8, u64 vice uint*_t
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:04 +0000 (01:49 +0000)]
staging: crypto: skein: remove all typedef {struct, enum}
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:03 +0000 (01:49 +0000)]
staging: crypto: skein: remove unneeded typedefs
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:02 +0000 (01:49 +0000)]
staging: crypto: skein: remove __cplusplus and an unneeded stddef.h
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:01 +0000 (01:49 +0000)]
staging: crypto: skein: remove skein_port.h
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:49:00 +0000 (01:49 +0000)]
staging: crypto: skein: remove brg_*.h includes
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 02:32:49 +0000 (02:32 +0000)]
staging: crypto: skein: allow building statically
These are the minimum changes required to get the code to build
statically in the kernel. It's necessary to do this first so that we
can empirically determine that future cleanup patches aren't changing
the generated object code.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Mon, 24 Mar 2014 01:48:58 +0000 (01:48 +0000)]
L. Alberto Giménez [Sun, 6 Apr 2014 22:12:30 +0000 (00:12 +0200)]
staging/line6: Fix kzalloc coding style issue
Pass the actual variable to sizeof instead of a type definition.
Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
Acked-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabian Mewes [Mon, 24 Mar 2014 22:46:31 +0000 (23:46 +0100)]
staging: line6: Add blank lines after declarations
Use the more common kernel coding style.
Signed-off-by: Fabian Mewes <architekt@coding4coffee.org>
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Sampson [Fri, 4 Apr 2014 22:01:25 +0000 (09:01 +1100)]
Staging: lustre: mark a variable static in workitem.c
This fixes a sparse warning:
warning: symbol 'cfs_wi_data' was not declared. Should it be static?
Signed-off-by: Mike Sampson <mike@sambodata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 7 Apr 2014 02:47:17 +0000 (11:47 +0900)]
staging: lustre: use NULL instead of 0 for pointer
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Denis Pithon [Mon, 14 Apr 2014 16:25:30 +0000 (18:25 +0200)]
staging/lustre: fix sparse warning
Fix sparse complaint: "Using plain integer as NULL pointer"
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:59 +0000 (19:12 +1100)]
Staging: lustre: Fixed syntax errors reported by checkpatch.pl script for file types.h
Added space after ',' and moved '{' to same line as struct as instructed by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:58 +0000 (19:12 +1100)]
Staging: lustre: Corrected styling errors reported by checkpatch.pl script on file ptllnd_wire.h
Moved '{' from new line to same line as struct as advised by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:57 +0000 (19:12 +1100)]
Staging: lustre: Fixed errors reported by checkpatch.pl script for file ptllnd.h
Added space after ',' as reported as error by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Thu, 27 Mar 2014 23:21:07 +0000 (00:21 +0100)]
staging: lustre: use __func__ instead of __FUNCTION__
__FUNCTION__ is gcc specific; use __func__ instead.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John de la Garza [Mon, 24 Mar 2014 20:58:02 +0000 (13:58 -0700)]
drivers:staging:lustre Fixed sparse warning: plain integer as NULL pointer
Fixes these sparse warnings:
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:202:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:203:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:204:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:205:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:206:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:207:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:213:47: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:214:11: warning: Using plain integer as NULL pointer
Signed-off-by: John de la Garza <john@jjdev.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 21 Mar 2014 14:42:52 +0000 (23:42 +0900)]
staging: lustre: Fix typo in lustre/include
Fix spelling typo in comments within lustre/include.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julian Gindi [Sun, 13 Apr 2014 22:38:31 +0000 (18:38 -0400)]
bcm: Fixing a few checkpatch issues in InterfaceMisc.h
Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h.
I converted some spaces to tabs, and removed unnecessary whitespace. The
kernel version I am using linux-next-
20140411.
Signed-off-by: Julian Gindi <juliangindi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Tue, 15 Apr 2014 10:03:05 +0000 (12:03 +0200)]
staging: binder: add __user annotation in binder.c
Add __user to binder_version to correct sparse warning.
Reduce line size to fit to coding style.
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Seunghun Lee [Wed, 16 Apr 2014 15:39:44 +0000 (00:39 +0900)]
staging: android: uapi: fix coding style
This patch fix checkpatch.pl warning and errors.
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Garret Kelly [Mon, 7 Apr 2014 03:47:31 +0000 (23:47 -0400)]
staging: goldfish: Fix missing blank lines
Fix two instances of the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Garret Kelly <garret.kelly@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 24 Mar 2014 23:45:09 +0000 (01:45 +0200)]
staging: goldfish: switch from spinlock to mutex
Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
the TODO list.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:52 +0000 (19:44 +0200)]
staging: rtl8723au: Make _rtw_free_network23() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:51 +0000 (19:44 +0200)]
staging: rtl8723au: Remove bogus inline from rtw_set_roaming() prototype
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:50 +0000 (19:44 +0200)]
staging: rtl8723au: Move rtw23a_roaming() so we can declare _rtw_roaming() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:49 +0000 (19:44 +0200)]
staging: rtl8723au: collect_bss_info23a(): Use struct ieee80211_mgmt
Somplify code by using struct ieee80211_mgmt to calculate offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:48 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused function rtw_get_timestampe_from_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:47 +0000 (19:44 +0200)]
staging: rtl8723au: Fold _rtw_free_mlme_priv23a() into rtw_free_mlme_priv23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:46 +0000 (19:44 +0200)]
staging: rtl8723au: Fold rtw_to_roaming() into the code
Simple read variable from a struct function, having it as an external
function is just silly.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:45 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_mlme.c: Clean up mess
Clean up spaghetti formatting and avoid NULL initializing variables
where it isn't needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:44 +0000 (19:44 +0200)]
staging: rtl8723au: Remove dummy function rtw_hostapd_mlme_rx23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:43 +0000 (19:44 +0200)]
staging: rtl8723au: Remove another unused prototype
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:42 +0000 (19:44 +0200)]
staging: rtl8723au: Fold some resource allocation abstraction into their callers
Fold rtw_os_recvbuf_resource_alloc23a() and
rtw_os_recvbuf_resource_free23a() into the functions calling them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:41 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unnecessary abstraction rtw_os_recv_resource_alloc23a()
No point calling a function to NULL a pointer that was just cleared in
the malloc call.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:40 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused function rtw_os_read_port23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:39 +0000 (19:44 +0200)]
staging: rtl8723au: Clean up namespace clashes with rtl8188eu driver
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:38 +0000 (19:44 +0200)]
staging: rtl8188eu: os_intfs.c: Mark a couple of variables static
Mark these variables local to avoid namespace clash with other RTL
drivers.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:37 +0000 (19:44 +0200)]
staging: rtl8188eu: usb_intf.c: No point processing an empty table
In addition, this would globally disable HT if one device in the
system would mark it unsupported. If any device ended up requiring
this, it should be handled on a per-instance basis.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:36 +0000 (19:44 +0200)]
staging: rtl8723au: os_intfs.c: Declare a couple of local variables static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:35 +0000 (19:44 +0200)]
staging: rtl8723au: init_channel_set(): Restructure variable names
Shorten variable names allowing for fewer broken lines due to the
large number of indents.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:34 +0000 (19:44 +0200)]
staging: rtl8723au: mgmt_dispatcher23a(): Use struct ieee80211_mgmt
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:33 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23a(): ieee80211.h-ify
Switch to using struct ieee80211_mgmt to obtain offsets. Again a
bizarre +4 offset was applied for the IE scan which doesn't make
sense, since this offset wasn't applied for the auth struct elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:32 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23aClient23a(): Clean up using struct ieee80211_mgmt
Use 80211_mgmt to determine offsets within the received frame. This
also removes a suspicious offset adjustment:
offset = ieee80211_has_protected(hdr->frame_control) ? 4: 0;
which didn't make any sense, since it was only applied to determining
the auth, sequence number, and status, but wasn't applied to the
location of the IEs.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:31 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211_mgmt to obtain DA
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:30 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a_back23a(): Use struct ieee8011_mgmt to parse action frames
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:29 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a(): Use struct ieee80211_mgmt instead of hardcoded offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / log