GitHub/WoltLab/WCF.git
13 years agoFixed some language variables
Marcel Werk [Mon, 26 Sep 2011 16:43:51 +0000 (18:43 +0200)]
Fixed some language variables

13 years agoMerge pull request #188 from wbbaddons/devNullCache
Marcel Werk [Mon, 26 Sep 2011 16:06:12 +0000 (09:06 -0700)]
Merge pull request #188 from wbbaddons/devNullCache

Adding "NoCacheSource"

13 years agoMerge pull request #191 from Gravatronics/bug/languageToString
Marcel Werk [Mon, 26 Sep 2011 16:04:54 +0000 (09:04 -0700)]
Merge pull request #191 from Gravatronics/bug/languageToString

Adds wcf\data\language\Language::__toString()

13 years agoLanguage::__toString() now returns languageName property
Matthias Schmidt [Mon, 26 Sep 2011 16:00:49 +0000 (18:00 +0200)]
Language::__toString() now returns languageName property

13 years agoMerge pull request #186 from Gravatronics/bug/languageInstallation
Alexander Ebert [Mon, 26 Sep 2011 13:23:13 +0000 (06:23 -0700)]
Merge pull request #186 from Gravatronics/bug/languageInstallation

Fixes bug during installation of new language items

13 years agoAdds wcf\data\language\Language::__toString()
Matthias Schmidt [Mon, 26 Sep 2011 11:37:48 +0000 (13:37 +0200)]
Adds wcf\data\language\Language::__toString()

Fixes a bug when `LanguageFactory::getInstance()->getLanguages()` is used for html check boxes. Additionally the documentation has been updated a bit.

13 years agoFixing PHPDoc of NoCacheSource
Tim Düsterhus [Sun, 25 Sep 2011 16:37:53 +0000 (18:37 +0200)]
Fixing PHPDoc of NoCacheSource

13 years agoAdding "NoCacheSource"
Tim Düsterhus [Sun, 25 Sep 2011 16:22:22 +0000 (18:22 +0200)]
Adding "NoCacheSource"

Disables the cache entirely, useful for debugging purposes.

13 years agoFixes bug during installation of new language items
Matthias Schmidt [Sun, 25 Sep 2011 13:13:41 +0000 (15:13 +0200)]
Fixes bug during installation of new language items

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Fri, 23 Sep 2011 18:51:31 +0000 (20:51 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoFront end template overhaul; new template events added
Marcel Werk [Fri, 23 Sep 2011 18:51:15 +0000 (20:51 +0200)]
Front end template overhaul; new template events added

13 years agoOK, that didn't work in Firefox! :-(
Luzifr [Fri, 23 Sep 2011 18:03:56 +0000 (20:03 +0200)]
OK, that didn't work in Firefox! :-(

13 years agoSome small changes (removes some png-icons and solves a problem with bubble-style...
Luzifr [Fri, 23 Sep 2011 18:00:26 +0000 (20:00 +0200)]
Some small changes (removes some png-icons and solves a problem with bubble-style-infos)

13 years agoMerge pull request #183 from Gravatronics/bug/updateServerEdit
Alexander Ebert [Fri, 23 Sep 2011 17:10:25 +0000 (10:10 -0700)]
Merge pull request #183 from Gravatronics/bug/updateServerEdit

Fixes wcf\acp\form\UpdateServerEditForm

13 years agoMerge pull request #185 from Gravatronics/cleanup/tempestUpdateServer
Alexander Ebert [Fri, 23 Sep 2011 17:08:24 +0000 (10:08 -0700)]
Merge pull request #185 from Gravatronics/cleanup/tempestUpdateServer

Removes tempest package update servers

13 years ago Front-end and more
Luzifr [Fri, 23 Sep 2011 14:22:00 +0000 (16:22 +0200)]
 Front-end and more

Min-height for main content; Footer-template now similar to acp-footer;
Some more corrections.

13 years agoMerge pull request #181 from Gravatronics/bug/installationStyleFileName
Harald Szekely [Fri, 23 Sep 2011 12:08:44 +0000 (05:08 -0700)]
Merge pull request #181 from Gravatronics/bug/installationStyleFileName

Corrects the style file name in the installation

13 years agoRemoves tempest package update servers
Matthias Schmidt [Fri, 23 Sep 2011 10:19:46 +0000 (12:19 +0200)]
Removes tempest package update servers

Additionally some whitespace is removed.

13 years agoFixes wcf\acp\form\UpdateServerEditForm
Matthias Schmidt [Fri, 23 Sep 2011 08:19:26 +0000 (10:19 +0200)]
Fixes wcf\acp\form\UpdateServerEditForm

Two errors:
* Wrong database table column name which causes database error
* Wrong class property and object property name which causes that the server url isn't shown in the form

13 years agoCorrects the style file name
Matthias Schmidt [Fri, 23 Sep 2011 07:18:05 +0000 (09:18 +0200)]
Corrects the style file name

13 years agoLanguage object cache added
Marcel Werk [Thu, 22 Sep 2011 20:30:01 +0000 (22:30 +0200)]
Language object cache added

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Thu, 22 Sep 2011 19:35:02 +0000 (21:35 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoFixed some issues in the language system
Marcel Werk [Thu, 22 Sep 2011 19:34:50 +0000 (21:34 +0200)]
Fixed some issues in the language system

13 years agoForm-error styling; Various bug-fixes; Deleted 2 obsolete templates.
Luzifr [Thu, 22 Sep 2011 18:21:45 +0000 (20:21 +0200)]
Form-error styling; Various bug-fixes; Deleted 2 obsolete templates.

Front-end is not usable now ;-)

13 years agoMerge pull request #176 from Gravatronics/cleanup/acpMenuXMLIcon
Marcel Werk [Thu, 22 Sep 2011 14:49:40 +0000 (07:49 -0700)]
Merge pull request #176 from Gravatronics/cleanup/acpMenuXMLIcon

Removes obsolete icons of ACP menu items

13 years agoMerge pull request #175 from Gravatronics/enhancement/dataDocUpdate
Marcel Werk [Thu, 22 Sep 2011 14:49:13 +0000 (07:49 -0700)]
Merge pull request #175 from Gravatronics/enhancement/dataDocUpdate

Updates documentation of DatabaseObject and ProcessibleDatabaseObject

13 years agoRemoves icon element from acp menu XSD file
Matthias Schmidt [Thu, 22 Sep 2011 14:32:21 +0000 (16:32 +0200)]
Removes icon element from acp menu XSD file

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Thu, 22 Sep 2011 14:31:38 +0000 (16:31 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoAdded "real" language name
Marcel Werk [Thu, 22 Sep 2011 14:31:24 +0000 (16:31 +0200)]
Added "real" language name

13 years agoStyle changes (files/declarations)
Luzifr [Thu, 22 Sep 2011 14:30:11 +0000 (16:30 +0200)]
Style changes (files/declarations)

Deleted unnecessary/old style-files; Renamed "testing.css" to
"style.css"; We now use "style.css" in the front-end; Changed all
style-sheet-links to "@import".

13 years agoRemoves obsolete icons of ACP menu items
Matthias Schmidt [Thu, 22 Sep 2011 14:28:56 +0000 (16:28 +0200)]
Removes obsolete icons of ACP menu items

13 years agoSome corrections for Buttons + a comment
Luzifr [Thu, 22 Sep 2011 12:42:35 +0000 (14:42 +0200)]
Some corrections for Buttons + a comment

13 years agoFixes type in documentation of DatabaseObject::compareObjects()
Matthias Schmidt [Thu, 22 Sep 2011 10:56:31 +0000 (12:56 +0200)]
Fixes type in documentation of DatabaseObject::compareObjects()

13 years agoUpdates documentation of DatabaseObject and ProcessibleDatabaseObject
Matthias Schmidt [Thu, 22 Sep 2011 10:54:46 +0000 (12:54 +0200)]
Updates documentation of DatabaseObject and ProcessibleDatabaseObject

13 years agoMerge pull request #174 from Gravatronics/enhancement/iOptionTypeDocUpdate
Alexander Ebert [Thu, 22 Sep 2011 10:27:40 +0000 (03:27 -0700)]
Merge pull request #174 from Gravatronics/enhancement/iOptionTypeDocUpdate

Updates the documentation of wcf\system\option\IOptionType

13 years agoMerge pull request #171 from wbbaddons/installationStyleFix
Alexander Ebert [Thu, 22 Sep 2011 10:26:46 +0000 (03:26 -0700)]
Merge pull request #171 from wbbaddons/installationStyleFix

Fixing Style in last step of WCFSetup

13 years agoOne more time dropdowns; CSS clean-up: button-colors
Luzifr [Wed, 21 Sep 2011 20:21:43 +0000 (22:21 +0200)]
One more time dropdowns; CSS clean-up: button-colors

More dropdown-changes; All buttons now get their colors by the same
style block! Only special/individual styles are declared separately.
This should make the file  a lot smaller. Maybe there are some bugs to
fix after this update.

13 years agoOne more time dropdown-experiments …
Luzifr [Wed, 21 Sep 2011 18:39:58 +0000 (20:39 +0200)]
One more time dropdown-experiments …

13 years agoSome more dropdown-menu experiments
Luzifr [Wed, 21 Sep 2011 17:32:54 +0000 (19:32 +0200)]
Some more dropdown-menu experiments

13 years agoModified overlays
Alexander Ebert [Wed, 21 Sep 2011 16:50:13 +0000 (18:50 +0200)]
Modified overlays

The 'loading …'-overlay now stays for at least one second to provide a smoother behavior. Additionally implemented a global event handler 'WCF.CloseOverlayHandler' to provide a consistent handler to close overlays once they've lost focus (click event bubbled to body-tag).

13 years agoFirst version of button/drop-down styles in front of input fields
Luzifr [Wed, 21 Sep 2011 13:55:43 +0000 (15:55 +0200)]
First version of button/drop-down styles in front of input fields

This is experimental at the moment! Also included min-widths for
text-input fields.

13 years agoFixes typo in wcf\system\option\IOptionType
Matthias Schmidt [Wed, 21 Sep 2011 13:23:33 +0000 (15:23 +0200)]
Fixes typo in wcf\system\option\IOptionType

13 years agoUpdates the documentation of wcf\system\option\IOptionType
Matthias Schmidt [Wed, 21 Sep 2011 13:17:42 +0000 (15:17 +0200)]
Updates the documentation of wcf\system\option\IOptionType

13 years agoFixes the Clipboard menu (does only work partly in Opera!)
Luzifr [Tue, 20 Sep 2011 17:09:39 +0000 (19:09 +0200)]
Fixes the Clipboard menu (does only work partly in Opera!)

13 years agoDeleted old style files, fixed small user-list bug
Luzifr [Tue, 20 Sep 2011 15:24:05 +0000 (17:24 +0200)]
Deleted old style files, fixed small user-list bug

13 years agoFixing Style in last step of WCFSetup
Tim Düsterhus [Tue, 20 Sep 2011 13:59:14 +0000 (15:59 +0200)]
Fixing Style in last step of WCFSetup

Closes gh-170
The Style was no loaded because it was still tunneled through install.php which was already deleted at that point

13 years agoSome typos, Faster scroll Effect, Tabs
Luzifr [Tue, 20 Sep 2011 13:37:12 +0000 (15:37 +0200)]
Some typos, Faster scroll Effect, Tabs

Fixed some typos, quickened the smooth-scroll effect, gave the tabs a
max-width to prevent too wide pages when there are too many tabs (not
really a good solution!), fixed some small spacing problems with
borders and fieldsets.

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Tue, 20 Sep 2011 13:20:31 +0000 (15:20 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoSetup fixed
Marcel Werk [Tue, 20 Sep 2011 13:20:19 +0000 (15:20 +0200)]
Setup fixed

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Tue, 20 Sep 2011 13:14:06 +0000 (15:14 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

Conflicts:
wcfsetup/install/files/acp/templates/userList.tpl
wcfsetup/install/files/js/WCF.js

13 years agoChanged HTML structure for clipboard API
Alexander Ebert [Tue, 20 Sep 2011 12:57:47 +0000 (14:57 +0200)]
Changed HTML structure for clipboard API

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Tue, 20 Sep 2011 12:51:20 +0000 (14:51 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

Conflicts:
wcfsetup/install/files/acp/templates/acpSessionLog.tpl
wcfsetup/install/files/acp/templates/cronjobList.tpl

13 years agoLanguage variable overhaul
Marcel Werk [Tue, 20 Sep 2011 12:39:20 +0000 (14:39 +0200)]
Language variable overhaul

13 years agoSome changes to icons and a new one
Luzifr [Mon, 19 Sep 2011 20:13:29 +0000 (22:13 +0200)]
Some changes to icons and a new one

13 years agoLarge Button Icons enabled (testing)
Luzifr [Mon, 19 Sep 2011 19:40:51 +0000 (21:40 +0200)]
Large Button Icons enabled (testing)

13 years ago2 small things forgotten.
Luzifr [Mon, 19 Sep 2011 16:32:20 +0000 (18:32 +0200)]
2 small things forgotten.

Coding style:
Attribute "id" should always come first! (Except in a form element,
then the type should be first)
Attribute "class" should always be found on the last place in a tag!

13 years agoMany small changes, mostly the Clipboard Editor display …
Luzifr [Mon, 19 Sep 2011 16:02:47 +0000 (18:02 +0200)]
Many small changes, mostly the Clipboard Editor display …

13 years agoLanguageFactory is now a descendant of SingletonFactory
Alexander Ebert [Mon, 19 Sep 2011 13:07:31 +0000 (15:07 +0200)]
LanguageFactory is now a descendant of SingletonFactory

13 years agoTables, Installation dialogues, Buttons, many small changes
Luzifr [Fri, 16 Sep 2011 20:07:31 +0000 (22:07 +0200)]
Tables, Installation dialogues, Buttons, many small changes

Some more tables adapted to have the new look and some small
bug-fixing; Again fixed some button-problems; More styling for the
several installation dialogues (not yet ready); Made the collapsible
table at package view function; Some smaller bug-fixes.

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Fri, 16 Sep 2011 17:45:25 +0000 (19:45 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoAgain table-views & some minor stuff
Luzifr [Fri, 16 Sep 2011 17:27:08 +0000 (19:27 +0200)]
Again table-views & some minor stuff

Unified table views (orientations & column CSS classes); Extended the
set of standard-classes for different table-row designs, they are
always the first declaration, please use those classes only (but note,
that in some cases there are generic table-columns, which cannot be
styled individually that way, we will have to add the generic classes
to the matching CSS declaration from time to time); Changed the way
elements on pages hold their distance to others. Note that we now use
only margins to the top, but no margins to the bottom any more; Edited
some cronjob texts; Edited the worker-template to reflect the changes
in the other overlay-templates.

13 years agoFixed usage of language variable in JS
Alexander Ebert [Fri, 16 Sep 2011 11:25:39 +0000 (13:25 +0200)]
Fixed usage of language variable in JS

13 years agoThat should be better! ;)
Luzifr [Fri, 16 Sep 2011 09:13:18 +0000 (11:13 +0200)]
That should be better! ;)

13 years agoSome refinements to fieldsets & buttons; replaced text with variable.
Luzifr [Thu, 15 Sep 2011 15:09:31 +0000 (17:09 +0200)]
Some refinements to fieldsets & buttons; replaced text with variable.

13 years agoSome small changes
Luzifr [Thu, 15 Sep 2011 14:45:08 +0000 (16:45 +0200)]
Some small changes

Started styling the installation-overlays; corrected most of the
english installation language-file; some small modifications to other
files.

13 years agoExporting email addresses now working
Alexander Ebert [Thu, 15 Sep 2011 12:49:49 +0000 (14:49 +0200)]
Exporting email addresses now working

13 years agoMinor form effects changes
Luzifr [Thu, 15 Sep 2011 12:06:30 +0000 (14:06 +0200)]
Minor form effects changes

13 years agoMarked items are now displayed on page load.
Alexander Ebert [Thu, 15 Sep 2011 11:52:48 +0000 (13:52 +0200)]
Marked items are now displayed on page load.

Reworked ClipboardAction to allow a better inheritance. ClipboardHandler now caches raw data for marked items, allowing further processing.

13 years agoDeleted obsolete icon, added 2 new ones
Luzifr [Wed, 14 Sep 2011 19:22:23 +0000 (21:22 +0200)]
Deleted obsolete icon, added 2 new ones

13 years agoInserted template events
Alexander Ebert [Wed, 14 Sep 2011 16:14:40 +0000 (18:14 +0200)]
Inserted template events

13 years agoFixed mail worker
Alexander Ebert [Wed, 14 Sep 2011 14:33:14 +0000 (16:33 +0200)]
Fixed mail worker

13 years agoAdded a proceed URL after worker has finished
Alexander Ebert [Wed, 14 Sep 2011 14:02:46 +0000 (16:02 +0200)]
Added a proceed URL after worker has finished

13 years agoFixed worker progress (calculation mismatch)
Alexander Ebert [Wed, 14 Sep 2011 13:45:15 +0000 (15:45 +0200)]
Fixed worker progress (calculation mismatch)

13 years agoSmall changes
Luzifr [Wed, 14 Sep 2011 09:35:15 +0000 (11:35 +0200)]
Small changes

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Tue, 13 Sep 2011 19:27:08 +0000 (21:27 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoImplemented worker system based upon AJAX dialogs.
Alexander Ebert [Tue, 13 Sep 2011 19:06:34 +0000 (21:06 +0200)]
Implemented worker system based upon AJAX dialogs.

Reworked the previous worker system relying on the old-style WCF 1.1 worker system as used by the installation itself. Right now the system is pretty unstable and I'm not sure wether the loop calculation is right.

13 years agoImplemented worker system based upon AJAX dialogs.
Alexander Ebert [Tue, 13 Sep 2011 19:06:34 +0000 (21:06 +0200)]
Implemented worker system based upon AJAX dialogs.

Reworked the previous worker system relying on the old-style WCF 1.1 worker system as used by the installation itself. Right now the system is pretty unstable and I'm not sure wether the loop calculation is right.

13 years agoDeleted obsolete old styles
Luzifr [Tue, 13 Sep 2011 16:10:11 +0000 (18:10 +0200)]
Deleted obsolete old styles

The installation now uses the full style from the ACP

13 years agoSome minor changes
Luzifr [Tue, 13 Sep 2011 15:49:47 +0000 (17:49 +0200)]
Some minor changes

ID for the installer body (in case we need it); Replaced quote marks in
the CSS with single quotes; Removed class "smallFont", as it
does/should not exist in table context any more; Moved formatting of
special table-columns to a separate section in the CSS (there will have
to be a lot of changes with those).

13 years agoMerge pull request #161 from wbbaddons/installationProgressBarFix
Alexander Ebert [Tue, 13 Sep 2011 14:53:14 +0000 (07:53 -0700)]
Merge pull request #161 from wbbaddons/installationProgressBarFix

Progressbar - WCFSetup

13 years agoProgressbar - WCFSetup
Tim Düsterhus [Tue, 13 Sep 2011 14:48:56 +0000 (16:48 +0200)]
Progressbar - WCFSetup

Made the progressbar in WCFSetup funktional.

13 years agoMerge branch 'master' of github.com:WoltLab/WCF
Marcel Werk [Tue, 13 Sep 2011 14:44:24 +0000 (16:44 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF

13 years agoAdded some template events in header template
Marcel Werk [Tue, 13 Sep 2011 14:44:08 +0000 (16:44 +0200)]
Added some template events in header template

13 years agoWCF installation folder
Luzifr [Tue, 13 Sep 2011 13:09:19 +0000 (15:09 +0200)]
WCF installation folder

More text for information

13 years agoHTML corrected
Luzifr [Tue, 13 Sep 2011 12:46:43 +0000 (14:46 +0200)]
HTML corrected

13 years agoFixed template compilation
Alexander Ebert [Tue, 13 Sep 2011 12:46:14 +0000 (14:46 +0200)]
Fixed template compilation

Template owner's package id was previously used, but conflicts with application groups. Furthermore template listeners were not included due to lack of cache loading.

13 years agoCoding style & disabled buttons
Luzifr [Tue, 13 Sep 2011 12:18:42 +0000 (14:18 +0200)]
Coding style & disabled buttons

13 years agoSome corrections of stuff from the last commit.
Luzifr [Mon, 12 Sep 2011 20:01:50 +0000 (22:01 +0200)]
Some corrections of stuff from the last commit.

Fixes some text-confusion with the WCF installation folder display @
installation.

13 years agoInstallation-, Language and Style-Changes
Luzifr [Mon, 12 Sep 2011 19:31:58 +0000 (21:31 +0200)]
Installation-, Language and Style-Changes

Installation is now widely functional again, some pages have been
modified; New language-variables and some older modified; Style changes
to work around the missing header-link of the installation page;
CSS-code format; Proper installation icon (the former was
unintentional).

13 years agoHighlighting license by setting focus
Alexander Ebert [Mon, 12 Sep 2011 16:58:50 +0000 (18:58 +0200)]
Highlighting license by setting focus

13 years agoInstallation correction, CSS-Update
Luzifr [Mon, 12 Sep 2011 16:53:25 +0000 (18:53 +0200)]
Installation correction, CSS-Update

13 years agoSome changes to installation.
Luzifr [Mon, 12 Sep 2011 16:21:09 +0000 (18:21 +0200)]
Some changes to installation.

13 years agoFixed icons during WCFSetup
Alexander Ebert [Mon, 12 Sep 2011 16:20:08 +0000 (18:20 +0200)]
Fixed icons during WCFSetup

It is now possible to fetch images (jpg, png or svg) and CSS via install.php

13 years agoFixed usage of RELATIVE_WCF_DIR during setup
Alexander Ebert [Mon, 12 Sep 2011 15:44:34 +0000 (17:44 +0200)]
Fixed usage of RELATIVE_WCF_DIR during setup

13 years agoStyling the installation (Part 2)
Luzifr [Fri, 9 Sep 2011 19:37:59 +0000 (21:37 +0200)]
Styling the installation (Part 2)

Warning: Crash for sure!  Just added the needed CSS declarations into
the setup header. There will be a different solution for that in the
future! Images will not load yet. Updated all installation templates to
meet the new design standards and HTML 5. We are still not ready here!
:-)

13 years agoMerge pull request #157 from Gravatronics/langVarFixes
Alexander Ebert [Fri, 9 Sep 2011 18:00:52 +0000 (11:00 -0700)]
Merge pull request #157 from Gravatronics/langVarFixes

Fixes wrong language variable names in xml files

13 years agoMerge pull request #158 from Gravatronics/documentationUpdates
Alexander Ebert [Fri, 9 Sep 2011 17:52:02 +0000 (10:52 -0700)]
Merge pull request #158 from Gravatronics/documentationUpdates

Updates some documentation + CronjobUtil "fixes"

13 years agoMerge pull request #154 from Gravatronics/userGroupsUGOT
Alexander Ebert [Fri, 9 Sep 2011 17:45:52 +0000 (10:45 -0700)]
Merge pull request #154 from Gravatronics/userGroupsUGOT

Beautifies the user groups user group option type

13 years agoMerge pull request #152 from Gravatronics/sqlFile
Alexander Ebert [Fri, 9 Sep 2011 17:45:18 +0000 (10:45 -0700)]
Merge pull request #152 from Gravatronics/sqlFile

Sorts the database tables in install.sql

13 years agoStyling the installation (Part 1)
Luzifr [Fri, 9 Sep 2011 15:33:23 +0000 (17:33 +0200)]
Styling the installation (Part 1)

This is a first try and work in progress! Be aware that the installation
panels may look very ugly in the next time … ;-)