Marcel Werk [Tue, 1 Sep 2020 14:43:56 +0000 (16:43 +0200)]
Unnecessary description removed
woltlab.com [Tue, 1 Sep 2020 14:24:30 +0000 (14:24 +0000)]
Updating minified JavaScript files
Alexander Ebert [Sat, 29 Aug 2020 23:20:00 +0000 (01:20 +0200)]
Merge pull request #3539 from mutec/53upgrade
WIP: Prepare upgrade instructions for 5.2 to 5.3
Alexander Ebert [Sat, 29 Aug 2020 21:37:42 +0000 (23:37 +0200)]
Resolved some issues during the upgrade, first successful upgrade
Alexander Ebert [Sat, 29 Aug 2020 16:54:53 +0000 (18:54 +0200)]
Deploy some files ahead of the upgrade
Alexander Ebert [Sat, 29 Aug 2020 16:49:48 +0000 (18:49 +0200)]
Set up the proper default package servers
Alexander Ebert [Sat, 29 Aug 2020 16:49:33 +0000 (18:49 +0200)]
Merge branch 'master' into pr/3539
Marcel Werk [Sat, 29 Aug 2020 14:43:07 +0000 (16:43 +0200)]
Added hover indicator in notification settings form
Alexander Ebert [Sat, 29 Aug 2020 13:50:27 +0000 (15:50 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 29 Aug 2020 12:05:58 +0000 (14:05 +0200)]
Preserve the leading and trailing whitespace in `<kbd>` on output
Fixes #3536
Alexander Ebert [Fri, 28 Aug 2020 18:16:36 +0000 (20:16 +0200)]
Merge pull request #3495 from Krymonota/update-version-dev-config-file-name-5.3
Update version number in Devtools config file name to 5.3
mutec [Fri, 28 Aug 2020 14:01:25 +0000 (16:01 +0200)]
prepare upgrade instructions for 5.2 to 5.3
We need to provide `/lib/core.functions.php` and `/lib/system/api/*` before executing the complete file-PIP; otherwise we're getting issues with Guzzle being not found and causing an abortion.
Put the style and email-confirmation scripts into standalone-instructions since they might cause long execution times. In my test-environment I updated without that parameter.
Tim Düsterhus [Fri, 28 Aug 2020 14:11:01 +0000 (16:11 +0200)]
Merge pull request #3538 from mutec/53upgradeStyle
fix updating the styles to 5.3
mutec [Fri, 28 Aug 2020 13:46:54 +0000 (15:46 +0200)]
fix updating the styles to 5.3
If `Style::$imagePath` is empty, it resulted in copying the shole WSC-folder into a style-asset-folder - and doing this until we reache the timeout limits.
Including `global.php` ended up in trying to define the option-constants (especially the fixed-value-options like `MODULE_ATTACHMENTS`) again while they are already defined - which causes a Fatal Error-Message.
Alexander Ebert [Fri, 28 Aug 2020 13:27:09 +0000 (15:27 +0200)]
Release 5.2.9
Alexander Ebert [Fri, 28 Aug 2020 13:15:59 +0000 (15:15 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Fri, 28 Aug 2020 11:09:35 +0000 (13:09 +0200)]
Release 3.1.17
Alexander Ebert [Thu, 27 Aug 2020 17:56:38 +0000 (19:56 +0200)]
Merge pull request #3524 from WoltLab/package-server-refactor
Clean up package update server management
Tim Düsterhus [Thu, 27 Aug 2020 10:24:30 +0000 (12:24 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Thu, 27 Aug 2020 10:21:00 +0000 (12:21 +0200)]
Revert "Fix deprecation warnings in form builder in PHP 8"
This reverts commit
5ae5d6c5621c8fe1f30d6a2c787024b9bcadee87.
As commented on the original commit this change is not compatible with PHP
7.0 which is the lowest PHP version we support as of right now. Revert
this commit for now to not break compatibility with existing installations
of 5.2 until a proper solution for 5.3 and later is developed.
See #3489.
Alexander Ebert [Wed, 26 Aug 2020 17:05:45 +0000 (19:05 +0200)]
`http_build_query()` is now allowed for calls from within a template
joshuaruesweg [Wed, 26 Aug 2020 16:51:12 +0000 (18:51 +0200)]
Fix notifications with are triggered by merged users
Objects of merged users are rewritten to the new user. This is currently done but not by the notification authors. There the author is simply deleted from the notification. This works for most notifications, but not for reactions, because they always expect a concrete author (a guest cannot assign reactions). If users are deleted, it works as intended, since the corresponding reaction object is then also deleted.
Alexander Ebert [Wed, 26 Aug 2020 15:57:54 +0000 (17:57 +0200)]
Release 5.2.9
Marcel Werk [Wed, 26 Aug 2020 15:04:00 +0000 (17:04 +0200)]
Merge pull request #3531 from WoltLab/jslang-template-plugin
Template plugin for the assignment of language variables in javascrip…
Marcel Werk [Wed, 26 Aug 2020 15:03:46 +0000 (17:03 +0200)]
Added missing use of jslang
Marcel Werk [Wed, 26 Aug 2020 14:59:31 +0000 (16:59 +0200)]
Added missing use of jslang
Alexander Ebert [Wed, 26 Aug 2020 13:39:33 +0000 (15:39 +0200)]
Merge branch '5.2'
woltlab.com [Wed, 26 Aug 2020 13:37:07 +0000 (13:37 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 26 Aug 2020 13:34:52 +0000 (15:34 +0200)]
Merge branch '3.1' into 5.2
woltlab.com [Wed, 26 Aug 2020 13:29:47 +0000 (13:29 +0000)]
Updating minified JavaScript files
Marcel Werk [Mon, 24 Aug 2020 13:26:00 +0000 (15:26 +0200)]
Unified usage of the elseif tag in template scripting
Tim Düsterhus [Mon, 24 Aug 2020 09:54:19 +0000 (11:54 +0200)]
Fix selection of related articles for old MySQL versions
MySQL < 5.7 and apparently MariaDB up to at least 10.3 is unable to deduce
that there can only be exactly a single row from the `article` table, because
it is functionally dependent on `tag_to_object.objectID`.
Help them out by using `MAX` which effectively does nothing, because we're
taking the `MAX` of a single item.
Fixes #3528.
Tim Düsterhus [Mon, 24 Aug 2020 08:46:36 +0000 (10:46 +0200)]
Fix Guzzle following redirects with a custom temporary sink
When following redirects Guzzle copies over the request options for the next
iteration internally, including the bare `resource` that was passed to it.
This bare resource will then be wrapped into the Stream wrapper. This stream
wrapper explicitely calls `close()` for the underlying resource when it is
being closed.
The created Streams for the subrequests will be closed before the `send`
function returns, thus ultimately closing the resource for the “parent”
request.
Fix this issue by passing a Stream, instead of a bare resource. This one
will be passed along as-is.
Fixes #3529.
Marcel Werk [Sun, 23 Aug 2020 23:01:43 +0000 (01:01 +0200)]
Template plugin for the assignment of language variables in javascript code
Closes #3530
Alexander Ebert [Sat, 22 Aug 2020 21:05:23 +0000 (23:05 +0200)]
Improved the performance of reading tags without a specific language id
joshuaruesweg [Sat, 22 Aug 2020 14:31:49 +0000 (16:31 +0200)]
Merge branch '5.2'
joshuaruesweg [Sat, 22 Aug 2020 14:29:45 +0000 (16:29 +0200)]
Merge branch '3.1'
joshuaruesweg [Sat, 22 Aug 2020 14:26:44 +0000 (16:26 +0200)]
Remove fullscreen mode in template diff
The fullscreen mode does not have any advantage at this point because the diff is also displayed with a height of 700px (just like without fullscreen mode).
Alexander Ebert [Sat, 22 Aug 2020 13:37:01 +0000 (15:37 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 22 Aug 2020 13:36:25 +0000 (15:36 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Sat, 22 Aug 2020 13:35:42 +0000 (15:35 +0200)]
Improved visuals of the fullscreen template comparison
Fixes #3473
joshuaruesweg [Sat, 22 Aug 2020 12:22:50 +0000 (14:22 +0200)]
Merge branch '3.1' into 5.2
joshuaruesweg [Sat, 22 Aug 2020 12:22:21 +0000 (14:22 +0200)]
Fix trophy icon size in badges on groupedUserTrophyList
Alexander Ebert [Sat, 22 Aug 2020 11:11:32 +0000 (13:11 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 22 Aug 2020 11:11:15 +0000 (13:11 +0200)]
Duplicate `<br>` inserted on paste
Fixes #3454
Alexander Ebert [Sat, 22 Aug 2020 00:14:17 +0000 (02:14 +0200)]
Workaround for custom elements being chopped up by outdenting an empty `li`
Reproducible test case:
```
<woltlab-spoiler>
<ul>
<li>Test</li>
<li>T</li> <!-- Backspace this item -->
</ul>
</woltlab-spoiler>
```
Alexander Ebert [Fri, 21 Aug 2020 22:14:56 +0000 (00:14 +0200)]
Merge branch '5.2'
Alexander Ebert [Fri, 21 Aug 2020 22:14:40 +0000 (00:14 +0200)]
Workaround for Safari when removing the text formatting with a collapsed selection
Marcel Werk [Fri, 21 Aug 2020 15:44:43 +0000 (17:44 +0200)]
Merge branch '5.2'
Marcel Werk [Fri, 21 Aug 2020 15:44:30 +0000 (17:44 +0200)]
Merge branch '3.1' into 5.2
Marcel Werk [Fri, 21 Aug 2020 15:42:29 +0000 (17:42 +0200)]
Adjusted appearance of the "sign in with google" button
Alexander Ebert [Fri, 21 Aug 2020 11:43:37 +0000 (13:43 +0200)]
Merge branch '5.2'
Alexander Ebert [Fri, 21 Aug 2020 11:43:23 +0000 (13:43 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Fri, 21 Aug 2020 11:43:04 +0000 (13:43 +0200)]
Reopened dialogs were hidden behind new dialogs
Alexander Ebert [Fri, 21 Aug 2020 11:29:48 +0000 (13:29 +0200)]
Merge branch '5.2'
Alexander Ebert [Fri, 21 Aug 2020 11:24:46 +0000 (13:24 +0200)]
Incorrect blacklisting of `register_activation_method`
woltlab.com [Fri, 21 Aug 2020 09:26:59 +0000 (09:26 +0000)]
Updating minified JavaScript files
Alexander Ebert [Fri, 21 Aug 2020 09:25:00 +0000 (11:25 +0200)]
The implementation for JS bundles for other repositories was outdated
See #3520
Alexander Ebert [Thu, 20 Aug 2020 22:50:53 +0000 (00:50 +0200)]
Update the number of votes in a poll after voting
Alexander Ebert [Thu, 20 Aug 2020 22:28:41 +0000 (00:28 +0200)]
Merge branch '5.2'
Alexander Ebert [Thu, 20 Aug 2020 22:28:22 +0000 (00:28 +0200)]
Prevent the focus being trapped if the user intentionally clicks outside
Clicking on a link or button outside of the overlay caused the browser to close the drop-down and shift the focus on the menu element.
woltlab.com [Thu, 20 Aug 2020 16:18:22 +0000 (16:18 +0000)]
Updating minified JavaScript files
Alexander Ebert [Thu, 20 Aug 2020 16:13:45 +0000 (18:13 +0200)]
uglifyjs.minify expects the code and not a path
For whatever reason that this has worked in the past, in node 14+ the behavior appears to have been changed.
The `cascade` option is not mentioned in the list of valid options and since error message were implicitly suppressed, this went by unnoticed.
Fixes #3520
Tim Düsterhus [Thu, 20 Aug 2020 13:18:46 +0000 (15:18 +0200)]
Ensure that the official package servers exist
Tim Düsterhus [Thu, 20 Aug 2020 13:09:50 +0000 (15:09 +0200)]
Remove support for filtering the results of PackageUpdateServer::getActiveUpdateServers()
Tim Düsterhus [Thu, 20 Aug 2020 11:48:48 +0000 (13:48 +0200)]
Dynamically generate package update server path in PackageUpdateServer::handleData()
Tim Düsterhus [Thu, 20 Aug 2020 11:48:25 +0000 (13:48 +0200)]
Add `\wcf\getMinorVersion()`
Tim Düsterhus [Thu, 20 Aug 2020 10:35:02 +0000 (12:35 +0200)]
Add `since` PHPDoc for cleaned package update server management
Co-authored-by: Matthias Schmidt <gravatronics@live.com>
Alexander Ebert [Thu, 20 Aug 2020 09:52:57 +0000 (11:52 +0200)]
Merge branch '5.2'
Alexander Ebert [Thu, 20 Aug 2020 09:52:30 +0000 (11:52 +0200)]
Merge pull request #3525 from WoltLab/rich-metacode-in-quick-reply
Prevent rich metacode being dysfunctional in new messages
Alexander Ebert [Wed, 19 Aug 2020 22:50:46 +0000 (00:50 +0200)]
Merge branch '5.2'
Alexander Ebert [Wed, 19 Aug 2020 22:50:13 +0000 (00:50 +0200)]
Merge pull request #3523 from WoltLab/dropdown-scrollbar-large-tablets-fix
Fix the scrollbar for dropdowns on large tablets
Alexander Ebert [Wed, 19 Aug 2020 17:26:11 +0000 (19:26 +0200)]
Prevent rich metacode being dysfunctional in messages just created by replying
The `isset` strategy does not work properly, because in some cases the HTML is evaluated before being placed in the final template, causing the variable to be set already.
This changes modifies the behavior to always attempt to initialize the JavaScript, but made changes to ensure that each subsequent call is idempotent.
Matthias Schmidt [Wed, 19 Aug 2020 16:38:35 +0000 (18:38 +0200)]
Add missing word in exception message
See
709b412bf72084e48d408787d8455f9876fcdaed
Tim Düsterhus [Wed, 19 Aug 2020 15:02:54 +0000 (17:02 +0200)]
Use StringUtil::endsWith to validate package update server URL
Tim Düsterhus [Wed, 19 Aug 2020 14:55:17 +0000 (16:55 +0200)]
Use dedicated column for loginUsername in packageUpdateServerList
Tim Düsterhus [Wed, 19 Aug 2020 14:33:45 +0000 (16:33 +0200)]
Improve phrasing for cleaned package update server management
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Wed, 19 Aug 2020 12:56:00 +0000 (14:56 +0200)]
Add note to package.xml that obsolete update servers should be deleted
Tim Düsterhus [Wed, 19 Aug 2020 13:18:30 +0000 (15:18 +0200)]
Force a proper URL for *.woltlab.com package update servers
Tim Düsterhus [Wed, 19 Aug 2020 12:52:18 +0000 (14:52 +0200)]
Disallow deleting official update servers
Tim Düsterhus [Wed, 19 Aug 2020 14:16:19 +0000 (16:16 +0200)]
Prevent adding *.woltlab.com update servers
Tim Düsterhus [Wed, 19 Aug 2020 13:38:03 +0000 (15:38 +0200)]
Prevent adding duplicate package update servers
joshuaruesweg [Wed, 19 Aug 2020 13:32:27 +0000 (15:32 +0200)]
Fix the scrollbar for dropdowns on large tablets
Because tablets are not the platform "desktop", the scrollbar is not shown for tablets, even though they are rendered with desktop view.
Fixes #3522
Tim Düsterhus [Wed, 19 Aug 2020 12:44:11 +0000 (14:44 +0200)]
Disallow changing the package update server URL
Tim Düsterhus [Wed, 19 Aug 2020 13:02:18 +0000 (15:02 +0200)]
Do not echo loginPassword in packageUpdateUnauthorized.tpl
Tim Düsterhus [Wed, 19 Aug 2020 12:39:22 +0000 (14:39 +0200)]
Do not echo loginPassword in PackageUpdateServerEditForm
Tim Düsterhus [Wed, 19 Aug 2020 12:55:00 +0000 (14:55 +0200)]
Show loginUsername in packageUpdateServerList
This allows the administrator to quickly see which update servers are missing
credentials.
Alexander Ebert [Wed, 19 Aug 2020 08:41:18 +0000 (10:41 +0200)]
Merge branch '5.2'
Alexander Ebert [Wed, 19 Aug 2020 08:40:47 +0000 (10:40 +0200)]
Disable the search for updates buttons while active
Alexander Ebert [Wed, 19 Aug 2020 08:00:20 +0000 (10:00 +0200)]
Merge pull request #3519 from WoltLab/reactions-smartphone-optimization
Overflow handling for reaction popovers on smartphones
Alexander Ebert [Wed, 19 Aug 2020 08:00:02 +0000 (10:00 +0200)]
Reset the scroll position for popovers aligned to the bottom
Tim Düsterhus [Wed, 19 Aug 2020 07:51:42 +0000 (09:51 +0200)]
Merge branch '5.2' into master
Marcel Werk [Tue, 18 Aug 2020 18:22:33 +0000 (20:22 +0200)]
Merge pull request #3514 from WoltLab/form-link-to-created-item
Forms: Provide a link to edit an item that was just created
Marcel Werk [Tue, 18 Aug 2020 18:21:51 +0000 (20:21 +0200)]
Changed appearance of the edit link
Alexander Ebert [Tue, 18 Aug 2020 18:12:35 +0000 (20:12 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Tue, 18 Aug 2020 17:54:44 +0000 (19:54 +0200)]
Use of explicit font weight `600` instead of `bold`
Matthias Schmidt [Tue, 18 Aug 2020 17:35:29 +0000 (19:35 +0200)]
Toggling preview button is only possible before building form
See #3513
Joshua Rüsweg [Tue, 18 Aug 2020 17:22:02 +0000 (19:22 +0200)]
Merge pull request #3521 from Krymonota/patch-13
Remove redundant `implements IWorker`
Niklas [Tue, 18 Aug 2020 17:14:12 +0000 (19:14 +0200)]
Remove redundant `implements IWorker`
Alexander Ebert [Tue, 18 Aug 2020 15:57:10 +0000 (17:57 +0200)]
Incorrect scroll position and reaction order