GitHub/WoltLab/WCF.git
4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 16:32:58 +0000 (17:32 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 18 Nov 2020 16:32:41 +0000 (17:32 +0100)]
Merge branch '3.1' into 5.2

4 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:32:21 +0000 (17:32 +0100)]
Fix ACL buttons when editing media files successively

Replaces 3a7740a3704339c79d08fd2f5094fa1a1973318b by backporting and using parts of 6ee58cd2865980cd7fa16a1f3ebc660131fc7fd6.

4 years agoRevert "Fix ACL buttons when editing media files successively"
Matthias Schmidt [Wed, 18 Nov 2020 16:26:26 +0000 (17:26 +0100)]
Revert "Fix ACL buttons when editing media files successively"

This reverts commit 3a7740a3704339c79d08fd2f5094fa1a1973318b.

4 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:24:30 +0000 (17:24 +0100)]
Fix ACL buttons when editing media files successively

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 15:28:34 +0000 (16:28 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix file icon update after upload on media list page
Matthias Schmidt [Wed, 18 Nov 2020 15:28:18 +0000 (16:28 +0100)]
Fix file icon update after upload on media list page

4 years agoMerge pull request #3727 from WoltLab/favicon-template-typo
Tim Düsterhus [Wed, 18 Nov 2020 08:22:32 +0000 (09:22 +0100)]
Merge pull request #3727 from WoltLab/favicon-template-typo

Fix typo in favicon template filename

4 years agoUpdating minified JavaScript files
WoltLab [Tue, 17 Nov 2020 14:56:24 +0000 (14:56 +0000)]
Updating minified JavaScript files

4 years agoFix typo in favicon template filename
Tim Düsterhus [Tue, 17 Nov 2020 14:25:44 +0000 (15:25 +0100)]
Fix typo in favicon template filename

5.2 used `favicon-template.ext` instead of `favicon.template.ext`.

4 years agoForce the synchronization of the `codeMetaCode` template
Alexander Ebert [Tue, 17 Nov 2020 14:25:36 +0000 (15:25 +0100)]
Force the synchronization of the `codeMetaCode` template

4 years agoPlace the `@charset` at the very beginning of the generated CSS (#3726)
Alexander Ebert [Tue, 17 Nov 2020 14:17:49 +0000 (15:17 +0100)]
Place the `@charset` at the very beginning of the generated CSS (#3726)

* Place the `@charset` at the very beginning of the generated CSS

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
4 years agoFix wrong user disable/enable label in user profile
joshuaruesweg [Tue, 17 Nov 2020 13:51:28 +0000 (14:51 +0100)]
Fix wrong user disable/enable label in user profile

4 years agoMerge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath
Tim Düsterhus [Tue, 17 Nov 2020 11:30:12 +0000 (12:30 +0100)]
Merge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath

Verify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 17 Nov 2020 11:10:59 +0000 (12:10 +0100)]
Merge branch '5.2' into 5.3

4 years agoEncode HTML special chars in form builder's action
Tim Düsterhus [Tue, 17 Nov 2020 11:10:32 +0000 (12:10 +0100)]
Encode HTML special chars in form builder's action

4 years agoVerify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php
Tim Düsterhus [Tue, 17 Nov 2020 09:13:42 +0000 (10:13 +0100)]
Verify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php

4 years agoAdded style.xsd
Marcel Werk [Mon, 16 Nov 2020 17:07:14 +0000 (18:07 +0100)]
Added style.xsd

4 years agoForce a sane value for `REGISTER_ACTIVATION_METHOD`
Alexander Ebert [Fri, 13 Nov 2020 12:33:17 +0000 (13:33 +0100)]
Force a sane value for `REGISTER_ACTIVATION_METHOD`

Fixes #3723

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Thu, 12 Nov 2020 18:16:06 +0000 (19:16 +0100)]
Merge branch '5.2' into 5.3

4 years agoWorkaround for nested paragraphs after pasting in Firefox
Alexander Ebert [Thu, 12 Nov 2020 18:04:01 +0000 (19:04 +0100)]
Workaround for nested paragraphs after pasting in Firefox

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Thu, 12 Nov 2020 16:30:40 +0000 (17:30 +0100)]
Merge branch '5.2' into 5.3

4 years agoDisallow changing time support after setting value in `DateFormField`
Matthias Schmidt [Thu, 12 Nov 2020 16:30:28 +0000 (17:30 +0100)]
Disallow changing time support after setting value in `DateFormField`

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Thu, 12 Nov 2020 15:08:04 +0000 (16:08 +0100)]
Merge branch '5.2' into 5.3

4 years agoDelete FK logs after removing FKs due to column removal
Matthias Schmidt [Thu, 12 Nov 2020 15:07:33 +0000 (16:07 +0100)]
Delete FK logs after removing FKs due to column removal

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 12 Nov 2020 08:56:26 +0000 (09:56 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Thu, 12 Nov 2020 08:56:12 +0000 (09:56 +0100)]
Merge branch '3.1' into 5.2

4 years agoActually delete the external_link_rel_nofollow option
Tim Düsterhus [Thu, 12 Nov 2020 08:54:12 +0000 (09:54 +0100)]
Actually delete the external_link_rel_nofollow option

see 533948aa618e967d39449b1ba2f810d9477c719d

4 years agoFix BBCodeHandler::setDisallowedBBCodes(...) PHPDoc (#3722)
Niklas [Thu, 12 Nov 2020 08:16:32 +0000 (09:16 +0100)]
Fix BBCodeHandler::setDisallowedBBCodes(...) PHPDoc (#3722)

4 years agoFix typo in de.xml
Felix | D1strict [Wed, 11 Nov 2020 20:35:39 +0000 (21:35 +0100)]
Fix typo in de.xml

See https://community.woltlab.com/thread/286689-sprachvariable-im-acp-von-option-inhalte-von-externen-anbietern/

Closes #3721

4 years agoUpdate packageSearchResultList.tpl
Sascha Moser [Wed, 11 Nov 2020 18:24:30 +0000 (19:24 +0100)]
Update packageSearchResultList.tpl

Should fix https://community.woltlab.com/thread/286683-paketsuche-zeigt-falschen-string/

Closes #3718
Closes #3719

4 years agoMerge pull request #3685 from WoltLab/jslang 5.3.0
Alexander Ebert [Tue, 10 Nov 2020 13:06:52 +0000 (14:06 +0100)]
Merge pull request #3685 from WoltLab/jslang

Use `jslang` in more places

4 years agoRelease 5.3.0
Alexander Ebert [Mon, 9 Nov 2020 15:19:30 +0000 (16:19 +0100)]
Release 5.3.0

4 years agoUpdating minified JavaScript files
WoltLab [Mon, 9 Nov 2020 15:16:18 +0000 (15:16 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 9 Nov 2020 13:08:28 +0000 (14:08 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix deleting obsolete nodes in form builder dependeny manager
Matthias Schmidt [Mon, 9 Nov 2020 13:08:14 +0000 (14:08 +0100)]
Fix deleting obsolete nodes in form builder dependeny manager

4 years agoUpdating minified JavaScript files
WoltLab [Mon, 9 Nov 2020 12:41:51 +0000 (12:41 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sun, 8 Nov 2020 18:19:49 +0000 (19:19 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 8 Nov 2020 18:19:34 +0000 (19:19 +0100)]
Merge branch '3.1' into 5.2

4 years agoObsolete exclusion of the old ACP catpcha
Alexander Ebert [Sun, 8 Nov 2020 18:19:17 +0000 (19:19 +0100)]
Obsolete exclusion of the old ACP catpcha

This route does not exist anymore since WoltLab Suite 3.0.

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sat, 7 Nov 2020 09:15:35 +0000 (10:15 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix deleting obsolete nodes in form builder dependeny manager
Matthias Schmidt [Sat, 7 Nov 2020 09:15:20 +0000 (10:15 +0100)]
Fix deleting obsolete nodes in form builder dependeny manager

4 years agoMerge branch '5.2' into 5.3
Marcel Werk [Thu, 5 Nov 2020 22:05:51 +0000 (23:05 +0100)]
Merge branch '5.2' into 5.3

4 years agoUse native click event if available
Marcel Werk [Thu, 5 Nov 2020 22:05:15 +0000 (23:05 +0100)]
Use native click event if available

4 years agoReplaced <b> tags with <strong>
Marcel Werk [Thu, 5 Nov 2020 17:21:09 +0000 (18:21 +0100)]
Replaced <b> tags with <strong>

4 years agoMerge branch '5.2' into 5.3
Marcel Werk [Tue, 3 Nov 2020 18:42:06 +0000 (19:42 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Tue, 3 Nov 2020 18:41:50 +0000 (19:41 +0100)]
Merge branch '3.1' into 5.2

4 years agoBlock search keyword list if permissions for the search function are denied
Marcel Werk [Tue, 3 Nov 2020 18:41:31 +0000 (19:41 +0100)]
Block search keyword list if permissions for the search function are denied

Closes #3681

4 years agoMerge pull request #3691 from WoltLab/bump-scss
Alexander Ebert [Tue, 3 Nov 2020 16:24:39 +0000 (17:24 +0100)]
Merge pull request #3691 from WoltLab/bump-scss

Update to scssphp/scssphp 1.3

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 3 Nov 2020 14:50:57 +0000 (15:50 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix `Ui/Poll/Editor._reset()`
Matthias Schmidt [Tue, 3 Nov 2020 14:50:45 +0000 (15:50 +0100)]
Fix `Ui/Poll/Editor._reset()`

4 years agoUpdate to scssphp/scssphp 1.3
Tim Düsterhus [Tue, 3 Nov 2020 14:44:50 +0000 (15:44 +0100)]
Update to scssphp/scssphp 1.3

4 years agoFix de.xml
Tim Düsterhus [Tue, 3 Nov 2020 13:30:18 +0000 (14:30 +0100)]
Fix de.xml

This fixes up commit 70746ece9789d3b2256495a788ae4875d01e95bc.

4 years agoFix typo in de.xml
Tim Düsterhus [Tue, 3 Nov 2020 13:26:13 +0000 (14:26 +0100)]
Fix typo in de.xml

4 years agoOutdated phrase refering to a specific package server
Alexander Ebert [Tue, 3 Nov 2020 12:34:54 +0000 (13:34 +0100)]
Outdated phrase refering to a specific package server

4 years agoBump the head.js timeout from 7s to 60s
Alexander Ebert [Tue, 3 Nov 2020 12:27:00 +0000 (13:27 +0100)]
Bump the head.js timeout from 7s to 60s

head.js will fire the ready event even when the script is still loading, causing the callback to be invoked on slow 3G networks before the script arrived.

See https://github.com/headjs/headjs/issues/330

4 years agoMerge pull request #3667 from Krymonota/patch-16
Alexander Ebert [Tue, 3 Nov 2020 10:47:42 +0000 (11:47 +0100)]
Merge pull request #3667 from Krymonota/patch-16

Update version number to 5.3 in README.md

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 3 Nov 2020 10:14:50 +0000 (11:14 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix polls in AJAX form builder forms
Matthias Schmidt [Tue, 3 Nov 2020 10:14:08 +0000 (11:14 +0100)]
Fix polls in AJAX form builder forms

4 years agoAdd data and options getters in poll editor js module
Matthias Schmidt [Tue, 3 Nov 2020 10:13:14 +0000 (11:13 +0100)]
Add data and options getters in poll editor js module

4 years agoFire event if field is registered in form builder manager
Matthias Schmidt [Tue, 3 Nov 2020 10:12:30 +0000 (11:12 +0100)]
Fire event if field is registered in form builder manager

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 2 Nov 2020 17:56:18 +0000 (18:56 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Mon, 2 Nov 2020 17:56:03 +0000 (18:56 +0100)]
Merge branch '3.1' into 5.2

4 years agoFix GDPR export if invalid user id is given
Matthias Schmidt [Mon, 2 Nov 2020 17:55:46 +0000 (18:55 +0100)]
Fix GDPR export if invalid user id is given

… and stop using deprecated method `UserProfile::getUserProfile()`.

4 years agoUse `jslang` in more places
Matthias Schmidt [Mon, 2 Nov 2020 16:40:23 +0000 (17:40 +0100)]
Use `jslang` in more places

See #3530

4 years agoSupport moderation filters if no outstanding entries exist
Matthias Schmidt [Mon, 2 Nov 2020 15:40:35 +0000 (16:40 +0100)]
Support moderation filters if no outstanding entries exist

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 2 Nov 2020 09:40:56 +0000 (10:40 +0100)]
Merge branch '5.2' into 5.3

4 years agoWhitelist `version_compare` in enterprise mode
Tim Düsterhus [Mon, 2 Nov 2020 09:40:18 +0000 (10:40 +0100)]
Whitelist `version_compare` in enterprise mode

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 30 Oct 2020 11:47:08 +0000 (12:47 +0100)]
Merge branch '5.2' into 5.3

4 years agoExpired session during 3rd party auth led to a SystemException
Marcel Werk [Mon, 14 Sep 2020 12:31:34 +0000 (14:31 +0200)]
Expired session during 3rd party auth led to a SystemException

(cherry picked from commit da8b0e89fa9da82fc7965955e7c0639a65d6ac00)

4 years agoExpired session during google auth led to a SystemException
Marcel Werk [Mon, 14 Sep 2020 11:51:37 +0000 (13:51 +0200)]
Expired session during google auth led to a SystemException

(cherry picked from commit 740ece8da10177354ab904f9aeb6ea914741c025)

4 years agoUpdate version number to 5.3 in README.md
Niklas [Thu, 29 Oct 2020 21:36:14 +0000 (22:36 +0100)]
Update version number to 5.3 in README.md

4 years agoMerge pull request #3663 from WoltLab/image-proxy-guzzle
Tim Düsterhus [Thu, 29 Oct 2020 14:12:35 +0000 (15:12 +0100)]
Merge pull request #3663 from WoltLab/image-proxy-guzzle

Use Guzzle directly in ImageProxyAction

4 years agoUse Guzzle directly in ImageProxyAction
Tim Düsterhus [Thu, 29 Oct 2020 09:22:51 +0000 (10:22 +0100)]
Use Guzzle directly in ImageProxyAction

This makes the Exception handling much cleaner.

Fixes #3660

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 28 Oct 2020 16:21:43 +0000 (17:21 +0100)]
Merge branch '5.2' into 5.3

4 years agoRemove obsolete TODO
Matthias Schmidt [Wed, 28 Oct 2020 16:21:28 +0000 (17:21 +0100)]
Remove obsolete TODO

4 years agoRemove obsolete TODO
Matthias Schmidt [Wed, 28 Oct 2020 16:02:17 +0000 (17:02 +0100)]
Remove obsolete TODO

4 years agoMerge branch '5.3' of github.com:WoltLab/WCF into 5.3
Matthias Schmidt [Wed, 28 Oct 2020 13:02:11 +0000 (14:02 +0100)]
Merge branch '5.3' of github.com:WoltLab/WCF into 5.3

4 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 28 Oct 2020 13:02:05 +0000 (14:02 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix reading medias' `captionEnableHtml`
Matthias Schmidt [Wed, 28 Oct 2020 13:01:48 +0000 (14:01 +0100)]
Fix reading medias' `captionEnableHtml`

See a1b75f8b9b9d6137434945bb8bea9518eddb48d3

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 28 Oct 2020 13:01:12 +0000 (14:01 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 28 Oct 2020 08:48:09 +0000 (09:48 +0100)]
Merge branch '3.1' into 5.2

4 years agoFix class name in UserRegistrationUtil::__construct() PHPDoc (#3652)
Niklas [Wed, 28 Oct 2020 08:46:10 +0000 (09:46 +0100)]
Fix class name in UserRegistrationUtil::__construct() PHPDoc (#3652)

4 years agoRelease 5.3.0 RC 3 5.3.0_RC_3
Alexander Ebert [Tue, 27 Oct 2020 18:10:35 +0000 (19:10 +0100)]
Release 5.3.0 RC 3

4 years agoHide empty table after deleting last missing language item on page
Matthias Schmidt [Tue, 27 Oct 2020 17:06:36 +0000 (18:06 +0100)]
Hide empty table after deleting last missing language item on page

4 years agoRemove obsolete references to `missingLanguageItems.txt`
Matthias Schmidt [Tue, 27 Oct 2020 17:02:15 +0000 (18:02 +0100)]
Remove obsolete references to `missingLanguageItems.txt`

4 years agoFix possible "Invalid parameter number" error in UserStorageHandler
Tim Düsterhus [Tue, 27 Oct 2020 10:46:55 +0000 (11:46 +0100)]
Fix possible "Invalid parameter number" error in UserStorageHandler

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 26 Oct 2020 16:31:20 +0000 (17:31 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge pull request #3648 from WoltLab/actions
Tim Düsterhus [Mon, 26 Oct 2020 16:31:08 +0000 (17:31 +0100)]
Merge pull request #3648 from WoltLab/actions

Refactor Workflows

4 years agoAdd javascript workflow
Tim Düsterhus [Mon, 26 Oct 2020 15:53:33 +0000 (16:53 +0100)]
Add javascript workflow

4 years agoRename php-syntax workflow to php
Tim Düsterhus [Mon, 26 Oct 2020 15:53:17 +0000 (16:53 +0100)]
Rename php-syntax workflow to php

4 years agoAdjust human readable name for CodeSniffer check
Tim Düsterhus [Mon, 26 Oct 2020 16:02:03 +0000 (17:02 +0100)]
Adjust human readable name for CodeSniffer check

4 years agoMerge pull request #3646 from WoltLab/user-storage-refactor
Alexander Ebert [Mon, 26 Oct 2020 14:48:46 +0000 (15:48 +0100)]
Merge pull request #3646 from WoltLab/user-storage-refactor

Clean up user storage update logic

4 years agoClean up user storage update logic
Tim Düsterhus [Fri, 23 Oct 2020 10:33:15 +0000 (12:33 +0200)]
Clean up user storage update logic

This commit attempts to reduce the lock contention during user storage
shutdown. The user storage is a constant source of deadlocks and the update
logic grew increasingly ugly over the years in attempts to fix this.

While the previous situation was acceptable in that errors did not surface due
to the automated retries it still trashed any useful information within `SHOW
ENGINE InnoDB STATUS`, making debugging other deadlocks unnecessarily hard.

The new updating logic uses a single `log` array, indexed by user and field.
`null` values indicate a reset, non-`null` values are an update.

When shutting the user storage down the database will be updated with one
transaction per user, ensuring a consistent view for that user. In most
requests it is expected that only a single user (the current one) is being
updated anyway. Before actually performing the updates the row in wcf1_user for
that user is locked using a SELECT FOR UPDATE query. This should cause
concurrent requests to wait at the `SELECT`, which hopefully stops them from
obtaining any locks that the later DELETE / INSERT will need.

Just locking the `wcf1_user_storage` will not work as the lock cannot be
grabbed atomically. Instead MySQL locks all the matching rows one-by-one.
Locking the user is not ideal, but the update of the user storage should happen
pretty quickly which makes it acceptable.

4 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Sat, 24 Oct 2020 13:52:10 +0000 (15:52 +0200)]
Merge branch '5.2' into 5.3

4 years agoMerge pull request #3644 from Krymonota/patch-14
Joshua Rüsweg [Sat, 24 Oct 2020 13:28:59 +0000 (15:28 +0200)]
Merge pull request #3644 from Krymonota/patch-14

Add like support check to comment responses

4 years agoAdd like support check to comment responses
Niklas [Sat, 24 Oct 2020 12:12:15 +0000 (14:12 +0200)]
Add like support check to comment responses

If the provided comment manager doesn't support likes, it's not possible to like comments, as can be seen here:

- https://github.com/WoltLab/WCF/blob/6747fe291c584d7c8295912f8d94297588d142b2/com.woltlab.wcf/templates/commentList.tpl#L59
- https://github.com/WoltLab/WCF/blob/6747fe291c584d7c8295912f8d94297588d142b2/com.woltlab.wcf/templates/commentList.tpl#L59

However, it's never checked for comment responses whether the comment manager supports likes. This results in the like button being displayed for comment responses, even though likes aren't supported.

4 years agoRelease 5.3.0 RC 3
Alexander Ebert [Fri, 23 Oct 2020 15:11:49 +0000 (17:11 +0200)]
Release 5.3.0 RC 3

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 23 Oct 2020 12:48:41 +0000 (14:48 +0200)]
Merge branch '5.2' into 5.3

4 years agoMerge pull request #3612 from WoltLab/csrf-token-template-backport
Tim Düsterhus [Fri, 23 Oct 2020 12:47:06 +0000 (14:47 +0200)]
Merge pull request #3612 from WoltLab/csrf-token-template-backport

Backport CsrfTokenFunctionTemplatePlugin