GitHub/WoltLab/WCF.git
3 years agoMerge pull request #4130 from WoltLab/actions-php-cs-fixer-ext
Tim Düsterhus [Mon, 19 Apr 2021 12:48:18 +0000 (14:48 +0200)]
Merge pull request #4130 from WoltLab/actions-php-cs-fixer-ext

Set-up php-cs-fixer using setup-php in codestyle workflow

3 years agoSet-up php-cs-fixer using setup-php in codestyle workflow
Tim Düsterhus [Mon, 19 Apr 2021 12:13:48 +0000 (14:13 +0200)]
Set-up php-cs-fixer using setup-php in codestyle workflow

This allows us to easily install extensions.

3 years agoAdd dialog with anonymous/personalized links for RSS feeds (#4123)
Matthias Schmidt [Mon, 19 Apr 2021 12:34:32 +0000 (14:34 +0200)]
Add dialog with anonymous/personalized links for RSS feeds (#4123)

Close #3661

3 years agoMerge branch '5.3'
Tim Düsterhus [Mon, 19 Apr 2021 11:48:08 +0000 (13:48 +0200)]
Merge branch '5.3'

3 years agoMerge pull request #4127 from WoltLab/fix-user-storage-handler
Tim Düsterhus [Mon, 19 Apr 2021 11:45:19 +0000 (13:45 +0200)]
Merge pull request #4127 from WoltLab/fix-user-storage-handler

Fix requesting multiple times the UserStorage tables if no cache exists

3 years agoDo not update `confirmTime` for read notifications (#4129)
Tim Düsterhus [Mon, 19 Apr 2021 11:42:34 +0000 (13:42 +0200)]
Do not update `confirmTime` for read notifications (#4129)

Co-authored-by: Matthias Schmidt <gravatronics@live.com>
3 years agoFix requesting multiple times the UserStorage tables if no cache exists
joshuaruesweg [Fri, 16 Apr 2021 10:38:56 +0000 (12:38 +0200)]
Fix requesting multiple times the UserStorage tables if no cache exists

3 years agoFix update script to delete language items
Matthias Schmidt [Sat, 17 Apr 2021 15:12:06 +0000 (17:12 +0200)]
Fix update script to delete language items

3 years agoSupport enabling/disabling `Ui/ItemList/LineBreakSeparatedText`
Matthias Schmidt [Sat, 17 Apr 2021 15:08:01 +0000 (17:08 +0200)]
Support enabling/disabling `Ui/ItemList/LineBreakSeparatedText`

… to support enabling/disabling user group options.

3 years agoAdd and use `LineBreakSeparatedTextUserGroupOptionType` (#4128)
Matthias Schmidt [Sat, 17 Apr 2021 14:21:29 +0000 (16:21 +0200)]
Add and use `LineBreakSeparatedTextUserGroupOptionType` (#4128)

The internal implementation of `LineBreakSeparatedTextOptionType` and `Ui/ItemList/LineBreakSeparatedText` required minor adjustments for the list to have unique ids and for the input element to be part of the template so that the user group option type works on `UserGroupOptionForm`.

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sat, 17 Apr 2021 10:02:09 +0000 (12:02 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sat, 17 Apr 2021 10:00:17 +0000 (12:00 +0200)]
Merge branch '3.1' into 5.2

3 years agoUpdate the number of responses that will be loaded
Alexander Ebert [Sat, 17 Apr 2021 10:00:01 +0000 (12:00 +0200)]
Update the number of responses that will be loaded

3 years agoAdd option type for with line break-separated items (#4126)
Matthias Schmidt [Fri, 16 Apr 2021 17:11:43 +0000 (19:11 +0200)]
Add option type for with line break-separated items (#4126)

* Add option type for with line break-separated items

Close #4041

* Apply suggestions from code review

* Use consistent sorting between PHP and JavaScript

* Apply suggestions from code review

3 years agoMerge branch '5.3'
Matthias Schmidt [Fri, 16 Apr 2021 16:50:39 +0000 (18:50 +0200)]
Merge branch '5.3'

3 years agoRelease 5.3.7 5.3.7
Alexander Ebert [Fri, 16 Apr 2021 14:15:00 +0000 (16:15 +0200)]
Release 5.3.7

3 years agoFix missing space in user registration email confirm mails
joshuaruesweg [Fri, 16 Apr 2021 12:53:29 +0000 (14:53 +0200)]
Fix missing space in user registration email confirm mails

3 years agoFix newline handling in user registration notification mails
joshuaruesweg [Fri, 16 Apr 2021 12:52:05 +0000 (14:52 +0200)]
Fix newline handling in user registration notification mails

3 years agoMerge branch 'xopez-patch-1'
joshuaruesweg [Fri, 16 Apr 2021 11:27:09 +0000 (13:27 +0200)]
Merge branch 'xopez-patch-1'

3 years agoAdd qwant to spiderList.xml
Sascha Moser [Thu, 15 Apr 2021 22:38:12 +0000 (00:38 +0200)]
Add qwant to spiderList.xml

Possible User-Agents:
```Mozilla/5.0 (compatible; Qwantify/2.4w; +https://www.qwant.com/)
Mozilla/5.0 (compatible; Qwant-news/2.0; +https://www.qwant.com/)
Mozilla/5.0 (compatible; Qwantify/Bleriot/1.1; +https://help.qwant.com/bot)```

3 years agoAdd Serpstabot to spiderList.xml
Sascha Moser [Wed, 14 Apr 2021 13:34:36 +0000 (15:34 +0200)]
Add Serpstabot to spiderList.xml

User-Agent: `serpstatbot/1.0 (advanced backlink tracking bot; curl/7.58.0; http://serpstatbot.com/; abuse@serpstatbot.com)`

3 years agoAdd SEOkicks to spiderList.xml
Sascha Moser [Tue, 13 Apr 2021 22:04:54 +0000 (00:04 +0200)]
Add SEOkicks to spiderList.xml

User-Agent: `Mozilla/5.0 (compatible; SEOkicks; +https://www.seokicks.de/robot.html)`

3 years agoAdd `ClipboardHandler::isMarked()` (#4124)
Matthias Schmidt [Thu, 15 Apr 2021 13:19:41 +0000 (15:19 +0200)]
Add `ClipboardHandler::isMarked()` (#4124)

See WoltLab/com.woltlab.wbb#454

3 years agoMerge branch '5.3'
Matthias Schmidt [Thu, 15 Apr 2021 12:39:47 +0000 (14:39 +0200)]
Merge branch '5.3'

3 years agoFix `UserNotification::markAllAsConfirmed()` for no unconfirmed notifications
Matthias Schmidt [Thu, 15 Apr 2021 12:33:16 +0000 (14:33 +0200)]
Fix `UserNotification::markAllAsConfirmed()` for no unconfirmed notifications

See 81982c717bbb55c36306ede938dc189f01f85592

3 years agoInclude compiled template code in exception logs (#4122)
Matthias Schmidt [Thu, 15 Apr 2021 12:19:22 +0000 (14:19 +0200)]
Include compiled template code in exception logs (#4122)

* Include compiled template code in exception logs

Close #3943

* Highlight error line in exceptions' template context

* Replace `break` with `return` in `getTemplateContextLines()`

3 years agoFix clearing of obsolete clipboard buttons
Matthias Schmidt [Thu, 15 Apr 2021 08:02:24 +0000 (10:02 +0200)]
Fix clearing of obsolete clipboard buttons

3 years agoUpdating minified JavaScript files
WoltLab [Thu, 15 Apr 2021 07:11:56 +0000 (07:11 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.3'
Matthias Schmidt [Thu, 15 Apr 2021 05:23:59 +0000 (07:23 +0200)]
Merge branch '5.3'

3 years agoMerge pull request #4117 from WoltLab/lazy-uploadformfield-registration
Joshua Rüsweg [Wed, 14 Apr 2021 20:13:41 +0000 (22:13 +0200)]
Merge pull request #4117 from WoltLab/lazy-uploadformfield-registration

Add lazy UploadFormField registration

3 years agoFix grammar in phpDoc comment
Joshua Rüsweg [Wed, 14 Apr 2021 20:05:14 +0000 (22:05 +0200)]
Fix grammar in phpDoc comment

Co-authored-by: Matthias Schmidt <gravatronics@live.com>
3 years agoMerge branch '5.3' of https://github.com/WoltLab/WCF into 5.3 5.3.6
Alexander Ebert [Wed, 14 Apr 2021 12:12:00 +0000 (14:12 +0200)]
Merge branch '5.3' of https://github.com/WoltLab/WCF into 5.3

3 years agoRelease 5.3.6
Alexander Ebert [Wed, 14 Apr 2021 12:10:01 +0000 (14:10 +0200)]
Release 5.3.6

3 years agoRelease 5.3.14
Alexander Ebert [Wed, 14 Apr 2021 12:10:01 +0000 (14:10 +0200)]
Release 5.3.14

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 14 Apr 2021 12:06:16 +0000 (14:06 +0200)]
Merge branch '5.2' into 5.3

3 years agoAdd clipboard support for moderation (#4121)
Matthias Schmidt [Wed, 14 Apr 2021 12:02:33 +0000 (14:02 +0200)]
Add clipboard support for moderation (#4121)

* Add clipboard support for moderation

Close  #3774

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
* Use `defaultChecked` property in `Ui/Moderation/Clipboard/AssignUser`

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoUpdating minified JavaScript files
WoltLab [Wed, 14 Apr 2021 12:01:06 +0000 (12:01 +0000)]
Updating minified JavaScript files

3 years agoRelease 5.2.14 5.2.14
Alexander Ebert [Wed, 14 Apr 2021 11:39:31 +0000 (13:39 +0200)]
Release 5.2.14

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 14 Apr 2021 11:36:56 +0000 (13:36 +0200)]
Merge branch '3.1' into 5.2

3 years agoRelease 3.1.22 3.1.22
Alexander Ebert [Wed, 14 Apr 2021 11:20:59 +0000 (13:20 +0200)]
Release 3.1.22

3 years agoAdd missing permissions check when removing moderated content
Matthias Schmidt [Tue, 13 Apr 2021 11:13:38 +0000 (13:13 +0200)]
Add missing permissions check when removing moderated content

3 years agoImproved visuals for code boxes on small screens
Alexander Ebert [Wed, 14 Apr 2021 08:57:36 +0000 (10:57 +0200)]
Improved visuals for code boxes on small screens

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 14 Apr 2021 08:23:01 +0000 (10:23 +0200)]
Merge branch '5.3'

3 years agoOnly show top add button on empty captcha question list page
Matthias Schmidt [Wed, 14 Apr 2021 08:21:14 +0000 (10:21 +0200)]
Only show top add button on empty captcha question list page

Close #4072

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 14 Apr 2021 05:42:21 +0000 (07:42 +0200)]
Merge branch '5.3'

3 years agoMerge pull request #4102 from WoltLab/devtools_open_archive
Matthias Schmidt [Wed, 14 Apr 2021 05:38:54 +0000 (07:38 +0200)]
Merge pull request #4102 from WoltLab/devtools_open_archive

Open archive in `DevtoolsPackageArchive` only once

3 years agoOnly create one `DevtoolsPackageArchive` object in `DevtoolsProject`
Matthias Schmidt [Tue, 13 Apr 2021 15:06:56 +0000 (17:06 +0200)]
Only create one `DevtoolsPackageArchive` object in `DevtoolsProject`

3 years agoCorrectly handle a missing .htaccess in the tmp/ folder
Tim Düsterhus [Tue, 13 Apr 2021 14:59:42 +0000 (16:59 +0200)]
Correctly handle a missing .htaccess in the tmp/ folder

see be81c8401ba16bd1f84fe95f8ca71c372cf548ec

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 13 Apr 2021 14:41:02 +0000 (16:41 +0200)]
Merge branch '5.3'

3 years agoMerge pull request #4118 from WoltLab/db_fk_future_tables
Matthias Schmidt [Tue, 13 Apr 2021 14:36:24 +0000 (16:36 +0200)]
Merge pull request #4118 from WoltLab/db_fk_future_tables

Properly handle foreign keys referencing tables created later on

3 years agoProperly handle foreign keys referencing tables created later on
Matthias Schmidt [Tue, 13 Apr 2021 14:21:54 +0000 (16:21 +0200)]
Properly handle foreign keys referencing tables created later on

If a foreign key of the first table references a table to be created later on, this foreign key can only be created once the referenced table was created.

3 years agoFix wcf1_tag_to_object migration
Tim Düsterhus [Tue, 13 Apr 2021 14:20:01 +0000 (16:20 +0200)]
Fix wcf1_tag_to_object migration

see 04e8818d46204033b00607a15d9ac1a37b5ef372

3 years agoCheck if foreign key references unknown database table
Matthias Schmidt [Tue, 13 Apr 2021 14:01:45 +0000 (16:01 +0200)]
Check if foreign key references unknown database table

3 years agoMake registerField() protected to allow using them in child classes
joshuaruesweg [Tue, 13 Apr 2021 13:15:48 +0000 (15:15 +0200)]
Make registerField() protected to allow using them in child classes

3 years agoRemove unused isRegistered method
joshuaruesweg [Tue, 13 Apr 2021 13:04:20 +0000 (15:04 +0200)]
Remove unused isRegistered method

3 years agoAdd lazy UploadFormField registration
joshuaruesweg [Tue, 13 Apr 2021 12:51:59 +0000 (14:51 +0200)]
Add lazy UploadFormField registration

If request data is to be transferred to the form, the field may otherwise be initialised with incorrect data.  For references please see the following bug report:  https://community.woltlab.com/thread/288462-uploadformfield-nicht-in-dialogformdocument-m%C3%B6glich/

3 years agoMerge branch '5.3' of https://github.com/WoltLab/WCF into 5.3
Alexander Ebert [Tue, 13 Apr 2021 12:13:03 +0000 (14:13 +0200)]
Merge branch '5.3' of https://github.com/WoltLab/WCF into 5.3

3 years agoAvoid one disk write with every request
Alexander Ebert [Tue, 13 Apr 2021 12:12:54 +0000 (14:12 +0200)]
Avoid one disk write with every request

3 years agoFix code style after merge
Matthias Schmidt [Tue, 13 Apr 2021 12:12:49 +0000 (14:12 +0200)]
Fix code style after merge

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 13 Apr 2021 12:08:45 +0000 (14:08 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 13 Apr 2021 12:03:37 +0000 (14:03 +0200)]
Merge branch '5.2' into 5.3

3 years agoFix `reloadPageOnSuccess` from different clipboard actions for same object type
Matthias Schmidt [Tue, 13 Apr 2021 12:02:59 +0000 (14:02 +0200)]
Fix `reloadPageOnSuccess` from different clipboard actions for same object type

If there are multiple clipboard action classes for the same object type, for example in case a plugin adds further clipboard actions, only the `reloadPageOnSuccess` data of the first clipboard action instance is used instead of collecting the data from all relevant clipboard action instances.

See #2584

3 years agoMerge pull request #4116 from WoltLab/html-processing-performance
Alexander Ebert [Tue, 13 Apr 2021 11:27:32 +0000 (13:27 +0200)]
Merge pull request #4116 from WoltLab/html-processing-performance

Improve the performance of the HTMLOutputProcessor

3 years agoUse `XPath::query()` for its superior performance
Alexander Ebert [Mon, 12 Apr 2021 20:14:20 +0000 (22:14 +0200)]
Use `XPath::query()` for its superior performance

3 years agoUse `XPath::query()` for its superior performance
Alexander Ebert [Mon, 12 Apr 2021 20:01:30 +0000 (22:01 +0200)]
Use `XPath::query()` for its superior performance

3 years ago`XPath::query()` is much more efficient than `getElementByTagName()`
Alexander Ebert [Mon, 12 Apr 2021 19:42:29 +0000 (21:42 +0200)]
`XPath::query()` is much more efficient than `getElementByTagName()`

The test document with ~8k elements took ~0.6s using `getElementsByTagName(*)`, but only 0.03s using `query("//*")`

3 years agoInline calls in `removeNode()` to improve the simplified-html/plain performance
Alexander Ebert [Mon, 12 Apr 2021 17:30:02 +0000 (19:30 +0200)]
Inline calls in `removeNode()` to improve the simplified-html/plain performance

3 years agoAvoid updates to DOMNodeList for childNodes
Alexander Ebert [Mon, 12 Apr 2021 17:21:21 +0000 (19:21 +0200)]
Avoid updates to DOMNodeList for childNodes

3 years agoAvoid live updates to DOMNodeList
Alexander Ebert [Mon, 12 Apr 2021 17:20:54 +0000 (19:20 +0200)]
Avoid live updates to DOMNodeList

The DOMNodeList is a live collection that is updated whenever an item is removed. This can have a significant performance impact when removing a large set of nodes.

3 years agoMerge branch '5.2' into 5.3
Marcel Werk [Mon, 12 Apr 2021 15:03:22 +0000 (17:03 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Marcel Werk [Mon, 12 Apr 2021 15:00:29 +0000 (17:00 +0200)]
Merge branch '3.1' into 5.2

3 years agoUpdated Google's address in the privacy policy
Marcel Werk [Mon, 12 Apr 2021 14:59:49 +0000 (16:59 +0200)]
Updated Google's address in the privacy policy

3 years agoRelease 5.3.6
Alexander Ebert [Mon, 12 Apr 2021 12:59:27 +0000 (14:59 +0200)]
Release 5.3.6

3 years agoStop using `self` return type in form builder (#4115)
Matthias Schmidt [Mon, 12 Apr 2021 12:23:12 +0000 (14:23 +0200)]
Stop using `self` return type in form builder (#4115)

… for compatibility with PHP versions < 7.4.

3 years agoUpdating minified JavaScript files
WoltLab [Mon, 12 Apr 2021 12:17:23 +0000 (12:17 +0000)]
Updating minified JavaScript files

3 years agoMerge pull request #4113 from WoltLab/event-all
Alexander Ebert [Mon, 12 Apr 2021 11:38:18 +0000 (13:38 +0200)]
Merge pull request #4113 from WoltLab/event-all

Add the update of wcf1_event_listener to update_com.woltlab.wcf_5.3.php

3 years agoMerge branch '5.3'
Tim Düsterhus [Mon, 12 Apr 2021 10:55:11 +0000 (12:55 +0200)]
Merge branch '5.3'

3 years agoAdd the update of wcf1_event_listener to update_com.woltlab.wcf_5.3.php
Tim Düsterhus [Mon, 12 Apr 2021 10:09:58 +0000 (12:09 +0200)]
Add the update of wcf1_event_listener to update_com.woltlab.wcf_5.3.php

… and restore update_com.woltlab.wcf_5.3.3_db.php for the users that upgraded
from 5.2.x to 5.3.3+.

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 12 Apr 2021 10:07:15 +0000 (12:07 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #4112 from WoltLab/user-option-title
Alexander Ebert [Mon, 12 Apr 2021 10:05:22 +0000 (12:05 +0200)]
Merge pull request #4112 from WoltLab/user-option-title

Use UserOption::getTitle() where possible

3 years agoUse UserOption::getTitle() in userOptionList.tpl
Tim Düsterhus [Mon, 12 Apr 2021 09:57:46 +0000 (11:57 +0200)]
Use UserOption::getTitle() in userOptionList.tpl

This one was missed in the previous commit.

3 years agoUse UserOption::getTitle() where possible
Tim Düsterhus [Mon, 12 Apr 2021 09:53:43 +0000 (11:53 +0200)]
Use UserOption::getTitle() where possible

Not all places could be adjusted for compatibility reasons, as the `Option`
super class does not have the `getTitle()` method and as the prefix is given
explicitly.

Helper methods for the description should also be added.

see #4107

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 12 Apr 2021 09:37:06 +0000 (11:37 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 12 Apr 2021 09:36:52 +0000 (11:36 +0200)]
Merge branch '3.1' into 5.2

3 years agoReset the assignment cache on group deletion
Alexander Ebert [Mon, 12 Apr 2021 09:36:26 +0000 (11:36 +0200)]
Reset the assignment cache on group deletion

Fixes #4045

3 years agoTypo + ES5-incompatible syntax
Alexander Ebert [Mon, 12 Apr 2021 09:13:26 +0000 (11:13 +0200)]
Typo + ES5-incompatible syntax

3 years agoAdd Buck to spiderList.xml
Sascha Moser [Sat, 10 Apr 2021 09:18:03 +0000 (11:18 +0200)]
Add Buck to spiderList.xml

User-Agent: `Buck/2.2; (+https://app.hypefactors.com/media-monitoring/about.html)`

see #3111

3 years agoAdd ZoominfoBot to spiderList.xml
Sascha Moser [Fri, 9 Apr 2021 17:28:00 +0000 (19:28 +0200)]
Add ZoominfoBot to spiderList.xml

User-Agent: `ZoominfoBot (zoominfobot at zoominfo dot com)`

see #3111

3 years agoFix SCSS code style
Matthias Schmidt [Mon, 12 Apr 2021 04:16:20 +0000 (06:16 +0200)]
Fix SCSS code style

3 years agoMerge branch '5.3'
Matthias Schmidt [Mon, 12 Apr 2021 04:12:23 +0000 (06:12 +0200)]
Merge branch '5.3'

3 years agoLogical separation of attachments in messages and signatures
Alexander Ebert [Sun, 11 Apr 2021 16:24:54 +0000 (18:24 +0200)]
Logical separation of attachments in messages and signatures

Fixes #3835

3 years agoUse consistent title for flood control delay time
Matthias Schmidt [Sun, 11 Apr 2021 15:43:56 +0000 (17:43 +0200)]
Use consistent title for flood control delay time

Close #3801

3 years agoConsistently use "entered" in English phrases instead of "given"
Matthias Schmidt [Sun, 11 Apr 2021 11:06:32 +0000 (13:06 +0200)]
Consistently use "entered" in English phrases instead of "given"

See #3801

3 years agoAdd missing url attribute for message share buttons' container
Matthias Schmidt [Sun, 11 Apr 2021 10:57:21 +0000 (12:57 +0200)]
Add missing url attribute for message share buttons' container

See #4108

3 years agoHide the quote tooltip while dragging the touch selection
Alexander Ebert [Sat, 10 Apr 2021 14:02:36 +0000 (16:02 +0200)]
Hide the quote tooltip while dragging the touch selection

3 years agoImproved the behavior of page action buttons on mobile
Alexander Ebert [Sat, 10 Apr 2021 13:35:47 +0000 (15:35 +0200)]
Improved the behavior of page action buttons on mobile

3 years agoWork-around for the scroll position when inserting quotes on iOS
Alexander Ebert [Sat, 10 Apr 2021 12:35:53 +0000 (14:35 +0200)]
Work-around for the scroll position when inserting quotes on iOS

3 years agoDetection of pasted blob uris in iOS
Alexander Ebert [Fri, 9 Apr 2021 16:48:41 +0000 (18:48 +0200)]
Detection of pasted blob uris in iOS

3 years agoBlock the form submit if one or more editors are still in source code mode
Alexander Ebert [Fri, 9 Apr 2021 15:34:56 +0000 (17:34 +0200)]
Block the form submit if one or more editors are still in source code mode

3 years agoDetection of repeated mentions with the first mention at index 0
Alexander Ebert [Fri, 9 Apr 2021 14:38:22 +0000 (16:38 +0200)]
Detection of repeated mentions with the first mention at index 0