Greg Kroah-Hartman [Thu, 3 Mar 2011 03:29:42 +0000 (19:29 -0800)]
Staging: hv: hv_mouse: fix camelcase in struct synthhid_device_info_ack
Just one field to fix up, s/Reserved/reserved/g
Odd that we have to set the reserved field to 0 when we send the
message, that would imply that it really isn't "reserved"...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:27:17 +0000 (19:27 -0800)]
Staging: hv: hv_mouse: use a real struct hid_descriptor
The data coming from the vmbus is really a hid descriptor, so use that
structure instead of having to mess around with a character array and
pointer fun.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:24:05 +0000 (19:24 -0800)]
Staging: hv: hv_mouse: clean up camelcase when using struct hv_input_dev_info
I think there's a callback we can remove that uses this variable in the
future as well, but that's for another patch...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:19:58 +0000 (19:19 -0800)]
Staging: hv: hv_mouse: clean up camelcase in struct synthhid_protocol_response
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:18:34 +0000 (19:18 -0800)]
Staging: hv: hv_mouse: clean up version structure usage
Turns out no one uses the major or minor fields, but hey, we'll keep
them around just to make people feel happy...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:11:49 +0000 (19:11 -0800)]
Staging: hv: hv_mouse: change camelcase for struct synthhid_msg
Turns out no one references the data field of this structure, so I
wonder if it's really even needed at all. All this is used for is the
type of the message here, so this structure might be able to be dropped
entirely in the future.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:08:05 +0000 (19:08 -0800)]
Staging: hv: hv_mouse: fix build warning
The trans_id variable (u64) was being incorrectly cast to a unsigned
long * when it should have just been unsigned long.
Fun with pointers, what a fricken mess, we need some real type safety
for these types of fields somehow...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:04:09 +0000 (19:04 -0800)]
Staging: hv: hv_mouse: fix camelcase use of struct synthhid_msg_hdr
s/Header/header/g for this structure when it is used in the file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:01:49 +0000 (19:01 -0800)]
Staging: hv: hv_mouse.c: clean up struct synthhid_msg_hdr
Use non-CamelCase names for this structure.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:58:35 +0000 (18:58 -0800)]
Staging: hv: hv_mouse: use proper input define for bus type
The code was so close, the bus type was in a comment, so go all the way
and actually use the define here. It's as if the original author was so
afraid of license issues if they referenced a define in the processed
code but they felt safe to keep it in a comment. Chicken.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:57:04 +0000 (18:57 -0800)]
Staging: hv: hv_mouse: fix up input device info structure
Make the name "hv_" specific as it's not an input layer structure we are
dealing with here. Also rename the fields to be not CamelCase.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:50:15 +0000 (18:50 -0800)]
Staging: hv: hv_mouse: reorder functions to remove forward declarations
This removes almost all forward declarations and makes all functions
static, as there should not be any global functions in this module at
all.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:40:16 +0000 (18:40 -0800)]
Staging: hv: hv_mouse: remove inline function markings
They are totally useless here, so remove them.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:38:31 +0000 (18:38 -0800)]
Staging: hv: hv_mouse.c: remove struct mousevsc_drv_obj function callbacks
They aren't needed at all either because they are never called (OnOpen,
OnClose), or because we can just call the real function instead as it's
never set to anything else.
Just another step in unwinding the callback mess...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:28:52 +0000 (18:28 -0800)]
Staging: hv: hv_mouse: unwind the initialization process a bit
This unwinds the init call sequence a bit, as we don't need a callback
pointer for a function that is already in this file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:21:01 +0000 (18:21 -0800)]
Staging: hv: hv_mouse: remove typedefs
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:57:51 +0000 (17:57 -0800)]
Staging: hv: delete mousevsc_api.h
This file is only used by one .c file (hv_mouse.c) so just move the
whole thing into that file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:53:58 +0000 (17:53 -0800)]
Staging: hv: delete vmbus_hid_protocol.h
The .h file is not needed as only one .c file uses it, so just move
it into that file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:49:30 +0000 (17:49 -0800)]
Staging: hv: hv_mouse: fix up copyright and license header
Use the proper license header from the other hv drivers and remove the
nonsense about derivative works, as it's rubbish.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:46:00 +0000 (17:46 -0800)]
Staging: hv: hv_mouse: rename hv_mouse_drv.c
As there's only one file for this driver, just name it the same
as the end module name, saving one build/link step and making it
simpler in the end.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:42:50 +0000 (17:42 -0800)]
Staging: hv: hv_mouse: delete mouse_vsc.c
Move the mouse_vsc.c file into hv_mouse_drv.c as it makes
no sense to have two files here, as we don't have to worry about the
"closed vs. open" split that this code was originally written for.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:33:26 +0000 (17:33 -0800)]
Staging: hv: mouse_vsc: fix comment coding style
Also mark this as a nice FIXME as we shouldn't ever
care about the value of an atomic variable, which makes me seriously
doubt the validity of this reference counting code. Odds are it can be
ripped out completly, or at the very least, converted to using a kref.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:31:05 +0000 (20:31 -0500)]
Staging: hv: mouse_vsc: fix space coding style issues
Lots of minor space cleanups to resolve coding style warnings and
errors.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:23:33 +0000 (20:23 -0500)]
Staging: hv: mouse_vsc.c: fix brace coding style issues
Minor brace coding style issue cleanups.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:19:05 +0000 (20:19 -0500)]
Staging: hv: hv_mouse_drv.c: minor coding style cleanups
Knock off some of the simple coding style issues in this file
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:15:14 +0000 (20:15 -0500)]
Staging: hv: enable mouse driver to build
But we disable it from automatically loading as that would
be bad. This way people can build it easier and start cleaning
it up, as it needs it.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:49 +0000 (21:18 +0100)]
staging: brcm80211: remove osl source files from driver
The whole need for the OSL concept has been removed from the driver. This
is the final commit removing the source file and include file from the
driver repository. All include statements of osl.h have been removed from
the other source files.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:48 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info from driver sources
The struct osl_info was being used only in attach functions but
previous changes make the entire usage of this structure obsolete.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:47 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info from function prototypes
A couple of functions with struct osl_info do not use this parameter
so it is removed from the function prototypes.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:46 +0000 (21:18 +0100)]
staging: brcm80211: remove counting of allocated sk_buff packets
The function pkt_buf_get_skb and pkt_buf_free_skb were using struct
osl_info field pktalloced to maintain counter of buffers in use in
the driver. It was decided to remove this facility. The prototypes
of these functions have been modified and the calling code adapted.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:45 +0000 (21:18 +0100)]
staging: brcm80211: remove of type definition osldma_t
The usage of variable of this type is not required so its use has
been removed from the driver.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:44 +0000 (21:18 +0100)]
staging: brcm80211: cleanup declaration in osl.h
Several declarations and macro definitions in osl.h are still needed
and therefore moved to bcmutils.h or hnddma.h. The osl_assert function
is moved to bcmutils.c accordingly.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:43 +0000 (21:18 +0100)]
staging: brcm80211: remove unused attributes from struct osl_info
Getting rid of the whole osl concept soon this removes most fields
in struct osl_info. Turned out hnddma.c was still using it so this
was fixed and now it gets pointer to bus device from si_info which
it only needs in the attach function for this purpose so reference
to it does not need to be kept. Two unused functions referencing
the removed fields in linux_osl.c also were removed.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:42 +0000 (21:18 +0100)]
staging: brcm80211: removed struct osl_info usage from fullmac driver
Several occurrences in fullmac using struct osl_info could be removed.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:41 +0000 (21:18 +0100)]
staging: brcm80211: remove function prototypes from wl_export.h
The include file wl_export.h contained several function prototypes
(and one macro defintion) that were not used or implemented within
the driver.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:40 +0000 (21:18 +0100)]
staging: brcm80211: move frameid initialization in wlc_d11hdrs_mac80211
Minor esthetical change to do initialization immediately at declaration.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:39 +0000 (21:18 +0100)]
staging: brcm80211: remove osl_info usage in wlc_main and wl_mac80211
Getting rid of osl concept taking small steps. This commit removes
it from wlc_main.c and wl_mac80211.c.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:38 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info usage from phy sources
Getting rid of osl concept taking small steps. This commit removes
it from source files in brcm80211/brcmsmac/phy directory.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:37 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info usage from wlc_bmac
Getting rid of osl concept taking small steps. This commit removes
it from wlc_bmac.c.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 16:01:37 +0000 (17:01 +0100)]
staging: brcm80211: replace simple_strtoul with strict_strtoul
By checkpatch recommendation using strict_strtoul now.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 08:08:43 +0000 (09:08 +0100)]
staging: brcm80211: changed module wlc_mac80211 to wlc_main
The source and include file for the wlc_mac80211 module has been
renamed to wlc_main and subsequently the include statement in
other source files. This module provides the main interface towards
wl_mac80211 module.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Neuschäfer [Tue, 1 Mar 2011 22:58:54 +0000 (23:58 +0100)]
staging: echo: fix a typo ("overflow")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arnd Bergmann [Tue, 1 Mar 2011 23:13:05 +0000 (00:13 +0100)]
staging/usbip: convert to kthread
usbip has its own infrastructure for managing kernel
threads, similar to kthread. By changing it to use
the standard functions, we can simplify the code
and get rid of one of the last BKL users at the
same time.
Includes changes suggested by Max Vozeler.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Takahiro Hirofuchi <hirofuchi@users.sourceforge.net>
Cc: Max Vozeler <max@vozeler.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:45 +0000 (14:34 +0000)]
Staging: vt6656: Clean up switching to power saving mode.
When switching to power saving mode we only need to notify
the receiver when in infrastructure mode.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 17:36:35 +0000 (17:36 +0000)]
Staging: vt6656: Ensure power.c uses proper tabbing.
Simplify setting of power state in power.c when sending power
state notifications to the access point.
Signed-off-by: Philip Worrall <philip.worrall at googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:43 +0000 (14:34 +0000)]
Staging: vt6656: Clean up spaces around parenthesized expressions
Clean up a number of places where unneeded spaces are used around
expressions.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:42 +0000 (14:34 +0000)]
Staging: vt6656: Clean up return from sending power state notifications
Clean up power.c so that unnecessary final return statements
are not used when sending power state notifications to
the access point.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:41 +0000 (14:34 +0000)]
Staging: vt6656: Clean up unneccessary braces in power.c
Clean up some unnecessary braces for conditional statements
where a single statement will do.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:40 +0000 (14:34 +0000)]
Staging: vt6656: Use C89 comments in power.c
Reformat the comments in power.c to use the C89 commenting
style instead of the C99 commenting style.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:39 +0000 (14:34 +0000)]
Staging: vt6656: Ensure power.c uses proper tabbing.
Cleanup power.c to use proper tabbing as per coding standards.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stanislav Fomichev [Tue, 1 Mar 2011 20:15:26 +0000 (23:15 +0300)]
brcm80211: remove unused TLV defines
Signed-off-by: Stanislav Fomichev <kernel@fomichev.me>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stanislav Fomichev [Tue, 1 Mar 2011 20:15:25 +0000 (23:15 +0300)]
brcm80211: use proper ieee80211 routines
removed the following defines as a side effect:
- FC_SUBTYPE_ANY_QOS
- FC_KIND_MASK
- FC_PROBE_REQ
- FC_PROBE_RESP
- FC_BEACON
- FC_PS_POLL
- FC_RTS
- FC_CTS
also fixed possible bug when the CPU byte ordered fc was passed into
ieee80211_is_data and ieee80211_is_mgmt
Signed-off-by: Stanislav Fomichev <kernel@fomichev.me>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Tue, 1 Mar 2011 09:56:56 +0000 (10:56 +0100)]
staging: brcm80211: change prototype for wlc_antsel_attach
wlc_antsel_attach was called with four parameters but actually
three parameters were already provided in the first parameter.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Tue, 1 Mar 2011 09:56:55 +0000 (10:56 +0100)]
staging: brcm80211: remove usage of struct osl_info from util sources
Most of the util source files do not need the osl_info anymore due
to previous patches so usage of it has been removed.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Tue, 1 Mar 2011 09:56:54 +0000 (10:56 +0100)]
staging: brcm80211: remove usage of struct osl_info for register access
Register access to the device uses a flag in struct osl_info to determine
whether to use memory mapped access or not. This check was not needed as
it boils down to memory mapped for brcmsmac driver and not for brcmfmac
driver. Only use of struct osl_info is reduced to keeping track of the
number of allocated sk_buffs within the driver(s).
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Thu, 24 Feb 2011 19:49:00 +0000 (14:49 -0500)]
staging: winbond: needs <linux/delay.h> for msleep and friends
linux/delay.h is pulled in somehow on x86 but not on ia64 or powerpc.
This fixes a build failure on those arches since they use [mu]delay.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Javier Martinez Canillas [Sun, 27 Feb 2011 20:54:14 +0000 (21:54 +0100)]
staging: brcm80211: Add buf_size parameter to ampdu_action handler function
struct ieee80211_ops.ampdu_action function pointer definition now includes a
u8 buf_size parameter.
Update wl_ops_ampdu_action handler function according to this new signature.
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stanislav Fomichev [Sun, 27 Feb 2011 20:28:21 +0000 (23:28 +0300)]
brcm80211: replace broadcom specific defines
AMPDU_RX_FACTOR_64K -> IEEE80211_HT_MAX_AMPDU_64K
AMPDU_RX_FACTOR_32K -> IEEE80211_HT_MAX_AMPDU_32K
DOT11_MAX_KEY_SIZE -> WLAN_MAX_KEY_LEN
HT_CAP_MIMO_PS_MASK -> IEEE80211_HT_CAP_SM_PS
HT_CAP_MAX_AMSDU -> IEEE80211_HT_CAP_MAX_AMSDU
HT_CAP_RX_STBC_MASK -> IEEE80211_HT_CAP_RX_STBC
HT_CAP_RX_STBC_SHIFT -> IEEE80211_HT_CAP_RX_STBC_SHIFT
HT_PARAMS_RX_FACTOR_MASK -> IEEE80211_HT_AMPDU_PARM_FACTOR
Signed-off-by: Stanislav Fomichev <kernel@fomichev.me>
Acked-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stanislav Fomichev [Sun, 27 Feb 2011 20:28:19 +0000 (23:28 +0300)]
staging: brcm80211: replace broadcom specific auth related defines
- DOT11_OPEN_SYSTEM -> WLAN_AUTH_OPEN
- DOT11_SHARED_KEY -> WLAN_AUTH_SHARED_KEY
- remove unused DOT11_MGMT_HDR_LEN
Signed-off-by: Stanislav Fomichev <kernel@fomichev.me>
Acked-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Van Nyen [Sun, 27 Feb 2011 22:20:24 +0000 (23:20 +0100)]
staging: keucr: Change the custom counting functions to hweight8 and hweight16
Change the custom counting functions to hweight8 and hweight16
Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sat, 26 Feb 2011 12:48:12 +0000 (15:48 +0300)]
staging: gma500: fix some swapped gotos
These gotos were swapped. In the original code, the first would result
in a NULL dereference and the second would result in a memory leak.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Sun, 27 Feb 2011 04:33:59 +0000 (20:33 -0800)]
drivers:staging:rt2860 Remove one to many n's in a word.
The Patch below removes one to many "n's" in a word..
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
CC: Jesper Juhl <jj@chaosbits.net>
CC: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Sun, 27 Feb 2011 04:34:00 +0000 (20:34 -0800)]
drivers:staging:dspbridge:node.h Remove one to many n's in a word.
The Patch below removes one to many "n's" in a word..
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Rene Sapiens <rene.sapiens@ti.com>
CC: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Sun, 27 Feb 2011 04:34:02 +0000 (20:34 -0800)]
drivers:staging:bcm:CmHost.c Remove one to many n's in a word.
The Patch below removes one to many "n's" in a word..
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: Stephen Hemminger <shemminger@vyatta.com>
CC: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Sun, 27 Feb 2011 04:34:01 +0000 (20:34 -0800)]
drivers:staging:westbridge:astoria Remove one to many n's in a word.
The Patch below removes one to many "n's" in a word..
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>
CC: David Cross <david.cross@cypress.com>
CC: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Fri, 25 Feb 2011 06:14:42 +0000 (22:14 -0800)]
staging: vt6655: device_main.c remove one to many l's in the word.
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Fri, 25 Feb 2011 06:14:23 +0000 (22:14 -0800)]
staging: rtl8712: rtl871x_pwrctrl.c remove one to many l's in the word.
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Fri, 25 Feb 2011 06:14:05 +0000 (22:14 -0800)]
staging: comedi: pcl818.c remove one to many l's in the word.
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Fri, 25 Feb 2011 06:13:46 +0000 (22:13 -0800)]
staging: comedi: pcl816.c remove one to many l's in the word.
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Justin P. Mattock [Fri, 25 Feb 2011 06:13:27 +0000 (22:13 -0800)]
staging: vt6656: main_usb.c remove one to many l's in the word.
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:24 +0000 (16:39 +0100)]
staging: brcm80211: remove usage of struct osl_info to access device
For accessing the PCI or SDIO device in the driver the device is stored
in a separate structure osl_info. To get rid of the osl concept the use
of this device pointer attribute is removed from the drivers.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:23 +0000 (16:39 +0100)]
staging: brcm80211: remove NULL pointer checks before calling kfree
kfree function can handle NULL pointer as passed parameter so there
is no need for the calling function to check for this before calling
kfree.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:22 +0000 (16:39 +0100)]
staging: brcm80211: remove struct osl_info parameter from wlc_alloc
The functions within wlc_alloc had parameter of struct osl_info type
but it was never used. As part of osl concept removal this parameter
has been removed from the function prototypes.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:21 +0000 (16:39 +0100)]
staging: brcm80211: remove osl handle from pkttotlen function
The function pkttotlen was part of osl function and as such was
called with struct osl_info parameter although not used within
the function. As part of remove the whole osl concept from the
drivers this parameter has been removed from the function
prototype.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:20 +0000 (16:39 +0100)]
staging: brcm80211: remove checks for ANTSEL related compiler definitions
The source module antsel is always included in the current driver so
any checks for it being compiled in are redundant and have been removed.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:19 +0000 (16:39 +0100)]
staging: brcm80211: remove include file d11ucode_ext.h
Include file required by wl_ucode.h only so merged content of
d11ucode_ext.h into that include file to reduce number of include
files in the driver.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:18 +0000 (16:39 +0100)]
staging: brcm80211: remove include file sbhndpio.h
All source files including sbhndpio.h were needing it only
because they needed d11.h and it had a dependency. The content
of sbhndpio.h has been merged in d11.h.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:17 +0000 (16:39 +0100)]
staging: brcm80211: remove include file proto/802.1d.h
Aim to reduce the number of source and include files. This
include file is not used anymore and can be removed.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:16 +0000 (16:39 +0100)]
staging: brcm80211: remove typedef for struct wl_timer
Typedefinitions for structures are considered affecting the
code readability. This removes use of wl_timer_t which is
typedef for struct wl_timer.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:15 +0000 (16:39 +0100)]
staging: brcm80211: remove typedefs that were flagged by checkpatch
The previous patch resulted in checkpatch to complain about 'new'
typedefs that were relocated to another include file. This commits
removes those typedef structures.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:14 +0000 (16:39 +0100)]
staging: brcm80211: remove nested include statements
In order to analyze include file usage nested includes have been
removed from the driver sources.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:13 +0000 (16:39 +0100)]
staging: brcm80211: cleanup function prototypes in header files
Several header files were specifying function prototypes although
no other module was relying on them. They have been moved to the
related source file and made static or removed if the functions
were non-existent in the driver.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Fri, 25 Feb 2011 15:39:12 +0000 (16:39 +0100)]
staging: brcm80211: remove unused module from softmac driver
The softmac driver contained an event queue mechanism which
was properly initialized and queried but no event are ever
posted to it. Therefor the module has been removed.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 25 Feb 2011 15:39:11 +0000 (16:39 +0100)]
staging: brcm80211: relocate skb_get/free routines
Getting rid of os abstraction layer (ie. osl) is ongoing. Some
routines which are still required have been moved to bcmutils
module.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 25 Feb 2011 15:39:10 +0000 (16:39 +0100)]
staging: brcm80211: Remove abstraction of pci_(alloc/free)_consistent
The abstraction for allocating and freeing dma descriptor memory
has been removed and replaced by usage of pci_alloc_consistent and
pci_free_consistent.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Brett Rudley [Fri, 25 Feb 2011 15:39:09 +0000 (16:39 +0100)]
staging: brcm80211: Remove abstractions for pci_(un)map_single
The driver had abstracted DMA mapping functions. As abstraction
is not required for the linux driver, these have been removed
and replaced by native linux functions.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stefan Weil [Thu, 24 Feb 2011 21:11:48 +0000 (22:11 +0100)]
staging: brcm80211: Fix memory leak after kmalloc failure
This error was spotted by cppcheck:
drivers/staging/brcm80211/phy/wlc_phy_lcn.c:4053: error: Memory leak: ptr
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: linux-wireless@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roland Vossen [Thu, 24 Feb 2011 11:04:34 +0000 (12:04 +0100)]
staging: brcm80211: removed compile warning
A warning was generated if CONFIG_BRCMDBG=n. Fixed this by introducing an
function.
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 24 Feb 2011 16:24:50 +0000 (16:24 +0000)]
staging: gma500: Add 2D acceleration
This is taken from Richard Purdie's previous attempt to rip the heart out
of the PVR driver and stake it.
Accelerate copies and fills.
[Revised patch which disables the methods until we can finish debugging them]
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 24 Feb 2011 14:06:53 +0000 (08:06 -0600)]
staging: delete ti-st from staging
The 2 drivers originally staged, the core ti-st driver
and the btwilink bluetooth driver have now moved to relevant
directories, so deleting the ti-st/ from staging.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Cameron [Mon, 28 Feb 2011 12:33:42 +0000 (12:33 +0000)]
staging:iio:gyro: adis16060 cleanup, move to abi and bug fixes.
Moved to standard sysfs naming and got rid of direct register writing from
userspace.
The rx and tx buffers are never used together so just have one and avoid
the need to malloc it by using putting it in the state structure and
using the ____cacheline_aligned trick.
A number of obvious bugs also fixed and correction of register address
defines in header which has now been squashed into the driver.
I don't have one of these so can't test. This is done off datasheet.
Note that the driver had parts that definitely wouldn't work before
this patch. Now it 'might' assuming I haven't messed up too badly.
I've left fixing the fact that you can only have one of these on a given
machine for another day.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Cameron [Sat, 26 Feb 2011 17:30:18 +0000 (17:30 +0000)]
staging:iio:gyro: adis16130 cleanup, move to abi and bug fixes.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Cameron [Sat, 26 Feb 2011 17:27:18 +0000 (17:27 +0000)]
staging:iio:gyro remove adis16251 driver as now supported by adis16260 driver
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Cameron [Sat, 26 Feb 2011 17:27:17 +0000 (17:27 +0000)]
staging:iio:gyro: add adis16251 support to adis16260 driver
These parts are very similar and the adis16260 driver supports
a lot of additional functionality.
Precursor to removal of adis16251 driver.
Note that some supported devices were missing from Kconfig help text
and are also added in this patch.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Cameron [Fri, 25 Feb 2011 16:09:07 +0000 (16:09 +0000)]
staging:iio:gyro: adis16080 cleanup, move to abi and bug fixes.
Moved to standard sysfs naming and got rid of direct register writing
from userspace.
The rx and tx buffers are never used together so just have one and
avoid the need to malloc it by using putting it in the state structure
and using the ____cacheline_aligned trick.
Couple of obvious bug fixes whilst I was here.
I don't have one of these so can't test. This is done off datasheet.
Note that as with the adis16060 driver there are parts that definitely
wouldn't work before this patch. Now it 'might' assuming I haven't
messed up too badly.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Mon, 28 Feb 2011 17:27:10 +0000 (19:27 +0200)]
staging/easycap: add first level indentation to easycap_ioctl.c
Add the first level indentation to easycap_testcard.c with astyle -t8.
About 100 of 80 columns warnings were left out for further fix
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Mon, 28 Feb 2011 17:27:09 +0000 (19:27 +0200)]
staging/easycap: add first level indentation to easycap_testcard.c
Add the first level indentation to easycap_testcard.c with astyle -t8.
No chackpatch warnings were created
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Mon, 28 Feb 2011 17:27:08 +0000 (19:27 +0200)]
staging/easycap: add first level indentation to easycap_sound_oss.c
Add first level indentation to easycap_sound_oss.c with astyle -t8
62 lines over 80 characters were left out for further fix
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Mon, 28 Feb 2011 17:27:07 +0000 (19:27 +0200)]
staging/easycap: add first level indentation to easycap_sound.c
Add the first level indentation to easycap_sound.c with astyle -t8.
41 lines over 80 characters were left out for further fix
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Mon, 28 Feb 2011 17:27:06 +0000 (19:27 +0200)]
staging/easycap: add first level indentation to easycap_main
Add first level indentation to easayca_main.c
This created around 300 lines over 80 characters.
Around 100 of straight forward once were fixed in this patch.
The another 200 require more code movement and need to be fixed
later
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>