Tim Düsterhus [Fri, 28 May 2021 10:51:24 +0000 (12:51 +0200)]
Remove X-XSS-Protection response header
The XSS auditor has been removed in all web browsers by now, making this header
useless.
Matthias Schmidt [Thu, 27 May 2021 08:00:32 +0000 (10:00 +0200)]
Merge branch '5.3'
SirWill [Sat, 1 May 2021 18:15:54 +0000 (20:15 +0200)]
Fix first custom smiley category not being preloaded
Joshua Rüsweg [Thu, 27 May 2021 07:23:59 +0000 (09:23 +0200)]
Merge pull request #4240 from WoltLab/pageLogo-stable-name
Do not process the pageLogo in StyleAction::updateVariables() if it is unchanged
Tim Düsterhus [Wed, 26 May 2021 14:48:00 +0000 (16:48 +0200)]
Do not process the pageLogo in StyleAction::updateVariables() if it is unchanged
This change ensures that the filename of the logo remains the same, unless the
file actually is modified.
A fix for this issue was initially attempted in
cc17f302902fb62c78b4411dadc3243913f18c74. However that commit was much more
complex and it introduced additional bugs, because it no longer passed an
explicit `null` for removed files, thus breaking the update of the related
database columns. It was subsequently reverted in
dd7c98858d406f8ca9824770ae8a68edde451493.
Tim Düsterhus [Wed, 26 May 2021 14:38:37 +0000 (16:38 +0200)]
Merge branch '5.3'
Marcel Werk [Wed, 26 May 2021 13:55:56 +0000 (15:55 +0200)]
Reduce size of og images
Marcel Werk [Wed, 26 May 2021 13:45:28 +0000 (15:45 +0200)]
Merge pull request #4239 from WoltLab/style-edit-reverts
Revert broken commits in Style Editor
Tim Düsterhus [Wed, 26 May 2021 13:05:20 +0000 (15:05 +0200)]
Revert "Prevent rewriting filenames for processed files"
This change is bogus, because it completely changes StyleAction's API and it
introduces bugs (namely not updating the database). One of these was fixed in
88b962c25b4c2dd0c312c6f7e4c11f15a1263cf4, but other fields are also affected.
As this commit doesn't fix an actual bug, but only a small inelegance (namely
the logo's path changing whenever the style is changed, even if the logo is
unchanged) this can be safely reverted until a proper fix is developed.
This reverts commit
cc17f302902fb62c78b4411dadc3243913f18c74.
Tim Düsterhus [Wed, 26 May 2021 13:17:15 +0000 (15:17 +0200)]
Revert "Fix updating pageLogo in StyleAction"
This was a fix for the broken
cc17f302902fb62c78b4411dadc3243913f18c74 which
will also be reverted.
This reverts commit
4b2f4354e6fab91ea1d7b38d7009f1f7f990d357.
Tim Düsterhus [Wed, 26 May 2021 13:16:42 +0000 (15:16 +0200)]
Revert "Only rebuild favicons if there is a new image uploaded"
This builds upon the broken
cc17f302902fb62c78b4411dadc3243913f18c74 which will
also be reverted.
This reverts commit
9bed2ebfa4e250a00794cdc75755f379dc17a696.
Tim Düsterhus [Wed, 26 May 2021 13:04:37 +0000 (15:04 +0200)]
Revert "Cover photo deletion was not saved properly"
This was a fix for the broken
cc17f302902fb62c78b4411dadc3243913f18c74 which
will also be reverted.
This reverts commit
88b962c25b4c2dd0c312c6f7e4c11f15a1263cf4.
Tim Düsterhus [Wed, 26 May 2021 12:53:20 +0000 (14:53 +0200)]
Fix `@since` tag for StyleAction::updateCustomAssets()
see
908e40a36a87ba7039c067cd8343087d701bef70
Tim Düsterhus [Wed, 26 May 2021 12:52:37 +0000 (14:52 +0200)]
Merge pull request #4238 from WoltLab/php7.1-compat
Remove PHP 7.1 compatibility layer in AvatarUploadFileValidationStrategy
Tim Düsterhus [Wed, 26 May 2021 12:48:12 +0000 (14:48 +0200)]
Trim trailing whitespace
Tim Düsterhus [Wed, 26 May 2021 12:36:45 +0000 (14:36 +0200)]
Properly delete all variants of style cover photos
This needed some workarounds to properly account for the WebP variant.
Tim Düsterhus [Wed, 26 May 2021 12:35:22 +0000 (14:35 +0200)]
Update `$newLocation` after creating the WebP variant of a style's cover photo
This ensures that the StyleEditForm always uses the non-WebP version for processing.
Tim Düsterhus [Wed, 26 May 2021 12:27:33 +0000 (14:27 +0200)]
Use the non-WebP version of the cover photo in StyleEditForm
Tim Düsterhus [Wed, 26 May 2021 12:10:21 +0000 (14:10 +0200)]
Recognize IMAGETYPE_WEBP in StyleAddForm
Tim Düsterhus [Wed, 26 May 2021 11:07:18 +0000 (13:07 +0200)]
Remove PHP 7.1 compatibility layer in AvatarUploadFileValidationStrategy
Tim Düsterhus [Wed, 26 May 2021 11:05:54 +0000 (13:05 +0200)]
Fix detection of WebP images in `ImageUtil::createWebpVariant()`
Tim Düsterhus [Wed, 26 May 2021 10:59:18 +0000 (12:59 +0200)]
Fix `$forceWebP` parameter in `UserCoverPhoto::getLocation()` and `::getURL()`
Tim Düsterhus [Wed, 26 May 2021 10:21:12 +0000 (12:21 +0200)]
Add missing backslash in `Attribute` attribute for `\wcf\SensitiveArgument`
Tim Düsterhus [Wed, 26 May 2021 09:27:40 +0000 (11:27 +0200)]
Update tslib to 2.2.0
Alexander Ebert [Tue, 25 May 2021 15:37:08 +0000 (17:37 +0200)]
Merge pull request #4236 from WoltLab/user-rebuild-memory-leak
Fetch UserProfiles live to avoid memory leaks through the RuntimeCache on CLI
Matthias Schmidt [Tue, 25 May 2021 09:04:20 +0000 (11:04 +0200)]
Fix code formatting
Matthias Schmidt [Tue, 25 May 2021 08:57:54 +0000 (10:57 +0200)]
Merge branch '5.3'
Matthias Schmidt [Tue, 25 May 2021 08:54:31 +0000 (10:54 +0200)]
Ignore disabled smiley categories for WYSIWYG form field
Matthias Schmidt [Tue, 25 May 2021 06:17:30 +0000 (08:17 +0200)]
Fix code formatting
Matthias Schmidt [Tue, 25 May 2021 06:13:26 +0000 (08:13 +0200)]
Merge branch '5.3'
Matthias Schmidt [Tue, 25 May 2021 06:01:52 +0000 (08:01 +0200)]
Fix media clipboard inserting when having multiple editors
Ensure that the clipboard insertion event listener is only added once and that the active media manager is set in the clipboard handler when opening a media manager window.
Matthias Schmidt [Tue, 25 May 2021 05:46:36 +0000 (07:46 +0200)]
Ensure uniqueness of media insert dialogs when having multiple editors
Alexander Ebert [Fri, 21 May 2021 15:06:21 +0000 (17:06 +0200)]
Fetch UserProfiles live to avoid memory leaks through the RuntimeCache on CLI
Tim Düsterhus [Fri, 21 May 2021 13:57:36 +0000 (15:57 +0200)]
Merge pull request #4234 from WoltLab/email-log-discard
Add 'discarded' status to email log
Tim Düsterhus [Fri, 21 May 2021 13:54:46 +0000 (15:54 +0200)]
Improve phrasing of message when discarding emails for read notifications
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Fri, 21 May 2021 13:51:30 +0000 (15:51 +0200)]
Merge pull request #4235 from WoltLab/cover-webp
Check ->coverPhotoHasWebP in UserCoverPhoto::getFilename()
Tim Düsterhus [Fri, 21 May 2021 13:46:56 +0000 (15:46 +0200)]
Check ->coverPhotoHasWebP in UserCoverPhoto::getFilename()
Alexander Ebert [Fri, 21 May 2021 13:42:39 +0000 (15:42 +0200)]
Event listeners had been attached repeatedly
Alexander Ebert [Fri, 21 May 2021 13:42:07 +0000 (15:42 +0200)]
Incorrect check for ignored mutation events
Tim Düsterhus [Fri, 21 May 2021 13:18:55 +0000 (15:18 +0200)]
Update email log status to discarded when dropping notification mails
Fixes #4225
Tim Düsterhus [Fri, 21 May 2021 12:27:13 +0000 (14:27 +0200)]
Add EmailLogEntry::STATUS_DISCARDED
Tim Düsterhus [Fri, 21 May 2021 12:23:58 +0000 (14:23 +0200)]
Make EmailDeliveryBackgroundJob::updateStatus() public
Alexander Ebert [Thu, 20 May 2021 15:04:39 +0000 (17:04 +0200)]
Release 5.4.0 Alpha 3
Tim Düsterhus [Thu, 20 May 2021 13:20:48 +0000 (15:20 +0200)]
Merge pull request #4232 from WoltLab/iusermailbox
Add IUserMailbox interface
Tim Düsterhus [Thu, 20 May 2021 13:10:28 +0000 (15:10 +0200)]
Add IUserMailbox interface
This cleans up the OO design a bit, because consumers may check against the
interface instead of a concrete class. This allows for additional mailboxes
belonging to an user, e.g. for emergency contacts or separate billing
addresses.
WoltLab [Thu, 20 May 2021 12:23:10 +0000 (12:23 +0000)]
Updating minified JavaScript files
Marcel Werk [Thu, 20 May 2021 12:05:58 +0000 (14:05 +0200)]
Merge pull request #4231 from WoltLab/unfurl-user-agent-like
Add '; like Twitterbot' to URL Unfurling User-Agent
Tim Düsterhus [Thu, 20 May 2021 09:26:08 +0000 (11:26 +0200)]
Improve phrasing of success state in email log
Resolves #4230
Tim Düsterhus [Thu, 20 May 2021 08:46:21 +0000 (10:46 +0200)]
Add '; like Twitterbot' to URL Unfurling User-Agent
Tim Düsterhus [Thu, 20 May 2021 08:39:13 +0000 (10:39 +0200)]
Allow commas and semicolons in the comment in HttpFactory::getDefaultUserAgent()
Matthias Schmidt [Thu, 20 May 2021 07:45:11 +0000 (09:45 +0200)]
Merge branch '5.3'
Matthias Schmidt [Thu, 20 May 2021 07:43:46 +0000 (09:43 +0200)]
Preserve deleted filter when using article list pagination in ACP
Alexander Ebert [Wed, 19 May 2021 16:30:48 +0000 (18:30 +0200)]
Merge pull request #4229 from WoltLab/bundle-exclude
Exclude JS modules from bundles
Alexander Ebert [Wed, 19 May 2021 16:13:46 +0000 (18:13 +0200)]
Bundle two modules due to external dependency
Alexander Ebert [Wed, 19 May 2021 15:57:49 +0000 (17:57 +0200)]
Skip the "Add Article" dialog for non authorized users
Marcel Werk [Wed, 19 May 2021 15:33:49 +0000 (17:33 +0200)]
Show disabled articles in categorized list
Marcel Werk [Wed, 19 May 2021 14:57:24 +0000 (16:57 +0200)]
Merge branch '5.3'
Marcel Werk [Wed, 19 May 2021 14:53:08 +0000 (16:53 +0200)]
Merge branch '5.3'
Marcel Werk [Wed, 19 May 2021 14:49:38 +0000 (16:49 +0200)]
Incorrect badge selector
Alexander Ebert [Wed, 19 May 2021 14:17:22 +0000 (16:17 +0200)]
Rebuild JS files
Alexander Ebert [Wed, 19 May 2021 14:00:43 +0000 (16:00 +0200)]
Exclude modules from (some) builds
joshuaruesweg [Wed, 19 May 2021 12:31:19 +0000 (14:31 +0200)]
Merge branch '5.3'
joshuaruesweg [Wed, 19 May 2021 12:30:14 +0000 (14:30 +0200)]
Fix email in Apple Mail with darkmode enabled
Fix #4188
Tim Düsterhus [Wed, 19 May 2021 10:32:05 +0000 (12:32 +0200)]
Use whitespace as the separator after `@woltlabExcludeBundle`
Marcel Werk [Wed, 19 May 2021 10:22:58 +0000 (12:22 +0200)]
Merge pull request #4226 from WoltLab/email-log-filter
Add `email` filter to email log
Tim Düsterhus [Wed, 19 May 2021 10:13:53 +0000 (12:13 +0200)]
Exclude `Ui/User/Multifactor/Totp/Qr` from all JS bundles
Tim Düsterhus [Wed, 19 May 2021 10:10:48 +0000 (12:10 +0200)]
Exclude `Devtools/Style/LiveReload` from all JS bundles
Tim Düsterhus [Wed, 19 May 2021 09:58:02 +0000 (11:58 +0200)]
Merge pull request #4228 from WoltLab/js-bundle-optimize
Support excluding specific modules from bundles
Tim Düsterhus [Wed, 19 May 2021 09:46:54 +0000 (11:46 +0200)]
Support excluding specific modules from bundles
Tim Düsterhus [Wed, 19 May 2021 09:20:47 +0000 (11:20 +0200)]
Make require.build.js more flexible
WoltLab [Wed, 19 May 2021 09:18:27 +0000 (09:18 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Wed, 19 May 2021 08:50:54 +0000 (10:50 +0200)]
Fix typo in comment in FloodControl.class.php
Tim Düsterhus [Wed, 19 May 2021 07:40:40 +0000 (09:40 +0200)]
Stop using `elBySel` in emailLogList.tpl
Tim Düsterhus [Wed, 19 May 2021 07:41:09 +0000 (09:41 +0200)]
Trim filter values in EmailLogListPage
Tim Düsterhus [Wed, 19 May 2021 07:39:14 +0000 (09:39 +0200)]
Add `email` filter to EmailLogList
Resolves #4224
Matthias Schmidt [Wed, 19 May 2021 05:11:21 +0000 (07:11 +0200)]
Fix code style issue
Matthias Schmidt [Wed, 19 May 2021 05:08:01 +0000 (07:08 +0200)]
Add `Database::prepare()` which replaces `app1_` with `app{WCF_N}_` (#4223)
Close #2911
Alexander Ebert [Tue, 18 May 2021 16:19:42 +0000 (18:19 +0200)]
Missing font stack for system font in emails
joshuaruesweg [Tue, 18 May 2021 13:30:57 +0000 (15:30 +0200)]
Add missing `since` tag
Tim Düsterhus [Tue, 18 May 2021 11:28:07 +0000 (13:28 +0200)]
Merge pull request #4221 from WoltLab/session-legacy-duplicate
Prevent duplicate key errors during creation of legacy sessions
Tim Düsterhus [Tue, 18 May 2021 10:33:35 +0000 (12:33 +0200)]
Merge pull request #4222 from mutec/pjsonfiles
provide files-property for `package.json`
mutec [Tue, 18 May 2021 10:23:43 +0000 (12:23 +0200)]
provide files-property for package.json
Prevent reading the whole repository when this repository is a dependency.
Tim Düsterhus [Tue, 18 May 2021 09:06:11 +0000 (11:06 +0200)]
Prevent duplicate key errors during creation of legacy sessions
Fixes #4214.
see
7878eb77952c506e5818587b49f9a64773b87fb1
Tim Düsterhus [Tue, 18 May 2021 08:48:00 +0000 (10:48 +0200)]
Gracefully handle missing legacy session in SessionHandler::__get()
Tim Düsterhus [Tue, 18 May 2021 08:45:42 +0000 (10:45 +0200)]
Explicitly `return null` in SessionHandler::__get()'s default case
Tim Düsterhus [Tue, 18 May 2021 08:11:07 +0000 (10:11 +0200)]
Revert "Ignore duplicate key errors when creating a legacy session"
This commit was incorrect, as `createOrIgnore()` might return `null` which is
disallowed by the return type and is undesired.
This reverts commit
7878eb77952c506e5818587b49f9a64773b87fb1.
Matthias Schmidt [Tue, 18 May 2021 06:51:47 +0000 (08:51 +0200)]
Fix code style issues
Matthias Schmidt [Tue, 18 May 2021 05:01:42 +0000 (07:01 +0200)]
Properly position errors below fields in `.inputAddon` elements
Matthias Schmidt [Tue, 18 May 2021 04:57:32 +0000 (06:57 +0200)]
Merge branch '5.3'
Matthias Schmidt [Tue, 18 May 2021 04:56:48 +0000 (06:56 +0200)]
Properly position errors below fields in `.inputAddon` elements (#4219)
Alexander Ebert [Mon, 17 May 2021 17:05:22 +0000 (19:05 +0200)]
Merge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:05:06 +0000 (19:05 +0200)]
Incorrect redirect url after login in multi domain setups
Alexander Ebert [Mon, 17 May 2021 17:02:50 +0000 (19:02 +0200)]
Use `opacity` to fade out icons
Alexander Ebert [Mon, 17 May 2021 17:01:14 +0000 (19:01 +0200)]
Merge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:00:44 +0000 (19:00 +0200)]
Incorrect fade out effect in iOS Safari
Matthias Schmidt [Mon, 17 May 2021 12:02:31 +0000 (14:02 +0200)]
Merge pull request #4217 from WoltLab/readme_redactor
Remove reference to specific WSC version in `README.md`
Alexander Ebert [Mon, 17 May 2021 10:10:49 +0000 (12:10 +0200)]
Skip basic bbcodes when the selection is inside a code block
Tim Düsterhus [Mon, 17 May 2021 10:01:08 +0000 (12:01 +0200)]
Fix possible property access on `null` in `SessionHandler::applyPendingUserChange()`
Matthias Schmidt [Mon, 17 May 2021 06:14:11 +0000 (08:14 +0200)]
Start each sentence in new line in `README.md`
Matthias Schmidt [Mon, 17 May 2021 06:13:23 +0000 (08:13 +0200)]
Remove reference to specific WSC version in `README.md`