Tim Düsterhus [Tue, 13 Jul 2021 09:39:50 +0000 (11:39 +0200)]
Remove PROFILE_MAIL_USE_CAPTCHA
see
67e204a044077c2ad96685386aabaf6803a61d21
see #3032
see #3151
Tim Düsterhus [Mon, 12 Jul 2021 14:28:34 +0000 (16:28 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 12 Jul 2021 14:27:34 +0000 (16:27 +0200)]
Upgrade the default STARTTLS level to `encrypt`
see #4246
Tim Düsterhus [Mon, 12 Jul 2021 13:55:57 +0000 (15:55 +0200)]
Update the default SMTP port to 587
25 is not meant for submission.
Alexander Ebert [Mon, 12 Jul 2021 13:40:28 +0000 (15:40 +0200)]
Explicitly mark styles for 5.2+ as compatible with 5.4
Tim Düsterhus [Mon, 12 Jul 2021 09:13:39 +0000 (11:13 +0200)]
Merge pull request #4384 from WoltLab/cronjob_xsd
Remove obsolete elements from `cronjob.xsd`
joshuaruesweg [Sun, 11 Jul 2021 16:03:42 +0000 (18:03 +0200)]
Merge branch '5.4'
Joshua Rüsweg [Sun, 11 Jul 2021 16:02:54 +0000 (18:02 +0200)]
Merge pull request #4392 from WoltLab/rename-totp-field
Rename TOTP code form field to `onetimecode`
joshuaruesweg [Sun, 11 Jul 2021 09:28:07 +0000 (11:28 +0200)]
Rename TOTP code form field to `onetimecode`
The name `code` for the form field is too generic and should be specified. `onetimecode` is a more fitting identifier for the input name. In addition, 1password fills the totp code automatically, if the field is named `onetimecode` (See https://1password.community/discussion/comment/604200/#Comment_604200).
joshuaruesweg [Sun, 11 Jul 2021 08:53:10 +0000 (10:53 +0200)]
Merge branch '5.4'
joshuaruesweg [Sun, 11 Jul 2021 08:50:15 +0000 (10:50 +0200)]
Convert tabs to spaces
joshuaruesweg [Sun, 11 Jul 2021 08:48:21 +0000 (10:48 +0200)]
Merge branch '5.3'
joshuaruesweg [Sun, 11 Jul 2021 08:34:16 +0000 (10:34 +0200)]
Merge branch '5.2'
joshuaruesweg [Sun, 11 Jul 2021 08:31:21 +0000 (10:31 +0200)]
Merge branch '3.1'
Sascha Greuel [Sun, 11 Jul 2021 08:24:24 +0000 (10:24 +0200)]
Don't leak an account's activation status (#4365)
* Don't leak an account's activation status
* Update wcfsetup/install/files/lib/form/RegisterNewActivationCodeForm.class.php
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
joshuaruesweg [Sat, 10 Jul 2021 09:47:04 +0000 (11:47 +0200)]
Merge branch '5.4'
joshuaruesweg [Sat, 10 Jul 2021 09:44:09 +0000 (11:44 +0200)]
Merge branch '5.3'
joshuaruesweg [Sat, 10 Jul 2021 09:39:33 +0000 (11:39 +0200)]
Set new activation code on rerequesting them
Tim Düsterhus [Fri, 9 Jul 2021 11:32:15 +0000 (13:32 +0200)]
Merge pull request #4389 from WoltLab/email-serialize-size
Reduce the size of the Mailbox objects
Tim Düsterhus [Fri, 9 Jul 2021 10:26:44 +0000 (12:26 +0200)]
Reduce the size of the Mailbox objects
This introduces a small BC break for classes inheriting from Mailbox or
UserMailbox that directly access the `language` or `user` properties instead of
the getter methods. But this is easily fixed.
Resolves #4387
Alexander Ebert [Thu, 8 Jul 2021 13:38:43 +0000 (15:38 +0200)]
Release 5.4.0 RC 2
Tim Düsterhus [Thu, 8 Jul 2021 11:33:34 +0000 (13:33 +0200)]
Merge pull request #4385 from WoltLab/package-update-compat
Do not store package compatibility from update servers within the database
Tim Düsterhus [Thu, 8 Jul 2021 10:31:49 +0000 (12:31 +0200)]
Do not store package compatibility from update servers within the database
These do not appear to be used anywhere and the official package servers do not
expose them either, making them effectively empty even in current versions.
see #4371
Tim Düsterhus [Thu, 8 Jul 2021 08:51:13 +0000 (10:51 +0200)]
Merge branch '5.4'
Matthias Schmidt [Thu, 8 Jul 2021 08:06:41 +0000 (10:06 +0200)]
Remove obsolete elements from `cronjob.xsd`
These elements are no longer (if ever) used.
Tim Düsterhus [Thu, 8 Jul 2021 07:25:39 +0000 (09:25 +0200)]
Add update_com.woltlab.wcf_5.4_styleCoverPhoto.php to package.xml
Tim Düsterhus [Thu, 8 Jul 2021 07:25:20 +0000 (09:25 +0200)]
Do not use the cache in update_com.woltlab.wcf_5.4_styleCoverPhoto.php
Matthias Schmidt [Thu, 8 Jul 2021 06:50:43 +0000 (08:50 +0200)]
Fix variable name in `ViewableArticleContentList::readObjects()`
Alexander Ebert [Wed, 7 Jul 2021 16:16:32 +0000 (18:16 +0200)]
Do not block matching abbreviation if the package is the same
The previous code would block the installation of an update of the same package.
Fix for #4357
Alexander Ebert [Wed, 7 Jul 2021 15:58:23 +0000 (17:58 +0200)]
Release 5.4.0 RC 2
WoltLab [Wed, 7 Jul 2021 15:41:36 +0000 (15:41 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 7 Jul 2021 15:14:55 +0000 (17:14 +0200)]
Improved the visuals of the list of MFA options
The content is now vertically centered and the somewhat tiny smartphone icon is enlarged to better match the other icons.
Alexander Ebert [Wed, 7 Jul 2021 15:08:28 +0000 (17:08 +0200)]
Use `<small>` instead of `<p class="small">`
Tim Düsterhus [Wed, 7 Jul 2021 13:42:15 +0000 (15:42 +0200)]
Avoid use of escapeString() in UserNotificationEventAction
This part of the code appears to be completely unused, but the same logic can
be found in UserNotificationEventPackageInstallationPlugin, so it should be
correct.
Tim Düsterhus [Wed, 7 Jul 2021 12:08:39 +0000 (14:08 +0200)]
Merge pull request #4371 from WoltLab/api-compat-no-store
Do not store API compatibility information within the database
Tim Düsterhus [Wed, 7 Jul 2021 12:07:57 +0000 (14:07 +0200)]
Merge pull request #4381 from WoltLab/gzopen64
Remove gzopen64() workaround
Tim Düsterhus [Wed, 7 Jul 2021 11:56:29 +0000 (13:56 +0200)]
Remove gzopen64() workaround
PHP bug #53829 (https://bugs.php.net/bug.php?id=53829) is fixed. This should no
longer be required.
Tim Düsterhus [Wed, 7 Jul 2021 11:45:11 +0000 (13:45 +0200)]
Mark wcf1_package_compatibility as deprecated in install.sql
Tim Düsterhus [Tue, 6 Jul 2021 12:41:34 +0000 (14:41 +0200)]
Remove list of compatible API versions in PackagePage
Tim Düsterhus [Tue, 6 Jul 2021 12:30:14 +0000 (14:30 +0200)]
Clear wcf1_package_compatibility when upgrading to 5.5
Tim Düsterhus [Mon, 5 Jul 2021 14:17:49 +0000 (16:17 +0200)]
Do not store API compatibility information within the database
These are automatically converted into an exclude of Core 6.0.0 Alpha 1 in
PackageArchive and thus redundant.
Matthias Schmidt [Wed, 7 Jul 2021 10:49:58 +0000 (12:49 +0200)]
Merge branch '5.4'
Matthias Schmidt [Wed, 7 Jul 2021 10:48:12 +0000 (12:48 +0200)]
Fix `this` value for `Core.enableLegacyInheritance()` (#4380)
Without explicitly binding `this` to `thisValue`, it will be `constructed` resulting in missing data only present in `thisValue`.
Matthias Schmidt [Wed, 7 Jul 2021 08:25:44 +0000 (10:25 +0200)]
Merge branch '5.4'
Matthias Schmidt [Wed, 7 Jul 2021 08:25:33 +0000 (10:25 +0200)]
Explicitly show error message if import queue is empty
Close #3804
See #4379
Matthias Schmidt [Wed, 7 Jul 2021 07:06:09 +0000 (09:06 +0200)]
Merge branch '5.4'
Matthias Schmidt [Wed, 7 Jul 2021 07:05:42 +0000 (09:05 +0200)]
Merge branch '5.3' into 5.4
Matthias Schmidt [Wed, 7 Jul 2021 07:01:14 +0000 (09:01 +0200)]
Fix reading value of `CheckboxFormField`
In contrast to `BooleanFormField` for which an explicit "no" input field exists, a normal checkbox does not submit any data if no checked.
Tim Düsterhus [Tue, 6 Jul 2021 12:56:59 +0000 (14:56 +0200)]
Merge pull request #4376 from WoltLab/rebuild-active-app
Remove the need to rebuild the active application
Alexander Ebert [Tue, 6 Jul 2021 12:47:11 +0000 (14:47 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Alexander Ebert [Tue, 6 Jul 2021 12:47:03 +0000 (14:47 +0200)]
Incorrect type cast to `number`
Matthias Schmidt [Tue, 6 Jul 2021 12:34:01 +0000 (14:34 +0200)]
Fix conversion of `Dictionary` to `Map` in `Acp/Ui/Menu/Item/Handler`
See
2727575fbe8a2ca2fe4a19288c7a982969170882
Alexander Ebert [Tue, 6 Jul 2021 12:33:14 +0000 (14:33 +0200)]
Search for articles toggled the incorrect container
Matthias Schmidt [Tue, 6 Jul 2021 12:26:22 +0000 (14:26 +0200)]
Explicitly delete obsolete style logo description phrases
See
dcb0fe8ec9560f4a7905d9fd1241bc72d1a5c337
Matthias Schmidt [Tue, 6 Jul 2021 12:24:24 +0000 (14:24 +0200)]
Merge branch '5.4'
Matthias Schmidt [Tue, 6 Jul 2021 12:24:10 +0000 (14:24 +0200)]
Merge branch '5.3' into 5.4
Matthias Schmidt [Tue, 6 Jul 2021 12:23:51 +0000 (14:23 +0200)]
Remove obsolete style logo upload field descriptions
See #3456
Tim Düsterhus [Tue, 6 Jul 2021 11:52:40 +0000 (13:52 +0200)]
Merge pull request #4375 from WoltLab/controller-workaround
Remove old workaround for the upgrade from 2.1 to 3.0
Tim Düsterhus [Tue, 6 Jul 2021 11:47:30 +0000 (13:47 +0200)]
Merge pull request #4370 from WoltLab/devtools-api-compat
Remove support for the API compatibility tags from dev tools
Marcel Werk [Tue, 6 Jul 2021 11:15:10 +0000 (13:15 +0200)]
Merge branch '5.4'
Marcel Werk [Tue, 6 Jul 2021 11:08:46 +0000 (13:08 +0200)]
Fixed missing language version for embedded articles
Tim Düsterhus [Tue, 6 Jul 2021 10:49:19 +0000 (12:49 +0200)]
Use temporary variables for `Request` objects in FontManager
This is for consistency with other code sending HTTP requests and to shorten
the lines, as one of them exceeded 120 characters.
Tim Düsterhus [Tue, 6 Jul 2021 10:49:01 +0000 (12:49 +0200)]
Merge branch '5.4'
Tim Düsterhus [Tue, 6 Jul 2021 10:48:04 +0000 (12:48 +0200)]
Merge remote-tracking branch 'origin/5.4' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:47:52 +0000 (12:47 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:46:01 +0000 (12:46 +0200)]
Add missing encoding of `$family` in font download requests
Tim Düsterhus [Tue, 6 Jul 2021 10:11:09 +0000 (12:11 +0200)]
Remove the need to rebuild the active application
Calculating this value live does not come with a relevant performance loss and
simplifies the request handling logic.
Tim Düsterhus [Tue, 6 Jul 2021 10:04:55 +0000 (12:04 +0200)]
Simplify extraction of abbreviation for active application check
Matthias Schmidt [Tue, 6 Jul 2021 09:42:44 +0000 (11:42 +0200)]
Merge branch '5.4'
Matthias Schmidt [Tue, 6 Jul 2021 09:42:35 +0000 (11:42 +0200)]
Add missing since tag for `User::requiresMultifactor()`
Tim Düsterhus [Tue, 6 Jul 2021 09:34:17 +0000 (11:34 +0200)]
Move call to `checkAppEvaluation()` into `handle()`
It fits better here to cleanly separate the handling from the building. No
behavioral change was found.
Tim Düsterhus [Tue, 6 Jul 2021 09:32:06 +0000 (11:32 +0200)]
Move the check for expired app evaluations into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:30:33 +0000 (11:30 +0200)]
Make the evaluation check independent of local variables
Tim Düsterhus [Tue, 6 Jul 2021 09:29:44 +0000 (11:29 +0200)]
Simplify extraction of abbreviation for evaluation check
Tim Düsterhus [Tue, 6 Jul 2021 09:29:14 +0000 (11:29 +0200)]
Add `@since` to RequestHandler::checkOfflineMode()
see
60fff547e76067211270f9f5eb7da9f257f847fc
Tim Düsterhus [Tue, 6 Jul 2021 09:19:37 +0000 (11:19 +0200)]
Move the check for offline mode into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:21:54 +0000 (11:21 +0200)]
Use `getActiveRequest()` method in favor of directly accessing the class property
Tim Düsterhus [Tue, 6 Jul 2021 09:10:18 +0000 (11:10 +0200)]
Remove old workaround for the upgrade from 2.1 to 3.0
Tim Düsterhus [Tue, 6 Jul 2021 09:04:44 +0000 (11:04 +0200)]
Use `isACPRequest()` method in favor of a local variable in RequestHandler::handle()
Tim Düsterhus [Tue, 6 Jul 2021 08:58:18 +0000 (10:58 +0200)]
Remove unused local variable `$appendSession` in LinkHandler::getLink()
Tim Düsterhus [Tue, 6 Jul 2021 08:23:46 +0000 (10:23 +0200)]
Merge branch '5.4'
Tim Düsterhus [Tue, 6 Jul 2021 08:23:25 +0000 (10:23 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 07:34:53 +0000 (09:34 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 6 Jul 2021 07:34:26 +0000 (09:34 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 6 Jul 2021 07:32:45 +0000 (09:32 +0200)]
Remove duplicate `class` attribute in cacheList.tpl
Matthias Schmidt [Tue, 6 Jul 2021 07:12:34 +0000 (09:12 +0200)]
Support sorting users in `UserOnlineListBoxController` (#4372)
Close #4182
Tim Düsterhus [Mon, 5 Jul 2021 14:09:47 +0000 (16:09 +0200)]
Remove support for the API compatibility tags from dev tools
Tim Düsterhus [Mon, 5 Jul 2021 14:21:52 +0000 (16:21 +0200)]
Remove obsolete import
Tim Düsterhus [Mon, 5 Jul 2021 14:00:08 +0000 (16:00 +0200)]
Remove cleanup of `userID` and `password` cookies
They are no longer used as of WoltLab Suite 5.4, however the removal remained
in the code to clean up the browser's cookie store on logout. Remove it, the
cookies will naturally expire in the future.
Tim Düsterhus [Mon, 5 Jul 2021 13:08:13 +0000 (15:08 +0200)]
Set `optimize-autoloader: true` in composer.json
Tim Düsterhus [Mon, 5 Jul 2021 13:03:53 +0000 (15:03 +0200)]
Merge pull request #4369 from WoltLab/composer
Update composer dependencies
Tim Düsterhus [Mon, 5 Jul 2021 13:00:35 +0000 (15:00 +0200)]
Update fileDelete.xml for composer updates
Tim Düsterhus [Mon, 5 Jul 2021 12:49:15 +0000 (14:49 +0200)]
Update composer dependencies
Tim Düsterhus [Mon, 5 Jul 2021 12:19:01 +0000 (14:19 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 12:18:15 +0000 (14:18 +0200)]
Check for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php
Tim Düsterhus [Mon, 5 Jul 2021 12:17:29 +0000 (14:17 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 12:09:42 +0000 (14:09 +0200)]
Merge pull request #4368 from WoltLab/upgrade-check-webp
Add check for GD support to PackageEnableUpgradeOverrideForm
Tim Düsterhus [Mon, 5 Jul 2021 11:57:40 +0000 (13:57 +0200)]
Add check for GD support to PackageEnableUpgradeOverrideForm
Matthias Schmidt [Mon, 5 Jul 2021 10:51:46 +0000 (12:51 +0200)]
Export `WCFMessageQuoteManager` interface in `Ui/Message/Quote`
See #3876
Tim Düsterhus [Mon, 5 Jul 2021 10:45:51 +0000 (12:45 +0200)]
Merge branch '5.4'