GitHub/WoltLab/WCF.git
4 years agoPrevent the focus being trapped if the user intentionally clicks outside
Alexander Ebert [Thu, 20 Aug 2020 22:28:22 +0000 (00:28 +0200)]
Prevent the focus being trapped if the user intentionally clicks outside

Clicking on a link or button outside of the overlay caused the browser to close the drop-down and shift the focus on the menu element.

4 years agoMerge pull request #3525 from WoltLab/rich-metacode-in-quick-reply
Alexander Ebert [Thu, 20 Aug 2020 09:52:30 +0000 (11:52 +0200)]
Merge pull request #3525 from WoltLab/rich-metacode-in-quick-reply

Prevent rich metacode being dysfunctional in new messages

4 years agoMerge pull request #3523 from WoltLab/dropdown-scrollbar-large-tablets-fix
Alexander Ebert [Wed, 19 Aug 2020 22:50:13 +0000 (00:50 +0200)]
Merge pull request #3523 from WoltLab/dropdown-scrollbar-large-tablets-fix

Fix the scrollbar for dropdowns on large tablets

4 years agoPrevent rich metacode being dysfunctional in messages just created by replying
Alexander Ebert [Wed, 19 Aug 2020 17:26:11 +0000 (19:26 +0200)]
Prevent rich metacode being dysfunctional in messages just created by replying

The `isset` strategy does not work properly, because in some cases the HTML is evaluated before being placed in the final template, causing the variable to be set already.

This changes modifies the behavior to always attempt to initialize the JavaScript, but made changes to ensure that each subsequent call is idempotent.

4 years agoFix the scrollbar for dropdowns on large tablets
joshuaruesweg [Wed, 19 Aug 2020 13:32:27 +0000 (15:32 +0200)]
Fix the scrollbar for dropdowns on large tablets
Because tablets are not the platform "desktop", the scrollbar is not shown for tablets, even though they are rendered with desktop view.
Fixes #3522

4 years agoDisable the search for updates buttons while active
Alexander Ebert [Wed, 19 Aug 2020 08:40:47 +0000 (10:40 +0200)]
Disable the search for updates buttons while active

4 years agoMerge pull request #3521 from Krymonota/patch-13
Joshua Rüsweg [Tue, 18 Aug 2020 17:22:02 +0000 (19:22 +0200)]
Merge pull request #3521 from Krymonota/patch-13

Remove redundant `implements IWorker`

4 years agoRemove redundant `implements IWorker`
Niklas [Tue, 18 Aug 2020 17:14:12 +0000 (19:14 +0200)]
Remove redundant `implements IWorker`

4 years agoFix deprecation warnings in form builder in PHP 8
Matthias Schmidt [Sat, 15 Aug 2020 12:46:51 +0000 (14:46 +0200)]
Fix deprecation warnings in form builder in PHP 8

Close #3489

4 years agoUpdating minified JavaScript files
woltlab.com [Mon, 17 Aug 2020 10:29:28 +0000 (10:29 +0000)]
Updating minified JavaScript files

4 years agoPrefer longer group names for mentions
Alexander Ebert [Sat, 15 Aug 2020 17:35:58 +0000 (19:35 +0200)]
Prefer longer group names for mentions

4 years agoSkip display-name of Mailbox if display-name == addr-spec
Tim Düsterhus [Fri, 14 Aug 2020 10:22:16 +0000 (12:22 +0200)]
Skip display-name of Mailbox if display-name == addr-spec

If the human readable $name of a Mailbox matches the $address then leave
out the $name within the header representation and specify a bare email
address. The name is redundant in cases like this and this might lead to
negative spam scoring.

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Thu, 13 Aug 2020 11:31:37 +0000 (13:31 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3500 from Krymonota/patch-12
Alexander Ebert [Thu, 13 Aug 2020 11:31:16 +0000 (13:31 +0200)]
Merge pull request #3500 from Krymonota/patch-12

Add missing phrases to English 3rd party register language items

4 years agoFix resizing images in Safari
joshuaruesweg [Thu, 13 Aug 2020 07:44:48 +0000 (09:44 +0200)]
Fix resizing images in Safari
Fixes #3506

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Wed, 12 Aug 2020 16:22:56 +0000 (18:22 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent username overflow in the message sidebar
Marcel Werk [Wed, 12 Aug 2020 16:22:37 +0000 (18:22 +0200)]
Prevent username overflow in the message sidebar

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Wed, 12 Aug 2020 15:51:54 +0000 (17:51 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent changes to the showOrder setting of system boxes during an update
Marcel Werk [Wed, 12 Aug 2020 15:51:25 +0000 (17:51 +0200)]
Prevent changes to the showOrder setting of system boxes during an update

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Wed, 12 Aug 2020 15:47:22 +0000 (17:47 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent changes to the visibility settings of system boxes during an update/upgrade
Alexander Ebert [Wed, 29 Jan 2020 13:38:56 +0000 (14:38 +0100)]
Prevent changes to the visibility settings of system boxes during an update/upgrade

4 years agoMerge pull request #3502 from Krymonota/timing-safe-comparison-social-login
Tim Düsterhus [Wed, 12 Aug 2020 14:13:05 +0000 (16:13 +0200)]
Merge pull request #3502 from Krymonota/timing-safe-comparison-social-login

Use timing safe comparison to validate `state` parameter for social login

4 years agoFix type of `options` parameter in HTTPRequest PHPDoc (#3504)
Niklas [Wed, 12 Aug 2020 14:08:29 +0000 (16:08 +0200)]
Fix type of `options` parameter in HTTPRequest PHPDoc (#3504)

4 years agoUse timing safe comparison to validate `state` parameter for social login
Niklas (Krymonota) [Wed, 12 Aug 2020 13:59:26 +0000 (15:59 +0200)]
Use timing safe comparison to validate `state` parameter for social login

The Twitter social login is left out because the implementation still uses OAuth 1.0, which does not support the `state` parameter.

Closes #3501

4 years agoAdd missing phrases to English 3rd party register language items
Niklas [Tue, 11 Aug 2020 16:16:41 +0000 (18:16 +0200)]
Add missing phrases to English 3rd party register language items

4 years agoMerge pull request #3499 from WoltLab/5.2-like-rebuild-data-fix
Joshua Rüsweg [Tue, 11 Aug 2020 09:32:34 +0000 (11:32 +0200)]
Merge pull request #3499 from WoltLab/5.2-like-rebuild-data-fix

Fix calculation the cached reactions

4 years agoUse proper placeholders for fetching the reactions
joshuaruesweg [Mon, 10 Aug 2020 16:36:49 +0000 (18:36 +0200)]
Use proper placeholders for fetching the reactions

4 years agoFix calculation the cached reactions
joshuaruesweg [Mon, 10 Aug 2020 15:57:26 +0000 (17:57 +0200)]
Fix calculation the cached reactions

4 years agoMerge pull request #3498 from WoltLab/dbo-action-php-8
Tim Düsterhus [Mon, 10 Aug 2020 15:19:21 +0000 (17:19 +0200)]
Merge pull request #3498 from WoltLab/dbo-action-php-8

Fix bogus call to `call_user_func_array` in AbstractDBOAction::validateAction()

4 years agoFix bogus call to `call_user_func_array` in AbstractDBOAction::validateAction()
Tim Düsterhus [Mon, 10 Aug 2020 14:16:37 +0000 (16:16 +0200)]
Fix bogus call to `call_user_func_array` in AbstractDBOAction::validateAction()

Fixes #3490

4 years agoRemove superfluous `array_unique` call
joshuaruesweg [Fri, 7 Aug 2020 13:43:27 +0000 (15:43 +0200)]
Remove superfluous `array_unique` call
No double value can occur in the array. When deleting, we already check if the object still exists in our file array and delete it only if it really still exists.

4 years agoFix return value of sort callback in TemplateListPage
Tim Düsterhus [Fri, 7 Aug 2020 09:56:58 +0000 (11:56 +0200)]
Fix return value of sort callback in TemplateListPage

Found using PHP 8's new warning:

> Message: uasort(): Returning bool from comparison function is deprecated,
> return an integer less than, equal to, or greater than zero

4 years agoFix PHP 8 compatibility for WCFSetup's error handler
Tim Düsterhus [Fri, 7 Aug 2020 09:31:45 +0000 (11:31 +0200)]
Fix PHP 8 compatibility for WCFSetup's error handler

see 0267fa9af7e18aa6449726f748e672cdac192d12

4 years agoAdded missing informal variant
Marcel Werk [Thu, 6 Aug 2020 14:25:45 +0000 (16:25 +0200)]
Added missing informal variant

4 years agoMerge pull request #3466 from Sir-Will/patch-1
Marcel Werk [Wed, 5 Aug 2020 16:49:12 +0000 (18:49 +0200)]
Merge pull request #3466 from Sir-Will/patch-1

Fixes exception when not using primary PayPal email

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 5 Aug 2020 14:21:45 +0000 (16:21 +0200)]
Merge branch '3.1' into 5.2

4 years agoFix PHP 5.5 compatibility
Tim Düsterhus [Wed, 5 Aug 2020 14:17:16 +0000 (16:17 +0200)]
Fix PHP 5.5 compatibility

see b044815dd9b6509fc44219684d7076cd28a80aa6
see #3480

4 years agoVerify if business argument is set in PayPal callback
Sir-Will [Wed, 5 Aug 2020 13:51:26 +0000 (15:51 +0200)]
Verify if business argument is set in PayPal callback

4 years agoFix handling of hidden form field values via AJAX
Matthias Schmidt [Wed, 5 Aug 2020 13:48:58 +0000 (15:48 +0200)]
Fix handling of hidden form field values via AJAX

See #3053

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 5 Aug 2020 10:57:22 +0000 (12:57 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3462 from SoftCreatR/patch-14
Alexander Ebert [Wed, 5 Aug 2020 10:56:18 +0000 (12:56 +0200)]
Merge pull request #3462 from SoftCreatR/patch-14

Add detection for Chromium based Edge browser

4 years agoMerge pull request #3471 from WoltLab/disable-spider-visit-tracking
Alexander Ebert [Wed, 5 Aug 2020 10:51:35 +0000 (12:51 +0200)]
Merge pull request #3471 from WoltLab/disable-spider-visit-tracking

Disable visit tracking for search engines

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 5 Aug 2020 10:06:26 +0000 (12:06 +0200)]
Merge branch '3.1' into 5.2

4 years agoDo not decrement wcf1_user.articles when deleting unpublished articles
Tim Düsterhus [Wed, 5 Aug 2020 10:05:08 +0000 (12:05 +0200)]
Do not decrement wcf1_user.articles when deleting unpublished articles

see b044815dd9b6509fc44219684d7076cd28a80aa6
see #3480

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Wed, 5 Aug 2020 09:59:38 +0000 (11:59 +0200)]
Merge branch '3.1' into 5.2

4 years agoUpdate wcf1_user.articles when deleting articles
Tim Düsterhus [Wed, 5 Aug 2020 09:58:13 +0000 (11:58 +0200)]
Update wcf1_user.articles when deleting articles

Fixes #3480

4 years agoAdded detection for Chromium based Edge browser
Sascha Greuel [Sun, 26 Jul 2020 15:19:00 +0000 (17:19 +0200)]
Added detection for Chromium based Edge browser

4 years agoAdd note, that the page.xml PIP instruction is needed with the next update
joshuaruesweg [Mon, 3 Aug 2020 16:23:12 +0000 (18:23 +0200)]
Add note, that the page.xml PIP instruction is needed with the next update
See #3474

4 years agoMerge branch '3.1'
joshuaruesweg [Mon, 3 Aug 2020 16:14:59 +0000 (18:14 +0200)]
Merge branch '3.1'

4 years agoFix updating `requireObjectID` for existing pages
joshuaruesweg [Mon, 3 Aug 2020 16:12:07 +0000 (18:12 +0200)]
Fix updating `requireObjectID` for existing pages

4 years agoThe `data-user-id` is already set by the ReactionHandler
Alexander Ebert [Sat, 1 Aug 2020 15:22:54 +0000 (17:22 +0200)]
The `data-user-id` is already set by the ReactionHandler

Fixes #3463

4 years agoPrevent writes to the session rather than reads
Alexander Ebert [Fri, 31 Jul 2020 15:10:25 +0000 (17:10 +0200)]
Prevent writes to the session rather than reads

4 years agoDisable visit tracking for search engines
Alexander Ebert [Fri, 31 Jul 2020 11:40:14 +0000 (13:40 +0200)]
Disable visit tracking for search engines

4 years agoRevert "Whitelist `unserialize()` when running in enterprise mode"
Tim Düsterhus [Thu, 30 Jul 2020 09:26:47 +0000 (11:26 +0200)]
Revert "Whitelist `unserialize()` when running in enterprise mode"

`unserialize()` is unsafe, because it potentially allows for arbitrary
code execution.

This reverts commit 564ba8525e42c9d4677ee1ddac58c4c9c67fc113.

4 years agoInclude PayPal business email in exception
Sir-Will [Tue, 28 Jul 2020 17:09:30 +0000 (19:09 +0200)]
Include PayPal business email in exception

4 years agoFixes exception when not using primary PayPal email
Sir-Will [Tue, 28 Jul 2020 00:57:32 +0000 (02:57 +0200)]
Fixes exception when not using primary PayPal email

PayPal allows adding multiple emails, if you are using one of the alternative emails instead of the primary email then WoltLab will throw the exception.
The `receiver_email` is always the primary email while `business` is the secondary in the IPN.

4 years agoClear language cache when clearing cronjob cache
Matthias Schmidt [Mon, 27 Jul 2020 16:44:45 +0000 (18:44 +0200)]
Clear language cache when clearing cronjob cache

Close #3465

4 years agoInvalid suffix value caused an error when rendering the form
Marcel Werk [Thu, 23 Jul 2020 10:30:53 +0000 (12:30 +0200)]
Invalid suffix value caused an error when rendering the form

4 years agoApproved `uniqid` for the use when running in enterprise mode
Alexander Ebert [Sun, 19 Jul 2020 16:04:42 +0000 (18:04 +0200)]
Approved `uniqid` for the use when running in enterprise mode

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sat, 18 Jul 2020 13:30:10 +0000 (15:30 +0200)]
Merge branch '3.1' into 5.2

4 years agoMoved the remark on the cleanup script
Alexander Ebert [Sat, 18 Jul 2020 13:29:14 +0000 (15:29 +0200)]
Moved the remark on the cleanup script

4 years agoMerge pull request #3450 from WoltLab/cms-embedded-object-remove
Alexander Ebert [Sat, 18 Jul 2020 13:28:13 +0000 (15:28 +0200)]
Merge pull request #3450 from WoltLab/cms-embedded-object-remove

Removed embedded object references when deleting articles / pages

4 years agoAdd update_com.woltlab.wcf_embeddedObjectOrphans.php
Tim Düsterhus [Fri, 17 Jul 2020 12:12:28 +0000 (14:12 +0200)]
Add update_com.woltlab.wcf_embeddedObjectOrphans.php

4 years agoAdd note about deletion of orphaned embedded objects
Tim Düsterhus [Fri, 17 Jul 2020 09:36:44 +0000 (11:36 +0200)]
Add note about deletion of orphaned embedded objects

see #3429

4 years agoRemove embedded object references when deleting pages
Tim Düsterhus [Fri, 17 Jul 2020 09:32:27 +0000 (11:32 +0200)]
Remove embedded object references when deleting pages

see #3429

4 years agoRemove embedded object references when deleting articles
Tim Düsterhus [Fri, 17 Jul 2020 09:25:24 +0000 (11:25 +0200)]
Remove embedded object references when deleting articles

see #3429

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Thu, 16 Jul 2020 09:26:21 +0000 (11:26 +0200)]
Merge branch '3.1' into 5.2

4 years agoFix PHP 5.5 compatibility
Tim Düsterhus [Thu, 16 Jul 2020 09:25:48 +0000 (11:25 +0200)]
Fix PHP 5.5 compatibility

4 years agoFix copy and paste bug
Tim Düsterhus [Thu, 16 Jul 2020 09:24:05 +0000 (11:24 +0200)]
Fix copy and paste bug

see 3cd8f5f63c1327c1534a4e24908b3e49d4074871

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Thu, 16 Jul 2020 08:42:45 +0000 (10:42 +0200)]
Merge branch '3.1' into 5.2

4 years agoProperly update page search index when editing
Tim Düsterhus [Thu, 16 Jul 2020 08:41:09 +0000 (10:41 +0200)]
Properly update page search index when editing

see #3430

4 years agoProperly update article search index when editing
Tim Düsterhus [Thu, 16 Jul 2020 08:40:38 +0000 (10:40 +0200)]
Properly update article search index when editing

see #3430

4 years agoMerge branch '3.1' into 5.2
Marcel Werk [Tue, 14 Jul 2020 17:09:42 +0000 (19:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoImproved detection of the links to twitch's clips
Marcel Werk [Tue, 14 Jul 2020 17:09:26 +0000 (19:09 +0200)]
Improved detection of the links to twitch's clips

4 years agoFix VoidFormDataProcessor for `null` values
Matthias Schmidt [Tue, 14 Jul 2020 13:31:19 +0000 (15:31 +0200)]
Fix VoidFormDataProcessor for `null` values

4 years agoRelease 5.2.8 5.2.8
Alexander Ebert [Mon, 13 Jul 2020 11:14:17 +0000 (13:14 +0200)]
Release 5.2.8

4 years agoUpdating minified JavaScript files
woltlab.com [Mon, 13 Jul 2020 11:06:11 +0000 (11:06 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 13 Jul 2020 10:59:40 +0000 (12:59 +0200)]
Merge branch '3.1' into 5.2

4 years agoRelease 3.1.16 3.1.16
Alexander Ebert [Mon, 13 Jul 2020 10:59:02 +0000 (12:59 +0200)]
Release 3.1.16

4 years agoAdd close callback to form builder dialog
Matthias Schmidt [Fri, 10 Jul 2020 16:04:47 +0000 (18:04 +0200)]
Add close callback to form builder dialog

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 9 Jul 2020 19:11:02 +0000 (19:11 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Thu, 9 Jul 2020 19:09:02 +0000 (21:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent Chromium browser form injecting base64 encoded images
Alexander Ebert [Thu, 9 Jul 2020 19:08:44 +0000 (21:08 +0200)]
Prevent Chromium browser form injecting base64 encoded images

4 years agoFix button class for single media form field
Matthias Schmidt [Wed, 8 Jul 2020 12:24:07 +0000 (14:24 +0200)]
Fix button class for single media form field

4 years agoFix duplicate data handler registration for captcha form fields
Matthias Schmidt [Wed, 8 Jul 2020 12:08:30 +0000 (14:08 +0200)]
Fix duplicate data handler registration for captcha form fields

Close #3441

4 years agoFixed error message in Form Builder
Peter Frühwirt [Wed, 8 Jul 2020 06:39:53 +0000 (08:39 +0200)]
Fixed error message in Form Builder

4 years agoWhitelist `unserialize()` when running in enterprise mode
Alexander Ebert [Tue, 7 Jul 2020 16:26:16 +0000 (18:26 +0200)]
Whitelist `unserialize()` when running in enterprise mode

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 7 Jul 2020 13:09:04 +0000 (15:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3439 from WoltLab/cronjob-fix2
Tim Düsterhus [Tue, 7 Jul 2020 13:07:09 +0000 (15:07 +0200)]
Merge pull request #3439 from WoltLab/cronjob-fix2

Fix calculation of nextExec of cronjobs

4 years agoFix calculation of nextExec of cronjobs
Tim Düsterhus [Tue, 7 Jul 2020 12:26:20 +0000 (14:26 +0200)]
Fix calculation of nextExec of cronjobs

To properly calculate nextExec we must not specify the TIME_NOW parameter,
because if the cronjob is run on the scheduled time the nextExec() will
return the current time.

Not passing the TIME_NOW parameter adds at least 120 seconds of delay to
prevent this issue.

This bug was introduced in commit 485f8e1888824b862823de983e019afcb9bca7ce.
When moving the update of the execution time the calls were not correctly
moved and the explicit passing of TIME_NOW was added.

4 years agoRelease 5.2.8
Alexander Ebert [Mon, 6 Jul 2020 15:53:12 +0000 (17:53 +0200)]
Release 5.2.8

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Mon, 6 Jul 2020 15:21:01 +0000 (17:21 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3428 from WoltLab/url-is
Tim Düsterhus [Mon, 6 Jul 2020 15:20:12 +0000 (17:20 +0200)]
Merge pull request #3428 from WoltLab/url-is

Fix Url::is()

4 years agoCaptcha setting was not considered
Marcel Werk [Mon, 6 Jul 2020 12:16:33 +0000 (14:16 +0200)]
Captcha setting was not considered

4 years agoUpdating minified JavaScript files
woltlab.com [Mon, 6 Jul 2020 11:25:05 +0000 (11:25 +0000)]
Updating minified JavaScript files

4 years agoRemoved misleading description
Marcel Werk [Mon, 6 Jul 2020 09:57:40 +0000 (11:57 +0200)]
Removed misleading description

4 years agoMissing module setting check
Marcel Werk [Mon, 6 Jul 2020 09:57:14 +0000 (11:57 +0200)]
Missing module setting check

4 years agoFixed parameter validation
Marcel Werk [Mon, 6 Jul 2020 09:56:56 +0000 (11:56 +0200)]
Fixed parameter validation

4 years agoMerge pull request #3435 from xopez/patch-1
Alexander Ebert [Fri, 3 Jul 2020 23:03:22 +0000 (01:03 +0200)]
Merge pull request #3435 from xopez/patch-1

Remove unused Packageservers for 5.2

4 years agoUpdate install.sql
xopez [Fri, 3 Jul 2020 18:00:39 +0000 (20:00 +0200)]
Update install.sql