Marcel Werk [Tue, 16 May 2023 13:12:23 +0000 (15:12 +0200)]
Fix typescript issue
Marcel Werk [Tue, 16 May 2023 12:53:31 +0000 (14:53 +0200)]
Apply suggestions from code review
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Marcel Werk [Tue, 16 May 2023 12:25:49 +0000 (14:25 +0200)]
Improve search form ux
If a user uses the search function within a certain area (e.g. subforum or thread), only the corresponding area will be searched. If the search does not return any results in this case, the "advanced filter" area in the search form is collapsed and therefore not directly visible to the user that advanced filters are active.
Alexander Ebert [Tue, 16 May 2023 11:39:37 +0000 (13:39 +0200)]
Add color variants to the template diff for the dark mode
See #5362
Alexander Ebert [Tue, 16 May 2023 11:30:41 +0000 (13:30 +0200)]
Improve the CSS for the editor history and add dark mode support
See #5362
Tim Düsterhus [Tue, 16 May 2023 08:43:20 +0000 (10:43 +0200)]
Update composer dependencies
Alexander Ebert [Mon, 15 May 2023 15:59:29 +0000 (17:59 +0200)]
Unify the appearance of new and legacy dialogs
Fixes #5507
Alexander Ebert [Mon, 15 May 2023 13:00:33 +0000 (15:00 +0200)]
Fix the rendering of buttons in the visual editor
There was no gap between buttons on smaller screen sizes.
Alexander Ebert [Mon, 15 May 2023 12:56:46 +0000 (14:56 +0200)]
Update the visual style editor for status elements
Alexander Ebert [Mon, 15 May 2023 12:53:45 +0000 (14:53 +0200)]
Update the color palette for CKEditor
Fixes #5485
Tim Düsterhus [Mon, 15 May 2023 12:08:47 +0000 (14:08 +0200)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Mon, 15 May 2023 12:08:37 +0000 (14:08 +0200)]
Merge branch '5.5'
Alexander Ebert [Mon, 15 May 2023 11:42:36 +0000 (13:42 +0200)]
Reintroduce the relative position of message overlay icons
See WoltLab/com.woltlab.wbb#593
Regression of
f116ee6cad7c05a5f007af6b95c8b9bec2b3379d
Alexander Ebert [Mon, 15 May 2023 11:39:12 +0000 (13:39 +0200)]
Add a spacer for notices above the editor
Fixes WoltLab/com.woltlab.wbb#592
Alexander Ebert [Mon, 15 May 2023 11:38:48 +0000 (13:38 +0200)]
Improve the visuals of the editor while being initialized
Alexander Ebert [Mon, 15 May 2023 11:23:51 +0000 (13:23 +0200)]
Fix the appearance of code boxes using the dark color scheme
Fixes #5502
Tim Düsterhus [Mon, 15 May 2023 07:06:30 +0000 (09:06 +0200)]
Update composer dependencies
Alexander Ebert [Sun, 14 May 2023 16:47:58 +0000 (18:47 +0200)]
Fix the replacement of the pagination in the media manager
Fixes #5503
Alexander Ebert [Sun, 14 May 2023 15:04:10 +0000 (17:04 +0200)]
Remove the `vertical-align` from icons again
This was added to address #5090, but the root cause of the issue was something else. The added `vertical-align` did workaround the reported problem, but caused smaller icons to be misaligned, in particular 16px class icons where offset towards the top.
Alexander Ebert [Sun, 14 May 2023 14:55:16 +0000 (16:55 +0200)]
Add the phrase and permissions for media again
Fixes WoltLab/com.woltlab.wbb#596
Alexander Ebert [Sun, 14 May 2023 14:45:49 +0000 (16:45 +0200)]
Move the indicator badge 4px to the right
The width of the new icons has increased from 32px to 40px.
Fixes #5506
Alexander Ebert [Sun, 14 May 2023 14:42:25 +0000 (16:42 +0200)]
Fix CKEditor’s sticky toolbar
Fixes #5508
Alexander Ebert [Fri, 12 May 2023 16:27:19 +0000 (18:27 +0200)]
Release 5.5.12 dev 2
WoltLab [Fri, 12 May 2023 16:19:53 +0000 (16:19 +0000)]
Updating minified JavaScript files
Alexander Ebert [Fri, 12 May 2023 15:01:31 +0000 (17:01 +0200)]
Release 5.5.12 dev 1
Tim Düsterhus [Fri, 12 May 2023 09:02:39 +0000 (11:02 +0200)]
Merge pull request #5505 from WoltLab/mailbox-types
Add proper types to Mailbox
Tim Düsterhus [Fri, 12 May 2023 09:00:23 +0000 (11:00 +0200)]
Merge pull request #5504 from WoltLab/mailbox-name
Improve handling of Mailboxes with empty names
Tim Düsterhus [Fri, 12 May 2023 07:42:54 +0000 (09:42 +0200)]
Add proper types to Mailbox
Tim Düsterhus [Fri, 12 May 2023 07:37:40 +0000 (09:37 +0200)]
Do not emit empty names in Mailbox::__toString()
Likely depending on the MUA this will either emit the email address in the best
case or show an empty field. In any case, this will likely look a little odd to
spam filters and thus should be simplified to just the email address.
Tim Düsterhus [Fri, 12 May 2023 07:35:58 +0000 (09:35 +0200)]
Trim the human readable name of a Mailbox
Whitespace around the name is going to be a little wonky and this is in
preparation of a future change that detects and suppresses empty names.
Marcel Werk [Thu, 11 May 2023 09:54:54 +0000 (11:54 +0200)]
Merge pull request #5498 from WoltLab/webp-avatars
Fix handling of WebP avatars
Tim Düsterhus [Thu, 11 May 2023 08:01:50 +0000 (10:01 +0200)]
Fix syntax error in wysiwyg.tpl if editor is localized
Tim Düsterhus [Thu, 11 May 2023 07:53:49 +0000 (09:53 +0200)]
Alexander Ebert [Wed, 10 May 2023 19:34:28 +0000 (21:34 +0200)]
Adds support for configurable highlighters to CKEditor
Fixes WoltLab/editor#46
Alexander Ebert [Wed, 10 May 2023 15:12:14 +0000 (17:12 +0200)]
Rebuild the CKEditor 5 bundle
Alexander Ebert [Wed, 10 May 2023 15:11:30 +0000 (17:11 +0200)]
Add support for images floating to the left
See WoltLab/editor#51
Alexander Ebert [Wed, 10 May 2023 13:43:18 +0000 (15:43 +0200)]
Convert floating images in CKEditor into `<figure>`
See WoltLab/editor#51
Alexander Ebert [Wed, 10 May 2023 13:36:19 +0000 (15:36 +0200)]
Rename the Cleanup module for CKEditor to `Normalizer`
Alexander Ebert [Wed, 10 May 2023 13:34:39 +0000 (15:34 +0200)]
Add support for floating images
See WoltLab/editor#51
Tim Düsterhus [Wed, 10 May 2023 13:25:38 +0000 (15:25 +0200)]
Drop the SameSite attribute from the XSRF-Token cookie to work around WebKit Bug 255524
It appears that Safari 16.4+ sometimes loses SameSite cookies without explicit
expiry when performing subrequests, e.g. to load JavaScript or when using
`fetch()`. The conditions apply to the XSRF-Token cookie. Now if one of the
subrequests hits the application, the application will hand out a fresh
XSRF-Token cookie, due to the cookie being missing. This results in spurious
changes of the XSRF-Token and thus error messages for the user.
According to comments in the WebKit Bug a workaround for the issue is not
providing a SameSite attribute at all and we leverage this workaround for the
time being: The SameSite attribute on the XSRF-Token cookie is a defense in
depth measure.
see https://bugs.webkit.org/show_bug.cgi?id=255524
see https://www.woltlab.com/community/thread/299769-fehlerhafter-xsrf-token/
Alexander Ebert [Wed, 10 May 2023 12:13:20 +0000 (14:13 +0200)]
Add support for floated images again
This was unintentionally removed when purging the files for Redactor.
Tim Düsterhus [Wed, 10 May 2023 11:56:04 +0000 (13:56 +0200)]
Merge branch '5.5'
Tim Düsterhus [Wed, 10 May 2023 11:54:05 +0000 (13:54 +0200)]
Update @types/google.maps
Tim Düsterhus [Wed, 10 May 2023 11:51:05 +0000 (13:51 +0200)]
Update tabbable
Tim Düsterhus [Wed, 10 May 2023 11:50:13 +0000 (13:50 +0200)]
Update esbuild
Tim Düsterhus [Wed, 10 May 2023 11:35:34 +0000 (13:35 +0200)]
Merge branch '5.5'
Tim Düsterhus [Wed, 10 May 2023 11:32:58 +0000 (13:32 +0200)]
Merge pull request #5501 from WoltLab/contentInteraction-print
Hide `.contentInteraction` in print CSS
Tim Düsterhus [Wed, 10 May 2023 10:21:22 +0000 (12:21 +0200)]
Hide `.contentInteraction` in print CSS
Tim Düsterhus [Wed, 10 May 2023 08:25:01 +0000 (10:25 +0200)]
Remove the reference to WCF.Poll.js in template
see
12e1aa4fe4b01fd1b77598d6eef6ceba8cb095c3
Tim Düsterhus [Wed, 10 May 2023 08:13:00 +0000 (10:13 +0200)]
Mark the first time setup as completed on upgrade
Resolves #5500
Alexander Ebert [Tue, 9 May 2023 15:49:27 +0000 (17:49 +0200)]
Discard the autosave draft when resetting the editor
Fixes #5462
Alexander Ebert [Tue, 9 May 2023 14:19:41 +0000 (16:19 +0200)]
Fix the retrieval of the contents of a CKEditor form field
Fixes #5480
Alexander Ebert [Tue, 9 May 2023 13:44:07 +0000 (15:44 +0200)]
Reset the poll editor on editor reset
Fixes #5492
Alexander Ebert [Tue, 9 May 2023 13:43:47 +0000 (15:43 +0200)]
Allow the `No` field variants of the poll editor to be absent
Alexander Ebert [Tue, 9 May 2023 13:16:14 +0000 (15:16 +0200)]
Replace the negative margin hack of share buttons with `gap`
Fixes #5489
Alexander Ebert [Tue, 9 May 2023 13:13:27 +0000 (15:13 +0200)]
Explicitly provide a value for `$float` for the media BBCode
Fixes #5486
Alexander Ebert [Tue, 9 May 2023 13:11:56 +0000 (15:11 +0200)]
Strip the `margin-top` of the first section in dialogs
Fixes #5484
Marcel Werk [Tue, 9 May 2023 11:28:13 +0000 (13:28 +0200)]
Fix handling of WebP avatars
Closes #5264
Marcel Werk [Tue, 9 May 2023 10:19:10 +0000 (12:19 +0200)]
Merge branch '5.5'
Marcel Werk [Tue, 9 May 2023 10:18:34 +0000 (12:18 +0200)]
Merge pull request #5496 from WoltLab/avatar-validation
Fix multiple validation issues during the avatar upload
Tim Düsterhus [Tue, 9 May 2023 09:04:09 +0000 (11:04 +0200)]
Fix search submit button in pageHeaderSearch
Fixes #5488
Alexander Ebert [Mon, 8 May 2023 18:52:02 +0000 (20:52 +0200)]
Improve the visuals for the search bar on tablets
Fixes #5490
Alexander Ebert [Mon, 8 May 2023 17:10:37 +0000 (19:10 +0200)]
Upcast `[wsm]` BBCode
See WoltLab/editor#47
Alexander Ebert [Mon, 8 May 2023 16:37:02 +0000 (18:37 +0200)]
Merge pull request #5474 from WoltLab/ckeditor-true-paragraph
Enforce true paragraphs in CKEditor
Alexander Ebert [Mon, 8 May 2023 16:20:44 +0000 (18:20 +0200)]
Fix the detection of `<p><br></p>`
Alexander Ebert [Mon, 8 May 2023 16:11:35 +0000 (18:11 +0200)]
Replace `<p>…</p>` with `<p>`
Alexander Ebert [Mon, 8 May 2023 14:33:26 +0000 (16:33 +0200)]
Sync the implementation of the number of paragraphs marked for removal
Alexander Ebert [Mon, 8 May 2023 10:09:07 +0000 (12:09 +0200)]
Unify the clean up of trailing `<br>` in `<p>` and `<td>`
Alexander Ebert [Mon, 8 May 2023 10:05:44 +0000 (12:05 +0200)]
Replace the recursive call in `unwrapBr` with a loop
Alexander Ebert [Mon, 8 May 2023 10:00:04 +0000 (12:00 +0200)]
Make the normalizer reusable by passing in the `\DOMXPath` for `normalize()`
Alexander Ebert [Mon, 8 May 2023 09:58:09 +0000 (11:58 +0200)]
Simplify the code to calculate the number of paragraphs to retain
Alexander Ebert [Sat, 6 May 2023 19:35:48 +0000 (21:35 +0200)]
Port the improve HTML normalization form PHP to TS
Alexander Ebert [Sat, 6 May 2023 19:18:36 +0000 (21:18 +0200)]
Improve the normalization of legacy messages
Alexander Ebert [Fri, 5 May 2023 10:04:50 +0000 (12:04 +0200)]
Suppress margins for the first/last child of a table cell
Alexander Ebert [Fri, 5 May 2023 09:58:26 +0000 (11:58 +0200)]
Unwrap `<br>` contained in `<del>`
Alexander Ebert [Fri, 5 May 2023 09:56:34 +0000 (11:56 +0200)]
Strip trailing `<br>` in `<td>`
Alexander Ebert [Thu, 4 May 2023 19:10:27 +0000 (21:10 +0200)]
Unwrap and strip trailing `<br>`
Alexander Ebert [Thu, 4 May 2023 17:44:35 +0000 (19:44 +0200)]
Clean up the markup passed to CKEditor
Alexander Ebert [Thu, 4 May 2023 17:06:40 +0000 (19:06 +0200)]
Move the clean up of legacy messages into a separate module
Alexander Ebert [Thu, 4 May 2023 15:57:25 +0000 (17:57 +0200)]
Strip the `data-cke-fillter` attribute in the HTML output
Alexander Ebert [Thu, 4 May 2023 14:32:05 +0000 (16:32 +0200)]
Strip legacy spacer paragraphs when editing messages
Alexander Ebert [Thu, 4 May 2023 14:06:55 +0000 (16:06 +0200)]
Strip extra paragraph elements that were created in earlier versions
Alexander Ebert [Thu, 4 May 2023 14:00:28 +0000 (16:00 +0200)]
Add a proper margin to paragraphs
Alexander Ebert [Thu, 4 May 2023 13:57:40 +0000 (15:57 +0200)]
Flag empty paragraphs as editor generated
Marcel Werk [Mon, 8 May 2023 15:18:26 +0000 (17:18 +0200)]
Fix validation of the image file type
Previously it was possible to upload any image (e.g. bmp) as avatars using a faked file extension.
Marcel Werk [Mon, 8 May 2023 15:15:40 +0000 (17:15 +0200)]
Proper handling of the case that no image was uploaded
Tim Düsterhus [Mon, 8 May 2023 14:30:05 +0000 (16:30 +0200)]
Merge pull request #5495 from WoltLab/application-management-wcf-force-landing-page
Enforce the selection of a landing page for WoltLab Suite Core in applicationManagement
Tim Düsterhus [Mon, 8 May 2023 14:26:53 +0000 (16:26 +0200)]
Improve readability of conditions in applicationManagement.tpl
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Mon, 8 May 2023 14:13:52 +0000 (16:13 +0200)]
Enforce the selection of a landing page for WoltLab Suite Core in applicationManagement
This is enforced in the template only, because the PHP logic already needs to
handle a NULL landing page, as the global landing page could be deleted or
uninstalled. It will implicitly fall back to the ArticleList then.
Resolves #4843
Tim Düsterhus [Mon, 8 May 2023 12:48:34 +0000 (14:48 +0200)]
Update composer dependencies
Tim Düsterhus [Mon, 8 May 2023 12:29:21 +0000 (14:29 +0200)]
Merge pull request #5494 from WoltLab/domutil-types
Add proper types to DOMUtil
Tim Düsterhus [Mon, 8 May 2023 12:18:18 +0000 (14:18 +0200)]
Merge pull request #5493 from WoltLab/poll-isPublic
Show the “pollIsPublic” setting when editing polls
Tim Düsterhus [Mon, 8 May 2023 11:59:30 +0000 (13:59 +0200)]
Show the “pollIsPublic” setting when editing polls
The checkbox is marked as disabled, as the setting may not be changed after the
fact.
Tim Düsterhus [Mon, 8 May 2023 11:09:29 +0000 (13:09 +0200)]
Add proper types to DOMUtil
Marcel Werk [Mon, 8 May 2023 10:54:08 +0000 (12:54 +0200)]
Merge pull request #5481 from WoltLab/tagged-page
Improve usability of the `TaggedPage`
Tim Düsterhus [Mon, 8 May 2023 10:11:22 +0000 (12:11 +0200)]
Fix titlecasing of “with” in page.xml (6.0)
Tim Düsterhus [Mon, 8 May 2023 10:10:32 +0000 (12:10 +0200)]
Merge branch '5.5'
Tim Düsterhus [Mon, 8 May 2023 10:09:37 +0000 (12:09 +0200)]
Fix titlecasing of “with” in page.xml
Tim Düsterhus [Mon, 8 May 2023 07:23:36 +0000 (09:23 +0200)]
Merge branch '5.5'
Tim Düsterhus [Mon, 8 May 2023 07:19:21 +0000 (09:19 +0200)]
Fix wcf.acp.rebuildData.com.woltlab.wcf.activityPoint*
see https://www.woltlab.com/community/thread/299762-language-wcf-acp-rebuilddata-com-woltlab-wcf-activitypointevent/