GitHub/WoltLab/WCF.git
4 months agoMake it easier to find a form field from a FormBuilder form
Marcel Werk [Wed, 3 Jul 2024 12:04:26 +0000 (14:04 +0200)]
Make it easier to find a form field from a FormBuilder form

Basically, it is just a wrapper around `getNodeById()`, which also checks whether it is a `IFormField`.

4 months agoReduce icon size in account security
Marcel Werk [Tue, 2 Jul 2024 15:35:45 +0000 (17:35 +0200)]
Reduce icon size in account security

Closes #5930

4 months agoLabel for received reaction shortened
Marcel Werk [Mon, 1 Jul 2024 15:11:30 +0000 (17:11 +0200)]
Label for received reaction shortened

"Reactions received" is too long for use in the user card.

4 months agoFix broken `HtmlNodeUnfurlLink.class.php`
Marcel Werk [Fri, 28 Jun 2024 12:05:08 +0000 (14:05 +0200)]
Fix broken `HtmlNodeUnfurlLink.class.php`

The file was merged incorrectly by this commit:
https://github.com/WoltLab/WCF/commit/7966721e4709d792180fb05a693cafd8db0e2793

4 months agoMerge pull request #5805 from WoltLab/service-worker-notifications
Olaf Braun [Tue, 25 Jun 2024 11:47:37 +0000 (13:47 +0200)]
Merge pull request #5805 from WoltLab/service-worker-notifications

Add service worker for push notifications

4 months agoUpgrade composer packages
Cyperghost [Tue, 25 Jun 2024 11:43:48 +0000 (13:43 +0200)]
Upgrade composer packages
  `web-token/jwt-library` to `3.3.50`
  `spomky-labs/pki-framework` to `1.2.1`

4 months agoUpgrade composer packages
Cyperghost [Tue, 25 Jun 2024 10:19:09 +0000 (12:19 +0200)]
Upgrade composer packages
  `web-token/jwt-library` to `3.3.50`
  `spomky-labs/pki-framework` to `1.2.1`

4 months agoNew indent `composer.json`
Olaf Braun [Mon, 24 Jun 2024 13:13:35 +0000 (15:13 +0200)]
New indent `composer.json`

4 months agoMerge branch 'refs/heads/master' into service-worker-notifications
Olaf Braun [Mon, 24 Jun 2024 12:57:36 +0000 (14:57 +0200)]
Merge branch 'refs/heads/master' into service-worker-notifications

# Conflicts:
# wcfsetup/install/files/lib/system/api/composer.json
# wcfsetup/install/files/lib/system/api/composer.lock
# wcfsetup/install/files/lib/system/api/composer/installed.php

4 months agoMerge pull request #5949 from WoltLab/require-https
Alexander Ebert [Mon, 24 Jun 2024 10:45:01 +0000 (12:45 +0200)]
Merge pull request #5949 from WoltLab/require-https

Make HTTPS a hard requirement

4 months agoUpdated the composer dependencies
Alexander Ebert [Mon, 24 Jun 2024 10:21:54 +0000 (12:21 +0200)]
Updated the composer dependencies

4 months agoMerge branch '6.0'
Alexander Ebert [Mon, 24 Jun 2024 10:19:30 +0000 (12:19 +0200)]
Merge branch '6.0'

4 months agoFix the search of errors by exception id
Alexander Ebert [Mon, 24 Jun 2024 10:18:19 +0000 (12:18 +0200)]
Fix the search of errors by exception id

The non-recursive variant of the `DirectoryUtil` returns a plain list of filenames rather than the pathname.

See #5932

4 months agoUpdate `minishlink/web-push` to `v9.0.0-rc2`
Cyperghost [Mon, 24 Jun 2024 08:30:47 +0000 (10:30 +0200)]
Update `minishlink/web-push` to `v9.0.0-rc2`

4 months agoMerge branch 'refs/heads/master' into service-worker-notifications
Cyperghost [Mon, 24 Jun 2024 08:25:10 +0000 (10:25 +0200)]
Merge branch 'refs/heads/master' into service-worker-notifications

# Conflicts:
# wcfsetup/install/files/acp/database/update_com.woltlab.wcf_6.1.php

4 months agoEnable the Sandbox for Templates Inside of BBCodes
Alexander Ebert [Sun, 23 Jun 2024 11:35:09 +0000 (13:35 +0200)]
Enable the Sandbox for Templates Inside of BBCodes

See #5910

5 months agoRename endpoint classes to match the naming schema
Alexander Ebert [Sat, 22 Jun 2024 18:03:51 +0000 (20:03 +0200)]
Rename endpoint classes to match the naming schema

5 months agoAdd a preflight script for the upgrade from 6.0
Alexander Ebert [Sat, 22 Jun 2024 17:32:11 +0000 (19:32 +0200)]
Add a preflight script for the upgrade from 6.0

5 months agoRedirect insecure requests to the frontend
Alexander Ebert [Sat, 22 Jun 2024 17:23:51 +0000 (19:23 +0200)]
Redirect insecure requests to the frontend

5 months agoAdd the TLS check to the test script
Alexander Ebert [Sat, 22 Jun 2024 13:50:56 +0000 (15:50 +0200)]
Add the TLS check to the test script

5 months agoApply the code formatter to the test script
Alexander Ebert [Sat, 22 Jun 2024 13:40:41 +0000 (15:40 +0200)]
Apply the code formatter to the test script

5 months agoPromote HTTPS from being a recommendation to an requirement
Alexander Ebert [Sat, 22 Jun 2024 13:39:09 +0000 (15:39 +0200)]
Promote HTTPS from being a recommendation to an requirement

5 months agoAdd a check for the secure context on the index page
Alexander Ebert [Sat, 22 Jun 2024 13:28:58 +0000 (15:28 +0200)]
Add a check for the secure context on the index page

5 months agoVerify the HTTPS support within the system check
Alexander Ebert [Sat, 22 Jun 2024 12:43:04 +0000 (14:43 +0200)]
Verify the HTTPS support within the system check

5 months agoRemove files for the upgrade 5.5 → 6.0
Alexander Ebert [Sat, 22 Jun 2024 12:08:12 +0000 (14:08 +0200)]
Remove files for the upgrade 5.5 → 6.0

5 months agoAdd a workaround for the migration of the spider data
Alexander Ebert [Sat, 22 Jun 2024 12:07:51 +0000 (14:07 +0200)]
Add a workaround for the migration of the spider data

Fixes #5941

5 months agoRemove files for the upgrade 5.5 → 6.0
Alexander Ebert [Sat, 22 Jun 2024 12:02:34 +0000 (14:02 +0200)]
Remove files for the upgrade 5.5 → 6.0

5 months agoUnify phrases
Marcel Werk [Fri, 21 Jun 2024 14:42:06 +0000 (16:42 +0200)]
Unify phrases

5 months agoAdd a chunk-based progress tracking
Alexander Ebert [Fri, 21 Jun 2024 12:46:27 +0000 (14:46 +0200)]
Add a chunk-based progress tracking

There will be no progress bar if there is only a single chunk to be uploaded.

5 months agoImprove visuals of selects when used in the sidebar
Marcel Werk [Thu, 20 Jun 2024 13:58:05 +0000 (15:58 +0200)]
Improve visuals of selects when used in the sidebar

Closes #5924

5 months ago`\ini_parse_quantity()` is provided by the Symfony polyfill
Alexander Ebert [Thu, 20 Jun 2024 10:50:25 +0000 (12:50 +0200)]
`\ini_parse_quantity()` is provided by the Symfony polyfill

This reintroduces the changes made in 76b16ba4e89a7ff46cc2e1f79a158afc1c5e4c40 which was reverted in 5d52de11b680078012eba04ae983058e6086b7d7 due to a bug in an earlier version of Symphony’s polyfill.

5 months agoUpdate the Composer dependencies
Alexander Ebert [Thu, 20 Jun 2024 10:48:35 +0000 (12:48 +0200)]
Update the Composer dependencies

5 months agoMerge branch '6.0'
Alexander Ebert [Wed, 19 Jun 2024 12:51:28 +0000 (14:51 +0200)]
Merge branch '6.0'

5 months agoRelease 6.0.16 6.0.16
Alexander Ebert [Wed, 19 Jun 2024 10:38:49 +0000 (12:38 +0200)]
Release 6.0.16

5 months agoMerge branch '5.5' into 6.0
Alexander Ebert [Wed, 19 Jun 2024 10:37:24 +0000 (12:37 +0200)]
Merge branch '5.5' into 6.0

5 months agoRelease 5.5.22 5.5.22
Alexander Ebert [Wed, 19 Jun 2024 10:31:51 +0000 (12:31 +0200)]
Release 5.5.22

5 months agoMerge branch '5.4' into 5.5
Alexander Ebert [Wed, 19 Jun 2024 10:30:58 +0000 (12:30 +0200)]
Merge branch '5.4' into 5.5

5 months agoRelease 5.4.34 5.4.34 5.4.final
Alexander Ebert [Wed, 19 Jun 2024 10:23:32 +0000 (12:23 +0200)]
Release 5.4.34

5 months agoFix the missing error message
Alexander Ebert [Wed, 19 Jun 2024 10:23:03 +0000 (12:23 +0200)]
Fix the missing error message

5 months agoCheck for disallowed BB codes in the content
Cyperghost [Mon, 17 Jun 2024 10:27:59 +0000 (12:27 +0200)]
Check for disallowed BB codes in the content

5 months agoMerge pull request #5946 from WoltLab/bugfix/article-bb-code-permission
Olaf Braun [Tue, 18 Jun 2024 17:01:07 +0000 (19:01 +0200)]
Merge pull request #5946 from WoltLab/bugfix/article-bb-code-permission

Check for disallowed BB codes in the content

5 months agoRelease 6.0.15 6.0.15
Alexander Ebert [Tue, 18 Jun 2024 15:38:15 +0000 (17:38 +0200)]
Release 6.0.15

5 months agoRemove SVG from the list of safe file extensions
Alexander Ebert [Tue, 18 Jun 2024 09:20:32 +0000 (11:20 +0200)]
Remove SVG from the list of safe file extensions

Serving SVG from untrusted sources directly can be a security issue. SVG can contain JavaScript code that is executed when the file is opened in a standalone tab.

5 months agoMerge pull request #5944 from WoltLab/comment-backend-overhaul
Marcel Werk [Mon, 17 Jun 2024 12:52:19 +0000 (14:52 +0200)]
Merge pull request #5944 from WoltLab/comment-backend-overhaul

Comment backend overhaul

5 months agoMerge pull request #5945 from WoltLab/bugfix/signature-attachment
Olaf Braun [Mon, 17 Jun 2024 12:51:04 +0000 (14:51 +0200)]
Merge pull request #5945 from WoltLab/bugfix/signature-attachment

Extra check that the user also has the right to upload attachment when editing a user

5 months agoAdd link to migration guide
Marcel Werk [Mon, 17 Jun 2024 12:50:33 +0000 (14:50 +0200)]
Add link to migration guide

5 months agoMerge pull request #5947 from WoltLab/delete-files-after-attachment-deleted
Olaf Braun [Mon, 17 Jun 2024 12:25:34 +0000 (14:25 +0200)]
Merge pull request #5947 from WoltLab/delete-files-after-attachment-deleted

Also delete the associated file when an attachment is deleted

5 months agoAlso delete the associated file when an attachment is deleted
Cyperghost [Mon, 17 Jun 2024 11:29:42 +0000 (13:29 +0200)]
Also delete the associated file when an attachment is deleted

5 months agoCheck for disallowed BB codes in the content
Cyperghost [Mon, 17 Jun 2024 10:27:59 +0000 (12:27 +0200)]
Check for disallowed BB codes in the content

5 months agoAlso check that the current user has the right to upload file attachments
Cyperghost [Mon, 17 Jun 2024 10:08:36 +0000 (12:08 +0200)]
Also check that the current user has the right to upload file attachments

5 months agoSimplify the generation of HTML node identifiers
Alexander Ebert [Sun, 16 Jun 2024 11:31:00 +0000 (13:31 +0200)]
Simplify the generation of HTML node identifiers

We do not to generate completely random identifiers, the original intention was to prevent collisions with existing tag names.

Using a per-request random prefix together with a counter is sufficient to generate unique tag names without paying the CSPRNG tax for ever node.

5 months agoRemove obsolete code
Marcel Werk [Sun, 16 Jun 2024 11:30:09 +0000 (13:30 +0200)]
Remove obsolete code

5 months agoFix indentation
Marcel Werk [Sun, 16 Jun 2024 11:29:57 +0000 (13:29 +0200)]
Fix indentation

5 months agoIncrease the grace period for temporary attachments for logged-in users
Alexander Ebert [Sat, 15 Jun 2024 10:25:02 +0000 (12:25 +0200)]
Increase the grace period for temporary attachments for logged-in users

5 months agoRemove the additional secret for files
Alexander Ebert [Sat, 15 Jun 2024 10:13:47 +0000 (12:13 +0200)]
Remove the additional secret for files

It serves no real purpose. Guessing the SHA-256 hash is impossible due to entropy and if you *know* the hash then you pretty much know the file contents too.

There is no imaginable scenario where leaking the hash would not also leak the secret.

5 months agoMerge branch '6.0'
Alexander Ebert [Sat, 15 Jun 2024 09:42:10 +0000 (11:42 +0200)]
Merge branch '6.0'

5 months agoApply suggestions from code review
Marcel Werk [Fri, 14 Jun 2024 16:38:10 +0000 (18:38 +0200)]
Apply suggestions from code review

5 months agoRelease 6.0.15 dev 1 6.0.15_dev_1
Alexander Ebert [Fri, 14 Jun 2024 16:31:02 +0000 (18:31 +0200)]
Release 6.0.15 dev 1

5 months agoUpdating minified JavaScript files
WoltLab [Fri, 14 Jun 2024 16:18:07 +0000 (16:18 +0000)]
Updating minified JavaScript files

5 months agoAdd a proper error message for incompatible Plugin-Store packages
Alexander Ebert [Fri, 14 Jun 2024 11:26:59 +0000 (13:26 +0200)]
Add a proper error message for incompatible Plugin-Store packages

Fixes #5800
See https://www.woltlab.com/community/thread/306394-error-message-when-trying-to-install-a-package-by-storecode/

5 months agoFix phpdoc
Marcel Werk [Fri, 14 Jun 2024 11:02:06 +0000 (13:02 +0200)]
Fix phpdoc

5 months agoRemove obsolete guest dialog code
Marcel Werk [Fri, 14 Jun 2024 11:01:46 +0000 (13:01 +0200)]
Remove obsolete guest dialog code

5 months agoMade use of the new backend methods
Marcel Werk [Fri, 14 Jun 2024 11:01:30 +0000 (13:01 +0200)]
Made use of the new backend methods

5 months agoAdd typescript methods for requesting the new backend
Marcel Werk [Fri, 14 Jun 2024 11:00:51 +0000 (13:00 +0200)]
Add typescript methods for requesting the new backend

5 months agoAdd helper method to get a comment manager by id
Marcel Werk [Fri, 14 Jun 2024 10:56:19 +0000 (12:56 +0200)]
Add helper method to get a comment manager by id

5 months agoRemove/deprecate obsolete code
Marcel Werk [Fri, 14 Jun 2024 10:54:30 +0000 (12:54 +0200)]
Remove/deprecate obsolete code

5 months agoAdd RPC controller
Marcel Werk [Fri, 14 Jun 2024 10:54:06 +0000 (12:54 +0200)]
Add RPC controller

5 months agoAdd commands
Marcel Werk [Fri, 14 Jun 2024 10:53:14 +0000 (12:53 +0200)]
Add commands

5 months agoAdd PSR-14 events
Marcel Werk [Fri, 14 Jun 2024 10:50:28 +0000 (12:50 +0200)]
Add PSR-14 events

5 months agoFilter out restricted permissions in enterprise mode
Alexander Ebert [Fri, 14 Jun 2024 10:21:24 +0000 (12:21 +0200)]
Filter out restricted permissions in enterprise mode

5 months agoAdd a check that no attachment files have been deleted
Cyperghost [Fri, 14 Jun 2024 07:30:29 +0000 (09:30 +0200)]
Add a check that no attachment files have been deleted

5 months agoMake the URL filter a bit more lenient
Alexander Ebert [Thu, 13 Jun 2024 12:25:25 +0000 (14:25 +0200)]
Make the URL filter a bit more lenient

See https://www.woltlab.com/community/thread/305951-link-umwandlung-funktioniert-nicht-wenn-protokoll-im-text-steht/

5 months agoFix the overflow handling of the code box header
Alexander Ebert [Thu, 13 Jun 2024 12:02:31 +0000 (14:02 +0200)]
Fix the overflow handling of the code box header

See https://www.woltlab.com/community/thread/306288-erroneous-placement-of-icons-in-code-box-title-on-mobile/

5 months agoProperly handle possible NULL values for option values
Alexander Ebert [Thu, 13 Jun 2024 11:09:26 +0000 (13:09 +0200)]
Properly handle possible NULL values for option values

See https://www.woltlab.com/community/thread/306690-explode-passing-null-to-parameter-2-string-of-type-string-is-deprecated/

5 months agoPrevent scrolling when defocusing a reaction overlay
Alexander Ebert [Thu, 13 Jun 2024 11:02:19 +0000 (13:02 +0200)]
Prevent scrolling when defocusing a reaction overlay

See https://www.woltlab.com/community/thread/306559-scrolling-the-page-up-while-holding-the-reaction-button/

5 months agoNo longer add the description with the limits for uploading via the description....
Cyperghost [Thu, 13 Jun 2024 10:03:43 +0000 (12:03 +0200)]
No longer add the description with the limits for uploading via the description. This information is already available in the template

5 months agoIt Was only necessary for testing
Cyperghost [Thu, 13 Jun 2024 09:26:59 +0000 (11:26 +0200)]
It Was only necessary for testing

5 months agoMerge branch '6.0'
Alexander Ebert [Wed, 12 Jun 2024 12:40:14 +0000 (14:40 +0200)]
Merge branch '6.0'

5 months agoDo not focus the editor when resetting it
Alexander Ebert [Wed, 12 Jun 2024 12:39:48 +0000 (14:39 +0200)]
Do not focus the editor when resetting it

See https://www.woltlab.com/community/thread/306677-js-fehler-beim-antworten-auf-kommentare/

5 months agoFixes the problem if `maxHeight` and or `maxWidth` have the value `-1`. In this case...
Cyperghost [Wed, 12 Jun 2024 10:12:21 +0000 (12:12 +0200)]
Fixes the problem if `maxHeight` and or `maxWidth` have the value `-1`. In this case, the images were scaled anyway.

5 months agoFix wrong object type when deleting comment responses
Marcel Werk [Tue, 11 Jun 2024 13:10:02 +0000 (15:10 +0200)]
Fix wrong object type when deleting comment responses

5 months agoMerge pull request #5943 from WoltLab/bugfix/wysiwyg-form-field-attachment
Olaf Braun [Mon, 10 Jun 2024 10:08:13 +0000 (12:08 +0200)]
Merge pull request #5943 from WoltLab/bugfix/wysiwyg-form-field-attachment

Bugfix with WysiwygAttachmentFormField and FileProcessor

5 months agoMerge pull request #5942 from WoltLab/upload-pipeline-update-database
Olaf Braun [Mon, 10 Jun 2024 10:07:52 +0000 (12:07 +0200)]
Merge pull request #5942 from WoltLab/upload-pipeline-update-database

Add missing database columns for `wcf1_attachment`

5 months agoSimplify the usage of the helper function
Alexander Ebert [Mon, 10 Jun 2024 10:03:21 +0000 (12:03 +0200)]
Simplify the usage of the helper function

5 months agoFixes the problem that when using the WysiwygFormField with attachments, the `objectI...
Cyperghost [Mon, 10 Jun 2024 09:38:32 +0000 (11:38 +0200)]
Fixes the problem that when using the WysiwygFormField with attachments, the `objectID` can be `null` if it is not an EditForm.

5 months agoAdd missing database columns for `wcf1_attachment`, that are installed by the databas...
Cyperghost [Mon, 10 Jun 2024 08:51:30 +0000 (10:51 +0200)]
Add missing database columns for `wcf1_attachment`, that are installed by the database pip

5 months agoUse a helper function instead of a property
Alexander Ebert [Sun, 9 Jun 2024 19:53:59 +0000 (21:53 +0200)]
Use a helper function instead of a property

Using a property was a dumb idea because it breaks the promise of having the entire request data be made available through the parameters passed to `__invoke()`.

5 months agoFix the deletion of attachments through the file API
Alexander Ebert [Sun, 9 Jun 2024 19:28:59 +0000 (21:28 +0200)]
Fix the deletion of attachments through the file API

5 months agoAdd a helper attribute for object hydration
Alexander Ebert [Sun, 9 Jun 2024 19:25:20 +0000 (21:25 +0200)]
Add a helper attribute for object hydration

5 months agoRemove superfluous columns
Alexander Ebert [Sun, 9 Jun 2024 19:24:58 +0000 (21:24 +0200)]
Remove superfluous columns

Those columns were incorrectly copied and should not exist on `wcf1_file_temporary`.

5 months agoImprove the handling of server errors
Alexander Ebert [Sun, 9 Jun 2024 19:24:29 +0000 (21:24 +0200)]
Improve the handling of server errors

5 months agoMigrate the important workers to the linear rebuild worker
Alexander Ebert [Sun, 9 Jun 2024 10:56:24 +0000 (12:56 +0200)]
Migrate the important workers to the linear rebuild worker

5 months agoEnforce a consistent processing by id
Alexander Ebert [Sun, 9 Jun 2024 10:31:12 +0000 (12:31 +0200)]
Enforce a consistent processing by id

5 months agoMerge pull request #5939 from WoltLab/rebuild-html-performance
Alexander Ebert [Sat, 8 Jun 2024 11:46:04 +0000 (13:46 +0200)]
Merge pull request #5939 from WoltLab/rebuild-html-performance

Runtime and rebuild performance improvements

5 months agoMerge pull request #5940 from WoltLab/guest-token
Marcel Werk [Sat, 8 Jun 2024 11:45:24 +0000 (13:45 +0200)]
Merge pull request #5940 from WoltLab/guest-token

Guest tokens

5 months agoGuest tokens
Marcel Werk [Sat, 8 Jun 2024 11:34:57 +0000 (13:34 +0200)]
Guest tokens

5 months agoMerge branch '6.0'
Alexander Ebert [Sat, 8 Jun 2024 11:34:52 +0000 (13:34 +0200)]
Merge branch '6.0'

5 months agoMerge branch '5.5' into 6.0
Alexander Ebert [Sat, 8 Jun 2024 11:33:54 +0000 (13:33 +0200)]
Merge branch '5.5' into 6.0

5 months agoMerge pull request #5932 from SoftCreatR/bugfix/log-recursive
Alexander Ebert [Sat, 8 Jun 2024 11:33:15 +0000 (13:33 +0200)]
Merge pull request #5932 from SoftCreatR/bugfix/log-recursive

Disable log directory recursion

5 months agoChange template name to shared version
Marcel Werk [Sat, 8 Jun 2024 11:15:20 +0000 (13:15 +0200)]
Change template name to shared version