GitHub/WoltLab/WCF.git
4 years agoFixed code styling issues
Marcel Werk [Thu, 13 Feb 2020 23:36:33 +0000 (00:36 +0100)]
Fixed code styling issues

4 years agoFixed sql error when searching for articles
Marcel Werk [Thu, 13 Feb 2020 19:14:59 +0000 (20:14 +0100)]
Fixed sql error when searching for articles

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 13 Feb 2020 15:20:14 +0000 (16:20 +0100)]
Merge branch 'master' into next

4 years agoIncorrect data structure exposed to the push notification handler
Alexander Ebert [Thu, 13 Feb 2020 15:19:52 +0000 (16:19 +0100)]
Incorrect data structure exposed to the push notification handler

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 13 Feb 2020 10:33:11 +0000 (11:33 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Marcel Werk [Thu, 13 Feb 2020 10:14:31 +0000 (11:14 +0100)]
Merge branch '3.0'

4 years agoolder error logs were sometimes not deleted at the appropriate time
Marcel Werk [Thu, 13 Feb 2020 10:13:21 +0000 (11:13 +0100)]
older error logs were sometimes not deleted at the appropriate time

filectime may differ from filemtime

4 years agoEnable upload related classes for guests in accelerated mode
Alexander Ebert [Thu, 13 Feb 2020 09:38:52 +0000 (10:38 +0100)]
Enable upload related classes for guests in accelerated mode

These classes are required to support attachment in the contact form.

4 years agoDetect and report input validation errors in hidden tab menus
Alexander Ebert [Wed, 12 Feb 2020 12:59:32 +0000 (13:59 +0100)]
Detect and report input validation errors in hidden tab menus

4 years agoProperly handle userIDs referring to non-existent users in AbstractAuthedPage
Tim Düsterhus [Tue, 11 Feb 2020 10:32:41 +0000 (11:32 +0100)]
Properly handle userIDs referring to non-existent users in AbstractAuthedPage

This commit completes 33989f299121bfb3b82c40f3257f404fc23b3c1c.

4 years agoiOS Safari bug that cripples the editor after backspacing an empty instance
Alexander Ebert [Mon, 10 Feb 2020 17:56:23 +0000 (18:56 +0100)]
iOS Safari bug that cripples the editor after backspacing an empty instance

4 years agoImprove the email notification for logged errors
Marcel Werk [Mon, 10 Feb 2020 16:44:57 +0000 (17:44 +0100)]
Improve the email notification for logged errors

Closes #3157

4 years agoIncorrect detection of Shift+Enter in iOS Safari
Alexander Ebert [Mon, 10 Feb 2020 15:42:42 +0000 (16:42 +0100)]
Incorrect detection of Shift+Enter in iOS Safari

4 years agoMove the mobile reaction button back into the menu
Alexander Ebert [Mon, 10 Feb 2020 11:49:04 +0000 (12:49 +0100)]
Move the mobile reaction button back into the menu

The separate reaction button was a nice touch, but since it is generated on the fly, this caused the elements to increase their height. Eventually, browsers would to jump to anchors on load, but the reaction buttons would mess up the scroll location.

We should think about redesigning the mobile message view and start displaying at least some buttons. However, this could potentially cause incompatibilities with styles, therefore we need to postpone this to at least 5.3.

4 years agoMerge pull request #3156 from WoltLab/system-check-graphics-library
Alexander Ebert [Sun, 9 Feb 2020 20:20:52 +0000 (21:20 +0100)]
Merge pull request #3156 from WoltLab/system-check-graphics-library

Improve the system check during WCFSetup in regards to the graphics l…

4 years agoMerge pull request #3152 from Krymonota/add-reaction-alt-attribute
Alexander Ebert [Sun, 9 Feb 2020 20:19:59 +0000 (21:19 +0100)]
Merge pull request #3152 from Krymonota/add-reaction-alt-attribute

Add missing alt attribute to reaction type image

4 years agoAMP templates: Proper styling for quotes and message lists
Alexander Ebert [Sun, 9 Feb 2020 19:35:09 +0000 (20:35 +0100)]
AMP templates: Proper styling for quotes and message lists

4 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Sun, 9 Feb 2020 14:19:32 +0000 (15:19 +0100)]
Merge remote-tracking branch 'origin/master'

4 years agoMerge branch 'master' into next
Tim Düsterhus [Sun, 9 Feb 2020 14:19:15 +0000 (15:19 +0100)]
Merge branch 'master' into next

4 years agoMerge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Sun, 9 Feb 2020 14:18:12 +0000 (15:18 +0100)]
Merge branch 'master' of github.com:WoltLab/WCF

4 years agoImproved the paste results from MS Word
Alexander Ebert [Sun, 9 Feb 2020 14:17:33 +0000 (15:17 +0100)]
Improved the paste results from MS Word

Backport of b99034fb4bb799d0ca6f2aa46471b2221abadcfc

4 years agoMerge branch '3.0'
Tim Düsterhus [Sun, 9 Feb 2020 14:16:49 +0000 (15:16 +0100)]
Merge branch '3.0'

4 years agoChange empty phrase name exception type
Tim Düsterhus [Sun, 9 Feb 2020 14:15:14 +0000 (15:15 +0100)]
Change empty phrase name exception type

WoltLab Suite 5.2 already has a check for a category mismatch
that throws an Exception of type InvalidArgumentException. Change
this one for consistency.

see 9e280cb5c1dd3e398a3096b55f6d88be4baa6923
see e3d24f95b721e38ab205c89769c3b015aa43d75c

4 years agoMerge branch '3.0'
Tim Düsterhus [Sun, 9 Feb 2020 14:02:18 +0000 (15:02 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3158 from Krymonota/fix-veoh-privacy-policy-link-text
Tim Düsterhus [Sun, 9 Feb 2020 14:00:47 +0000 (15:00 +0100)]
Merge pull request #3158 from Krymonota/fix-veoh-privacy-policy-link-text

Fix Veoh privacy policy link text

4 years agoMerge pull request #3155 from SoftCreatR/patch-10
Tim Düsterhus [Sun, 9 Feb 2020 13:53:28 +0000 (14:53 +0100)]
Merge pull request #3155 from SoftCreatR/patch-10

Improve WhatsApp Message Sharing

4 years agoMerge branch '3.0'
Alexander Ebert [Sun, 9 Feb 2020 13:51:13 +0000 (14:51 +0100)]
Merge branch '3.0'

4 years agoFix Veoh privacy policy link text
Niklas (Krymonota) [Sat, 8 Feb 2020 20:47:01 +0000 (21:47 +0100)]
Fix Veoh privacy policy link text

Related to b6a668a61612802c098ceeb8070786a732607254.

4 years agoImprove the system check during WCFSetup in regards to the graphics library
Marcel Werk [Sat, 8 Feb 2020 19:46:42 +0000 (20:46 +0100)]
Improve the system check during WCFSetup in regards to the graphics library

Closes #3154

4 years agoSafeguard against phrases with empty names
Alexander Ebert [Sat, 8 Feb 2020 19:39:06 +0000 (20:39 +0100)]
Safeguard against phrases with empty names

4 years agoLimit size of images in content items
Marcel Werk [Sat, 8 Feb 2020 19:33:46 +0000 (20:33 +0100)]
Limit size of images in content items

4 years agoRemove some dangling attributes
Alexander Ebert [Sat, 8 Feb 2020 18:45:48 +0000 (19:45 +0100)]
Remove some dangling attributes

4 years agoDeprecated string offset in Net_IDNA2 (PHP 7.4)
Alexander Ebert [Mon, 27 Jan 2020 15:32:16 +0000 (16:32 +0100)]
Deprecated string offset in Net_IDNA2 (PHP 7.4)

4 years agoMerge branch 'next' of github.com:WoltLab/WCF into next
Alexander Ebert [Sat, 8 Feb 2020 14:56:29 +0000 (15:56 +0100)]
Merge branch 'next' of github.com:WoltLab/WCF into next

4 years agoExpose `getRemoveLinks()` in `BBCodeParser` for backwards compatibility
Alexander Ebert [Sat, 8 Feb 2020 14:56:19 +0000 (15:56 +0100)]
Expose `getRemoveLinks()` in `BBCodeParser` for backwards compatibility

4 years agoCopying user groups now returns the id of the new group
Alexander Ebert [Sat, 8 Feb 2020 14:55:55 +0000 (15:55 +0100)]
Copying user groups now returns the id of the new group

4 years agoRemove dialog HTML element when destroying dialog
Matthias Schmidt [Sat, 8 Feb 2020 14:35:03 +0000 (15:35 +0100)]
Remove dialog HTML element when destroying dialog

Fix #3148

4 years agoImproved WhatsApp Message Sharing
Sascha Greuel [Sat, 8 Feb 2020 13:04:22 +0000 (14:04 +0100)]
Improved WhatsApp Message Sharing

4 years agoMerge branch 'master' into next
Alexander Ebert [Fri, 7 Feb 2020 11:26:51 +0000 (12:26 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Alexander Ebert [Fri, 7 Feb 2020 11:26:33 +0000 (12:26 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3153 from SoftCreatR/patch-9
Alexander Ebert [Fri, 7 Feb 2020 11:26:01 +0000 (12:26 +0100)]
Merge pull request #3153 from SoftCreatR/patch-9

Remove Typehint

4 years agoUpdate CLIWCF.class.php
Sascha Greuel [Fri, 7 Feb 2020 01:39:29 +0000 (02:39 +0100)]
Update CLIWCF.class.php

4 years agoAdd missing alt attribute to reaction type image
Niklas (Krymonota) [Thu, 6 Feb 2020 23:27:35 +0000 (00:27 +0100)]
Add missing alt attribute to reaction type image

See: https://community.woltlab.com/thread/281417-reaktions-icons-alt-attribut-fehlt/

4 years agoPreparing the release 5.2.2 5.2.2
Alexander Ebert [Thu, 6 Feb 2020 18:09:41 +0000 (19:09 +0100)]
Preparing the release 5.2.2

4 years agoFixed missing consideration of the removeLinks parameter in bbcodes
Marcel Werk [Thu, 6 Feb 2020 17:42:56 +0000 (18:42 +0100)]
Fixed missing consideration of the removeLinks parameter in bbcodes

4 years agoMerge branch 'master' into next
Tim Düsterhus [Thu, 6 Feb 2020 17:16:18 +0000 (18:16 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 6 Feb 2020 17:15:47 +0000 (18:15 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3150 from Krymonota/fix-github-primary-email
Tim Düsterhus [Thu, 6 Feb 2020 17:14:51 +0000 (18:14 +0100)]
Merge pull request #3150 from Krymonota/fix-github-primary-email

Fix GitHub primary email not correctly being detected

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 6 Feb 2020 17:06:30 +0000 (17:06 +0000)]
Updating minified JavaScript files

4 years agoFix GitHub primary email not correctly being detected
Niklas (Krymonota) [Thu, 6 Feb 2020 17:01:13 +0000 (18:01 +0100)]
Fix GitHub primary email not correctly being detected

4 years agoMerge branch 'master' into next
Tim Düsterhus [Thu, 6 Feb 2020 16:44:45 +0000 (17:44 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 6 Feb 2020 16:43:19 +0000 (17:43 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3149 from Krymonota/update-github-auth
Tim Düsterhus [Thu, 6 Feb 2020 16:41:48 +0000 (17:41 +0100)]
Merge pull request #3149 from Krymonota/update-github-auth

Update GitHub authorization to use headers instead of query parameters

4 years agoUpdate GitHub authorization to use headers instead of query parameters
Niklas (Krymonota) [Thu, 6 Feb 2020 16:36:13 +0000 (17:36 +0100)]
Update GitHub authorization to use headers instead of query parameters

Using query parameters for access_token has been deprecated.

For further information, check out:
- https://community.woltlab.com/thread/281366-github-api-deprecation-notice-for-authentication-via-url-query-parameters/
- https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

4 years agoImproved scripting access
Alexander Ebert [Wed, 5 Feb 2020 17:16:18 +0000 (18:16 +0100)]
Improved scripting access

4 years agoImproved usability of the rewrite rules dialog
Marcel Werk [Wed, 5 Feb 2020 15:31:22 +0000 (16:31 +0100)]
Improved usability of the rewrite rules dialog

4 years agoFix active ACP menu item of BBCode media provider edit form
Matthias Schmidt [Tue, 4 Feb 2020 18:01:39 +0000 (19:01 +0100)]
Fix active ACP menu item of BBCode media provider edit form

4 years agoRequire length before setting decimals of DecimalDatabaseTableColumn
Matthias Schmidt [Tue, 4 Feb 2020 17:57:02 +0000 (18:57 +0100)]
Require length before setting decimals of DecimalDatabaseTableColumn

4 years agoDistinct class name for the "Search for Updates" button
Alexander Ebert [Mon, 3 Feb 2020 19:06:10 +0000 (20:06 +0100)]
Distinct class name for the "Search for Updates" button

4 years agoRevert "Add &display=swap to Google Font request"
Alexander Ebert [Mon, 3 Feb 2020 19:01:32 +0000 (20:01 +0100)]
Revert "Add &display=swap to Google Font request"

This reverts commit f869569107955803acf4625daab2f4e080f00f80.

The `font-display: swap` behaves quite different from the previous approach and causes a FOUT even on fast connections.
Changing the default behavior in a bugfix release doesn't feel right at this time, we should revisit this with 5.3.

4 years agoMerge pull request #3147 from WoltLab/request-sql-query-comment
Alexander Ebert [Sun, 2 Feb 2020 15:59:48 +0000 (16:59 +0100)]
Merge pull request #3147 from WoltLab/request-sql-query-comment

Add \wcf\getRequestId() to request information in SQL queries

4 years agoClean up generation of request information for SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 15:03:59 +0000 (16:03 +0100)]
Clean up generation of request information for SQL queries

4 years agoCache request information for SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 14:59:10 +0000 (15:59 +0100)]
Cache request information for SQL queries

4 years agoAdd \wcf\getRequestId() to request information in SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 14:57:27 +0000 (15:57 +0100)]
Add \wcf\getRequestId() to request information in SQL queries

4 years agoFix UserFormField value for empty fields
Matthias Schmidt [Sat, 1 Feb 2020 09:03:54 +0000 (10:03 +0100)]
Fix UserFormField value for empty fields

4 years agoUse function_exists to check for disabled functions
Marcel Werk [Fri, 31 Jan 2020 17:26:35 +0000 (18:26 +0100)]
Use function_exists to check for disabled functions

4 years agouse global namespace for opcache functions to improve the usefulness of error messages
Marcel Werk [Fri, 31 Jan 2020 17:26:18 +0000 (18:26 +0100)]
use global namespace for opcache functions to improve the usefulness of error messages

4 years agoAdded check for disabled opcache functions
Marcel Werk [Fri, 31 Jan 2020 17:14:02 +0000 (18:14 +0100)]
Added check for disabled opcache functions

4 years agoPreparing the release 5.2.2
Alexander Ebert [Thu, 30 Jan 2020 19:54:26 +0000 (20:54 +0100)]
Preparing the release 5.2.2

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 30 Jan 2020 17:32:24 +0000 (17:32 +0000)]
Updating minified JavaScript files

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 30 Jan 2020 16:39:05 +0000 (17:39 +0100)]
Merge branch 'master' into next

4 years agoIncorrect update path calculation if the only available version is not an exact match
Alexander Ebert [Thu, 30 Jan 2020 16:37:24 +0000 (17:37 +0100)]
Incorrect update path calculation if the only available version is not an exact match

4 years agoChanged layout of amp images to responsive
Marcel Werk [Thu, 30 Jan 2020 14:10:54 +0000 (15:10 +0100)]
Changed layout of amp images to responsive

4 years agoFixed typo
Marcel Werk [Thu, 30 Jan 2020 13:50:03 +0000 (14:50 +0100)]
Fixed typo

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Thu, 30 Jan 2020 13:37:14 +0000 (14:37 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoMerge pull request #3138 from netzhuffle/patch-2
Alexander Ebert [Thu, 30 Jan 2020 13:37:11 +0000 (14:37 +0100)]
Merge pull request #3138 from netzhuffle/patch-2

Add &display=swap to Google Font request

4 years agoremoved embedded videos from the dashboard to avoid truncated js code
Marcel Werk [Thu, 30 Jan 2020 13:37:06 +0000 (14:37 +0100)]
removed embedded videos from the dashboard to avoid truncated js code

4 years agoDisable the user edit button if there are no accessible actions
Alexander Ebert [Thu, 30 Jan 2020 13:30:13 +0000 (14:30 +0100)]
Disable the user edit button if there are no accessible actions

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Thu, 30 Jan 2020 13:27:40 +0000 (14:27 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoFixed broken hover state of the share buttons
Marcel Werk [Thu, 30 Jan 2020 13:27:38 +0000 (14:27 +0100)]
Fixed broken hover state of the share buttons

4 years agoDisable `transform: translate` when entering fullscreen mode in the editor
Alexander Ebert [Thu, 30 Jan 2020 12:41:40 +0000 (13:41 +0100)]
Disable `transform: translate` when entering fullscreen mode in the editor

The transform of `.anchorFixedHeader` introduces a new stacking context which will cause `position: fixed` inside to be relative to the container, instead of the document.

4 years agoDesktop notifications could not be turned off in multi-domain setup
Marcel Werk [Wed, 29 Jan 2020 21:57:23 +0000 (22:57 +0100)]
Desktop notifications could not be turned off in multi-domain setup

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Wed, 29 Jan 2020 21:49:43 +0000 (22:49 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoFixed inconsistent button labeling
Marcel Werk [Wed, 29 Jan 2020 21:49:33 +0000 (22:49 +0100)]
Fixed inconsistent button labeling

4 years agoInclude the overlaying page header in position calculations
Alexander Ebert [Wed, 29 Jan 2020 21:49:08 +0000 (22:49 +0100)]
Include the overlaying page header in position calculations

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Wed, 29 Jan 2020 21:46:46 +0000 (22:46 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoremoved potentially unreachable link
Marcel Werk [Wed, 29 Jan 2020 21:46:43 +0000 (22:46 +0100)]
removed potentially unreachable link

4 years agoPrevent changes to the visibility settings of system boxes during an update/upgrade
Alexander Ebert [Wed, 29 Jan 2020 13:38:56 +0000 (14:38 +0100)]
Prevent changes to the visibility settings of system boxes during an update/upgrade

4 years agoMerge branch 'master' into next
Marcel Werk [Tue, 28 Jan 2020 12:00:48 +0000 (13:00 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Marcel Werk [Tue, 28 Jan 2020 12:00:34 +0000 (13:00 +0100)]
Merge branch '3.0'

4 years agofixed issue that embedded videos were not aligned to the left
Marcel Werk [Tue, 28 Jan 2020 12:00:11 +0000 (13:00 +0100)]
fixed issue that embedded videos were not aligned to the left

4 years agoDeprecated string offset in Net_IDNA2 (PHP 7.4)
Alexander Ebert [Mon, 27 Jan 2020 15:32:16 +0000 (16:32 +0100)]
Deprecated string offset in Net_IDNA2 (PHP 7.4)

4 years agoIgnore validation errors for existing int columns with larger lengths
Matthias Schmidt [Sun, 26 Jan 2020 11:02:20 +0000 (12:02 +0100)]
Ignore validation errors for existing int columns with larger lengths

Close #3139

4 years agoFix smilies in wysiwyg form container for multiple smiley categories
Matthias Schmidt [Sun, 26 Jan 2020 09:21:39 +0000 (10:21 +0100)]
Fix smilies in wysiwyg form container for multiple smiley categories

4 years agoUse UTC instead of server timezone in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:17:23 +0000 (09:17 +0100)]
Use UTC instead of server timezone in DateFormField

4 years agoUse constants instead of hardcoded strings in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:16:51 +0000 (09:16 +0100)]
Use constants instead of hardcoded strings in DateFormField

4 years agoFix validation of earliest and latest date in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:14:23 +0000 (09:14 +0100)]
Fix validation of earliest and latest date in DateFormField

4 years agoUpdate documentation of DateFormField::supportsTime()
Matthias Schmidt [Sun, 26 Jan 2020 08:11:23 +0000 (09:11 +0100)]
Update documentation of DateFormField::supportsTime()

4 years agoFix reading existing poll's data in form builder
Matthias Schmidt [Sat, 25 Jan 2020 18:54:13 +0000 (19:54 +0100)]
Fix reading existing poll's data in form builder

4 years agoFix handling and validation of PollOptionsFormField's value
Matthias Schmidt [Sat, 25 Jan 2020 18:53:43 +0000 (19:53 +0100)]
Fix handling and validation of PollOptionsFormField's value