GitHub/moto-9609/android_kernel_motorola_exynos9610.git
7 years agoiio: common: st_sensors: fix channel data parsing
Lorenzo Bianconi [Wed, 16 Nov 2016 21:15:28 +0000 (22:15 +0100)]
iio: common: st_sensors: fix channel data parsing

Using realbits as i2c/spi read len, when that value is not byte aligned
(e.g 12 bits), lead to skip msb part of out data registers.
Fix this taking into account scan_type.shift in addition to
scan_type.realbits as read length:

read_len = DIV_ROUND_UP(realbits + shift, 8)

This fix has been tested on 8, 12, 16, 24 bit sensors

Fixes: e7385de5291e ("iio:st_sensors: align on storagebits boundaries")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: max44000: correct value in illuminance_integration_time_available
Akinobu Mita [Wed, 28 Dec 2016 17:16:36 +0000 (02:16 +0900)]
iio: max44000: correct value in illuminance_integration_time_available

According to the datasheet, the shortest available integration time for
ALS ADC conversion is 1.5625ms but illuminance_integration_time_available
sysfs file shows wrong value.

Cc: Crestez Dan Leonard <leonard.crestez@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Fixes: d5d8f49b6 ("max44000: Expose ambient sensor scaling")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: adc: TI_AM335X_ADC should depend on HAS_DMA
Geert Uytterhoeven [Wed, 14 Dec 2016 12:30:24 +0000 (13:30 +0100)]
iio: adc: TI_AM335X_ADC should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/iio/adc/ti_am335x_adc.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: f438b9da (" drivers: iio: ti_am335x_adc: add dma support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
7 years agoiio: bmi160: Fix time needed to sleep after command execution
Marcin Niestroj [Thu, 8 Dec 2016 14:22:58 +0000 (15:22 +0100)]
iio: bmi160: Fix time needed to sleep after command execution

Datasheet specifies typical and maximum execution times for which CMD
register is occupied after previous command execution. We took these
values as minimum and maximum time for usleep_range() call before making
a new command execution.

To be sure, that the CMD register is no longer occupied we need to wait
*at least* the maximum time specified by datasheet.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: 104-quad-8: Fix active level mismatch for the preset enable option
William Breathitt Gray [Tue, 29 Nov 2016 15:51:48 +0000 (10:51 -0500)]
iio: 104-quad-8: Fix active level mismatch for the preset enable option

The set_to_preset_on_index sysfs attribute provides a boolean
configuration option to enable a preset operation on the respective
channel's counter when Index occurs. However, the corresponding
configuration bit on the Input/Output Control register must be set low
to enable the preset operation.

This patch inverts the internal driver boolean logic exposed via the
set_to_preset_on_index attribute in order to correctly configure the
device which expects an active low bit.

Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: 104-quad-8: Fix off-by-one errors when addressing IOR
William Breathitt Gray [Mon, 28 Nov 2016 21:55:34 +0000 (16:55 -0500)]
iio: 104-quad-8: Fix off-by-one errors when addressing IOR

The Input/Output Control register (IOR) is offset by 1 from the
respective channel data register. This patch fixes off-by-one errors
when attempting to write to a channel IOR where the base address was not
properly offset.

Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: 104-quad-8: Fix index control configuration
William Breathitt Gray [Mon, 28 Nov 2016 21:22:44 +0000 (16:22 -0500)]
iio: 104-quad-8: Fix index control configuration

The LS7266R1 requires bits 5 & 6 to be high in order to select the Index
Control Register. This patch fixes a typo that incorrectly selects the
Input/Output Control Register where the Index Control Register was
desired.

Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agostaging: unisys: visorbus: Remove two passthrough postcode macros
Bryan Thompson [Thu, 1 Dec 2016 06:31:14 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove two passthrough postcode macros

Remove two passthrough macros that are only called from a single
location and make the resultant vmcall directly.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Remove POSTCODE_SEVERITY levels
Bryan Thompson [Thu, 1 Dec 2016 06:31:13 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove POSTCODE_SEVERITY levels

Use the already defined DIAG_SEVERITY values directly instead of special
postcode macro names.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Fix spelling error (FAIULRE to FAILURE)
Bryan Thompson [Thu, 1 Dec 2016 06:31:12 +0000 (01:31 -0500)]
staging: unisys: visorbus: Fix spelling error (FAIULRE to FAILURE)

There were two instances of FAILURE being misspelled in the s-Par
firmware postcode event enum that are fixed.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Remove unused values from guestlinuxdebug
Bryan Thompson [Thu, 1 Dec 2016 06:31:11 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove unused values from guestlinuxdebug

Remove guestlinuxdebug enum values that are no longer being used and
renumber remaining values accordingly.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Update visorchipset postcode values
Bryan Thompson [Thu, 1 Dec 2016 06:31:10 +0000 (01:31 -0500)]
staging: unisys: visorbus: Update visorchipset postcode values

The visorchipset.c functionality was moved into the visorbus driver
previously. This patch updates the s-Par firmware postcode values to
reflect this status.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Remove POSTCODE_LINUX_4 macro
Bryan Thompson [Thu, 1 Dec 2016 06:31:09 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove POSTCODE_LINUX_4 macro

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_4.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Remove POSTCODE_LINUX_3 macro
Bryan Thompson [Thu, 1 Dec 2016 06:31:08 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove POSTCODE_LINUX_3 macro

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_3.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Remove POSTCODE_LINUX_2 macro
Bryan Thompson [Thu, 1 Dec 2016 06:31:07 +0000 (01:31 -0500)]
staging: unisys: visorbus: Remove POSTCODE_LINUX_2 macro

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_2.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Use CURRENT_FILE_PC in base postcode macro
Bryan Thompson [Thu, 1 Dec 2016 06:31:06 +0000 (01:31 -0500)]
staging: unisys: visorbus: Use CURRENT_FILE_PC in base postcode macro

Use CURRENT_FILE_PC directly in the POSTCODE_LINUX macro instead of
relying on passthrough macros to provide it.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: Replace two base postcode macros with one
Bryan Thompson [Thu, 1 Dec 2016 06:31:05 +0000 (01:31 -0500)]
staging: unisys: visorbus: Replace two base postcode macros with one

Leverage the 3 existing s-Par postcode macros to do a bit more work
and provide only 1 base postcode macro.

Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: vbuschannel.h remove unused pound defines
Erik Arfvidson [Thu, 1 Dec 2016 06:31:04 +0000 (01:31 -0500)]
staging: unisys: visorbus: vbuschannel.h remove unused pound defines

This patch removes all the unused pound defines currently in
vbuschannel.h.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: vmcallinterface.h remove unused pound defines
Erik Arfvidson [Thu, 1 Dec 2016 06:31:03 +0000 (01:31 -0500)]
staging: unisys: visorbus: vmcallinterface.h remove unused pound defines

This patch removes all the unused pound defines currently in
vmcallinterface.h.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: remove sysfs files
Greg Kroah-Hartman [Wed, 30 Nov 2016 13:46:50 +0000 (14:46 +0100)]
staging: dgnc: remove sysfs files

The dgnc driver has no business creating "custom" sysfs files just for a
single tty driver.  Combined with the odd way they are created, it's
just a mess, so remove them entirely as I am tired of tripping over them
when doing driver core changes.

Cc: Lidza Louina <lidza.louina@gmail.com>
Cc: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: fix tabstop style warning
Andrea Ghittino [Tue, 29 Nov 2016 21:57:21 +0000 (22:57 +0100)]
staging: sm750fb: fix tabstop style warning

Fixes sm750fb tabstop style warning
found by checkpatch.pl tool

Signed-off-by: Andrea Ghittino <aghittino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: libcfs: repair improper unlikely test
James Simmons [Wed, 30 Nov 2016 01:33:33 +0000 (20:33 -0500)]
staging: lustre: libcfs: repair improper unlikely test

The scripts to replace NULL test got confused with the
macro parenthesis so the unlikely test in libcfs_private.h
ended up incorrect. This fixes this error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: fix spelling mistake of "outstanding"
Colin Ian King [Tue, 29 Nov 2016 19:06:58 +0000 (19:06 +0000)]
staging: unisys: fix spelling mistake of "outstanding"

Trivial fix to spelling mistake "oustanding" to "outstanding".

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: gdm724x: Remove one blank line in sequence
Dawid Kurek [Sat, 26 Nov 2016 10:51:00 +0000 (11:51 +0100)]
staging: gdm724x: Remove one blank line in sequence

Remove one blank line in sequence of two empty lines.

Signed-off-by: Dawid Kurek <dawikur@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: gdm724x: Align parameters to parenthesis
Dawid Kurek [Sat, 26 Nov 2016 10:43:25 +0000 (11:43 +0100)]
staging: gdm724x: Align parameters to parenthesis

Align parameters to open parenthesis.

Signed-off-by: Dawid Kurek <dawikur@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: fix a type issue in sm750_set_chip_type()
Dan Carpenter [Sat, 26 Nov 2016 10:20:58 +0000 (13:20 +0300)]
staging: sm750fb: fix a type issue in sm750_set_chip_type()

"revId" needs to be unsigned because we use it to test:

if (revId == SM750LE_REVISION_ID) {

and SM750LE_REVISION_ID is ((unsigned char )0xfe).

Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: update license
Sudip Mukherjee [Sat, 26 Nov 2016 09:07:42 +0000 (09:07 +0000)]
staging: sm750fb: update license

The driver was actually released with BSD license. It also gained GPL
when it was submitted to be included in the kernel.

Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: gzhou1 <guojian.zhou@windriver.com>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: slicoss: remove UPDATE_STATS_GB macro and inline code
Sergio Paracuellos [Thu, 24 Nov 2016 20:30:19 +0000 (21:30 +0100)]
staging: slicoss: remove UPDATE_STATS_GB macro and inline code

This patch removes UPDATE_STATS_GB macro in slic.h header file
and just inline code. This improve readability.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: slicoss: remove not used UPDATE_STATS macro
Sergio Paracuellos [Thu, 24 Nov 2016 20:30:18 +0000 (21:30 +0100)]
staging: slicoss: remove not used UPDATE_STATS macro

This patch remove UPDATE_STATS macro from
header slic.h which is not being used.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: ks7010: Fixed {} brace warnings for single statement blocks.
Yamanappagouda Patil [Thu, 24 Nov 2016 09:19:16 +0000 (14:49 +0530)]
Staging: ks7010: Fixed {} brace warnings for single statement blocks.

Fixed checkpatch.pl warnings related to {} brace warnings for single
statement blocks.

Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: most: Eliminate usage of symbolic permissions
Jason Litzinger [Fri, 25 Nov 2016 22:31:09 +0000 (15:31 -0700)]
staging: most: Eliminate usage of symbolic permissions

Fix checkpatch warnings regarding the use of symbolic permissions.

Where the MOST_CHANNEL_ATTR macro is used, convert to octal
permissions over symbolic.

Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.

Signed-off-by: Jason Litzinger <jlitzingerdev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: obd: reserve connection flag OBD_CONNECT_FLAGS2
Fan Yong [Wed, 23 Nov 2016 23:01:20 +0000 (18:01 -0500)]
staging: lustre: obd: reserve connection flag OBD_CONNECT_FLAGS2

This is a feature for the client and server to use
obd_connect_flags2 to communicate future feature flags. The
client should set this flag whenever any flags in that field
are requested, and the server should mask unsupported features
from this field (assuming it understands OBD_CONNECT_FLAGS2).
When checking if an OBD_CONNECT2_xxxx feature is supported,
the client/server needs to firstly check if OBD_CONNECT_FLAGS2
is supported, since this field is also beyond the end of the
old obd_connect_data.

Land the connection flags to upstream client earlier for reserving
the slot to avoid potential conflict with others.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7543
Reviewed-on: http://review.whamcloud.com/17647
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: obd: reserve connection flag OBD_CONNECT_OBDOPACK
Fan Yong [Wed, 23 Nov 2016 23:01:19 +0000 (18:01 -0500)]
staging: lustre: obd: reserve connection flag OBD_CONNECT_OBDOPACK

The connection flag OBD_CONNECT_OBDOPACK will be used for the
following the patch: LU-4215 optimize OUT protocol
http://review.whamcloud.com/15336

Land the connection flags to upstream client earlier for reserving
the slot to avoid potential conflict with others.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7543
Reviewed-on: http://review.whamcloud.com/17646
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: obd: reserve connection flag OBD_CONNECT_LOCK_AHEAD
Fan Yong [Wed, 23 Nov 2016 23:01:18 +0000 (18:01 -0500)]
staging: lustre: obd: reserve connection flag OBD_CONNECT_LOCK_AHEAD

The connection flag OBD_CONNECT_LOCK_AHEAD will be used for the
following the patch: LU-6917 LDLM lock ahead
http://review.whamcloud.com/13564

Land the connection flags to upstream client earlier for reserving
the slot to avoid potential conflict with others.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7543
Reviewed-on: http://review.whamcloud.com/17645
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: obd: reserve connection flag OBD_CONNECT_SUBTREE
Fan Yong [Wed, 23 Nov 2016 23:01:17 +0000 (18:01 -0500)]
staging: lustre: obd: reserve connection flag OBD_CONNECT_SUBTREE

The connection flag OBD_CONNECT_SUBTREE will be used for the
following the patch: LU-28 mounting of filesystem from MDS
http://review.whamcloud.com/5007

Land the connection flags to master earlier for reserving the
slot to avoid potential conflict with others.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7543
Reviewed-on: http://review.whamcloud.com/17644
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ldlm: change "int" to proper enum type
Andreas Dilger [Wed, 23 Nov 2016 22:59:51 +0000 (17:59 -0500)]
staging: lustre: ldlm: change "int" to proper enum type

Fix users of flags that were using "int" instead of named enum.
Rename some "flags" variables to distinguish between different flags.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: http://review.whamcloud.com/15300
Reviewed-on: http://review.whamcloud.com/15301
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ldlm: rename LDLM_CANCEL_* flags
Andreas Dilger [Wed, 23 Nov 2016 22:59:50 +0000 (17:59 -0500)]
staging: lustre: ldlm: rename LDLM_CANCEL_* flags

Rename LDLM_CANCEL_* flags (used with enum ldlm_lru_flags) to
LDLM_LRU_FLAGS_* to avoid confusion with enum ldlm_cancel_flags.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: http://review.whamcloud.com/15300
Reviewed-on: http://review.whamcloud.com/15301
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ldlm: remove ldlm_wire_policy_data_t typedef usage from code
Andreas Dilger [Wed, 23 Nov 2016 22:59:49 +0000 (17:59 -0500)]
staging: lustre: ldlm: remove ldlm_wire_policy_data_t typedef usage from code

Replace usage of ldlm_wire_policy_data_t with named enums
to conform to upstream coding style.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: http://review.whamcloud.com/15300
Reviewed-on: http://review.whamcloud.com/15301
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ldlm: remove ldlm_side_t typedef usage from code
Andreas Dilger [Wed, 23 Nov 2016 22:59:48 +0000 (17:59 -0500)]
staging: lustre: ldlm: remove ldlm_side_t typedef usage from code

Replace usage of ldlm_side_t with named enums
to conform to upstream coding style.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: http://review.whamcloud.com/15300
Reviewed-on: http://review.whamcloud.com/15301
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: ldlm: remove ldlm_policy_data_t typedef usage from code
Andreas Dilger [Wed, 23 Nov 2016 22:59:47 +0000 (17:59 -0500)]
staging: lustre: ldlm: remove ldlm_policy_data_t typedef usage from code

Replace usage of ldlm_policy_data_t with named enums
to conform to upstream coding style.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: http://review.whamcloud.com/15300
Reviewed-on: http://review.whamcloud.com/15301
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: frank zago <fzago@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: lnet: memory corruption in selftest
Dan Carpenter [Thu, 24 Nov 2016 11:10:39 +0000 (14:10 +0300)]
staging: lustre: lnet: memory corruption in selftest

We want sizeof(struct lstcon_node) but instead we're getting the sizeof
a pointer.

Fixes: 8d78f0f2ba76 ("staging: lustre: lnet: cleanup some of the > 80 line issues")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre/ptlrpc: small leak on allocation failure
Dan Carpenter [Thu, 24 Nov 2016 11:12:04 +0000 (14:12 +0300)]
staging: lustre/ptlrpc: small leak on allocation failure

We should free "desc" before returning NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoMerge tag 'iio-for-4.10d' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Mon, 28 Nov 2016 07:26:16 +0000 (08:26 +0100)]
Merge tag 'iio-for-4.10d' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

Fourth set of IIO new device support, features and cleaups for the 4.10 cycle.

Probably the final set before the merge window unless things get significantly
delayed.

New device support
* STM32 ADC core
  - new driver.  Interesting device with up to 3 ADCs with complex triggering
    options that will follow later. Note split into an 'mfd like' core that
    handles the interrupt sharing etc between the various instances present and
    a per ADC section that is instantiated as many times as needed.
  - device tree bindings.

Cleanups and minor fixes
* st_accel
  - inline per sensor data as the defines don't add any meaning and make it
    much harder to check if a given sensor has the right values.
* hid-magnetometer
  - sort out the associations of the associated attributes with the two types.

8 years agoiio: magnetometer: separate the values of attributes based on their usage type for...
Ooi, Joyce [Wed, 16 Nov 2016 09:43:09 +0000 (17:43 +0800)]
iio: magnetometer: separate the values of attributes based on their usage type for HID compass sensor

There are 2 usage types (Magnetic Flux and Heading data field) for HID
compass sensor, thus the values of offset, scale, and sensitivity should
be separated according to their respective usage type. The changes made
are as below:
1. Hysteresis: A struct hid_sensor_common rot_attributes is created in
struct magn_3d_state to contain the sensitivity for IIO_ROT.
2. Scale: scale_pre_decml and scale_post_decml are separated for IIO_MAGN
and IIO_ROT.
3. Offset: Same as scale, value_offset is separated for IIO_MAGN and
IIO_ROT.

For sensitivity, HID_USAGE_SENSOR_ORIENT_MAGN_FLUX and
HID_USAGE_SENSOR_ORIENT_MAGN_HEADING are used for sensivitity fields based
on the HID Sensor Usages specifications. Hence, these changes are added on
the sensitivity field.

Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: tsl2583: make array large enough
Dan Carpenter [Thu, 24 Nov 2016 13:38:07 +0000 (16:38 +0300)]
iio: tsl2583: make array large enough

This array is supposed to have 10 elements.  Smatch complains that with
the current code we can have n == max_ints and read beyond the end of
the array.

Fixes: ac4f6eee8fe8 ("staging: iio: TAOS tsl258x: Device driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agostaging: speakup: speakup_soft.c Align parenthesis
Walt Feasel [Mon, 21 Nov 2016 15:19:25 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c Align parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_soft.c comment modifications
Walt Feasel [Mon, 21 Nov 2016 15:19:24 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c comment modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_soft.c Blank line after {
Walt Feasel [Mon, 21 Nov 2016 15:19:23 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c Blank line after {

Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary after an
open brace '{'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_soft.c Multiple blank lines
Walt Feasel [Mon, 21 Nov 2016 15:19:22 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c Multiple blank lines

Make suggested checkpatch modification for
CHECK: Please don't use multiple blank lines

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_soft.c Logical continuation
Walt Feasel [Mon, 21 Nov 2016 15:19:21 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c Logical continuation

Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_soft.c Space around operator
Walt Feasel [Mon, 21 Nov 2016 15:19:20 +0000 (10:19 -0500)]
staging: speakup: speakup_soft.c Space around operator

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_spkout.c Space around operator
Walt Feasel [Mon, 21 Nov 2016 15:17:53 +0000 (10:17 -0500)]
staging: speakup: speakup_spkout.c Space around operator

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_spkout.c comment modifications
Walt Feasel [Mon, 21 Nov 2016 15:17:52 +0000 (10:17 -0500)]
staging: speakup: speakup_spkout.c comment modifications

Make modifications to comments

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_txprt.c Spaces preferred around operator
Walt Feasel [Mon, 21 Nov 2016 15:14:47 +0000 (10:14 -0500)]
staging: speakup: speakup_txprt.c Spaces preferred around operator

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: speakup_txprt.c Comment modifications
Walt Feasel [Mon, 21 Nov 2016 15:14:46 +0000 (10:14 -0500)]
staging: speakup: speakup_txprt.c Comment modifications

Make modifications to comments

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: spk_priv_keyinfo.h Space around operator
Walt Feasel [Mon, 21 Nov 2016 15:13:16 +0000 (10:13 -0500)]
staging: speakup: spk_priv_keyinfo.h Space around operator

Make suggested checkpatch modification for
CHECK: spaces preferred around that '+'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: spk_priv_keyinfo.h align columns
Walt Feasel [Mon, 21 Nov 2016 15:13:15 +0000 (10:13 -0500)]
staging: speakup: spk_priv_keyinfo.h align columns

Make modifications to align columns

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: spk_types.h Align parenthesis
Walt Feasel [Mon, 21 Nov 2016 15:11:25 +0000 (10:11 -0500)]
staging: speakup: spk_types.h Align parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: spk_types.h Comment modifications
Walt Feasel [Mon, 21 Nov 2016 15:11:24 +0000 (10:11 -0500)]
staging: speakup: spk_types.h Comment modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: emxx_udc: emxx_udc.c Align parenthesis
Walt Feasel [Mon, 21 Nov 2016 15:05:51 +0000 (10:05 -0500)]
staging: emxx_udc: emxx_udc.c Align parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: emxx_udc: emxx_udc.c Spaces preferred around operators
Walt Feasel [Mon, 21 Nov 2016 15:05:50 +0000 (10:05 -0500)]
staging: emxx_udc: emxx_udc.c Spaces preferred around operators

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: emxx_udc: emxx_udc.c {} Single statement blocks
Walt Feasel [Mon, 21 Nov 2016 15:05:49 +0000 (10:05 -0500)]
staging: emxx_udc: emxx_udc.c {} Single statement blocks

Make suggested checkpatch modification for
WARNING: braces {} are not necessary for single
statement blocks

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: emxx_udc: emxx_udc.c Logical continuation
Walt Feasel [Mon, 21 Nov 2016 15:05:48 +0000 (10:05 -0500)]
staging: emxx_udc: emxx_udc.c Logical continuation

Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: emxx_udc: emxx_udc.c Blank lines after {
Walt Feasel [Mon, 21 Nov 2016 15:05:47 +0000 (10:05 -0500)]
staging: emxx_udc: emxx_udc.c Blank lines after {

Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary after an
open brace '{'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: bus_configure add error handling
David Kershner [Mon, 21 Nov 2016 17:15:53 +0000 (12:15 -0500)]
staging: unisys: visorbus: bus_configure add error handling

Add proper error handling to bus_configure and have it propagate errors
back up the stack. This helped to streamline the function as well.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: return EAGAIN when empty
David Kershner [Mon, 21 Nov 2016 17:15:52 +0000 (12:15 -0500)]
staging: unisys: visorbus: return EAGAIN when empty

It really isn't an error when you call visorchannel_signalremove and
there isn't anything in the queue. Just means that the IOSP didn't
process anything since the last time you checked. Just inform the
caller that it is empty by returning -EAGAIN.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: device_responder add error handling
David Kershner [Mon, 21 Nov 2016 17:15:51 +0000 (12:15 -0500)]
staging: unisys: visorbus: device_responder add error handling

The function controlvm_respond returns proper error handling, so now we
can propagate the error up and handle it appropriately.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: device_changestate_responder add error handling
David Kershner [Mon, 21 Nov 2016 17:15:50 +0000 (12:15 -0500)]
staging: unisys: visorbus: device_changestate_responder add error handling

Pass the error returned from visorchannel_signalinsert up the stack
instead of just ignoring it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: bus_responder add error handling
David Kershner [Mon, 21 Nov 2016 17:15:49 +0000 (12:15 -0500)]
staging: unisys: visorbus: bus_responder add error handling

Controlvm_respond now returns an error. Add error handling to the
bus_responder function.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: save_crash_message add error handling
David Kershner [Mon, 21 Nov 2016 17:15:48 +0000 (12:15 -0500)]
staging: unisys: visorbus: save_crash_message add error handling

Add proper error handling to the function save_crash_message.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: controlvm_respond_physdev_changestate add error handling
David Kershner [Mon, 21 Nov 2016 17:15:47 +0000 (12:15 -0500)]
staging: unisys: visorbus: controlvm_respond_physdev_changestate add error handling

Propagate the error up the stack instead of ignoring it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: controlvm_respond add error handling
David Kershner [Mon, 21 Nov 2016 17:15:46 +0000 (12:15 -0500)]
staging: unisys: visorbus: controlvm_respond add error handling

The function visorchanel_signalinsert now returns an error, propagate
the error up the stack to be handled.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: chipset_init add error handling
David Kershner [Mon, 21 Nov 2016 17:15:45 +0000 (12:15 -0500)]
staging: unisys: visorbus: chipset_init add error handling

Controlvm_respond_chipset_init now errors out correctly. Pass the errors
back up to the stack to be processed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: controlvm_respond_chipset_init add error handling
David Kershner [Mon, 21 Nov 2016 17:15:44 +0000 (12:15 -0500)]
staging: unisys: visorbus: controlvm_respond_chipset_init add error handling

Now that visorchannel_signalinsert returns a Linux error code, we need
to convert controlvm_respond_chipset_init to return an error instead of
a void.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: visorbus_private rename 'local' var to 'dest'
Erik Arfvidson [Mon, 21 Nov 2016 17:15:43 +0000 (12:15 -0500)]
staging: unisys: visorbus: visorbus_private rename 'local' var to 'dest'

This patch renames the poorly named 'local' var to 'dest' in
the visorbus_private.h file

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: visorbus: visorchannel.c rename 'local' variable to 'dest'
Erik Arfvidson [Mon, 21 Nov 2016 17:15:42 +0000 (12:15 -0500)]
staging: unisys: visorbus: visorchannel.c rename 'local' variable to 'dest'

This patch renames poorly named 'local' variable to 'dest'.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: fix pound defines
Erik Arfvidson [Mon, 21 Nov 2016 17:15:41 +0000 (12:15 -0500)]
staging: unisys: include: fix pound defines

The purpose of this patch is to add style consistency and
beautify the entire file. This patch removes unused pound defines
and cleans up spacing and tabbing of pound defines.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: unisys: include: fixed iochannel.h comments
Erik Arfvidson [Mon, 21 Nov 2016 17:15:40 +0000 (12:15 -0500)]
staging: unisys: include: fixed iochannel.h comments

The purpose of this patch is to add style consistency and beautify the
entire file.

Grammar:
Uppercased beginning of new sentences/paragraphs
Missing ' and .
Fixed several comments using prefix phrase "as is in" to "as in"
Standard Grammar

Comments:
Fixed comments to follow the multiline styling
All comments are now either same line or above variable/definitions
Removed nested slash-star comments
Removed a random comment left by accident
Aligned star comments

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: slicoss: change some macros into inline functions
Sergio Paracuellos [Mon, 21 Nov 2016 16:48:24 +0000 (17:48 +0100)]
staging: slicoss: change some macros into inline functions

This patch changes macros into inline functions to avoid this checkpatch
check:
Macro argument 'x' may be better as '(x)' to avoid precedence issues

It also removes two macros because they aren't being used.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8712: rtl871x_*: Removed unnecessary else statements after a break or...
Shiva Kerdel [Mon, 21 Nov 2016 09:12:41 +0000 (10:12 +0100)]
Staging: rtl8712: rtl871x_*: Removed unnecessary else statements after a break or return

The indent code blocks of the else statements were unnecessary
and are better written without them.

Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8712: Fix coding style warnings on Block comments
Vijai Kumar K [Mon, 21 Nov 2016 01:01:52 +0000 (17:01 -0800)]
staging: rtl8712: Fix coding style warnings on Block comments

Fixed checkpatch.pl warnings related to Block comments in
staging/rtl8712/*.c files.

Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging/lustre: Use proper number of bytes in copy_from_user
Jian Yu [Mon, 21 Nov 2016 05:46:48 +0000 (00:46 -0500)]
staging/lustre: Use proper number of bytes in copy_from_user

This patch removes the usage of MAX_STRING_SIZE from
copy_from_user() and just copies enough bytes to cover
count passed in.

Signed-off-by: Jian Yu <jian.yu@intel.com>
Reviewed-on: http://review.whamcloud.com/23462
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8774
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6656: Fix coding style warnings on Block comments
Vijai Kumar K [Sun, 20 Nov 2016 20:51:40 +0000 (12:51 -0800)]
staging: vt6656: Fix coding style warnings on Block comments

Fix checkpatch.pl warnings related to Block comments in
staging/vt6656/rf.c file.

Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6655: Fixed coding style warnings on Block comments
Vijai Kumar K [Sun, 20 Nov 2016 18:57:09 +0000 (10:57 -0800)]
staging: vt6655: Fixed coding style warnings on Block comments

Fixed checkpatch.pl warnings related to Block comments in
staging/vt6655/*.c files.

Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: dgnc_tty: Remove blank lines
Vijai Kumar K [Sun, 20 Nov 2016 18:39:23 +0000 (10:39 -0800)]
staging: dgnc: dgnc_tty: Remove blank lines

Fixes checkpatch warning: waitqueue_active without comment

Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: skein: threefish_block.c Remove blank lines
Walt Feasel [Sun, 20 Nov 2016 21:10:47 +0000 (16:10 -0500)]
staging: skein: threefish_block.c Remove blank lines

Make suggested checkpatch modification for

CHECK: Please don't use multiple blank lines

Acked-by: Jason Cooper <jason@lakedaemon.net
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: digi.h Spelling correction
Walt Feasel [Sat, 19 Nov 2016 16:47:41 +0000 (11:47 -0500)]
staging: dgnc: digi.h Spelling correction

Make spelling correction for 'regular'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: digi.h Comment style modifications
Walt Feasel [Sat, 19 Nov 2016 16:47:40 +0000 (11:47 -0500)]
staging: dgnc: digi.h Comment style modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: dgnc_tty.c Spelling corrections
Walt Feasel [Sat, 19 Nov 2016 16:45:42 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Spelling corrections

Make spelling corrections for 'transitions' and 'satisfy'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: dgnc_tty.c comment style modifications
Walt Feasel [Sat, 19 Nov 2016 16:45:41 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c comment style modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: dgnc_tty.c Align on parenthesis
Walt Feasel [Sat, 19 Nov 2016 16:45:40 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Align on parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: dgnc: dgnc_tty.c Space preferred around
Walt Feasel [Sat, 19 Nov 2016 16:45:39 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Space preferred around

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: slicoss: fix different address space warnings
Sergio Paracuellos [Fri, 18 Nov 2016 17:57:18 +0000 (18:57 +0100)]
staging: slicoss: fix different address space warnings

Remove incorrect __iomem annotation.

This patch fix the following sparse warnings in slicoss driver:
warning: incorrect type in assignment (different address spaces)

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: synth.c Align parenthesis
Walt Feasel [Sat, 19 Nov 2016 17:35:47 +0000 (12:35 -0500)]
staging: speakup: synth.c Align parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: synth.c Comment modifications
Walt Feasel [Sat, 19 Nov 2016 17:35:46 +0000 (12:35 -0500)]
staging: speakup: synth.c Comment modifications

Make modifications to comment style

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: synth.c Logical continuation
Walt Feasel [Sat, 19 Nov 2016 17:35:45 +0000 (12:35 -0500)]
staging: speakup: synth.c Logical continuation

Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: synth.c Blank line before }
Walt Feasel [Sat, 19 Nov 2016 17:35:44 +0000 (12:35 -0500)]
staging: speakup: synth.c Blank line before }

Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: synth.c Spaces around operators
Walt Feasel [Sat, 19 Nov 2016 19:34:35 +0000 (14:34 -0500)]
staging: speakup: synth.c Spaces around operators

Make suggested checkpatch modification for
CHECK: spaces preferred around that '|,+,-,/'

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: thread.c align on parenthesis
Walt Feasel [Sat, 19 Nov 2016 17:12:12 +0000 (12:12 -0500)]
staging: speakup: thread.c align on parenthesis

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: thread.c Comment modifications
Walt Feasel [Sat, 19 Nov 2016 17:12:11 +0000 (12:12 -0500)]
staging: speakup: thread.c Comment modifications

Make comment style modifications

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>