Daeseok Youn [Wed, 19 Mar 2014 23:20:51 +0000 (08:20 +0900)]
staging: unisys: replace kzalloc/kfree with UISMALLOC/UISFREE
It doesn't need to trace status of buffer when buffers are
allocated/deallocated. So stuff of tracing memory status
are removed. And also UISMALLOC/UISFREE macro are removed
completetly. just use kzalloc/kfree.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aaro Koskinen [Wed, 19 Mar 2014 22:52:08 +0000 (00:52 +0200)]
staging: octeon-usb: prevent memory corruption
octeon-hcd will crash the kernel when SLOB is used. This usually happens
after the 18-byte control transfer when a device descriptor is read.
The DMA engine is always transfering full 32-bit words and if the
transfer is shorter, some random garbage appears after the buffer.
The problem is not visible with SLUB since it rounds up the allocations
to word boundary, and the extra bytes will go undetected.
Fix by providing quirk functions for DMA map/unmap that allocate a bigger
temporary buffer when necessary. Tested by booting EdgeRouter Lite
to USB stick root file system with SLAB, SLOB and SLUB kernels.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=72121
Reported-by: Sergey Popov <pinkbyte@gentoo.org>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cédric Cabessa [Wed, 19 Mar 2014 22:04:57 +0000 (23:04 +0100)]
staging: usbip: fix line over 80 characters
Signed-off-by: Cédric Cabessa <ced@ryick.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cédric Cabessa [Wed, 19 Mar 2014 22:04:56 +0000 (23:04 +0100)]
staging: usbip: fix quoted string split across lines
Signed-off-by: Cédric Cabessa <ced@ryick.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:25 +0000 (13:06 -0500)]
Staging: unisys: Remove RETINT macro
The RETINT macro included a goto statement which is not allowed in the
kernel.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:24 +0000 (13:06 -0500)]
Staging: unisys: Remove FAIL macro
The FAIL macro ultimately includes a goto statement which is not allowed
in the kernel.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:23 +0000 (13:06 -0500)]
Staging: unisys: Remove RETVOID macro
The RETVOID macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:22 +0000 (13:06 -0500)]
Staging: unisys: Remove RETPTR macro
The RETPTR macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:21 +0000 (13:06 -0500)]
Staging: unisys: Remove RETBOOL macro
The RETBOOL macro contained a goto statement which is not allowed in
the kernel.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:20 +0000 (13:06 -0500)]
Staging: unisys: Remove FAIL_WPOSTCODE_1 macro
Part of a series to get rid of goto statements embedded in macros. I'm
breaking this up into a series of smaller patches for easier review. The
later patches in the series will actually remove the goto statements.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:19 +0000 (13:06 -0500)]
Staging: unisys: Cleanup macros to get rid of goto statements
Remove the following macros:
TRY
CHKFD
CHKDD
CHKFDX
CHKDDX
ADDPROCLINE
TRY_WPOSTCODE_1
TRY_WPOSTCODE_2
FAIL_WPOSTCODE_2
FAIL_WPOSTCODE_3
Part of a series to get rid of goto statements embedded in macros. I'm
breaking this up into a series of smaller patches for easier review. The later
patches in the series will actually remove the goto statements.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Wed, 19 Mar 2014 18:06:18 +0000 (13:06 -0500)]
Staging: unisys: include: Remove unused macros from timskmod.h
The following macros were never referenced and have been removed:
DEVFROMID
DEVFROMFILE
DEVFROMINODE
DEVFROMIDX
TRY_WPOSTCODE_3
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 19:46:57 +0000 (15:46 -0400)]
staging: dgap: fix the rest of the checkpatch warnings in dgap.c
This patch fixes all the simple_strtol and simple_strtoul warnings
as reported by checkpatch. After this patch, checkpatch will report
zero errors or warnings on dgap.c.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Wed, 19 Mar 2014 18:55:25 +0000 (20:55 +0200)]
Staging: bcm: Remove unnecessary parentheses
This patch fixes checkpatch.pl warning Unnecessary parentheses in bcm
driver.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jelena Bjelja [Wed, 19 Mar 2014 18:46:11 +0000 (19:46 +0100)]
staging: wlags49_h2: Delete unnecessary braces
Fix the following checkpatch.pl warnings in wl_netdev.c:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jelena Bjelja [Wed, 19 Mar 2014 18:46:06 +0000 (19:46 +0100)]
staging: wlags49_h2: Do not use assignment in if condition
Fix the following checkpatch.pl issue in wl_netdev.c:
ERROR: do not use assignment in if condition
Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jelena Bjelja [Wed, 19 Mar 2014 18:45:45 +0000 (19:45 +0100)]
staging: wlags49_h2: Enclose macro in a do-while loop
Fix the following checkpatch.pl issues in wl_netdev.c:
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Wed, 19 Mar 2014 18:25:13 +0000 (20:25 +0200)]
staging/media/davinci_vpfe/vpfe_video.h Unnecessary space after function pointer name
Fix checkpatch.pl issues with Unnecessary space after function pointer
name in vpfe_video.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Wed, 19 Mar 2014 18:25:12 +0000 (20:25 +0200)]
staging/media/davinci_vpfe/vpfe_video.h Fix missing space after return type
Fix checkpatch.pl issues with
missing space after return type in /vpfe_video.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Wed, 19 Mar 2014 18:16:19 +0000 (20:16 +0200)]
staging: nokia_h4p: Fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in
nokia_fw-csr.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Tao [Tue, 18 Mar 2014 13:05:56 +0000 (21:05 +0800)]
staging/lustre/libcfs: remove cfs_pause
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Tao [Tue, 18 Mar 2014 13:05:55 +0000 (21:05 +0800)]
staging/lustre/libcfs: remove schedule_timeout_and_set_state
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Tao [Tue, 18 Mar 2014 13:05:54 +0000 (21:05 +0800)]
staging/lustre/libcfs: remove waitq_timedwait
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Tao [Tue, 18 Mar 2014 13:05:53 +0000 (21:05 +0800)]
staging/lustre/libcfs: remove waitq_wait
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peng Tao [Tue, 18 Mar 2014 13:05:52 +0000 (21:05 +0800)]
staging/lustre/libcfs: remove init_waitqueue_entry_current
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Wed, 19 Mar 2014 17:47:27 +0000 (19:47 +0200)]
staging: ft1000: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in ft1000.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Wed, 19 Mar 2014 17:39:52 +0000 (19:39 +0200)]
staging: as102: as10x_handle.h .Fix Unnecessary space after function pointer name
This patch removes the following checkpatch.pl warning in as10x_handle.h
Warning : Unnecessary space after function pointer name
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Wed, 19 Mar 2014 16:49:52 +0000 (18:49 +0200)]
Staging: wlan-ng: Fix smatch warning potential null reference
This patch fixes potential null dereference 'wlandev' in wlan-ng driver.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Wed, 19 Mar 2014 16:44:46 +0000 (18:44 +0200)]
staging: adc: mxs-lradc.c Fix line over 80 characters.
Fix checkpatch.pl issues with
line over 80 characters in mxs-lradc.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Wed, 19 Mar 2014 19:01:08 +0000 (21:01 +0200)]
Staging: lustre: Fix space required before the open parenthesis
This patch fixes space required before the open parenthesis in lustre
driver.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 11:47:27 +0000 (12:47 +0100)]
staging: rtl8192u: make in r819xU_cmdpkt.c some local functions static
Make some local functions static.
Fix sparse warnings in r819xU_cmdpkt.c
drivers/staging/rtl8192u/r819xU_cmdpkt.c:185:6: warning: symbol 'cmdpkt_beacontimerinterrupt_819xusb' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 11:47:26 +0000 (12:47 +0100)]
staging: rtl8192u: make in ieee80211/ieee80211_wx.c a local variable static
Make some local variable eee80211_modes static.
Fix sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c:42:19: warning: symbol 'ieee80211_modes' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 11:47:25 +0000 (12:47 +0100)]
staging: rtl8192u: Delete 'fwSendNullPacket' function in r819xU_firmware.c
Delete the fwSendNullPacket function that is not used in anywhere in
the driver.
Fix sparse warnings:
drivers/staging/rtl8192u/r819xU_firmware.c:109:1: warning: symbol 'fwSendNullPacket' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 11:47:24 +0000 (12:47 +0100)]
staging: rtl8192u: make in r819xU_firmware.c some local functions static
Make some local functions static (firmware_init_param, fw_download_code,
CPUcheck_maincodeok_turnonCPU and CPUcheck_firmware_ready) and fix
coding style in these function declarations when It is necessary.
Fixed the following sparse warnings in r819xU_firmware.c
CHECK drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8192u/r819xU_firmware.c:20:6: warning: symbol 'firmware_init_param' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:32:6: warning: symbol 'fw_download_code' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:159:6: warning: symbol 'CPUcheck_maincodeok_turnonCPU' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:208:6: warning: symbol 'CPUcheck_firmware_ready' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Wed, 19 Mar 2014 11:37:09 +0000 (17:07 +0530)]
staging: bcm: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in Adapter.h
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 10:54:53 +0000 (11:54 +0100)]
staging: rtl8192u: Delete duplicate function declarations and extern keyword
Delete the duplicate function declarations in r8192U_dm.c.
These function declarations are defined in r8192U_dm.h.
Also, delete the 'extern' keyword of these function definitions.
Fix the following sparse warnings:
CHECK drivers/staging/rtl8192u/r8192U_dm.c
drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition
Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 10:54:54 +0000 (11:54 +0100)]
staging: rtl8192u: Delete 'DM_CTSToSelfSetting' function in r8192U_dm.c
Delete the DM_CTSToSelfSetting function that is not used in
anywhere in the driver.
Fix sparse warnings:
drivers/staging/rtl8192u/r8192U_dm.c:2623:6: warning: symbol 'DM_CTSToSelfSetting' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 10:54:55 +0000 (11:54 +0100)]
staging: rtl8192u: Delete 'dm_change_fsync_setting' function in r8192U_dm.c
Delete the 'dm_change_fsync_setting' function that is not used in
anywhere in the driver.
Fix sparse warnings:
drivers/staging/rtl8192u/r8192U_dm.c:1812:6: warning: symbol 'dm_change_fsync_setting' was not declared. Should it be static?
Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 19 Mar 2014 10:54:57 +0000 (11:54 +0100)]
staging: rtl8192u: Fix whitespaces in function declarations in r8192U_dm.h
Fix whitespaces in function declarations in r8192U_dm.h
Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Wed, 19 Mar 2014 11:07:26 +0000 (13:07 +0200)]
staging/tidspbridge/rmgr/mgr.c Fix quoted string split across lines
This patch fixes "quoted string split across lines warning"
warning in mgr.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Wed, 19 Mar 2014 08:17:18 +0000 (10:17 +0200)]
staging: winbond: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in localpara.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 19 Mar 2014 00:38:50 +0000 (02:38 +0200)]
Staging: cxt1e1: Fix externs should be avoided in .c files in comet.c
Fix checkpatch.pl issues with externs should be
avoided in comet.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Wed, 19 Mar 2014 00:38:49 +0000 (02:38 +0200)]
Staging: cxt1e1: Fix use of volatile is usually wrong in comet.c
Fix checkpatch.pl issues with use of volatile is
usually wrong in comet.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Wed, 19 Mar 2014 06:36:50 +0000 (08:36 +0200)]
staging: rtl8821ae: Fix braces {} are not necessary.
Fix checkpatch.pl issues with braces {} are not necessary in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Tue, 18 Mar 2014 22:25:49 +0000 (00:25 +0200)]
staging: rtl8821ae: Fix suspect code indent for conditional statements
Fix checkpatch.pl issues with suspect code indent for conditional
statements (16, 16) in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Tue, 18 Mar 2014 22:13:58 +0000 (00:13 +0200)]
Staging: comedi: Fix line over 80 characters in s626.c
Fix checkpatch.pl issues line over 80 characters
in s626.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Tue, 18 Mar 2014 22:13:57 +0000 (00:13 +0200)]
Staging: comedi: Fix missing space after return type in s626.c
Fix checkpatch.pl issues with missing space after
return type in s626.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:50:11 +0000 (14:50 +0200)]
Staging: rtl8188eu: Fix warning of braces are not necessary.
This patch fixes the warning of "braces are not necessary for single
statement blocks" in file rtw_ieee80211.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:49:44 +0000 (14:49 +0200)]
Staging: rtl8188eu: Fix warning of space prohibited.
This patch fixes the warning of "space prohibited before semicolon" in
file rtw_efuse.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:49:11 +0000 (14:49 +0200)]
Staging: rtl8188eu: Fix warning of braces not necessary.
This small patch fixes the warning of "braces are
necessary for any arm of this statement" in file rtw_efuse.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:48:44 +0000 (14:48 +0200)]
Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warning of "please, no space before tabs" in file
rtw_efuse.c. I have also modified the style of the comments for
readability.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:47:52 +0000 (14:47 +0200)]
Staging: rtl8188eu: Fix warning of space prohibited.
This small patch fixes the warning of "space prohibited before
semicolon" in file rtw_debug.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chi Pham [Tue, 18 Mar 2014 22:10:50 +0000 (23:10 +0100)]
staging: rtl8188eu: Reduced nesting and improved coding style.
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 23:35:47 +0000 (01:35 +0200)]
staging:lustre:lnet: lib-types.h Fix open brace '{' err.
Fix checkpatch.pl issues with open brace '{' following
struct go on the same line in lib-types.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 22:41:47 +0000 (00:41 +0200)]
staging:lustre:lnet: lib-types.h Fix unnecessary space func. pointer name.
Fix checkpatch.pl issues with
unnecessary space after function pointer name in lib-types.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Tue, 18 Mar 2014 21:12:38 +0000 (23:12 +0200)]
staging: lustre: add an extra line
Add an extra line break between the variable
declaration and the rest of the code
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 22:33:41 +0000 (00:33 +0200)]
Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warnings of "please, no space before tabs" in the
file rtw_mlme.c. I have also modified the comment style and removed some
unnecessary tabs.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 20:59:47 +0000 (22:59 +0200)]
Staging: rtl8188eu: Fix warnings of space prohibited.
This patch fixes the warnings of "space prohibited between function name
and open parenthesis" in file rtw_mlme.c.
While at it, I have also removed unneccessary tabs. Also one comment
that didn't make sense was removed.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 20:09:21 +0000 (22:09 +0200)]
Staging: rtl8188eu: Fix warning of braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_mlme.c. I have removed the else statement
in one case, as it didn't have any value.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:08 +0000 (19:25 +0000)]
staging: vt6656: s_uGetRTSCTSRsvTime fix return.
Always returns to __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:07 +0000 (19:25 +0000)]
staging: vt6656: vnt_rxtx_rsvtime_le16 fix return.
Always returns to __le16 type.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:06 +0000 (19:25 +0000)]
staging: vt6656: s_uGetDataDuration use __le16.
s_uGetDataDuration always returns to __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:05 +0000 (19:25 +0000)]
staging: vt6656: Correct return type s_uGetRTSCTSDuration.
s_uGetRTSCTSDuration always returns in __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:04 +0000 (19:25 +0000)]
staging: vt6656: rxtx endian correct return duration
All duration base types are __le16 correct back to cpu
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:03 +0000 (19:25 +0000)]
staging: vt6656: vnt_time_stamp_off fix return to __le16
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:02 +0000 (19:25 +0000)]
staging: vt6656: struct vnt_tx_short_buf_head correct base types
Both variables duration and time_stamp_off are __le16 types
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:01 +0000 (19:25 +0000)]
staging: vt6656: rxtx Replace wTimeStampOff* variables
Fix base type to __le16 and remove camel case.
Camel case changes
wTimeStampOff* -> time_stamp_off*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:00 +0000 (19:25 +0000)]
staging: vt6656: rxtx Replace wCTSTxRrvTime_ba
Replace with cts_rrv_time_ba with __le16 base.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:59 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wCTSDuration*
Fix base type to __le16 and remove camel case.
Camel case changes
wCTSDuration* -> cts_duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:58 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wTxRrvTime*
Fix base type to __le16 and remove camel case.
Camel case changes
wTxRrvTime* -> rrv_time*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:57 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wRTSTxRrvTime*
Fix base type to __le16 and remove camel case.
Camel case changes
wRTSTxRrvTime* -> rts_rrv_time*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:56 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wRTSDuration* variables
Fix base type to __le16 and remove camel case.
Camel case changes
wRTSDuration* -> rts_duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:55 +0000 (19:24 +0000)]
staging: vt6656: rxtx Replace wDuration* variables.
Fix base type to __le16 and remove camel case.
Camel case changes
wDuration* -> duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:52 +0000 (11:10 -0400)]
staging: dgap: re-factor some more code for 80+ lines
This patch fixes more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:51 +0000 (11:10 -0400)]
staging: dgap: get rid of DGAP_LOCK and DGAP_UNLOCK macros
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:50 +0000 (11:10 -0400)]
staging: dgap: re-factor some code for 80+ lines as reported by checkpatch
This patch re-factors some code to fix some 80+ lines as reported by checkpatch.
This patch was suggested and authored by Dan Carpenter. A test case for this
patch has been written and used to show the patch to be correct.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:33 +0000 (09:20 +0100)]
staging: wlags49_h2: Correct comment style in wl_netdev.c
Code is using C99 code style, so change them to kernel style
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:32 +0000 (09:20 +0100)]
staging: wlags49_h2: remove commented code in wl_netdev.c
Remove unused code under C99 comment style
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:31 +0000 (09:20 +0100)]
staging: wlags49_h2: reindent wl_netdev.c
As the file is using a mix between space and tab,
and space instead of tab, use Lindent to fix the file
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Wed, 19 Mar 2014 04:24:31 +0000 (23:24 -0500)]
Staging: comedi: proc: title block update
Follow up patch for "STAGING: comedi: style and checkpatch fixes".
Removes the file name in the comment block per suggestions.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gary Rookard [Tue, 18 Mar 2014 20:17:28 +0000 (16:17 -0400)]
Staging: bcm: CmHost: moved and removed declarations and tmp bracing.
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but are not intended to remain.
In this scenario there are declarations occupying space only
reserved for statements. If these tmp braces were to be removed
before the declarations in question were reassigned to there
proper place in the funtion, compile time errors would result.
So, having that said, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Removed temporary bracing from case labels.
Removed new lines as needed.
Properly indented case breaks.
Added /* FALLTHROUGH */ comments to switch/case.
Signed-off-by: Gary Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masood Mehmood [Tue, 18 Mar 2014 20:40:14 +0000 (13:40 -0700)]
staging: dgap: Fixed sparse error: same symbol redeclared with different type
sparse reported dgap_do_fep_load is redeclared with different type. while
fixing, I noticed __user attribute is used incorrectly in declaration.
There is no need to define __user for firware->data.
Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
did the same for function dgap_do_bios_load
patch generated against: next-
20140318
Signed-off-by: Masood Mehmood <ody.guru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Silvio F [Tue, 18 Mar 2014 21:13:10 +0000 (22:13 +0100)]
staging: unisys: kmalloc/memset to kzalloc conversation
This patch solves the Coccinelle warning: "kzalloc should be used
instead of kmalloc/memset"
This patch is a fixup for
linux-next:
97a84f1203786985856a0d4b49b1d7cc387238ce
"Staging: unisys: Replace kmalloc/memset with kzalloc"
The ALLOC_CMDRSP #define is after transformation to kzalloc only a
rename for kzalloc and was completly removed.
Signed-off-by: Silvio F <silvio.fricke@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Weinberger [Tue, 18 Mar 2014 23:07:05 +0000 (00:07 +0100)]
staging/xillybus: Handle OOM in xillybus_init()
alloc_workqueue() can fail and returns NULL in case of
OOM.
Handle this case and undo class_create().
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mikhail Boiko [Tue, 18 Mar 2014 21:59:46 +0000 (23:59 +0200)]
staging: line6: Fix coding style problem
Fix style issue for eudyptula challenge
Signed-off-by: Mikhail Boiko <mm.boiko@yandex.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 18 Mar 2014 19:35:16 +0000 (01:05 +0530)]
Staging:
ced1401: Fix no new typedef warning in ced_ioctl.h
This patch fixes following checkpatch.pl warnings:
WARNING:do not add new typedefs.All the related files have been modified.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 18 Mar 2014 19:36:35 +0000 (01:06 +0530)]
Staging:
ced1401: Fix typedef warnings in ced_ioctl.h
This patch fixes following checkpatch.pl warnings:
WARNING:do not add new typedefs.
In this patch i have also renamed TransferDesc to transfer_area_desc in order to clearly indicate
that it describes the transfer area.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keerthimai Janarthanan [Tue, 18 Mar 2014 19:08:59 +0000 (00:38 +0530)]
staging: usbip: Fix quoted string split across lines.
Fix quoted string split across lines.
Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 19:13:29 +0000 (21:13 +0200)]
staging/octeon:ethernet-rgmii.c: Fix line over 80 characters.
checkpatch.pl issues with line over
80 characters in ethernet-rgmii.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 18 Mar 2014 00:45:40 +0000 (09:45 +0900)]
staging: cxt1e1: remove unneeded mkret() calls
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Tue, 18 Mar 2014 07:14:20 +0000 (02:14 -0500)]
STAGING: comedi: style and checkpatch fixes
Updates block comment per Documentation/CodingStyle.
Also updated due to checkpatch warnings about qouted string
after Lindent modified the spacing slightly.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 18:22:18 +0000 (20:22 +0200)]
Staging: rtl8188eu: Fix warning of printk() should include KERN_ facility level.
This patch fixes the warning of "printk() should include KERN_ facility
level" in file rtw_debug.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 17:16:49 +0000 (19:16 +0200)]
Staging: rtl8188eu: Fix warning of unchecked sscanf return value.
This patch fixes the warning "unchecked sscanf return value" in file
rtw_mp.c. Zero is returned in case sscanf fails or if less than expected
items are read and assigned successfully. I have decided to return zero,
because in previous conditional statements zero was returned in case of
failure.
While at it, I have also fixed the warning of line over 80
characters.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 18:45:59 +0000 (20:45 +0200)]
staging/speakup:speakup_dectlk.c Fix line over 80 characters.
checkpatch.pl issues with line over
80 characters in speakup_dectlk.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Tue, 18 Mar 2014 15:26:57 +0000 (17:26 +0200)]
staging: luster: do not combine value 0 with |
There is no point in combining a variable
that is 0 with other things with |
The semantic patch used:
@@
expression x,e,e1;
statement S;
@@
if (x == 0) {
<... when != x = e1
when != while(...) S
when != for(...;...;...) S
- x |= e
+ x = e
...>
}
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Mon, 17 Mar 2014 22:25:56 +0000 (00:25 +0200)]
staging: addac: adt7316.c: Fix line over 80 characters
Fix checkpatch.pl issues with line over 80 characters in adt7316.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 13:21:52 +0000 (15:21 +0200)]
staging: rtl8192e: Fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in
dot11d.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreea-Cristina Bernat [Sun, 16 Mar 2014 20:21:41 +0000 (22:21 +0200)]
Staging: lirc: Fix warning: assignment of bool to 0/1
This patch solves the warning "Assignment of bool to 0/1"
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Tue, 18 Mar 2014 15:05:56 +0000 (17:05 +0200)]
staging: slicoss: free IO remapping on failure
Make sure iounmap is always called after ioremap when module loading
fails. Also remove a call to release_mem_region because that region is
never reserved in the first place.
Fixes the following issue reported by Coccinelle:
drivers/staging/slicoss/slicoss.c:3727:1-7: ERROR: missing iounmap; ioremap on line 3661 and execution via conditional on line 3677
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 13:42:32 +0000 (15:42 +0200)]
staging: rtl8712: Fix multiple spaces after return type
Fix checkpatch.pl issues with multiple spaces after return type in
drv_types.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / MotorolaMobilityLLC / kernel-slsi.git / log