GitHub/WoltLab/WCF.git
20 months agoMove generic cache preparing to `AbstractCommentResponseUserNotificationEvent`
Marcel Werk [Thu, 27 Apr 2023 14:06:50 +0000 (16:06 +0200)]
Move generic cache preparing to `AbstractCommentResponseUserNotificationEvent`

20 months agoFix event hash for notifications about comment responses
Marcel Werk [Thu, 27 Apr 2023 14:05:53 +0000 (16:05 +0200)]
Fix event hash for notifications about comment responses

20 months agoRemove obsolete code
Marcel Werk [Thu, 27 Apr 2023 13:58:04 +0000 (15:58 +0200)]
Remove obsolete code

The same event hash is already generated in `AbstractUserNotificationEvent`.

20 months agoFix inconsistency of the English version of `wcf.acp.option.url_omit_index_php.descri...
Marcel Werk [Thu, 27 Apr 2023 13:25:28 +0000 (15:25 +0200)]
Fix inconsistency of the English version of `wcf.acp.option.url_omit_index_php.description`

Closes #5227

20 months agoMerge pull request #5454 from WoltLab/abstract-comment-user-notification-event
Marcel Werk [Thu, 27 Apr 2023 11:39:05 +0000 (13:39 +0200)]
Merge pull request #5454 from WoltLab/abstract-comment-user-notification-event

Add default implementation for user notifications about comments

20 months agoApply suggestions from code review
Marcel Werk [Thu, 27 Apr 2023 11:38:30 +0000 (13:38 +0200)]
Apply suggestions from code review

20 months agoPrevent iOS from zooming when focusing the editor
Alexander Ebert [Thu, 27 Apr 2023 11:29:26 +0000 (13:29 +0200)]
Prevent iOS from zooming when focusing the editor

Fixes WoltLab/editor#39

20 months agoMerge pull request #5459 from WoltLab/time-template-function
Marcel Werk [Thu, 27 Apr 2023 11:20:03 +0000 (13:20 +0200)]
Merge pull request #5459 from WoltLab/time-template-function

Replace |time modifier by {time} function

20 months agoImprove API for `{time}`
Tim Düsterhus [Thu, 27 Apr 2023 10:47:08 +0000 (12:47 +0200)]
Improve API for `{time}`

20 months agoSynchronize the `wysiwyg` template
Alexander Ebert [Wed, 26 Apr 2023 17:44:28 +0000 (19:44 +0200)]
Synchronize the `wysiwyg` template

20 months agoExport custom bbcode icons as image src
Alexander Ebert [Wed, 26 Apr 2023 17:43:01 +0000 (19:43 +0200)]
Export custom bbcode icons as image src

See #5182

20 months agoAllow custom images as the icon for the bbcode button
Alexander Ebert [Wed, 26 Apr 2023 17:29:19 +0000 (19:29 +0200)]
Allow custom images as the icon for the bbcode button

See #5182

20 months agoMark time modifier functions as deprecated
Marcel Werk [Wed, 26 Apr 2023 16:21:26 +0000 (18:21 +0200)]
Mark time modifier functions as deprecated

20 months agoReplace |time modifier by {time} function
Marcel Werk [Wed, 26 Apr 2023 16:21:11 +0000 (18:21 +0200)]
Replace |time modifier by {time} function

Closes #5277

20 months agoFix documentation of the icon template plugin
Marcel Werk [Wed, 26 Apr 2023 16:06:42 +0000 (18:06 +0200)]
Fix documentation of the icon template plugin

It's not a compiler plugin.

20 months agoEnable `inputmode` for email form fields by default
Marcel Werk [Wed, 26 Apr 2023 15:57:22 +0000 (17:57 +0200)]
Enable `inputmode` for email form fields by default

20 months agoAdd default implementation for user notifications about comment responses
Marcel Werk [Wed, 26 Apr 2023 13:59:42 +0000 (15:59 +0200)]
Add default implementation for user notifications about comment responses

20 months agoMerge pull request #5455 from WoltLab/relative-time-weekday-not-first
Tim Düsterhus [Wed, 26 Apr 2023 11:56:10 +0000 (13:56 +0200)]
Merge pull request #5455 from WoltLab/relative-time-weekday-not-first

Fix “today or yesterday” rendering for languages that do not put the weekday first

20 months agoDisallow changing the languageCode of existing languages
Tim Düsterhus [Wed, 26 Apr 2023 10:07:54 +0000 (12:07 +0200)]
Disallow changing the languageCode of existing languages

Changing the language code for an existing language effectively invalidates
everything that is already stored within that language and thus is not a useful
operation. Changing the country code or locale should be compatible with
existing phrases or contents and thus is still allowed.

20 months agoFix checks for form mode in LanguageAddForm
Tim Düsterhus [Wed, 26 Apr 2023 10:07:28 +0000 (12:07 +0200)]
Fix checks for form mode in LanguageAddForm

20 months agoFix “today or yesterday” rendering for languages that do not put the weekday first
Tim Düsterhus [Wed, 26 Apr 2023 09:54:31 +0000 (11:54 +0200)]
Fix “today or yesterday” rendering for languages that do not put the weekday first

The previous version was broken, because it just returned the name of the
weekday (`value`), but the time was missing entirely. The code was refactored
to move the “weekday first” check into refresh(), allowing languages that put
the weekday first to proceed as previously without any visual changes and other
languages to just use the absolute date + time. The diff likely looks larger
than it is for that reason.

Rendering was verified with de, en_US, en_GB, ar, he, el, ru, ja.

20 months agoMerge branch 'language-add-formbuilder'
Tim Düsterhus [Wed, 26 Apr 2023 09:03:00 +0000 (11:03 +0200)]
Merge branch 'language-add-formbuilder'

Closes #5252

20 months agoImplement `LanguageContentCopying` event
mutec [Tue, 31 Jan 2023 19:55:26 +0000 (20:55 +0100)]
Implement `LanguageContentCopying` event

This event is meant to give 3rd-party developers the possibility to copy i18n
contents in every case contents should be copied to another language.

[Tim: Renamed the event to match the event naming scheme]

see #5252

20 months agoConvert `Language*Form` to form builder
mutec [Sun, 29 Jan 2023 12:36:08 +0000 (13:36 +0100)]
Convert `Language*Form` to form builder

see #5252

[Tim: Performed some final adjustments]

20 months agoAllow for custom workflows that do not rely on passwords
Alexander Ebert [Tue, 25 Apr 2023 16:05:09 +0000 (18:05 +0200)]
Allow for custom workflows that do not rely on passwords

20 months agoAdd default implementation for user notifications about comments
Marcel Werk [Tue, 25 Apr 2023 14:06:04 +0000 (16:06 +0200)]
Add default implementation for user notifications about comments

20 months agoMerge pull request #5453 from WoltLab/datepicker-disabled
Tim Düsterhus [Tue, 25 Apr 2023 13:44:04 +0000 (15:44 +0200)]
Merge pull request #5453 from WoltLab/datepicker-disabled

Add `.disabled` class to Date/Picker cells before or after the legal date range

20 months agoMerge pull request #5452 from WoltLab/devtools-sync
Tim Düsterhus [Tue, 25 Apr 2023 13:39:20 +0000 (15:39 +0200)]
Merge pull request #5452 from WoltLab/devtools-sync

Fix visuals in devtoolsProjectSync if the first non-important PIP has no target

20 months agoMerge pull request #5450 from WoltLab/user-notification-mail-title
Marcel Werk [Tue, 25 Apr 2023 12:04:14 +0000 (14:04 +0200)]
Merge pull request #5450 from WoltLab/user-notification-mail-title

Remove the "New Notification:" prefix from notification e-mails

20 months agoFix CSS to disable the datePicker hover effect on unclickable cells
Tim Düsterhus [Tue, 25 Apr 2023 10:49:41 +0000 (12:49 +0200)]
Fix CSS to disable the datePicker hover effect on unclickable cells

20 months agoAdd `.disabled` class to Date/Picker cells before or after the legal date range
Tim Düsterhus [Tue, 25 Apr 2023 10:45:19 +0000 (12:45 +0200)]
Add `.disabled` class to Date/Picker cells before or after the legal date range

And then reduce the opacity to make it more clear that these are unselectable.
Valid dates in a different month will still not be clickable, but their opacity
will not be reduced to not be misleading.

see https://www.woltlab.com/community/thread/294117-datepicker-ausw%C3%A4hlbare-daten-eindeutiger-darstellen/

20 months agoFix visuals in devtoolsProjectSync if the first non-important PIP has no target
Tim Düsterhus [Tue, 25 Apr 2023 10:24:31 +0000 (12:24 +0200)]
Fix visuals in devtoolsProjectSync if the first non-important PIP has no target

The thicker border was missing, because the element having the border was
visually hidden.

20 months agoMerge branch '5.5'
Tim Düsterhus [Tue, 25 Apr 2023 09:34:29 +0000 (11:34 +0200)]
Merge branch '5.5'

20 months agoImprove phrasing for `user_authentication_failure_*` descriptions
Tim Düsterhus [Tue, 25 Apr 2023 09:33:59 +0000 (11:33 +0200)]
Improve phrasing for `user_authentication_failure_*` descriptions

20 months agoRemove the "New Notification:" prefix from notification e-mails
Marcel Werk [Mon, 24 Apr 2023 16:04:48 +0000 (18:04 +0200)]
Remove the "New Notification:" prefix from notification e-mails

The prefix had little use and caused that in many e-mail clients little of the actual subject of the e-mails was immediately visible.

20 months agoMerge branch '5.5'
Tim Düsterhus [Mon, 24 Apr 2023 13:08:26 +0000 (15:08 +0200)]
Merge branch '5.5'

20 months agoFix creating menuItem PIP entries without parent using dev tools
Tim Düsterhus [Mon, 24 Apr 2023 13:07:17 +0000 (15:07 +0200)]
Fix creating menuItem PIP entries without parent using dev tools

Fixes #4754

20 months agoUse `intdiv()` in `ExifUtil::simplifyRational()`
Tim Düsterhus [Mon, 24 Apr 2023 12:19:24 +0000 (14:19 +0200)]
Use `intdiv()` in `ExifUtil::simplifyRational()`

20 months agoMerge pull request #5449 from WoltLab/exifutil-simplify-exposure
Tim Düsterhus [Mon, 24 Apr 2023 12:00:14 +0000 (14:00 +0200)]
Merge pull request #5449 from WoltLab/exifutil-simplify-exposure

Simplify the ExposureTime fraction in ExifUtil::getFormattedExifData()

20 months agoSimplify the ExposureTime fraction in ExifUtil::getFormattedExifData()
Tim Düsterhus [Mon, 24 Apr 2023 11:25:19 +0000 (13:25 +0200)]
Simplify the ExposureTime fraction in ExifUtil::getFormattedExifData()

see https://www.woltlab.com/community/thread/298320-fehlerhafte-exif-daten/

20 months agoMerge pull request #5437 from WoltLab/random-cronjob
Tim Düsterhus [Mon, 24 Apr 2023 08:55:26 +0000 (10:55 +0200)]
Merge pull request #5437 from WoltLab/random-cronjob

Support randomized cronjobs in cronjob PIP

20 months agoRemove obsolete manual cronjob randomization.
Tim Düsterhus [Fri, 21 Apr 2023 11:03:00 +0000 (13:03 +0200)]
Remove obsolete manual cronjob randomization.

20 months agoUse `<expression type="random">` for randomized cronjobs
Tim Düsterhus [Fri, 21 Apr 2023 11:01:36 +0000 (13:01 +0200)]
Use `<expression type="random">` for randomized cronjobs

see #5202

20 months agoGenerate WCF_UUID earlier during installation
Tim Düsterhus [Fri, 21 Apr 2023 11:07:24 +0000 (13:07 +0200)]
Generate WCF_UUID earlier during installation

This is required for cronjob randomization. Some additional changes needed to
be performed to not break WCFSetup. As the options.inc.php is rewritten, the
cookie prefix update needs to be moved into the install script from
PackageInstallationDispatcher.

20 months agoFix the styling of the overflow toolbar
Alexander Ebert [Sun, 23 Apr 2023 09:05:10 +0000 (11:05 +0200)]
Fix the styling of the overflow toolbar

20 months agoFix the overflow behavior of the grouped toolbar
Alexander Ebert [Sun, 23 Apr 2023 09:02:13 +0000 (11:02 +0200)]
Fix the overflow behavior of the grouped toolbar

See #18

20 months agoEnable the automatic grouping of items in the toolbar
Alexander Ebert [Sat, 22 Apr 2023 10:30:16 +0000 (12:30 +0200)]
Enable the automatic grouping of items in the toolbar

Fixes WoltLab/editor#18

20 months agoUse a darker shade to separate split buttons
Alexander Ebert [Fri, 21 Apr 2023 14:05:17 +0000 (16:05 +0200)]
Use a darker shade to separate split buttons

20 months agoFix version variable in INVALID_REQUIRED_PACKAGE_VERSION_NUMBER error message
Tim Düsterhus [Fri, 21 Apr 2023 14:04:05 +0000 (16:04 +0200)]
Fix version variable in INVALID_REQUIRED_PACKAGE_VERSION_NUMBER error message

Fixes #5443

20 months agoMerge pull request #5438 from WoltLab/quit-more-often
Tim Düsterhus [Fri, 21 Apr 2023 13:35:22 +0000 (15:35 +0200)]
Merge pull request #5438 from WoltLab/quit-more-often

Run the userQuit cronjob every 4 hours

20 months agoMerge pull request #5440 from WoltLab/ckeditor5-styling
Alexander Ebert [Fri, 21 Apr 2023 13:27:17 +0000 (15:27 +0200)]
Merge pull request #5440 from WoltLab/ckeditor5-styling

Align the styling of CKEditor 5 with the regular style

20 months agoRemove the border radius from the table creation widget
Alexander Ebert [Fri, 21 Apr 2023 13:18:19 +0000 (15:18 +0200)]
Remove the border radius from the table creation widget

20 months agoApply `cursor: pointer` to all non-disabled buttons
Alexander Ebert [Fri, 21 Apr 2023 13:18:07 +0000 (15:18 +0200)]
Apply `cursor: pointer` to all non-disabled buttons

20 months agoImprove the color scheme of focus indicators
Alexander Ebert [Fri, 21 Apr 2023 12:57:53 +0000 (14:57 +0200)]
Improve the color scheme of focus indicators

20 months agoAdd the missing border to the pseudo dialog for draft restores
Alexander Ebert [Fri, 21 Apr 2023 11:27:34 +0000 (13:27 +0200)]
Add the missing border to the pseudo dialog for draft restores

20 months agoApply the framework’s style to CKEditor
Alexander Ebert [Thu, 20 Apr 2023 17:19:10 +0000 (19:19 +0200)]
Apply the framework’s style to CKEditor

20 months agoApply the style variables for the editor toolbar
Alexander Ebert [Thu, 20 Apr 2023 13:53:00 +0000 (15:53 +0200)]
Apply the style variables for the editor toolbar

20 months agoDelete some remaining `@package` tags in *.php
Tim Düsterhus [Fri, 21 Apr 2023 12:39:38 +0000 (14:39 +0200)]
Delete some remaining `@package` tags in *.php

These were likely sitting in PRs when the tags were removed originally in
bb349f5cfb64ec93ad08f1485a938f851e891cee.

20 months agoRun the userQuit cronjob every 4 hours
Tim Düsterhus [Fri, 21 Apr 2023 12:10:32 +0000 (14:10 +0200)]
Run the userQuit cronjob every 4 hours

Users that initiated their quit reported more than once that their user account
was not yet deleted, even though their quit time already expired. This is
especially pronounced if the planned quit time was in the morning, as the
cronjob previously only ran during night.

Run the cronjob every 4 hours, reducing the time window where the quit time
already expired, but the account is not actually deleted yet. A delay of a few
hours is likely reasonable even for layman users.

20 months agoMerge pull request #5436 from WoltLab/mfa-code-visuals
Tim Düsterhus [Fri, 21 Apr 2023 11:42:29 +0000 (13:42 +0200)]
Merge pull request #5436 from WoltLab/mfa-code-visuals

Improve visuals for MFA code inputs

20 months agoSupport randomized cronjobs in cronjob PIP
Tim Düsterhus [Fri, 21 Apr 2023 10:59:09 +0000 (12:59 +0200)]
Support randomized cronjobs in cronjob PIP

This uses an additional attribute on the `<expression>` for a clear migration
path forward, if the cron expression library gains native support.

With PHP 8.2+ a seedable engine is used, ensuring the values stay the same
after a reimport of the same cronjob.

Resolves #5202

20 months agoImprove visuals for MFA code inputs
Tim Düsterhus [Fri, 21 Apr 2023 09:36:05 +0000 (11:36 +0200)]
Improve visuals for MFA code inputs

The `size=""` attribute does not really match the required size for the input,
even with monospace fonts. Use explicit a `width:` attribute with the `ch` unit
for the few field sizes we actually use, because using an attribute value in
calculations is not possible.

This commit also updates the use of the `monospace` font to
`--wcfFontFamilyMonospace` for consistency.

20 months agoUpdate to FontAwesome 6.4.0
Tim Düsterhus [Fri, 21 Apr 2023 09:20:04 +0000 (11:20 +0200)]
Update to FontAwesome 6.4.0

20 months agoMerge pull request #5434 from WoltLab/username-validating-event
Tim Düsterhus [Fri, 21 Apr 2023 09:15:58 +0000 (11:15 +0200)]
Merge pull request #5434 from WoltLab/username-validating-event

Add UsernameValidating event

20 months agoMerge pull request #5435 from WoltLab/fix-google-font
Tim Düsterhus [Fri, 21 Apr 2023 09:14:42 +0000 (11:14 +0200)]
Merge pull request #5435 from WoltLab/fix-google-font

Fix the use of Google Fonts

20 months agoFix the use of Google Fonts
Tim Düsterhus [Fri, 21 Apr 2023 08:24:46 +0000 (10:24 +0200)]
Fix the use of Google Fonts

Due to the move to proper CSS variables, instead of just SCSS variables, the
variables need to be available during `->bootstrap()` and thus they are
prepared early in the compilation process. This preparation included quoting
the Google Font. Later in the bootstrap, when loading the CSS for the Google
Font, the corresponding CSS file could not be found due to this quoting.

It appears that the quoting of the variable itself is no longer be necessary.
The previous comment stated that font names with 'and' or 'or' in their name
cause issues. While the current list of fonts does not include any font with
'or' in its name, I successfully tested the `Black And White Picture` font.

The SCSS compiled just fine, possibly due to an upgrade of the SCSS compiler
that fixed a limitation. So this is going to be the bugfix.

Fixes #5400

20 months agoMove the REGISTER_USERNAME_FORCE_ASCII check into an event listener
Tim Düsterhus [Thu, 20 Apr 2023 15:33:16 +0000 (17:33 +0200)]
Move the REGISTER_USERNAME_FORCE_ASCII check into an event listener

20 months agoAdd UsernameValidating event
Tim Düsterhus [Thu, 20 Apr 2023 15:25:55 +0000 (17:25 +0200)]
Add UsernameValidating event

20 months agoImprove Ckeditor/Types.ts
Tim Düsterhus [Thu, 20 Apr 2023 13:07:17 +0000 (15:07 +0200)]
Improve Ckeditor/Types.ts

20 months agoUnify the general styling of CKEditor
Alexander Ebert [Thu, 20 Apr 2023 12:15:38 +0000 (14:15 +0200)]
Unify the general styling of CKEditor

Fixes #5428

20 months agoFix incorrect phrase reference in styleAdd.tpl
Tim Düsterhus [Thu, 20 Apr 2023 09:14:19 +0000 (11:14 +0200)]
Fix incorrect phrase reference in styleAdd.tpl

20 months agoMerge branch '5.5'
Tim Düsterhus [Thu, 20 Apr 2023 08:40:02 +0000 (10:40 +0200)]
Merge branch '5.5'

20 months agoAdd parameter types from psr/http-message to LegacyPlaceholderResponse
Tim Düsterhus [Thu, 20 Apr 2023 08:38:09 +0000 (10:38 +0200)]
Add parameter types from psr/http-message to LegacyPlaceholderResponse

20 months agoMerge pull request #5429 from WoltLab/username-spoof
Tim Düsterhus [Thu, 20 Apr 2023 07:02:30 +0000 (09:02 +0200)]
Merge pull request #5429 from WoltLab/username-spoof

Extend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking

20 months agoMerge pull request #5430 from WoltLab/generic-share-button
Marcel Werk [Wed, 19 Apr 2023 16:44:24 +0000 (18:44 +0200)]
Merge pull request #5430 from WoltLab/generic-share-button

Add generic position for share button in the content interaction section

20 months agoUse new position in article template
Marcel Werk [Wed, 19 Apr 2023 14:51:11 +0000 (16:51 +0200)]
Use new position in article template

20 months agoAdd generic position for share button in the content interaction section
Marcel Werk [Wed, 19 Apr 2023 14:43:37 +0000 (16:43 +0200)]
Add generic position for share button in the content interaction section

20 months agoAdd support for button-type share buttons
Marcel Werk [Wed, 19 Apr 2023 14:37:49 +0000 (16:37 +0200)]
Add support for button-type share buttons

20 months agoExtend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking
Tim Düsterhus [Wed, 19 Apr 2023 11:41:06 +0000 (13:41 +0200)]
Extend REGISTER_USERNAME_FORCE_ASCII to support ICU spoofchecking

20 months agoRelease 5.5.11 5.5.11
Alexander Ebert [Wed, 19 Apr 2023 13:32:44 +0000 (15:32 +0200)]
Release 5.5.11

20 months agoMerge branch '5.4' into 5.5
Alexander Ebert [Wed, 19 Apr 2023 12:57:09 +0000 (14:57 +0200)]
Merge branch '5.4' into 5.5

20 months agoRelease 5.4.27 5.4.27
Alexander Ebert [Wed, 19 Apr 2023 12:56:08 +0000 (14:56 +0200)]
Release 5.4.27

20 months agoRequire usernames to be valid UTF-8
Tim Düsterhus [Wed, 19 Apr 2023 12:54:33 +0000 (14:54 +0200)]
Require usernames to be valid UTF-8

20 months agoGenerally consider usernames with bytes less than 0x20 as invalid
Tim Düsterhus [Wed, 19 Apr 2023 12:51:15 +0000 (14:51 +0200)]
Generally consider usernames with bytes less than 0x20 as invalid

NUL bytes, newlines (LF was already restricted) and other ASCII control
characters have no business of existing within an username.

20 months agoMerge branch '5.3' into 5.4
Alexander Ebert [Wed, 19 Apr 2023 12:50:28 +0000 (14:50 +0200)]
Merge branch '5.3' into 5.4

20 months agoRelease 5.3.28 5.3.28 5.3.final
Alexander Ebert [Wed, 19 Apr 2023 12:48:51 +0000 (14:48 +0200)]
Release 5.3.28

20 months agoMerge branch '5.5'
Tim Düsterhus [Wed, 19 Apr 2023 12:00:13 +0000 (14:00 +0200)]
Merge branch '5.5'

20 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:59:20 +0000 (11:59 +0000)]
Updating minified JavaScript files

20 months agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 19 Apr 2023 11:58:03 +0000 (13:58 +0200)]
Merge branch '5.4' into 5.5

20 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:57:15 +0000 (11:57 +0000)]
Updating minified JavaScript files

20 months agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 19 Apr 2023 11:55:57 +0000 (13:55 +0200)]
Merge branch '5.3' into 5.4

20 months agoUpdating minified JavaScript files
WoltLab [Wed, 19 Apr 2023 11:55:07 +0000 (11:55 +0000)]
Updating minified JavaScript files

20 months agoMerge branch '5.5'
Tim Düsterhus [Wed, 19 Apr 2023 11:52:42 +0000 (13:52 +0200)]
Merge branch '5.5'

20 months agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 19 Apr 2023 11:51:47 +0000 (13:51 +0200)]
Merge branch '5.4' into 5.5

20 months agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 19 Apr 2023 11:51:31 +0000 (13:51 +0200)]
Merge branch '5.3' into 5.4

20 months agoMerge branch 'article-clipboard' into 5.3
Tim Düsterhus [Wed, 19 Apr 2023 11:45:04 +0000 (13:45 +0200)]
Merge branch 'article-clipboard' into 5.3

20 months agoMerge branch 'js-unescape-html' into 5.3
Tim Düsterhus [Wed, 19 Apr 2023 11:44:42 +0000 (13:44 +0200)]
Merge branch 'js-unescape-html' into 5.3

20 months agoMerge pull request #5427 from SoftCreatR/patch-1
Alexander Ebert [Tue, 18 Apr 2023 12:46:28 +0000 (14:46 +0200)]
Merge pull request #5427 from SoftCreatR/patch-1

Apply small style optimization

20 months agoFix StyleEditor::update() for absent variables
Tim Düsterhus [Tue, 18 Apr 2023 09:12:14 +0000 (11:12 +0200)]
Fix StyleEditor::update() for absent variables

see d7fad3385012cd86b33b9262c47040b1c7267826

20 months agoFix style variable update in StyleEditor::update()
Tim Düsterhus [Tue, 18 Apr 2023 08:59:27 +0000 (10:59 +0200)]
Fix style variable update in StyleEditor::update()

The previous version overwrote the input variables before processing them. It
also did not support missing a `variables` key, whereas 5.5 did.

see f573c802cc70e929641b7145c1e28ff557ec61ff