GitHub/WoltLab/WCF.git
13 months agoMigrate from DomChangeListener to `wheneverFirstSeen()` for Date/Picker
Tim Düsterhus [Thu, 14 Sep 2023 13:02:43 +0000 (15:02 +0200)]
Migrate from DomChangeListener to `wheneverFirstSeen()` for Date/Picker

see https://www.woltlab.com/community/thread/301605-formbuilder-via-dialogfactory-l%C3%A4dt-dateformfield-falsch/

13 months agoCheck for version and date when loading PackageArchive
Tim Düsterhus [Wed, 13 Sep 2023 12:32:11 +0000 (14:32 +0200)]
Check for version and date when loading PackageArchive

Resolves #5650

13 months agoReject duplicated elements in `<packageinformation>`
Tim Düsterhus [Wed, 13 Sep 2023 12:21:42 +0000 (14:21 +0200)]
Reject duplicated elements in `<packageinformation>`

13 months agoDrop `<compatibility>` from package.xsd
Tim Düsterhus [Wed, 13 Sep 2023 11:53:46 +0000 (13:53 +0200)]
Drop `<compatibility>` from package.xsd

13 months agoExport CKEditor5 as an AMD module
Alexander Ebert [Wed, 13 Sep 2023 11:40:22 +0000 (13:40 +0200)]
Export CKEditor5 as an AMD module

See WoltLab/editor#91

13 months agoFix the `WCF.Label.ACPList` namespace
Alexander Ebert [Wed, 13 Sep 2023 11:34:00 +0000 (13:34 +0200)]
Fix the `WCF.Label.ACPList` namespace

13 months agoFix the color of the CKEditor logo
Alexander Ebert [Tue, 12 Sep 2023 15:53:36 +0000 (17:53 +0200)]
Fix the color of the CKEditor logo

13 months agoAdd missing `menuItem` PIP to update instructions from 5.5
Tim Düsterhus [Tue, 12 Sep 2023 11:23:22 +0000 (13:23 +0200)]
Add missing `menuItem` PIP to update instructions from 5.5

13 months agoUpdate files_pre_check.tar
Tim Düsterhus [Tue, 12 Sep 2023 11:19:57 +0000 (13:19 +0200)]
Update files_pre_check.tar

13 months agoEnable the update server check when upgrading from 5.5
Tim Düsterhus [Tue, 12 Sep 2023 11:15:42 +0000 (13:15 +0200)]
Enable the update server check when upgrading from 5.5

13 months agoRevert "Remove the preliminary upgrade instructions from 5.5"
Tim Düsterhus [Tue, 12 Sep 2023 11:15:27 +0000 (13:15 +0200)]
Revert "Remove the preliminary upgrade instructions from 5.5"

This reverts commit b600a2611491aa9c16891d2c5ffbdc1a005591c9.

13 months agoUpdate fileDelete.xml
Tim Düsterhus [Tue, 12 Sep 2023 11:14:54 +0000 (13:14 +0200)]
Update fileDelete.xml

13 months agoFix error message in PackageArchive::extractTar()
Tim Düsterhus [Fri, 8 Sep 2023 13:17:36 +0000 (15:17 +0200)]
Fix error message in PackageArchive::extractTar()

The two archive names were swapped.

13 months agoEnforce the width of the first column of `.boxN`
Alexander Ebert [Tue, 12 Sep 2023 10:20:07 +0000 (12:20 +0200)]
Enforce the width of the first column of `.boxN`

See https://www.woltlab.com/community/thread/301575-plugin-store-icons-in-boxen-zu-breit/

13 months agoFix the style variable value for `individualScssDarkMode`
Alexander Ebert [Mon, 11 Sep 2023 17:47:04 +0000 (19:47 +0200)]
Fix the style variable value for `individualScssDarkMode`

13 months agoRemove obsolete / deprecated code
Marcel Werk [Mon, 11 Sep 2023 15:00:16 +0000 (17:00 +0200)]
Remove obsolete / deprecated code

13 months agoRemove obsolete `__sidebarLeftHasMenu` parameter
Marcel Werk [Mon, 11 Sep 2023 10:15:17 +0000 (12:15 +0200)]
Remove obsolete `__sidebarLeftHasMenu` parameter

The notification list doesn't have a left sidebar anymore.

13 months agoAdjust event name to match the naming scheme
Marcel Werk [Mon, 11 Sep 2023 09:00:08 +0000 (11:00 +0200)]
Adjust event name to match the naming scheme

13 months agoMerge pull request #5648 from WoltLab/resolve-current-page-event
Marcel Werk [Mon, 11 Sep 2023 08:34:21 +0000 (10:34 +0200)]
Merge pull request #5648 from WoltLab/resolve-current-page-event

Add event for resolving the active page

13 months agoAdd the missing border to the rich embeds
Alexander Ebert [Sun, 10 Sep 2023 14:05:09 +0000 (16:05 +0200)]
Add the missing border to the rich embeds

Fixes #5646

13 months agoAdd event for resolving the active page
Marcel Werk [Sun, 10 Sep 2023 13:55:07 +0000 (15:55 +0200)]
Add event for resolving the active page

This event allows to add custom logic for resolving the active page.

13 months agoReliably discard the draft when discarding the editor
Alexander Ebert [Sun, 10 Sep 2023 13:17:00 +0000 (15:17 +0200)]
Reliably discard the draft when discarding the editor

See https://www.woltlab.com/community/thread/301527-zwischenspeicherung-von-nachrichten-wird-nicht-zur%C3%BCckgesetzt/

13 months agoLimit the maximum length of the option name
Alexander Ebert [Sun, 10 Sep 2023 12:59:18 +0000 (14:59 +0200)]
Limit the maximum length of the option name

See https://www.woltlab.com/community/thread/301557-fatal-error-zu-viele-zeichen-im-kontaktformular-im-feld-name/

13 months agoFix the hover color of overlay buttons
Alexander Ebert [Sun, 10 Sep 2023 10:13:36 +0000 (12:13 +0200)]
Fix the hover color of overlay buttons

See https://www.woltlab.com/community/thread/301487-ckeditor-unpassende-farbwerte-im-tabellen-widget/

13 months agoFix the binding of existing removal buttons
Alexander Ebert [Sun, 10 Sep 2023 09:56:29 +0000 (11:56 +0200)]
Fix the binding of existing removal buttons

The previous implementation of 5.5 lazily listened for clicks on the entire list which was refactored in 6.0 to bind on the delete button.

The existing contents of the ACL is statically generated in the template, but the delete button was not bound.

See https://www.woltlab.com/community/thread/301553-rechtevergabe-bei-seiten-l%C3%A4%C3%9Ft-sich-nicht-r%C3%BCckg%C3%A4ngig-machen/

13 months agoFix the color values when hovering drop-down menus
Alexander Ebert [Sat, 9 Sep 2023 16:11:39 +0000 (18:11 +0200)]
Fix the color values when hovering drop-down menus

See

13 months agoReintroduce the phrases for Plugin-Store references
Alexander Ebert [Sat, 9 Sep 2023 15:53:14 +0000 (17:53 +0200)]
Reintroduce the phrases for Plugin-Store references

See https://www.woltlab.com/community/thread/301521-fehlende-sprachvariable-wcf-acp-pluginstore-file-link/

13 months agoAlign the styling of the style changer to the footer menu
Alexander Ebert [Sat, 9 Sep 2023 15:06:23 +0000 (17:06 +0200)]
Align the styling of the style changer to the footer menu

See https://www.woltlab.com/community/thread/301491-mobil-stil-%C3%A4ndern-position-nicht-korrekt/

13 months agoBlur the active element when opening the image viewer
Alexander Ebert [Sat, 9 Sep 2023 15:02:34 +0000 (17:02 +0200)]
Blur the active element when opening the image viewer

See https://www.woltlab.com/community/thread/301522-logo-ckeditor-%C3%BCber-dem-bildbetrachter/

13 months agoSkip BBCode buttons that are already present
Alexander Ebert [Sat, 9 Sep 2023 14:51:24 +0000 (16:51 +0200)]
Skip BBCode buttons that are already present

See https://www.woltlab.com/community/thread/301518-ckeditor-eigenes-men%C3%BC/?postID=1938077#post1938077

13 months agoFix the width of the placeholder icon for attachments
Alexander Ebert [Fri, 8 Sep 2023 19:43:01 +0000 (21:43 +0200)]
Fix the width of the placeholder icon for attachments

See https://www.woltlab.com/community/thread/301526-icon-f%C3%BCr-dateianh%C3%A4nge-ist-zu-gro%C3%9F-bzw-breit/

13 months agoFix the inconsistent size of the user avatar
Alexander Ebert [Fri, 8 Sep 2023 19:34:57 +0000 (21:34 +0200)]
Fix the inconsistent size of the user avatar

See https://www.woltlab.com/community/thread/301525-the-user-avatar-is-smaller-in-the-admin-panel-header/

13 months agoFix the dimension check for images w/o thumbnail
Alexander Ebert [Fri, 8 Sep 2023 15:22:01 +0000 (17:22 +0200)]
Fix the dimension check for images w/o thumbnail

See https://www.woltlab.com/community/thread/301523-bilder-die-zu-klein-f%C3%BCr-eine-vorschau-sind-aber-gro%C3%9F-genug-f%C3%BCr-den-bildbetrachte/

13 months agoFix the color preview when HSL is the source
Alexander Ebert [Fri, 8 Sep 2023 14:49:12 +0000 (16:49 +0200)]
Fix the color preview when HSL is the source

13 months agoUse fixed saturation and lightness for the hue gradient
Alexander Ebert [Fri, 8 Sep 2023 14:48:33 +0000 (16:48 +0200)]
Use fixed saturation and lightness for the hue gradient

See https://www.woltlab.com/community/thread/301501-stileditor-farbauswahl-farbton-nicht-%C3%A4ndern/

13 months agoFix an error in the RGB to HSL conversion
Alexander Ebert [Fri, 8 Sep 2023 14:40:33 +0000 (16:40 +0200)]
Fix an error in the RGB to HSL conversion

13 months agoFix the check for installable packages when there are no packages
Alexander Ebert [Fri, 8 Sep 2023 13:25:08 +0000 (15:25 +0200)]
Fix the check for installable packages when there are no packages

See https://www.woltlab.com/community/thread/301509-fehler-beim-aufruf-der-lizenzen-im-acp/

13 months agoShow information on outdated / not owned products
Alexander Ebert [Fri, 8 Sep 2023 13:22:53 +0000 (15:22 +0200)]
Show information on outdated / not owned products

13 months agoImprove the navigation between `License` and `LicenseEdit`
Alexander Ebert [Fri, 8 Sep 2023 11:20:44 +0000 (13:20 +0200)]
Improve the navigation between `License` and `LicenseEdit`

13 months agoImprove the workflow for missing license credentials
Alexander Ebert [Fri, 8 Sep 2023 10:33:49 +0000 (12:33 +0200)]
Improve the workflow for missing license credentials

13 months agoMerge pull request #5647 from WoltLab/link-regex
Tim Düsterhus [Thu, 7 Sep 2023 13:20:15 +0000 (15:20 +0200)]
Merge pull request #5647 from WoltLab/link-regex

Fix catastrophic backtracking in FileUtil::LINK_REGEX

13 months agoFix the default value of placeholder badges
Alexander Ebert [Thu, 7 Sep 2023 13:01:54 +0000 (15:01 +0200)]
Fix the default value of placeholder badges

See https://www.woltlab.com/community/thread/301502-fehler-bei-troph%C3%A4en/

13 months agoFix the specificity of the active header menu
Alexander Ebert [Thu, 7 Sep 2023 12:54:17 +0000 (14:54 +0200)]
Fix the specificity of the active header menu

See https://www.woltlab.com/community/thread/301481-stil-erstellung-farbpalette-darstellung-inkorrekt/

13 months agoSuppress the box shadow for the CKEditor logo
Alexander Ebert [Thu, 7 Sep 2023 12:47:21 +0000 (14:47 +0200)]
Suppress the box shadow for the CKEditor logo

See https://www.woltlab.com/community/thread/301484-schatten-unterhalb-cke-logo/

13 months agoDrop useless groups in FileUtil::LINK_REGEX
Tim Düsterhus [Thu, 7 Sep 2023 12:37:53 +0000 (14:37 +0200)]
Drop useless groups in FileUtil::LINK_REGEX

13 months agoSimplify consecutive repetition operators in FileUtil::LINK_REGEX
Tim Düsterhus [Thu, 7 Sep 2023 12:36:28 +0000 (14:36 +0200)]
Simplify consecutive repetition operators in FileUtil::LINK_REGEX

This appeared with the previous commit and cause useless backtracking.

13 months agoRemove support for nested parentheses in FileUtil::LINK_REGEX
Tim Düsterhus [Thu, 7 Sep 2023 12:33:07 +0000 (14:33 +0200)]
Remove support for nested parentheses in FileUtil::LINK_REGEX

This does not provide a meaningful improvement in link detection and instead
just increases complexity of the regex.

13 months agoRemove inner capturing groups in FileUtil::LINK_REGEX
Tim Düsterhus [Thu, 7 Sep 2023 12:12:07 +0000 (14:12 +0200)]
Remove inner capturing groups in FileUtil::LINK_REGEX

13 months agoImprove domain detection in FileUtil::LINK_REGEX
Tim Düsterhus [Thu, 7 Sep 2023 11:55:44 +0000 (13:55 +0200)]
Improve domain detection in FileUtil::LINK_REGEX

With this change, the regex will no longer detect domains with two consecutive
dots and also the number of backtracking steps are reduced.

13 months agoAdd parameter types to various HtmlInputNodeTextParser methods
Tim Düsterhus [Thu, 7 Sep 2023 11:42:01 +0000 (13:42 +0200)]
Add parameter types to various HtmlInputNodeTextParser methods

This catches garbage inputs (specifically `null`) a little earlier and thus
improves debugging.

see https://www.woltlab.com/community/thread/301492-fehler-beim-aktualisieren-der-beitr%C3%A4ge/

13 months agoAdd the missing border of sidebar boxes
Alexander Ebert [Thu, 7 Sep 2023 11:19:50 +0000 (13:19 +0200)]
Add the missing border of sidebar boxes

See https://www.woltlab.com/community/thread/301499-stileditor-zeigt-keine-rahmenfarbe-an/

13 months agoAllow PHP 8.3 in SystemCheckPage
Tim Düsterhus [Thu, 7 Sep 2023 10:37:37 +0000 (12:37 +0200)]
Allow PHP 8.3 in SystemCheckPage

This also moves PHP 8.1 from recommended to supported.

see 3fd17ae60b9851c1d07c1f8dd22bff3fe7c2360c

13 months agoOfficially allow PHP 8.3
Tim Düsterhus [Thu, 7 Sep 2023 10:30:53 +0000 (12:30 +0200)]
Officially allow PHP 8.3

13 months agoMerge pull request #5645 from WoltLab/update-server-detect-paid-update
Alexander Ebert [Thu, 7 Sep 2023 09:55:30 +0000 (11:55 +0200)]
Merge pull request #5645 from WoltLab/update-server-detect-paid-update

Detect paid updates in the Plugin-Store during the process

13 months agoSimplify the check for the trusted servers
Alexander Ebert [Thu, 7 Sep 2023 09:44:42 +0000 (11:44 +0200)]
Simplify the check for the trusted servers

13 months agoDetect paid updates in the Plugin-Store during the process
Alexander Ebert [Wed, 6 Sep 2023 19:16:37 +0000 (21:16 +0200)]
Detect paid updates in the Plugin-Store during the process

See https://www.woltlab.com/community/thread/296689/

13 months agoMerge pull request #5644 from WoltLab/clean-suspicious-link-text
Tim Düsterhus [Thu, 7 Sep 2023 07:54:47 +0000 (09:54 +0200)]
Merge pull request #5644 from WoltLab/clean-suspicious-link-text

Reduce abuse potential of link values in UGC

14 months agoEnsure the URL's authority is fully visible when truncating link values
Tim Düsterhus [Wed, 6 Sep 2023 14:30:33 +0000 (16:30 +0200)]
Ensure the URL's authority is fully visible when truncating link values

14 months agoStrip suspicious link values in HTML content
Tim Düsterhus [Wed, 6 Sep 2023 14:11:16 +0000 (16:11 +0200)]
Strip suspicious link values in HTML content

14 months agoMove the link detection regex into a reusable constant
Tim Düsterhus [Wed, 6 Sep 2023 14:05:13 +0000 (16:05 +0200)]
Move the link detection regex into a reusable constant

see #5583

14 months agoRelease 6.0.0 Beta 4 6.0.0_Beta_4
Alexander Ebert [Wed, 6 Sep 2023 14:02:39 +0000 (16:02 +0200)]
Release 6.0.0 Beta 4

14 months agoUpdating minified JavaScript files
WoltLab [Wed, 6 Sep 2023 13:52:46 +0000 (13:52 +0000)]
Updating minified JavaScript files

14 months agoUpgrade to CKEditor v39.0.2
Alexander Ebert [Wed, 6 Sep 2023 13:47:08 +0000 (15:47 +0200)]
Upgrade to CKEditor v39.0.2

14 months agoFix the text color of drop down menus
Alexander Ebert [Wed, 6 Sep 2023 13:44:41 +0000 (15:44 +0200)]
Fix the text color of drop down menus

See https://www.woltlab.com/community/thread/301335-ckeditor-dropdown-css-variablen-%C3%A4ndern/

14 months agoClean up the CSS for footer boxes
Alexander Ebert [Wed, 6 Sep 2023 12:21:55 +0000 (14:21 +0200)]
Clean up the CSS for footer boxes

14 months agoMerge pull request #5643 from WoltLab/test-php
Tim Düsterhus [Wed, 6 Sep 2023 10:19:21 +0000 (12:19 +0200)]
Merge pull request #5643 from WoltLab/test-php

Update test.php

14 months agoAdd x64 check to test.php
Tim Düsterhus [Wed, 6 Sep 2023 09:33:30 +0000 (11:33 +0200)]
Add x64 check to test.php

see 46eadac2690f19f7d7ac3f82117e12ceef35e88b

14 months agoDo not check other PHP requirements if the PHP version is incompatible in test.php
Tim Düsterhus [Wed, 6 Sep 2023 09:27:27 +0000 (11:27 +0200)]
Do not check other PHP requirements if the PHP version is incompatible in test.php

If the PHP version is not compatible, we can't really trust the other results
anyway, because test.php itself might not be compatible with the PHP version in
question and also because a change of PHP version might also change the php.ini
/ loaded extensions.

14 months agoHandle `memory_limit=-1` in test.php
Tim Düsterhus [Wed, 6 Sep 2023 09:24:57 +0000 (11:24 +0200)]
Handle `memory_limit=-1` in test.php

14 months agoAdd PHP upper bound to test.php
Tim Düsterhus [Wed, 6 Sep 2023 09:21:32 +0000 (11:21 +0200)]
Add PHP upper bound to test.php

see #5626

14 months agoUnify parsing of memory limit in test.php with the software itself
Tim Düsterhus [Wed, 6 Sep 2023 09:10:17 +0000 (11:10 +0200)]
Unify parsing of memory limit in test.php with the software itself

14 months agoRun autoformatter on test.php
Tim Düsterhus [Wed, 6 Sep 2023 09:01:08 +0000 (11:01 +0200)]
Run autoformatter on test.php

14 months agoCollect PHP logic at the top of test.php
Tim Düsterhus [Wed, 6 Sep 2023 08:59:29 +0000 (10:59 +0200)]
Collect PHP logic at the top of test.php

14 months agoMerge pull request #5642 from WoltLab/license-page
Alexander Ebert [Tue, 5 Sep 2023 15:37:12 +0000 (17:37 +0200)]
Merge pull request #5642 from WoltLab/license-page

Add a license page to install WoltLab and Plugin-Store products

14 months agoAdd `#[\Override]` to Pipeline
Tim Düsterhus [Tue, 5 Sep 2023 15:31:25 +0000 (17:31 +0200)]
Add `#[\Override]` to Pipeline

14 months agoAdd `#[\Override]` to RequestHandlerMiddleware
Tim Düsterhus [Tue, 5 Sep 2023 15:30:38 +0000 (17:30 +0200)]
Add `#[\Override]` to RequestHandlerMiddleware

14 months agoAdd `#[\Override]` to LegacyPlaceholderResponse
Tim Düsterhus [Tue, 5 Sep 2023 15:29:21 +0000 (17:29 +0200)]
Add `#[\Override]` to LegacyPlaceholderResponse

14 months agoUpgrade to `actions/checkout@v4`
Tim Düsterhus [Tue, 5 Sep 2023 15:15:15 +0000 (17:15 +0200)]
Upgrade to `actions/checkout@v4`

14 months agoMerge branch '5.5'
Tim Düsterhus [Tue, 5 Sep 2023 15:14:46 +0000 (17:14 +0200)]
Merge branch '5.5'

14 months agoUpgrade to `actions/checkout@v4`
Tim Düsterhus [Tue, 5 Sep 2023 15:13:42 +0000 (17:13 +0200)]
Upgrade to `actions/checkout@v4`

14 months agoFix the check for installable packages
Alexander Ebert [Tue, 5 Sep 2023 15:07:18 +0000 (17:07 +0200)]
Fix the check for installable packages

14 months agoSlightly improve the phrasing of the developer notice
Alexander Ebert [Tue, 5 Sep 2023 14:32:13 +0000 (16:32 +0200)]
Slightly improve the phrasing of the developer notice

14 months agoSimplify the condition to order the packages
Alexander Ebert [Tue, 5 Sep 2023 14:31:41 +0000 (16:31 +0200)]
Simplify the condition to order the packages

14 months agoFix the indentation
Alexander Ebert [Tue, 5 Sep 2023 14:29:50 +0000 (16:29 +0200)]
Fix the indentation

14 months agoBlock parallel requests to install a package
Alexander Ebert [Tue, 5 Sep 2023 14:26:22 +0000 (16:26 +0200)]
Block parallel requests to install a package

14 months agoMerge branch '5.5'
Tim Düsterhus [Tue, 5 Sep 2023 12:58:21 +0000 (14:58 +0200)]
Merge branch '5.5'

14 months agoUpdate to `psr/http-message` 1.1
Tim Düsterhus [Tue, 5 Sep 2023 12:55:39 +0000 (14:55 +0200)]
Update to `psr/http-message` 1.1

14 months agoFix `license.tpl` showing official packages in the Plugin-Store section
Tim Düsterhus [Tue, 5 Sep 2023 12:20:05 +0000 (14:20 +0200)]
Fix `license.tpl` showing official packages in the Plugin-Store section

14 months agoFix a typo
Alexander Ebert [Tue, 5 Sep 2023 11:17:57 +0000 (13:17 +0200)]
Fix a typo

14 months agoRemove the legacy plugin store package search
Alexander Ebert [Tue, 5 Sep 2023 10:20:46 +0000 (12:20 +0200)]
Remove the legacy plugin store package search

14 months agoAdd the license page to the menu
Alexander Ebert [Tue, 5 Sep 2023 10:16:50 +0000 (12:16 +0200)]
Add the license page to the menu

14 months agoAllow description language in XSD/style.xsd
Tim Düsterhus [Tue, 5 Sep 2023 08:48:20 +0000 (10:48 +0200)]
Allow description language in XSD/style.xsd

14 months agoFix styleVariables.xsd
Tim Düsterhus [Tue, 5 Sep 2023 08:45:10 +0000 (10:45 +0200)]
Fix styleVariables.xsd

14 months agoHandle missing auth data and stale package lists
Alexander Ebert [Mon, 4 Sep 2023 18:16:09 +0000 (20:16 +0200)]
Handle missing auth data and stale package lists

14 months agoAdd a form to set up the license data
Alexander Ebert [Mon, 4 Sep 2023 16:13:23 +0000 (18:13 +0200)]
Add a form to set up the license data

14 months agoReplace the hard-wired data for the package server
Alexander Ebert [Thu, 31 Aug 2023 09:28:36 +0000 (11:28 +0200)]
Replace the hard-wired data for the package server

14 months agoImprove the visuals of the licensed products
Alexander Ebert [Wed, 23 Aug 2023 17:05:19 +0000 (19:05 +0200)]
Improve the visuals of the licensed products

14 months agoAdd the install functionality
Alexander Ebert [Wed, 23 Aug 2023 13:53:35 +0000 (15:53 +0200)]
Add the install functionality

14 months agoCheck which packages are installable
Alexander Ebert [Mon, 19 Jun 2023 11:42:54 +0000 (13:42 +0200)]
Check which packages are installable

14 months agoDetect already installed packages
Alexander Ebert [Sat, 17 Jun 2023 20:06:05 +0000 (22:06 +0200)]
Detect already installed packages