GitHub/MotorolaMobilityLLC/kernel-slsi.git
11 years agostaging: vt6655: fixed use of unnecessary braces in baseband.c
Archana kumari [Thu, 24 Oct 2013 18:29:47 +0000 (23:59 +0530)]
staging: vt6655: fixed use of unnecessary braces in baseband.c

This patch fixes use of unnecessary braces in baseband.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: vt6656: fix a brace coding style issue in power.c
Johannes Löthberg [Thu, 24 Oct 2013 05:26:46 +0000 (07:26 +0200)]
Staging: vt6656: fix a brace coding style issue in power.c

This patch fixes a brace warning in power.c found by checkpatch.pl

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: vt6655: Fix Sparse Warning for Static Declarations in wpa.c
Ebru Akagunduz [Wed, 23 Oct 2013 22:34:42 +0000 (01:34 +0300)]
Staging: vt6655: Fix Sparse Warning for Static Declarations in wpa.c

This patch fixes the Sparse Warning "symbol was not declared.
Should it be static?" in wpa.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: vt6655: Fix Sparse Warning for Static Declarations in tkip.c
Ebru Akagunduz [Wed, 23 Oct 2013 22:42:55 +0000 (01:42 +0300)]
Staging: vt6655: Fix Sparse Warning for Static Declarations in tkip.c

This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in tkip.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: removed braces from single line if-statement
Nandini Hanumanthagowda [Wed, 23 Oct 2013 18:50:12 +0000 (00:20 +0530)]
staging: vt6656: removed braces from single line if-statement

removed braces from if-control flow structs whenever it
contained only one statement to comply with the coding style

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: fixed indentation and unnecessary space errors
Nandini Hanumanthagowda [Wed, 23 Oct 2013 18:50:11 +0000 (00:20 +0530)]
staging: vt6656: fixed indentation and unnecessary space errors

Fixed the indentation errors and removed unnecessary space
warnings to comply with coding style

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: call usb_device_reset before netdev registration
Malcolm Priestley [Tue, 22 Oct 2013 19:00:22 +0000 (20:00 +0100)]
staging: vt6656: call usb_device_reset before netdev registration

The USB reset occurs after netdev registration if network manager
calls device_open too fast causing USB fails in main_usb.c: device_init_registers.

Move the usb reset to before register_netdev.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix no use of assignment in if condition
Rashika Kheria [Sun, 27 Oct 2013 13:19:31 +0000 (18:49 +0530)]
Staging: lustre: Fix no use of assignment in if condition

This patch fixes the following checkpatch.pl error in lustre/ldlm/interval_tree.c-
ERROR: do not use assignment in if condition

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:media: Use dev_dbg() instead of pr_debug()
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:28:28 +0000 (22:58 +0530)]
staging:media: Use dev_dbg() instead of pr_debug()

Use dev_dbg() instead of pr_debug() in go7007-usb.c.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:media: Use dev_info() instead of pr_info()
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:27:19 +0000 (22:57 +0530)]
staging:media: Use dev_info() instead of pr_info()

Use dev_info instead of pr_info() in go7007-usb.c.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: media: Use dev_err() instead of pr_err()
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:26:45 +0000 (22:56 +0530)]
staging: media: Use dev_err() instead of pr_err()

Use dev_err() instead of pr_err() in go7007-usb.c.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: media: lirc: Replaced printk macro with dev_info(dev,....) in lirc_imon.c
Archana kumari [Wed, 23 Oct 2013 19:47:41 +0000 (01:17 +0530)]
staging: media: lirc: Replaced printk macro with dev_info(dev,....) in lirc_imon.c

This patch replaces printk macro with dev_info(dev,....)
in lirc_imon.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ft1000: remove unnecessary static function declarations in ft1000_hw.c
Ebru Akagunduz [Thu, 24 Oct 2013 13:30:28 +0000 (16:30 +0300)]
Staging: ft1000: remove unnecessary static function declarations in ft1000_hw.c

This patch removes unnecessary static function
declarations in ft1000_hw.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ft1000: Fix Sparse Warning for Static Declarations in boot.h
Ebru Akagunduz [Tue, 22 Oct 2013 23:54:33 +0000 (02:54 +0300)]
Staging: ft1000: Fix Sparse Warning for Static Declarations in boot.h

This patch fixes the Sparse Warning: "symbol 'bootimage'
was not declared. Should it be static?" in boot.h

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ft1000: Fix Sparse Warning for Static Declarations in ft1000_hw.c
Ebru Akagunduz [Wed, 23 Oct 2013 18:29:22 +0000 (21:29 +0300)]
Staging: ft1000: Fix Sparse Warning for Static Declarations in ft1000_hw.c

This patch fixes the Sparse Warning: "symbol 'ft1000_reset'
was not declared. Should it be static?" in ft1000_hw.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: sep: add missing misc_deregister() on error in sep_register_driver_with_fs()
Wei Yongjun [Mon, 21 Oct 2013 05:33:50 +0000 (13:33 +0800)]
staging: sep: add missing misc_deregister() on error in sep_register_driver_with_fs()

Add the missing misc_deregister() before return from
sep_register_driver_with_fs() in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Replace __FUNCTION__ with __func__
Rashika Kheria [Sat, 26 Oct 2013 10:54:43 +0000 (16:24 +0530)]
Staging: lustre: Replace __FUNCTION__ with __func__

This patch fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_request.c-
WARNING: __func__ should be used instead of gcc specific __FUNCTION__

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix paranthesis not required around return
Rashika Kheria [Sat, 26 Oct 2013 10:54:02 +0000 (16:24 +0530)]
Staging: lustre: Fix paranthesis not required around return

This patch fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_extent.c-
ERROR: return is not a function, parentheses are not required

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix space required after ','
Rashika Kheria [Sat, 26 Oct 2013 10:53:21 +0000 (16:23 +0530)]
Staging: lustre: Fix space required after ','

This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c-
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix no spaces at the start of the line
Rashika Kheria [Sat, 26 Oct 2013 10:52:32 +0000 (16:22 +0530)]
Staging: lustre: Fix no spaces at the start of the line

This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c-
WARNING: please, no spaces at the start of a line

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix code indentation for conditional statements
Rashika Kheria [Sat, 26 Oct 2013 10:49:42 +0000 (16:19 +0530)]
Staging: lustre: Fix code indentation for conditional statements

This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c-
WARNING: suspect code indent for conditional statements

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix initialisation of statics to NULL or 0
Rashika Kheria [Fri, 25 Oct 2013 18:54:03 +0000 (00:24 +0530)]
Staging: lustre: Fix initialisation of statics to NULL or 0

This patch fixes the following checkpatch.pl error in
lnet/lnet/config.c:
ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging; lustre: Fix quoted string split across lines
Rashika Kheria [Fri, 25 Oct 2013 18:52:54 +0000 (00:22 +0530)]
Staging; lustre: Fix quoted string split across lines

This patch fixes the following checkpatch.pl issues in
lnet/lnet/config.c:
WARNING: quoted string split across lines

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix space prohibited between function and open paranthesis
Rashika Kheria [Fri, 25 Oct 2013 18:51:24 +0000 (00:21 +0530)]
Staging: lustre: Fix space prohibited between function and open paranthesis

This patch fixes the following checkpatch.pl warning in
lnet/lnet/config.c-
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: replaced C99 comment style by C89 style
Nandini Hanumanthagowda [Thu, 24 Oct 2013 18:06:17 +0000 (23:36 +0530)]
staging: lustre: replaced C99 comment style by C89 style

As per coding style guidelines C89 comment style /*...*/
is preferred over C99 comment style //, hence replaced
C99 comment style by C89 comment style to fix checkpatch
error

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: added space before the open parenthesis
Nandini Hanumanthagowda [Thu, 24 Oct 2013 18:06:16 +0000 (23:36 +0530)]
staging: lustre: added space before the open parenthesis

added space before the open parenthesis to fix checkpatch error

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix indentation of labels
Rashika Kheria [Thu, 24 Oct 2013 14:00:37 +0000 (19:30 +0530)]
Staging: lustre: Fix indentation of labels

This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
WARNING: labels should not be indented

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix initialisation of statics to 0 or NULL
Rashika Kheria [Thu, 24 Oct 2013 13:59:52 +0000 (19:29 +0530)]
Staging: lustre: Fix initialisation of statics to 0 or NULL

This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix quoted strings split across lines
Rashika Kheria [Thu, 24 Oct 2013 13:58:51 +0000 (19:28 +0530)]
Staging: lustre: Fix quoted strings split across lines

This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
WARNING: quoted string split across lines

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix EXPORT_SYMBOL should immediately follow its function/variable
Rashika Kheria [Thu, 24 Oct 2013 13:57:14 +0000 (19:27 +0530)]
Staging: lustre: Fix EXPORT_SYMBOL should immediately follow its function/variable

This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: lustre: Fix space prohibited between function name and open paranthesis
Rashika Kheria [Thu, 24 Oct 2013 13:56:23 +0000 (19:26 +0530)]
Staging: lustre: Fix space prohibited between function name and open paranthesis

This patch fixes the following checkpatch.pl issues in lnet/lnet/acceptor.c:
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agodrivers/staging/lustre/lustre/osc/osc_io.c : remove space prohibited warning
Himangi Saraogi [Wed, 23 Oct 2013 20:40:11 +0000 (02:10 +0530)]
drivers/staging/lustre/lustre/osc/osc_io.c : remove space prohibited warning

There was a warning on running checkpatch.pl on the file
drivers/staging/lustre/lustre/osc/osc_io.c which stated:
WARNING: space prohibited between function name and open parenthesis '('
108: FILE: staging/lustre/lustre/osc/osc_io.c:108:
+ LIST_HEAD     (list);

total: 0 errors, 1 warnings, 828 lines checked

To get rid of the warning the extra spaces were eliminated.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Valentina Manea [Wed, 23 Oct 2013 07:30:19 +0000 (10:30 +0300)]
staging: lustre: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

This patch fixes coccinelle error regarding usage of IS_ERR and
PTR_ERR instead of PTR_ERR_OR_ZERO.

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: lnet: Reformat pointer variable in lib-lnet.h
Lisa Nguyen [Tue, 22 Oct 2013 04:52:29 +0000 (21:52 -0700)]
staging: lustre: lnet: Reformat pointer variable in lib-lnet.h

Reformat a pointer variable in lib-lnet.h to meet kernel
coding style and eliminate pointer format warning
generated by checkpatch.pl

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: lnet: Remove unnecessary () from return statements
Lisa Nguyen [Tue, 22 Oct 2013 04:52:03 +0000 (21:52 -0700)]
staging: lustre: lnet: Remove unnecessary () from return statements

Remove unnecessary parentheses from return statements in lib-lnet.h
to meet kernel coding style.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: lnet: Remove unnecessary spaces in lib-lnet.h
Lisa Nguyen [Tue, 22 Oct 2013 04:51:37 +0000 (21:51 -0700)]
staging: lustre: lnet: Remove unnecessary spaces in lib-lnet.h

Remove spaces between function names and open parentheses to
meet kernel coding style and eliminate extra space warnings
generated by checkpatch.pl

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Remove typedef and update cfs_hash struct
Lisa Nguyen [Tue, 22 Oct 2013 01:16:26 +0000 (18:16 -0700)]
staging: lustre: Remove typedef and update cfs_hash struct

Remove typedef keyword and rename the cfs_hash_t struct to
cfs_hash in libcfs_hash.h. These changes resolve the "Do
not add new typedefs" warning generated by checkpatch.pl
and meet kernel coding style.

Struct variables in other header and source files that
depend on libcfs_hash.h are updated as well.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Remove typedef and update cfs_hash_bd struct
Lisa Nguyen [Tue, 22 Oct 2013 01:16:05 +0000 (18:16 -0700)]
staging: lustre: Remove typedef and update cfs_hash_bd struct

Remove typedef keyword and rename the cfs_hash_bd_t struct to
cfs_hash_bd in libcfs_hash.h. These changes resolve the
"Do not add new typedefs" warning generated by checkpatch.pl
and meet kernel coding style.

Struct variables in other header and source files that depend
on libcfs_hash.h are updated as well.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Remove typedef and update cfs_debug_limit_state struct
Lisa Nguyen [Tue, 22 Oct 2013 01:15:39 +0000 (18:15 -0700)]
staging: lustre: Remove typedef and update cfs_debug_limit_state struct

Removed typedef keyword and rename the cfs_debug_limit_state_t
struct to cfs_debug_limit_state in libcfs_debug.h. These changes
resolve the "Do not add new typedefs" warning generated by
checkpatch.pl and meet kernel coding style.

Struct variables in other header and source files
that depend on libcfs_debug.h are updated as well.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: fix tv_usec build warning on parisc
Peng Tao [Mon, 21 Oct 2013 15:18:24 +0000 (23:18 +0800)]
staging/lustre: fix tv_usec build warning on parisc

As reported by Fengguang:

config: make ARCH=parisc allyesconfig

All warnings:

   drivers/staging/lustre/lustre/llite/lproc_llite.c: In function 'll_rw_extents_stats_pp_seq_show':
>> drivers/staging/lustre/lustre/llite/lproc_llite.c:1069:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__kernel_suseconds_t' [-Wformat]
   drivers/staging/lustre/lustre/llite/lproc_llite.c: In function 'll_rw_extents_stats_seq_show':
>> drivers/staging/lustre/lustre/llite/lproc_llite.c:1133:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__kernel_suseconds_t' [-Wformat]
   drivers/staging/lustre/lustre/llite/lproc_llite.c: In function 'll_rw_offset_stats_seq_show':
>> drivers/staging/lustre/lustre/llite/lproc_llite.c:1299:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__kernel_suseconds_t' [-Wformat]
--
   drivers/staging/lustre/lustre/obdclass/lprocfs_status.c: In function 'lprocfs_stats_seq_show':
>> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1070:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type '__kernel_suseconds_t' [-Wformat]
--
   drivers/staging/lustre/lustre/osc/lproc_osc.c: In function 'osc_rpc_stats_seq_show':
>> drivers/staging/lustre/lustre/osc/lproc_osc.c:575:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__kernel_suseconds_t' [-Wformat]
   drivers/staging/lustre/lustre/osc/lproc_osc.c: In function 'osc_stats_seq_show':
>> drivers/staging/lustre/lustre/osc/lproc_osc.c:687:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type '__kernel_suseconds_t' [-Wformat]

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/llite: fix mkdir endless loop
Peng Tao [Mon, 21 Oct 2013 15:18:23 +0000 (23:18 +0800)]
staging/lustre/llite: fix mkdir endless loop

Running on 3.11-rc4 kernel, I got below endless loop. It turns to be that Lustre
always saves the first page of a dir inode mapping at index ~0UL.  And after
commit 5a720394 (mm: teach truncate_inode_pages_range() to handle non page
aligned ranges), truncate_inode_pages_range() _NO LONGER_ truncates the page
that is sitting at index ~0UL.

[16768.998006] mkdir           R  running task        0  2717   2716 0x00000080
[16768.998073]  000000000000000e 0000000000000000 0000000000000000 ffff88000be00460
[16768.998157]  ffff88000ea65908 ffffffff810fec3e ffff88000ea65968 ffff8800229e7750
[16768.998241]  ffff88000ea658b8 0000000000000000 0000000000000000 ffff88000ea65958
[16768.998326] Call Trace:
[16768.998401]  [<ffffffff810fc6ed>] ? rcu_read_unlock+0x1c/0x2d
[16768.998473]  [<ffffffff810fec3e>] ? find_get_pages+0xf5/0x11b
[16768.998530]  [<ffffffff811078f0>] ? pagevec_lookup+0x20/0x2a
[16768.998586]  [<ffffffff8110920e>] ? truncate_inode_pages_range.part.2+0x161/0x39a
[16768.998680]  [<ffffffffa02ad5dc>] ? ll_md_blocking_ast+0x338/0x62f [lustre]
[16768.998744]  [<ffffffff8110947f>] ? truncate_inode_pages_range+0x38/0x3f
[16768.998805]  [<ffffffff811094f8>] ? truncate_inode_pages+0x12/0x14
[16768.998871]  [<ffffffffa02ad6e8>] ? ll_md_blocking_ast+0x444/0x62f [lustre]
[16768.998948]  [<ffffffff810981b5>] ? arch_local_irq_save+0x9/0xc
[16768.999022]  [<ffffffffa07ee0e8>] ? ldlm_cancel_callback+0x67/0x12a [ptlrpc]
[16768.999100]  [<ffffffffa07f85b2>] ? ldlm_cli_cancel_local+0xf3/0x2bc [ptlrpc]
[16768.999176]  [<ffffffffa07f9163>] ? ldlm_cli_cancel_list_local+0x7e/0x1e4 [ptlrpc]
[16768.999268]  [<ffffffffa07f9473>] ? ldlm_cancel_resource_local+0x1aa/0x1b9 [ptlrpc]
[16768.999385]  [<ffffffffa0657bad>] ? mdc_resource_get_unused+0xf8/0x115 [mdc]
[16768.999472]  [<ffffffff8109c887>] ? trace_hardirqs_on+0xd/0xf
[16768.999533]  [<ffffffffa06583d8>] ? mdc_create+0x11e/0x4db [mdc]
[16768.999597]  [<ffffffff8152ed84>] ? mutex_unlock+0xe/0x10
[16768.999654]  [<ffffffffa0350e99>] ? lmv_create+0x355/0x3e9 [lmv]
[16768.999712]  [<ffffffff811553b7>] ? final_putname+0x35/0x39
[16768.999775]  [<ffffffffa02ae167>] ? ll_new_node+0x33b/0x3ff [lustre]
[16768.999841]  [<ffffffffa02ae62c>] ? ll_mkdir+0xf2/0x127 [lustre]
[16768.999897]  [<ffffffff81156996>] ? vfs_mkdir+0x84/0xc9
[16768.999961]  [<ffffffff81158cf8>] ? SyS_mkdirat+0x77/0xad
[16769.000014]  [<ffffffff81158d47>] ? SyS_mkdir+0x19/0x1b
[16769.000066]  [<ffffffff81538652>] ? system_call_fastpath+0x16/0x1b

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agolustre/fld: remove fld_thread_key
Peng Tao [Mon, 21 Oct 2013 15:18:22 +0000 (23:18 +0800)]
lustre/fld: remove fld_thread_key

It is left over when porting Lustre tree patch in commit (e62e5d92) and should be
removed.

Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Remove typedef and update cfs_hash_bucket struct
Lisa Nguyen [Mon, 21 Oct 2013 05:53:49 +0000 (22:53 -0700)]
staging: lustre: Remove typedef and update cfs_hash_bucket struct

Remove typedef keyword and rename the cfs_hash_bucket_t struct to
cfs_hash_bucket in libcfs_hash.h. These changes resolve the
"Do not add new typedefs" warning generated by checkpatch.pl and
meet kernel coding style.

The struct variables in hash.c are updated to reflect this change
as well.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: sb105x: Fix a possible null dereference
Rashika Kheria [Sun, 20 Oct 2013 12:59:55 +0000 (18:29 +0530)]
Staging: sb105x: Fix a possible null dereference

This patch fixes the following error in sb_pc_mp.c-

drivers/staging/sb105x/sb_pci_mp.c:546 mp_startup() error: we previously assumed 'info->tty' could be null (see line 525)

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ashmem: Fix ASHMEM_PURGE_ALL_CACHES return value
John Stultz [Mon, 21 Oct 2013 16:58:07 +0000 (09:58 -0700)]
staging: ashmem: Fix ASHMEM_PURGE_ALL_CACHES return value

Hopefully this isn't too late for 3.12.

In commit 7dc19d5aff (convert shrinkers to new count/scan API)
the return value to PURGE_ALL_CACHES was dropped, causing -EPERM
to always be returned.

This patch re-adds the ret assignment, setting it to the the
ashmem_shrink_count(), which is the lru_count.

(Sorry this was missed in the review!)

Fixes: 7dc19d5affd7 ("convert shrinkers to new count/scan API")
Cc: Colin Cross <ccross@android.com>
Cc: Android Kernel Team <kernel-team@android.com>
Cc: Glauber Costa <glommer@openvz.org>
Reported-by: YongQin Liu <yongqin.liu@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Cc: stable <stable@kernel.org> # 3.12
Acked-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: Remove typedef and update cfs_hash_lock union
Lisa Nguyen [Mon, 21 Oct 2013 04:33:20 +0000 (21:33 -0700)]
staging: lustre: Remove typedef and update cfs_hash_lock union

Remove typedef keyword and rename the cfs_hash_lock_t
union to cfs_hash_lock in libcfs_hash.h. These changes
resolve the "Do not add new typedefs" warning
generated by checkpatch.pl and meet kernel coding style.

The union variables in hash.c are updated to reflect this
change as well.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: replace foo* with foo *
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:35:00 +0000 (23:05 +0530)]
staging:lustre: replace foo* with foo *

Fix checkpatch.pl warning of "(foo*)" should be "(foo *)" in lustre/lov

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: Fix externs should be avoided in .c files warning
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:35:37 +0000 (23:05 +0530)]
staging:lustre: Fix externs should be avoided in .c files warning

Fix the checkpatch.pl warning 'externs should be avoided in .c files' in
lustre/lov.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: Fix space before open parenthesis
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:36:09 +0000 (23:06 +0530)]
staging:lustre: Fix space before open parenthesis

Fix checkpatch.pl error "space required before the open parenthesis '('"
in lustre/lov.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: Replace max() with max_t()
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:36:35 +0000 (23:06 +0530)]
staging:lustre: Replace max() with max_t()

Replace max() with max_t() in accordance to chekpatch.pl warning in
lov_obd.c.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: Fix C99 style comments
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:37:24 +0000 (23:07 +0530)]
staging:lustre: Fix C99 style comments

Fix C99 style comments in lov_obd.c in accordance to checkpatch.pl
warning.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging:lustre: Remove space between function name and open parenthesis
Dulshani Gunawardhana [Sun, 20 Oct 2013 17:33:13 +0000 (23:03 +0530)]
staging:lustre: Remove space between function name and open parenthesis

Remove checkpatch.pl warning of space prohibited between function name
and open parenthesis '('in /lustre/lov.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: libcfs: Remove bitmap.h file
Lisa Nguyen [Sun, 20 Oct 2013 16:06:18 +0000 (09:06 -0700)]
staging: lustre: libcfs: Remove bitmap.h file

The functions in the bitmap.h header file are not being used by
any source file in the lustre driver.

Unless there are any objections, please remove the bitmap.h
header file as it contains unused code in the kernel.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: rtl8187se: checkpatch cleanups
Teodora Baluta [Sat, 19 Oct 2013 18:09:48 +0000 (21:09 +0300)]
staging: rtl8187se: checkpatch cleanups

Fix the following checkpatch.pl errors:

drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:890: "foo* bar" should be "foo *bar"
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:944: "foo* bar" should be "foo *bar"

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: rtl8187se: fix static sparse warnings
Teodora Baluta [Sat, 19 Oct 2013 18:09:47 +0000 (21:09 +0300)]
staging: rtl8187se: fix static sparse warnings

This patch fixes sparse warnings regarding functions that should be
static in driver rtl8187se.

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: rtl8187se: add missing __iomem annotation
Teodora Baluta [Sat, 19 Oct 2013 18:09:46 +0000 (21:09 +0300)]
staging: rtl8187se: add missing __iomem annotation

Fix the following type of sparse warnings:

drivers/staging/rtl8187se/r8180_core.c:163:48: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/rtl8187se/r8180_core.c:163:48:    expected void const volatile [noderef] <asn:2>*addr
drivers/staging/rtl8187se/r8180_core.c:163:48:    got unsigned char [usertype] *

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: rtl8187se: use gfp_t instead of int
Teodora Baluta [Sat, 19 Oct 2013 18:09:45 +0000 (21:09 +0300)]
staging: rtl8187se: use gfp_t instead of int

Fix the following type of sparse warnings:

drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17:    expected restricted gfp_t [usertype] flags
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17:    got int [signed] gfp_mask

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: sb105x: Remove redundant null check
Rashika Kheria [Sat, 19 Oct 2013 17:35:01 +0000 (23:05 +0530)]
Staging: sb105x: Remove redundant null check

This patch fixes the following Sparse information in sb_pci_mp.c-

~/git/kernels/linux/drivers/staging/sb105x/sb_pci_mp.c:1813
mp_unregister_driver() info: redundant null check on drv->state calling kfree()

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: line6: replacing -EINVAL with retval in driver.c
Ashvini Varatharaj [Sat, 19 Oct 2013 16:31:22 +0000 (22:01 +0530)]
Staging: line6: replacing -EINVAL with retval in driver.c

drivers/staging/line6/driver.c:208 line6_send_raw_message_async_part()
info: why not propagate 'retval' from usb_submit_urb() instead of (-22)?

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: line6: replacing -EINVAL with retval
Ashvini Varatharaj [Sat, 19 Oct 2013 16:23:37 +0000 (21:53 +0530)]
Staging: line6: replacing -EINVAL with retval

drivers/staging/line6/midi.c:147 send_midi_async() info: why not
propagate 'retval' from usb_submit_urb() instead of (-22)?

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup: replacing simple_strtoul with kstrtoul
Ashvini Varatharaj [Sat, 19 Oct 2013 15:28:26 +0000 (20:58 +0530)]
Staging: speakup: replacing simple_strtoul with kstrtoul

Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use
kstrtoul instead

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: sep: Fix Smatch Warning in sep_crypto.c
Rashika Kheria [Sat, 19 Oct 2013 10:23:21 +0000 (15:53 +0530)]
Staging: sep: Fix Smatch Warning in sep_crypto.c

This patch fixes the following smatch warning-

~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1137
sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)?
~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1152
sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)?

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6655: Fix C99 commenting style in michael.h
Archana kumari [Sat, 19 Oct 2013 10:17:04 +0000 (15:47 +0530)]
staging: vt6655: Fix C99 commenting style in michael.h

This patch fixes C99 commenting style in staging:vt6655:michael.h

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: slicoss: Fix quoted string split across lines
Rashika Kheria [Sat, 19 Oct 2013 07:47:59 +0000 (13:17 +0530)]
Staging: slicoss: Fix quoted string split across lines

This patch fixes the following checkpatch.pl warning in slicoss.c-
WARNING: quoted string split across lines

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: slicoss: Refactor code by introducing new function slic_interrupt_card_up()
Rashika Kheria [Sat, 19 Oct 2013 07:47:10 +0000 (13:17 +0530)]
Staging: slicoss: Refactor code by introducing new function slic_interrupt_card_up()

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Too many leading tabs - consider code refactoring

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: slicoss: Replace printk() with pr_debug() or dev_dbg() as required
Rashika Kheria [Sat, 19 Oct 2013 07:45:53 +0000 (13:15 +0530)]
Staging: slicoss: Replace printk() with pr_debug() or dev_dbg() as required

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then
pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: slicoss: Removal of if check since debugfs_remove(NULL) is safe
Rashika Kheria [Sat, 19 Oct 2013 07:43:36 +0000 (13:13 +0530)]
Staging: slicoss: Removal of if check since debugfs_remove(NULL) is safe

This patch fixes the following checkpatch.pl warning in slicoss.c:
WARNING: debugfs_remove(NULL) is safe this check is probably not
required

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: dgnc: avoiding buffer overflow
Ashvini Varatharaj [Sat, 19 Oct 2013 09:52:28 +0000 (15:22 +0530)]
Staging: dgnc: avoiding buffer overflow

drivers/staging/dgnc/dgnc_neo.c:1969 neo_vpd() error: buffer overflow 'brd->vpd' 128 <= 128
drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130
drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: dgnc: removing the comparison 'board<0'
Ashvini Varatharaj [Sat, 19 Oct 2013 07:56:44 +0000 (13:26 +0530)]
Staging: dgnc: removing the comparison 'board<0'

Fix dgnc_mgmt_ioctl() warn: unsigned 'board' is never less than zero.

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: braces {} are not necessary for single statement in dgnc_driver.c
Archana kumari [Fri, 18 Oct 2013 08:22:51 +0000 (13:52 +0530)]
staging: dgnc: braces {} are not necessary for single statement in dgnc_driver.c

Fixes "braces {} are not necessary for single statement blocks" warning
in dgnc_driver.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc:Removed unecessary error messages in dgnc_driver.c
Archana kumari [Fri, 18 Oct 2013 08:19:50 +0000 (13:49 +0530)]
staging: dgnc:Removed unecessary error messages in dgnc_driver.c

Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: wlags49_h2: Fixes the sparse warning in sta_h2.c
Archana kumari [Sat, 19 Oct 2013 14:15:11 +0000 (19:45 +0530)]
staging: wlags49_h2: Fixes the sparse warning in sta_h2.c

This patch fixes sparse warning "Using plain integer as NULL pointer" in
sta_h2.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: wlags49_h2: fixed space prohibited warnings in hcf.h
Archana kumari [Sat, 19 Oct 2013 12:11:27 +0000 (17:41 +0530)]
staging: wlags49_h2: fixed space prohibited warnings in hcf.h

This patch fixes the following warnings in hcf.c:
"space prohibited between function name and open parenthesis '(' "

"space prohibited before that close parenthesis ')' ".

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: bitfield manipulation macros for CRA, CRB and setup
Ian Abbott [Fri, 18 Oct 2013 13:40:55 +0000 (14:40 +0100)]
staging: comedi: s626: bitfield manipulation macros for CRA, CRB and setup

Some bits of the 'CRB' register have different functions when read or
written, so add macros to define the read-only parts.

Add macros to define the widths of the bitfields in the 'CRA' and 'CRB'
registers and the standard encoder setup value.

Add macros to construct and extract parts of the 'CRA' and 'CRB'
register values and the standard encoder setup value, along with a
couple of general helper macros for the above.

Redefine the bitfield mask macros for 'CRA', 'CRB' and standard encoder
setup using the above.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: add missing bits for 'CRB' register
Ian Abbott [Fri, 18 Oct 2013 13:40:54 +0000 (14:40 +0100)]
staging: comedi: s626: add missing bits for 'CRB' register

There are some bits in the 'CRB' register not defined in "s626.h".
Three of these are read-only bits that overlay the write-only interrupt
control bits.  Another missing bit controls whether counter 'B' is
cleared when counter 'A' overflows.  Add the missing bit definitions for
completeness.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: correct S626_CRAMSK_CLKPOL_A macro (unused)
Ian Abbott [Fri, 18 Oct 2013 13:40:53 +0000 (14:40 +0100)]
staging: comedi: s626: correct S626_CRAMSK_CLKPOL_A macro (unused)

The counter 'A' clock polarity field in the 'CRA' register is only 1 bit
wide, but the `S626_CRAMSK_CLKPOL_A` macro shows it as 2 bits wide,
which would overlap with the counter 'A' interrupt source field.  This
is harmless as the macro isn't actually used yet, but correct it anyway
as I want to use it!

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: distinguish counter src from encoder mode
Ian Abbott [Fri, 18 Oct 2013 13:40:52 +0000 (14:40 +0100)]
staging: comedi: s626: distinguish counter src from encoder mode

The macros `S626_CLKSRC_COUNTER`, `S626_CLKSRC_TIMER` and
`S626_CLKSRC_EXTENDER` are used logically to set the operating mode of
an encoder channel.  `S626_CLKSRC_COUNTER` (0) is also used as a 2-bit
physical value to set the counter source of an encoder channel to
"encoder".

Rename the macros to `S626_ENCMODE_COUNTER`, `S626_ENCMODE_TIMER` and
`S626_ENCMODE_EXTENDER` and rename some other macros and (unused)
functions relating to the encoder mode for consistency.

Define new macros to specify the physical counter source values for the
'CRA' register and rename the corresponding bitshift and mask macros
accordingly.  The physical values for the counter source are:

  S626_CNTSRC_ENCODER = 0      // encoder
  S626_CNTSRC_DIGIN = 1        // digital inputs
  S626_CNTSRC_SYSCLK = 2       // system clock up
  S626_CNTSRC_SYSCLK_DOWN = 3  // system clock down

Also use the `S626_CNTSRC_SYSCLK` value as a bitmask (bit 1) to indicate
either of the system clock values, with the direction (bit 0) indicated
separately in this case.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: correct a comment in s626_get_mode_b()
Ian Abbott [Fri, 18 Oct 2013 13:40:51 +0000 (14:40 +0100)]
staging: comedi: s626: correct a comment in s626_get_mode_b()

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: specify bitshift for encoder A clock source
Ian Abbott [Fri, 18 Oct 2013 13:40:50 +0000 (14:40 +0100)]
staging: comedi: s626: specify bitshift for encoder A clock source

When setting the clock source for one of the 'A' encoders to operate in
"counter" mode in `s626_set_mode_a()`, bitshift the clock source value by
`S626_CRABIT_CLKSRC_A` for consistency with the other modes.  This has
no effect on the value since `S626_CRABIT_CLKSRC_A` is 0.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: s626: clock polarity and direction are the same
Ian Abbott [Fri, 18 Oct 2013 13:40:49 +0000 (14:40 +0100)]
staging: comedi: s626: clock polarity and direction are the same

When setting up an encoder channel, the setup value includes a polarity
and direction, but these are the same bit of the setup value:

  S626_CLKPOL_POS = S626_CNTDIR_UP = 0

  S626_CLKPOL_NEG = S626_CNTDIR_DOWN = 1

In the construction of the setup value, both the CLKPOL and the CNTDIR
constants are shifted by the same amount `S626_BF_CLKPOL`.  Only the
following combinations are set up currently (this may change if user
configuration of the encoder is implemented properly):

  (S626_CLKPOL_POS << S626_BF_CLKPOL)

  (S626_CLKPOL_POS << S626_BF_CLKPOL) |
  (S626_CNTDIR_UP << S626_BF_CLKPOL)

  (S626_CLKPOL_POS << S626_BF_CLKPOL) |
  (S626_CNTDIR_DOWN << S626_BF_CLKPOL)

The first two are used in "counter" mode and is equivalent to:

  (S626_CLKPOL_POS << S626_BF_CLKPOL)

The last one is used in "timer" mode and is equivalent to:

  (S626_CNTDIR_DOWN << S626_BF_CLKPOL)

Use the shorter equivalents.  The comments in "s626.h" indicate that the
'CLKPOL' constants make more sense for the "counter" mode (when the
encoders operate as up/down counters) and the 'CNTDIR' constants make
more sense for the "timer" mode.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: rtd520: use normal bitfield functions
Ian Abbott [Thu, 17 Oct 2013 11:06:34 +0000 (12:06 +0100)]
staging: comedi: rtd520: use normal bitfield functions

The `unsigned char chan_is_bipolar[]` member of `struct rtd_private` is
used with some macros as a packed array of 1-bit values that indicate
whether the corresponding entries in the hardware's "channel-gain" table
have been set to a bipolar (1) or unipolar (0) range, as the raw samples
from the hardware need to be cooked differently in each case.

Replace the declaration of the member with a standard Linux bitfield
using `DECLARE_BITFIELD()`, and replace the home-grown macros used
access the bitfield with the standard Linux non-atomic bitop functions,
`__set_bit()`, `__clear_bit()` and `test_bit()`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ft1000: fixed two coding style issues
Aldo Iljazi [Fri, 18 Oct 2013 15:14:31 +0000 (18:14 +0300)]
Staging: ft1000: fixed two coding style issues

Fixed two coding style issues, specifically:

ft1000_proc.c:35: ERROR: space required before the open parenthesis '('
ft1000_proc.c:42: ERROR: space required before the open parenthesis '('

Signed-off-by: Aldo Iljazi <me@aldo.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: xillybus: Use dev_* functions instead of pr_* in xillybus_core
Eli Billauer [Fri, 18 Oct 2013 22:02:28 +0000 (01:02 +0300)]
staging: xillybus: Use dev_* functions instead of pr_* in xillybus_core

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: xillybus: Use dev_* functions instead of pr_* in xillybus_of
Eli Billauer [Fri, 18 Oct 2013 22:02:27 +0000 (01:02 +0300)]
staging: xillybus: Use dev_* functions instead of pr_* in xillybus_of

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: xillybus: Use dev_* functions instead of pr_* in xillybus_pcie
Eli Billauer [Fri, 18 Oct 2013 22:02:26 +0000 (01:02 +0300)]
staging: xillybus: Use dev_* functions instead of pr_* in xillybus_pcie

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: xillybus: Remember device pointer for use with dev_* functions
Eli Billauer [Fri, 18 Oct 2013 22:02:25 +0000 (01:02 +0300)]
staging: xillybus: Remember device pointer for use with dev_* functions

This is necessary so that xillybus_core uses the correct device pointer
for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info)

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Remove unnecessary spaces in router_proc.c
Lisa Nguyen [Fri, 18 Oct 2013 18:52:41 +0000 (11:52 -0700)]
staging/lustre/lnet: Remove unnecessary spaces in router_proc.c

Remove unnecessary spaces between function names and open
parentheses in router_proc.c to meet kernel coding style.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Fix static initialization error in router_proc.c
Lisa Nguyen [Fri, 18 Oct 2013 18:52:34 +0000 (11:52 -0700)]
staging/lustre/lnet: Fix static initialization error in router_proc.c

Fixed the static initialization error generated by checkpatch.pl to
meet kernel coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Reformat pointer variable in lib-move.c
Lisa Nguyen [Fri, 18 Oct 2013 09:12:18 +0000 (02:12 -0700)]
staging/lustre/lnet: Reformat pointer variable in lib-move.c

Reformat a pointer variable in lib-move.c to meet kernel
coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Remove () from return statements in lib-move.c
Lisa Nguyen [Fri, 18 Oct 2013 09:12:11 +0000 (02:12 -0700)]
staging/lustre/lnet: Remove () from return statements in lib-move.c

Remove unnecessary parentheses from return statements to
eliminate errors generated by checkpatch.pl and meet kernel
coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Adjust lines to meet 80 column limit in lib-move.c
Lisa Nguyen [Fri, 18 Oct 2013 09:12:02 +0000 (02:12 -0700)]
staging/lustre/lnet: Adjust lines to meet 80 column limit in lib-move.c

Fixed lines to not exceed more than 80 columns per line to meet
kernel coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Move open braces to previous lines in lib-move.c
Lisa Nguyen [Fri, 18 Oct 2013 09:11:54 +0000 (02:11 -0700)]
staging/lustre/lnet: Move open braces to previous lines in lib-move.c

Move open braces to previous lines in lib-move.c to meet kernel
coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet: Remove unnecessary whitespace in lib-move.c
Lisa Nguyen [Fri, 18 Oct 2013 09:11:44 +0000 (02:11 -0700)]
staging/lustre/lnet: Remove unnecessary whitespace in lib-move.c

Remove unnecessary whitespace around open parentheses in lib-move.c
to meet kernel coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet/selftest: Remove unnecessary spaces in brw_test.c
Lisa Nguyen [Fri, 18 Oct 2013 06:03:48 +0000 (23:03 -0700)]
staging/lustre/lnet/selftest: Remove unnecessary spaces in brw_test.c

Remove spaces between function names and open parentheses to
eliminate warnings generated by checkpatch.pl and meet kernel
coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lnet/selftest: Fix trailing statements in brw_test.c
Lisa Nguyen [Fri, 18 Oct 2013 06:03:38 +0000 (23:03 -0700)]
staging/lustre/lnet/selftest: Fix trailing statements in brw_test.c

Fix trailing statement errors generated by checkpatch.pl in
brw_test.c to meet kernel coding standards.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoMerge 3.12-rc6 into staging-next.
Greg Kroah-Hartman [Sat, 19 Oct 2013 20:14:34 +0000 (13:14 -0700)]
Merge 3.12-rc6 into staging-next.

We want these fixes in here as well.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoLinux 3.12-rc6
Linus Torvalds [Sat, 19 Oct 2013 19:28:15 +0000 (12:28 -0700)]
Linux 3.12-rc6

11 years agostaging: rtl8192u: fix sparse warning, make a function static
Teodora Baluta [Fri, 18 Oct 2013 18:37:47 +0000 (21:37 +0300)]
staging: rtl8192u: fix sparse warning, make a function static

Fix the following sparse warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup: removing jiffies comparison in speakup_apollo.c
Ashvini Varatharaj [Sat, 19 Oct 2013 03:30:59 +0000 (09:00 +0530)]
Staging: speakup: removing jiffies comparison in speakup_apollo.c

Fix checkpatch warning: WARNING: Comparing jiffies is almost always
wrong; prefer time_after, time_before and friends

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup: removing jiffies comparison using time_after_eq()
Ashvini Varatharaj [Sat, 19 Oct 2013 03:21:20 +0000 (08:51 +0530)]
Staging: speakup: removing jiffies comparison using time_after_eq()

Fix checkpatch warning:  Comparing jiffies is almost always wrong;
prefer time_after, time_before and friends

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>