GitHub/WoltLab/WCF.git
5 years agoMake the AbstractAttachmentImporter calculate file metadata itself
Tim Düsterhus [Fri, 28 Jun 2019 14:09:05 +0000 (16:09 +0200)]
Make the AbstractAttachmentImporter calculate file metadata itself

5 years agoMerge branch 'master' into next
Tim Düsterhus [Tue, 18 Jun 2019 18:32:44 +0000 (20:32 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Tim Düsterhus [Tue, 18 Jun 2019 18:31:05 +0000 (20:31 +0200)]
Merge branch '3.0'

5 years agoStop `exit`ing when no output was created in ExportMailAddressUserBulkProcessingAction
Tim Düsterhus [Tue, 18 Jun 2019 18:30:18 +0000 (20:30 +0200)]
Stop `exit`ing when no output was created in ExportMailAddressUserBulkProcessingAction

5 years agoThrow exception in `WCF::__call()` for undefined methods
Matthias Schmidt [Tue, 18 Jun 2019 18:13:04 +0000 (20:13 +0200)]
Throw exception in `WCF::__call()` for undefined methods

5 years agoFixed typo
Alexander Ebert [Tue, 18 Jun 2019 13:25:46 +0000 (15:25 +0200)]
Fixed typo

5 years agoAvoid closing dialogs on mouse drag
Alexander Ebert [Tue, 18 Jun 2019 10:56:17 +0000 (12:56 +0200)]
Avoid closing dialogs on mouse drag

5 years agoMerge branch 'master' into next
Alexander Ebert [Tue, 18 Jun 2019 10:37:16 +0000 (12:37 +0200)]
Merge branch 'master' into next

5 years agoUpdate LanguageAddForm.class.php (#2939)
Marcel Beckers [Tue, 18 Jun 2019 10:36:32 +0000 (12:36 +0200)]
Update LanguageAddForm.class.php (#2939)

* Update LanguageAddForm.class.php

Added aditionalFields

* Update LanguageEditForm.class.php

5 years agoMerge pull request #2938 from WoltLab/selection_tree_support
Alexander Ebert [Tue, 18 Jun 2019 10:28:02 +0000 (12:28 +0200)]
Merge pull request #2938 from WoltLab/selection_tree_support

Add abstract object tree node used for selection form fields

5 years agoFix now invalid usages of CryptoException (#2908)
Jens Hausdorf [Mon, 17 Jun 2019 16:24:49 +0000 (18:24 +0200)]
Fix now invalid usages of CryptoException (#2908)

* Fix now invalid usages of CryptoException

The \random_{bytes,int} functions are now called directly instead through
wcf\util\CryptoUtil,  which means that the exceptions may not be caught
with CryptoException anymore. Instead, they must be caught with the
generic \Throwable interface.
This commit also fixes usages of those functions to prevent malicious code
to overwrite these critical functions in userland code.

* Make sure to generate a truly random ID
by disallowing user modification.

Adding the `\` in front of the function call makes sure PHP does not use
any overwritten (user-land) function, potentially destroying our efforts of
having a CSRPNG ID

* Remove no longer necessary try-catch block.

5 years agoMerge branch 'master' into next
Alexander Ebert [Mon, 17 Jun 2019 16:22:07 +0000 (18:22 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Alexander Ebert [Mon, 17 Jun 2019 16:18:51 +0000 (18:18 +0200)]
Merge branch '3.0'

5 years agoMerge pull request #2931 from WoltLab/30-reaction-backport
Alexander Ebert [Mon, 17 Jun 2019 16:18:13 +0000 (18:18 +0200)]
Merge pull request #2931 from WoltLab/30-reaction-backport

Backport reaction related interfaces

5 years agoMerge pull request #2933 from WoltLab/queue-failure-callback
Alexander Ebert [Mon, 17 Jun 2019 16:15:21 +0000 (18:15 +0200)]
Merge pull request #2933 from WoltLab/queue-failure-callback

Add on(Final)?Failure callbacks to AbstractBackgroundJob

5 years agoMerge pull request #2941 from WoltLab/database-options
Alexander Ebert [Mon, 17 Jun 2019 16:14:52 +0000 (18:14 +0200)]
Merge pull request #2941 from WoltLab/database-options

Support custom database driver options

5 years agoFixed required PHP version
Marcel Werk [Tue, 11 Jun 2019 14:59:22 +0000 (16:59 +0200)]
Fixed required PHP version

5 years agoOverhauled test.php
Marcel Werk [Mon, 10 Jun 2019 17:41:03 +0000 (19:41 +0200)]
Overhauled test.php

5 years agoSupport custom database driver options
Tim Düsterhus [Tue, 4 Jun 2019 20:25:14 +0000 (22:25 +0200)]
Support custom database driver options

5 years agoFix parameter documentation
Matthias Schmidt [Sat, 8 Jun 2019 18:04:02 +0000 (20:04 +0200)]
Fix parameter documentation

See #2852

5 years agoMerge pull request #2914 from SoftCreatR/patch-4
Alexander Ebert [Sat, 8 Jun 2019 17:42:50 +0000 (19:42 +0200)]
Merge pull request #2914 from SoftCreatR/patch-4

Fix password comparison

5 years agoAdd html message support for `WCF.Table.EmptyTableHandler`
Matthias Schmidt [Sat, 8 Jun 2019 13:36:14 +0000 (15:36 +0200)]
Add html message support for `WCF.Table.EmptyTableHandler`

5 years agoAutomatically mark published new articles written in ACP as read
Matthias Schmidt [Thu, 6 Jun 2019 17:13:32 +0000 (19:13 +0200)]
Automatically mark published new articles written in ACP as read

5 years agoRedirect user to published article created in frontend
Matthias Schmidt [Thu, 6 Jun 2019 17:09:05 +0000 (19:09 +0200)]
Redirect user to published article created in frontend

See #2681

5 years agoMerge branch 'master' into next
Tim Düsterhus [Mon, 3 Jun 2019 19:32:46 +0000 (21:32 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Tim Düsterhus [Mon, 3 Jun 2019 19:32:23 +0000 (21:32 +0200)]
Merge branch '3.0'

5 years agoRename Piwik to Matomo in Footer Code description
Tim Düsterhus [Mon, 3 Jun 2019 19:31:24 +0000 (21:31 +0200)]
Rename Piwik to Matomo in Footer Code description

5 years agoFix typo in de.xml
Tim Düsterhus [Mon, 3 Jun 2019 19:30:14 +0000 (21:30 +0200)]
Fix typo in de.xml

5 years agoMerge branch 'master' into next
Matthias Schmidt [Mon, 3 Jun 2019 17:35:56 +0000 (19:35 +0200)]
Merge branch 'master' into next

5 years agoFix type of `$user` property after assigning trophy to user
Matthias Schmidt [Mon, 3 Jun 2019 17:35:28 +0000 (19:35 +0200)]
Fix type of `$user` property after assigning trophy to user

5 years agoFix typo
Joshua Rüsweg [Mon, 3 Jun 2019 15:19:52 +0000 (17:19 +0200)]
Fix typo

5 years agounnecessary complicated code simplified
Marcel Werk [Mon, 3 Jun 2019 14:48:55 +0000 (16:48 +0200)]
unnecessary complicated code simplified

5 years agoMerge branch '3.0'
Marcel Werk [Mon, 3 Jun 2019 13:51:49 +0000 (15:51 +0200)]
Merge branch '3.0'

5 years agowcf1_user.authData was missing in GDPR export
Marcel Werk [Mon, 3 Jun 2019 13:51:28 +0000 (15:51 +0200)]
wcf1_user.authData was missing in GDPR export

CLoses #2906

5 years agoArticleAddForm doesn't validate imageIDs (teaser)
Marcel Werk [Mon, 3 Jun 2019 13:35:21 +0000 (15:35 +0200)]
ArticleAddForm doesn't validate imageIDs (teaser)

See #2935

5 years agoMerge branch '3.0'
Marcel Werk [Mon, 3 Jun 2019 13:34:40 +0000 (15:34 +0200)]
Merge branch '3.0'

5 years agoArticleAddForm doesn't validate imageIDs
Marcel Werk [Mon, 3 Jun 2019 13:33:57 +0000 (15:33 +0200)]
ArticleAddForm doesn't validate imageIDs

Closes #2935

5 years agoFix typos in en.xml
Tim Düsterhus [Mon, 3 Jun 2019 12:42:52 +0000 (14:42 +0200)]
Fix typos in en.xml

5 years agoAlways display the second level categories for articles
Marcel Werk [Mon, 3 Jun 2019 10:46:02 +0000 (12:46 +0200)]
Always display the second level categories for articles

Closes #2886

5 years agoFix phrasing of devools-related error language item
Matthias Schmidt [Sun, 2 Jun 2019 14:31:41 +0000 (16:31 +0200)]
Fix phrasing of devools-related error language item

See #2772

5 years agoAdd abstract object tree node used for selection form fields
Matthias Schmidt [Sun, 2 Jun 2019 07:31:02 +0000 (09:31 +0200)]
Add abstract object tree node used for selection form fields

5 years agoAdd reCAPTCHA key fields to first setup form
Matthias Schmidt [Sun, 2 Jun 2019 07:20:08 +0000 (09:20 +0200)]
Add reCAPTCHA key fields to first setup form

See #2797

5 years agoFix wrong parameter type issue in `CategoryNode::isVisibleInNestedList()`
Matthias Schmidt [Sun, 2 Jun 2019 06:58:14 +0000 (08:58 +0200)]
Fix wrong parameter type issue in `CategoryNode::isVisibleInNestedList()`

See #2886

5 years agoAdd missing cover photo-related language item
Matthias Schmidt [Sat, 1 Jun 2019 12:32:36 +0000 (14:32 +0200)]
Add missing cover photo-related language item

See #2876

5 years agoMerge branch 'master' into next
Matthias Schmidt [Sat, 1 Jun 2019 12:27:01 +0000 (14:27 +0200)]
Merge branch 'master' into next

5 years agoRemove unused, non-existent language items from JS code
Matthias Schmidt [Sat, 1 Jun 2019 12:25:41 +0000 (14:25 +0200)]
Remove unused, non-existent language items from JS code

5 years agoMerge branch 'master' into next
Joshua Rüsweg [Thu, 30 May 2019 19:34:00 +0000 (21:34 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Joshua Rüsweg [Thu, 30 May 2019 19:33:13 +0000 (21:33 +0200)]
Merge branch '3.0'

5 years agoEncode JSON variables in AMP article page
Joshua Rüsweg [Thu, 30 May 2019 19:31:31 +0000 (21:31 +0200)]
Encode JSON variables in AMP article page

5 years agoFix typo in English StopForumSpam-related language item
Matthias Schmidt [Thu, 30 May 2019 12:35:31 +0000 (14:35 +0200)]
Fix typo in English StopForumSpam-related language item

See #2692

5 years agoUnify modification log names in German (frontend/backend)
Matthias Schmidt [Mon, 27 May 2019 17:44:42 +0000 (19:44 +0200)]
Unify modification log names in German (frontend/backend)

See #2597

5 years agoMerge pull request #2921 from WoltLab/exception-request-id
Alexander Ebert [Mon, 27 May 2019 14:23:40 +0000 (16:23 +0200)]
Merge pull request #2921 from WoltLab/exception-request-id

Log Request-ID header in Exceptions

5 years agoFix reactions for non unique containers
Joshua Rüsweg [Mon, 27 May 2019 11:38:05 +0000 (13:38 +0200)]
Fix reactions for non unique containers
Sometimes it is necessary to reload object containers (e.g. if something is sorted via JavaScript and the elements have to be reloaded in the background). This was not possible with the implementation, each object could exist only once in the DOM.
See #2508

5 years agoFix reaction list buttons in user profile
Joshua Rüsweg [Sun, 26 May 2019 18:30:58 +0000 (20:30 +0200)]
Fix reaction list buttons in user profile
See #2508

5 years agoFix width issue with button to add new project instructions
Matthias Schmidt [Sun, 26 May 2019 14:59:07 +0000 (16:59 +0200)]
Fix width issue with button to add new project instructions

In German, the button label is too wide for the previous column width.

See 2772

5 years agoFix typos in German language items
Matthias Schmidt [Sun, 26 May 2019 14:55:50 +0000 (16:55 +0200)]
Fix typos in German language items

5 years agoMerge branch 'master' into next
Tim Düsterhus [Fri, 24 May 2019 15:26:24 +0000 (17:26 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Tim Düsterhus [Fri, 24 May 2019 15:26:04 +0000 (17:26 +0200)]
Merge branch '3.0'

5 years agoFix submitButton selector in Ui/Message/Reply
Peter Lohse [Thu, 9 May 2019 06:21:45 +0000 (08:21 +0200)]
Fix submitButton selector in Ui/Message/Reply

Closes #2927

5 years agoFix reaction sorting function
Joshua Rüsweg [Fri, 24 May 2019 14:06:01 +0000 (16:06 +0200)]
Fix reaction sorting function
See #2508

5 years agoOptimize javascript code
Joshua Rüsweg [Fri, 24 May 2019 13:59:24 +0000 (15:59 +0200)]
Optimize javascript code
See #2508

5 years agoMerge pull request #2937 from WoltLab/next-reaction-improvement
Joshua Rüsweg [Fri, 24 May 2019 13:03:42 +0000 (15:03 +0200)]
Merge pull request #2937 from WoltLab/next-reaction-improvement

Next reaction improvement

5 years agoAdd single reaction type modus
Joshua Rüsweg [Fri, 24 May 2019 12:44:05 +0000 (14:44 +0200)]
Add single reaction type modus
See #2508

5 years agoMerge pull request #2936 from derpierre65/next
Joshua Rüsweg [Fri, 24 May 2019 09:04:36 +0000 (11:04 +0200)]
Merge pull request #2936 from derpierre65/next

Show DatePicker clear button on setDate

5 years agoRemove unused variables
derpierre65 [Wed, 22 May 2019 11:48:37 +0000 (13:48 +0200)]
Remove unused variables

5 years agoRemove code duplicates
derpierre65 [Wed, 22 May 2019 11:45:01 +0000 (13:45 +0200)]
Remove code duplicates

5 years agoShow DatePicker clear button on setDate
derpierre65 [Wed, 22 May 2019 10:48:37 +0000 (12:48 +0200)]
Show DatePicker clear button on setDate

5 years agoFix typo in de.xml
Tim Düsterhus [Mon, 20 May 2019 10:30:14 +0000 (12:30 +0200)]
Fix typo in de.xml

5 years agoFix typo
Joshua Rüsweg [Sun, 19 May 2019 17:58:14 +0000 (19:58 +0200)]
Fix typo
See #2716

5 years agoFix typo
Joshua Rüsweg [Sun, 19 May 2019 17:43:45 +0000 (19:43 +0200)]
Fix typo
See #2716

5 years agoUse package name instead of identifier on modification log list page
Matthias Schmidt [Sun, 19 May 2019 12:59:26 +0000 (14:59 +0200)]
Use package name instead of identifier on modification log list page

See #2597

5 years agoImprove wording of SFS-related language item
Matthias Schmidt [Sun, 19 May 2019 12:29:54 +0000 (14:29 +0200)]
Improve wording of SFS-related language item

See #2692

5 years agoFixes overlapping dialog container
Joshua Rüsweg [Sun, 19 May 2019 08:48:28 +0000 (10:48 +0200)]
Fixes overlapping dialog container
See #2716

5 years agoFix name of JavaScript module
Matthias Schmidt [Sun, 19 May 2019 07:52:20 +0000 (09:52 +0200)]
Fix name of JavaScript module

See #2716

5 years agoBackport TReactionUserNotificationEvent to version 3.0
Joshua Rüsweg [Wed, 15 May 2019 15:01:19 +0000 (17:01 +0200)]
Backport TReactionUserNotificationEvent to version 3.0
This backport ensures the compatibility for version 3.0 (and above) and version 5.2. With this commit, plugins can fully support the reaction system and the like system, previously this was only possible to a limited extent.
See #2508

5 years agoAdd on(Final)?Failure callbacks to AbstractBackgroundJob
Tim Düsterhus [Wed, 15 May 2019 17:12:26 +0000 (19:12 +0200)]
Add on(Final)?Failure callbacks to AbstractBackgroundJob

5 years agoMerge branch 'master' into next
Tim Düsterhus [Wed, 15 May 2019 16:30:15 +0000 (18:30 +0200)]
Merge branch 'master' into next

5 years agoMerge branch '3.0'
Tim Düsterhus [Wed, 15 May 2019 16:28:48 +0000 (18:28 +0200)]
Merge branch '3.0'

5 years agoFix PHP 5.5 compatibility
Tim Düsterhus [Wed, 15 May 2019 16:27:26 +0000 (18:27 +0200)]
Fix PHP 5.5 compatibility

PHP 5.5 does not support constant expressions in static variable declarations.
Simply remove the `static`, it brings no real benefit.

5 years agoIncrease the number of email retries to better match the RFCs (#2932)
Tim Düsterhus [Wed, 15 May 2019 16:21:07 +0000 (18:21 +0200)]
Increase the number of email retries to better match the RFCs (#2932)

* Increase the number of email retries to better match the RFCs

* Improve readability of running total comment in email job

5 years agoMerge pull request #2930 from WoltLab/next-passwordreset
Joshua Rüsweg [Wed, 15 May 2019 15:12:28 +0000 (17:12 +0200)]
Merge pull request #2930 from WoltLab/next-passwordreset

Allow multiple calls of the link to set a new password

5 years agoBackport IReactionObject to version 3.0
Joshua Rüsweg [Wed, 15 May 2019 15:00:44 +0000 (17:00 +0200)]
Backport IReactionObject to version 3.0
This backport ensures the compatibility for version 3.0 (and above) and version 5.2. With this commit, plugins can fully support the reaction system and the like system, previously this was only possible to a limited extent.
See #2508

5 years agoAllow multiple calls of the link to set a new password
Joshua Rüsweg [Wed, 15 May 2019 13:32:04 +0000 (15:32 +0200)]
Allow multiple calls of the link to set a new password
See #2923

5 years agoFix blocking all users within the registration process
Sascha Greuel [Sun, 5 May 2019 17:44:56 +0000 (19:44 +0200)]
Fix blocking all users within the registration process
See #2692
See #2920

5 years agoImprove UI for reaction recent activity
Joshua Rüsweg [Mon, 13 May 2019 19:52:50 +0000 (21:52 +0200)]
Improve UI for reaction recent activity
See #2508

5 years agoImprove UI of reaction overview list
Joshua Rüsweg [Mon, 13 May 2019 19:28:54 +0000 (21:28 +0200)]
Improve UI of reaction overview list
See #2508

5 years agoIgnore invalid values passed to `ShowOrderFormField::value()`
Matthias Schmidt [Sun, 12 May 2019 16:26:49 +0000 (18:26 +0200)]
Ignore invalid values passed to `ShowOrderFormField::value()`

See #2509

5 years agoRestruct showOrder after object deletion
Joshua Rüsweg [Sun, 12 May 2019 15:24:06 +0000 (17:24 +0200)]
Restruct showOrder after object deletion
See #2508

5 years agoSimplify showOrder input
Joshua Rüsweg [Sun, 12 May 2019 15:18:39 +0000 (17:18 +0200)]
Simplify showOrder input
See #2508

5 years agoSet default sort oder for reaction types
Joshua Rüsweg [Sun, 12 May 2019 15:16:54 +0000 (17:16 +0200)]
Set default sort oder for reaction types
See #2508

5 years agoUnify sort button HTML code
Matthias Schmidt [Sun, 12 May 2019 09:56:12 +0000 (11:56 +0200)]
Unify sort button HTML code

Close #2929

5 years agoFix double `(first position)` when using callable for show order field options
Matthias Schmidt [Sun, 12 May 2019 09:44:14 +0000 (11:44 +0200)]
Fix double `(first position)` when using callable for show order field options

See #2509

5 years agoMerge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:56:59 +0000 (17:56 +0200)]
Merge branch '3.0'

5 years agoAdded missing language variable
Marcel Werk [Fri, 10 May 2019 15:56:37 +0000 (17:56 +0200)]
Added missing language variable

5 years agoMerge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:44:23 +0000 (17:44 +0200)]
Merge branch '3.0'

5 years agoHide language drop-down if a multilingual page has only one language
Marcel Werk [Fri, 10 May 2019 15:44:05 +0000 (17:44 +0200)]
Hide language drop-down if a multilingual page has only one language

5 years agoMerge branch '3.0'
Marcel Werk [Fri, 10 May 2019 15:34:57 +0000 (17:34 +0200)]
Merge branch '3.0'

5 years agoFixed missing title in link to user profile
Marcel Werk [Fri, 10 May 2019 15:34:12 +0000 (17:34 +0200)]
Fixed missing title in link to user profile

5 years agoFix article report button if reaction system is disabled
Joshua Rüsweg [Fri, 10 May 2019 11:25:48 +0000 (13:25 +0200)]
Fix article report button if reaction system is disabled
Fix #2926

5 years agoFix showOrder value for reactionTypes
Joshua Rüsweg [Fri, 10 May 2019 11:04:20 +0000 (13:04 +0200)]
Fix showOrder value for reactionTypes
See #2508