GitHub/WoltLab/WCF.git
3 years agoMerge pull request #3746 from WoltLab/mfa-conditions
Joshua Rüsweg [Tue, 24 Nov 2020 11:03:51 +0000 (12:03 +0100)]
Merge pull request #3746 from WoltLab/mfa-conditions

Integrate multi-factor authentication into the condition system

3 years agoRename condition to `multifactorActive`
joshuaruesweg [Mon, 23 Nov 2020 17:05:51 +0000 (18:05 +0100)]
Rename condition to `multifactorActive`

3 years agoFix typo in PHPDoc in \wcf\system\multifactor\totp\Totp
Tim Düsterhus [Tue, 24 Nov 2020 10:33:39 +0000 (11:33 +0100)]
Fix typo in PHPDoc in \wcf\system\multifactor\totp\Totp

3 years agoAdd multi-factor foreign keys to update_com.woltlab.wcf_5.4_db.php
Tim Düsterhus [Mon, 23 Nov 2020 15:57:40 +0000 (16:57 +0100)]
Add multi-factor foreign keys to update_com.woltlab.wcf_5.4_db.php

3 years agoAdd wcf1_user_multifactor_email to update_com.woltlab.wcf_5.4_db.php
Tim Düsterhus [Mon, 23 Nov 2020 15:55:18 +0000 (16:55 +0100)]
Add wcf1_user_multifactor_email to update_com.woltlab.wcf_5.4_db.php

3 years agoAdd missing usage of fully qualified function names for email MFA
Tim Düsterhus [Mon, 23 Nov 2020 15:53:29 +0000 (16:53 +0100)]
Add missing usage of fully qualified function names for email MFA

3 years agoAdd usesMultifactor condition for user search in acp
joshuaruesweg [Sun, 22 Nov 2020 11:03:34 +0000 (12:03 +0100)]
Add usesMultifactor condition for user search in acp

3 years agoAdd usesMultifactor condition for notices
joshuaruesweg [Sun, 22 Nov 2020 10:37:45 +0000 (11:37 +0100)]
Add usesMultifactor condition for notices

3 years agoAdd `$multifactorActive` property for user dbo
joshuaruesweg [Sun, 22 Nov 2020 10:25:57 +0000 (11:25 +0100)]
Add `$multifactorActive` property for user dbo

3 years agoMerge pull request #3743 from WoltLab/mfa-disable
Tim Düsterhus [Fri, 20 Nov 2020 14:39:11 +0000 (15:39 +0100)]
Merge pull request #3743 from WoltLab/mfa-disable

Support disabling the multi-factor authentication

3 years agoSupport disabling the multi-factor authentication
Tim Düsterhus [Fri, 20 Nov 2020 14:25:47 +0000 (15:25 +0100)]
Support disabling the multi-factor authentication

3 years agoUse U+2022 to black out backup code trailers
Tim Düsterhus [Fri, 20 Nov 2020 12:39:50 +0000 (13:39 +0100)]
Use U+2022 to black out backup code trailers

3 years agoMerge branch 'master' into mfa-meta
Tim Düsterhus [Fri, 20 Nov 2020 10:29:25 +0000 (11:29 +0100)]
Merge branch 'master' into mfa-meta

For the bug fix in the email templates.

3 years agoMerge branch '5.3'
Tim Düsterhus [Fri, 20 Nov 2020 10:23:22 +0000 (11:23 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.2.10_orphanedComments.php
- Replaced ts/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js with the file
  from 5.3, replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Fri, 20 Nov 2020 10:19:32 +0000 (11:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3732 from WoltLab/mfa-acp
Tim Düsterhus [Fri, 20 Nov 2020 09:24:35 +0000 (10:24 +0100)]
Merge pull request #3732 from WoltLab/mfa-acp

Support multi-factor authentication within ACP

3 years agoMake the MF authentication controller for ACP inherit from the frontend ones
Tim Düsterhus [Thu, 19 Nov 2020 15:56:29 +0000 (16:56 +0100)]
Make the MF authentication controller for ACP inherit from the frontend ones

3 years agoSupport multi-factor authentication within ACP
Tim Düsterhus [Wed, 18 Nov 2020 15:02:35 +0000 (16:02 +0100)]
Support multi-factor authentication within ACP

3 years agoClean up comments when removing moderation queues (#3740)
Alexander Ebert [Thu, 19 Nov 2020 18:24:52 +0000 (19:24 +0100)]
Clean up comments when removing moderation queues (#3740)

* Delete comments when moderation queues are being removed

See #3707

* Clean-up script for orphaned comments

* Use the `CommentHandler` to remove comments

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoEnabled three column layout for boxes top / bottom
Marcel Werk [Thu, 19 Nov 2020 18:02:23 +0000 (19:02 +0100)]
Enabled three column layout for boxes top / bottom

3 years agoSkip DOM updates when the article is not present
Alexander Ebert [Thu, 19 Nov 2020 15:56:12 +0000 (16:56 +0100)]
Skip DOM updates when the article is not present

3 years agoMerge branch '5.3'
Tim Düsterhus [Thu, 19 Nov 2020 15:24:51 +0000 (16:24 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.3_style.php which is not required.
- Replaced ts/WoltLabSuite/Core/Media/Editor.js with the file from 5.3,
  replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.

3 years agoMerge pull request #3739 from WoltLab/fix-style-preview
Tim Düsterhus [Thu, 19 Nov 2020 15:17:08 +0000 (16:17 +0100)]
Merge pull request #3739 from WoltLab/fix-style-preview

Fix style preview images when upgrading from 5.2

3 years agoFix style preview images when upgrading from 5.2
Tim Düsterhus [Thu, 19 Nov 2020 15:09:29 +0000 (16:09 +0100)]
Fix style preview images when upgrading from 5.2

3 years agoMerge pull request #3736 from WoltLab/mfa-method-description
Tim Düsterhus [Thu, 19 Nov 2020 14:51:18 +0000 (15:51 +0100)]
Merge pull request #3736 from WoltLab/mfa-method-description

Add descriptions to the account security page

3 years agoImprove phrasing of TOTP description
Tim Düsterhus [Thu, 19 Nov 2020 14:48:27 +0000 (15:48 +0100)]
Improve phrasing of TOTP description

Remove the adjective "free".

Co-authored-by: Joshua Rüsweg <ruesweg@woltlab.com>
3 years agoFixed html in acp search results
Marcel Werk [Thu, 19 Nov 2020 14:27:41 +0000 (15:27 +0100)]
Fixed html in acp search results

3 years agoAdd note about the email_html.tpl update to package.xml
Tim Düsterhus [Thu, 19 Nov 2020 13:18:04 +0000 (14:18 +0100)]
Add note about the email_html.tpl update to package.xml

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 19 Nov 2020 13:13:46 +0000 (14:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoReplace the selector for the font-family in email_html.tpl
Tim Düsterhus [Thu, 19 Nov 2020 13:06:01 +0000 (14:06 +0100)]
Replace the selector for the font-family in email_html.tpl

The Emogrifier version used in 5.2 does not fully support all features
of the `:not()` selector. Depending on the environment the use of
`:not()` results in slightly different output. Specifically the number
of `:not()`s chained there caused the result to have a very large
specificity, possibly overriding the font-size of the headline tags.

Use `body, body *` instead, it will not put any useless CSS onto heading
tags and still catch all relevant elements. The biggest difference is
that the `<br>` tag will carry a `font-family` and `font-size`.

3 years agoSort enabled MFA methods to the top in AccountSecurityPage
Tim Düsterhus [Thu, 19 Nov 2020 10:42:02 +0000 (11:42 +0100)]
Sort enabled MFA methods to the top in AccountSecurityPage

3 years agoFix typo in DevicesContainer
Tim Düsterhus [Thu, 19 Nov 2020 10:39:18 +0000 (11:39 +0100)]
Fix typo in DevicesContainer

see 1e08b49f1c61ecb81a15f1d163d7322043a0512e

3 years agoAdd description to the list of active sessions
Tim Düsterhus [Thu, 19 Nov 2020 09:11:08 +0000 (10:11 +0100)]
Add description to the list of active sessions

3 years agoAdd a general MFA description
Tim Düsterhus [Thu, 19 Nov 2020 09:04:04 +0000 (10:04 +0100)]
Add a general MFA description

3 years agoAdd description for MFA methods
Tim Düsterhus [Thu, 19 Nov 2020 09:00:55 +0000 (10:00 +0100)]
Add description for MFA methods

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Wed, 18 Nov 2020 19:02:11 +0000 (20:02 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Wed, 18 Nov 2020 19:01:46 +0000 (20:01 +0100)]
Merge branch '3.1' into 5.2

3 years agoMutable variable access inside a callback
Alexander Ebert [Wed, 18 Nov 2020 19:00:04 +0000 (20:00 +0100)]
Mutable variable access inside a callback

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 16:32:58 +0000 (17:32 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 18 Nov 2020 16:32:41 +0000 (17:32 +0100)]
Merge branch '3.1' into 5.2

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:32:21 +0000 (17:32 +0100)]
Fix ACL buttons when editing media files successively

Replaces 3a7740a3704339c79d08fd2f5094fa1a1973318b by backporting and using parts of 6ee58cd2865980cd7fa16a1f3ebc660131fc7fd6.

3 years agoRevert "Fix ACL buttons when editing media files successively"
Matthias Schmidt [Wed, 18 Nov 2020 16:26:26 +0000 (17:26 +0100)]
Revert "Fix ACL buttons when editing media files successively"

This reverts commit 3a7740a3704339c79d08fd2f5094fa1a1973318b.

3 years agoFix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 16:24:30 +0000 (17:24 +0100)]
Fix ACL buttons when editing media files successively

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 18 Nov 2020 15:31:03 +0000 (16:31 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 18 Nov 2020 15:28:34 +0000 (16:28 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix file icon update after upload on media list page
Matthias Schmidt [Wed, 18 Nov 2020 15:28:18 +0000 (16:28 +0100)]
Fix file icon update after upload on media list page

3 years agoRemove assignment of $__wscMissingOwnerGroup
Tim Düsterhus [Wed, 18 Nov 2020 15:16:44 +0000 (16:16 +0100)]
Remove assignment of $__wscMissingOwnerGroup

Apparently this was forgotten in #3697.

3 years agoUse multifactor prefix for formbuilder templates related to MFA
Tim Düsterhus [Wed, 18 Nov 2020 14:22:45 +0000 (15:22 +0100)]
Use multifactor prefix for formbuilder templates related to MFA

3 years agoMake WoltLabSuite/Core/List a proper generic class
Tim Düsterhus [Wed, 18 Nov 2020 14:14:59 +0000 (15:14 +0100)]
Make WoltLabSuite/Core/List a proper generic class

3 years agoMerge pull request #3730 from WoltLab/mfa-auth
Tim Düsterhus [Wed, 18 Nov 2020 14:13:55 +0000 (15:13 +0100)]
Merge pull request #3730 from WoltLab/mfa-auth

Clean up the MF authentication flow

3 years agoAdd SessionHandler::applyPendingUserChange()
Tim Düsterhus [Wed, 18 Nov 2020 13:22:44 +0000 (14:22 +0100)]
Add SessionHandler::applyPendingUserChange()

3 years agoSet session's languageID in SessionHandler::changeUserAfterMultifactor()
Tim Düsterhus [Wed, 18 Nov 2020 13:16:35 +0000 (14:16 +0100)]
Set session's languageID in SessionHandler::changeUserAfterMultifactor()

3 years agoAdd information box to multifactorAuthentication.tpl
Tim Düsterhus [Wed, 18 Nov 2020 11:16:30 +0000 (12:16 +0100)]
Add information box to multifactorAuthentication.tpl

3 years agoAdd support for pending users to UserProfile::canSeeAvatar()
Tim Düsterhus [Wed, 18 Nov 2020 10:51:56 +0000 (11:51 +0100)]
Add support for pending users to UserProfile::canSeeAvatar()

3 years agoExpose a userProfile object to the template in MFAuthenticationForm
Tim Düsterhus [Wed, 18 Nov 2020 10:52:56 +0000 (11:52 +0100)]
Expose a userProfile object to the template in MFAuthenticationForm

3 years agoAdd MultifactorAuthenticationAbortForm
Tim Düsterhus [Wed, 18 Nov 2020 11:15:30 +0000 (12:15 +0100)]
Add MultifactorAuthenticationAbortForm

3 years agoMake the MFA authentication look a bit nicer
Tim Düsterhus [Tue, 17 Nov 2020 11:04:43 +0000 (12:04 +0100)]
Make the MFA authentication look a bit nicer

3 years agoDisable the login dropdown in multifactorAuthentcation.tpl
Tim Düsterhus [Tue, 17 Nov 2020 10:17:00 +0000 (11:17 +0100)]
Disable the login dropdown in multifactorAuthentcation.tpl

3 years agoSupport accessing the MultifactorAuthenticationForm when logged in
Tim Düsterhus [Tue, 17 Nov 2020 10:10:41 +0000 (11:10 +0100)]
Support accessing the MultifactorAuthenticationForm when logged in

3 years agoAdd support for redirectUrl to MultifactorAuthenticationForm
Tim Düsterhus [Tue, 17 Nov 2020 10:07:24 +0000 (11:07 +0100)]
Add support for redirectUrl to MultifactorAuthenticationForm

3 years agoSet multifactorActive = 1 in MultifactorMangeForm
Tim Düsterhus [Tue, 17 Nov 2020 13:09:59 +0000 (14:09 +0100)]
Set multifactorActive = 1 in MultifactorMangeForm

3 years agoMerge transactions in MultifactorManageForm::save()
Tim Düsterhus [Tue, 17 Nov 2020 09:26:11 +0000 (10:26 +0100)]
Merge transactions in MultifactorManageForm::save()

3 years agoAdd MultifactorManageForm::generateBackupCodes()
Tim Düsterhus [Tue, 17 Nov 2020 09:24:01 +0000 (10:24 +0100)]
Add MultifactorManageForm::generateBackupCodes()

3 years agoMerge pull request #3729 from WoltLab/mfa-email
Tim Düsterhus [Wed, 18 Nov 2020 12:53:05 +0000 (13:53 +0100)]
Merge pull request #3729 from WoltLab/mfa-email

Add EmailMultifactorMethod

3 years agoImprove phrasing for email MFA
Tim Düsterhus [Wed, 18 Nov 2020 11:52:26 +0000 (12:52 +0100)]
Improve phrasing for email MFA

3 years agofixup! Add EmailMultifactorMethod
Tim Düsterhus [Wed, 18 Nov 2020 11:51:21 +0000 (12:51 +0100)]
fixup! Add EmailMultifactorMethod

3 years agoShow the one time code within the mail's subject
Tim Düsterhus [Wed, 18 Nov 2020 11:50:22 +0000 (12:50 +0100)]
Show the one time code within the mail's subject

3 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 18 Nov 2020 11:43:32 +0000 (12:43 +0100)]
Merge branch '5.3'

Dropped update_com.woltlab.wcf_5.3_fixActivationMethod.php which is not
required.

3 years agoRemove obsolete update_com.woltlab.wcf_5.3_fixActivationMethod.php
Tim Düsterhus [Wed, 18 Nov 2020 11:42:59 +0000 (12:42 +0100)]
Remove obsolete update_com.woltlab.wcf_5.3_fixActivationMethod.php

3 years agoForce the setupId to be an int in MFAuthenticationForm
Tim Düsterhus [Tue, 17 Nov 2020 10:14:15 +0000 (11:14 +0100)]
Force the setupId to be an int in MFAuthenticationForm

3 years agoImprove return type for Setup::getAllForUser()
Tim Düsterhus [Tue, 17 Nov 2020 10:13:42 +0000 (11:13 +0100)]
Improve return type for Setup::getAllForUser()

3 years agoAdd EmailMultifactorMethod
Tim Düsterhus [Tue, 17 Nov 2020 14:19:55 +0000 (15:19 +0100)]
Add EmailMultifactorMethod

3 years agoMerge pull request #3727 from WoltLab/favicon-template-typo
Tim Düsterhus [Wed, 18 Nov 2020 08:22:32 +0000 (09:22 +0100)]
Merge pull request #3727 from WoltLab/favicon-template-typo

Fix typo in favicon template filename

3 years agoFix TOTP flood control
Tim Düsterhus [Tue, 17 Nov 2020 13:42:10 +0000 (14:42 +0100)]
Fix TOTP flood control

3 years agoAdd Setup::getUser() method
Tim Düsterhus [Tue, 17 Nov 2020 13:59:48 +0000 (14:59 +0100)]
Add Setup::getUser() method

3 years agoFix use of informal German in TOTP's lastDevice phrase
Tim Düsterhus [Tue, 17 Nov 2020 15:15:56 +0000 (16:15 +0100)]
Fix use of informal German in TOTP's lastDevice phrase

3 years agoUpdating minified JavaScript files
WoltLab [Tue, 17 Nov 2020 14:56:24 +0000 (14:56 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 17 Nov 2020 14:47:05 +0000 (15:47 +0100)]
Merge branch '5.3'

3 years agoFix typo in favicon template filename
Tim Düsterhus [Tue, 17 Nov 2020 14:25:44 +0000 (15:25 +0100)]
Fix typo in favicon template filename

5.2 used `favicon-template.ext` instead of `favicon.template.ext`.

3 years agoForce the synchronization of the `codeMetaCode` template
Alexander Ebert [Tue, 17 Nov 2020 14:25:36 +0000 (15:25 +0100)]
Force the synchronization of the `codeMetaCode` template

3 years agoPlace the `@charset` at the very beginning of the generated CSS (#3726)
Alexander Ebert [Tue, 17 Nov 2020 14:17:49 +0000 (15:17 +0100)]
Place the `@charset` at the very beginning of the generated CSS (#3726)

* Place the `@charset` at the very beginning of the generated CSS

* Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoFix wrong user disable/enable label in user profile
joshuaruesweg [Tue, 17 Nov 2020 13:51:28 +0000 (14:51 +0100)]
Fix wrong user disable/enable label in user profile

3 years agoMerge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath
Tim Düsterhus [Tue, 17 Nov 2020 11:30:12 +0000 (12:30 +0100)]
Merge pull request #3724 from WoltLab/upgrade-53-ignore-missing-imagePath

Verify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 17 Nov 2020 11:11:16 +0000 (12:11 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 17 Nov 2020 11:10:59 +0000 (12:10 +0100)]
Merge branch '5.2' into 5.3

3 years agoEncode HTML special chars in form builder's action
Tim Düsterhus [Tue, 17 Nov 2020 11:10:32 +0000 (12:10 +0100)]
Encode HTML special chars in form builder's action

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 17 Nov 2020 09:17:50 +0000 (10:17 +0100)]
Merge branch '5.3'

3 years agoVerify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php
Tim Düsterhus [Tue, 17 Nov 2020 09:13:42 +0000 (10:13 +0100)]
Verify the existence of the old imagePath in update_com.woltlab.wcf_5.3_style.php

3 years agoAdded style.xsd
Marcel Werk [Mon, 16 Nov 2020 17:07:14 +0000 (18:07 +0100)]
Added style.xsd

3 years agoMerge pull request #3712 from WoltLab/mfa-setup
Tim Düsterhus [Mon, 16 Nov 2020 16:33:51 +0000 (17:33 +0100)]
Merge pull request #3712 from WoltLab/mfa-setup

Add basic support for multi factor authentication

3 years agoUse the placeholder as the default device name
Tim Düsterhus [Mon, 16 Nov 2020 12:51:05 +0000 (13:51 +0100)]
Use the placeholder as the default device name

3 years agoAdd SessionHandler::getPendingUserChange()
Tim Düsterhus [Mon, 16 Nov 2020 12:06:57 +0000 (13:06 +0100)]
Add SessionHandler::getPendingUserChange()

3 years agoGenerate backup codes when setting up the first MFA method
Tim Düsterhus [Fri, 13 Nov 2020 15:24:07 +0000 (16:24 +0100)]
Generate backup codes when setting up the first MFA method

3 years agoDisallow management of backup codes if they are not set up
Tim Düsterhus [Fri, 13 Nov 2020 14:40:02 +0000 (15:40 +0100)]
Disallow management of backup codes if they are not set up

3 years agoAdd proper success messages for TOTP
Tim Düsterhus [Fri, 13 Nov 2020 14:34:54 +0000 (15:34 +0100)]
Add proper success messages for TOTP

3 years agoAdd proper TOTP device management
Tim Düsterhus [Fri, 13 Nov 2020 13:42:27 +0000 (14:42 +0100)]
Add proper TOTP device management

3 years agoAdd multifactor\Setup class for stronger typing
Tim Düsterhus [Wed, 11 Nov 2020 14:59:19 +0000 (15:59 +0100)]
Add multifactor\Setup class for stronger typing

3 years agoAdd helper methods to MultifactorManageForm
Tim Düsterhus [Wed, 11 Nov 2020 14:14:02 +0000 (15:14 +0100)]
Add helper methods to MultifactorManageForm

These will be required for a future commit, but they also improve readability.

3 years agoClear MFA inputs if an invalid code is entered
Tim Düsterhus [Tue, 10 Nov 2020 14:19:39 +0000 (15:19 +0100)]
Clear MFA inputs if an invalid code is entered

It's not useful preserving an invalid code for the user.

3 years agoImprove UX when setting up TOTP
Tim Düsterhus [Tue, 10 Nov 2020 14:07:27 +0000 (15:07 +0100)]
Improve UX when setting up TOTP