Tim Düsterhus [Thu, 11 Feb 2021 14:37:18 +0000 (15:37 +0100)]
Use proper return types in HttpFactory
Tim Düsterhus [Thu, 11 Feb 2021 14:30:04 +0000 (15:30 +0100)]
Use Guzzle's RequestOptions constants
These allow one to easily view the option's description within the IDE.
Tim Düsterhus [Thu, 11 Feb 2021 11:46:54 +0000 (12:46 +0100)]
Replace GuzzleException by ClientExceptionInterface
ClientExceptionInterface is the standardized Exception and thus preferable.
GuzzleException extends that interface.
Tim Düsterhus [Thu, 11 Feb 2021 08:58:46 +0000 (09:58 +0100)]
Merge branch '5.3'
Marcel Werk [Thu, 11 Feb 2021 08:52:51 +0000 (09:52 +0100)]
Merge branch '5.2' into 5.3
Marcel Werk [Thu, 11 Feb 2021 08:52:33 +0000 (09:52 +0100)]
Additional template event in articleAdd template
Tim Düsterhus [Wed, 10 Feb 2021 15:28:47 +0000 (16:28 +0100)]
Add `RewriteEngine On` to generated Apache mod_rewrite rules
Resolves #3930
Tim Düsterhus [Wed, 10 Feb 2021 10:12:52 +0000 (11:12 +0100)]
Use unicode escape for bullets in BackupMultifactorMethod
Tim Düsterhus [Tue, 9 Feb 2021 11:31:21 +0000 (12:31 +0100)]
Delete unused require.build-acp.js
Tim Düsterhus [Tue, 9 Feb 2021 11:27:44 +0000 (12:27 +0100)]
Set optimize to 'none' for r.js
This was forgotten to commit while adjusting extra/*.
see
e9fa719f372fb3aeb2fa1c1579699164f2ca7fe6
see #3952
Tim Düsterhus [Tue, 9 Feb 2021 11:21:53 +0000 (12:21 +0100)]
Explicitly load tslib
This should resolve #3951, because this performs a blocking load.
Tim Düsterhus [Tue, 9 Feb 2021 08:38:11 +0000 (09:38 +0100)]
Merge pull request #3952 from WoltLab/jsmin-ts
Make extra/* compatible with TypeScript / ES 6
Matthias Schmidt [Mon, 8 Feb 2021 16:35:26 +0000 (17:35 +0100)]
Log user authentication failure type (#3950)
See #3395
Tim Düsterhus [Mon, 8 Feb 2021 14:44:26 +0000 (15:44 +0100)]
Make extra/* compatible with TypeScript / ES 6
Tim Düsterhus [Mon, 8 Feb 2021 08:34:05 +0000 (09:34 +0100)]
Merge pull request #3935 from WoltLab/use-getSubselectForObjectsByTags
Make use of TagEngine::getSubselectForObjectsByTags() in TaggedArticleList
joshuaruesweg [Sun, 7 Feb 2021 18:36:15 +0000 (19:36 +0100)]
Fix editing system pages
joshuaruesweg [Sat, 6 Feb 2021 11:58:03 +0000 (12:58 +0100)]
Fix codestyle
joshuaruesweg [Sat, 6 Feb 2021 11:29:07 +0000 (12:29 +0100)]
Use `User::getUserOptionID` instead of internal cache
Fixes #3936
Tim Düsterhus [Fri, 5 Feb 2021 15:32:12 +0000 (16:32 +0100)]
Merge pull request #3947 from WoltLab/ts-template-circular
Remove the circular dependency between Core/Language and Core/Template
Matthias Schmidt [Fri, 5 Feb 2021 15:20:35 +0000 (16:20 +0100)]
Consistently use "Attention" in English texts
See #3801
Tim Düsterhus [Fri, 5 Feb 2021 15:06:56 +0000 (16:06 +0100)]
Mark Core/Template#compiled as readonly
Tim Düsterhus [Fri, 5 Feb 2021 15:05:26 +0000 (16:05 +0100)]
Use Object.entries() in Core/Language#addObject()
Tim Düsterhus [Fri, 5 Feb 2021 14:55:06 +0000 (15:55 +0100)]
Update MysqlSearchEngine::getFulltextMinimumWordLength() for InnoDB
At the same time copy over the deprecation comment from AbstractSearchEngine.
see
7d059540531e82c12b0aec2ad50e38a6788657cc
Resolves #3948
Matthias Schmidt [Fri, 5 Feb 2021 14:09:31 +0000 (15:09 +0100)]
Constistently print "Achtung" in bold in German language item
See #3801
Matthias Schmidt [Fri, 5 Feb 2021 13:59:39 +0000 (14:59 +0100)]
Consistently use "ungültig" in German language item
See #3801
Matthias Schmidt [Fri, 5 Feb 2021 12:59:50 +0000 (13:59 +0100)]
Add `WCFMessageQuoteManager` interface to replace temporary `any` type (#3949)
Tim Düsterhus [Fri, 5 Feb 2021 11:19:57 +0000 (12:19 +0100)]
Remove the circular dependency between Core/Language and Core/Template
The old work-around for this issue was no longer working well since the
migration to TypeScript. This commit untangles both modules, by each splitting
them into a low level and a high level interface.
The largest change is that language items are compiled when add()ing them to
the language store instead of when get()ting the contents.
This might slightly reduce the initialization performance on pages with a large
number of unused language items and it also might increase memory usage, due to
needing to store functions instead of strings.
It however improves the readability of the code and of course it also fixes
this breakage introduced by TypeScript. If it turns out that the change
actually *is* an issue then the logic can be optimized, e.g. by skipping the
template compiler if no `{` can be found within the phrase that is being
add()ed to the language store.
Matthias Schmidt [Fri, 5 Feb 2021 10:34:20 +0000 (11:34 +0100)]
Merge branch '5.3'
Matthias Schmidt [Fri, 5 Feb 2021 10:33:18 +0000 (11:33 +0100)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Fri, 5 Feb 2021 10:33:03 +0000 (11:33 +0100)]
Fix mixed boolean operators in condition in `TI18nFormField::validate()`
… and improve the preceding comment.
See #3926
Tim Düsterhus [Fri, 5 Feb 2021 10:22:14 +0000 (11:22 +0100)]
Implement Language#addObject() in terms of Language#add()
Matthias Schmidt [Fri, 5 Feb 2021 09:24:50 +0000 (10:24 +0100)]
Use monospace font for language item value fields in devtools
Close #3933
Matthias Schmidt [Fri, 5 Feb 2021 09:09:43 +0000 (10:09 +0100)]
Update `.git-blame-ignore-revs`
Matthias Schmidt [Fri, 5 Feb 2021 09:08:47 +0000 (10:08 +0100)]
Merge pull request #3937 from WoltLab/query_formatting
Improve formatting of SQL queries in PHP code
Matthias Schmidt [Thu, 4 Feb 2021 17:08:56 +0000 (18:08 +0100)]
Split additional joins into multiple lines
Matthias Schmidt [Thu, 4 Feb 2021 16:41:15 +0000 (17:41 +0100)]
Split subquery into multiple lines
Matthias Schmidt [Thu, 4 Feb 2021 16:15:11 +0000 (17:15 +0100)]
Remove unnecessary parentheses around join conditions
Tim Düsterhus [Thu, 4 Feb 2021 15:35:21 +0000 (16:35 +0100)]
Make use of TagEngine::getSubselectForObjectsByTags() in TaggedArticleList
Commit
c9613f130106f74853fbe9a50f06c00208106b8c is fun.
It renamed the getSqlForObjectsByTags() method that was previously used in
TaggedArticleList to the current name getSubselectForObjectsByTags() and fixed
a bug in the method that prevented it from working correctly.
At the same time the commit edited TaggedArticleList to no longer use this
method and instead copied over the logic.
I'm not sure what exactly happened during the development of that commit, but
we simply should use this (fixed) method.
joshuaruesweg [Thu, 4 Feb 2021 15:31:25 +0000 (16:31 +0100)]
Add missing parentheses
Joshua Rüsweg [Thu, 4 Feb 2021 15:23:50 +0000 (16:23 +0100)]
Merge pull request #3934 from WoltLab/box_pages_restricting_viewing
Inverted Permissions for Boxes and Pages
joshuaruesweg [Thu, 4 Feb 2021 12:34:58 +0000 (13:34 +0100)]
Add inverted permissions feature for pages
joshuaruesweg [Thu, 4 Feb 2021 12:13:06 +0000 (13:13 +0100)]
Add inverted permissions feature for boxes
joshuaruesweg [Thu, 4 Feb 2021 12:08:55 +0000 (13:08 +0100)]
Add support for inverted permissions with Simple ACL
Tim Düsterhus [Thu, 4 Feb 2021 11:48:06 +0000 (12:48 +0100)]
Merge pull request #3904 from WoltLab/tag-to-object-languageID
Clean up wcf1_tag_to_object
Tim Düsterhus [Thu, 4 Feb 2021 10:32:46 +0000 (11:32 +0100)]
Merge pull request #3928 from WoltLab/deprecated-updateStyleFile
Deprecate StyleUtil::updateStyleFile()
Tim Düsterhus [Wed, 3 Feb 2021 16:40:37 +0000 (17:40 +0100)]
Explicitely configure `printWidth: 120` for Prettier
Matthias Schmidt [Wed, 3 Feb 2021 15:13:04 +0000 (16:13 +0100)]
Merge branch '5.3'
Matthias Schmidt [Wed, 3 Feb 2021 15:12:48 +0000 (16:12 +0100)]
Tim Düsterhus [Wed, 3 Feb 2021 15:08:44 +0000 (16:08 +0100)]
Merge pull request #3929 from WoltLab/style-compiler
Clean up StyleCompiler
Tim Düsterhus [Wed, 3 Feb 2021 14:46:01 +0000 (15:46 +0100)]
Remove redundant wcfFontFamily generation for ACP style
Tim Düsterhus [Wed, 3 Feb 2021 14:43:35 +0000 (15:43 +0100)]
Fix the use of Google fonts in StyleCompiler
Tim Düsterhus [Wed, 3 Feb 2021 13:42:32 +0000 (14:42 +0100)]
Use a `/*!` comment for the CSS header
This change stops the `Compressed` formatter from removing the comment,
allowing us to remove the `insertHeader()` logic which looked somewhat fragile.
Tim Düsterhus [Wed, 3 Feb 2021 13:40:35 +0000 (14:40 +0100)]
Pass SCSS instead of files + invididualScss to StyleCompiler::compileStylesheet()
Tim Düsterhus [Wed, 3 Feb 2021 13:28:39 +0000 (14:28 +0100)]
Make StyleCompiler::compileStylesheet() only compile
Tim Düsterhus [Wed, 3 Feb 2021 13:24:20 +0000 (14:24 +0100)]
Add StyleCompiler::writeCss()
Tim Düsterhus [Wed, 3 Feb 2021 13:17:50 +0000 (14:17 +0100)]
Add StyleCompiler::convertToRtl()
Tim Düsterhus [Wed, 3 Feb 2021 13:10:43 +0000 (14:10 +0100)]
Add StyleCompiler::injectHeader()
Tim Düsterhus [Wed, 3 Feb 2021 11:55:44 +0000 (12:55 +0100)]
Remove the StyleCompiler::$compiler property
State is bad. This method allows to prevent leaking compiler configuration
across multiple unrelated compilation processes.
Tim Düsterhus [Wed, 3 Feb 2021 12:43:47 +0000 (13:43 +0100)]
Make the StyleCompiler `final`
Tim Düsterhus [Wed, 3 Feb 2021 15:00:12 +0000 (16:00 +0100)]
Merge branch '5.3'
Tim Düsterhus [Wed, 3 Feb 2021 14:57:05 +0000 (15:57 +0100)]
Download Google fonts before validating the individual SCSS
The individual SCSS will compile the style and this compiled CSS will later be
used for the style itself.
When first downloading a new Google font the font will not yet be available
during this test, thus the necessary CSS will not be included which in turn
will cause the font to fail to display.
Alexander Ebert [Wed, 3 Feb 2021 12:39:33 +0000 (13:39 +0100)]
Added missing parantheses
Stictly speaking this was a bug, but based on how the HTML is laid out, it will never cause any unexpected side effects. Fixing this for the sake of code clarity.
Tim Düsterhus [Wed, 3 Feb 2021 11:23:25 +0000 (12:23 +0100)]
Deprecate StyleUtil::updateStyleFile()
Resolves #3927
Tim Düsterhus [Wed, 3 Feb 2021 10:03:20 +0000 (11:03 +0100)]
Add explicit parentheses around mixed boolean operators in BooleanUserGroupOptionType
see #3926
Tim Düsterhus [Wed, 3 Feb 2021 10:02:25 +0000 (11:02 +0100)]
Add explicit parentheses around mixed boolean operators in I18nPlural
see #3926
Tim Düsterhus [Wed, 3 Feb 2021 09:57:00 +0000 (10:57 +0100)]
Fix reference URL for Unicode plural rules
Tim Düsterhus [Wed, 3 Feb 2021 09:07:47 +0000 (10:07 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Wed, 3 Feb 2021 09:06:55 +0000 (10:06 +0100)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Wed, 3 Feb 2021 09:06:19 +0000 (10:06 +0100)]
Merge branch '3.0' into 3.1
Tim Düsterhus [Wed, 3 Feb 2021 08:18:31 +0000 (09:18 +0100)]
Fix typo in phrases
Matthias Schmidt [Tue, 2 Feb 2021 14:22:52 +0000 (15:22 +0100)]
Support changing moderation queue status of closed entries (#3924)
Close #3227
Matthias Schmidt [Tue, 2 Feb 2021 12:28:26 +0000 (13:28 +0100)]
Merge branch '5.3'
Matthias Schmidt [Tue, 2 Feb 2021 12:26:39 +0000 (13:26 +0100)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Tue, 2 Feb 2021 12:26:09 +0000 (13:26 +0100)]
Ignore name of primary keys during creation (#3921)
Tim Düsterhus [Tue, 2 Feb 2021 11:19:25 +0000 (12:19 +0100)]
Merge pull request #3918 from WoltLab/exporter-init
Initialize the exporter only once in ImportWorker
Tim Düsterhus [Tue, 2 Feb 2021 10:39:44 +0000 (11:39 +0100)]
Fix bad merge / codestyle
When resolving the conflict in UserAvatarAction due to
621a83b075404f408dd025dfdc2cc55a43466536 it was forgotten to add the leading
backslash.
Tim Düsterhus [Tue, 2 Feb 2021 10:33:23 +0000 (11:33 +0100)]
Merge branch '5.3'
Tim Düsterhus [Tue, 2 Feb 2021 10:31:21 +0000 (11:31 +0100)]
Make 5.4_session_3_migrate_session.php idempotent
Fixes #3923
Marcel Werk [Tue, 2 Feb 2021 10:28:22 +0000 (11:28 +0100)]
Long file name caused SQL error
Alexander Ebert [Mon, 1 Feb 2021 12:07:47 +0000 (13:07 +0100)]
Release 5.3.4
Alexander Ebert [Mon, 1 Feb 2021 12:04:25 +0000 (13:04 +0100)]
Merge branch '5.2' into 5.3
Alexander Ebert [Mon, 1 Feb 2021 12:00:53 +0000 (13:00 +0100)]
Release 5.2.12
Alexander Ebert [Mon, 1 Feb 2021 11:59:33 +0000 (12:59 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 1 Feb 2021 11:56:07 +0000 (12:56 +0100)]
Release 3.1.20
Alexander Ebert [Mon, 1 Feb 2021 11:55:02 +0000 (12:55 +0100)]
Merge branch '3.0' into 3.1
Tim Düsterhus [Mon, 1 Feb 2021 11:54:02 +0000 (12:54 +0100)]
Merge branch '5.3'
Alexander Ebert [Mon, 1 Feb 2021 11:50:17 +0000 (12:50 +0100)]
Release 3.0.26
Alexander Ebert [Mon, 1 Feb 2021 11:48:01 +0000 (12:48 +0100)]
Merge branch '5.2' into 5.3
Alexander Ebert [Mon, 1 Feb 2021 11:47:42 +0000 (12:47 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 1 Feb 2021 11:47:24 +0000 (12:47 +0100)]
Merge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:47:09 +0000 (12:47 +0100)]
Missing check for accessible user groups
Alexander Ebert [Mon, 1 Feb 2021 11:38:59 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1
Alexander Ebert [Mon, 1 Feb 2021 11:38:49 +0000 (12:38 +0100)]
Notify users of the expiring support
Alexander Ebert [Mon, 1 Feb 2021 11:38:11 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1
Tim Düsterhus [Fri, 16 Oct 2020 11:57:29 +0000 (13:57 +0200)]
Ignore top-level node_modules/
Tim Düsterhus [Mon, 1 Feb 2021 10:54:13 +0000 (11:54 +0100)]
Merge branch '5.3'
Tim Düsterhus [Mon, 1 Feb 2021 10:50:35 +0000 (11:50 +0100)]
Merge pull request #3920 from WoltLab/http-request-proxy
Fix HTTPRequest with proxies
Tim Düsterhus [Mon, 1 Feb 2021 10:37:09 +0000 (11:37 +0100)]
Stream HTTPRequest responses only of a maximum length is desired
cURL is not supported for streaming responses. As we process the full response
body for requests without a maximum length there is no benefit to streaming the
response, because we lose cURL support.
Tim Düsterhus [Mon, 1 Feb 2021 10:34:50 +0000 (11:34 +0100)]
Update Guzzle
see guzzle/guzzle#2848
see guzzle/guzzle#2850
Alexander Ebert [Fri, 29 Jan 2021 19:03:38 +0000 (20:03 +0100)]
Merge pull request #3917 from WoltLab/cover-photo-webp-thumbnail
WebP support for cover photos