Leo Kim [Thu, 29 Oct 2015 02:58:32 +0000 (11:58 +0900)]
staging: wilc1000: rename hSemGetCHNL of struct host_if_drv
This patch renames hSemGetCHNL of struct host_if_drv to sem_get_chnl
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:31 +0000 (11:58 +0900)]
staging: wilc1000: rename hSemGetLINKSPEED of struct host_if_drv
This patch renames hSemGetLINKSPEED of struct host_if_drv to sem_get_link_speed
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:30 +0000 (11:58 +0900)]
staging: wilc1000: rename hSemGetRSSI of struct host_if_drv
This patch renames hSemGetRSSI of struct host_if_drv to sem_get_rssi
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:29 +0000 (11:58 +0900)]
staging: wilc1000: rename hSemTestDisconnectBlock of struct host_if_drv
This patch renames hSemTestDisconnectBlock of struct host_if_drv to
sem_test_disconn_block to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:28 +0000 (11:58 +0900)]
staging: wilc1000: rename hSemTestKeyBlock of struct host_if_drv
This patch renames hSemTestKeyBlock of struct host_if_drv to sem_test_key_block
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:27 +0000 (11:58 +0900)]
staging: wilc1000: rename gtOsCfgValuesSem of struct host_if_drv
This patch renames gtOsCfgValuesSem of struct host_if_drv to sem_cfg_values
to avoid CamelCase naming convention.
And, remove the relation comment.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:26 +0000 (11:58 +0900)]
staging: wilc1000: rename strCfgValues of struct host_if_drv
This patch renames strCfgValues of struct host_if_drv to cfg_values
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:25 +0000 (11:58 +0900)]
staging: wilc1000: rename au8AssociatedBSSID of struct host_if_drv
This patch renames au8AssociatedBSSID of struct host_if_drv to assoc_bssid
to avoid CamelCase naming convention.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Thu, 29 Oct 2015 02:58:24 +0000 (11:58 +0900)]
staging: wilc1000: rename enuHostIFstate of struct host_if_drv
This patch renames enuHostIFstate of struct host_if_drv to hif_state
to avoid CamelCase naming convention.
And, some comments modification that has been included name 'enuHostIFstate'.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Fri, 30 Oct 2015 06:48:56 +0000 (12:18 +0530)]
staging: wilc1000: Remove inclusion of version.h
version.h header inclusion is not necessary as detected by versioncheck.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ciornei [Sun, 1 Nov 2015 14:38:23 +0000 (16:38 +0200)]
staging: android: remove multiple blank lines
This patch removes multiple blank lines in order to follow
the linux kernel coding style.
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ciornei [Sun, 1 Nov 2015 14:38:22 +0000 (16:38 +0200)]
staging: android: properly align function arguments
Fix alingment issues by properly indenting function arguments
in accordance with the kernel coding style.
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ciornei [Sun, 1 Nov 2015 14:38:21 +0000 (16:38 +0200)]
staging: android: replace uint32_t with u32
This patch makes use of the preferred kernel types such
as u16, u32.
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ioana Ciornei [Sun, 1 Nov 2015 14:38:20 +0000 (16:38 +0200)]
staging: android: replace explicit NULL comparison
This patch replaces explicit NULL comparison with !
operator in order to simplify the code
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 1 Nov 2015 06:04:40 +0000 (11:34 +0530)]
Staging: fwserial: Remove unused fwtty_bind_console from header
fwtty_bind_console is defined in header file but not used.
Thus remove the definition.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 14:52:03 +0000 (20:22 +0530)]
staging: rtl8192e: Remove unnecessary variable
This patch removes unnecessary variable by using a single line of code
instead.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 14:49:40 +0000 (20:19 +0530)]
staging: rtl8712: rtl871x_mlme: Remove wrapper function
Remove wrapper function free_network_nolock() that can be replaced by a single line of code.
This patch renames _free_network_nolock() function to free_network_nolock().
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amarjargal Gundjalam [Sat, 31 Oct 2015 08:56:41 +0000 (01:56 -0700)]
staging: media: bcm2048: fix mispelling
This patch fixes the checkpatch issue:
CHECK: 'Syncronize' may be misspelled - perhaps 'Synchronize'?
Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amarjargal Gundjalam [Sat, 31 Oct 2015 08:56:40 +0000 (01:56 -0700)]
staging: media: bcm2048: remove unnecessary space after a cast
This patch fixes the checkpatch issue:
CHECK: No space is necessary after a cast
Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amarjargal Gundjalam [Sat, 31 Oct 2015 08:56:39 +0000 (01:56 -0700)]
staging: media: bcm2048: remove unnecessary blank lines
This patch fixes the checkpatch issues:
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amarjargal Gundjalam [Sat, 31 Oct 2015 08:56:38 +0000 (01:56 -0700)]
staging: media: bcm2048: add space around operators
This patch fixes the checkpatch issue:
CHECK: spaces preferred around that ' '
Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amarjargal Gundjalam [Sat, 31 Oct 2015 08:56:37 +0000 (01:56 -0700)]
staging: media: bcm2048: match alignments with open parenthesis
This patch fixes the checkpatch issue:
CHECK: Alignment should match open parenthesis
Signed-off-by: Amarjargal Gundjalam <amarjargal.gundjalam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 16:23:03 +0000 (21:53 +0530)]
Staging: wlan-ng: Remove unused function declaration
Function p80211wext_event_associated has been declared but not used.
Thus remove the declaration.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 10:19:29 +0000 (15:49 +0530)]
staging: wlan-ng: prism2mib: Remove unnecessary variable
Drop unnecessary variable that can be replaced by a single line of
code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 10:17:38 +0000 (15:47 +0530)]
staging: wlan-ng: hfa384x_usb: Remove wrapper function
Remove wrapper function that can be replaced by a single line of code.
As a result of the change, there is an unused variable which has also
been removed in this patch.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 10:21:04 +0000 (15:51 +0530)]
staging: wlan-ng: Remove wrapper function
Remove wrapper function that can be replaced by a single line of code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 14:03:03 +0000 (19:33 +0530)]
Staging: dgnc: Remove unused #include header file
Since the things defined by digi.h are not used in dgnc_utils.c,
remove the header from this file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 14:03:02 +0000 (19:33 +0530)]
Staging: sm750fb: Remove unused modedb.h file
The header file modedb.h is only included in sm750.c but the things
defined by modedb.h are not used anywhere in sm750.c. Thus, drop
the include in sm750.c and modedb.h can be dropped completely.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Fri, 30 Oct 2015 01:01:01 +0000 (04:01 +0300)]
staging: octeon: Add space around '+'
Add space around operator '+'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 20:59:03 +0000 (02:29 +0530)]
staging: gdm724x: Remove wrapper function
Remove wrapper function that can be replaced by a single line of code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Thu, 29 Oct 2015 23:49:01 +0000 (02:49 +0300)]
staging: nvec: Add space around '<<'
Add space around operator '<<'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Fri, 30 Oct 2015 00:04:03 +0000 (03:04 +0300)]
staging: nvec: Add space around '>>'
Add space around operator '>>'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '>>' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Fri, 30 Oct 2015 00:29:08 +0000 (03:29 +0300)]
staging: nvec:Misspelled the word
Word error correction.Problem found using checkpatch.pl
CHECK: 'Implemenation' may be misspelled - perhaps 'Implementation'?
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Thu, 29 Oct 2015 20:43:41 +0000 (13:43 -0700)]
Staging: rtl8723au: Declare function static
Declare function Efuse_ReadAllMap as static since it's defined and used
only in this file.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Thu, 29 Oct 2015 20:42:38 +0000 (13:42 -0700)]
Staging: rtl8723au: Remove unused EFUSE_Write1Byte function
Function is defined but not used, so remove it.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Thu, 29 Oct 2015 15:54:06 +0000 (18:54 +0300)]
staging: vt6656: Do not use multiple blank lines.
Remove multiple blank lines. Problem found using checkpatch.pl
"CHECK: Please don't use multiple blank lines"
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sun, 1 Nov 2015 10:48:18 +0000 (16:18 +0530)]
staging: rdma: hfi1: chip: Remove wrapper function
Drop wrapper function remap_receive_available_interrupt() that wraps a
call to remap_intr() with the only difference being the addition of
macro IS_RCVAVAIL_START to the second argument of remap_intr().
Both the function names give the same information so the wrapper
function can be dropped.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sun, 1 Nov 2015 10:46:40 +0000 (16:16 +0530)]
staging: rdma: hfi1: sdma: Remove wrapper functions
Drop wrapper functions sdma_start_err_halt_wait() and
sdma_start_sw_clean_up() that can be replaced by a direct call to
schedule_work() and tasklet_hi_schedule() respectively both of which
are standard kernel functions.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sun, 1 Nov 2015 10:44:32 +0000 (16:14 +0530)]
staging: rdma: hfi1: Remove hfi1_nomsix() wrapper function
This patch removes hfi1_nomsix() wrapper function that is used to wrap
pci_disable_msix() and so substituted the wrapper function by a direct
call to pci_disable_msix().
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 20:15:13 +0000 (01:45 +0530)]
staging: rdma: amso1100: Remove extern from function declarations
Functions have the extern specifier by default, so this keyword can be
removed.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 08:05:06 +0000 (13:35 +0530)]
staging: rdma: hfi1: Remove unnecessary variable
Drop unnecessary variable that can be replaced by a single line of
code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 08:03:45 +0000 (13:33 +0530)]
staging: rdma: amso1100: Remove unnecessary variable
Drop unnecessary variable that can be replaced by single line of code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 11:04:06 +0000 (16:34 +0530)]
staging: rtl8188eu: core: Change function parameter to bool
Change int wait_ack to bool wait_ack as it only takes true or false as its argument.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 06:22:35 +0000 (11:52 +0530)]
staging: rtl8188eu: core: Remove wrapper function
Remove wrapper function issue_probereq() that can be replaced by a
single line of code and rename _issue_probereq() to issue_probereq().
This patch also fixes line over 80 characters checkpatch.pl warning.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 06:18:39 +0000 (11:48 +0530)]
staging: rtl8188eu: Remove unused function
Remove function that is declared but not called anywhere.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 06:17:03 +0000 (11:47 +0530)]
staging: rtl8188eu: core: rtw_ap : Remove unnecessary functions
Drop unnecessary functions that are declared but not being used.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sun, 1 Nov 2015 11:08:08 +0000 (14:08 +0300)]
staging: gdm72xx:Add space around '<<'
Add space around operator '<<'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sat, 31 Oct 2015 22:56:52 +0000 (01:56 +0300)]
staging: gdm72xx: Add space around '>>'
Add space around operator '>>'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '>>' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sat, 31 Oct 2015 22:56:51 +0000 (01:56 +0300)]
staging: gdm72xx: Add space around '/'
Add space around operator '/'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '/' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sat, 31 Oct 2015 22:56:50 +0000 (01:56 +0300)]
staging: gdm72xx: Add space around '+'
Add space around operator '+'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sat, 31 Oct 2015 22:56:49 +0000 (01:56 +0300)]
staging: gdm72xx: Add space around '-'
Add space around operator '-'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Burcin Akalin [Sat, 31 Oct 2015 22:56:48 +0000 (01:56 +0300)]
staging: gdm72xx: Add space around '&'
Add space around operator '&'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '&' (ctx:VxV)
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 29 Oct 2015 20:42:16 +0000 (02:12 +0530)]
staging: gdm72xx: Remove wrapper function
Remove wrapper function that can be replaced by a single line of code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 31 Oct 2015 14:55:29 +0000 (20:25 +0530)]
staging: rtl8192u: Remove unnecessary function
This patch solves two problems.
The function rtl8192_CalculateBitShift() had an unnecessary variable i
that could be removed by using a single line of code.
After this change, rtl8192_CalculateBitShift() becomes a wrapper
function, so the rtl8192_CalculateBitShift() function has been removed
completely to replace it with a single line of code.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Thu, 29 Oct 2015 01:59:55 +0000 (18:59 -0700)]
Staging: rtl8192u: Remove unused function
Function rtl8192_try_wake_queue is defined but not used, so remove it.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 18:59:43 +0000 (00:29 +0530)]
Staging: lustre: tracefile: Remove wrapper function
Remove the function cfs_trace_put_console_buffer() as it is no longer
required.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 18:59:22 +0000 (00:29 +0530)]
Staging: lustre: tracefile: Replace function calls
Replace the calls of function cfs_trace_put_console_buffer() with
put_cpu() as former is just a wrapper for latter.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 17:49:55 +0000 (23:19 +0530)]
Staging: lustre: linux-cpu: Remove unnecessary wrapper function
Remove the function cfs_node_to_cpumask() and replace all its calls with
the function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 17:49:34 +0000 (23:19 +0530)]
Staging: lustre: linux-cpu: Drop wrapper function
Remove the function cfs_cpu_ht_siblings() and replace all its calls with
the function it wrapped.
Siigned-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 17:49:13 +0000 (23:19 +0530)]
Staging: lustre: linux-cpu: Remove wrapper function
Remove the function cfs_cpu_core_siblings() and replace its calls with
the function it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Mon, 2 Nov 2015 17:25:36 +0000 (22:55 +0530)]
Staging: lustre: linux-crypto-adler: Drop wrapper function
Remove the function __adler32() and replace its calls with the function
it wrapped.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 1 Nov 2015 11:36:32 +0000 (17:06 +0530)]
Staging: lustre: libcfs: Remove unused functions
The functions cfs_hash_bd_findadd_locked and cfs_hash_bd_finddel_locked
are not used anywhere. Thus remove these functions.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 1 Nov 2015 11:36:34 +0000 (17:06 +0530)]
Staging: lustre: obdclass: Declare local function cl_lock_mutex_try as static
Function cl_lock_mutex_try has been used only in this particular file.
Thus declare the function as static.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 1 Nov 2015 11:36:33 +0000 (17:06 +0530)]
Staging: lustre: ptlrpc: Remove unused function declarations
Functions ptlrpc_handle_failed_import and ptlrpc_lprocfs_do_request_stat
have been declared but not used. Thus drop the declarations.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 1 Nov 2015 06:51:37 +0000 (12:21 +0530)]
Staging: lustre: lnet: Remove typedef srpc_server_rpc_t
The Linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
srpc_server_rpc_t.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 29 Oct 2015 21:35:22 +0000 (17:35 -0400)]
staging: lustre: place linux header first in hash.c
Always place linux headers first in libcfs header files.
This avoid can potential build issues if any changes to
a libcfs header land that starts using a linux header
definition.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 29 Oct 2015 21:35:21 +0000 (17:35 -0400)]
staging: lustre: remove white space in hash.c
Cleanup all the unneeded white space in hash.c.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 29 Oct 2015 21:35:19 +0000 (17:35 -0400)]
staging: lustre: move linux hash.h header to start of libcfs_hash.h
Minor style cleanup to put hash.h header to the top of the
libcfs_hash.h file.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 29 Oct 2015 21:35:18 +0000 (17:35 -0400)]
staging: lustre: remove obsolete comment in libcfs_hash.h
Remove comment hash_long which was removed long ago.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 29 Oct 2015 21:35:17 +0000 (17:35 -0400)]
staging: lustre: remove white space in libcfs_hash.h
Cleanup all the unneeded white space in libcfs_hash.h.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Sat, 31 Oct 2015 14:56:56 +0000 (20:26 +0530)]
Staging: lustre: Drop wrapper functions
Remove the functions node_equal() and node_compare() and replace their
calls with appropriate functions.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:46 +0000 (15:58 +0530)]
Staging: lustre: mdc: Remove unused declarations
The functions mdc_pack_req and mdc_getxattr_pack have been
declared in header file but not used. Thus remove the
declarations.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:45 +0000 (15:58 +0530)]
Staging: lustre: lov: Declare local functions as static
Declare functions lov_set_add_req, lov_set_finished, lov_update_set,
lov_check_and_wait_active and lov_update_statfs as static since
they are used only in this particular file. Also remove corresponding
declarations from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:44 +0000 (15:58 +0530)]
Staging: lustre: lov: Remove unused function declarations
These functions have been declared in header but not used anywhere.
Thus drop the declarations.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:43 +0000 (15:58 +0530)]
Staging: lustre: lmv: Declare local functions as static
Declare functions lmv_intent_open and lmv_intent_lookup as static
since they are used only in this particular file. Also remove
corresponding declarations from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:42 +0000 (15:58 +0530)]
Staging: lustre: lmv: Remove unused function declaration
The function lmv_blocking_ast is declared in header file but not used.
Hence remove the declaration.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 31 Oct 2015 10:28:41 +0000 (15:58 +0530)]
Staging: lustre: lclient: Remove wrapper functions
The functions cl_isize_lock and cl_isize_unlock can be replaced with
direct calls to ll_inode_size_lock and ll_inode_size_unlock. Thus
drop the wrapper functions.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:09 +0000 (20:59 +0530)]
Staging: lustre: osc: Declare local functions as static
Declare osc_real_create, osc_create and osc_cleanup as static
since they are used only in this particular file. Also remove the
corresponding declarations from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:08 +0000 (20:59 +0530)]
Staging: lustre: fld: Remove unused declaration
Function fld_dump_cache_entries is declared in header file but not used.
Hence remove the declaration.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:07 +0000 (20:59 +0530)]
Staging: lustre: fld: Remove unused functions
Remove functions fld_cache_delete and fld_cache_delete_nolock
since they are defined but not used.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:06 +0000 (20:59 +0530)]
Staging: lustre: fld: Declare local functions as static
Declare fld_cache_entry_delete and fld_cache_insert_nolock as static
since they are used only in this particular file. Also remove
corresponding declarations from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:05 +0000 (20:59 +0530)]
Staging: lustre: fld: Remove unused seq_client_alloc_super
Remove function seq_client_alloc_super since it is defined but not used.
Also remove corresponding declaration from header file.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:04 +0000 (20:59 +0530)]
Staging: lustre: mdc: Remove unused mdc_open function from header
Function mdc_open is declared in header file but it is not used anywhere.
Hence drop the declaration.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 30 Oct 2015 15:29:03 +0000 (20:59 +0530)]
Staging: lustre: mdc: Declare local functions as static
Declare mdc_get_lustre_md, mdc_free_lustre_md and
mdc_clear_open_replay_data as static since they are used only
in this particular file. Also remove corresponding declarations
from header files.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Thu, 29 Oct 2015 13:51:23 +0000 (16:51 +0300)]
staging: lustre: potential underflow in libcfs_kkuc_group_add()
My static checker says that "group" is a user controlled number that can
be negative leading to an array underflow. I have looked at it, and I'm
not an expert enough in lustre to say for sure if it is really a bug.
Anyway, it's simple enough to make the variable unsigned which pleases
the static checker and makes it easier to audit.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Thu, 29 Oct 2015 09:26:36 +0000 (12:26 +0300)]
staging: lustre: remove m_ prefix from function pointers
All the callers call these function pointers without the "m_" prefix and
use macro magic to add it later behind the scenes. It means that you
can't grep for the call sites. I considered modifying the call sites
but in the end I decided that the "m_" prefix doesn't add anything so we
can just get rid of it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Thu, 29 Oct 2015 09:24:40 +0000 (12:24 +0300)]
staging: lustre: remove o_ prefix from function pointers
We mostly refer to these function pointers using macros that use macro
magic to add the "o_" prefix to the front. It means that you can't use
cscope to find the caller. Heck, you can't even grep for it.
I looked at preserving the "o_" prefix by removing the macro magic and
adding "o_" to all the call sites but then I realized that, really, the
prefix doesn't add any value. Let's just remove it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 29 Oct 2015 13:29:14 +0000 (18:59 +0530)]
Staging: lustre: rpc: Drop unnecessary wrapper function
Remove the function srpc_post_active_rqtbuf() and replace its only call
with the function srpc_post_active_rdma() by adding appropriate parameters.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 29 Oct 2015 06:58:31 +0000 (12:28 +0530)]
Staging: lustre: config: Remove unnecessary wrapper functions
Remove the function lnet_ipaddr_free_enumeration() and replace all its
calls with LIBCFS_FREE().
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 29 Oct 2015 06:38:06 +0000 (12:08 +0530)]
Staging: lustre: api-ni: Drop unneeded wrapper function
Remove the function lnet_create_interface_cookie() and replace its call
with the function ktime_get_ns().
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 29 Oct 2015 06:20:35 +0000 (11:50 +0530)]
Staging: lustre: console: Remove irrelevant return statement
Remove return statement from the function lstcon_group_ndlink_move()
as its return type is void.
Fix checkpatch WARNING: void function return statements are not
generally useful
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shivani Bhardwaj [Thu, 29 Oct 2015 05:32:23 +0000 (11:02 +0530)]
Staging: lustre: console: Drop unnecessary wrapper function
Remove the function lstcon_group_put() and replace all its calls with the
function lstcon_group_decref() because the former function just
performs the job of calling the latter.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Thu, 29 Oct 2015 00:30:43 +0000 (17:30 -0700)]
Staging: lustre: Replace LPROCFS_CLIMP_EXIT with up_read
In all call sites type of argument that macro LPROCFS_CLIMP_EXIT
use is the same, so replace it with up_read function.
Also remove the macro since it's no longer used.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 30 Oct 2015 18:10:05 +0000 (11:10 -0700)]
staging: comedi: adv_pci1710: separate out PCI-1720 support as a new driver
The PCI-1710 series boards are multifunction data acquisition boards with
analog inputs and outputs, digital inputs and outputs, and counter/timer
functions.
The PCI-1720 is a simple 4 channel analog output board. It also uses a
unique register map.
Separate out the PCI-1720 support as a new driver, adv_pci1720, to ease
maintainability.
Fix some issues with the PCI-1720 support in the new driver:
1) the registers are all 8-bit
2) remove the analog output "reset" when the driver attaches/detaches
3) disable "synchronized output" to simplify the analog outputs
4) remove the need for the private data
5) add support for the BoardID register to allow multiple cards
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Sat, 31 Oct 2015 13:36:44 +0000 (06:36 -0700)]
Staging: comedi: adl_pci9118: Fix endian sparse warning
Fix following sparse warning:
warning: cast to restricted __be16
data is pointer of type void and can be used to store any type of data.
barray and array have the same 16 bit offset.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Sat, 31 Oct 2015 13:34:29 +0000 (06:34 -0700)]
Staging: comedi: ni_mio_common: Fix endian sparse warning
Fix following sparse warnings:
warning: cast to restricted __le32
warning: cast to restricted __le16
warning: incorrect type in assignment (different base types)
expected unsigned short [unsigned] [assigned] val
got restricted __le16 [usertype] <noident>
Data is pointer of type void and can be used to store any type of data.
In function ni_ai_munge:
barray and array have the same 16 bit offset.
blarray and larray have the same 32 bit offset.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ksenija Stanojevic [Fri, 30 Oct 2015 04:58:16 +0000 (21:58 -0700)]
Staging: comedi: das16: Fix sparse endian warning
Fix following sparse warning:
warning: cast to restricted __le16
This change is safe because array is pointer of type void and can
be used to store any type of data, also offset of the array would
be the same since unsigned short and __le16 are both 16 bits in size.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linus Torvalds [Mon, 16 Nov 2015 01:00:27 +0000 (17:00 -0800)]
Linux 4.4-rc1
Linus Torvalds [Sun, 15 Nov 2015 17:36:24 +0000 (09:36 -0800)]
Merge branch 'perf-urgent-for-linus' of git://git./linux/kernel/git/tip/tip
Pull perf updates from Thomas Gleixner:
"Mostly updates to the perf tool plus two fixes to the kernel core code:
- Handle tracepoint filters correctly for inherited events (Peter
Zijlstra)
- Prevent a deadlock in perf_lock_task_context (Paul McKenney)
- Add missing newlines to some pr_err() calls (Arnaldo Carvalho de
Melo)
- Print full source file paths when using 'perf annotate --print-line
--full-paths' (Michael Petlan)
- Fix 'perf probe -d' when just one out of uprobes and kprobes is
enabled (Wang Nan)
- Add compiler.h to list.h to fix 'make perf-tar-src-pkg' generated
tarballs, i.e. out of tree building (Arnaldo Carvalho de Melo)
- Add the llvm-src-base.c and llvm-src-kbuild.c files, generated by
the 'perf test' LLVM entries, when running it in-tree, to
.gitignore (Yunlong Song)
- libbpf error reporting improvements, using a strerror interface to
more precisely tell the user about problems with the provided
scriptlet, be it in C or as a ready made object file (Wang Nan)
- Do not be case sensitive when searching for matching 'perf test'
entries (Arnaldo Carvalho de Melo)
- Inform the user about objdump failures in 'perf annotate' (Andi
Kleen)
- Improve the LLVM 'perf test' entry, introduce a new ones for BPF
and kbuild tests to check the environment used by clang to compile
.c scriptlets (Wang Nan)"
* 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (32 commits)
perf/x86/intel/rapl: Remove the unused RAPL_EVENT_DESC() macro
tools include: Add compiler.h to list.h
perf probe: Verify parameters in two functions
perf session: Add missing newlines to some pr_err() calls
perf annotate: Support full source file paths for srcline fix
perf test: Add llvm-src-base.c and llvm-src-kbuild.c to .gitignore
perf: Fix inherited events vs. tracepoint filters
perf: Disable IRQs across RCU RS CS that acquires scheduler lock
perf test: Do not be case sensitive when searching for matching tests
perf test: Add 'perf test BPF'
perf test: Enhance the LLVM tests: add kbuild test
perf test: Enhance the LLVM test: update basic BPF test program
perf bpf: Improve BPF related error messages
perf tools: Make fetch_kernel_version() publicly available
bpf tools: Add new API bpf_object__get_kversion()
bpf tools: Improve libbpf error reporting
perf probe: Cleanup find_perf_probe_point_from_map to reduce redundancy
perf annotate: Inform the user about objdump failures in --stdio
perf stat: Make stat options global
perf sched latency: Fix thread pid reuse issue
...
Linus Torvalds [Sun, 15 Nov 2015 17:35:33 +0000 (09:35 -0800)]
Merge branch 'sched-urgent-for-linus' of git://git./linux/kernel/git/tip/tip
Pull scheduler fix from Thomas Gleixner:
"A single fix to prevent math underflow in the numa balancing code"
* 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
sched/numa: Fix math underflow in task_tick_numa()